From owner-freebsd-standards@FreeBSD.ORG Sun Feb 15 21:56:33 2009 Return-Path: Delivered-To: standards@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A3A5106566B for ; Sun, 15 Feb 2009 21:56:33 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (unknown [IPv6:2001:610:150::2]) by mx1.freebsd.org (Postfix) with ESMTP id D2A7E8FC17 for ; Sun, 15 Feb 2009 21:56:32 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mx1.stack.nl (Postfix) with ESMTP id 0D71F3F91A for ; Sun, 15 Feb 2009 22:56:32 +0100 (CET) Received: by snail.stack.nl (Postfix, from userid 1677) id EEA4A2289C; Sun, 15 Feb 2009 22:56:31 +0100 (CET) Date: Sun, 15 Feb 2009 22:56:31 +0100 From: Jilles Tjoelker To: standards@freebsd.org Message-ID: <20090215215631.GA50673@stack.nl> References: <20090214135010.GB9262@zim.MIT.EDU> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090214135010.GB9262@zim.MIT.EDU> X-Operating-System: FreeBSD 7.1-PRERELEASE i386 User-Agent: Mutt/1.5.18 (2008-05-17) Cc: Subject: Re: [patch] getdelim, new string functions X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2009 21:56:33 -0000 On Sat, Feb 14, 2009 at 08:50:10AM -0500, David Schultz wrote: > This patch adds getdelim(), getline(), stpncpy(), strnlen(), > wcsnlen(), wcscasecmp(), and wcsncasecmp() (mixed in with a few > other changes that I need to factor out). Comments and reviews > would be appreciated. > http://www.freebsd.org/~das/str.diff Looks nice, I look forward to using some of these. getdelim() in particular, it is more efficient than a getc() loop and fgetln()'s lack of zero termination and nonportability are annoying. I wonder how long it will be necessary to be paranoid about the getline name. I don't like things like glibc's _GNU_SOURCE which is getting less and less optional and so loses its meaning. Of course, I can use getdelim() to avoid the problem on FreeBSD. -- Jilles Tjoelker