From owner-p4-projects@FreeBSD.ORG  Sun Feb 15 13:19:30 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id AF4E31065673; Sun, 15 Feb 2009 13:19:30 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6EF45106566B;
	Sun, 15 Feb 2009 13:19:30 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 4B50E8FC22;
	Sun, 15 Feb 2009 13:19:30 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id CFEFD46B46;
	Sun, 15 Feb 2009 08:19:29 -0500 (EST)
Date: Sun, 15 Feb 2009 13:19:29 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Stacey Son <sson@FreeBSD.org>
In-Reply-To: <200902122220.n1CMKcaK029439@repoman.freebsd.org>
Message-ID: <alpine.BSF.2.00.0902151255270.5806@fledge.watson.org>
References: <200902122220.n1CMKcaK029439@repoman.freebsd.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 157612 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Feb 2009 13:19:31 -0000


On Thu, 12 Feb 2009, Stacey Son wrote:

> http://perforce.freebsd.org/chv.cgi?CH=157612
>
> Change 157612 by sson@sson_amd64 on 2009/02/12 22:19:43
>
> 	Rewrite auditd_expire_trails() to use a TAILQ instead of an array
> 	since the assumption that you can stat a directory and look at the
> 	nlinks of the file count doesn't hold for all file systems.
>
> 	Also, if the time stamp encoded in the trail file name is valid
> 	use it instead of the mtime of the file.

With these changes, expiry of multiple trails at once now appears to work 
properly for me on FreeBSD using UFS.

Robert N M Watson
Computer Laboratory
University of Cambridge