From owner-p4-projects@FreeBSD.ORG Sun May 17 04:19:31 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 94CFC1065674; Sun, 17 May 2009 04:19:31 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A3DE106566C for ; Sun, 17 May 2009 04:19:31 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outQ.internet-mail-service.net (outq.internet-mail-service.net [216.240.47.240]) by mx1.freebsd.org (Postfix) with ESMTP id 198EC8FC0A for ; Sun, 17 May 2009 04:19:30 +0000 (UTC) (envelope-from julian@elischer.org) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id D0AF414DC5A; Sat, 16 May 2009 21:19:53 -0700 (PDT) X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38]) by idiom.com (Postfix) with ESMTP id 5E9B42D6006; Sat, 16 May 2009 21:19:30 -0700 (PDT) Message-ID: <4A0F9052.1040302@elischer.org> Date: Sat, 16 May 2009 21:19:30 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302) MIME-Version: 1.0 To: Marko Zec References: <200905161449.n4GEnR0a018561@repoman.freebsd.org> In-Reply-To: <200905161449.n4GEnR0a018561@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Perforce Change Reviews Subject: Re: PERFORCE change 162162 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 May 2009 04:19:32 -0000 Marko Zec wrote: > http://perforce.freebsd.org/chv.cgi?CH=162162 > > Change 162162 by zec@zec_tpx32 on 2009/05/16 14:48:26 > > Reduce churn in struct vnet, thereby the diff against head. > > Affected files ... > > .. //depot/projects/vimage-commit2/src/sys/net/vnet.h#18 edit > > Differences ... > > ==== //depot/projects/vimage-commit2/src/sys/net/vnet.h#18 (text+ko) ==== > > @@ -36,29 +36,28 @@ > #include > > struct vnet_net { > + int _if_index; > + struct ifindex_entry * _ifindex_table; > struct ifnethead _ifnet; > struct ifgrouphead _ifg_head; > > - struct ifnet * _loif; > - LIST_HEAD(, lo_softc) _lo_list; > + int _if_indexlim; > + struct knlist _ifklist; > > + struct rtstat _rtstat; > struct radix_node_head *_rt_tables[RT_MAXFIBS][AF_MAX+1]; > - struct rtstat _rtstat; > int _rttrash; > uma_zone_t _rtzone; > > - struct ifindex_entry * _ifindex_table; > - int _if_index; > - int _if_indexlim; > - struct knlist _ifklist; > + struct ifnet * _loif; > + LIST_HEAD(, lo_softc) _lo_list; > + struct if_clone * _lo_cloner; > > - struct if_clone * _lo_cloner; > + LIST_HEAD(, rawcb) _rawcb_list; > > LIST_HEAD(, if_clone) _if_cloners; > int _if_cloners_count; > > - LIST_HEAD(, rawcb) _rawcb_list; > - > int _ether_ipfw; > }; > > @@ -79,22 +78,22 @@ > > #define VNET_NET(sym) VSYM(vnet_net, sym) > > -#define V_ether_ipfw VNET_NET(ether_ipfw) > -#define V_if_cloners VNET_NET(if_cloners) > -#define V_if_cloners_count VNET_NET(if_cloners_count) > -#define V_if_index VNET_NET(if_index) > -#define V_if_indexlim VNET_NET(if_indexlim) > -#define V_ifg_head VNET_NET(ifg_head) > -#define V_ifindex_table VNET_NET(ifindex_table) > -#define V_ifklist VNET_NET(ifklist) > -#define V_ifnet VNET_NET(ifnet) > -#define V_lo_list VNET_NET(lo_list) > -#define V_lo_cloner VNET_NET(lo_cloner) > -#define V_loif VNET_NET(loif) > -#define V_rawcb_list VNET_NET(rawcb_list) > -#define V_rt_tables VNET_NET(rt_tables) > -#define V_rtstat VNET_NET(rtstat) > -#define V_rttrash VNET_NET(rttrash) > -#define V_rtzone VNET_NET(rtzone) > +#define V_ether_ipfw VNET_NET(ether_ipfw) > +#define V_if_index VNET_NET(if_index) > +#define V_if_indexlim VNET_NET(if_indexlim) > +#define V_if_cloners VNET_NET(if_cloners) > +#define V_if_cloners_count VNET_NET(if_cloners_count) > +#define V_ifg_head VNET_NET(ifg_head) > +#define V_ifindex_table VNET_NET(ifindex_table) > +#define V_ifklist VNET_NET(ifklist) > +#define V_ifnet VNET_NET(ifnet) > +#define V_lo_cloner VNET_NET(lo_cloner) > +#define V_lo_list VNET_NET(lo_list) > +#define V_loif VNET_NET(loif) > +#define V_rawcb_list VNET_NET(rawcb_list) > +#define V_rt_tables VNET_NET(rt_tables) > +#define V_rtstat VNET_NET(rtstat) > +#define V_rttrash VNET_NET(rttrash) > +#define V_rtzone VNET_NET(rtzone) > I prefer the other tabbing.. why not commit nice tabbing to svn as a separate fix :-) > #endif /* !_NET_VNET_H_ */