From owner-svn-src-head@FreeBSD.ORG Sun May 3 00:21:47 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1AAF106566C; Sun, 3 May 2009 00:21:47 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 5FDA08FC0C; Sun, 3 May 2009 00:21:47 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id n430Kvqt030778; Sat, 2 May 2009 18:20:57 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 02 May 2009 18:21:03 -0600 (MDT) Message-Id: <20090502.182103.-895882057.imp@bsdimp.com> To: mav@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <49FCC404.6090105@FreeBSD.org> References: <200905012143.n41Lh4uS054073@svn.freebsd.org> <20090502.153808.-896932641.imp@bsdimp.com> <49FCC404.6090105@FreeBSD.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191733 - in head/sys: amd64/isa isa X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 May 2009 00:21:48 -0000 In message: <49FCC404.6090105@FreeBSD.org> Alexander Motin writes: : M. Warner Losh wrote: : > : Author: mav : > : Date: Fri May 1 21:43:04 2009 : > : New Revision: 191733 : > : URL: http://svn.freebsd.org/changeset/base/191733 : > : : > : Log: : > : Add resume methods to i8254 and atrtc devices. : > : > This likely obviates the need for pmtimer.c now. You might want to : > investigate... : : Yes, I have seen it. : : > : Modified: : > : head/sys/amd64/isa/clock.c : > : head/sys/isa/atrtc.c : > : > Shouldn't there be one for i386 too? : : For i386 it is done by pmtimer now (that's why I haven't done it there), : but there is no pmtimer driver for amd64. Actually both ways are not so : perfect, as both restore timer interrupts quite late on resume process. Yes. That's a problem... : In my case it is not fatal as i8254 is anyway ticking by default, just : slower. But it seems to increase my system resume time to 10 seconds : instead of usual 4-5. May be we should somehow enforce order of device : resuming, or build some special event timers control infrastructure : alike to PIC one. There's some work to do multi-pass probe/attach. Perhaps it should be generalized to do suspend/resume as well... : Also, except restoring clocks interrupts, pmtimer restores system time : on wakeup. For amd64 it is implemented in MD resume code now. We should : decide which way to go. I don't very like pmtimer approach, as there is : no any newbus relations between it and i8254/atrtc drivers. pmtimer should likely die, or at least be only used by APM. It was a hack that was tuned to APM and never really updated for ACPI... Warner