From owner-cvs-src@FreeBSD.ORG Tue Aug 3 22:51:51 2010 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15B19106566C; Tue, 3 Aug 2010 22:51:51 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id E2E188FC1C; Tue, 3 Aug 2010 22:51:50 +0000 (UTC) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id 7D00B46B35; Tue, 3 Aug 2010 18:51:50 -0400 (EDT) Date: Tue, 3 Aug 2010 23:51:50 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Attilio Rao In-Reply-To: <200711142121.lAELLmo4018474@repoman.freebsd.org> Message-ID: References: <200711142121.lAELLmo4018474@repoman.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: alfred@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_rwlock.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2010 22:51:51 -0000 On Wed, 14 Nov 2007, Attilio Rao wrote: > attilio 2007-11-14 21:21:48 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_rwlock.c > Log: > Remove a bogus KASSERT which will prevent rwlock to be acquired > recursively in exclusive mode with debugging kernels. > > Submitted by: kmacy > Approved by: jeff > > Revision Changes Path > 1.30 +0 -3 src/sys/kern/kern_rwlock.c Hi Attilio-- This bug seems also to affect the 6.x backport of rwlocks that Alfred did. Might either you or Alfred consider doing an MFC of this change? Without it, recursive write locks on rwlocks are broken with INVARIANTS enabled. Thanks, Robert