From owner-cvs-src-old@FreeBSD.ORG Sun Dec 12 00:07:52 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B19B7106567A for ; Sun, 12 Dec 2010 00:07:52 +0000 (UTC) (envelope-from jilles@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 9EF898FC1B for ; Sun, 12 Dec 2010 00:07:52 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id oBC07qVa069616 for ; Sun, 12 Dec 2010 00:07:52 GMT (envelope-from jilles@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id oBC07qGl069615 for cvs-src-old@freebsd.org; Sun, 12 Dec 2010 00:07:52 GMT (envelope-from jilles@repoman.freebsd.org) Message-Id: <201012120007.oBC07qGl069615@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to jilles@repoman.freebsd.org using -f From: Jilles Tjoelker Date: Sun, 12 Dec 2010 00:07:27 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/bin/sh expand.c memalloc.c memalloc.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Dec 2010 00:07:52 -0000 jilles 2010-12-12 00:07:27 UTC FreeBSD src repository Modified files: bin/sh expand.c memalloc.c memalloc.h Log: SVN rev 216387 on 2010-12-12 00:07:27Z by jilles sh: Remove the herefd hack. The herefd hack wrote out partial here documents while expanding them. It seems unnecessary complication given that other expansions just allocate memory. It causes bugs because the stack is also used for intermediate results such as arithmetic expressions. Such places should disable herefd for the duration but not all of them do, and I prefer removing the need for disabling herefd to disabling it everywhere needed. Here documents larger than 1024 bytes will use a bit more CPU time and memory. Additionally this allows a later change to expand here documents in the current shell environment. (This is faster for small here documents but also changes behaviour.) Obtained from: dash Revision Changes Path 1.77 +0 -8 src/bin/sh/expand.c 1.34 +0 -6 src/bin/sh/memalloc.c 1.15 +0 -1 src/bin/sh/memalloc.h