From owner-freebsd-doc@FreeBSD.ORG Sun Aug 29 10:00:24 2010 Return-Path: Delivered-To: freebsd-doc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BC6FD1065698 for ; Sun, 29 Aug 2010 10:00:24 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 92A878FC17 for ; Sun, 29 Aug 2010 10:00:24 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7TA0OZP030073 for ; Sun, 29 Aug 2010 10:00:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7TA0OfP030044; Sun, 29 Aug 2010 10:00:24 GMT (envelope-from gnats) Resent-Date: Sun, 29 Aug 2010 10:00:24 GMT Resent-Message-Id: <201008291000.o7TA0OfP030044@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-doc@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "N.J. Mann" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A878A1065670 for ; Sun, 29 Aug 2010 09:59:15 +0000 (UTC) (envelope-from njm@njm.me.uk) Received: from smtp003.apm-internet.net (smtp003.apm-internet.net [85.119.248.52]) by mx1.freebsd.org (Postfix) with SMTP id 20EE38FC1E for ; Sun, 29 Aug 2010 09:59:14 +0000 (UTC) Received: (qmail 33175 invoked from network); 29 Aug 2010 09:32:33 -0000 Received: from unknown (HELO oberon.njm.me.uk) (86.148.212.219) by smtp003.apm-internet.net with SMTP; 29 Aug 2010 09:32:33 -0000 Received: from titania.njm.me.uk (titania.njm.me.uk [192.168.144.130]) by oberon.njm.me.uk (8.14.4/8.14.4) with ESMTP id o7T9WXe5090623 for ; Sun, 29 Aug 2010 10:32:33 +0100 (BST) (envelope-from njm@oberon.njm.me.uk) Received: from titania.njm.me.uk (localhost [127.0.0.1]) by titania.njm.me.uk (8.14.4/8.14.4) with ESMTP id o7T9WXTi070188 for ; Sun, 29 Aug 2010 10:32:33 +0100 (BST) (envelope-from njm@titania.njm.me.uk) Received: (from njm@localhost) by titania.njm.me.uk (8.14.4/8.14.4/Submit) id o7T9WWSN070156; Sun, 29 Aug 2010 10:32:32 +0100 (BST) (envelope-from njm) Message-Id: <201008290932.o7T9WWSN070156@titania.njm.me.uk> Date: Sun, 29 Aug 2010 10:32:32 +0100 (BST) From: "N.J. Mann" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: docs/150082: [patch] gsched.8 fixes for errors in EXAMPLES section X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "N.J. Mann" List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Aug 2010 10:00:24 -0000 >Number: 150082 >Category: docs >Synopsis: [patch] gsched.8 fixes for errors in EXAMPLES section >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-doc >State: open >Quarter: >Keywords: >Date-Required: >Class: doc-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 29 10:00:23 UTC 2010 >Closed-Date: >Last-Modified: >Originator: N.J. Mann >Release: FreeBSD 8.1-STABLE i386 >Organization: >Environment: System: FreeBSD titania.njm.me.uk 8.1-STABLE FreeBSD 8.1-STABLE #26 r211698M: Mon Aug 23 09:07:05 BST 2010 njm@titania.njm.me.uk:/usr/obj/usr/src/sys/titania i386 >Description: In the example in the EXAMPLES section of the gsched(8) man page it begins by claiming that the example will 'create a scheduling provider for disk /dev/da0'. However, the example is actually for ad0. Also, the example uses 'geom sched insert -s rr' . There is no option 's'. This should (probably) be 'geom sched insert -a rr'. This was noted by Bruce Cran[1] when gsched was originally committed to SVN, but seems to have been ignored. [1] http://docs.freebsd.org/cgi/getmsg.cgi?fetch=0+0+archive/2010/svn-src-all/20100502.svn-src-all >How-To-Repeat: man gsched >Fix: The first patch changes /dev/da0 to /dev/ad0 so that the example is correct within itself. The second patch changes '-s rr' to '-a rr'. --- gsched.8.patch.diff begins here --- --- gsched.8.orig 2010-08-29 09:56:38.000000000 +0100 +++ gsched.8 2010-08-29 09:58:03.000000000 +0100 @@ -135,7 +135,7 @@ Exit status is 0 on success, and 1 if the command fails. .Sh EXAMPLES The following example shows how to create a scheduling provider for disk -.Pa /dev/da0 +.Pa /dev/ad0 , and how to destroy it. .Bd -literal -offset indent # Load the geom_sched module: --- gsched.8.patch.diff ends here --- --- gsched.8.patch2.diff begins here --- --- gsched.8~ 2010-08-29 09:58:03.000000000 +0100 +++ gsched.8 2010-08-29 10:16:32.000000000 +0100 @@ -143,7 +143,7 @@ # Load some scheduler classes used by geom_sched: kldload gsched_rr gsched_as # Configure device ad0 to use scheduler 'rr': -geom sched insert -s rr ad0 +geom sched insert -a rr ad0 # Now provider ad0 uses the 'rr' algorithm; # the new geom is ad0.sched. # Remove the scheduler on the device: --- gsched.8.patch2.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: