From owner-freebsd-embedded@FreeBSD.ORG Mon Nov 8 04:07:35 2010 Return-Path: Delivered-To: freebsd-embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E8440106564A; Mon, 8 Nov 2010 04:07:35 +0000 (UTC) (envelope-from andy@fud.org.nz) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 64ABB8FC1E; Mon, 8 Nov 2010 04:07:35 +0000 (UTC) Received: by wyb34 with SMTP id 34so3010020wyb.13 for ; Sun, 07 Nov 2010 20:07:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.227.58.82 with SMTP id f18mr4728139wbh.12.1289187445647; Sun, 07 Nov 2010 19:37:25 -0800 (PST) Sender: andy@fud.org.nz Received: by 10.227.146.67 with HTTP; Sun, 7 Nov 2010 19:37:25 -0800 (PST) In-Reply-To: <4C0BB887.5070103@freebsd.org> References: <4C0BB887.5070103@freebsd.org> Date: Mon, 8 Nov 2010 16:37:25 +1300 X-Google-Sender-Auth: rhL9FL2lTiYOWSqPjdwYXwuuOzI Message-ID: From: Andrew Thompson To: Nathan Whitehorn Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-embedded@freebsd.org Subject: Re: Review request: iicbus_transfer_gen() repeated start support X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2010 04:07:36 -0000 On 7 June 2010 03:02, Nathan Whitehorn wrote: > I committed yesterday some changes to the iicbus_transfer() API that allow > using that interface to send messages containing repeated starts. The > attached patch implements this for the iicbus_transfer_gen() case, but I > don't have any I2C controllers that use this routine, so I can't test it. I > would much appreciate it if someone could review and test the patch for me. > -Nathan I have tested this and nothing broke. The i2c devices+drivers on my board do not use IIC_M_NOSTART or IIC_M_NOSTOP flags so couldn't verify that part of it. Andrew