From owner-freebsd-fs@FreeBSD.ORG Sun Mar 28 00:47:03 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5E30106564A for ; Sun, 28 Mar 2010 00:47:03 +0000 (UTC) (envelope-from dan.naumov@gmail.com) Received: from mail-bw0-f216.google.com (mail-bw0-f216.google.com [209.85.218.216]) by mx1.freebsd.org (Postfix) with ESMTP id 6700D8FC08 for ; Sun, 28 Mar 2010 00:47:03 +0000 (UTC) Received: by bwz8 with SMTP id 8so3922217bwz.3 for ; Sat, 27 Mar 2010 17:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:received:message-id :subject:from:to:content-type; bh=z3fCglnTMYsOu+0WAmpfNu/x5xYVPW2ztEe66TP4WQw=; b=B99L82tXoz2oLsoPEh/b81vYUbDnwOpFWVeHS/DdNixXn81RNxTlZl+8D5LW5Bjely c1J7d433QVwIYPGWnGAQrsLa4JDHbVP1UybQ2bbVnkcTBwzCIi0/DWLZ3oFfXMxDNOVF pw2pBAZw1FjNJnfrN5Bxw6MFKgtL8cgFvSCVk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=urjVZ1fUkbKgjfcUxYyCLNzVZmBD1S9pY3DJfE3qTOpak3uImYBn/qkYixmZBT6fg4 PNUiz310vcsbTVjYJ+JwKrfwGw94LCW1Jc/l+GyJ3wNIzOv4ANkjjA8mnOguL9PBPh+0 yKOy7gidt45DjJBz0mxhYK9+FC931Tv7RsWLY= MIME-Version: 1.0 Received: by 10.204.59.143 with HTTP; Sat, 27 Mar 2010 17:47:02 -0700 (PDT) Date: Sun, 28 Mar 2010 02:47:02 +0200 Received: by 10.204.4.139 with SMTP id 11mr1787880bkr.27.1269737222178; Sat, 27 Mar 2010 17:47:02 -0700 (PDT) Message-ID: From: Dan Naumov To: freebsd-fs@freebsd.org, ari@ish.com.au Content-Type: text/plain; charset=ISO-8859-1 Cc: Subject: RE: boot code compatibility with ZFS X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2010 00:47:03 -0000 > FreeBSD 7.1: ZFS version 6, no ZFS boot capability > FreeBSD 7.2: ZFS version 6, zfsboot only, boot from single vdev pool only > FreeBSD 7.3: ZFS version 13, zfsboot broken, no ZFS boot capability > > FreeBSD 8.0: ZFS version 13, gptzfsboot and zfsboot, boot from mirrored pool > or single vdev, RAIDZ not supported, degraded pool not supported I am not really sure what gives you the idea that booting off a degraded pool is not supported in 8.0. I have a zfsroot/boot configuration sitting on a mirror and I have tested yanking one drive at a time (resulting in a degraded pool) and booting with only 1 disk present and it worked just fine. - Sincerely, Dan Naumov From owner-freebsd-fs@FreeBSD.ORG Sun Mar 28 01:10:02 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2CCC5106564A for ; Sun, 28 Mar 2010 01:10:02 +0000 (UTC) (envelope-from ari@ish.com.au) Received: from fish.ish.com.au (eth5921.nsw.adsl.internode.on.net [59.167.240.32]) by mx1.freebsd.org (Postfix) with ESMTP id ACE1D8FC15 for ; Sun, 28 Mar 2010 01:10:01 +0000 (UTC) Received: from [10.29.62.2] (port=53563 helo=Aris-MacBook-Pro.local) by fish.ish.com.au with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1Nvh0l-0000cj-1Y; Sun, 28 Mar 2010 12:09:55 +1100 Message-ID: <4BAEAC62.4060401@ish.com.au> Date: Sun, 28 Mar 2010 12:09:54 +1100 From: Aristedes Maniatis User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.8) Gecko/20100227 Lightning/1.0b1 Thunderbird/3.0.3 MIME-Version: 1.0 To: Dan Naumov References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org Subject: Re: boot code compatibility with ZFS X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2010 01:10:02 -0000 On 28/03/10 11:47 AM, Dan Naumov wrote: >> FreeBSD 7.1: ZFS version 6, no ZFS boot capability >> FreeBSD 7.2: ZFS version 6, zfsboot only, boot from single vdev pool only >> FreeBSD 7.3: ZFS version 13, zfsboot broken, no ZFS boot capability >> >> FreeBSD 8.0: ZFS version 13, gptzfsboot and zfsboot, boot from mirrored pool >> or single vdev, RAIDZ not supported, degraded pool not supported > > I am not really sure what gives you the idea that booting off a > degraded pool is not supported in 8.0. I have a zfsroot/boot > configuration sitting on a mirror and I have tested yanking one drive > at a time (resulting in a degraded pool) and booting with only 1 disk > present and it worked just fine. > > - Sincerely, > Dan Naumov Ah, thanks for that. I just read that on one of the FreeBSD lists recently. Can't see the exact post now, but I'm happy to be wrong, perhaps that was an older limitation in a previous release. From Ali's comment, I guess we could add for the future release of 8.1: FreeBSD 8.1: ZFS version 13, gptzfsboot and zfsboot, boot from mirrored pool, RAIDZ or single vdev. Does that include RAIDZ2? I'm happy to write up my results for the wiki (although editing seems to be closed to only certain people), once I have some definitive answers for what is supported where. And hopefully there will be a 7.3p1 which restores ZFS booting ability. Regards Ari Maniatis -- --------------------------> Aristedes Maniatis ish http://www.ish.com.au Level 1, 30 Wilson Street Newtown 2042 Australia phone +61 2 9550 5001 fax +61 2 9550 4001 GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A From owner-freebsd-fs@FreeBSD.ORG Sun Mar 28 03:12:54 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 27BD4106564A for ; Sun, 28 Mar 2010 03:12:54 +0000 (UTC) (envelope-from mashtizadeh@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id D8AE68FC08 for ; Sun, 28 Mar 2010 03:12:53 +0000 (UTC) Received: by gyh3 with SMTP id 3so2700394gyh.13 for ; Sat, 27 Mar 2010 20:12:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=kH5BrWCPa3JBw3/J+VkJWw7bZbdvzb7yWUljkXbOEiI=; b=aVZO3jEzY+KRjwzs5j6XyPL85cAcz5ihBBiScb+6lKcOOLgmxqYzKKKkGaznmldHFP 6QJGeldixfPC/uzhwGWEzGwZbrhU0QiG9d2JHYua+Ozew8LqNCx7BLzi4zgKC32cTYom KC03ilJd4Va26RCkjRpjdY8R3YlAec2unJcus= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=OyeIkBlEy/W7F/CSW/hwO2X4U8u5I04RYQ2knzfbFsI5KruRTEAbkeqjN+SNkVI5zD CV3JXexOEZceltqwfkwOTrZ5fHD0NFXHJd3m+bAPhciwDVr6GKWA6pJpL6dS3pTrutSt MWqklt396qBkBAus0EDPj+HWielxPYRXQ2Zek= MIME-Version: 1.0 Received: by 10.231.171.196 with HTTP; Sat, 27 Mar 2010 20:12:52 -0700 (PDT) In-Reply-To: <4BAEAC62.4060401@ish.com.au> References: <4BAEAC62.4060401@ish.com.au> Date: Sat, 27 Mar 2010 20:12:52 -0700 Received: by 10.101.174.17 with SMTP id b17mr4259482anp.36.1269745973023; Sat, 27 Mar 2010 20:12:53 -0700 (PDT) Message-ID: <440b3e931003272012j63014342ib31d93ff2317af7e@mail.gmail.com> From: Ali Mashtizadeh To: Aristedes Maniatis Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-fs@freebsd.org, Dan Naumov Subject: Re: boot code compatibility with ZFS X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2010 03:12:54 -0000 Yes the code includes support for raidz2. On Sat, Mar 27, 2010 at 6:09 PM, Aristedes Maniatis wrote: > On 28/03/10 11:47 AM, Dan Naumov wrote: >>> >>> FreeBSD 7.1: ZFS version 6, no ZFS boot capability >>> FreeBSD 7.2: ZFS version 6, zfsboot only, boot from single vdev pool on= ly >>> FreeBSD 7.3: ZFS version 13, zfsboot broken, no ZFS boot capability >>> >>> FreeBSD 8.0: ZFS version 13, gptzfsboot and zfsboot, boot from mirrored >>> pool >>> or single vdev, RAIDZ not supported, degraded pool not supported >> >> I am not really sure what gives you the idea that booting off a >> degraded pool is not supported in 8.0. I have a zfsroot/boot >> configuration sitting on a mirror and I have tested yanking one drive >> at a time (resulting in a degraded pool) and booting with only 1 disk >> present and it worked just fine. >> >> - Sincerely, >> Dan Naumov > > Ah, thanks for that. I just read that on one of the FreeBSD lists recentl= y. > Can't see the exact post now, but I'm happy to be wrong, perhaps that was= an > older limitation in a previous release. > > From Ali's comment, I guess we could add for the future release of 8.1: > > FreeBSD 8.1: ZFS version 13, gptzfsboot and zfsboot, boot from mirrored > pool, RAIDZ or single vdev. > > Does that include RAIDZ2? > > > I'm happy to write up my results for the wiki (although editing seems to = be > closed to only certain people), once I have some definitive answers for w= hat > is supported where. And hopefully there will be a 7.3p1 which restores ZF= S > booting ability. > > > Regards > > Ari Maniatis > > > -- > --------------------------> > Aristedes Maniatis > ish > http://www.ish.com.au > Level 1, 30 Wilson Street Newtown 2042 Australia > phone +61 2 9550 5001 =C2=A0 fax +61 2 9550 4001 > GPG fingerprint CBFB 84B4 738D 4E87 5E5C =C2=A05EFA EF6A 7D2E 3E49 102A > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > --=20 Ali Mashtizadeh =D8=B9=D9=84=DB=8C =D9=85=D8=B4=D8=AA=DB=8C =D8=B2=D8=A7=D8=AF=D9=87 From owner-freebsd-fs@FreeBSD.ORG Sun Mar 28 07:06:40 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 521FF1065670 for ; Sun, 28 Mar 2010 07:06:40 +0000 (UTC) (envelope-from me@lexasoft.ru) Received: from relay.wahome.ru (relay.wahome.ru [95.211.21.141]) by mx1.freebsd.org (Postfix) with ESMTP id 17EF58FC12 for ; Sun, 28 Mar 2010 07:06:39 +0000 (UTC) Received: from mmx.lexasoft.ru (mmx.lexasoft.ru [92.241.160.6]) by relay.wahome.ru (Postfix) with ESMTP id BEE946B212E for ; Sun, 28 Mar 2010 11:03:47 +0400 (MSD) Received: from [192.168.40.138] (unknown [124.157.205.118]) by mmx.lexasoft.ru (Postfix) with ESMTPSA id 5F3CA28490; Sun, 28 Mar 2010 11:06:35 +0400 (MSD) From: Alexey Tarasov Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 28 Mar 2010 11:06:29 +0400 Message-Id: To: freebsd-fs@freebsd.org Mime-Version: 1.0 (Apple Message framework v1077) X-Mailer: Apple Mail (2.1077) Cc: Subject: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2010 07:06:40 -0000 Hello. I have reviewed a lot of discussion about new WD 4k sector disks = (...EARS). I have RAIDZ pool of such disks with very bad performance. Now my GPT = ZFS partitions don't start from value dividable by 4 (162). Some guys noticed that aligning ZFS partitions according to = recommendation wouldn't help at all because RAIDZ uses variable stripe = size. So where is the bottleneck of this configuration: 1) in ZFS which = doesn't know about 4k sectorsize? 2) maybe somewhere inside FreeBSD VFS = code or disk driver code? 3) somewhere else? If you doesn't want to use ZFS there are two ways to deal with this = problem: 1) Use GNOP with virtual 4k sectorsize. 2) Use UFS on properly aligned partition and some tuning. -- Alexey Tarasov (\__/)=20 (=3D'.'=3D)=20 E[: | | | | :]=D0=97=20 (")_(") From owner-freebsd-fs@FreeBSD.ORG Sun Mar 28 10:45:03 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09C3A106566B for ; Sun, 28 Mar 2010 10:45:03 +0000 (UTC) (envelope-from freebsd-fs@m.gmane.org) Received: from lo.gmane.org (lo.gmane.org [80.91.229.12]) by mx1.freebsd.org (Postfix) with ESMTP id B8EBC8FC0C for ; Sun, 28 Mar 2010 10:45:02 +0000 (UTC) Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NvpzH-0007eW-RM for freebsd-fs@freebsd.org; Sun, 28 Mar 2010 12:44:59 +0200 Received: from 93-138-119-5.adsl.net.t-com.hr ([93.138.119.5]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 28 Mar 2010 12:44:59 +0200 Received: from ivoras by 93-138-119-5.adsl.net.t-com.hr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 28 Mar 2010 12:44:59 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-fs@freebsd.org From: Ivan Voras Date: Sun, 28 Mar 2010 12:44:35 +0200 Lines: 21 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 93-138-119-5.adsl.net.t-com.hr User-Agent: Thunderbird 2.0.0.21 (X11/20090612) In-Reply-To: Subject: Re: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2010 10:45:03 -0000 Alexey Tarasov wrote: > Hello. > > I have reviewed a lot of discussion about new WD 4k sector disks (...EARS). > I have RAIDZ pool of such disks with very bad performance. Now my GPT ZFS partitions don't start from value dividable by 4 (162). > Some guys noticed that aligning ZFS partitions according to recommendation wouldn't help at all because RAIDZ uses variable stripe size. Yes, it doesn't group data in aligned "clusters" - the basic data alignment is sector-sized. > So where is the bottleneck of this configuration: 1) in ZFS which doesn't know about 4k sectorsize? 2) maybe somewhere inside FreeBSD VFS code or disk driver code? 3) somewhere else? AFAIK (I don't have actual experience with them) current 4k drives emulate 512b drives and have a performance penalty in the above scenario. Because of this emulation, ZFS doesn't know you have a 4k drive. If you can, try disabling this emulation and make it present to the operating system as a true 4k drive. Of course, this will make the data on it unreadable - you will have to reformat it, and the drive will be unbootable. Good luck and report what you find. From owner-freebsd-fs@FreeBSD.ORG Sun Mar 28 13:03:48 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 06E74106564A for ; Sun, 28 Mar 2010 13:03:48 +0000 (UTC) (envelope-from me@lexasoft.ru) Received: from relay.wahome.ru (relay.wahome.ru [95.211.21.141]) by mx1.freebsd.org (Postfix) with ESMTP id BCBB48FC12 for ; Sun, 28 Mar 2010 13:03:47 +0000 (UTC) Received: from mmx.lexasoft.ru (mmx.lexasoft.ru [92.241.160.6]) by relay.wahome.ru (Postfix) with ESMTP id 8F7746B1DF0; Sun, 28 Mar 2010 17:00:55 +0400 (MSD) Received: from [192.168.40.138] (unknown [124.157.205.118]) by mmx.lexasoft.ru (Postfix) with ESMTPSA id 3758028490; Sun, 28 Mar 2010 17:03:43 +0400 (MSD) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Apple Message framework v1077) From: Alexey Tarasov In-Reply-To: Date: Sun, 28 Mar 2010 17:03:38 +0400 Content-Transfer-Encoding: quoted-printable Message-Id: <492FB7C5-1B48-46BA-B63F-E7CBF7A0A195@lexasoft.ru> References: To: Ivan Voras , freebsd-fs@freebsd.org X-Mailer: Apple Mail (2.1077) Cc: Subject: Re: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2010 13:03:48 -0000 According to mailing lists, these drives can't be configured to present = 4k sectors to OS. Emulation jumper only changes first LBA number to 1 to made WinXP start = first partition from 64 sector (63+1). May be fresh firmware update can solve this problem. On 28.03.2010, at 14:44, Ivan Voras wrote: > AFAIK (I don't have actual experience with them) current 4k drives = emulate 512b drives and have a performance penalty in the above = scenario. Because of this emulation, ZFS doesn't know you have a 4k = drive. If you can, try disabling this emulation and make it present to = the operating system as a true 4k drive. Of course, this will make the = data on it unreadable - you will have to reformat it, and the drive will = be unbootable. >=20 > Good luck and report what you find. >=20 > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" -- Alexey Tarasov (\__/)=20 (=3D'.'=3D)=20 E[: | | | | :]=D0=97=20 (")_(") From owner-freebsd-fs@FreeBSD.ORG Sun Mar 28 17:17:11 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23AEC106564A for ; Sun, 28 Mar 2010 17:17:11 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: from mail-ww0-f54.google.com (mail-ww0-f54.google.com [74.125.82.54]) by mx1.freebsd.org (Postfix) with ESMTP id AE9CF8FC08 for ; Sun, 28 Mar 2010 17:17:10 +0000 (UTC) Received: by wwb24 with SMTP id 24so996638wwb.13 for ; Sun, 28 Mar 2010 10:17:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:content-type; bh=s+n4nvyJWs/tMWthNFcnOKgdNtvYC0cQQAVMJHe+O1c=; b=gm/EgOXXOqPiPWFWBy3qRiOM73kP+Fuq5aFf2gM/DEW28X6IyuApuU60RMyu6DBWoc RqSkd9S5RIJe7+l0Fljwgt92ebdTCswHao98IV/yYoDiGpLiaa20ZpibGUAh9cBV77fi +e0V1MZwHD5oRpz5MnuTqUJdBDqF2A1nFT8oo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=LfUQMs0vH2isjfBxRq/CvI2Vc5kf1euKlbb4sMnorIFmaXtwN7r/70LmKedbthTh5W qGn0sY0sZWmJ96Aw/gRqKVciCBtqBdn78jzhe8ZSXlKB0v1nD3qOPiuHssWmBUyNttoV hMBz6jUAKoypql0OmoASwzXHAbKMCdp8rdiP0= MIME-Version: 1.0 Received: by 10.216.186.211 with HTTP; Sun, 28 Mar 2010 09:49:18 -0700 (PDT) In-Reply-To: <492FB7C5-1B48-46BA-B63F-E7CBF7A0A195@lexasoft.ru> References: <492FB7C5-1B48-46BA-B63F-E7CBF7A0A195@lexasoft.ru> Date: Sun, 28 Mar 2010 18:49:18 +0200 Received: by 10.216.87.66 with SMTP id x44mr2375852wee.96.1269794958753; Sun, 28 Mar 2010 09:49:18 -0700 (PDT) Message-ID: <786602c61003280949s15782d2bh82e2f8dd33a31d88@mail.gmail.com> From: Thomas Zander To: freebsd-fs@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2010 17:17:11 -0000 On Sun, Mar 28, 2010 at 15:03, Alexey Tarasov wrote: > According to mailing lists, these drives can't be configured to present 4k sectors to OS. Maybe that's a dumb idea, but I am curious. As far as I understand, the following points apply: - EARS and RAIDZ is slow, but - if you make ZFS aware of the 4k sector size (gnop), performance is okay If so, what happens if you configure geli for the whole drive with 4k sectors? Maybe you get AES-128 for free :-) Riggs From owner-freebsd-fs@FreeBSD.ORG Sun Mar 28 17:53:55 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5A801065677 for ; Sun, 28 Mar 2010 17:53:55 +0000 (UTC) (envelope-from me@lexasoft.ru) Received: from relay.wahome.ru (relay.wahome.ru [95.211.21.141]) by mx1.freebsd.org (Postfix) with ESMTP id 978958FC16 for ; Sun, 28 Mar 2010 17:53:55 +0000 (UTC) Received: from mmx.lexasoft.ru (mmx.lexasoft.ru [92.241.160.6]) by relay.wahome.ru (Postfix) with ESMTP id A9C366B210B; Sun, 28 Mar 2010 21:51:03 +0400 (MSD) Received: from [192.168.40.138] (unknown [124.157.205.118]) by mmx.lexasoft.ru (Postfix) with ESMTPSA id 1252D28490; Sun, 28 Mar 2010 21:53:50 +0400 (MSD) Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=utf-8 From: Alexey Tarasov In-Reply-To: <786602c61003280949s15782d2bh82e2f8dd33a31d88@mail.gmail.com> Date: Sun, 28 Mar 2010 21:53:44 +0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <492FB7C5-1B48-46BA-B63F-E7CBF7A0A195@lexasoft.ru> <786602c61003280949s15782d2bh82e2f8dd33a31d88@mail.gmail.com> To: Thomas Zander X-Mailer: Apple Mail (2.1077) Cc: freebsd-fs@freebsd.org Subject: Re: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2010 17:53:55 -0000 On 28.03.2010, at 20:49, Thomas Zander wrote: > On Sun, Mar 28, 2010 at 15:03, Alexey Tarasov wrote: >> According to mailing lists, these drives can't be configured to = present 4k sectors to OS. >=20 > Maybe that's a dumb idea, but I am curious. > As far as I understand, the following points apply: > - EARS and RAIDZ is slow, but > - if you make ZFS aware of the 4k sector size (gnop), performance is = okay >=20 > If so, what happens if you configure geli for the whole drive with 4k > sectors? Maybe you get AES-128 for free :-) What do you mean "for free"? =3D) -- Alexey Tarasov (\__/)=20 (=3D'.'=3D)=20 E[: | | | | :]=D0=97=20 (")_(") From owner-freebsd-fs@FreeBSD.ORG Mon Mar 29 02:00:17 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40DB21065675 for ; Mon, 29 Mar 2010 02:00:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 13B278FC19 for ; Mon, 29 Mar 2010 02:00:17 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2T20GSR045444 for ; Mon, 29 Mar 2010 02:00:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2T20GWB045437; Mon, 29 Mar 2010 02:00:16 GMT (envelope-from gnats) Date: Mon, 29 Mar 2010 02:00:16 GMT Message-Id: <201003290200.o2T20GWB045437@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: "Pedro F. Giffuni" Cc: Subject: Re: kern/143345: [ext2fs] [patch] extfs minor header cleanups to better match NetBSD/UFS X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Pedro F. Giffuni" List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 02:00:17 -0000 The following reply was made to PR kern/143345; it has been noted by GNATS. From: "Pedro F. Giffuni" To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/143345: [ext2fs] [patch] extfs minor header cleanups to better match NetBSD/UFS Date: Sun, 28 Mar 2010 18:58:57 -0700 (PDT) --0-155324898-1269827937=:26301 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I simplified the patch by avoiding unnecessary changes.=0A =0A=0A=0A --0-155324898-1269827937=:26301 Content-Type: application/octet-stream; name=patch-ext2fs-headers Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch-ext2fs-headers" LS0tIGV4dDJmcy5ic2QvZXh0Ml9kaW5vZGUuaAkyMDEwLTAxLTE3IDE5OjAx OjM1LjAwMDAwMDAwMCArMDAwMAorKysgZXh0MmZzL2V4dDJfZGlub2RlLmgJ MjAxMC0wMy0yOCAyMDo1MzoxMC4wMDAwMDAwMDAgKzAwMDAKQEAgLTMyLDYg KzMyLDE4IEBACiAjZGVmaW5lIGUyZGlfc2l6ZV9oaWdoCWUyZGlfZGFjbAog CiAvKgorICogU3BlY2lhbCBpbm9kZSBudW1iZXJzCisgKiBUaGUgcm9vdCBp bm9kZSBpcyB0aGUgcm9vdCBvZiB0aGUgZmlsZSBzeXN0ZW0uICBJbm9kZSAw IGNhbid0IGJlIHVzZWQgZm9yCisgKiBub3JtYWwgcHVycG9zZXMgYW5kIGJh ZCBibG9ja3MgYXJlIG5vcm1hbGx5IGxpbmtlZCB0byBpbm9kZSAxLCB0aHVz CisgKiB0aGUgcm9vdCBpbm9kZSBpcyAyLgorICogSW5vZGUgMyB0byAxMCBh cmUgcmVzZXJ2ZWQgaW4gZXh0MmZzLgorICovCisjZGVmaW5lIEVYVDJfQkFE X0lOTwkJIDEJLyogQmFkIGJsb2NrcyBpbm9kZSAqLworI2RlZmluZSBFWFQy X1JPT1RfSU5PCQkgMgkvKiBSb290IGlub2RlICovCisjZGVmaW5lIEVYVDJf Qk9PVF9MT0FERVJfSU5PCSA1CS8qIEJvb3QgbG9hZGVyIGlub2RlICovCisj ZGVmaW5lIEVYVDJfVU5ERUxfRElSX0lOTwkgNgkvKiBVbmRlbGV0ZSBkaXJl Y3RvcnkgaW5vZGUgKi8KKworLyoKICAqIElub2RlIGZsYWdzCiAgKiBUaGUg Y3VycmVudCBpbXBsZW1lbnRhdGlvbiB1c2VzIG9ubHkgRVhUMl9JTU1VVEFC TEUgYW5kIEVYVDJfQVBQRU5EIGZsYWdzCiAgKi8KQEAgLTc0LDUgKzg2LDUg QEAKIAl1X2ludDMyX3QJZTJkaV9saW51eF9yZXNlcnZlZDM7IC8qIDEyNCAq LwogfTsKIAotI2VuZGlmIC8qIF9GU19FWFQyRlNfRVhUMl9ESU5PREVfSF8g Ki8KKyNlbmRpZiAvKiAhX0ZTX0VYVDJGU19FWFQyX0RJTk9ERV9IXyAqLwog Ci0tLSBleHQyZnMuYnNkL2V4dDJmcy5oCTIwMTAtMDEtMTcgMTk6MDM6MDgu MDAwMDAwMDAwICswMDAwCisrKyBleHQyZnMvZXh0MmZzLmgJMjAxMC0wMS0y OSAwOTozNDozMi4wMDAwMDAwMDAgKzAwMDAKQEAgLTM5LDIyICszOSw2IEBA CiAKICNpbmNsdWRlIDxzeXMvdHlwZXMuaD4KIAotLyoKLSAqIFNwZWNpYWwg aW5vZGUgbnVtYmVycwotICovCi0jZGVmaW5lCUVYVDJfQkFEX0lOTwkJIDEJ LyogQmFkIGJsb2NrcyBpbm9kZSAqLwotI2RlZmluZSBFWFQyX1JPT1RfSU5P CQkgMgkvKiBSb290IGlub2RlICovCi0jZGVmaW5lIEVYVDJfQk9PVF9MT0FE RVJfSU5PCSA1CS8qIEJvb3QgbG9hZGVyIGlub2RlICovCi0jZGVmaW5lIEVY VDJfVU5ERUxfRElSX0lOTwkgNgkvKiBVbmRlbGV0ZSBkaXJlY3RvcnkgaW5v ZGUgKi8KLQotLyogRmlyc3Qgbm9uLXJlc2VydmVkIGlub2RlIGZvciBvbGQg ZXh0MiBmaWxlc3lzdGVtcyAqLwotI2RlZmluZSBFMkZTX1JFVjBfRklSU1Rf SU5PCTExCi0KLS8qCi0gKiBUaGUgc2Vjb25kIGV4dGVuZGVkIGZpbGUgc3lz dGVtIG1hZ2ljIG51bWJlcgotICovCi0jZGVmaW5lIEUyRlNfTUFHSUMJCTB4 RUY1MwotCiAjaWYgZGVmaW5lZChfS0VSTkVMKQogLyoKICAqIEZyZWVCU0Qg cGFzc2VzIHRoZSBwb2ludGVyIHRvIHRoZSBpbi1jb3JlIHN0cnVjdCB3aXRo IHJlbGV2YW50CkBAIC0xMjksNyArMTEzLDkgQEAKIAl1X2ludDhfdCAgIGUy ZnNfdXVpZFsxNl07CS8qIDEyOC1iaXQgdXVpZCBmb3Igdm9sdW1lICovCiAJ Y2hhciAgICAgICBlMmZzX3ZuYW1lWzE2XTsJLyogdm9sdW1lIG5hbWUgKi8K IAljaGFyICAgICAgIGUyZnNfZnNtbnRbNjRdOyAJLyogbmFtZSBtb3VudGVk IG9uICovCi0JdV9pbnQzMl90ICBlMmZzX2FsZ287CQkvKiBGb3IgY29tY2F0 ZSBmb3IgZGlyICovCisJdV9pbnQzMl90ICBlMmZzX2FsZ287CQkvKiBmb3Ig Y29tcHJlc3Npb24gKi8KKwl1aW50OF90CSAgIGUyZnNfcHJlYWxsb2M7CS8q ICMgb2YgYmxvY2tzIHRvIHByZWFsbG9jYXRlICovCisJdWludDhfdAkgICBl MmZzX2Rpcl9wcmVhbGxvYzsJLyogIyBvZiBibG9ja3MgdG8gcHJlYWxsb2Nh dGUgZm9yIGRpciAqLwogCXVfaW50MTZfdCAgZTJmc19yZXNlcnZlZF9uZ2Ri OyAvKiAjIG9mIHJlc2VydmVkIGdkIGJsb2NrcyBmb3IgcmVzaXplICovCiAJ dV9pbnQzMl90ICByZXNlcnZlZDJbMjA0XTsKIH07CkBAIC0xNTMsOCArMTM5 LDggQEAKIAl1aW50MzJfdCBlMmZzX2JzaGlmdDsgICAgIC8qIGNhbGMgb2Yg bG9naWNhbCBibG9jayBubyAqLwogCWludDMyX3QgZTJmc19ibWFzazsgICAg ICAgLyogY2FsYyBvZiBibG9jayBvZmZzZXQgKi8KIAlpbnQzMl90IGUyZnNf YnBnOyAgICAgICAgIC8qIE51bWJlciBvZiBibG9ja3MgcGVyIGdyb3VwICov Ci0JaW50NjRfdCBlMmZzX3FibWFzazsgICAgICAgLyogPSBzX2Jsb2Nrc2l6 ZSAtMSAqLwotCXVpbnQzMl90IGUyZnNfZnNidG9kYjsgICAgIC8qIFNoaWZ0 IHRvIGdldCBkaXNrIGJsb2NrICovCisJaW50NjRfdCBlMmZzX3FibWFzazsg ICAgICAvKiA9IHNfYmxvY2tzaXplIC0xICovCisJdWludDMyX3QgZTJmc19m c2J0b2RiOyAgICAvKiBTaGlmdCB0byBnZXQgZGlzayBibG9jayAqLwogCXVp bnQzMl90IGUyZnNfaXBnOyAgICAgICAgLyogTnVtYmVyIG9mIGlub2RlcyBw ZXIgZ3JvdXAgKi8KIAl1aW50MzJfdCBlMmZzX2lwYjsgICAgICAgIC8qIE51 bWJlciBvZiBpbm9kZXMgcGVyIGJsb2NrICovCiAJdWludDMyX3QgZTJmc19p dHBnOyAgICAgICAvKiBOdW1iZXIgb2YgaW5vZGUgdGFibGUgcGVyIGdyb3Vw ICovCkBAIC0xNjksOCArMTU1LDggQEAKIAlpbnQzMl90ICBlMmZzX2lzaXpl OyAgICAgIC8qIFNpemUgb2YgaW5vZGUgKi8KIAl1aW50MzJfdCBlMmZzX21v dW50X29wdDsKIAl1aW50MzJfdCBlMmZzX2Jsb2Nrc2l6ZV9iaXRzOworCXVp bnQ4X3QJKmUyZnNfY29udGlnZGlyczsgLyogKHUpICMgb2YgY29udGlnLiBh bGxvY2F0ZWQgZGlycyAqLwogCXVpbnQzMl90IGUyZnNfdG90YWxfZGlyOyAg LyogVG90YWwgbnVtYmVyIG9mIGRpcmVjdG9yaWVzICovCi0JdWludDhfdAkq ZTJmc19jb250aWdkaXJzOwogCWNoYXIgZTJmc193YXN2YWxpZDsgICAgICAg LyogdmFsaWQgYXQgbW91bnQgdGltZSAqLwogCW9mZl90IGUyZnNfbWF4Zmls ZXNpemU7CiAJc3RydWN0IGV4dDJfZ2QgKmUyZnNfZ2Q7IC8qIEdyb3VwIERl c2NyaXB0b3JzICovCkBAIC0xODIsNiArMTY4LDE0IEBACiAjZGVmaW5lIEUy RlNfREFURQkJIjk1LzA4LzA5IgogI2RlZmluZSBFMkZTX1ZFUlNJT04JCSIw LjViIgogCisvKiBGaXJzdCBub24tcmVzZXJ2ZWQgaW5vZGUgZm9yIG9sZCBl eHQyIGZpbGVzeXN0ZW1zICovCisjZGVmaW5lIEUyRlNfUkVWMF9GSVJTVF9J Tk8JMTEKKworLyoKKyAqIFRoZSBzZWNvbmQgZXh0ZW5kZWQgZmlsZSBzeXN0 ZW0gbWFnaWMgbnVtYmVyCisgKi8KKyNkZWZpbmUgRTJGU19NQUdJQwkJMHhF RjUzCisKIC8qCiAgKiBSZXZpc2lvbiBsZXZlbHMKICAqLwpAQCAtMTk3LDYg KzE5MSw3IEBACiAgKiBjb21wYXRpYmxlL2luY29tcGF0aWJsZSBmZWF0dXJl cwogICovCiAjZGVmaW5lIEVYVDJGX0NPTVBBVF9QUkVBTExPQwkJMHgwMDAx CisjZGVmaW5lIEVYVDJGX0NPTVBBVF9IQVNKT1VSTkFMCQkweDAwMDQKICNk ZWZpbmUgRVhUMkZfQ09NUEFUX1JFU0laRQkJMHgwMDEwCiAKICNkZWZpbmUg RVhUMkZfUk9DT01QQVRfU1BBUlNFU1VQRVIJMHgwMDAxCkBAIC0zMjYsNCAr MzIxLDQgQEAKIAogI2VuZGlmCiAKLSNlbmRpZgkvKiBfTElOVVhfRVhUMl9G U19IICovCisjZW5kaWYJLyogIV9GU19FWFQyRlNfRVhUMkZTX0ggKi8K --0-155324898-1269827937=:26301-- From owner-freebsd-fs@FreeBSD.ORG Mon Mar 29 07:33:36 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B944106564A for ; Mon, 29 Mar 2010 07:33:36 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id C43798FC14 for ; Mon, 29 Mar 2010 07:33:35 +0000 (UTC) Received: by wyb33 with SMTP id 33so5059565wyb.13 for ; Mon, 29 Mar 2010 00:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type; bh=3nBTLYlkV+STIUZCsqBeNbl+H2rGlUemDViE7P6RQvs=; b=xLk+Y3FolOum9A/Hjox5OUiWLfRiYJIMSzUpbb6tNgoip2Dimiz2TK/AGEeN4iNGrl CkBUfSCVexv2HN71Nn8s4xQ+b3uwjuXixF9ODhF+eA0rqaEdlYVWfrwA5jOzPsSiTYJ9 0pLj19m+PDnbLwWyDsaIYIX4IXpWEbcGS11D8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=K9ac3Mjl7nkkpo3CVf3VYVs3eBcLpMV0dUB/+gkeNzwVbMTPrLyNx9RdoU5Q3MO+V5 ATj8eACBTcrYMdzoc1YyOOtgw6rg96G/Y0+/QQpovx+ZygP3JL+cu0xjAP4GDizdGG9V 9WA91RC5jKMsDgRsdSRPlHSZDSzvpLHP7uMlw= MIME-Version: 1.0 Received: by 10.216.186.211 with HTTP; Mon, 29 Mar 2010 00:33:34 -0700 (PDT) In-Reply-To: References: <492FB7C5-1B48-46BA-B63F-E7CBF7A0A195@lexasoft.ru> <786602c61003280949s15782d2bh82e2f8dd33a31d88@mail.gmail.com> Date: Mon, 29 Mar 2010 09:33:34 +0200 Received: by 10.216.86.16 with SMTP id v16mr2862708wee.162.1269848014811; Mon, 29 Mar 2010 00:33:34 -0700 (PDT) Message-ID: <786602c61003290033n5ca5c4afo64bc3673e548bd4f@mail.gmail.com> From: Thomas Zander To: Alexey Tarasov Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-fs@freebsd.org Subject: Re: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 07:33:36 -0000 On Sun, Mar 28, 2010 at 19:53, Alexey Tarasov wrote: >> If so, what happens if you configure geli for the whole drive with 4k >> sectors? Maybe you get AES-128 for free :-) > > What do you mean "for free"? =) I mean (4K sectors + geli + RAIDZ) could be faster than (4K sectors + RAIDZ) ? Riggs From owner-freebsd-fs@FreeBSD.ORG Mon Mar 29 07:36:59 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2397C1065672 for ; Mon, 29 Mar 2010 07:36:59 +0000 (UTC) (envelope-from numisemis@yahoo.com) Received: from web112420.mail.gq1.yahoo.com (web112420.mail.gq1.yahoo.com [98.137.26.117]) by mx1.freebsd.org (Postfix) with SMTP id E72DB8FC17 for ; Mon, 29 Mar 2010 07:36:58 +0000 (UTC) Received: (qmail 20555 invoked by uid 60001); 29 Mar 2010 07:36:58 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1269848218; bh=qbI7fzkrSGs5bnL6uB0qD7BXNwCRwHvt/6WveDaKHMQ=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:References:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=nFjfOslkrLjjNuKnzEMRNCzhuIxNzSx1PxY+ILZ4/pizBfclItsUXna7NgSyiWLkSIWoptZCsOlBbBoibcB3j6Ves8KQ0djpSEMPQM7xazemvihZU7PyWusKSJZJp5WcQcO/yVgZz0EVmZhRdjGp9kVttLGrPt84d8l5jsyclqo= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:References:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=MlthcyGZffTYhtTLEX2TnvOJrBSw/7542RoCjpkXW6EGD+zjZSQX+S8J6OBn17FsAjBMBhKEBjDsSny1xVn13huwEdktzTH0a8VYvYxz1a9V4QByf6vAZIj6SajJPV3LLPYB/HQ4m5IF/doKuFEbk2IjZMU5uTwKKcoC3/3iOt4=; Message-ID: <641044.19603.qm@web112420.mail.gq1.yahoo.com> X-YMail-OSG: _xJI6SQVM1nCYu41EcgSuJ9KDzIR96TyuTobA3petgMF4I3 eUNmuMOOjfoSCcIV.bvTHGo50d_eDmqvWynEpQyVfAleTLG2PQYtg5SurdXi LhH9HAAN9U5JnCOaGhjYorFZfj5gB_Kufohz_yAf6QRLEicEqivt_9PnMkhK .vkGSxdIhAKA8mjEDkvqBc0aJRVgfhA4yiQwt41JVDYiIhQBvvR0b3mulv7v xjjl4Q6b5g0f0XOA.C.p9CPXGZBnqveN53IAVN4BTCdnLRTSzIcJznIacN43 YGvUgZ1A43NGfAKKVPvmhD4vPIQdoV9DZr._oJfJGTcqjmaLbZsdGsquBvGr l1hhFEd7hw1dnvke9433QO3.vEFgYRg-- Received: from [213.147.110.159] by web112420.mail.gq1.yahoo.com via HTTP; Mon, 29 Mar 2010 00:36:58 PDT X-Mailer: YahooMailRC/324.3 YahooMailWebService/0.8.100.260964 References: <492FB7C5-1B48-46BA-B63F-E7CBF7A0A195@lexasoft.ru> Date: Mon, 29 Mar 2010 00:36:58 -0700 (PDT) From: Simun Mikecin To: Alexey Tarasov In-Reply-To: <492FB7C5-1B48-46BA-B63F-E7CBF7A0A195@lexasoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-fs@freebsd.org Subject: Re: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 07:36:59 -0000 ----- Original Message ---- > From: Alexey Tarasov > To: Ivan Voras ; freebsd-fs@freebsd.org > Sent: Sun, March 28, 2010 3:03:38 PM > Subject: Re: ZFS raidz and 4k sector disks > > According to mailing lists, these drives can't be configured to present 4k > sectors to OS. Emulation jumper only changes first LBA number to 1 to made > WinXP start first partition from 64 sector (63+1). May be fresh firmware > update can solve this problem. I don't think they will ever come with a firmware update like that because WD has major operating systems (like Windows 7) covered. It could be solved by asking the drive what is the size of a sector (such ATA call exists: see http://www.wdc.com/wdproducts/library/WhitePapers/ENG/2579-771430.pdf) and set the sector size of the device (/dev/[a]da*) as needed . That would be a permanent solution for ZFS, UFS, swap or any other consumer of this device. From owner-freebsd-fs@FreeBSD.ORG Mon Mar 29 08:40:24 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D2B74106566C for ; Mon, 29 Mar 2010 08:40:24 +0000 (UTC) (envelope-from me@lexasoft.ru) Received: from relay.wahome.ru (relay.wahome.ru [95.211.21.141]) by mx1.freebsd.org (Postfix) with ESMTP id 98D2E8FC1B for ; Mon, 29 Mar 2010 08:40:24 +0000 (UTC) Received: from mmx.lexasoft.ru (mmx.lexasoft.ru [92.241.160.6]) by relay.wahome.ru (Postfix) with ESMTP id 32C516B2135 for ; Mon, 29 Mar 2010 12:37:32 +0400 (MSD) Received: from [192.168.40.138] (unknown [124.157.205.118]) by mmx.lexasoft.ru (Postfix) with ESMTPSA id E271228490 for ; Mon, 29 Mar 2010 12:40:21 +0400 (MSD) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Apple Message framework v1077) From: Alexey Tarasov In-Reply-To: <641044.19603.qm@web112420.mail.gq1.yahoo.com> Date: Mon, 29 Mar 2010 12:40:21 +0400 Content-Transfer-Encoding: quoted-printable Message-Id: <767C3247-5913-4C23-94D6-5D72CAD60515@lexasoft.ru> References: <492FB7C5-1B48-46BA-B63F-E7CBF7A0A195@lexasoft.ru> <641044.19603.qm@web112420.mail.gq1.yahoo.com> To: freebsd-fs@freebsd.org X-Mailer: Apple Mail (2.1077) Subject: Re: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 08:40:24 -0000 Cool. May be there is someone here who can implement this solution? On 29.03.2010, at 11:36, Simun Mikecin wrote: > I don't think they will ever come with a firmware update like that = because WD has major operating systems (like Windows 7) covered. > It could be solved by asking the drive what is the size of a sector = (such ATA call exists: see = http://www.wdc.com/wdproducts/library/WhitePapers/ENG/2579-771430.pdf) = and set the sector size of the device (/dev/[a]da*) as needed . That = would be a permanent solution for ZFS, UFS, swap or any other consumer = of this device. -- Alexey Tarasov (\__/)=20 (=3D'.'=3D)=20 E[: | | | | :]=D0=97=20 (")_(") From owner-freebsd-fs@FreeBSD.ORG Mon Mar 29 11:06:54 2010 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B6F28106566C for ; Mon, 29 Mar 2010 11:06:54 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 88FB08FC20 for ; Mon, 29 Mar 2010 11:06:54 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2TB6smP057970 for ; Mon, 29 Mar 2010 11:06:54 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2TB6rCG057968 for freebsd-fs@FreeBSD.org; Mon, 29 Mar 2010 11:06:53 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 29 Mar 2010 11:06:53 GMT Message-Id: <201003291106.o2TB6rCG057968@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-fs@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-fs@FreeBSD.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 11:06:54 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/144929 fs [ufs] [lor] vfs_bio.c + ufs_dirhash.c o kern/144458 fs [nfs] [patch] nfsd fails as a kld o kern/144416 fs [panic] Kernel panic on online filesystem optimization s kern/144415 fs [zfs] [panic] kernel panics on boot after zfs crash o kern/144330 fs [nfs] mbuf leakage in nfsd with zfs o kern/144234 fs [zfs] Cannot boot machine with recent gptzfsboot code o bin/144214 fs zfsboot fails on gang block after upgrade to zfs v14 o kern/143825 fs [nfs] [panic] Kernel panic on NFS client o kern/143345 fs [ext2fs] [patch] extfs minor header cleanups to better o kern/143212 fs [nfs] NFSv4 client strange work ... o kern/143184 fs [zfs] [lor] zfs/bufwait LOR o kern/142924 fs [ext2fs] [patch] Small cleanup for the inode struct in o kern/142914 fs [zfs] ZFS performance degradation over time o kern/142878 fs [zfs] [vfs] lock order reversal o kern/142597 fs [ext2fs] ext2fs does not work on filesystems with real o kern/142489 fs [zfs] [lor] allproc/zfs LOR o kern/142466 fs Update 7.2 -> 8.0 on Raid 1 ends with screwed raid [re o kern/142401 fs [ntfs] [patch] Minor updates to NTFS from NetBSD o kern/142306 fs [zfs] [panic] ZFS drive (from OSX Leopard) causes two o kern/142068 fs [ufs] BSD labels are got deleted spontaneously o kern/141950 fs [unionfs] [lor] ufs/unionfs/ufs Lock order reversal o kern/141897 fs [msdosfs] [panic] Kernel panic. msdofs: file name leng o kern/141463 fs [nfs] [panic] Frequent kernel panics after upgrade fro o kern/141305 fs [zfs] FreeBSD ZFS+sendfile severe performance issues ( o kern/141091 fs [patch] [nullfs] fix panics with DIAGNOSTIC enabled o kern/141086 fs [nfs] [panic] panic("nfs: bioread, not dir") on FreeBS o kern/141010 fs [zfs] "zfs scrub" fails when backed by files in UFS2 o kern/140888 fs [zfs] boot fail from zfs root while the pool resilveri o kern/140661 fs [zfs] [patch] /boot/loader fails to work on a GPT/ZFS- o kern/140640 fs [zfs] snapshot crash o kern/140433 fs [zfs] [panic] panic while replaying ZIL after crash o kern/140134 fs [msdosfs] write and fsck destroy filesystem integrity o kern/140068 fs [smbfs] [patch] smbfs does not allow semicolon in file o kern/139725 fs [zfs] zdb(1) dumps core on i386 when examining zpool c o kern/139715 fs [zfs] vfs.numvnodes leak on busy zfs o bin/139651 fs [nfs] mount(8): read-only remount of NFS volume does n o kern/139597 fs [patch] [tmpfs] tmpfs initializes va_gen but doesn't u o kern/139564 fs [zfs] [panic] 8.0-RC1 - Fatal trap 12 at end of shutdo o kern/139407 fs [smbfs] [panic] smb mount causes system crash if remot o kern/139363 fs [nfs] diskless root nfs mount from non FreeBSD server o kern/138790 fs [zfs] ZFS ceases caching when mem demand is high o kern/138524 fs [msdosfs] disks and usb flashes/cards with Russian lab o kern/138421 fs [ufs] [patch] remove UFS label limitations o kern/138202 fs mount_msdosfs(1) see only 2Gb f kern/137037 fs [zfs] [hang] zfs rollback on root causes FreeBSD to fr o kern/136968 fs [ufs] [lor] ufs/bufwait/ufs (open) o kern/136945 fs [ufs] [lor] filedesc structure/ufs (poll) o kern/136944 fs [ffs] [lor] bufwait/snaplk (fsync) o kern/136873 fs [ntfs] Missing directories/files on NTFS volume o kern/136865 fs [nfs] [patch] NFS exports atomic and on-the-fly atomic o kern/136470 fs [nfs] Cannot mount / in read-only, over NFS o kern/135594 fs [zfs] Single dataset unresponsive with Samba o kern/135546 fs [zfs] zfs.ko module doesn't ignore zpool.cache filenam o kern/135469 fs [ufs] [panic] kernel crash on md operation in ufs_dirb o kern/135050 fs [zfs] ZFS clears/hides disk errors on reboot o kern/134491 fs [zfs] Hot spares are rather cold... o kern/133676 fs [smbfs] [panic] umount -f'ing a vnode-based memory dis o kern/133614 fs [panic] panic: ffs_truncate: read-only filesystem o kern/133174 fs [msdosfs] [patch] msdosfs must support utf-encoded int f kern/133150 fs [zfs] Page fault with ZFS on 7.1-RELEASE/amd64 while w o kern/132960 fs [ufs] [panic] panic:ffs_blkfree: freeing free frag o kern/132397 fs reboot causes filesystem corruption (failure to sync b o kern/132331 fs [ufs] [lor] LOR ufs and syncer o kern/132237 fs [msdosfs] msdosfs has problems to read MSDOS Floppy o kern/132145 fs [panic] File System Hard Crashes o kern/131441 fs [unionfs] [nullfs] unionfs and/or nullfs not combineab o kern/131360 fs [nfs] poor scaling behavior of the NFS server under lo o kern/131342 fs [nfs] mounting/unmounting of disks causes NFS to fail o bin/131341 fs makefs: error "Bad file descriptor" on the mount poin o kern/130979 fs [smbfs] [panic] boot/kernel/smbfs.ko o kern/130920 fs [msdosfs] cp(1) takes 100% CPU time while copying file o kern/130229 fs [iconv] usermount fails on fs that need iconv o kern/130210 fs [nullfs] Error by check nullfs o kern/129760 fs [nfs] after 'umount -f' of a stale NFS share FreeBSD l o kern/129488 fs [smbfs] Kernel "bug" when using smbfs in smbfs_smb.c: o kern/129231 fs [ufs] [patch] New UFS mount (norandom) option - mostly o kern/129152 fs [panic] non-userfriendly panic when trying to mount(8) o kern/129059 fs [zfs] [patch] ZFS bootloader whitelistable via WITHOUT f kern/128829 fs smbd(8) causes periodic panic on 7-RELEASE o kern/127420 fs [gjournal] [panic] Journal overflow on gmirrored gjour o kern/127029 fs [panic] mount(8): trying to mount a write protected zi o kern/126287 fs [ufs] [panic] Kernel panics while mounting an UFS file s kern/125738 fs [zfs] [request] SHA256 acceleration in ZFS p kern/124621 fs [ext3] [patch] Cannot mount ext2fs partition f bin/124424 fs [zfs] zfs(8): zfs list -r shows strange snapshots' siz o kern/123939 fs [msdosfs] corrupts new files o kern/122380 fs [ffs] ffs_valloc:dup alloc (Soekris 4801/7.0/USB Flash o bin/122172 fs [fs]: amd(8) automount daemon dies on 6.3-STABLE i386, o bin/121898 fs [nullfs] pwd(1)/getcwd(2) fails with Permission denied o bin/121779 fs [ufs] snapinfo(8) (and related tools?) only work for t o bin/121366 fs [zfs] [patch] Automatic disk scrubbing from periodic(8 o bin/121072 fs [smbfs] mount_smbfs(8) cannot normally convert the cha f kern/120991 fs [panic] [fs] [snapshot] System crashes when manipulati o kern/120483 fs [ntfs] [patch] NTFS filesystem locking changes o kern/120482 fs [ntfs] [patch] Sync style changes between NetBSD and F f kern/119735 fs [zfs] geli + ZFS + samba starting on boot panics 7.0-B o kern/118912 fs [2tb] disk sizing/geometry problem with large array o kern/118713 fs [minidump] [patch] Display media size required for a k o bin/118249 fs mv(1): moving a directory changes its mtime o kern/118107 fs [ntfs] [panic] Kernel panic when accessing a file at N o bin/117315 fs [smbfs] mount_smbfs(8) and related options can't mount o kern/117314 fs [ntfs] Long-filename only NTFS fs'es cause kernel pani o kern/117158 fs [zfs] zpool scrub causes panic if geli vdevs detach on o bin/116980 fs [msdosfs] [patch] mount_msdosfs(8) resets some flags f o kern/116913 fs [ffs] [panic] ffs_blkfree: freeing free block p kern/116608 fs [msdosfs] [patch] msdosfs fails to check mount options o kern/116583 fs [ffs] [hang] System freezes for short time when using o kern/116170 fs [panic] Kernel panic when mounting /tmp o kern/115645 fs [snapshots] [panic] lockmgr: thread 0xc4c00d80, not ex o bin/115361 fs [zfs] mount(8) gets into a state where it won't set/un o kern/114955 fs [cd9660] [patch] [request] support for mask,dirmask,ui o kern/114847 fs [ntfs] [patch] [request] dirmask support for NTFS ala o kern/114676 fs [ufs] snapshot creation panics: snapacct_ufs2: bad blo o bin/114468 fs [patch] [request] add -d option to umount(8) to detach o kern/113852 fs [smbfs] smbfs does not properly implement DFS referral o bin/113838 fs [patch] [request] mount(8): add support for relative p o bin/113049 fs [patch] [request] make quot(8) use getopt(3) and show o kern/112658 fs [smbfs] [patch] smbfs and caching problems (resolves b o kern/111843 fs [msdosfs] Long Names of files are incorrectly created o kern/111782 fs [ufs] dump(8) fails horribly for large filesystems s bin/111146 fs [2tb] fsck(8) fails on 6T filesystem o kern/109024 fs [msdosfs] mount_msdosfs: msdosfs_iconv: Operation not o kern/109010 fs [msdosfs] can't mv directory within fat32 file system o bin/107829 fs [2TB] fdisk(8): invalid boundary checking in fdisk / w o kern/106030 fs [ufs] [panic] panic in ufs from geom when a dead disk o kern/104406 fs [ufs] Processes get stuck in "ufs" state under persist o kern/104133 fs [ext2fs] EXT2FS module corrupts EXT2/3 filesystems o kern/103035 fs [ntfs] Directories in NTFS mounted disc images appear o kern/101324 fs [smbfs] smbfs sometimes not case sensitive when it's s o kern/99290 fs [ntfs] mount_ntfs ignorant of cluster sizes o kern/97377 fs [ntfs] [patch] syntax cleanup for ntfs_ihash.c o kern/95222 fs [iso9660] File sections on ISO9660 level 3 CDs ignored o kern/94849 fs [ufs] rename on UFS filesystem is not atomic o kern/94769 fs [ufs] Multiple file deletions on multi-snapshotted fil o kern/94733 fs [smbfs] smbfs may cause double unlock o kern/93942 fs [vfs] [patch] panic: ufs_dirbad: bad dir (patch from D o kern/92272 fs [ffs] [hang] Filling a filesystem while creating a sna f kern/91568 fs [ufs] [panic] writing to UFS/softupdates DVD media in o kern/91134 fs [smbfs] [patch] Preserve access and modification time a kern/90815 fs [smbfs] [patch] SMBFS with character conversions somet o kern/88657 fs [smbfs] windows client hang when browsing a samba shar o kern/88266 fs [smbfs] smbfs does not implement UIO_NOCOPY and sendfi o kern/87859 fs [smbfs] System reboot while umount smbfs. o kern/86587 fs [msdosfs] rm -r /PATH fails with lots of small files o kern/85326 fs [smbfs] [panic] saving a file via samba to an overquot o kern/84589 fs [2TB] 5.4-STABLE unresponsive during background fsck 2 o kern/80088 fs [smbfs] Incorrect file time setting on NTFS mounted vi o kern/73484 fs [ntfs] Kernel panic when doing `ls` from the client si o bin/73019 fs [ufs] fsck_ufs(8) cannot alloc 607016868 bytes for ino o kern/71774 fs [ntfs] NTFS cannot "see" files on a WinXP filesystem o kern/68978 fs [panic] [ufs] crashes with failing hard disk, loose po o kern/65920 fs [nwfs] Mounted Netware filesystem behaves strange o kern/65901 fs [smbfs] [patch] smbfs fails fsx write/truncate-down/tr o kern/61503 fs [smbfs] mount_smbfs does not work as non-root o kern/55617 fs [smbfs] Accessing an nsmb-mounted drive via a smb expo o kern/51685 fs [hang] Unbounded inode allocation causes kernel to loc o kern/51583 fs [nullfs] [patch] allow to work with devices and socket o kern/36566 fs [smbfs] System reboot with dead smb mount and umount o kern/33464 fs [ufs] soft update inconsistencies after system crash o kern/18874 fs [2TB] 32bit NFS servers export wrong negative values t 160 problems total. From owner-freebsd-fs@FreeBSD.ORG Mon Mar 29 10:01:56 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3D2F106566C for ; Mon, 29 Mar 2010 10:01:56 +0000 (UTC) (envelope-from ludovit.koren@gmail.com) Received: from mail-fx0-f225.google.com (mail-fx0-f225.google.com [209.85.220.225]) by mx1.freebsd.org (Postfix) with ESMTP id 2FA1E8FC0C for ; Mon, 29 Mar 2010 10:01:55 +0000 (UTC) Received: by fxm25 with SMTP id 25so3096fxm.3 for ; Mon, 29 Mar 2010 03:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:date :message-id:to:subject:from:cc:x-mailer:mime-version:content-type :content-transfer-encoding; bh=VzHPSgcqkDnnGTbroxltJddVUYhVCEqZNXwIBZjBar4=; b=AdaywliFKu2wTqXL8eXeHreR7G9TGEanbGtHUH5p9dQsMrYEceAMcuUFcgcxn9+Gu3 c+5DirHCPkK6HgXrUHGVx6rdesDOvOuLzzuw65NsX0w7a9yN2nOzhaJQKt/eEMkzWiBJ 4OQh+FSx4HXNEAxK1Z3XeOz6FEPTtLZ4AiMSI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:message-id:to:subject:from:cc:x-mailer:mime-version :content-type:content-transfer-encoding; b=L4RkdtFwrVnFCitmOZTOpY86f2d6d0amfwdg8vM2stgvDDCTYx1Gn3YdYs3fLVgiyu y2ZS+nNZm5xsb/8PizdRoyAKKG0IsbOpmS/fab+KJsFq907OPCXtgixx4uTAEQDuXC9V /Nh2zjVmz9JZwHTPjQyO0yhZpptTD7gTd91SE= Received: by 10.87.62.39 with SMTP id p39mr2128528fgk.9.1269855329331; Mon, 29 Mar 2010 02:35:29 -0700 (PDT) Received: from jedi.localdomain (dial-92-52-48-145-orange.orange.sk [92.52.48.145]) by mx.google.com with ESMTPS id 4sm6217781fgg.2.2010.03.29.02.35.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 29 Mar 2010 02:35:28 -0700 (PDT) Sender: Ludovit Koren Received: from localhost (localhost [127.0.0.1]) by jedi.localdomain (Postfix) with ESMTP id 5E4901140A; Mon, 29 Mar 2010 11:35:27 +0200 (CEST) Date: Mon, 29 Mar 2010 11:35:27 +0200 (CEST) Message-Id: <20100329.113527.29593248145854380.koren@tempest.sk> To: Ali Mashtizadeh From: Ludovit Koren X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=utf-8 Content-Transfer-Encoding: base64 X-Mailman-Approved-At: Mon, 29 Mar 2010 11:32:47 +0000 Cc: freebsd-fs@freebsd.org, Dan Naumov , Aristedes Maniatis Subject: Re: boot code compatibility with ZFS X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 10:01:56 -0000 Pj4+Pj4gQWxpIE1hc2h0aXphZGVoIDxtYXNodGl6YWRlaEBnbWFpbC5jb20+IHdyaXRlczoNCg0K ICAgID4gWWVzIHRoZSBjb2RlIGluY2x1ZGVzIHN1cHBvcnQgZm9yIHJhaWR6Mi4gIA0KDQpkb2Vz IGl0IGluY2x1ZGUgdGhlIFpGUyB2ZXJzaW9uIDE0LiBhZnRlciB1cGdyYWRlIGFuZCBpbnN0YWxs YXRpb24gb2YNCmdwdHpmc2Jvb3QsIEkgYW0gbm90IGFibGUgdG8gYm9vdCBmcm9tIHJhaWR6IHdp dGggdGhlIGZvbGxvd2luZyBlcnJvcjoNCg0KZXJyb3IgMSBsYmEgLi4uDQouLi4uDQoNCk5vIFpG UyBwb29scyBsb2NhdGVkDQoNCg0KVGhlIHN5c3RlbSBpcyA4LjAtU1RBQkxFIChhYm91dCBGZWJy dWFyeSAxOXRoKQ0KDQpJIGFtIGxvc3QuIEFueSBoaW50IGdyZWF0bHkgYXBwcmVjaWF0ZWQgKEkg Z29vZ2xlZCAtIG5vIHNvbHV0aW9uDQpmb3VuZCkNCg0KUmVnYXJkcywNCg0KbGsNCg0KICAgID4g T24gU2F0LCBNYXIgMjcsIDIwMTAgYXQgNjowOSBQTSwgQXJpc3RlZGVzIE1hbmlhdGlzIDxhcmlA aXNoLmNvbS5hdT4gd3JvdGU6DQogICAgPj4gT24gMjgvMDMvMTAgMTE6NDcgQU0sIERhbiBOYXVt b3Ygd3JvdGU6DQogICAgPj4+PiANCiAgICA+Pj4+IEZyZWVCU0QgNy4xOiBaRlMgdmVyc2lvbiA2 LCBubyBaRlMgYm9vdCBjYXBhYmlsaXR5IEZyZWVCU0QNCiAgICA+Pj4+IDcuMjogWkZTIHZlcnNp b24gNiwgemZzYm9vdCBvbmx5LCBib290IGZyb20gc2luZ2xlIHZkZXYgcG9vbA0KICAgID4+Pj4g b25seSBGcmVlQlNEIDcuMzogWkZTIHZlcnNpb24gMTMsIHpmc2Jvb3QgYnJva2VuLCBubyBaRlMg Ym9vdA0KICAgID4+Pj4gY2FwYWJpbGl0eQ0KICAgID4+Pj4gDQogICAgPj4+PiBGcmVlQlNEIDgu MDogWkZTIHZlcnNpb24gMTMsIGdwdHpmc2Jvb3QgYW5kIHpmc2Jvb3QsIGJvb3QNCiAgICA+Pj4+ IGZyb20gbWlycm9yZWQgcG9vbCBvciBzaW5nbGUgdmRldiwgUkFJRFogbm90IHN1cHBvcnRlZCwN CiAgICA+Pj4+IGRlZ3JhZGVkIHBvb2wgbm90IHN1cHBvcnRlZA0KICAgID4+PiANCiAgICA+Pj4g SSBhbSBub3QgcmVhbGx5IHN1cmUgd2hhdCBnaXZlcyB5b3UgdGhlIGlkZWEgdGhhdCBib290aW5n IG9mZg0KICAgID4+PiBhIGRlZ3JhZGVkIHBvb2wgaXMgbm90IHN1cHBvcnRlZCBpbiA4LjAuIEkg aGF2ZSBhIHpmc3Jvb3QvYm9vdA0KICAgID4+PiBjb25maWd1cmF0aW9uIHNpdHRpbmcgb24gYSBt aXJyb3IgYW5kIEkgaGF2ZSB0ZXN0ZWQgeWFua2luZw0KICAgID4+PiBvbmUgZHJpdmUgYXQgYSB0 aW1lIChyZXN1bHRpbmcgaW4gYSBkZWdyYWRlZCBwb29sKSBhbmQgYm9vdGluZw0KICAgID4+PiB3 aXRoIG9ubHkgMSBkaXNrIHByZXNlbnQgYW5kIGl0IHdvcmtlZCBqdXN0IGZpbmUuDQogICAgPj4+ IA0KICAgID4+PiAtIFNpbmNlcmVseSwgRGFuIE5hdW1vdg0KICAgID4+IA0KICAgID4+IEFoLCB0 aGFua3MgZm9yIHRoYXQuIEkganVzdCByZWFkIHRoYXQgb24gb25lIG9mIHRoZSBGcmVlQlNEDQog ICAgPj4gbGlzdHMgcmVjZW50bHkuICBDYW4ndCBzZWUgdGhlIGV4YWN0IHBvc3Qgbm93LCBidXQg SSdtIGhhcHB5IHRvDQogICAgPj4gYmUgd3JvbmcsIHBlcmhhcHMgdGhhdCB3YXMgYW4gb2xkZXIg bGltaXRhdGlvbiBpbiBhIHByZXZpb3VzDQogICAgPj4gcmVsZWFzZS4NCiAgICA+PiANCiAgICA+ PiBGcm9tIEFsaSdzIGNvbW1lbnQsIEkgZ3Vlc3Mgd2UgY291bGQgYWRkIGZvciB0aGUgZnV0dXJl IHJlbGVhc2UNCiAgICA+PiBvZiA4LjE6DQogICAgPj4gDQogICAgPj4gRnJlZUJTRCA4LjE6IFpG UyB2ZXJzaW9uIDEzLCBncHR6ZnNib290IGFuZCB6ZnNib290LCBib290IGZyb20NCiAgICA+PiBt aXJyb3JlZCBwb29sLCBSQUlEWiBvciBzaW5nbGUgdmRldi4NCiAgICA+PiANCiAgICA+PiBEb2Vz IHRoYXQgaW5jbHVkZSBSQUlEWjI/DQogICAgPj4gDQogICAgPj4gDQogICAgPj4gSSdtIGhhcHB5 IHRvIHdyaXRlIHVwIG15IHJlc3VsdHMgZm9yIHRoZSB3aWtpIChhbHRob3VnaCBlZGl0aW5nDQog ICAgPj4gc2VlbXMgdG8gYmUgY2xvc2VkIHRvIG9ubHkgY2VydGFpbiBwZW9wbGUpLCBvbmNlIEkg aGF2ZSBzb21lDQogICAgPj4gZGVmaW5pdGl2ZSBhbnN3ZXJzIGZvciB3aGF0IGlzIHN1cHBvcnRl ZCB3aGVyZS4gQW5kIGhvcGVmdWxseQ0KICAgID4+IHRoZXJlIHdpbGwgYmUgYSA3LjNwMSB3aGlj aCByZXN0b3JlcyBaRlMgYm9vdGluZyBhYmlsaXR5Lg0KICAgID4+IA0KICAgID4+IA0KICAgID4+ IFJlZ2FyZHMNCiAgICA+PiANCiAgICA+PiBBcmkgTWFuaWF0aXMNCiAgICA+PiANCiAgICA+PiAN CiAgICA+PiAtLQ0KICAgIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tPiANCiAgICA+PiBBcmlz dGVkZXMgTWFuaWF0aXMgaXNoIGh0dHA6Ly93d3cuaXNoLmNvbS5hdSBMZXZlbCAxLCAzMCBXaWxz b24NCiAgICA+PiBTdHJlZXQgTmV3dG93biAyMDQyIEF1c3RyYWxpYSBwaG9uZSArNjEgMiA5NTUw IDUwMDEgwqAgZmF4ICs2MSAyDQogICAgPj4gOTU1MCA0MDAxIEdQRyBmaW5nZXJwcmludCBDQkZC IDg0QjQgNzM4RCA0RTg3IDVFNUMgwqA1RUZBIEVGNkENCiAgICA+PiA3RDJFIDNFNDkgMTAyQSBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KICAgID4+IGZy ZWVic2QtZnNAZnJlZWJzZC5vcmcgbWFpbGluZyBsaXN0DQogICAgPj4gaHR0cDovL2xpc3RzLmZy ZWVic2Qub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWJzZC1mcyBUbw0KICAgID4+IHVuc3Vic2Ny aWJlLCBzZW5kIGFueSBtYWlsIHRvDQogICAgPj4gImZyZWVic2QtZnMtdW5zdWJzY3JpYmVAZnJl ZWJzZC5vcmciDQogICAgPj4gDQoNCg0KDQotLSANCiAgICA+IEFsaSBNYXNodGl6YWRlaCDYudmE 24wg2YXYtNiq24wg2LLYp9iv2YcNCiAgICA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fDQogICAgPiBmcmVlYnNkLWZzQGZyZWVic2Qub3JnIG1haWxpbmcg bGlzdA0KICAgID4gaHR0cDovL2xpc3RzLmZyZWVic2Qub3JnL21haWxtYW4vbGlzdGluZm8vZnJl ZWJzZC1mcyBUbw0KICAgID4gdW5zdWJzY3JpYmUsIHNlbmQgYW55IG1haWwgdG8NCiAgICA+ICJm cmVlYnNkLWZzLXVuc3Vic2NyaWJlQGZyZWVic2Qub3JnIg0KDQo= From owner-freebsd-fs@FreeBSD.ORG Mon Mar 29 14:28:49 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF53F106564A for ; Mon, 29 Mar 2010 14:28:49 +0000 (UTC) (envelope-from Pascal.Stumpf@cubes.de) Received: from smtprelay03.ispgateway.de (smtprelay03.ispgateway.de [80.67.31.37]) by mx1.freebsd.org (Postfix) with ESMTP id 6EF438FC08 for ; Mon, 29 Mar 2010 14:28:49 +0000 (UTC) Received: from [62.224.184.41] (helo=ikarus.local.cubes.de) by smtprelay03.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1NwFlU-0006xK-H9 for freebsd-fs@freebsd.org; Mon, 29 Mar 2010 16:16:28 +0200 From: Pascal Stumpf To: freebsd-fs@freebsd.org Date: Mon, 29 Mar 2010 16:16:27 +0200 User-Agent: KMail/1.12.4 (FreeBSD/8.0-STABLE; KDE/4.3.5; amd64; ; ) In-Reply-To: A4F324C1-FD40-46D1-905D-6D3EEEB1CF05@lexasoft.ru MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <201003291616.27838.Pascal.Stumpf@cubes.de> X-Df-Sender: 429867 Subject: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 14:28:49 -0000 I have exactly that setup (3 drives, GPT partitions aligned to 4k=20 boundaries, geli with 4k sector size, on top of that RAID-Z), and=20 the write performance is the same as with a single ZFS partition on=20 a regular 512-sector disk. So yes, it does work. (I don=E2=80=99t have a=20 benchmark on how geli affects RAID-Z performance though, since=20 all my ZFS partitions are encrypted. From owner-freebsd-fs@FreeBSD.ORG Mon Mar 29 14:40:48 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E025E106567B for ; Mon, 29 Mar 2010 14:40:48 +0000 (UTC) (envelope-from me@lexasoft.ru) Received: from relay.wahome.ru (relay.wahome.ru [95.211.21.141]) by mx1.freebsd.org (Postfix) with ESMTP id A70C48FC1D for ; Mon, 29 Mar 2010 14:40:48 +0000 (UTC) Received: from mmx.lexasoft.ru (mmx.lexasoft.ru [92.241.160.6]) by relay.wahome.ru (Postfix) with ESMTP id 0C9616B201E; Mon, 29 Mar 2010 18:37:56 +0400 (MSD) Received: from [192.168.40.138] (unknown [124.157.205.118]) by mmx.lexasoft.ru (Postfix) with ESMTPSA id D93C528490; Mon, 29 Mar 2010 18:40:44 +0400 (MSD) Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=utf-8 From: Alexey Tarasov In-Reply-To: <201003291616.27838.Pascal.Stumpf@cubes.de> Date: Mon, 29 Mar 2010 18:40:37 +0400 Content-Transfer-Encoding: quoted-printable Message-Id: <9D752CC7-5CCA-454D-8BEC-F3D5E6F8445C@lexasoft.ru> References: <201003291616.27838.Pascal.Stumpf@cubes.de> To: Pascal Stumpf X-Mailer: Apple Mail (2.1077) Cc: freebsd-fs@freebsd.org Subject: Re: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 14:40:49 -0000 Thank you for your reply, I will try to realign my partitions as soon as = possible. On 29.03.2010, at 18:16, Pascal Stumpf wrote: > I have exactly that setup (3 drives, GPT partitions aligned to 4k=20 > boundaries, geli with 4k sector size, on top of that RAID-Z), and=20 > the write performance is the same as with a single ZFS partition on=20 > a regular 512-sector disk. So yes, it does work. (I don=E2=80=99t have = a=20 > benchmark on how geli affects RAID-Z performance though, since=20 > all my ZFS partitions are encrypted. > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" -- Alexey Tarasov (\__/)=20 (=3D'.'=3D)=20 E[: | | | | :]=D0=97=20 (")_(") From owner-freebsd-fs@FreeBSD.ORG Mon Mar 29 15:18:46 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4E681065674 for ; Mon, 29 Mar 2010 15:18:46 +0000 (UTC) (envelope-from freebsd-fs@m.gmane.org) Received: from lo.gmane.org (lo.gmane.org [80.91.229.12]) by mx1.freebsd.org (Postfix) with ESMTP id 87D468FC37 for ; Mon, 29 Mar 2010 15:18:45 +0000 (UTC) Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NwGjj-0004hx-9G for freebsd-fs@freebsd.org; Mon, 29 Mar 2010 17:18:43 +0200 Received: from lara.cc.fer.hr ([161.53.72.113]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 29 Mar 2010 17:18:43 +0200 Received: from ivoras by lara.cc.fer.hr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 29 Mar 2010 17:18:43 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-fs@freebsd.org From: Ivan Voras Date: Mon, 29 Mar 2010 17:18:35 +0200 Lines: 16 Message-ID: References: <201003291616.27838.Pascal.Stumpf@cubes.de> <9D752CC7-5CCA-454D-8BEC-F3D5E6F8445C@lexasoft.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: lara.cc.fer.hr User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.5) Gecko/20100118 Thunderbird/3.0 In-Reply-To: <9D752CC7-5CCA-454D-8BEC-F3D5E6F8445C@lexasoft.ru> X-Enigmail-Version: 1.0.1 Subject: Re: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 15:18:46 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/29/10 16:40, Alexey Tarasov wrote: > Thank you for your reply, I will try to realign my partitions as soon as possible. Another possible solution is gnop, which I think somebody already mentioned. It too can create sector sizes of multiple base sector size. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkuwxMsACgkQldnAQVacBcg4NQCcCV3GaPcbN+3eZV9+8T0ute4e bqMAn3GceXqmxsH8fznglIxqEQ2hpzaU =+M9c -----END PGP SIGNATURE----- From owner-freebsd-fs@FreeBSD.ORG Mon Mar 29 15:26:49 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0571E106566B; Mon, 29 Mar 2010 15:26:49 +0000 (UTC) (envelope-from me@lexasoft.ru) Received: from relay.wahome.ru (relay.wahome.ru [95.211.21.141]) by mx1.freebsd.org (Postfix) with ESMTP id BC70D8FC19; Mon, 29 Mar 2010 15:26:48 +0000 (UTC) Received: from mmx.lexasoft.ru (mmx.lexasoft.ru [92.241.160.6]) by relay.wahome.ru (Postfix) with ESMTP id A6B4A6B2015; Mon, 29 Mar 2010 19:23:56 +0400 (MSD) Received: from [192.168.40.138] (unknown [124.157.205.118]) by mmx.lexasoft.ru (Postfix) with ESMTPSA id 5618B28490; Mon, 29 Mar 2010 19:26:44 +0400 (MSD) Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=utf-8 From: Alexey Tarasov In-Reply-To: Date: Mon, 29 Mar 2010 19:26:39 +0400 Content-Transfer-Encoding: quoted-printable Message-Id: <31E6FC89-84B0-4D36-AB65-E9CE3016EB0E@lexasoft.ru> References: <201003291616.27838.Pascal.Stumpf@cubes.de> <9D752CC7-5CCA-454D-8BEC-F3D5E6F8445C@lexasoft.ru> To: Ivan Voras , freebsd-fs@freebsd.org X-Mailer: Apple Mail (2.1077) Cc: Subject: Re: ZFS raidz and 4k sector disks X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 15:26:49 -0000 There is one problem with this solution: GNOP can't be attached to = root-on-ZFS configuration. On 29.03.2010, at 19:18, Ivan Voras wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > On 03/29/10 16:40, Alexey Tarasov wrote: >> Thank you for your reply, I will try to realign my partitions as soon = as possible. >=20 > Another possible solution is gnop, which I think somebody already > mentioned. It too can create sector sizes of multiple base sector = size. -- Alexey Tarasov (\__/)=20 (=3D'.'=3D)=20 E[: | | | | :]=D0=97=20 (")_(") From owner-freebsd-fs@FreeBSD.ORG Tue Mar 30 17:58:53 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C73E1065673 for ; Tue, 30 Mar 2010 17:58:53 +0000 (UTC) (envelope-from trevor.hearn@Vanderbilt.Edu) Received: from mailgate.vanderbilt.edu (mailgate.vanderbilt.edu [129.59.4.20]) by mx1.freebsd.org (Postfix) with ESMTP id F01788FC1E for ; Tue, 30 Mar 2010 17:58:52 +0000 (UTC) Received: from its-hcwnem22.ds.vanderbilt.edu ([10.1.137.30]) by mailgate06 (8.14.3/8.14.3) with ESMTP id o2UHtAXf013995 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT) for ; Tue, 30 Mar 2010 12:58:28 -0500 Received: from its-hcwnem04.ds.Vanderbilt.edu ([10.2.171.184]) by ITS-SCWNEM24.ds.Vanderbilt.edu ([::1]) with mapi; Tue, 30 Mar 2010 12:55:34 -0500 From: "Hearn, Trevor" To: "freebsd-fs@freebsd.org" Date: Tue, 30 Mar 2010 12:55:33 -0500 Thread-Topic: Questions about GPT and it's replacement... Thread-Index: AcrQMjFyb8UwnTwlEd+ZgwAbY6lRSw== Message-ID: Accept-Language: en-US Content-Language: en X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.8161:2.4.5, 1.2.40, 4.0.166 definitions=2010-03-30_16:2010-02-06, 2010-03-30, 2010-03-30 signatures=0 X-PPS: No, score=0 Subject: Questions about GPT and it's replacement... X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2010 17:58:53 -0000 Heya Everyone,=20 I have a FreeBSD 6.4 system with a Promise array attached to it via a Qlogi= c Fibre Channel card. I have been unable to get 7.2 to get past the FW:Get mailbox error, so I installed FREEBSD 8.0 on it, and have been playing around. I am used to GPT, and have set up all of the partitions in the past using it. I see that someone did GPTE, but I can't seem to get it to see th= e devices and partitions in the same way that it did before. Since GPTE seems experimental, and self-proclaimed as 'hackerish' what should I use to cut u= p a 25.5tb array? GPART? I am at a loss at the moment. I thought that GPTE wa= s doing what I needed, but when I try and mount the partitions, I get no success. What am I missing? -Trevor From owner-freebsd-fs@FreeBSD.ORG Tue Mar 30 19:35:23 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF9761065705 for ; Tue, 30 Mar 2010 19:35:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 81F308FC32 for ; Tue, 30 Mar 2010 19:35:23 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 2BEA146B51; Tue, 30 Mar 2010 15:35:23 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 05EED8A021; Tue, 30 Mar 2010 15:35:22 -0400 (EDT) From: John Baldwin To: freebsd-fs@freebsd.org Date: Tue, 30 Mar 2010 15:09:30 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201003301509.30826.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 30 Mar 2010 15:35:22 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.8 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Subject: Re: Questions about GPT and it's replacement... X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2010 19:35:23 -0000 On Tuesday 30 March 2010 1:55:33 pm Hearn, Trevor wrote: > Heya Everyone, > I have a FreeBSD 6.4 system with a Promise array attached to it via a Qlogic > Fibre Channel card. I have been unable to get 7.2 to get past the FW:Get > mailbox error, so I installed FREEBSD 8.0 on it, and have been playing > around. I am used to GPT, and have set up all of the partitions in the past > using it. I see that someone did GPTE, but I can't seem to get it to see the > devices and partitions in the same way that it did before. Since GPTE seems > experimental, and self-proclaimed as 'hackerish' what should I use to cut up > a 25.5tb array? GPART? I am at a loss at the moment. I thought that GPTE was > doing what I needed, but when I try and mount the partitions, I get no > success. What am I missing? You should still use GPT, but you now have to use the 'gpart' utility to manage GPT partitions instead of gpt(8). -- John Baldwin From owner-freebsd-fs@FreeBSD.ORG Wed Mar 31 09:56:24 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 016221065670 for ; Wed, 31 Mar 2010 09:56:24 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 9F9158FC15 for ; Wed, 31 Mar 2010 09:56:23 +0000 (UTC) Received: from outgoing.leidinger.net (pD9E2CFB7.dip.t-dialin.net [217.226.207.183]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id C822E8442CF; Wed, 31 Mar 2010 11:56:18 +0200 (CEST) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id D54185082; Wed, 31 Mar 2010 11:56:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1270029375; bh=00f70Mwg644hgYZQkOEA+ZechiLu7fA+x7cbi9WHvdg=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=2SAXZt3igQbK53YI00QDJ5bXJ6I9MeyzZqlP8OK52jWLF3wLX8w8ltjBeu5Mn9zFL MYDbvXWbYf7YXKqn00tMRenzLsESXY9c414H3J/k8wB/5SHDItYxhL09UN0LatAARK G45rWSeeJd8V7+COKF/3wxFLmQkKTmdTr5MIUAoMiXb7vO2zoMnDQpthtN2mQolE5o qf12A0pO/g9ky0D9BEF0nt5H5oxPWOvbUavSHfC4hfPBSEc4b/SPfIMIL4ZbEwqxgT oa1/5zNEp5kn8M8kHnuj+YIG8onXKhmVc+sFMUKx4ZDA2NfLOFp+FdDSD+JtuBdROZ CPpNnI4OnWcbg== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id o2V9uFEd074541; Wed, 31 Mar 2010 11:56:15 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 31 Mar 2010 11:56:15 +0200 Message-ID: <20100331115615.478511gt4oto94q8@webmail.leidinger.net> Date: Wed, 31 Mar 2010 11:56:15 +0200 From: Alexander Leidinger To: Aristedes Maniatis References: <4BAEAC62.4060401@ish.com.au> In-Reply-To: <4BAEAC62.4060401@ish.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: C822E8442CF.4A9AD X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.44, required 6, autolearn=disabled, ALL_TRUSTED -1.44, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1270634179.56655@xQbQWrQv8TNh2Olz/lxxUw X-EBL-Spam-Status: No Cc: freebsd-fs@freebsd.org, Dan Naumov Subject: Re: boot code compatibility with ZFS X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 09:56:24 -0000 Quoting Aristedes Maniatis (from Sun, 28 Mar 2010 12:09:54 +1100): > I'm happy to write up my results for the wiki (although editing > seems to be closed to only certain people), http://wiki.freebsd.org/AboutWiki Bye, Alexander. -- BOFH excuse #224: Jan 9 16:41:27 huber su: 'su root' succeeded for .... on /dev/pts/1 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-freebsd-fs@FreeBSD.ORG Wed Mar 31 14:54:11 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5257D106566C; Wed, 31 Mar 2010 14:54:11 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 636398FC1A; Wed, 31 Mar 2010 14:54:10 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA21421; Wed, 31 Mar 2010 17:54:08 +0300 (EEST) (envelope-from avg@freebsd.org) Message-ID: <4BB36210.5040102@freebsd.org> Date: Wed, 31 Mar 2010 17:54:08 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.24 (X11/20100319) MIME-Version: 1.0 To: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org References: <4BA8CD21.3000803@freebsd.org> In-Reply-To: <4BA8CD21.3000803@freebsd.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Subject: Re: on st_blksize value X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 14:54:11 -0000 on 23/03/2010 16:16 Andriy Gapon said the following: > First, what I am proposing: > --- a/sys/kern/vfs_vnops.c > +++ b/sys/kern/vfs_vnops.c > @@ -790,11 +790,11 @@ vn_stat(vp, sb, active_cred, file_cred, td) > * to file" > * Default to PAGE_SIZE after much discussion. > * XXX: min(PAGE_SIZE, vp->v_bufobj.bo_bsize) may be more correct. > */ > > - sb->st_blksize = PAGE_SIZE; > + sb->st_blksize = max(PAGE_SIZE, vap->va_blocksize); If no one has objections, suggestions or opinions, I am going to commit this. I will probably change the scary comment too. > > sb->st_flags = vap->va_flags; > if (priv_check(td, PRIV_VFS_GENERATION)) > sb->st_gen = 0; > else > > Explanation: > 1. IMO it is not nice that we totally ignore va_blocksize value that can be set by > a filesystem. This takes away flexibility. That va_blocksize value might really > turn out to be optimal given the filesystem implementation. > 2. As currently st_blksize is always PAGE_SIZE, it is playing safe to not use any > smaller value. For some case this might not be optimal (which I personally > doubt), but at least nothing should get broken. > > One practical benefit can be with ZFS: if a filesystem has recordsize > PAGE_SIZE > (e.g. default 128K) and it has checksums or compression enabled, then > (over-)writing in blocks smaller than recordsize would require reading of a whole > record first. And some applications do use st_blksize as a hint (just for the > record: some other use f_iosize instead, and yet some use a hardcoded value). > BTW, some torrent-like applications can serve as a good example of applications > that overwrite chunks of existing files. > > Additionally, here's a little bit of history that explains the PAGE_SIZE ("much > discussion") comment in vn_stat. It seems that the comment may be misleading > nowadays. > It was introduced in r89784 and at that time it applied only to the case of > non-VREG and non-vn_isdisk vnodes. > Then, almost 3 years later, in revision 136966 code for VREG vnodes and vn_isdisk > vnodes was dropped, the XXX comment was introduced, and we ended up with the > current state of matters. > > BTW, I am not sure about the XXX comment either. > Using bo_bsize may be a nice shortcut, but it would also take away some > flexibility. Filesystems can already set bo_bsize and va_blocksize to the same > value, but there could be special cases where they not need be the same. > > Thanks a lot for opinions and suggestions! > > P.S. Yes, I have read the following interesting thread _completely_: > http://lists.freebsd.org/pipermail/freebsd-fs/2007-May/003155.html > And this one too: > http://freebsd.monkey.org/freebsd-fs/200810/msg00059.html > Unfortunately, the discussions didn't result in any action. > -- Andriy Gapon From owner-freebsd-fs@FreeBSD.ORG Wed Mar 31 14:54:46 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D915F106566C; Wed, 31 Mar 2010 14:54:46 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id EB2EA8FC08; Wed, 31 Mar 2010 14:54:45 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA21430; Wed, 31 Mar 2010 17:54:44 +0300 (EEST) (envelope-from avg@freebsd.org) Message-ID: <4BB36234.8070907@freebsd.org> Date: Wed, 31 Mar 2010 17:54:44 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.24 (X11/20100319) MIME-Version: 1.0 To: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org References: <4BA7B9E3.3080003@freebsd.org> In-Reply-To: <4BA7B9E3.3080003@freebsd.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Subject: Re: geom_vfs: disallow multiple readonly mounts of a device X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 14:54:46 -0000 If no one has objections, suggestions or opinions, I am going to commit this. on 22/03/2010 20:41 Andriy Gapon said the following: > Currently FreeBSD allows multiple readonly mounts of the same device. > This feature seems to be introduced along with GEOM. Before that, only one mount > of a device was allowed, whether readonly or not. Other (major) BSDs still work > that way. > Unfortunately, the feature has never really worked correctly because of some > architectural/design issues in our buffer cache layer/interface. > Multiple shared mounts are allowed to happen but later on, during filesystem > access or at unmount time, a system would crash. > > Because of this, I propose to disable shared mounting feature for time being. > In my opinion it is very unlikely that anybody depends on this feature now, but > nullfs can be used as its replacement. In fact, it could be even more efficient > if the same files are access via different mount points. > > The proposed patch is a greatly reduced version of a patch by Pawel Jakub Dawidek: > http://people.freebsd.org/~pjd/patches/mro_mount.patch > Pawel's patch, in fact, fixes the shared mounting feature. > Unfortunately, at least one filesystem (FFS) is quite intrusive at what it does > with a device vnode (or rather its bufobj) when it attempts mounting. > So, in some edge cases (synthetic or accidental) a system may still crash even > with the Pawel's patch. So, I think that it should not be committed until after > all filesystems in the tree are made to play nice. Otherwise, I like it. > > As an afterthought, perhaps it is the Pawel's patch that we should actually use > with one change - add a sysctl that enables/disables shared mounts and make them > disabled by default. > > Thank you very for the feedback. > > --- a/sys/geom/geom_vfs.c > +++ b/sys/geom/geom_vfs.c > @@ -161,6 +161,10 @@ g_vfs_open > g_topology_assert(); > > *cpp = NULL; > + bo = &vp->v_bufobj; > + if (bo->bo_private != vp) > + return (EBUSY); > + > pp = g_dev_getprovider(vp->v_rdev); > if (pp == NULL) > return (ENOENT); > @@ -176,6 +180,6 @@ g_vfs_open > vnode_create_vobject(vp, pp->mediasize, curthread); > VFS_UNLOCK_GIANT(vfslocked); > *cpp = cp; > - bo = &vp->v_bufobj; > + cp->private = vp; > bo->bo_ops = g_vfs_bufops; > bo->bo_private = cp; > @@ -196,5 +200,6 @@ g_vfs_close > gp = cp->geom; > bo = gp->softc; > bufobj_invalbuf(bo, V_SAVE, 0, 0); > + bo->bo_private = cp->private; > g_wither_geom_close(gp, ENXIO); > } > -- Andriy Gapon From owner-freebsd-fs@FreeBSD.ORG Wed Mar 31 16:21:58 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 62CAF106566B for ; Wed, 31 Mar 2010 16:21:58 +0000 (UTC) (envelope-from mj@feral.com) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.freebsd.org (Postfix) with ESMTP id 27FB18FC13 for ; Wed, 31 Mar 2010 16:21:57 +0000 (UTC) Received: from [192.168.0.102] (m206-63.dsl.tsoft.com [198.144.206.63]) by ns1.feral.com (8.14.3/8.14.3) with ESMTP id o2VGLvFe027137 for ; Wed, 31 Mar 2010 08:21:57 -0800 (PST) (envelope-from mj@feral.com) Message-ID: <4BB376A8.7060702@feral.com> Date: Wed, 31 Mar 2010 09:22:00 -0700 From: Matthew Jacob User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: freebsd-fs@freebsd.org References: <4BA7B9E3.3080003@freebsd.org> <4BB36234.8070907@freebsd.org> In-Reply-To: <4BB36234.8070907@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Default is to whitelist mail, not delayed by milter-greylist-4.2.3 (ns1.feral.com [192.67.166.1]); Wed, 31 Mar 2010 08:21:57 -0800 (PST) Subject: Re: geom_vfs: disallow multiple readonly mounts of a device X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 16:21:58 -0000 >> Because of this, I propose to disable shared mounting feature for time being. >> In my opinion it is very unlikely that anybody depends on this feature now, but >> nullfs can be used as its replacement. In fact, it could be even more efficient >> if the same files are access via different mount points. >> For me using nulls is the key point. This allows you to affect the name space for various policy reasons. From owner-freebsd-fs@FreeBSD.ORG Wed Mar 31 18:47:59 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 75C4F1065675; Wed, 31 Mar 2010 18:47:59 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4CB9D8FC1D; Wed, 31 Mar 2010 18:47:59 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2VIlxvp014826; Wed, 31 Mar 2010 18:47:59 GMT (envelope-from mm@freefall.freebsd.org) Received: (from mm@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2VIlxr3014822; Wed, 31 Mar 2010 18:47:59 GMT (envelope-from mm) Date: Wed, 31 Mar 2010 18:47:59 GMT Message-Id: <201003311847.o2VIlxr3014822@freefall.freebsd.org> To: mm@FreeBSD.org, mm@FreeBSD.org, freebsd-fs@FreeBSD.org From: mm@FreeBSD.org Cc: Subject: Re: kern/135594: [zfs] Single dataset unresponsive with Samba X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 18:47:59 -0000 Synopsis: [zfs] Single dataset unresponsive with Samba State-Changed-From-To: open->closed State-Changed-By: mm State-Changed-When: Wed Mar 31 18:47:58 UTC 2010 State-Changed-Why: Closed on submitter request. http://www.freebsd.org/cgi/query-pr.cgi?pr=135594 From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 01:20:44 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F12B106566B; Thu, 1 Apr 2010 01:20:44 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 057388FC0C; Thu, 1 Apr 2010 01:20:44 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o311Kh0x052997; Thu, 1 Apr 2010 01:20:43 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o311KhSd052985; Thu, 1 Apr 2010 01:20:43 GMT (envelope-from linimon) Date: Thu, 1 Apr 2010 01:20:43 GMT Message-Id: <201004010120.o311KhSd052985@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/145246: [ufs] dirhash in 7.3 gratuitously frees hashes when it shouldn't [regression] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 01:20:44 -0000 Old Synopsis: dirhash in 7.3 gratuitously frees hashes when it shouldn't New Synopsis: [ufs] dirhash in 7.3 gratuitously frees hashes when it shouldn't [regression] Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: linimon Responsible-Changed-When: Thu Apr 1 01:19:41 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=145246 From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 13:10:13 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 27E8A106568F for ; Thu, 1 Apr 2010 13:10:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DCEF48FC2E for ; Thu, 1 Apr 2010 13:10:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o31DAC0i099992 for ; Thu, 1 Apr 2010 13:10:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o31DACJO099991; Thu, 1 Apr 2010 13:10:12 GMT (envelope-from gnats) Date: Thu, 1 Apr 2010 13:10:12 GMT Message-Id: <201004011310.o31DACJO099991@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: John Baldwin Cc: Subject: Re: kern/145246: [ufs] dirhash in 7.3 gratuitously frees hashes when it shouldn't [regression] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John Baldwin List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 13:10:13 -0000 The following reply was made to PR kern/145246; it has been noted by GNATS. From: John Baldwin To: bug-followup@freebsd.org, martin.birgmeier@aon.at Cc: Subject: Re: kern/145246: [ufs] dirhash in 7.3 gratuitously frees hashes when it shouldn't [regression] Date: Thu, 1 Apr 2010 08:56:03 -0400 I suspect the fix here is to provide a tunable/sysctl that can be used to disable the dirhash lowmem handler for workloads where it does more harm than good. -- John Baldwin From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 13:41:03 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0245D106564A; Thu, 1 Apr 2010 13:41:03 +0000 (UTC) (envelope-from bartosz.stec@it4pro.pl) Received: from mainframe.kkip.pl (kkip.pl [87.105.164.78]) by mx1.freebsd.org (Postfix) with ESMTP id 443C38FC0A; Thu, 1 Apr 2010 13:41:02 +0000 (UTC) Received: from mb01.admin.lan.kkip.pl ([10.66.3.254]) by mainframe.kkip.pl with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.71 (FreeBSD)) (envelope-from ) id 1NxKMZ-000Cps-Mx; Thu, 01 Apr 2010 15:23:19 +0200 Message-ID: <4BB49E3F.7070506@it4pro.pl> Date: Thu, 01 Apr 2010 15:23:11 +0200 From: Bartosz Stec Organization: IT4Pro User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.8) Gecko/20100227 Lightning/1.0b1 Thunderbird/3.0.3 MIME-Version: 1.0 To: freebsd-current@freebsd.org, freebsd-fs@freebsd.org X-Stationery: 0.5.1 X-Authenticated-User: bartosz.stec@it4pro.pl X-Authenticator: plain X-Sender-Verify: SUCCEEDED (sender exists & accepts mail) X-Spam-Score: -7.0 X-Spam-Score-Int: -69 X-Exim-Version: 4.71 (build at 02-Feb-2010 20:10:28) X-Date: 2010-04-01 15:23:19 X-Connected-IP: 10.66.3.254:2203 X-Message-Linecount: 172 X-Body-Linecount: 159 X-Message-Size: 7504 X-Body-Size: 6932 X-Received-Count: 1 X-Recipient-Count: 2 X-Local-Recipient-Count: 2 X-Local-Recipient-Defer-Count: 0 X-Local-Recipient-Fail-Count: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: gpart failing with no such geom after gpt corruption X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 13:41:03 -0000 Hello ZFS and GPT hackers :) I'm sending this message to both freebsd-current and freebsd-fs because it doesn't seems to be a CURRENT-specific issue. Yesterday I tried to migrate my mixed UFS/RAIDZ config to clean RAIDZ with GPT boot. I've following mostly this guide: http://wiki.freebsd.org/RootOnZFS/GPTZFSBoot/RAIDZ1 I'm using CURRENT on 3x40GB HDDs (ad0-ad3) and additional 250GB HDD has been used for data migration (ad4). Data was copied form RAIDZ to 250GB HDD, GPT sheme was created on 40GB HDDs, then new zpool on them, and finally data went back to RAIDZ. Booting from RAIDZ was succesful, so far so good. After a while I've noticed some SMART errors on ad1, so I've booted machine with seatools for dos and made long test. One bad sector was found and reallocated, nothing to worry about. As I was in seatools already, I've decided to adjust LBA size on that disk (seatools can do that), because it was about 30MB larger than the other two, and because of that I had to adjust size of freebsd-zfs partition on that disk to match exact size of others (otherwise 'zpool create' will complain). So LBA was adjusted and system rebooted. Yes, I was aware that changing disk size probably end with corrupted GPT and data loss, but it doesn't seem to be a big deal for me as far as 2/3 of zpool is alive, because I can always recreate gpt and resilver ad1. Unfortunately it wasn't so easy. First of all system booted, and as I expected kernel message shows GPT error on ad1. Zpool was degraded but alive and kicking. However, when I tried to execute any gpart command on ad1, it return: ad1: no such geom ad1 was present under /dev, and it could be accessed by sysinstall/fdisk, but no with gpart. I've created bsd slice with sysinstall on ad1 and rebooted, with hope that after reboot I could acces ad1 with gpart and recreate GPT scheme. Another surprise - system didn't boot at all, rebooting after couple of seconds in loader (changing boot device didn't make a difference). Only way I could boot system at this moment was connecting 250GB HDD which fortunately still had data from zpool migration and boot from it. Another surprise - kernel was still complaining about GPT corruption on ad1. I had no other ideas so I ran dd if=/dev/zero of=/dev/ad1 bs=512 count=512 to clear beginning of the hdd. After that disk was still unaccesible fromt gpart, so I tried sysinstall/fdisk againt to create standard BSD partitioning scheme and rebooted system. After that finally gpart started to talk with ad1 and GPT scheme and zpool has been recreated and work as it supposed to. Still, how can we clear broken GPT data after it got corrupted? Why gpart has been showing "ad1: no such geom", and how can we deal with this problem? Finally, why gptzfsboot failed with GPT corrupted on other disk after trying to fix it, while it booted at first place? Or maybe changing LBA size of already partitioned HDD is extreme case, and the only way these problems could be triggered ;)? Cheers! -- Bartosz Stec From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 15:00:20 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 43192106566B for ; Thu, 1 Apr 2010 15:00:20 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 311E18FC08 for ; Thu, 1 Apr 2010 15:00:20 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o31F0Jfv013968 for ; Thu, 1 Apr 2010 15:00:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o31F0JDO013967; Thu, 1 Apr 2010 15:00:19 GMT (envelope-from gnats) Date: Thu, 1 Apr 2010 15:00:19 GMT Message-Id: <201004011500.o31F0JDO013967@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: Martin Birgmeier Cc: Subject: Re: kern/145246: [ufs] dirhash in 7.3 gratuitously frees hashes when it shouldn't [regression] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Martin Birgmeier List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 15:00:20 -0000 The following reply was made to PR kern/145246; it has been noted by GNATS. From: Martin Birgmeier To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/145246: [ufs] dirhash in 7.3 gratuitously frees hashes when it shouldn't [regression] Date: Thu, 01 Apr 2010 16:54:13 +0200 I believe that there should be some notion of "value" given to resources which may potentially be destroyed and recreated - computing the dirhash takes a lot of time (see http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/117954 ), and this work should not be thrown away lightly. (This is why dirhash exists in the first place.) Maybe the lowmem handler could be modified to only use the dirhash lowmem handler as a last resort. In my case, the kernel did not really seem to be that short on memory, as it has now been running with moderate to high load for 24 hours with the reversion to SVN rev 195783 for ufs_dirhash.c and dirhash.h. I have configured vfs.ufs.dirhash_maxmem=33554432 (32M) by the way. Compared to 1.25G, this is only 2.5%, so I believe not really something that's eating lots of memory. Regards, Martin From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 16:36:47 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 66428106566B; Thu, 1 Apr 2010 16:36:46 +0000 (UTC) (envelope-from olivier@gid0.org) Received: from mail-bw0-f216.google.com (mail-bw0-f216.google.com [209.85.218.216]) by mx1.freebsd.org (Postfix) with ESMTP id C82C28FC19; Thu, 1 Apr 2010 16:36:45 +0000 (UTC) Received: by bwz8 with SMTP id 8so1033345bwz.3 for ; Thu, 01 Apr 2010 09:36:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.6.76 with HTTP; Thu, 1 Apr 2010 09:36:43 -0700 (PDT) In-Reply-To: <4BB49E3F.7070506@it4pro.pl> References: <4BB49E3F.7070506@it4pro.pl> Date: Thu, 1 Apr 2010 18:36:43 +0200 Received: by 10.204.140.18 with SMTP id g18mr1706507bku.47.1270139803349; Thu, 01 Apr 2010 09:36:43 -0700 (PDT) Message-ID: From: Olivier Smedts To: Bartosz Stec Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: gpart failing with no such geom after gpt corruption X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 16:36:47 -0000 2010/4/1 Bartosz Stec : > Hello ZFS and GPT hackers :) > > I'm sending this message to both freebsd-current and freebsd-fs because i= t > doesn't seems to be a CURRENT-specific issue. > > Yesterday I tried to migrate my mixed UFS/RAIDZ config to clean RAIDZ wit= h > GPT boot. I've following mostly this guide: > http://wiki.freebsd.org/RootOnZFS/GPTZFSBoot/RAIDZ1 > I'm using CURRENT on 3x40GB HDDs (ad0-ad3) and additional 250GB HDD has b= een > used for data migration (ad4). > > Data was copied form RAIDZ to 250GB HDD, GPT sheme was created on =A040GB > HDDs, then new zpool on them, and finally data went back to RAIDZ. Bootin= g > from RAIDZ was succesful, so far so good. > > After a while I've =A0noticed some SMART errors on ad1, so I've booted ma= chine > with seatools for dos and made long test. One bad sector was found and > reallocated, nothing to worry about. > As I was in seatools already, I've decided to adjust LBA size on that dis= k > (seatools can do that), because it was about 30MB larger than the other t= wo, > and because of that I had to adjust size of freebsd-zfs partition on that > disk to match exact size of others (otherwise 'zpool create' will complai= n). > So LBA was adjusted and system rebooted. > > Yes, I was aware that changing disk size probably end with corrupted GPT = and > data loss, but it doesn't seem to be a big deal for me as far as 2/3 of > zpool is alive, because I can always recreate gpt and resilver ad1. > > Unfortunately it wasn't so easy. First of all system booted, and as I > expected kernel message shows GPT error on ad1. Zpool was degraded but al= ive > and kicking. However, when I tried to execute any gpart command on ad1, i= t > return: > > =A0 ad1: no such geom Are you sure you created a partition scheme with gpart on ad1 before issuing partition-related gpart commands ? > > ad1 was present under /dev, and it could be accessed by sysinstall/fdisk, > but no with gpart. I've created bsd slice with sysinstall on ad1 and > rebooted, with hope that after reboot I could acces ad1 with gpart and > recreate GPT scheme. Another surprise - system didn't boot at all, reboot= ing > after couple of seconds in loader (changing boot device didn't make a > difference). > > Only way I could boot system at this moment was connecting 250GB HDD whic= h > fortunately still had data from zpool migration and boot from it. Another > surprise - kernel was still complaining about GPT corruption on ad1. I ha= d > no other ideas so I ran > > =A0 dd if=3D/dev/zero of=3D/dev/ad1 bs=3D512 count=3D512 > > to clear beginning of the hdd. After that disk was still unaccesible from= t > gpart, so I tried sysinstall/fdisk againt to create standard BSD > partitioning scheme and rebooted system. > After that finally gpart started to talk with ad1 and GPT scheme and zpoo= l > has been recreated and work as it supposed to. > > Still, how can we clear broken GPT data after it got corrupted? > Why gpart has been showing "ad1: no such geom", and how can we deal with > this problem? > Finally, why gptzfsboot failed with GPT corrupted on other disk after try= ing > to fix it, while it booted at first place? > > Or maybe changing LBA size of already partitioned HDD is extreme case, an= d > the only way these problems could be triggered ;)? > > Cheers! > > -- > Bartosz Stec > > > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > --=20 Olivier Smedts _ ASCII ribbon campaign ( ) e-mail: olivier@gid0.org - against HTML email & vCards X www: http://www.gid0.org - against proprietary attachments / \ "Il y a seulement 10 sortes de gens dans le monde : ceux qui comprennent le binaire, et ceux qui ne le comprennent pas." From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 17:38:09 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B0FE106566B; Thu, 1 Apr 2010 17:38:09 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 557AA8FC15; Thu, 1 Apr 2010 17:38:07 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id UAA17181; Thu, 01 Apr 2010 20:38:04 +0300 (EEST) (envelope-from avg@freebsd.org) Message-ID: <4BB4D9FB.3000706@freebsd.org> Date: Thu, 01 Apr 2010 20:38:03 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.24 (X11/20100319) MIME-Version: 1.0 To: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org References: <201003261528.o2QFSAuI037251@chez.mckusick.com> In-Reply-To: <201003261528.o2QFSAuI037251@chez.mckusick.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Kirk McKusick , Bruce Evans Subject: Re: g_vfs_open and bread(devvp, ...) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 17:38:09 -0000 Some bad news. Apparently I missed the fact that in some places bo_bsize is used as sectorsize value of underlying provider. That is, there is code that assumes that devvp's bo_bsize == sectorsize. One such place is vnode_pager_generic_getpages() in sys/vm/vnode_pager.c. That code directly calls bstrategy() on bufobj of devvp and because of that it wants to round up read size to media sectorsize (there would be a KASSERT panic in GEOM if I/O size is not multiple of sectorsize). Thus the code needs to know sectorsize. The other possible place is ffs_rawread. I am not sure how to get sectorsize value in those places in a nice way, i.e. without kludges or violating logical layering. I.e. I could access bo_private->provider->sectorsize, but that seems to be too hack-ish. If anyone knows of a proper way to do this, please let me know. For now I am thinking about resorting to a different, slightly less kludgy (IMO) approach. Leave devvp's bo_bsize to mean provider's sectorsize, but instead in getblk() account for devvp's blkno being in units of DEV_BSIZE: --- a/sys/kern/vfs_bio.c +++ b/sys/kern/vfs_bio.c @@ -2700,7 +2700,7 @@ */ if (flags & GB_NOCREAT) return NULL; - bsize = bo->bo_bsize; + bsize = vn_isdisk(vp, NULL) ? DEV_BSIZE : bo->bo_bsize; offset = blkno * bsize; vmio = vp->v_object != NULL; maxsize = vmio ? size + (offset & PAGE_MASK) : size; -- Andriy Gapon From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 18:15:24 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51402106566C; Thu, 1 Apr 2010 18:15:24 +0000 (UTC) (envelope-from olivier@gid0.org) Received: from mail-bw0-f216.google.com (mail-bw0-f216.google.com [209.85.218.216]) by mx1.freebsd.org (Postfix) with ESMTP id B26B58FC0A; Thu, 1 Apr 2010 18:15:23 +0000 (UTC) Received: by bwz8 with SMTP id 8so1106207bwz.3 for ; Thu, 01 Apr 2010 11:15:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.6.76 with HTTP; Thu, 1 Apr 2010 11:15:22 -0700 (PDT) In-Reply-To: <4BB49E3F.7070506@it4pro.pl> References: <4BB49E3F.7070506@it4pro.pl> Date: Thu, 1 Apr 2010 20:15:22 +0200 Received: by 10.204.32.196 with SMTP id e4mr1816408bkd.131.1270145722089; Thu, 01 Apr 2010 11:15:22 -0700 (PDT) Message-ID: From: Olivier Smedts To: Bartosz Stec Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: gpart failing with no such geom after gpt corruption X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 18:15:24 -0000 2010/4/1 Bartosz Stec : > Hello ZFS and GPT hackers :) > > I'm sending this message to both freebsd-current and freebsd-fs because i= t > doesn't seems to be a CURRENT-specific issue. > > Yesterday I tried to migrate my mixed UFS/RAIDZ config to clean RAIDZ wit= h > GPT boot. I've following mostly this guide: > http://wiki.freebsd.org/RootOnZFS/GPTZFSBoot/RAIDZ1 > I'm using CURRENT on 3x40GB HDDs (ad0-ad3) and additional 250GB HDD has b= een > used for data migration (ad4). > > Data was copied form RAIDZ to 250GB HDD, GPT sheme was created on =A040GB > HDDs, then new zpool on them, and finally data went back to RAIDZ. Bootin= g > from RAIDZ was succesful, so far so good. > > After a while I've =A0noticed some SMART errors on ad1, so I've booted ma= chine > with seatools for dos and made long test. One bad sector was found and > reallocated, nothing to worry about. > As I was in seatools already, I've decided to adjust LBA size on that dis= k > (seatools can do that), because it was about 30MB larger than the other t= wo, > and because of that I had to adjust size of freebsd-zfs partition on that > disk to match exact size of others (otherwise 'zpool create' will complai= n). > So LBA was adjusted and system rebooted. I don't understand why you adjusted LBA. You're using GPT partitions, so, couldn't you just make the zfs partition the same size on all disks by adjusting it to the smallest disk, and let free space at the end of the bigger ones ? Cheers, Olivier > Yes, I was aware that changing disk size probably end with corrupted GPT = and > data loss, but it doesn't seem to be a big deal for me as far as 2/3 of > zpool is alive, because I can always recreate gpt and resilver ad1. > > Unfortunately it wasn't so easy. First of all system booted, and as I > expected kernel message shows GPT error on ad1. Zpool was degraded but al= ive > and kicking. However, when I tried to execute any gpart command on ad1, i= t > return: > > =A0 ad1: no such geom > > ad1 was present under /dev, and it could be accessed by sysinstall/fdisk, > but no with gpart. I've created bsd slice with sysinstall on ad1 and > rebooted, with hope that after reboot I could acces ad1 with gpart and > recreate GPT scheme. Another surprise - system didn't boot at all, reboot= ing > after couple of seconds in loader (changing boot device didn't make a > difference). > > Only way I could boot system at this moment was connecting 250GB HDD whic= h > fortunately still had data from zpool migration and boot from it. Another > surprise - kernel was still complaining about GPT corruption on ad1. I ha= d > no other ideas so I ran > > =A0 dd if=3D/dev/zero of=3D/dev/ad1 bs=3D512 count=3D512 > > to clear beginning of the hdd. After that disk was still unaccesible from= t > gpart, so I tried sysinstall/fdisk againt to create standard BSD > partitioning scheme and rebooted system. > After that finally gpart started to talk with ad1 and GPT scheme and zpoo= l > has been recreated and work as it supposed to. > > Still, how can we clear broken GPT data after it got corrupted? > Why gpart has been showing "ad1: no such geom", and how can we deal with > this problem? > Finally, why gptzfsboot failed with GPT corrupted on other disk after try= ing > to fix it, while it booted at first place? > > Or maybe changing LBA size of already partitioned HDD is extreme case, an= d > the only way these problems could be triggered ;)? > > Cheers! > > -- > Bartosz Stec > > > _______________________________________________ > freebsd-fs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > --=20 Olivier Smedts _ ASCII ribbon campaign ( ) e-mail: olivier@gid0.org - against HTML email & vCards X www: http://www.gid0.org - against proprietary attachments / \ "Il y a seulement 10 sortes de gens dans le monde : ceux qui comprennent le binaire, et ceux qui ne le comprennent pas." From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 18:34:35 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2578A1065672 for ; Thu, 1 Apr 2010 18:34:35 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout027.mac.com (asmtpout027.mac.com [17.148.16.102]) by mx1.freebsd.org (Postfix) with ESMTP id 0E5A48FC22 for ; Thu, 1 Apr 2010 18:34:34 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=us-ascii Received: from macbook-pro.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp027.mac.com (Sun Java(tm) System Messaging Server 6.3-8.01 (built Dec 16 2008; 32bit)) with ESMTPSA id <0L0700EGUKTC8790@asmtp027.mac.com>; Thu, 01 Apr 2010 10:34:26 -0700 (PDT) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=5.0.0-0908210000 definitions=main-1004010164 From: Marcel Moolenaar In-reply-to: <4BB49E3F.7070506@it4pro.pl> Date: Thu, 01 Apr 2010 10:34:23 -0700 Message-id: <4D9CB47F-5571-444D-A30B-0227BA01D6E9@mac.com> References: <4BB49E3F.7070506@it4pro.pl> To: Bartosz Stec X-Mailer: Apple Mail (2.1078) Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: gpart failing with no such geom after gpt corruption X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 18:34:35 -0000 On Apr 1, 2010, at 6:23 AM, Bartosz Stec wrote: > Unfortunately it wasn't so easy. First of all system booted, and as I expected kernel message shows GPT error on ad1. Zpool was degraded but alive and kicking. However, when I tried to execute any gpart command on ad1, it return: > > ad1: no such geom If the GPT is rejected, no GEOM is created in the kernel. It's the GEOM that gpart(8) talks to, so the error indicates that the GPT is not accepted after you changed the disk size. For all practical purposes ad1 doesn't have a partitioning. The only gpart command you can use is: gpart create -s gpt ad1 This creates a new GPT on the disk, wiping out whatever was there... -- Marcel Moolenaar xcllnt@mac.com From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 19:02:41 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E0738106566B; Thu, 1 Apr 2010 19:02:41 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id 9ABAC8FC17; Thu, 1 Apr 2010 19:02:41 +0000 (UTC) Received: from [10.170.20.44] (nat-170-141-177-44.tn.gov [170.141.177.44]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id o31J2cpe040938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 Apr 2010 15:02:39 -0400 (EDT) (envelope-from rnoland@FreeBSD.org) Message-ID: <4BB4EDC9.2050507@FreeBSD.org> Date: Thu, 01 Apr 2010 14:02:33 -0500 From: Robert Noland Organization: FreeBSD User-Agent: Thunderbird 2.0.0.19 (X11/20090218) MIME-Version: 1.0 To: Olivier Smedts References: <4BB49E3F.7070506@it4pro.pl> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=1.8 required=5.0 tests=AWL, BAYES_00, FH_DATE_PAST_20XX, RDNS_DYNAMIC,SPF_SOFTFAIL autolearn=no version=3.2.5 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: Bartosz Stec , freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: gpart failing with no such geom after gpt corruption X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 19:02:42 -0000 Olivier Smedts wrote: > 2010/4/1 Bartosz Stec : >> Hello ZFS and GPT hackers :) >> >> I'm sending this message to both freebsd-current and freebsd-fs because it >> doesn't seems to be a CURRENT-specific issue. >> >> Yesterday I tried to migrate my mixed UFS/RAIDZ config to clean RAIDZ with >> GPT boot. I've following mostly this guide: >> http://wiki.freebsd.org/RootOnZFS/GPTZFSBoot/RAIDZ1 >> I'm using CURRENT on 3x40GB HDDs (ad0-ad3) and additional 250GB HDD has been >> used for data migration (ad4). >> >> Data was copied form RAIDZ to 250GB HDD, GPT sheme was created on 40GB >> HDDs, then new zpool on them, and finally data went back to RAIDZ. Booting >> from RAIDZ was succesful, so far so good. >> >> After a while I've noticed some SMART errors on ad1, so I've booted machine >> with seatools for dos and made long test. One bad sector was found and >> reallocated, nothing to worry about. >> As I was in seatools already, I've decided to adjust LBA size on that disk >> (seatools can do that), because it was about 30MB larger than the other two, >> and because of that I had to adjust size of freebsd-zfs partition on that >> disk to match exact size of others (otherwise 'zpool create' will complain). >> So LBA was adjusted and system rebooted. > > I don't understand why you adjusted LBA. You're using GPT partitions, > so, couldn't you just make the zfs partition the same size on all > disks by adjusting it to the smallest disk, and let free space at the > end of the bigger ones ? For that matter, my understanding is that ZFS just doesn't care. If you have disks of different sized in a raidz, the pool size will be limited by the size of the smallest device. If those devices are replaced with larger ones, then the pool just grows to take advantage of the additional available space. robert. > Cheers, > Olivier > >> Yes, I was aware that changing disk size probably end with corrupted GPT and >> data loss, but it doesn't seem to be a big deal for me as far as 2/3 of >> zpool is alive, because I can always recreate gpt and resilver ad1. >> >> Unfortunately it wasn't so easy. First of all system booted, and as I >> expected kernel message shows GPT error on ad1. Zpool was degraded but alive >> and kicking. However, when I tried to execute any gpart command on ad1, it >> return: >> >> ad1: no such geom >> >> ad1 was present under /dev, and it could be accessed by sysinstall/fdisk, >> but no with gpart. I've created bsd slice with sysinstall on ad1 and >> rebooted, with hope that after reboot I could acces ad1 with gpart and >> recreate GPT scheme. Another surprise - system didn't boot at all, rebooting >> after couple of seconds in loader (changing boot device didn't make a >> difference). >> >> Only way I could boot system at this moment was connecting 250GB HDD which >> fortunately still had data from zpool migration and boot from it. Another >> surprise - kernel was still complaining about GPT corruption on ad1. I had >> no other ideas so I ran >> >> dd if=/dev/zero of=/dev/ad1 bs=512 count=512 >> >> to clear beginning of the hdd. After that disk was still unaccesible fromt >> gpart, so I tried sysinstall/fdisk againt to create standard BSD >> partitioning scheme and rebooted system. >> After that finally gpart started to talk with ad1 and GPT scheme and zpool >> has been recreated and work as it supposed to. >> >> Still, how can we clear broken GPT data after it got corrupted? >> Why gpart has been showing "ad1: no such geom", and how can we deal with >> this problem? >> Finally, why gptzfsboot failed with GPT corrupted on other disk after trying >> to fix it, while it booted at first place? >> >> Or maybe changing LBA size of already partitioned HDD is extreme case, and >> the only way these problems could be triggered ;)? >> >> Cheers! >> >> -- >> Bartosz Stec >> >> >> _______________________________________________ >> freebsd-fs@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-fs >> To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" >> > > > From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 19:34:25 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5891D1065675; Thu, 1 Apr 2010 19:34:25 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id 15C3E8FC19; Thu, 1 Apr 2010 19:34:24 +0000 (UTC) Received: from [10.170.20.44] (nat-170-141-177-44.tn.gov [170.141.177.44]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id o31JYMqm041104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 Apr 2010 15:34:23 -0400 (EDT) (envelope-from rnoland@FreeBSD.org) Message-ID: <4BB4F539.1070204@FreeBSD.org> Date: Thu, 01 Apr 2010 14:34:17 -0500 From: Robert Noland Organization: FreeBSD User-Agent: Thunderbird 2.0.0.19 (X11/20090218) MIME-Version: 1.0 To: Olivier Smedts References: <4BB49E3F.7070506@it4pro.pl> <4BB4EDC9.2050507@FreeBSD.org> In-Reply-To: <4BB4EDC9.2050507@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=1.3 required=5.0 tests=AWL, BAYES_00, FH_DATE_PAST_20XX, RDNS_DYNAMIC,SPF_SOFTFAIL autolearn=no version=3.2.5 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: Bartosz Stec , freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: gpart failing with no such geom after gpt corruption X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 19:34:25 -0000 Robert Noland wrote: > > > Olivier Smedts wrote: >> 2010/4/1 Bartosz Stec : >>> Hello ZFS and GPT hackers :) >>> >>> I'm sending this message to both freebsd-current and freebsd-fs >>> because it >>> doesn't seems to be a CURRENT-specific issue. >>> >>> Yesterday I tried to migrate my mixed UFS/RAIDZ config to clean RAIDZ >>> with >>> GPT boot. I've following mostly this guide: >>> http://wiki.freebsd.org/RootOnZFS/GPTZFSBoot/RAIDZ1 >>> I'm using CURRENT on 3x40GB HDDs (ad0-ad3) and additional 250GB HDD >>> has been >>> used for data migration (ad4). >>> >>> Data was copied form RAIDZ to 250GB HDD, GPT sheme was created on 40GB >>> HDDs, then new zpool on them, and finally data went back to RAIDZ. >>> Booting >>> from RAIDZ was succesful, so far so good. >>> >>> After a while I've noticed some SMART errors on ad1, so I've booted >>> machine >>> with seatools for dos and made long test. One bad sector was found and >>> reallocated, nothing to worry about. >>> As I was in seatools already, I've decided to adjust LBA size on that >>> disk >>> (seatools can do that), because it was about 30MB larger than the >>> other two, >>> and because of that I had to adjust size of freebsd-zfs partition on >>> that >>> disk to match exact size of others (otherwise 'zpool create' will >>> complain). >>> So LBA was adjusted and system rebooted. >> >> I don't understand why you adjusted LBA. You're using GPT partitions, >> so, couldn't you just make the zfs partition the same size on all >> disks by adjusting it to the smallest disk, and let free space at the >> end of the bigger ones ? > > For that matter, my understanding is that ZFS just doesn't care. If you > have disks of different sized in a raidz, the pool size will be limited > by the size of the smallest device. If those devices are replaced with > larger ones, then the pool just grows to take advantage of the > additional available space. balrog% gpart show => 34 2097085 md0 GPT (1.0G) 34 128 1 freebsd-boot (64K) 162 2096957 2 freebsd-zfs (1.0G) => 34 2097085 md1 GPT (1.0G) 34 128 1 freebsd-boot (64K) 162 2096957 2 freebsd-zfs (1.0G) => 34 4194237 md2 GPT (2.0G) 34 128 1 freebsd-boot (64K) 162 4194109 2 freebsd-zfs (2.0G) balrog% zpool status pool: test state: ONLINE scrub: none requested config: NAME STATE READ WRITE CKSUM test ONLINE 0 0 0 raidz1 ONLINE 0 0 0 md0p2 ONLINE 0 0 0 md1p2 ONLINE 0 0 0 md2p2 ONLINE 0 0 0 errors: No known data errors balrog% zpool list NAME SIZE USED AVAIL CAP HEALTH ALTROOT test 2.98G 141K 2.98G 0% ONLINE - robert. > robert. > >> Cheers, >> Olivier >> >>> Yes, I was aware that changing disk size probably end with corrupted >>> GPT and >>> data loss, but it doesn't seem to be a big deal for me as far as 2/3 of >>> zpool is alive, because I can always recreate gpt and resilver ad1. >>> >>> Unfortunately it wasn't so easy. First of all system booted, and as I >>> expected kernel message shows GPT error on ad1. Zpool was degraded >>> but alive >>> and kicking. However, when I tried to execute any gpart command on >>> ad1, it >>> return: >>> >>> ad1: no such geom >>> >>> ad1 was present under /dev, and it could be accessed by >>> sysinstall/fdisk, >>> but no with gpart. I've created bsd slice with sysinstall on ad1 and >>> rebooted, with hope that after reboot I could acces ad1 with gpart and >>> recreate GPT scheme. Another surprise - system didn't boot at all, >>> rebooting >>> after couple of seconds in loader (changing boot device didn't make a >>> difference). >>> >>> Only way I could boot system at this moment was connecting 250GB HDD >>> which >>> fortunately still had data from zpool migration and boot from it. >>> Another >>> surprise - kernel was still complaining about GPT corruption on ad1. >>> I had >>> no other ideas so I ran >>> >>> dd if=/dev/zero of=/dev/ad1 bs=512 count=512 >>> >>> to clear beginning of the hdd. After that disk was still unaccesible >>> fromt >>> gpart, so I tried sysinstall/fdisk againt to create standard BSD >>> partitioning scheme and rebooted system. >>> After that finally gpart started to talk with ad1 and GPT scheme and >>> zpool >>> has been recreated and work as it supposed to. >>> >>> Still, how can we clear broken GPT data after it got corrupted? >>> Why gpart has been showing "ad1: no such geom", and how can we deal with >>> this problem? >>> Finally, why gptzfsboot failed with GPT corrupted on other disk after >>> trying >>> to fix it, while it booted at first place? >>> >>> Or maybe changing LBA size of already partitioned HDD is extreme >>> case, and >>> the only way these problems could be triggered ;)? >>> >>> Cheers! >>> >>> -- >>> Bartosz Stec >>> >>> >>> _______________________________________________ >>> freebsd-fs@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/freebsd-fs >>> To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" >>> >> >> >> > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 19:40:34 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 719CC1065674 for ; Thu, 1 Apr 2010 19:40:34 +0000 (UTC) (envelope-from paul@fletchermoorland.co.uk) Received: from hydra.fletchermoorland.co.uk (hydra.fletchermoorland.co.uk [78.33.209.59]) by mx1.freebsd.org (Postfix) with ESMTP id F15CF8FC23 for ; Thu, 1 Apr 2010 19:40:33 +0000 (UTC) Received: from demophon.fletchermoorland.co.uk (demophon.fletchermoorland.co.uk [192.168.0.154]) by hydra.fletchermoorland.co.uk (8.14.3/8.14.3) with ESMTP id o31JA5K6097605; Thu, 1 Apr 2010 20:10:05 +0100 (BST) (envelope-from paul@fletchermoorland.co.uk) Message-ID: <4BB4EF8D.9090809@fletchermoorland.co.uk> Date: Thu, 01 Apr 2010 19:10:05 +0000 From: Paul Wootton User-Agent: Thunderbird 2.0.0.23 (X11/20091217) MIME-Version: 1.0 To: Bartosz Stec References: <4BB49E3F.7070506@it4pro.pl> In-Reply-To: <4BB49E3F.7070506@it4pro.pl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=4.5 required=10.0 tests=ALL_TRUSTED,BAYES_80, DNS_FROM_OPENWHOIS,FH_DATE_PAST_20XX autolearn=no version=3.2.5 X-Spam-Level: **** X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on hydra.fletchermoorland.co.uk Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: gpart failing with no such geom after gpt corruption X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 19:40:34 -0000 Bartosz, One thing to remember is that GPT stores it's header and entry tables at both the start and end of the disk for redundancy. As far as I understand it, by making the disk physically smaller, the GPT primary header and entry data would have become invalid as the last partition would now be ending past the end of the disk Partition table format Offset Length Content 0 8 Signature ("EFI PART", 45 46 49 20 50 41 52 54) ... 24 8 Current LBA (location of this header copy) 32 8 Backup LBA (location of the other header copy) 40 8 First usable LBA for partitions (primary partition table last LBA + 1) 48 8 Last usable LBA (secondary partition table first LBA - 1) ... GUID partition entry format Offset Length Content 0 16 Partition type GUID ... 32 8 First LBA (little-endian) 40 8 Last LBA (inclusive, usually odd) ... See http://en.wikipedia.org/wiki/GUID_Partition_Table From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 19:42:35 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1CF24106566C; Thu, 1 Apr 2010 19:42:35 +0000 (UTC) (envelope-from bartosz.stec@it4pro.pl) Received: from mainframe.kkip.pl (kkip.pl [87.105.164.78]) by mx1.freebsd.org (Postfix) with ESMTP id 615EB8FC16; Thu, 1 Apr 2010 19:42:33 +0000 (UTC) Received: from static-78-8-144-74.ssp.dialog.net.pl ([78.8.144.74] helo=[192.168.0.2]) by mainframe.kkip.pl with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.71 (FreeBSD)) (envelope-from ) id 1NxQHZ-000Dy8-4P; Thu, 01 Apr 2010 21:42:32 +0200 Message-ID: <4BB4F71D.5030105@it4pro.pl> Date: Thu, 01 Apr 2010 21:42:21 +0200 From: Bartosz Stec Organization: IT4Pro User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.8) Gecko/20100306 Shredder/3.0.3 MIME-Version: 1.0 References: <4BB49E3F.7070506@it4pro.pl> <4BB4EDC9.2050507@FreeBSD.org> In-Reply-To: <4BB4EDC9.2050507@FreeBSD.org> X-Authenticated-User: bartosz.stec@it4pro.pl X-Authenticator: plain X-Sender-Verify: SUCCEEDED (sender exists & accepts mail) X-Spam-Score: -7.6 X-Spam-Score-Int: -75 X-Exim-Version: 4.71 (build at 02-Feb-2010 20:10:28) X-Date: 2010-04-01 21:42:32 X-Connected-IP: 78.8.144.74:60774 X-Message-Linecount: 205 X-Body-Linecount: 192 X-Message-Size: 7880 X-Body-Size: 7226 X-Received-Count: 1 X-Recipient-Count: 2 X-Local-Recipient-Count: 2 X-Local-Recipient-Defer-Count: 0 X-Local-Recipient-Fail-Count: 0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: gpart failing with no such geom after gpt corruption X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 19:42:35 -0000 On 2010-04-01 21:02, Robert Noland wrote: >>> >>> After a while I've noticed some SMART errors on ad1, so I've booted >>> machine >>> with seatools for dos and made long test. One bad sector was found and >>> reallocated, nothing to worry about. >>> As I was in seatools already, I've decided to adjust LBA size on >>> that disk >>> (seatools can do that), because it was about 30MB larger than the >>> other two, >>> and because of that I had to adjust size of freebsd-zfs partition on >>> that >>> disk to match exact size of others (otherwise 'zpool create' will >>> complain). >>> So LBA was adjusted and system rebooted. >> >> I don't understand why you adjusted LBA. You're using GPT partitions, >> so, couldn't you just make the zfs partition the same size on all >> disks by adjusting it to the smallest disk, and let free space at the >> end of the bigger ones ? > Well yes, I could indeed, and this is exactly what I did at the first time (before LBA count adjusting). But while I was already using software which could adjust LBA to make all HDD appear to be same size, I've decided to do it to never have to remember about it while partitioning ;) At least 'gpart show' isn't showing any unused (wasted) space now ;) : # gpart show => 34 78165293 ad0 GPT (37G) 34 128 1 freebsd-boot (64K) 162 2097152 2 freebsd-swap (1.0G) 2097314 76068013 3 freebsd-zfs (36G) => 34 78165293 ad1 GPT (37G) 34 128 1 freebsd-boot (64K) 162 2097152 2 freebsd-swap (1.0G) 2097314 76068013 3 freebsd-zfs (36G) => 34 78165293 ad2 GPT (37G) 34 128 1 freebsd-boot (64K) 162 2097152 2 freebsd-swap (1.0G) 2097314 76068013 3 freebsd-zfs (36G) > > For that matter, my understanding is that ZFS just doesn't care. If > you have disks of different sized in a raidz, the pool size will be > limited by the size of the smallest device. If those devices are > replaced with larger ones, then the pool just grows to take advantage > of the additional available space. > > robert. > Well, here's what man zpool says about zpool create: "(...) The use of differently sized devices within a single raidz or mirror group is also flagged as an error unless -f is specified." I know I could force it, I just didn't know if I should. After all it's just easier to type 3 times: gpt add -t freebsd-zfs -l diskN to use all free space on device than checking numbers on other disks and type gpt add -b 2097314 -s 76068013 -t freebsd-zfs -l diskN and that's why all story begins :) -- Bartosz Stec From owner-freebsd-fs@FreeBSD.ORG Thu Apr 1 20:41:02 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A53E106564A for ; Thu, 1 Apr 2010 20:41:02 +0000 (UTC) (envelope-from admin@kkip.pl) Received: from mainframe.kkip.pl (kkip.pl [87.105.164.78]) by mx1.freebsd.org (Postfix) with ESMTP id 10F1E8FC17 for ; Thu, 1 Apr 2010 20:41:01 +0000 (UTC) Received: from static-78-8-144-74.ssp.dialog.net.pl ([78.8.144.74] helo=[192.168.0.2]) by mainframe.kkip.pl with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.71 (FreeBSD)) (envelope-from ) id 1NxQbA-000E3y-PS; Thu, 01 Apr 2010 22:02:53 +0200 Message-ID: <4BB4FBDD.5030709@kkip.pl> Date: Thu, 01 Apr 2010 22:02:37 +0200 From: Bartosz Stec User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.8) Gecko/20100306 Shredder/3.0.3 MIME-Version: 1.0 References: <4BB49E3F.7070506@it4pro.pl> <4D9CB47F-5571-444D-A30B-0227BA01D6E9@mac.com> In-Reply-To: <4D9CB47F-5571-444D-A30B-0227BA01D6E9@mac.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-User: admin@kkip.pl X-Authenticator: plain X-Sender-Verify: SUCCEEDED (sender exists & accepts mail) X-Spam-Score: -6.2 X-Spam-Score-Int: -61 X-Exim-Version: 4.71 (build at 02-Feb-2010 20:10:28) X-Date: 2010-04-01 22:02:53 X-Connected-IP: 78.8.144.74:60671 X-Message-Linecount: 42 X-Body-Linecount: 30 X-Message-Size: 1868 X-Body-Size: 1273 X-Received-Count: 1 X-Recipient-Count: 2 X-Local-Recipient-Count: 2 X-Local-Recipient-Defer-Count: 0 X-Local-Recipient-Fail-Count: 0 Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: gpart failing with no such geom after gpt corruption X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 20:41:02 -0000 On 2010-04-01 19:34, Marcel Moolenaar wrote: > On Apr 1, 2010, at 6:23 AM, Bartosz Stec wrote: > > >> Unfortunately it wasn't so easy. First of all system booted, and as I expected kernel message shows GPT error on ad1. Zpool was degraded but alive and kicking. However, when I tried to execute any gpart command on ad1, it return: >> >> ad1: no such geom >> > If the GPT is rejected, no GEOM is created in the kernel. It's the GEOM > that gpart(8) talks to, so the error indicates that the GPT is not accepted > after you changed the disk size. For all practical purposes ad1 doesn't have > a partitioning. > > The only gpart command you can use is: > gpart create -s gpt ad1 > > This creates a new GPT on the disk, wiping out whatever was there... > > It was a middle of night when I played with that, so I'm not remember clearly if I tried it simpliest way like above or not. Maybe not, and all noise I made was pointless and caused by my inexperience with gpart. Probably I just expected output from "gpart show ad1" be more like "no valid partitioning scheme on device" or "error in GPT table, please recreate partition scheme" in place of mystic geom message ;) Sorry for noise, thanks for a hint and happy easter everyone :) -- Bartosz Stec From owner-freebsd-fs@FreeBSD.ORG Fri Apr 2 07:10:07 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D7D94106566C for ; Fri, 2 Apr 2010 07:10:07 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-bw0-f216.google.com (mail-bw0-f216.google.com [209.85.218.216]) by mx1.freebsd.org (Postfix) with ESMTP id 64F0F8FC16 for ; Fri, 2 Apr 2010 07:10:07 +0000 (UTC) Received: by bwz8 with SMTP id 8so1412226bwz.3 for ; Fri, 02 Apr 2010 00:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject :organization:date:message-id:user-agent:mime-version:content-type; bh=EKaahNnnDL7ITiPN3RsYxzrO2SdqnrCmIt/PM3XzK7E=; b=KXW9LXsXcLWQ0GkR4rec2kD4i67VLC3ZbcYkjhd4vrZ+U3wCbrSw1xWg0DHvA8bRE1 C4Vw9A7yF96L2weV+B5oq0awMAKUu3juXnHL9p1lSB40HxP+76qK3HPtY2HfJwb+Fqja PZEmRhRwSiw34KsY1BliMs2zp94PcfWqdkLA4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:date:message-id:user-agent :mime-version:content-type; b=P3fzydiYzrgZw1rkzj73x/K7mxwg1BCzaqgzfMZdT6P3B5tHov0QiCwhjLFyl+o9a+ tcRnhL9vhW3Hn0zbTwzJ9mz/utV0s2C4eazhu+cz2UkrH+SX1Q1b/7A1/cnfZP9dMkds y//YwBtdnTErMeUDoIiFjSaR5Gm5bXEx2e6jg= Received: by 10.204.1.136 with SMTP id 8mr2685082bkf.92.1270192205644; Fri, 02 Apr 2010 00:10:05 -0700 (PDT) Received: from localhost (ua1.etadirect.net [91.198.140.16]) by mx.google.com with ESMTPS id 15sm4639928bwz.12.2010.04.02.00.10.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 02 Apr 2010 00:10:04 -0700 (PDT) From: Mikolaj Golub To: freebsd-fs@FreeBSD.org Organization: TOA Ukraine Date: Fri, 02 Apr 2010 10:10:02 +0300 Message-ID: <86sk7e1gad.fsf@zhuzha.ua1> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Eugene Grosbein Subject: Lock leakage on rename if vop->vop_rename is NULL (kern/107439) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 07:10:07 -0000 Hi, Could somebody look at kern/107439? Although the pr is closed the issue still persists: if a file system does not provide vop_rename the vop_bypass() is called and the vnods, which are expected to be unlocked in VOP_RENAME(), are left locked. I have attached there the patch that solves the problem but I am not confident about the solution. -- Mikolaj Golub From owner-freebsd-fs@FreeBSD.ORG Fri Apr 2 09:04:06 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2FFE8106566B for ; Fri, 2 Apr 2010 09:04:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id BC37F8FC1D for ; Fri, 2 Apr 2010 09:04:05 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o32942to037001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 2 Apr 2010 12:04:02 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o32941tm086983; Fri, 2 Apr 2010 12:04:01 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o32941re086982; Fri, 2 Apr 2010 12:04:01 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 2 Apr 2010 12:04:01 +0300 From: Kostik Belousov To: Mikolaj Golub Message-ID: <20100402090401.GG2415@deviant.kiev.zoral.com.ua> References: <86sk7e1gad.fsf@zhuzha.ua1> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wQFNOvpuONRGomCw" Content-Disposition: inline In-Reply-To: <86sk7e1gad.fsf@zhuzha.ua1> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_05, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-fs@freebsd.org Subject: Re: Lock leakage on rename if vop->vop_rename is NULL (kern/107439) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 09:04:06 -0000 --wQFNOvpuONRGomCw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable [Do not want to get "YOU ARE NOT IN WHITELIST" garbage] On Fri, Apr 02, 2010 at 10:10:02AM +0300, Mikolaj Golub wrote: > Hi, >=20 > Could somebody look at kern/107439? Although the pr is closed the issue s= till > persists: if a file system does not provide vop_rename the vop_bypass() is > called and the vnods, which are expected to be unlocked in VOP_RENAME(), = are > left locked. >=20 > I have attached there the patch that solves the problem but I am not conf= ident > about the solution. Patch seems to be eaten by unnamed daemon, but survived in the PR log. I think that ap->ap_tvp should be handled too. Anyway, I assume that the proper solution there would be to implement default vop_rename that is in fact identical to deadfs_rename(). The later exists exactly to handle a very similar situation. Please test the patch below. If it works for you, I will combine deadfs_rename() and vop_norename(). Thanks for the report and patch. diff --git a/sys/kern/vfs_default.c b/sys/kern/vfs_default.c index 50bf0d2..7e278a5 100644 --- a/sys/kern/vfs_default.c +++ b/sys/kern/vfs_default.c @@ -67,6 +67,7 @@ __FBSDID("$FreeBSD$"); #include =20 static int vop_nolookup(struct vop_lookup_args *); +static int vop_norename(struct vop_rename_args *); static int vop_nostrategy(struct vop_strategy_args *); static int get_next_dirent(struct vnode *vp, struct dirent **dpp, char *dirbuf, int dirbuflen, off_t *off, @@ -113,6 +114,7 @@ struct vop_vector default_vnodeops =3D { .vop_poll =3D vop_nopoll, .vop_putpages =3D vop_stdputpages, .vop_readlink =3D VOP_EINVAL, + .vop_rename =3D vop_norename, .vop_revoke =3D VOP_PANIC, .vop_strategy =3D vop_nostrategy, .vop_unlock =3D vop_stdunlock, @@ -206,6 +208,27 @@ vop_nolookup(ap) } =20 /* + * vop_norename: + * + * Handle unlock and reference counting for arguments of vop_rename + * for filesystems that do not implement rename operation. + */ +static int +vop_norename(struct vop_rename_args *ap) +{ + + if (ap->a_tvp !=3D NULL) + vput(ap->a_tvp); + if (ap->a_tdvp =3D=3D ap->a_tvp) + vrele(ap->a_tdvp); + else + vput(ap->a_tdvp); + vrele(ap->a_fdvp); + vrele(ap->a_fvp); + return (EOPNOTSUPP); +} + +/* * vop_nostrategy: * * Strategy routine for VFS devices that have none. --wQFNOvpuONRGomCw Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAku1swEACgkQC3+MBN1Mb4ir9gCfYzqnk4so9FZYi4MPTSW7DYt1 uXMAnjXJc7iewWVW7jrn8suOZ0HyMXGa =DdtH -----END PGP SIGNATURE----- --wQFNOvpuONRGomCw-- From owner-freebsd-fs@FreeBSD.ORG Fri Apr 2 11:27:22 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB7BC106566B for ; Fri, 2 Apr 2010 11:27:22 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-bw0-f228.google.com (mail-bw0-f228.google.com [209.85.218.228]) by mx1.freebsd.org (Postfix) with ESMTP id 4842E8FC08 for ; Fri, 2 Apr 2010 11:27:21 +0000 (UTC) Received: by bwz28 with SMTP id 28so1489809bwz.14 for ; Fri, 02 Apr 2010 04:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject :organization:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=2psnmeXG43IsncOduq3ZNK2fCF4S5yhnM24xjynfeBc=; b=e62YgvID6LEPNWGpMFlRL53ZC1nZCB3SxSX6a+Hq7M3+gAZ8IzkYOZf9PeAT01p7jJ w4lkk0Ry7Ckp6uOAeklCmPmcHvo7FLDY6hlWP9T6CmUP98YL3P3qJ+IBnIcrzY1frcj/ eVwj9FaI4EtuK6PZcu6C+hj2et4gv5nu8KaAM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=UEy293OzH2Qi8a3gaPlW7Cz30EXWzthIBFtpF5BeFt6MlIEe8L3RYKvraItFweAlxe WlenmtLFToyn2EdehZbe2U95ihCn1E4v9npzCWUO8+pdgwQz0OKkpaD9TSdHWLvPwHnl W9MK4UcB4LdcIaK4vZ9H328HPfD7A/RVqRJpI= Received: by 10.204.15.14 with SMTP id i14mr2892625bka.123.1270207640980; Fri, 02 Apr 2010 04:27:20 -0700 (PDT) Received: from localhost (ua1.etadirect.net [91.198.140.16]) by mx.google.com with ESMTPS id 14sm4506198bwz.2.2010.04.02.04.27.19 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 02 Apr 2010 04:27:20 -0700 (PDT) From: Mikolaj Golub To: Kostik Belousov Organization: TOA Ukraine References: <86sk7e1gad.fsf@zhuzha.ua1> <20100402090401.GG2415@deviant.kiev.zoral.com.ua> Date: Fri, 02 Apr 2010 14:27:18 +0300 In-Reply-To: <20100402090401.GG2415@deviant.kiev.zoral.com.ua> (Kostik Belousov's message of "Fri, 2 Apr 2010 12:04:01 +0300") Message-ID: <86wrwqnlgp.fsf@zhuzha.ua1> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-fs@freebsd.org, Eugene Grosbein Subject: Re: Lock leakage on rename if vop->vop_rename is NULL (kern/107439) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 11:27:22 -0000 On Fri, 2 Apr 2010 12:04:01 +0300 Kostik Belousov wrote: KB> Please test the patch below. If it works for you, I will combine KB> deadfs_rename() and vop_norename(). Tested on today's 8.0-STABLE i386. Trying to move from/to/inside ntfs: no locking issues or problems with unmounting fs (and any other strange things) have been detected. -- Mikolaj Golub From owner-freebsd-fs@FreeBSD.ORG Fri Apr 2 12:15:04 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4028C106566C for ; Fri, 2 Apr 2010 12:15:04 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id A93BB8FC0C for ; Fri, 2 Apr 2010 12:15:03 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o32CExCn052003 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 2 Apr 2010 15:14:59 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o32CExLh087975; Fri, 2 Apr 2010 15:14:59 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o32CExTd087974; Fri, 2 Apr 2010 15:14:59 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 2 Apr 2010 15:14:59 +0300 From: Kostik Belousov To: Mikolaj Golub Message-ID: <20100402121459.GH2415@deviant.kiev.zoral.com.ua> References: <86sk7e1gad.fsf@zhuzha.ua1> <20100402090401.GG2415@deviant.kiev.zoral.com.ua> <86wrwqnlgp.fsf@zhuzha.ua1> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GFHRPGHrS2AOMWit" Content-Disposition: inline In-Reply-To: <86wrwqnlgp.fsf@zhuzha.ua1> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-fs@freebsd.org, Eugene Grosbein Subject: Re: Lock leakage on rename if vop->vop_rename is NULL (kern/107439) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 12:15:04 -0000 --GFHRPGHrS2AOMWit Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 02, 2010 at 02:27:18PM +0300, Mikolaj Golub wrote: >=20 > On Fri, 2 Apr 2010 12:04:01 +0300 Kostik Belousov wrote: >=20 > KB> Please test the patch below. If it works for you, I will combine > KB> deadfs_rename() and vop_norename(). >=20 > Tested on today's 8.0-STABLE i386. Trying to move from/to/inside ntfs: no > locking issues or problems with unmounting fs (and any other strange thin= gs) > have been detected. Great, thank you. Below is the patch I intent to commit. Will be grateful if you sanity-check it too. diff --git a/sys/fs/deadfs/dead_vnops.c b/sys/fs/deadfs/dead_vnops.c index 7a07b38..e255654 100644 --- a/sys/fs/deadfs/dead_vnops.c +++ b/sys/fs/deadfs/dead_vnops.c @@ -225,13 +225,7 @@ dead_rename(ap) struct componentname *a_tcnp; } */ *ap; { - if (ap->a_tvp) - vput(ap->a_tvp); - if (ap->a_tdvp =3D=3D ap->a_tvp) - vrele(ap->a_tdvp); - else - vput(ap->a_tdvp); - vrele(ap->a_fdvp); - vrele(ap->a_fvp); + + vop_rename_fail(ap); return (EXDEV); } diff --git a/sys/kern/vfs_default.c b/sys/kern/vfs_default.c index 50bf0d2..3788147 100644 --- a/sys/kern/vfs_default.c +++ b/sys/kern/vfs_default.c @@ -67,6 +67,7 @@ __FBSDID("$FreeBSD$"); #include =20 static int vop_nolookup(struct vop_lookup_args *); +static int vop_norename(struct vop_rename_args *); static int vop_nostrategy(struct vop_strategy_args *); static int get_next_dirent(struct vnode *vp, struct dirent **dpp, char *dirbuf, int dirbuflen, off_t *off, @@ -113,6 +114,7 @@ struct vop_vector default_vnodeops =3D { .vop_poll =3D vop_nopoll, .vop_putpages =3D vop_stdputpages, .vop_readlink =3D VOP_EINVAL, + .vop_rename =3D vop_norename, .vop_revoke =3D VOP_PANIC, .vop_strategy =3D vop_nostrategy, .vop_unlock =3D vop_stdunlock, @@ -206,6 +208,20 @@ vop_nolookup(ap) } =20 /* + * vop_norename: + * + * Handle unlock and reference counting for arguments of vop_rename + * for filesystems that do not implement rename operation. + */ +static int +vop_norename(struct vop_rename_args *ap) +{ + + vop_rename_fail(ap); + return (EOPNOTSUPP); +} + +/* * vop_nostrategy: * * Strategy routine for VFS devices that have none. diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index daaa5b1..9d4b3a9 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -3751,6 +3751,20 @@ assert_vop_slocked(struct vnode *vp, const char *str) #endif /* DEBUG_VFS_LOCKS */ =20 void +vop_rename_fail(struct vop_rename_args *ap) +{ + + if (ap->a_tvp !=3D NULL) + vput(ap->a_tvp); + if (ap->a_tdvp =3D=3D ap->a_tvp) + vrele(ap->a_tdvp); + else + vput(ap->a_tdvp); + vrele(ap->a_fdvp); + vrele(ap->a_fvp); +} + +void vop_rename_pre(void *ap) { struct vop_rename_args *a =3D ap; diff --git a/sys/sys/vnode.h b/sys/sys/vnode.h index 4c84ea3..b5784e4 100644 --- a/sys/sys/vnode.h +++ b/sys/sys/vnode.h @@ -720,6 +720,8 @@ void vop_symlink_post(void *a, int rc); void vop_unlock_post(void *a, int rc); void vop_unlock_pre(void *a); =20 +void vop_rename_fail(struct vop_rename_args *ap); + #define VOP_WRITE_PRE(ap) \ struct vattr va; \ int error, osize, ooffset, noffset; \ --GFHRPGHrS2AOMWit Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAku138MACgkQC3+MBN1Mb4i2AQCgrUhzoR4uLKr06Nqaem/O0IiH 9msAoJcNPy+QKXnVhIriX+TDS8Wnx0a0 =rqUo -----END PGP SIGNATURE----- --GFHRPGHrS2AOMWit-- From owner-freebsd-fs@FreeBSD.ORG Fri Apr 2 13:15:58 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 785D5106564A for ; Fri, 2 Apr 2010 13:15:58 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-bw0-f228.google.com (mail-bw0-f228.google.com [209.85.218.228]) by mx1.freebsd.org (Postfix) with ESMTP id 0068D8FC0C for ; Fri, 2 Apr 2010 13:15:57 +0000 (UTC) Received: by bwz28 with SMTP id 28so1544361bwz.14 for ; Fri, 02 Apr 2010 06:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject :organization:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=yxRYcJDBuoTSUHHv8QSR/c5adRVi1MMSvH6tNjej55Y=; b=MpLHc1JdRLiCSQnWK/5Hkb1aiA4sncIW3nZN3r54w/Jg6M9km0Ne11REzcthNIaVZw /zSQz19jSZEOgm3Sah8bqGG7HwubYHfkn7QWM1KX/2OgXS947gjf5ZRFNqGXgFBRnshQ Ywr17ZUskJpvexmuz8RsIFNNn8Qi9EY+Rfo7Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=MIJAup3Eb2Q2JINk3iF5CU+ZF/U2GMnJpTboLuMLtnKNZsxrj7e5pucB9LesD7gfji tDksPM0G0wZ1turrxO8Uw3FePE7JYBTCf/m2Ok+uD+JrdgY3wfw0kpWR6C1x8kFpTKqW a4ERPrHhhnfIGNyYUD62hqeLQfpbcP0J+5aZc= Received: by 10.204.8.205 with SMTP id i13mr3087984bki.109.1270214156842; Fri, 02 Apr 2010 06:15:56 -0700 (PDT) Received: from localhost (ua1.etadirect.net [91.198.140.16]) by mx.google.com with ESMTPS id 16sm4518934bwz.1.2010.04.02.06.15.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 02 Apr 2010 06:15:56 -0700 (PDT) From: Mikolaj Golub To: Kostik Belousov Organization: TOA Ukraine References: <86sk7e1gad.fsf@zhuzha.ua1> <20100402090401.GG2415@deviant.kiev.zoral.com.ua> <86wrwqnlgp.fsf@zhuzha.ua1> <20100402121459.GH2415@deviant.kiev.zoral.com.ua> Date: Fri, 02 Apr 2010 16:15:54 +0300 In-Reply-To: <20100402121459.GH2415@deviant.kiev.zoral.com.ua> (Kostik Belousov's message of "Fri, 2 Apr 2010 15:14:59 +0300") Message-ID: <86r5myq9kl.fsf@zhuzha.ua1> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-fs@freebsd.org, Eugene Grosbein Subject: Re: Lock leakage on rename if vop->vop_rename is NULL (kern/107439) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 13:15:58 -0000 On Fri, 2 Apr 2010 15:14:59 +0300 Kostik Belousov wrote: KB> On Fri, Apr 02, 2010 at 02:27:18PM +0300, Mikolaj Golub wrote: >> >> On Fri, 2 Apr 2010 12:04:01 +0300 Kostik Belousov wrote: >> >> KB> Please test the patch below. If it works for you, I will combine >> KB> deadfs_rename() and vop_norename(). >> >> Tested on today's 8.0-STABLE i386. Trying to move from/to/inside ntfs: no >> locking issues or problems with unmounting fs (and any other strange things) >> have been detected. KB> Great, thank you. KB> Below is the patch I intent to commit. Will be grateful if you sanity-check KB> it too. Tested. It works for me. -- Mikolaj Golub From owner-freebsd-fs@FreeBSD.ORG Fri Apr 2 23:47:59 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37F681065673; Fri, 2 Apr 2010 23:47:59 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0E57C8FC0C; Fri, 2 Apr 2010 23:47:59 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o32NlwBV051312; Fri, 2 Apr 2010 23:47:58 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o32NlwRR051308; Fri, 2 Apr 2010 23:47:58 GMT (envelope-from linimon) Date: Fri, 2 Apr 2010 23:47:58 GMT Message-Id: <201004022347.o32NlwRR051308@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/145272: [zfs] [panic] Panic during boot when accessing zfs on a gmirror X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 23:47:59 -0000 Old Synopsis: Panic during boot when accessing zfs on a gmirror New Synopsis: [zfs] [panic] Panic during boot when accessing zfs on a gmirror Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: linimon Responsible-Changed-When: Fri Apr 2 23:47:41 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=145272 From owner-freebsd-fs@FreeBSD.ORG Sat Apr 3 07:53:12 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 017E9106564A; Sat, 3 Apr 2010 07:53:12 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CCC328FC0A; Sat, 3 Apr 2010 07:53:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o337rBo9006190; Sat, 3 Apr 2010 07:53:11 GMT (envelope-from remko@freefall.freebsd.org) Received: (from remko@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o337rBlh006186; Sat, 3 Apr 2010 07:53:11 GMT (envelope-from remko) Date: Sat, 3 Apr 2010 07:53:11 GMT Message-Id: <201004030753.o337rBlh006186@freefall.freebsd.org> To: remko@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: remko@FreeBSD.org Cc: Subject: Re: kern/145339: [zfs] deadlock after detaching block device from raidz pool X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2010 07:53:12 -0000 Synopsis: [zfs] deadlock after detaching block device from raidz pool Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: remko Responsible-Changed-When: Sat Apr 3 07:53:02 UTC 2010 Responsible-Changed-Why: Reassign to FS team. http://www.freebsd.org/cgi/query-pr.cgi?pr=145339 From owner-freebsd-fs@FreeBSD.ORG Sat Apr 3 07:54:52 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F4FF106566C; Sat, 3 Apr 2010 07:54:52 +0000 (UTC) (envelope-from remko@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 069A98FC0C; Sat, 3 Apr 2010 07:54:52 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o337sptF006363; Sat, 3 Apr 2010 07:54:51 GMT (envelope-from remko@freefall.freebsd.org) Received: (from remko@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o337spJh006358; Sat, 3 Apr 2010 07:54:51 GMT (envelope-from remko) Date: Sat, 3 Apr 2010 07:54:51 GMT Message-Id: <201004030754.o337spJh006358@freefall.freebsd.org> To: remko@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: remko@FreeBSD.org Cc: Subject: Re: kern/145309: [disklabel]: Editing disk label invalidates the whole device X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2010 07:54:52 -0000 Old Synopsis: Editing disk label invalidates the whole device New Synopsis: [disklabel]: Editing disk label invalidates the whole device Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: remko Responsible-Changed-When: Sat Apr 3 07:54:34 UTC 2010 Responsible-Changed-Why: Filesystem related. http://www.freebsd.org/cgi/query-pr.cgi?pr=145309 From owner-freebsd-fs@FreeBSD.ORG Sat Apr 3 10:51:26 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83EF5106564A; Sat, 3 Apr 2010 10:51:26 +0000 (UTC) (envelope-from brucec@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5A5498FC12; Sat, 3 Apr 2010 10:51:26 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o33ApQvU068496; Sat, 3 Apr 2010 10:51:26 GMT (envelope-from brucec@freefall.freebsd.org) Received: (from brucec@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o33ApQvX068492; Sat, 3 Apr 2010 10:51:26 GMT (envelope-from brucec) Date: Sat, 3 Apr 2010 10:51:26 GMT Message-Id: <201004031051.o33ApQvX068492@freefall.freebsd.org> To: brucec@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: brucec@FreeBSD.org Cc: Subject: Re: conf/116931: lack of fsck_cd9660 prevents mounting iso images with mdconfig_md%d (with workaround) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2010 10:51:26 -0000 Synopsis: lack of fsck_cd9660 prevents mounting iso images with mdconfig_md%d (with workaround) Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: brucec Responsible-Changed-When: Sat Apr 3 10:51:07 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=116931 From owner-freebsd-fs@FreeBSD.ORG Sat Apr 3 10:55:34 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E39CB106566B; Sat, 3 Apr 2010 10:55:34 +0000 (UTC) (envelope-from brucec@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B9A808FC15; Sat, 3 Apr 2010 10:55:34 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o33AtYqD068581; Sat, 3 Apr 2010 10:55:34 GMT (envelope-from brucec@freefall.freebsd.org) Received: (from brucec@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o33AtYXf068577; Sat, 3 Apr 2010 10:55:34 GMT (envelope-from brucec) Date: Sat, 3 Apr 2010 10:55:34 GMT Message-Id: <201004031055.o33AtYXf068577@freefall.freebsd.org> To: brucec@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: brucec@FreeBSD.org Cc: Subject: Re: kern/106107: [ufs] left-over fsck_snapshot after unfinished background fsck if filesystem clean X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2010 10:55:35 -0000 Synopsis: [ufs] left-over fsck_snapshot after unfinished background fsck if filesystem clean Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: brucec Responsible-Changed-When: Sat Apr 3 10:55:14 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=106107 From owner-freebsd-fs@FreeBSD.ORG Sat Apr 3 10:59:21 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1C844106566B; Sat, 3 Apr 2010 10:59:21 +0000 (UTC) (envelope-from brucec@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E79EF8FC08; Sat, 3 Apr 2010 10:59:20 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o33AxKmA068649; Sat, 3 Apr 2010 10:59:20 GMT (envelope-from brucec@freefall.freebsd.org) Received: (from brucec@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o33AxKfH068645; Sat, 3 Apr 2010 10:59:20 GMT (envelope-from brucec) Date: Sat, 3 Apr 2010 10:59:20 GMT Message-Id: <201004031059.o33AxKfH068645@freefall.freebsd.org> To: brucec@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: brucec@FreeBSD.org Cc: Subject: Re: kern/125895: [panic] kernel: panic: ffs_blkfree: freeing free block X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2010 10:59:21 -0000 Synopsis: [panic] kernel: panic: ffs_blkfree: freeing free block Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: brucec Responsible-Changed-When: Sat Apr 3 10:59:03 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=125895 From owner-freebsd-fs@FreeBSD.ORG Sat Apr 3 10:59:58 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 99E1A106566B; Sat, 3 Apr 2010 10:59:58 +0000 (UTC) (envelope-from brucec@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 70E638FC1A; Sat, 3 Apr 2010 10:59:58 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o33AxwfS068717; Sat, 3 Apr 2010 10:59:58 GMT (envelope-from brucec@freefall.freebsd.org) Received: (from brucec@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o33AxwsV068713; Sat, 3 Apr 2010 10:59:58 GMT (envelope-from brucec) Date: Sat, 3 Apr 2010 10:59:58 GMT Message-Id: <201004031059.o33AxwsV068713@freefall.freebsd.org> To: brucec@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-fs@FreeBSD.org From: brucec@FreeBSD.org Cc: Subject: Re: kern/53137: [panic] background fscking causing ffs_valloc panic. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2010 10:59:58 -0000 Synopsis: [panic] background fscking causing ffs_valloc panic. Responsible-Changed-From-To: freebsd-bugs->freebsd-fs Responsible-Changed-By: brucec Responsible-Changed-When: Sat Apr 3 10:59:39 UTC 2010 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=53137 From owner-freebsd-fs@FreeBSD.ORG Sat Apr 3 16:19:42 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76A6E1065675 for ; Sat, 3 Apr 2010 16:19:42 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 4C48B8FC23 for ; Sat, 3 Apr 2010 16:19:42 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o33GJfkv043512 for ; Sat, 3 Apr 2010 16:19:41 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o33GJf2F043511; Sat, 3 Apr 2010 16:19:41 GMT (envelope-from gnats) Date: Sat, 3 Apr 2010 16:19:41 GMT Message-Id: <201004031619.o33GJf2F043511@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: Andriy Gapon Cc: Subject: Re: conf/116931: lack of fsck_cd9660 prevents mounting iso images with mdconfig_md%d (with workaround) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Andriy Gapon List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2010 16:19:42 -0000 The following reply was made to PR conf/116931; it has been noted by GNATS. From: Andriy Gapon To: bug-followup@FreeBSD.org, phk@critter.freebsd.dk Cc: Subject: Re: conf/116931: lack of fsck_cd9660 prevents mounting iso images with mdconfig_md%d (with workaround) Date: Sat, 03 Apr 2010 14:08:16 +0300 Somewhat tangential: etc/rc.d/root shouldn't attempt to re-mount root filesystem read-write if it's known to be strictly read-only, e.g. cd9660. -- Andriy Gapon From owner-freebsd-fs@FreeBSD.ORG Sat Apr 3 17:05:32 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AAFA1106566C; Sat, 3 Apr 2010 17:05:32 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-ew0-f224.google.com (mail-ew0-f224.google.com [209.85.219.224]) by mx1.freebsd.org (Postfix) with ESMTP id 0BD5C8FC0C; Sat, 3 Apr 2010 17:05:30 +0000 (UTC) Received: by ewy24 with SMTP id 24so782608ewy.33 for ; Sat, 03 Apr 2010 10:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:to:cc:subject:references :organization:from:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=nIFYksMTKLKvMk5wrhZu7hoOz/1hIvzgysafqd+ccs0=; b=k3zFIWgrpvpyi5Z+U0TXFz+gQMRvZ8s6EJ4SK/6NT1svGtoH9iT7o5qCB3gQyDzZOn 00+er4ZO41dXQvTsJLBIXKjXlqlImuxG6ZfMCzSiFk67bwesHQFI11wueaGesJk+RsIA ndyQ3jUWcmobyQiCnyPyJmtgUHnpjp4DQViq0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=to:cc:subject:references:organization:from:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=cqlg4SklVA/XZr2I1V2UYySihQIAg3jDGFa04rGSg22sT00Kr4clf5cezzUbNsTUZ8 ZHT3YervaNahZYpvi5Zud7eePVI+KKfTf5jc39xxF02UD/lJFf1FPsKJxtpJ2YvWCws2 1E+84/7NA6gVCh7Y/+FoWTXp/Gg99CmvdUfeY= Received: by 10.213.37.11 with SMTP id v11mr1946995ebd.60.1270314329493; Sat, 03 Apr 2010 10:05:29 -0700 (PDT) Received: from localhost ([95.69.173.18]) by mx.google.com with ESMTPS id 15sm5479425ewy.12.2010.04.03.10.05.27 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 03 Apr 2010 10:05:28 -0700 (PDT) To: bug-followup@FreeBSD.org References: <201004031051.o33ApQvX068492@freefall.freebsd.org> Organization: TOA Ukraine From: Mikolaj Golub Date: Sat, 03 Apr 2010 20:05:25 +0300 In-Reply-To: <201004031051.o33ApQvX068492@freefall.freebsd.org> (brucec@freebsd.org's message of "Sat\, 3 Apr 2010 10\:51\:26 GMT") Message-ID: <866348jwkq.fsf@kopusha.onet> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Cc: freebsd-fs@FreeBSD.org, Poul-Henning Kamp Subject: Re: conf/116931: lack of fsck_cd9660 prevents mounting iso images with mdconfig_md%d (with workaround) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2010 17:05:32 -0000 --=-=-= We could keep the list of fs types that should not be fsck'ed (like in the first patch below) or could check the pass number in /etc/fstab (the second patch). -- Mikolaj Golub --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=mdconfig2.fsck_skip_fs.patch --- etc/rc.d/mdconfig2.orig 2010-04-03 18:39:43.000000000 +0300 +++ etc/rc.d/mdconfig2 2010-04-03 19:38:07.000000000 +0300 @@ -39,6 +39,19 @@ start_precmd='[ -n "${_mdconfig2_list}" ]' required_modules="geom_md:g_md" +fsck_skip_fs="cd9660 udf" + +in_list() +{ + local _x _list _i + _x=$1 + _list=$2 + for _i in ${_list}; do + [ "${_x}" = "${_i}" ] && return 0 + done + return 1 +} + is_readonly() { local _mp _ret @@ -95,10 +108,13 @@ for _i in `df ${_file} 2>/dev/null`; do _fs=${_i}; done fi + _fs_type=`awk -v d="${_dev}" '$1 == d {print $3; exit}' /etc/fstab` + # Debugging help. debug "${_md} config: ${_config}" debug "${_md} type: ${_type}" debug "${_md} dev: ${_dev}" + debug "${_md} fs_type: ${_fs_type}" debug "${_md} file: ${_file}" debug "${_md} fs: ${_fs}" debug "${_md} owner: ${_owner}" @@ -109,7 +125,7 @@ mdconfig2_start() { - local _md _fs _mp _mounted _dev _config _type _file _owner _perms _files _populate _fsck_cmd _i + local _md _fs _mp _mounted _dev _config _type _file _owner _perms _files _populate _fsck_cmd _fs_type _i for _md in ${_mdconfig2_list}; do init_variables ${_md} @@ -136,8 +152,9 @@ echo "Creating ${_md} device failed, moving on." continue fi - # Skip fsck for uzip devices. - if [ "${_file}" != "${_file%.uzip}" ]; then + # Skip fsck for uzip devices and for fs types listed in fsck_skip_fs + if [ "${_file}" != "${_file%.uzip}" ] || + in_list "${_fs_type}" "${fsck_skip_fs}"; then _fsck_cmd=":" elif checkyesno background_fsck; then _fsck_cmd="fsck -F" --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=mdconfig2.check_pass.patch --- etc/rc.d/mdconfig2.orig 2010-04-03 18:39:43.000000000 +0300 +++ etc/rc.d/mdconfig2 2010-04-03 19:59:15.000000000 +0300 @@ -136,8 +136,9 @@ echo "Creating ${_md} device failed, moving on." continue fi - # Skip fsck for uzip devices. - if [ "${_file}" != "${_file%.uzip}" ]; then + # Skip fsck for uzip devices or that have zero pass in fstab + if [ "${_file}" != "${_file%.uzip}" ] || + `awk -v d="${_dev}" '$1 == d {exit $6}' /etc/fstab`; then _fsck_cmd=":" elif checkyesno background_fsck; then _fsck_cmd="fsck -F" --=-=-=-- From owner-freebsd-fs@FreeBSD.ORG Sat Apr 3 17:10:13 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8382C1065672 for ; Sat, 3 Apr 2010 17:10:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 578BE8FC1D for ; Sat, 3 Apr 2010 17:10:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o33HADa5087700 for ; Sat, 3 Apr 2010 17:10:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o33HADg6087695; Sat, 3 Apr 2010 17:10:13 GMT (envelope-from gnats) Date: Sat, 3 Apr 2010 17:10:13 GMT Message-Id: <201004031710.o33HADg6087695@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: Mikolaj Golub Cc: Subject: Re: conf/116931: lack of fsck_cd9660 prevents mounting iso images with mdconfig_md%d (with workaround) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mikolaj Golub List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Apr 2010 17:10:13 -0000 The following reply was made to PR conf/116931; it has been noted by GNATS. From: Mikolaj Golub To: bug-followup@FreeBSD.org Cc: freebsd-fs@FreeBSD.org, Poul-Henning Kamp Subject: Re: conf/116931: lack of fsck_cd9660 prevents mounting iso images with mdconfig_md%d (with workaround) Date: Sat, 03 Apr 2010 20:05:25 +0300 --=-=-= We could keep the list of fs types that should not be fsck'ed (like in the first patch below) or could check the pass number in /etc/fstab (the second patch). -- Mikolaj Golub --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=mdconfig2.fsck_skip_fs.patch --- etc/rc.d/mdconfig2.orig 2010-04-03 18:39:43.000000000 +0300 +++ etc/rc.d/mdconfig2 2010-04-03 19:38:07.000000000 +0300 @@ -39,6 +39,19 @@ start_precmd='[ -n "${_mdconfig2_list}" ]' required_modules="geom_md:g_md" +fsck_skip_fs="cd9660 udf" + +in_list() +{ + local _x _list _i + _x=$1 + _list=$2 + for _i in ${_list}; do + [ "${_x}" = "${_i}" ] && return 0 + done + return 1 +} + is_readonly() { local _mp _ret @@ -95,10 +108,13 @@ for _i in `df ${_file} 2>/dev/null`; do _fs=${_i}; done fi + _fs_type=`awk -v d="${_dev}" '$1 == d {print $3; exit}' /etc/fstab` + # Debugging help. debug "${_md} config: ${_config}" debug "${_md} type: ${_type}" debug "${_md} dev: ${_dev}" + debug "${_md} fs_type: ${_fs_type}" debug "${_md} file: ${_file}" debug "${_md} fs: ${_fs}" debug "${_md} owner: ${_owner}" @@ -109,7 +125,7 @@ mdconfig2_start() { - local _md _fs _mp _mounted _dev _config _type _file _owner _perms _files _populate _fsck_cmd _i + local _md _fs _mp _mounted _dev _config _type _file _owner _perms _files _populate _fsck_cmd _fs_type _i for _md in ${_mdconfig2_list}; do init_variables ${_md} @@ -136,8 +152,9 @@ echo "Creating ${_md} device failed, moving on." continue fi - # Skip fsck for uzip devices. - if [ "${_file}" != "${_file%.uzip}" ]; then + # Skip fsck for uzip devices and for fs types listed in fsck_skip_fs + if [ "${_file}" != "${_file%.uzip}" ] || + in_list "${_fs_type}" "${fsck_skip_fs}"; then _fsck_cmd=":" elif checkyesno background_fsck; then _fsck_cmd="fsck -F" --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=mdconfig2.check_pass.patch --- etc/rc.d/mdconfig2.orig 2010-04-03 18:39:43.000000000 +0300 +++ etc/rc.d/mdconfig2 2010-04-03 19:59:15.000000000 +0300 @@ -136,8 +136,9 @@ echo "Creating ${_md} device failed, moving on." continue fi - # Skip fsck for uzip devices. - if [ "${_file}" != "${_file%.uzip}" ]; then + # Skip fsck for uzip devices or that have zero pass in fstab + if [ "${_file}" != "${_file%.uzip}" ] || + `awk -v d="${_dev}" '$1 == d {exit $6}' /etc/fstab`; then _fsck_cmd=":" elif checkyesno background_fsck; then _fsck_cmd="fsck -F" --=-=-=--