From owner-freebsd-fs@FreeBSD.ORG  Sun Sep 19 01:02:30 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2B934106566B
	for <freebsd-fs@freebsd.org>; Sun, 19 Sep 2010 01:02:30 +0000 (UTC)
	(envelope-from obrien@NUXI.org)
Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 0DCFC8FC12
	for <freebsd-fs@freebsd.org>; Sun, 19 Sep 2010 01:02:29 +0000 (UTC)
Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1])
	by dragon.nuxi.org (8.14.4/8.14.4) with ESMTP id o8J12T11093786;
	Sat, 18 Sep 2010 18:02:29 -0700 (PDT)
	(envelope-from obrien@dragon.nuxi.org)
Received: (from obrien@localhost)
	by dragon.nuxi.org (8.14.4/8.14.4/Submit) id o8J12TMK093785;
	Sat, 18 Sep 2010 18:02:29 -0700 (PDT) (envelope-from obrien)
Date: Sat, 18 Sep 2010 18:02:29 -0700
From: "David O'Brien" <obrien@freebsd.org>
To: Kostik Belousov <kostikbel@gmail.com>
Message-ID: <20100919010229.GB93245@dragon.NUXI.org>
References: <20100917180738.GA51572@dragon.NUXI.org>
	<20100917190907.GQ2389@deviant.kiev.zoral.com.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100917190907.GQ2389@deviant.kiev.zoral.com.ua>
X-Operating-System: FreeBSD 9.0-CURRENT
X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN?
User-Agent: Mutt/1.5.16 (2007-06-09)
Cc: freebsd-fs@freebsd.org
Subject: Re: [PATCH] replace INVARIANTS+panic() with KASSERT
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: obrien@freebsd.org
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Sep 2010 01:02:30 -0000

On Fri, Sep 17, 2010 at 10:09:07PM +0300, Kostik Belousov wrote:
> On Fri, Sep 17, 2010 at 11:07:38AM -0700, David O'Brien wrote:
> Isn't this reverted ? I believe that all conditions for panics/printf
> should be reverted in KASSERTs.

Yes, thanks.

> > -#ifdef notyet
> > -		if (bp)
> > -			brelse(bp);
> > -#endif
>
> Please leave both notyet blocks in indir_trunc() as is.
> There are patches in progress that change this fragments, and you
> supposedly seen them.

Will do.  Do you if you will commit them soon?

-- 
-- David  (obrien@FreeBSD.org)