From owner-freebsd-geom@FreeBSD.ORG Mon Aug 16 08:54:15 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 551DB1065674; Mon, 16 Aug 2010 08:54:15 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2BF658FC15; Mon, 16 Aug 2010 08:54:15 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7G8sFIq028588; Mon, 16 Aug 2010 08:54:15 GMT (envelope-from ae@freefall.freebsd.org) Received: (from ae@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7G8sE7b028584; Mon, 16 Aug 2010 08:54:14 GMT (envelope-from ae) Date: Mon, 16 Aug 2010 08:54:14 GMT Message-Id: <201008160854.o7G8sE7b028584@freefall.freebsd.org> To: mwisnicki+freebsd@gmail.com, ae@FreeBSD.org, freebsd-geom@FreeBSD.org From: ae@FreeBSD.org Cc: Subject: Re: kern/148540: [geom] geom_sched breaks ata devices X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2010 08:54:15 -0000 Synopsis: [geom] geom_sched breaks ata devices State-Changed-From-To: patched->closed State-Changed-By: ae State-Changed-When: Mon Aug 16 08:53:50 UTC 2010 State-Changed-Why: Merged to stable/8. http://www.freebsd.org/cgi/query-pr.cgi?pr=148540 From owner-freebsd-geom@FreeBSD.ORG Mon Aug 16 09:00:08 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 471CD1065675 for ; Mon, 16 Aug 2010 09:00:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 116498FC0A for ; Mon, 16 Aug 2010 09:00:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7G907MW028784 for ; Mon, 16 Aug 2010 09:00:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7G907o5028783; Mon, 16 Aug 2010 09:00:07 GMT (envelope-from gnats) Date: Mon, 16 Aug 2010 09:00:07 GMT Message-Id: <201008160900.o7G907o5028783@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: kern/148540: commit references a PR X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2010 09:00:08 -0000 The following reply was made to PR kern/148540; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/148540: commit references a PR Date: Mon, 16 Aug 2010 08:51:45 +0000 (UTC) Author: ae Date: Mon Aug 16 08:51:35 2010 New Revision: 211391 URL: http://svn.freebsd.org/changeset/base/211391 Log: MFC r210747: Forward ioctl requests to original geom. PR: 148540 Approved by: kib (mentor) Modified: stable/8/sys/geom/sched/g_sched.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cam/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) stable/8/sys/dev/e1000/ (props changed) stable/8/sys/dev/xen/xenpci/ (props changed) Modified: stable/8/sys/geom/sched/g_sched.c ============================================================================== --- stable/8/sys/geom/sched/g_sched.c Mon Aug 16 08:48:39 2010 (r211390) +++ stable/8/sys/geom/sched/g_sched.c Mon Aug 16 08:51:35 2010 (r211391) @@ -136,6 +136,8 @@ static void g_sched_dumpconf(struct sbuf struct g_geom *gp, struct g_consumer *cp, struct g_provider *pp); static void g_sched_init(struct g_class *mp); static void g_sched_fini(struct g_class *mp); +static int g_sched_ioctl(struct g_provider *pp, u_long cmd, void *data, + int fflag, struct thread *td); struct g_class g_sched_class = { .name = G_SCHED_CLASS_NAME, @@ -144,6 +146,7 @@ struct g_class g_sched_class = { .taste = g_sched_taste, .destroy_geom = g_sched_destroy_geom, .init = g_sched_init, + .ioctl = g_sched_ioctl, .fini = g_sched_fini }; @@ -1601,6 +1604,22 @@ g_sched_fini(struct g_class *mp) mtx_destroy(&me.gs_mtx); } +static int +g_sched_ioctl(struct g_provider *pp, u_long cmd, void *data, int fflag, + struct thread *td) +{ + struct g_consumer *cp; + struct g_geom *gp; + + cp = LIST_FIRST(&pp->geom->consumer); + if (cp == NULL) + return (ENOIOCTL); + gp = cp->provider->geom; + if (gp->ioctl == NULL) + return (ENOIOCTL); + return (gp->ioctl(cp->provider, cmd, data, fflag, td)); +} + /* * Read the i-th argument for a request, skipping the /dev/ * prefix if present. _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-freebsd-geom@FreeBSD.ORG Mon Aug 16 11:06:59 2010 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F107910656A5 for ; Mon, 16 Aug 2010 11:06:59 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DED168FC08 for ; Mon, 16 Aug 2010 11:06:59 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7GB6xR4058879 for ; Mon, 16 Aug 2010 11:06:59 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7GB6x3n058877 for freebsd-geom@FreeBSD.org; Mon, 16 Aug 2010 11:06:59 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 16 Aug 2010 11:06:59 GMT Message-Id: <201008161106.o7GB6x3n058877@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-geom@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-geom@FreeBSD.org X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2010 11:07:00 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o bin/149215 geom [panic] gpart(8): Delete linux's slice via Gpart - get o kern/147852 geom [geom] [panic] graid3 panic: wrong offset 16384 for se o kern/147851 geom [geom] [panic] graid3 panic: g_read_data: invalid leng o kern/147667 geom [gmirror] Booting with one component of a gmirror, the o kern/147664 geom [geom] [patch] Add the ability to create linux and fat o kern/145818 geom [geom] geom_stat_open showing cached information for n o kern/145042 geom [geom] System stops booting after printing message "GE o kern/144962 geom [geom] panic when accessing GPT disk with a large numb o kern/144905 geom [geom][gpart] panic in gpart_ctlreq when unplugging ca o bin/144521 geom geom(1) tool parsing non-subclass command broken o kern/143455 geom gstripe(8) in RELENG_8 (31st Jan 2010) broken o kern/142563 geom [geom] [hang] ioctl freeze in zpool f kern/142365 geom [geom] FreeBSD RAID1 (gmirror) is much slower than Lin o kern/141740 geom [geom] gjournal(8): g_journal_destroy concurrent error s kern/141235 geom [geom_part] 8.0 no longer provides /dev entries for al o kern/140352 geom [geom] gjournal + glabel not working o kern/135898 geom [geom] Severe filesystem corruption - large files or l o kern/134922 geom [gmirror] [panic] kernel panic when use fdisk on disk o kern/134113 geom [geli] Problem setting secondary GELI key o kern/134044 geom [geom] gmirror(8) overwrites fs with stale data from r o kern/133931 geom [geli] [request] intentionally wrong password to destr o bin/132845 geom [geom] [patch] ggated(8) does not close files opened a o kern/132273 geom glabel(8): [patch] failing on journaled partition f kern/132242 geom [gmirror] gmirror.ko fails to fully initialize o kern/131353 geom [geom] gjournal(8) kernel lock p docs/130548 geom [patch] gjournal(8) man page is missing sysctls o kern/129674 geom [geom] gjournal root did not mount on boot o kern/129645 geom gjournal(8): GEOM_JOURNAL causes system to fail to boo o kern/129245 geom [geom] gcache is more suitable for suffix based provid f kern/128276 geom [gmirror] machine lock up when gmirror module is used o kern/124973 geom [gjournal] [patch] boot order affects geom_journal con o kern/124969 geom gvinum(8): gvinum raid5 plex does not detect missing s o kern/123962 geom [panic] [gjournal] gjournal (455Gb data, 8Gb journal), o kern/123122 geom [geom] GEOM / gjournal kernel lock o kern/122738 geom [geom] gmirror list "losts consumers" after gmirror de f kern/122415 geom [geom] UFS labels are being constantly created and rem o kern/122067 geom [geom] [panic] Geom crashed during boot o kern/121559 geom [patch] [geom] geom label class allows to create inacc o kern/121364 geom [gmirror] Removing all providers create a "zombie" mir o kern/120091 geom [geom] [geli] [gjournal] geli does not prompt for pass o kern/115856 geom [geli] ZFS thought it was degraded when it should have o kern/115547 geom [geom] [patch] [request] let GEOM Eli get password fro o kern/114532 geom [geom] GEOM_MIRROR shows up in kldstat even if compile f kern/113957 geom [gmirror] gmirror is intermittently reporting a degrad o kern/113837 geom [geom] unable to access 1024 sector size storage o kern/113419 geom [geom] geom fox multipathing not failing back p bin/110705 geom gmirror(8) control utility does not exit with correct o kern/107707 geom [geom] [patch] [request] add new class geom_xbox360 to o kern/94632 geom [geom] Kernel output resets input while GELI asks for o kern/90582 geom [geom] [panic] Restore cause panic string (ffs_blkfree o bin/90093 geom fdisk(8) incapable of altering in-core geometry o kern/88601 geom [geli] geli cause kernel panic under heavy disk usage o kern/87544 geom [gbde] mmaping large files on a gbde filesystem deadlo o kern/84556 geom [geom] [panic] GBDE-encrypted swap causes panic at shu o kern/79251 geom [2TB] newfs fails on 2.6TB gbde device o kern/79035 geom [vinum] gvinum unable to create a striped set of mirro o bin/78131 geom gbde(8) "destroy" not working. s kern/73177 geom kldload geom_* causes panic due to memory exhaustion 58 problems total. From owner-freebsd-geom@FreeBSD.ORG Tue Aug 17 04:27:40 2010 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5772A10656A4 for ; Tue, 17 Aug 2010 04:27:40 +0000 (UTC) (envelope-from greg@bonett.org) Received: from bonett.org (bonett.org [66.249.7.150]) by mx1.freebsd.org (Postfix) with ESMTP id 34ACD8FC14 for ; Tue, 17 Aug 2010 04:27:39 +0000 (UTC) Received: from [192.168.1.7] (cpe-75-85-52-129.socal.res.rr.com [75.85.52.129]) by bonett.org (Postfix) with ESMTPSA id BA62412407D for ; Tue, 17 Aug 2010 04:08:41 +0000 (UTC) From: Greg Bonett To: freebsd-geom@FreeBSD.org Content-Type: text/plain Date: Mon, 16 Aug 2010 21:04:23 -0700 Message-Id: <1282017863.3017.10.camel@debian> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Cc: Subject: upgraded to 7.3 - trouble with gstripe and geli X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: greg@bonett.org List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Aug 2010 04:27:40 -0000 hi, I just upgraded to freebsd 7.3 on amd64 and I'm having trouble attaching a geli device. I am using gstripe to created a striped array with two disks and then using geli to create an encryption layer on top of it. It was working with 7.2, but after an upgrade I'm running into this error when I try and attach the geli device: #geli attach -k key.file /dev/stripe/private geli: Cannot read metadata from /dev/stripe/private: Invalid argument. also gstripe dump gives: #gstripe dump /dev/stripe/private Can't read metadata from /dev/stripe/private: Invalid argument. gstripe: Not fully done. but gstripe status says: #gstripe status private Name Status Components stripe/private UP ad8s2 ad12s2 and gstripe list gives: #gstripe list private Geom name: stripe State: UP Status: Total=2, Online=2 Type: MANUAL Stripesize: 65536 ID: 248630040 Providers: 1. Name: stripe/private Mediasize: 1925258280960 (1.8T) Sectorsize: 512 Mode: r0w0e0 Consumers: 1. Name: ad8s2 Mediasize: 962629194240 (897G) Sectorsize: 512 Mode: r0w0e0 Number: 0 2. Name: ad12s2 Mediasize: 962631548928 (897G) Sectorsize: 512 Mode: r0w0e0 Number: 1 I didn't see anything in /usr/src/UPDATING about gstripe but I'm wondering if the default stripe size or something changed between 7.2 and 7.3 anyone have any suggestions? Let me know if there is more relavent data i should provide. Thanks in advance. -Greg From owner-freebsd-geom@FreeBSD.ORG Tue Aug 17 15:20:03 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B95A9106567A for ; Tue, 17 Aug 2010 15:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A7B7C8FC13 for ; Tue, 17 Aug 2010 15:20:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7HFK3QK056561 for ; Tue, 17 Aug 2010 15:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7HFK3nK056558; Tue, 17 Aug 2010 15:20:03 GMT (envelope-from gnats) Date: Tue, 17 Aug 2010 15:20:03 GMT Message-Id: <201008171520.o7HFK3nK056558@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: "Andrey V. Elsukov" Cc: Subject: Re: bin/149215: [panic] gpart(8): Delete linux's slice via Gpart - get kernel panic X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Andrey V. Elsukov" List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Aug 2010 15:20:03 -0000 The following reply was made to PR bin/149215; it has been noted by GNATS. From: "Andrey V. Elsukov" To: bug-followup@FreeBSD.org, universite@ukr.net Cc: Andrew Thompson Subject: Re: bin/149215: [panic] gpart(8): Delete linux's slice via Gpart - get kernel panic Date: Tue, 17 Aug 2010 19:12:46 +0400 Hi, As I see from `gpart show ad4` output and from screenshot ad4 disk was part of software raid (partition type '253') and also it was part of Linux LVM. Also, last messages before panic are: GEOM_LINUX_LVM: Disk ad4s3 removed from pv0. GEOM_LINUX_LVM: I think panic occurs in this code from g_linux_lvm.c: g_llvm_remove_disk(struct g_llvm_vg *vg, struct g_consumer *cp) .... if (found) { G_LLVM_DEBUG(0, "Device %s removed.", lv->lv_gprov->name); ^^^^^^^^^^^^^^^^^^^^^^^^ - NULL-pointer dereference here g_orphan_provider(lv->lv_gprov, ENXIO); lv->lv_gprov = NULL; } -- WBR, Andrey V. Elsukov From owner-freebsd-geom@FreeBSD.ORG Wed Aug 18 16:41:37 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D3D831065694; Wed, 18 Aug 2010 16:41:37 +0000 (UTC) (envelope-from olli@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AB11A8FC0C; Wed, 18 Aug 2010 16:41:37 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7IGfbOY095959; Wed, 18 Aug 2010 16:41:37 GMT (envelope-from olli@freefall.freebsd.org) Received: (from olli@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7IGfb09095955; Wed, 18 Aug 2010 16:41:37 GMT (envelope-from olli) Date: Wed, 18 Aug 2010 16:41:37 GMT Message-Id: <201008181641.o7IGfb09095955@freefall.freebsd.org> To: walter@pelissero.de, olli@FreeBSD.org, freebsd-bugs@FreeBSD.org, freebsd-geom@FreeBSD.org From: olli@FreeBSD.org Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2010 16:41:37 -0000 Synopsis: volume labels with rogue characters State-Changed-From-To: closed->open State-Changed-By: olli State-Changed-When: Wed Aug 18 16:37:02 UTC 2010 State-Changed-Why: Re-open and assign to -geom. Maybe some knowledgeable person here can review and handle this. Responsible-Changed-From-To: freebsd-bugs->freebsd-geom Responsible-Changed-By: olli Responsible-Changed-When: Wed Aug 18 16:37:02 UTC 2010 Responsible-Changed-Why: Re-open and assign to -geom. Maybe some knowledgeable person here can review and handle this. http://www.freebsd.org/cgi/query-pr.cgi?pr=149762 From owner-freebsd-geom@FreeBSD.ORG Wed Aug 18 16:50:03 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C018C106564A for ; Wed, 18 Aug 2010 16:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 951208FC0A for ; Wed, 18 Aug 2010 16:50:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7IGo3lN096177 for ; Wed, 18 Aug 2010 16:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7IGo3vu096176; Wed, 18 Aug 2010 16:50:03 GMT (envelope-from gnats) Date: Wed, 18 Aug 2010 16:50:03 GMT Message-Id: <201008181650.o7IGo3vu096176@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Oliver Fromme Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Oliver Fromme List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2010 16:50:03 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: Oliver Fromme To: freebsd-bugs@FreeBSD.ORG, bug-followup@FreeBSD.ORG, walter@pelissero.de Cc: Subject: Re: kern/149762: volume labels with rogue characters Date: Wed, 18 Aug 2010 18:36:22 +0200 (CEST) Walter C. Pelissero wrote: > In the following patch, the function sanitise_name (controlled > by kern.geom.label.sanitation sysctl) replaces characters > deemed invalid according to three levels: > > 0 - replace only '/'s with '#'s > 1 - like 0, but also replace whitespace and all the ASCII control > characters (anything below 0x20) with '_' > 2 - like 1, but also replace anything above 0x7E with '#' > > Note that the replacement of '/'s is done in any case. I > don't know whether that might be redundant or even bad in the > context of the other geom_label stuff. It just made sense, > but I don't have enough familiarity with that code. FWIW, I like this approach much better than the one from bin/149424. (Trying to put personal attitudes aside.) I have reviewed the patch (the second one from the followup), and it looks good to me, except for a few minor style(9) issues, and one type problem: By default, char is unsigned, so the comparisons p <= ' ' and p > '~' probably don't do what you expect. Other than that, the patch looks fine to me. But I'm not authoritative regarding the geom code in the kernel, so I cannot pick this up myself. I'll re-assign the PR to -geom, maybe someone there can help. Best regards Oliver -- Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M. Handelsregister: Registergericht Muenchen, HRA 74606, Geschäftsfuehrung: secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün- chen, HRB 125758, Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart FreeBSD-Dienstleistungen, -Produkte und mehr: http://www.secnetix.de/bsd "... there are two ways of constructing a software design: One way is to make it so simple that there are _obviously_ no deficiencies and the other way is to make it so complicated that there are no _obvious_ deficiencies." -- C.A.R. Hoare, ACM Turing Award Lecture, 1980 From owner-freebsd-geom@FreeBSD.ORG Wed Aug 18 17:06:43 2010 Return-Path: Delivered-To: freebsd-geom@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8159C106566B; Wed, 18 Aug 2010 17:06:43 +0000 (UTC) (envelope-from olli@lurza.secnetix.de) Received: from lurza.secnetix.de (lurza.secnetix.de [IPv6:2a01:170:102f::2]) by mx1.freebsd.org (Postfix) with ESMTP id 012328FC18; Wed, 18 Aug 2010 17:06:42 +0000 (UTC) Received: from lurza.secnetix.de (localhost [127.0.0.1]) by lurza.secnetix.de (8.14.3/8.14.3) with ESMTP id o7IH6QtR042333; Wed, 18 Aug 2010 19:06:41 +0200 (CEST) (envelope-from oliver.fromme@secnetix.de) Received: (from olli@localhost) by lurza.secnetix.de (8.14.3/8.14.3/Submit) id o7IH6Q3q042332; Wed, 18 Aug 2010 19:06:26 +0200 (CEST) (envelope-from olli) Date: Wed, 18 Aug 2010 19:06:26 +0200 (CEST) Message-Id: <201008181706.o7IH6Q3q042332@lurza.secnetix.de> From: Oliver Fromme To: freebsd-geom@FreeBSD.ORG, bug-followup@FreeBSD.ORG, walter@pelissero.de In-Reply-To: <201008181650.o7IGo3vu096176@freefall.freebsd.org> X-Newsgroups: list.freebsd-geom User-Agent: tin/1.8.3-20070201 ("Scotasay") (UNIX) (FreeBSD/6.4-PRERELEASE-20080904 (i386)) MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.3.4 (lurza.secnetix.de [127.0.0.1]); Wed, 18 Aug 2010 19:06:41 +0200 (CEST) Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2010 17:06:43 -0000 Oliver Fromme wrote: > I have reviewed the patch (the second one from the followup), > and it looks good to me, except for a few minor style(9) > issues, and one type problem: By default, char is unsigned, ^^^^^^^^^^^^^^^^^^ > so the comparisons p <= ' ' and p > '~' probably don't do > what you expect. I'm sorry, I meant signed, of course. You need to specify "unsigned char" if you want it to be unsigned. Best regards Oliver -- Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M. Handelsregister: Registergericht Muenchen, HRA 74606, Geschäftsfuehrung: secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün- chen, HRB 125758, Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart FreeBSD-Dienstleistungen, -Produkte und mehr: http://www.secnetix.de/bsd "C is quirky, flawed, and an enormous success." -- Dennis M. Ritchie. From owner-freebsd-geom@FreeBSD.ORG Wed Aug 18 17:10:03 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A540106564A for ; Wed, 18 Aug 2010 17:10:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 45FAF8FC08 for ; Wed, 18 Aug 2010 17:10:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7IHA3Pw015254 for ; Wed, 18 Aug 2010 17:10:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7IHA3Ww015251; Wed, 18 Aug 2010 17:10:03 GMT (envelope-from gnats) Date: Wed, 18 Aug 2010 17:10:03 GMT Message-Id: <201008181710.o7IHA3Ww015251@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Oliver Fromme Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Oliver Fromme List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2010 17:10:03 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: Oliver Fromme To: freebsd-geom@FreeBSD.ORG, bug-followup@FreeBSD.ORG, walter@pelissero.de Cc: Subject: Re: kern/149762: volume labels with rogue characters Date: Wed, 18 Aug 2010 19:06:26 +0200 (CEST) Oliver Fromme wrote: > I have reviewed the patch (the second one from the followup), > and it looks good to me, except for a few minor style(9) > issues, and one type problem: By default, char is unsigned, ^^^^^^^^^^^^^^^^^^ > so the comparisons p <= ' ' and p > '~' probably don't do > what you expect. I'm sorry, I meant signed, of course. You need to specify "unsigned char" if you want it to be unsigned. Best regards Oliver -- Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M. Handelsregister: Registergericht Muenchen, HRA 74606, Geschäftsfuehrung: secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün- chen, HRB 125758, Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart FreeBSD-Dienstleistungen, -Produkte und mehr: http://www.secnetix.de/bsd "C is quirky, flawed, and an enormous success." -- Dennis M. Ritchie. From owner-freebsd-geom@FreeBSD.ORG Wed Aug 18 19:34:39 2010 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F398D106564A; Wed, 18 Aug 2010 19:34:38 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 52D6E8FC0A; Wed, 18 Aug 2010 19:34:37 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o7IIwWSg059719 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 18 Aug 2010 21:58:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o7IIwWwL017366; Wed, 18 Aug 2010 21:58:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o7IIwWZf017365; Wed, 18 Aug 2010 21:58:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 18 Aug 2010 21:58:31 +0300 From: Kostik Belousov To: Oliver Fromme Message-ID: <20100818185831.GX2396@deviant.kiev.zoral.com.ua> References: <201008181650.o7IGo3vu096176@freefall.freebsd.org> <201008181706.o7IH6Q3q042332@lurza.secnetix.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b6tME5Uow9dgAUD7" Content-Disposition: inline In-Reply-To: <201008181706.o7IH6Q3q042332@lurza.secnetix.de> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.2 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_50, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: walter@pelissero.de, bug-followup@freebsd.org, freebsd-geom@freebsd.org Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2010 19:34:39 -0000 --b6tME5Uow9dgAUD7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 18, 2010 at 07:06:26PM +0200, Oliver Fromme wrote: > Oliver Fromme wrote: > > I have reviewed the patch (the second one from the followup), > > and it looks good to me, except for a few minor style(9) > > issues, and one type problem: By default, char is unsigned, > ^^^^^^^^^^^^^^^^^^ > > so the comparisons p <=3D ' ' and p > '~' probably don't do > > what you expect. >=20 > I'm sorry, I meant signed, of course. > You need to specify "unsigned char" if you want it to be unsigned. Signedness of char is implementation-depended. It is signed on x86-oids, and unsigned on powerpc, AFAIR. --b6tME5Uow9dgAUD7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkxsLVcACgkQC3+MBN1Mb4jcDQCfUYofBvJScewmXBYPLljLETSO 798An0wmSPW4dbr4fReYCvPaN/9AbLdl =sCVM -----END PGP SIGNATURE----- --b6tME5Uow9dgAUD7-- From owner-freebsd-geom@FreeBSD.ORG Wed Aug 18 19:40:03 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83FAC10656A6 for ; Wed, 18 Aug 2010 19:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6FF0D8FC08 for ; Wed, 18 Aug 2010 19:40:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7IJe3gq063619 for ; Wed, 18 Aug 2010 19:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7IJe3wf063617; Wed, 18 Aug 2010 19:40:03 GMT (envelope-from gnats) Date: Wed, 18 Aug 2010 19:40:03 GMT Message-Id: <201008181940.o7IJe3wf063617@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Kostik Belousov Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Kostik Belousov List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2010 19:40:03 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: Kostik Belousov To: Oliver Fromme Cc: freebsd-geom@freebsd.org, bug-followup@freebsd.org, walter@pelissero.de Subject: Re: kern/149762: volume labels with rogue characters Date: Wed, 18 Aug 2010 21:58:31 +0300 --b6tME5Uow9dgAUD7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 18, 2010 at 07:06:26PM +0200, Oliver Fromme wrote: > Oliver Fromme wrote: > > I have reviewed the patch (the second one from the followup), > > and it looks good to me, except for a few minor style(9) > > issues, and one type problem: By default, char is unsigned, > ^^^^^^^^^^^^^^^^^^ > > so the comparisons p <=3D ' ' and p > '~' probably don't do > > what you expect. >=20 > I'm sorry, I meant signed, of course. > You need to specify "unsigned char" if you want it to be unsigned. Signedness of char is implementation-depended. It is signed on x86-oids, and unsigned on powerpc, AFAIR. --b6tME5Uow9dgAUD7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkxsLVcACgkQC3+MBN1Mb4jcDQCfUYofBvJScewmXBYPLljLETSO 798An0wmSPW4dbr4fReYCvPaN/9AbLdl =sCVM -----END PGP SIGNATURE----- --b6tME5Uow9dgAUD7-- From owner-freebsd-geom@FreeBSD.ORG Thu Aug 19 00:10:05 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E91FF1065694 for ; Thu, 19 Aug 2010 00:10:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D90338FC13 for ; Thu, 19 Aug 2010 00:10:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7J0A5Yv030259 for ; Thu, 19 Aug 2010 00:10:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7J0A5EL030258; Thu, 19 Aug 2010 00:10:05 GMT (envelope-from gnats) Date: Thu, 19 Aug 2010 00:10:05 GMT Message-Id: <201008190010.o7J0A5EL030258@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: jhell Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: jhell List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2010 00:10:06 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: jhell To: bug-followup@FreeBSD.org Cc: walter@pelissero.de Subject: Re: kern/149762: volume labels with rogue characters Date: Wed, 18 Aug 2010 20:04:40 -0400 This is a hack, something that you would commonly find in Linux code and is neither a proper or viable workaround for the naming of labels. Instead, using glabel(8) the admin/user can create a local label to FreeBSD that does not change the original nor does it carry over to any other OS that does not understand geom_label's. From the manual page: label Set up a label name for the given provider. This is the ``automatic'' method, where metadata is stored in a provider's last sector. The kernel module geom_label.ko will be loaded if it is not loaded already. Stripping characters no matter what they are with a sysctl is overkill and does not scale well, all the while - presenting false information to the user. I would highly advise against this. If the user does not like the label that appears in msdosfs/{LABEL} then they are free to change that at their own will. I see presenting the label as it is to the user ``important''. Lets not try to prevent a foot shooting but instead document the case in the manual. Also if they are using FreeBSD and they are also adding a mount-point to fstab(5) for a geom_label then intelligence lurks within. Regards, -- jhell,v From owner-freebsd-geom@FreeBSD.ORG Thu Aug 19 01:45:03 2010 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB99D1065675 for ; Thu, 19 Aug 2010 01:45:03 +0000 (UTC) (envelope-from greg@bonett.org) Received: from bonett.org (bonett.org [66.249.7.150]) by mx1.freebsd.org (Postfix) with ESMTP id B5AC38FC17 for ; Thu, 19 Aug 2010 01:45:03 +0000 (UTC) Received: from [192.168.1.7] (cpe-75-85-52-129.socal.res.rr.com [75.85.52.129]) by bonett.org (Postfix) with ESMTPSA id 554EF124365 for ; Thu, 19 Aug 2010 01:43:34 +0000 (UTC) From: Greg Bonett To: freebsd-geom@FreeBSD.org In-Reply-To: <20100817194337.GA2438@garage.freebsd.pl> References: <1282017863.3017.10.camel@debian> <20100817194337.GA2438@garage.freebsd.pl> Content-Type: text/plain Date: Wed, 18 Aug 2010 18:38:58 -0700 Message-Id: <1282181940.22964.18.camel@debian> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Cc: Subject: Re: upgraded to 7.3 - trouble with gstripe and geli X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: greg@bonett.org List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2010 01:45:03 -0000 On Tue, 2010-08-17 at 21:43 +0200, Pawel Jakub Dawidek wrote: > On Mon, Aug 16, 2010 at 09:04:23PM -0700, Greg Bonett wrote: > > hi, > > I just upgraded to freebsd 7.3 on amd64 and I'm having trouble attaching > > a geli device. I am using gstripe to created a striped array with two > > disks and then using geli to create an encryption layer on top of it. > > It was working with 7.2, but after an upgrade I'm running into this > > error when I try and attach the geli device: > > > > #geli attach -k key.file /dev/stripe/private > > geli: Cannot read metadata from /dev/stripe/private: Invalid argument. > > > > also gstripe dump gives: > > #gstripe dump /dev/stripe/private > > Can't read metadata from /dev/stripe/private: Invalid argument. > > gstripe: Not fully done. > > You should apply 'gstripe dump' to stripe components, so in your case to > ad8s2 and ad12s2. ah yes that seems to give the correct data. > If 'geli dump /dev/stripe/private' doesn't show anything, try dumping > the last sector: > > # dd if=/dev/stripe/private count=1 iseek=3760270079 | hexdump -C | head offsite# dd if=/dev/stripe/private count=1 iseek=3760270079 | hexdump -C | head 1+0 records in 1+0 records out 512 bytes transferred in 0.000313 secs (1635555 bytes/sec) 00000000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| * 00000200 hmm, I'm not sure what i was supposed to see there, but I'm assuming it's not all zeros. Does this mean I wrote over the geli meta data? Does this make my data irrecoverable even if i have the key and password and could probably figure out what encryption algorithm I was using? (I don't have the .eli file for this device) What's in there that's required to reconstruct the data? These are just backups, so I won't be too heartbroken if it's gone. If I had that .eli file, would this just be a matter of "geli restore"? Also, it looks like there is data at the beginning of the /dev/stripe/private device but not at the end. (last 80 blocks are all zeros) Is this a clue as to what I did to destroy my meta data? Thanks for the response. From owner-freebsd-geom@FreeBSD.ORG Thu Aug 19 11:30:04 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 309051065679 for ; Thu, 19 Aug 2010 11:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 050B38FC12 for ; Thu, 19 Aug 2010 11:30:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7JBU3Oj033856 for ; Thu, 19 Aug 2010 11:30:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7JBU3jU033851; Thu, 19 Aug 2010 11:30:03 GMT (envelope-from gnats) Date: Thu, 19 Aug 2010 11:30:03 GMT Message-Id: <201008191130.o7JBU3jU033851@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: Oliver Fromme Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Oliver Fromme List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2010 11:30:04 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: Oliver Fromme To: jhell , bug-followup@freebsd.org Cc: Subject: Re: kern/149762: volume labels with rogue characters Date: Thu, 19 Aug 2010 13:29:25 +0200 (CEST) jhell wrote: > This is a hack, something that you would commonly find in Linux code and > is neither a proper or viable workaround for the naming of labels. > > Instead, using glabel(8) the admin/user can create a local label to > FreeBSD that does not change the original nor does it carry over to any > other OS that does not understand geom_label's. There are cases were you cannot create a permanent label with glabel. For example, there are quite a lot of USB devices that insist on having their memory formatted with their own firmware only, destroying any other labels. I own an mp3 player (Medion) that behaves like this. The submitter mentioned a digital camera (Nikon, I think) in a previous thread. How do you suggest to solve the problem for those cases? > Stripping characters no matter what they are with a sysctl is overkill > and does not scale well, all the while - presenting false information to > the user. I don't think there is a scalability issue, because it is only done once when a device is attached. On the other hand, maybe the patch should be changed so it doesn't touch the name at all when the sysctl is 0, so the default behaviour would be no different from what we have today. > I would highly advise against this. If the user does not like > the label that appears in msdosfs/{LABEL} then they are free to change > that at their own will. Unfortunately they are subject to the will of their devices, see above. And if the device's own label contains a space (the Nikon camera mentioned above does), it cannot be used as-is in /etc/fstab. I think a similar problem occurs with the volume names of CD-ROMs and DVD-ROMs, which contain spaces quite often, and you cannot glabel them. But I haven't looked deeply into this, maybe it's not an issue. (Does FreeBSD even support mounting CDs by their volume name, like Solaris does? I've never tried, but it would come in handy, because I have a clip art CD that I use every now and then, and I never remember whether it's in drive cd0 or cd1 currently ...) > I see presenting the label as it is to the user > ``important''. Uhm ... it is not my impression that the names of nodes in /dev are intended to present accurate "external" information to the user. I always thought that the purpose of /dev is an interface between userland software and drivers, and that users shouldn't have to deal with /dev at all during "normal operations". Am I wrong? I mean, there are commands to display the atual labels if you need to see them (and I don't mean "ls /dev/..."). Best regards Oliver -- Oliver Fromme, secnetix GmbH & Co. KG, Marktplatz 29, 85567 Grafing b. M. Handelsregister: Registergericht Muenchen, HRA 74606, Geschäftsfuehrung: secnetix Verwaltungsgesellsch. mbH, Handelsregister: Registergericht Mün- chen, HRB 125758, Geschäftsführer: Maik Bachmann, Olaf Erb, Ralf Gebhart FreeBSD-Dienstleistungen, -Produkte und mehr: http://www.secnetix.de/bsd "When your hammer is C++, everything begins to look like a thumb." -- Steve Haflich, in comp.lang.c++ From owner-freebsd-geom@FreeBSD.ORG Thu Aug 19 12:40:03 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51EBD10656CB for ; Thu, 19 Aug 2010 12:40:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3CEEE8FC16 for ; Thu, 19 Aug 2010 12:40:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7JCe2sJ005866 for ; Thu, 19 Aug 2010 12:40:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7JCe2kP005865; Thu, 19 Aug 2010 12:40:02 GMT (envelope-from gnats) Date: Thu, 19 Aug 2010 12:40:02 GMT Message-Id: <201008191240.o7JCe2kP005865@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: walter@pelissero.de (Walter C. Pelissero) Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Walter C. Pelissero" List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2010 12:40:03 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: walter@pelissero.de (Walter C. Pelissero) To: jhell Cc: bug-followup@FreeBSD.org, freebsd-bugs@FreeBSD.ORG Subject: Re: kern/149762: volume labels with rogue characters Date: Thu, 19 Aug 2010 14:26:26 +0200 jhell writes: > This is a hack, something that you would commonly find in Linux > code and is neither a proper or viable workaround for the naming of > labels. That's exactly what I keep repeating my friends who run Linux and brag about features they had first or better implemented. Just a bunch of dirty hacks any kid would have whipped up in an afternoon if he just had the fancy. Just hacks. Unfortunately they answer using terms like: self-indulgent inertia, inconclusive arrogance, bureaucratic attitude, self-important sloth, pompous underachiever. Bloody Linux kids, aren't they? This might be an hack, but in 8 years since this issue has been first raised nobody has came up with it, so I thought I might as well do it. > Instead, using glabel(8) the admin/user can create a local label to > FreeBSD that does not change the original nor does it carry over to any > other OS that does not understand geom_label's. > > >From the manual page: > > label Set up a label name for the given provider. This is the > ``automatic'' method, where metadata is stored in a provider's > last sector. The kernel module geom_label.ko will be loaded if > it is not loaded already. Can anyone explain me how metadata stored on media cannot interfere with other OSs? Below I include a revised patch that turns kern.geom.label.sanitation into a bitmask, thus allowing to enable selectively the replacements, as I have been struck by the fact that slashes in labels might be desirable, as they create a path (although the parent directory is left behind after the device disappearance). Now kern.geom.label.sanitation can be set to zero (default) obtaining the usual behaviour without "hack". So that when I meet up with some Vogon friends, who coincidentally all run exclusively FreeBSD or VMS, I can revert the sysctl and show them their volume labels coded in UTF-16. Well, yes, "show". Typing those labels at the shell prompt is another story altogether, but at least they won't scoff at me as if I was a Linux hacker! Index: g_label.c =================================================================== RCS file: /repos/src/sys/geom/label/g_label.c,v retrieving revision 1.24.2.4 diff -c -r1.24.2.4 g_label.c *** g_label.c 22 Jun 2010 08:17:20 -0000 1.24.2.4 --- g_label.c 19 Aug 2010 11:27:13 -0000 *************** *** 136,141 **** --- 136,161 ---- return (1); } + static int sanitation_mask = 0; + SYSCTL_INT(_kern_geom_label, OID_AUTO, sanitation, CTLFLAG_RW, + &sanitation_mask, 0, + "Correction applied to labels. A bitmask of: 0 = none, 1 = replace '/'s, 2 = replace whitespace and ctrls, 4 = replace anything beyond '~'"); + + static void + sanitise_name (char *name) + { + unsigned char *p; + + for (p = name; *p; ++p) { + if ((sanitation_mask & 1) && *p == '/') + *p = '#'; + else if ((sanitation_mask & 2) && *p <= ' ') + *p = '_'; + else if ((sanitation_mask & 4) && *p > '~') + *p = '?'; + } + } + static struct g_geom * g_label_create(struct gctl_req *req, struct g_class *mp, struct g_provider *pp, const char *label, const char *dir, off_t mediasize) *************** *** 156,161 **** --- 176,182 ---- gp = NULL; cp = NULL; snprintf(name, sizeof(name), "%s/%s", dir, label); + sanitise_name(name + strlen(dir) + 1); LIST_FOREACH(gp, &mp->geom, geom) { pp2 = LIST_FIRST(&gp->provider); if (pp2 == NULL) -- walter pelissero http://www.pelissero.de From owner-freebsd-geom@FreeBSD.ORG Thu Aug 19 15:50:03 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F7751065698 for ; Thu, 19 Aug 2010 15:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6044F8FC0A for ; Thu, 19 Aug 2010 15:50:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7JFo39F090004 for ; Thu, 19 Aug 2010 15:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7JFo3sD090003; Thu, 19 Aug 2010 15:50:03 GMT (envelope-from gnats) Date: Thu, 19 Aug 2010 15:50:03 GMT Message-Id: <201008191550.o7JFo3sD090003@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: jhell Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: jhell List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2010 15:50:03 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: jhell To: Oliver Fromme Cc: bug-followup@freebsd.org Subject: Re: kern/149762: volume labels with rogue characters Date: Thu, 19 Aug 2010 11:42:32 -0400 On 08/19/2010 07:29, Oliver Fromme wrote: > jhell wrote: > > This is a hack, something that you would commonly find in Linux code and > > is neither a proper or viable workaround for the naming of labels. > > > > Instead, using glabel(8) the admin/user can create a local label to > > FreeBSD that does not change the original nor does it carry over to any > > other OS that does not understand geom_label's. > > There are cases were you cannot create a permanent label > with glabel. For example, there are quite a lot of USB > devices that insist on having their memory formatted with > their own firmware only, destroying any other labels. > I own an mp3 player (Medion) that behaves like this. > The submitter mentioned a digital camera (Nikon, I think) > in a previous thread. > > How do you suggest to solve the problem for those cases? > > > Stripping characters no matter what they are with a sysctl is overkill > > and does not scale well, all the while - presenting false information to > > the user. > > I don't think there is a scalability issue, because it is > only done once when a device is attached. On the other > hand, maybe the patch should be changed so it doesn't > touch the name at all when the sysctl is 0, so the default > behaviour would be no different from what we have today. If this is the case then why adapt geom_label at all ? why not instead go straight for the culprit "devfs/devd" and add a sysctl for stripping what needs to be stripped ?. This way it is distinct to /dev and can be done on the system-wide basis and/or focused on particular pieces of the system like geom_label. This is more of what I meant by scalable. > > > I would highly advise against this. If the user does not like > > the label that appears in msdosfs/{LABEL} then they are free to change > > that at their own will. > > Unfortunately they are subject to the will of their devices, > see above. And if the device's own label contains a space > (the Nikon camera mentioned above does), it cannot be used > as-is in /etc/fstab. That is understandable but to adjust the code to fit a few edge cases like this IMO just feels wrong, remember this is only my opinion in this case. > > I think a similar problem occurs with the volume names of > CD-ROMs and DVD-ROMs, which contain spaces quite often, > and you cannot glabel them. But I haven't looked deeply > into this, maybe it's not an issue. > > (Does FreeBSD even support mounting CDs by their volume > name, like Solaris does? I've never tried, but it would > come in handy, because I have a clip art CD that I use > every now and then, and I never remember whether it's in > drive cd0 or cd1 currently ...) Yes it does. I usually turn these off for client systems as I find them very unneeded and duplicate cases that can cause hell on hald(8). Design flaw of hald(8)? no but we introduced it. kern.geom.label.ext2fs.enable=0 kern.geom.label.iso9660.enable=0 kern.geom.label.msdosfs.enable=0 kern.geom.label.ntfs.enable=0 kern.geom.label.reiserfs.enable=0 kern.geom.label.ufs.enable=0 kern.geom.label.ufsid.enable=0 kern.geom.label.gptid.enable=0 kern.geom.label.gpt.enable=0 > > > I see presenting the label as it is to the user > > ``important''. > > Uhm ... it is not my impression that the names of nodes > in /dev are intended to present accurate "external" > information to the user. I always thought that the > purpose of /dev is an interface between userland software > and drivers, and that users shouldn't have to deal with > /dev at all during "normal operations". Am I wrong? No you are not wrong. But in the case of first introduction of the device and the use of fstab(5) being mentioned already, the user has to interact with /dev right ? > > I mean, there are commands to display the atual labels if > you need to see them (and I don't mean "ls /dev/..."). > Right I agree with this to an extent that the hypothetical user should not have to drop back to a manual page to find out how to get the original information of the device. Regards, -- jhell,v From owner-freebsd-geom@FreeBSD.ORG Thu Aug 19 16:40:08 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7C8E10656AC for ; Thu, 19 Aug 2010 16:40:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CD00F8FC18 for ; Thu, 19 Aug 2010 16:40:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7JGe2fv039149 for ; Thu, 19 Aug 2010 16:40:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7JGe2en039148; Thu, 19 Aug 2010 16:40:02 GMT (envelope-from gnats) Date: Thu, 19 Aug 2010 16:40:02 GMT Message-Id: <201008191640.o7JGe2en039148@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: jhell Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: jhell List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2010 16:40:09 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: jhell To: walter@pelissero.de Cc: freebsd-bugs@freebsd.org, bug-followup@freebsd.org Subject: Re: kern/149762: volume labels with rogue characters Date: Thu, 19 Aug 2010 12:35:59 -0400 On 08/19/2010 08:26, Walter C. Pelissero wrote: > jhell writes: > > This is a hack, something that you would commonly find in Linux > > code and is neither a proper or viable workaround for the naming of > > labels. > > That's exactly what I keep repeating my friends who run Linux and brag > about features they had first or better implemented. Just a bunch of > dirty hacks any kid would have whipped up in an afternoon if he just > had the fancy. Just hacks. > Putting aside whats written below, please don't feel that this is an attack on your work to make this happen. I feel your work is very viable for what it is supposed to do but to the same effect does not address the issue that this might happen elsewhere to anything new that may be introduced to the system at a later point in time which is why I call it a hack. In a previous post I mentioned a proper full term solution based on adjusting devfs/devd instead that would fit future situations and not call for individual adjustments for pieces of geom or anything related. > Unfortunately they answer using terms like: self-indulgent inertia, > inconclusive arrogance, bureaucratic attitude, self-important sloth, > pompous underachiever. Bloody Linux kids, aren't they? > > This might be an hack, but in 8 years since this issue has been first > raised nobody has came up with it, so I thought I might as well do > it. > It has be ~6 years that GEOM_LABEL was introduced to the system. r131476 | pjd | 2004-07-02 15:40:36 -0400 (Fri, 02 Jul 2004) | 22 lines Regards, -- jhell,v From owner-freebsd-geom@FreeBSD.ORG Fri Aug 20 10:10:04 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 13F9610656C0 for ; Fri, 20 Aug 2010 10:10:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 035FB8FC1B for ; Fri, 20 Aug 2010 10:10:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7KAA3xf089479 for ; Fri, 20 Aug 2010 10:10:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7KAA3a1089478; Fri, 20 Aug 2010 10:10:03 GMT (envelope-from gnats) Date: Fri, 20 Aug 2010 10:10:03 GMT Message-Id: <201008201010.o7KAA3a1089478@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: walter@pelissero.de (Walter C. Pelissero) Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Walter C. Pelissero" List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2010 10:10:04 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: walter@pelissero.de (Walter C. Pelissero) To: jhell Cc: freebsd-bugs@freebsd.org, bug-followup@freebsd.org Subject: Re: kern/149762: volume labels with rogue characters Date: Fri, 20 Aug 2010 11:58:12 +0200 jhell writes: > Putting aside whats written below, please don't feel that this is an > attack on your work to make this happen. Attack on my work? Amusing. > I feel your work is very viable for what it is supposed to do but > to the same effect does not address the issue that this might > happen elsewhere to anything new that may be introduced to the > system at a later point in time What don't you understand in: Now kern.geom.label.sanitation can be set to zero (default) obtaining the usual behaviour without "hack". > In a previous post I mentioned a proper full term solution based on > adjusting devfs/devd instead that would fit future situations and > not call for individual adjustments for pieces of geom or anything > related. I failed to see the devfs/devd solution you mention. > It has be ~6 years that GEOM_LABEL was introduced to the system. > r131476 | pjd | 2004-07-02 15:40:36 -0400 (Fri, 02 Jul 2004) | 22 lines conf/37569 Mon Apr 29 08:40:01 PDT 2002 The common issue of all the already mentioned PRs is: mounting volumes with names that are not compatible with fstab (and a lot of other things). Which this modification of geom_label could mitigate. There is a related PR of mine, which tackles the problem from the fstab stand point, that does more or less what the other PR has been already suggesting since 2002 and Linux has been doing for more than a decade. It was closed by a sulky baby boy on the same grounds as this. -- walter pelissero http://www.pelissero.de From owner-freebsd-geom@FreeBSD.ORG Fri Aug 20 13:20:05 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 77614106566B for ; Fri, 20 Aug 2010 13:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6741D8FC1F for ; Fri, 20 Aug 2010 13:20:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7KDK4pF078490 for ; Fri, 20 Aug 2010 13:20:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7KDK4ZL078489; Fri, 20 Aug 2010 13:20:04 GMT (envelope-from gnats) Date: Fri, 20 Aug 2010 13:20:04 GMT Message-Id: <201008201320.o7KDK4ZL078489@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: jhell Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: jhell List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2010 13:20:05 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: jhell To: walter@pelissero.de Cc: freebsd-bugs@freebsd.org, bug-followup@freebsd.org Subject: Re: kern/149762: volume labels with rogue characters Date: Fri, 20 Aug 2010 09:16:47 -0400 On 08/20/2010 05:58, Walter C. Pelissero wrote: > jhell writes: > > Putting aside whats written below, please don't feel that this is an > > attack on your work to make this happen. > > Attack on my work? > Amusing. > > > > I feel your work is very viable for what it is supposed to do but > > to the same effect does not address the issue that this might > > happen elsewhere to anything new that may be introduced to the > > system at a later point in time > > What don't you understand in: > Now kern.geom.label.sanitation can be set to zero (default) > obtaining the usual behaviour without "hack". I understand that completely still it is not a proper fix for the situation. > > > > In a previous post I mentioned a proper full term solution based on > > adjusting devfs/devd instead that would fit future situations and > > not call for individual adjustments for pieces of geom or anything > > related. > > I failed to see the devfs/devd solution you mention. I believe I meant patch devfs/devd here rather than adjust. Since were dealing with what shows up in the device file-system why not patch that instead of horrifying pieces of the system, one at a time. vfs.devfs.``normalization'' - Would probably suit this. I don't expect you to understand this... ;) > > > > It has be ~6 years that GEOM_LABEL was introduced to the system. > > r131476 | pjd | 2004-07-02 15:40:36 -0400 (Fri, 02 Jul 2004) | 22 lines > > conf/37569 > Mon Apr 29 08:40:01 PDT 2002 > > The common issue of all the already mentioned PRs is: mounting volumes > with names that are not compatible with fstab (and a lot of other > things). Which this modification of geom_label could mitigate. > > There is a related PR of mine, which tackles the problem from the > fstab stand point, that does more or less what the other PR has been > already suggesting since 2002 and Linux has been doing for more than a > decade. > > It was closed by a sulky baby boy on the same grounds as this. > Personally I have seen enough of the hash and bash coming from anyone here. Ive tried to make sure that what I have wrote back as a reply to your work was neither demeaning or intrusive but yet you continue to take the same negative standpoint with objection toward further ideas all the while holding an immature context with a submitter. Besides this! It is not really needed to adjust your personal system for the likes of some labels that may contain weird characters that conflict with how the system parses fstab(5). Simply by using the 'link' action in devfs.conf(5) you can create a link to a device auto-magically when the device is plugged in that would be available for use in fstab(5). link label/my?edgecase myedgecase2 link msdosfs/your?edgecase myedgecase3 This is only performed if the device appears. In fstab(5) /dev/myedgecase2 /headcase2 msdosfs rw,noauto 0 0 /dev/myedgecase3 /headcase3 msdosfs rw,noauto 0 0 Of course you can also adjust devd.conf(5) for example to perform specific actions upon device entry but Ill let you figure that out. Regards, -- jhell,v From owner-freebsd-geom@FreeBSD.ORG Fri Aug 20 21:00:12 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 24509106566B for ; Fri, 20 Aug 2010 21:00:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EE0498FC1C for ; Fri, 20 Aug 2010 21:00:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7KL0BKI025144 for ; Fri, 20 Aug 2010 21:00:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7KL0Bn8025138; Fri, 20 Aug 2010 21:00:11 GMT (envelope-from gnats) Date: Fri, 20 Aug 2010 21:00:11 GMT Message-Id: <201008202100.o7KL0Bn8025138@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: =?UTF-8?Q?Marcin_Wi=C5=9Bnicki?= Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: =?UTF-8?Q?Marcin_Wi=C5=9Bnicki?= List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2010 21:00:12 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: =?UTF-8?Q?Marcin_Wi=C5=9Bnicki?= To: bug-followup , walter Cc: Subject: Re: kern/149762: volume labels with rogue characters Date: Fri, 20 Aug 2010 22:57:07 +0200 How about using "percent encoding": http://en.wikipedia.org/wiki/Percent-encoding It is well known and solves all issues. From owner-freebsd-geom@FreeBSD.ORG Sat Aug 21 09:10:04 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7BAC1106566B for ; Sat, 21 Aug 2010 09:10:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6D7B18FC14 for ; Sat, 21 Aug 2010 09:10:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7L9A3IM069713 for ; Sat, 21 Aug 2010 09:10:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7L9A3LA069712; Sat, 21 Aug 2010 09:10:03 GMT (envelope-from gnats) Date: Sat, 21 Aug 2010 09:10:03 GMT Message-Id: <201008210910.o7L9A3LA069712@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: walter@pelissero.de (Walter C. Pelissero) Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Walter C. Pelissero" List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Aug 2010 09:10:04 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: walter@pelissero.de (Walter C. Pelissero) To: Marcin =?iso-8859-2?Q?Wi=B6nicki?= Cc: bug-followup Subject: Re: kern/149762: volume labels with rogue characters Date: Sat, 21 Aug 2010 01:08:44 +0200 Marcin Wi=B6nicki writes: > How about using "percent encoding": > http://en.wikipedia.org/wiki/Percent-encoding >=20 > It is well known and solves all issues. Which would have the advantage of being one byte more compact than the backslash-octal encoding. sanitise=5Fname performs a simple masking because the pathname built in= g=5Flabel=5Fcreate is limited to 64 chars, which I didn't know whether = it had some special meaning (on a second look, it seems as it didn't), and it looked rather tight for anything more elaborate. --=20 walter pelissero http://www.pelissero.de From owner-freebsd-geom@FreeBSD.ORG Sat Aug 21 11:48:35 2010 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C41C910656A4 for ; Sat, 21 Aug 2010 11:48:35 +0000 (UTC) (envelope-from zeus@ibs.dn.ua) Received: from ibs.dn.ua (ibs.dn.ua [91.216.196.30]) by mx1.freebsd.org (Postfix) with ESMTP id 2838B8FC08 for ; Sat, 21 Aug 2010 11:48:34 +0000 (UTC) Received: from ibs.dn.ua (localhost [127.0.0.1]) by ibs.dn.ua with ESMTP id o7LBYejb051784 for ; Sat, 21 Aug 2010 14:34:40 +0300 (EEST) Received: (from zeus@localhost) by ibs.dn.ua (8.14.4/8.14.4/Submit) id o7LBYeTe051783 for freebsd-geom@freebsd.org; Sat, 21 Aug 2010 14:34:40 +0300 (EEST) Date: Sat, 21 Aug 2010 14:34:40 +0300 From: Zeus V Panchenko To: freebsd-geom@freebsd.org Message-ID: <20100821113440.GB13028@ibs.dn.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 8.1-RELEASE X-Editor: GNU Emacs 23.2.1 Subject: syslog message "kernel: g_post_event_x(0x...)" ? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Aug 2010 11:48:35 -0000 Hi All, may somebody help me to understand the meaning of the messages in syslog i'm receiving? is it good or not? ... Aug 21 14:28:08 im kernel: g_post_event_x(0xc05afdd0, 0xc4554c80, 2, 262144) Aug 21 14:28:08 im kernel: g_post_event_x(0xc05afdd0, 0xc4554c80, 2, 262144) Aug 21 14:28:08 im kernel: g_post_event_x(0xc05afdd0, 0xc45cc560, 2, 262144) Aug 21 14:28:08 im kernel: g_post_event_x(0xc05afdd0, 0xc45cc760, 2, 262144) Aug 21 14:28:14 im kernel: g_post_event_x(0xc05afdd0, 0xc45cc7a0, 2, 262144) Aug 21 14:28:14 im kernel: g_post_event_x(0xc05afdd0, 0xc8792980, 2, 262144) Aug 21 14:28:14 im kernel: g_post_event_x(0xc05afdd0, 0xc4f6d2e0, 2, 262144) Aug 21 14:28:14 im kernel: g_post_event_x(0xc05afdd0, 0xc3f87ba0, 2, 262144) ... i have: uname -a FreeBSD 8.1-PRERELEASE #0: Thu Jul 1 12:45:44 EEST 2010 # sysctl kern.geom.debugflags kern.geom.debugflags: 17 # gmirror list Geom name: gm0 State: COMPLETE Components: 2 Balance: round-robin Slice: 4096 Flags: NONE GenID: 0 SyncID: 1 ID: 1882695400 Providers: 1. Name: mirror/gm0 Mediasize: 320072932864 (298G) Sectorsize: 512 Mode: r4w4e11 Consumers: 1. Name: ada0 Mediasize: 320072933376 (298G) Sectorsize: 512 Mode: r1w1e1 State: ACTIVE Priority: 0 Flags: DIRTY GenID: 0 SyncID: 1 ID: 1125460738 2. Name: ada1 Mediasize: 320072933376 (298G) Sectorsize: 512 Mode: r1w1e1 State: ACTIVE Priority: 0 Flags: DIRTY GenID: 0 SyncID: 1 ID: 541563348 thanks in advance -- Zeus V. Panchenko IT Dpt., IBS ltd GMT+2 (EET)