From owner-freebsd-hackers@FreeBSD.ORG  Sun Apr 11 08:36:20 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CCD4E106564A;
	Sun, 11 Apr 2010 08:36:20 +0000 (UTC)
	(envelope-from uqs@spoerlein.net)
Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2001:470:9a47::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 87AA38FC12;
	Sun, 11 Apr 2010 08:36:20 +0000 (UTC)
Received: from acme.spoerlein.net (localhost.spoerlein.net [IPv6:::1])
	by acme.spoerlein.net (Postfix) with ESMTPS id C0B435C59;
	Sun, 11 Apr 2010 10:36:19 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net;
	s=dkim200908; t=1270974979;
	bh=94OmU0a0wHfv+irZ7HPSwj0t93YMKKl3XBwsr0gWXG8=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	Content-Type:In-Reply-To;
	b=qwkvigfVq4bRdrZbUdU8la6xFRugKQFj0rw9iYO51/gmdvWmNlcaDfUGLHaAJqJ4q
	bd6X7D/ego1tX6zXZnirLbXXyKF23DWVhlp7DpWG6D+MNsZeCwgEph1PAsomfM9CGU
	pbjehxik2Gm5a2WGf9B9W/qXlUyCkVwk1u0fbnOk=
Received: (from uqs@localhost)
	by acme.spoerlein.net (8.14.4/8.14.4/Submit) id o3B8aJQS057712;
	Sun, 11 Apr 2010 10:36:19 +0200 (CEST)
	(envelope-from uqs@spoerlein.net)
Date: Sun, 11 Apr 2010 10:36:19 +0200
From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@spoerlein.net>
To: Andriy Gapon <avg@icyb.net.ua>
Message-ID: <20100411083618.GA57638@acme.spoerlein.net>
Mail-Followup-To: Andriy Gapon <avg@icyb.net.ua>,
	Pavel Sukhoy <sukhoy@ripn.net>, freebsd-scsi@freebsd.org,
	freebsd-hackers@freebsd.org, Markus Wild <m.wild@cybernet.ch>,
	Hans Petter Selasky <hselasky@c2i.net>
References: <903d65bf1d5624b5208c588b21e679ea@ripn.net>
	<4BBCFE30.2010709@icyb.net.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BBCFE30.2010709@icyb.net.ua>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: freebsd-scsi@freebsd.org, Pavel Sukhoy <sukhoy@ripn.net>,
	Hans Petter Selasky <hselasky@c2i.net>,
	Markus Wild <m.wild@cybernet.ch>, freebsd-hackers@freebsd.org
Subject: Re: virtual drive errors
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2010 08:36:20 -0000

On Thu, 08.04.2010 at 00:50:40 +0300, Andriy Gapon wrote:
> Looking at cdcheckmedia and at the logged READ TOC (0x43) SCSI command errors
> (as reported by Markus) I see the following problem.  Even if cdsize() call at
> the beginning of cdcheckmedia() succeeds, a subsequent failure of cdreadtoc()
> throws us to 'bailout' label which is past the code that sets d_mediasize.
> 
> I think that the following patch should help with this situation (and possibly
> other cases with READ TOC problems):
> 
> --- a/sys/cam/scsi/scsi_cd.c
> +++ b/sys/cam/scsi/scsi_cd.c
>[snip]

This patch, much like the one in kern/138789 makes my external Plextor
PX-755A drive successfully read "mastered" DVD media, i.e., the retail
kind, not DVD-R/RW.

So, please commit some version of this patch. Thanks!

Regards,
Uli