From owner-freebsd-i18n@FreeBSD.ORG Tue Aug 31 22:13:56 2010 Return-Path: Delivered-To: i18n@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 26B7F106564A for ; Tue, 31 Aug 2010 22:13:56 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id C8EC78FC16 for ; Tue, 31 Aug 2010 22:13:55 +0000 (UTC) Received: by qwg5 with SMTP id 5so11905qwg.13 for ; Tue, 31 Aug 2010 15:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=Y2fxI2xSlTptpi47ICsqlzj4lG/9kkzrVS9DQuXcC/o=; b=Us33Pg8sMrj/ckpY3no9kt7YMXb82jO89Uim26y/yZF65vRKFpBF+rBob9dd7FQFNw 3o2qur9q04wHuX6/lbctXmi6FzsNXFe/iNzXSMmpRi70d1BI/CjgZdFddJSZsVw5/7Tv 1elrMujyYVsz+ZExBG47D47dvwSF0vo19MOis= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=L1VnShmLPgLbmDueWhQFeeJk37gPX9NCLKpz90T7XC9fEyd5Y2Wer0UMpl9nsnH5G2 IdHYueb0mjxWI//ufyKN5HUrwXmR+QQcrSAMc4Nlxq20lrpY1VvU2elAR1FJ96tZ18KY CPj2vYJP9APwG0De/JgIcxzV+tRpvW1+jG8QA= Received: by 10.229.182.82 with SMTP id cb18mr4083625qcb.197.1283291161652; Tue, 31 Aug 2010 14:46:01 -0700 (PDT) Received: from localhost ([85.17.254.135]) by mx.google.com with ESMTPS id r36sm10219742qcs.27.2010.08.31.14.45.58 (version=SSLv3 cipher=RC4-MD5); Tue, 31 Aug 2010 14:46:00 -0700 (PDT) From: Anonymous To: Jilles Tjoelker References: <4C16C5B5.1070308@FreeBSD.org> <20100616190416.GA3896@a91-153-117-195.elisa-laajakaista.fi> <20100616200935.GA26321@stack.nl> Date: Wed, 01 Sep 2010 01:39:35 +0400 In-Reply-To: <20100616200935.GA26321@stack.nl> (Jilles Tjoelker's message of "Wed, 16 Jun 2010 22:09:36 +0200") Message-ID: <86aao21my0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jaakko Heinonen , FreeBSD Current , Gabor Kovesdan , i18n@FreeBSD.org Subject: Re: [CFT] BSDL iconv in base system X-BeenThere: freebsd-i18n@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD Internationalization Effort List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2010 22:13:56 -0000 Jilles Tjoelker writes: > On Wed, Jun 16, 2010 at 10:04:16PM +0300, Jaakko Heinonen wrote: >> On 2010-06-15, Gabor Kovesdan wrote: >> > - The iconv.h header files is supposed to be compatible with the GNU >> > version, i.e. sources should build with base iconv.h and GNU libiconv. >> > I've just did a very quick test and it seems ports can safely link to >> > GNU libiconv, there's no conflict. > >> > The rather big patch (42,5M) is available here: >> > http://www.kovesdan.org/patches/iconv_base_integrate.diff > >> iconv(3) prototype doesn't conform to POSIX.1-2008. Is it a >> well-considered decision? > > I think the difference from POSIX.1-2008 is pretty common and may > therefore cause less compilation problems. NetBSD's Citrus iconv and GNU > iconv have the extra 'const', and so does the default Solaris iconv GNU iconv doesn't use `const' by default. Our port adds it explicitly. CONFIGURE_ENV= gl_cv_cc_visibility="no" \ am_cv_func_iconv="yes" \ am_cv_proto_iconv_arg1="const" For example, devel/git refers to `const' using OLD_ICONV macro. BTW, iconv() on DragonFlyBSD doesn't seem to have `const', too. > (Solaris has a separate iconv for standards-conforming applications with > the POSIX prototype.)