From owner-freebsd-ipfw@FreeBSD.ORG Mon Mar 22 11:07:05 2010 Return-Path: Delivered-To: freebsd-ipfw@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE34A106566B for ; Mon, 22 Mar 2010 11:07:05 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A2C938FC1A for ; Mon, 22 Mar 2010 11:07:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2MB75AR015073 for ; Mon, 22 Mar 2010 11:07:05 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2MB75a1015071 for freebsd-ipfw@FreeBSD.org; Mon, 22 Mar 2010 11:07:05 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 22 Mar 2010 11:07:05 GMT Message-Id: <201003221107.o2MB75a1015071@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-ipfw@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-ipfw@FreeBSD.org X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2010 11:07:05 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/144869 ipfw [ipfw] [panic] Instant kernel panic when adding NAT ru o kern/144269 ipfw [ipfw] problem with ipfw tables o kern/144187 ipfw [ipfw] deadlock using multiple ipfw nat and multiple l o kern/143973 ipfw [ipfw] [panic] ipfw forward option causes kernel reboo o kern/143653 ipfw [ipfw] [patch] ipfw nat redirect_port "buf is too smal o kern/143621 ipfw [ipfw] [dummynet] [patch] dummynet and vnet use result o kern/143474 ipfw [ipfw] ipfw table contains the same address o kern/139581 ipfw [ipfw] "ipfw pipe" not limiting bandwidth o kern/139226 ipfw [ipfw] install_state: entry already present, done o kern/137346 ipfw [ipfw] ipfw nat redirect_proto is broken o kern/137232 ipfw [ipfw] parser troubles o kern/136695 ipfw [ipfw] [patch] fwd reached after skipto in dynamic rul o kern/135476 ipfw [ipfw] IPFW table breaks after adding a large number o o bin/134975 ipfw [patch] ipfw(8) can't work with set in rule file. o kern/132553 ipfw [ipfw] ipfw doesn't understand ftp-data port o kern/131817 ipfw [ipfw] blocks layer2 packets that should not be blocke o kern/131601 ipfw [ipfw] [panic] 7-STABLE panic in nat_finalise (tcp=0) o kern/131558 ipfw [ipfw] Inconsistent "via" ipfw behavior o bin/130132 ipfw [patch] ipfw(8): no way to get mask from ipfw pipe sho o kern/129103 ipfw [ipfw] IPFW check state does not work =( o kern/129093 ipfw [ipfw] ipfw nat must not drop packets o kern/129036 ipfw [ipfw] 'ipfw fwd' does not change outgoing interface n o kern/128260 ipfw [ipfw] [patch] ipfw_divert damages IPv6 packets o kern/127230 ipfw [ipfw] [patch] Feature request to add UID and/or GID l o kern/127209 ipfw [ipfw] IPFW table become corrupted after many changes o bin/125370 ipfw [ipfw] [patch] increase a line buffer limit o conf/123119 ipfw [patch] rc script for ipfw does not handle IPv6 o kern/122963 ipfw [ipfw] tcpdump does not show packets redirected by 'ip s kern/121807 ipfw [request] TCP and UDP port_table in ipfw o kern/121382 ipfw [dummynet]: 6.3-RELEASE-p1 page fault in dummynet (cor o kern/121122 ipfw [ipfw] [patch] add support to ToS IP PRECEDENCE fields o kern/118993 ipfw [ipfw] page fault - probably it's a locking problem o bin/117214 ipfw ipfw(8) fwd with IPv6 treats input as IPv4 o kern/116009 ipfw [ipfw] [patch] Ignore errors when loading ruleset from o docs/113803 ipfw [patch] ipfw(8) - don't get bitten by the fwd rule p kern/113388 ipfw [ipfw] [patch] Addition actions with rules within spec o kern/112561 ipfw [ipfw] ipfw fwd does not work with some TCP packets o kern/105330 ipfw [ipfw] [patch] ipfw (dummynet) does not allow to set q o bin/104921 ipfw [patch] ipfw(8) sometimes treats ipv6 input as ipv4 (a o kern/104682 ipfw [ipfw] [patch] Some minor language consistency fixes a o kern/103454 ipfw [ipfw] [patch] [request] add a facility to modify DF b o kern/103328 ipfw [ipfw] [request] sugestions about ipfw table o kern/102471 ipfw [ipfw] [patch] add tos and dscp support o kern/98831 ipfw [ipfw] ipfw has UDP hickups o kern/97951 ipfw [ipfw] [patch] ipfw does not tie interface details to o kern/97504 ipfw [ipfw] IPFW Rules bug o kern/95084 ipfw [ipfw] [regression] [patch] IPFW2 ignores "recv/xmit/v o kern/93300 ipfw [ipfw] ipfw pipe lost packets o kern/91847 ipfw [ipfw] ipfw with vlanX as the device o kern/88659 ipfw [modules] ipfw and ip6fw do not work properly as modul o kern/87032 ipfw [ipfw] [patch] ipfw ioctl interface implementation o kern/86957 ipfw [ipfw] [patch] ipfw mac logging o bin/83046 ipfw ipfw2 error: "setup" is allowed for icmp, but shouldn' o kern/82724 ipfw [ipfw] [patch] [request] Add setnexthop and defaultrou s kern/80642 ipfw [ipfw] [patch] ipfw small patch - new RULE OPTION o bin/78785 ipfw [patch] ipfw(8) verbosity locks machine if /etc/rc.fir o kern/74104 ipfw [ipfw] ipfw2/1 conflict not detected or reported, manp o kern/73910 ipfw [ipfw] serious bug on forwarding of packets after NAT o kern/72987 ipfw [ipfw] ipfw/dummynet pipe/queue 'queue [BYTES]KBytes ( o kern/71366 ipfw [ipfw] "ipfw fwd" sometimes rewrites destination mac a o kern/69963 ipfw [ipfw] install_state warning about already existing en o kern/60719 ipfw [ipfw] Headerless fragments generate cryptic error mes o kern/55984 ipfw [ipfw] [patch] time based firewalling support for ipfw o kern/51274 ipfw [ipfw] [patch] ipfw2 create dynamic rules with parent o kern/48172 ipfw [ipfw] [patch] ipfw does not log size and flags o kern/46159 ipfw [ipfw] [patch] [request] ipfw dynamic rules lifetime f a kern/26534 ipfw [ipfw] Add an option to ipfw to log gid/uid of who cau 67 problems total. From owner-freebsd-ipfw@FreeBSD.ORG Wed Mar 24 14:48:11 2010 Return-Path: Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC6281065673 for ; Wed, 24 Mar 2010 14:48:11 +0000 (UTC) (envelope-from alex@wittig.name) Received: from hotzenplotz.wittig.name (unknown [IPv6:2002:5b8f:51e8::1]) by mx1.freebsd.org (Postfix) with ESMTP id 85CA98FC15 for ; Wed, 24 Mar 2010 14:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=wittig.name; s=experimental; h=Sender:Content-Transfer-Encoding:Content-Type:Subject:To:MIME-Version:From:Date:Message-ID; bh=giftYOEEu5vJOINV7BLhXwe9ZyCcvURdYsYvFqlX/KE=; b=PACMwS2DuXQBJdAupbct/C66g2IgXXgGKoZ+0z+y4QXWA65P3zgy4u/DAgtO4uqT2MiJMNhEn/fBGFVSdrPJ3FoKdD5hLfI3eA98tnBTiEsKw6ropMrhAZmXP3Q63ME1ulWr1x5Rf7HGCy13yPMSP3LDBWSU9EzHosV/wSmNiCc=; Received: from prokofiev.bt.pa.msu.edu ([35.9.70.209] helo=Schneeweisschen-II.local) by hotzenplotz.wittig.name with esmtpsa (TLSv1:DHE-RSA-CAMELLIA256-SHA:256) (Exim 4.71 (FreeBSD)) (envelope-from ) id 1NuRsQ-0003JL-4A for freebsd-ipfw@freebsd.org; Wed, 24 Mar 2010 15:48:10 +0100 Message-ID: <4BAA2627.8080203@wittig.name> Date: Wed, 24 Mar 2010 10:48:07 -0400 From: Alexander Wittig User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; de; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: freebsd-ipfw@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: alex@wittig.name Subject: r205511 - ipfw.ko has unresolved symbols X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 14:48:11 -0000 Hello Since the r205511 commit to 8-Stable my kernel can't load ipfw.ko any more. The error message in dmsg is: kernel: link_elf_obj: symbol ipfw_dyn_attach undefined kernel: linker_load_file: Unsupported file type A quick Google search for the first line brings up this message from last December (http://www.mail-archive.com/freebsd-ipfw@freebsd.org/msg02276.html): > On Thu, Dec 17, 2009 at 12:31:32PM -0500, David Horn wrote: > > I am seeing a kldload failure for ipfw.ko after the latest -current commits > > (fails for r200580 - r200633 inclusive) for ipfw: > > > > link_elf_obj: symbol ipfw_dyn_attach undefined > > not surprising, as i forgot to put the new filenames in the Makefile > for the module, and buildworld does not (and cannot) complain about > unresolved symbols. > > Just committed a fix in r200636 > > thanks > luigi > Is it possible that there is the same issue with this commit? For reference: uname -a FreeBSD hotzenplotz.wittig.name 8.0-STABLE FreeBSD 8.0-STABLE #0: Wed Mar 24 14:36:45 CET 2010 root@hotzenplotz.wittig.name:/usr/obj/usr/src/sys/ALEX amd64 If I compile IPFW into the kernel everything works fine. Thanks, Alexander (please CC me in replies as I'm not on freebsd-ipfw@) From owner-freebsd-ipfw@FreeBSD.ORG Wed Mar 24 15:08:37 2010 Return-Path: Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 66BFD1065670 for ; Wed, 24 Mar 2010 15:08:37 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id 2CF718FC14 for ; Wed, 24 Mar 2010 15:08:36 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id C02F9730A1; Wed, 24 Mar 2010 16:18:31 +0100 (CET) Date: Wed, 24 Mar 2010 16:18:31 +0100 From: Luigi Rizzo To: Alexander Wittig Message-ID: <20100324151831.GB28594@onelab2.iet.unipi.it> References: <4BAA2627.8080203@wittig.name> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BAA2627.8080203@wittig.name> User-Agent: Mutt/1.4.2.3i Cc: freebsd-ipfw@freebsd.org Subject: Re: r205511 - ipfw.ko has unresolved symbols X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 15:08:37 -0000 On Wed, Mar 24, 2010 at 10:48:07AM -0400, Alexander Wittig wrote: > Hello > > Since the r205511 commit to 8-Stable my kernel can't load ipfw.ko any > more. The error message in dmsg is: > > kernel: link_elf_obj: symbol ipfw_dyn_attach undefined > kernel: linker_load_file: Unsupported file type > > A quick Google search for the first line brings up this message from > last December > (http://www.mail-archive.com/freebsd-ipfw@freebsd.org/msg02276.html): > > >On Thu, Dec 17, 2009 at 12:31:32PM -0500, David Horn wrote: > >> I am seeing a kldload failure for ipfw.ko after the latest -current > >commits > >> (fails for r200580 - r200633 inclusive) for ipfw: > >> > >> link_elf_obj: symbol ipfw_dyn_attach undefined > > > >not surprising, as i forgot to put the new filenames in the Makefile > >for the module, and buildworld does not (and cannot) complain about > >unresolved symbols. > > > >Just committed a fix in r200636 > > > >thanks > >luigi > > > > Is it possible that there is the same issue with this commit? definitely yes. thanks for the reminder. cheers luigi From owner-freebsd-ipfw@FreeBSD.ORG Wed Mar 24 22:05:14 2010 Return-Path: Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9D5731065674 for ; Wed, 24 Mar 2010 22:05:14 +0000 (UTC) (envelope-from freebsd-ipfw@m.gmane.org) Received: from lo.gmane.org (lo.gmane.org [80.91.229.12]) by mx1.freebsd.org (Postfix) with ESMTP id 5ABC88FC19 for ; Wed, 24 Mar 2010 22:05:14 +0000 (UTC) Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NuYSi-0002LM-Eo for freebsd-ipfw@freebsd.org; Wed, 24 Mar 2010 22:50:04 +0100 Received: from static-78-8-147-77.ssp.dialog.net.pl ([78.8.147.77]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 24 Mar 2010 22:50:04 +0100 Received: from mwisnicki+freebsd by static-78-8-147-77.ssp.dialog.net.pl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 24 Mar 2010 22:50:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-ipfw@freebsd.org From: Marcin Wisnicki Date: Wed, 24 Mar 2010 21:38:11 +0000 (UTC) Lines: 20 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: static-78-8-147-77.ssp.dialog.net.pl User-Agent: Pan/0.132 (Waxed in Black) Subject: ipfw: missing action X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 22:05:14 -0000 Another victim of recent MFC: # ipfw -n add 00100 set 2 allow all from any to any via lo0 ipfw: missing action Bug also exists on head. Someone should add "write IPFW testsuite" to FreeBSD project ideas ;) diff -ruN /usr/src/sbin/ipfw/ipfw2.c /home/marcin/p/bugfix/ipfw/ipfw2.c --- /usr/src/sbin/ipfw/ipfw2.c 2010-03-24 04:19:34.000000000 +0100 +++ /home/marcin/p/bugfix/ipfw/ipfw2.c 2010-03-24 22:07:33.000000000 +0100 @@ -2656,7 +2656,7 @@ } /* [set N] -- set number (0..RESVD_SET), optional */ - if (av[0] && !av[1] && _substrcmp(*av, "set") == 0) { + if (av[0] && av[1] && _substrcmp(*av, "set") == 0) { int set = strtoul(av[1], NULL, 10); if (set < 0 || set > RESVD_SET) errx(EX_DATAERR, "illegal set %s", av[1]); From owner-freebsd-ipfw@FreeBSD.ORG Wed Mar 24 22:52:11 2010 Return-Path: Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3BE21065670 for ; Wed, 24 Mar 2010 22:52:10 +0000 (UTC) (envelope-from kudzu@tenebras.com) Received: from mail-qy0-f200.google.com (mail-qy0-f200.google.com [209.85.221.200]) by mx1.freebsd.org (Postfix) with ESMTP id A3A648FC16 for ; Wed, 24 Mar 2010 22:52:10 +0000 (UTC) Received: by qyk38 with SMTP id 38so927090qyk.9 for ; Wed, 24 Mar 2010 15:52:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.219.143 with SMTP id hu15mr3863182qcb.12.1269469360242; Wed, 24 Mar 2010 15:22:40 -0700 (PDT) In-Reply-To: References: Date: Wed, 24 Mar 2010 15:22:40 -0700 Message-ID: <813887681003241522r3e124c43m2c0dd2a3d280da08@mail.gmail.com> From: Michael Sierchio To: Marcin Wisnicki Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-ipfw@freebsd.org Subject: Re: ipfw: missing action X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 22:52:11 -0000 I'm really distressed about the state of ipfw development. Is there no test harness? Rather than becoming more mature and stable, I think it's in the weeds these days. - M On Wed, Mar 24, 2010 at 2:38 PM, Marcin Wisnicki < mwisnicki+freebsd@gmail.com > wrote: > Another victim of recent MFC: > > # ipfw -n add 00100 set 2 allow all from any to any via lo0 > ipfw: missing action > > Bug also exists on head. > Someone should add "write IPFW testsuite" to FreeBSD project ideas ;) > > diff -ruN /usr/src/sbin/ipfw/ipfw2.c /home/marcin/p/bugfix/ipfw/ipfw2.c > --- /usr/src/sbin/ipfw/ipfw2.c 2010-03-24 04:19:34.000000000 +0100 > +++ /home/marcin/p/bugfix/ipfw/ipfw2.c 2010-03-24 22:07:33.000000000 +0100 > @@ -2656,7 +2656,7 @@ > } > > /* [set N] -- set number (0..RESVD_SET), optional */ > - if (av[0] && !av[1] && _substrcmp(*av, "set") == 0) { > + if (av[0] && av[1] && _substrcmp(*av, "set") == 0) { > int set = strtoul(av[1], NULL, 10); > if (set < 0 || set > RESVD_SET) > errx(EX_DATAERR, "illegal set %s", av[1]); > > _______________________________________________ > freebsd-ipfw@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw > To unsubscribe, send any mail to "freebsd-ipfw-unsubscribe@freebsd.org" > From owner-freebsd-ipfw@FreeBSD.ORG Wed Mar 24 23:21:03 2010 Return-Path: Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3418F106566B for ; Wed, 24 Mar 2010 23:21:03 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id EE26C8FC1D for ; Wed, 24 Mar 2010 23:21:02 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 61D00730A1; Thu, 25 Mar 2010 00:30:55 +0100 (CET) Date: Thu, 25 Mar 2010 00:30:55 +0100 From: Luigi Rizzo To: Michael Sierchio Message-ID: <20100324233055.GC37533@onelab2.iet.unipi.it> References: <813887681003241522r3e124c43m2c0dd2a3d280da08@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <813887681003241522r3e124c43m2c0dd2a3d280da08@mail.gmail.com> User-Agent: Mutt/1.4.2.3i Cc: freebsd-ipfw@freebsd.org, Marcin Wisnicki Subject: Re: ipfw: missing action X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2010 23:21:03 -0000 On Wed, Mar 24, 2010 at 03:22:40PM -0700, Michael Sierchio wrote: > I'm really distressed about the state of ipfw development. Is there no test > harness? Rather than becoming more mature and stable, I think it's in the > weeds these days. Yeah, really disgusting :) I am sorry, there is no comprehensive test harness. Various parts of this code have been in HEAD for 1 to 3 months, and i got 0 reports there. Within two days of the merge we got reports for 3 (trivial) bugs, which were fixed in a matter of hours. I'd love if all of our bugs were like this. cheers luigi > - M > > On Wed, Mar 24, 2010 at 2:38 PM, Marcin Wisnicki < > mwisnicki+freebsd@gmail.com > wrote: > > > Another victim of recent MFC: > > > > # ipfw -n add 00100 set 2 allow all from any to any via lo0 > > ipfw: missing action > > > > Bug also exists on head. > > Someone should add "write IPFW testsuite" to FreeBSD project ideas ;) > > > > diff -ruN /usr/src/sbin/ipfw/ipfw2.c /home/marcin/p/bugfix/ipfw/ipfw2.c > > --- /usr/src/sbin/ipfw/ipfw2.c 2010-03-24 04:19:34.000000000 +0100 > > +++ /home/marcin/p/bugfix/ipfw/ipfw2.c 2010-03-24 22:07:33.000000000 +0100 > > @@ -2656,7 +2656,7 @@ > > } > > > > /* [set N] -- set number (0..RESVD_SET), optional */ > > - if (av[0] && !av[1] && _substrcmp(*av, "set") == 0) { > > + if (av[0] && av[1] && _substrcmp(*av, "set") == 0) { > > int set = strtoul(av[1], NULL, 10); > > if (set < 0 || set > RESVD_SET) > > errx(EX_DATAERR, "illegal set %s", av[1]); > > > > _______________________________________________ > > freebsd-ipfw@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw > > To unsubscribe, send any mail to "freebsd-ipfw-unsubscribe@freebsd.org" > > > _______________________________________________ > freebsd-ipfw@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw > To unsubscribe, send any mail to "freebsd-ipfw-unsubscribe@freebsd.org" From owner-freebsd-ipfw@FreeBSD.ORG Thu Mar 25 18:00:36 2010 Return-Path: Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CBF89106564A for ; Thu, 25 Mar 2010 18:00:36 +0000 (UTC) (envelope-from milhorini@hardonline.com.br) Received: from roma.hardonline.com.br (roma.hardonline.com.br [189.126.224.4]) by mx1.freebsd.org (Postfix) with ESMTP id E434F8FC15 for ; Thu, 25 Mar 2010 18:00:35 +0000 (UTC) Received: (qmail 39022 invoked by uid 98); 25 Mar 2010 15:00:36 -0300 Received: from 189.126.225.194 by roma.hardonline.com.br (envelope-from , uid 82) with qmail-scanner-1.25 (clamdscan: 0.88.4/1726. spamassassin: 3.1.4. Clear:RC:1(189.126.225.194):. Processed in 0.04407 secs); 25 Mar 2010 18:00:36 -0000 X-Qmail-Scanner-Mail-From: milhorini@hardonline.com.br via roma.hardonline.com.br X-Qmail-Scanner: 1.25 (Clear:RC:1(189.126.225.194):. Processed in 0.04407 secs) Received: from unknown (HELO ?192.168.0.3?) (adailton@hardonline.com.br@189.126.225.194) by roma.hardonline.com.br with ESMTPA; 25 Mar 2010 15:00:36 -0300 Message-ID: <4BABA4A1.9040307@hardonline.com.br> Date: Thu, 25 Mar 2010 15:00:01 -0300 From: Adailton Milhorini User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; pt-BR; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: freebsd-ipfw@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: dummynet error in last stable version X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2010 18:00:36 -0000 Hi, i use this rules for my bandwidth control, and after update my freebsd in last days, show any error for me.. my rule # ipfw pipe 10 config mask dst-ip 0xffffffff bw 900Kbit/s queue 90Kbit/s errors in dmesg after rule #Bump sched buckets to 64 (was 0) and after traffic show #dummynet_io dropped by enqueue these rules were used up last week.. Adailton Milhorini From owner-freebsd-ipfw@FreeBSD.ORG Fri Mar 26 10:06:59 2010 Return-Path: Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE4CC1065679 for ; Fri, 26 Mar 2010 10:06:59 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id B3DD28FC27 for ; Fri, 26 Mar 2010 10:06:59 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 51AC3730A1; Fri, 26 Mar 2010 11:16:57 +0100 (CET) Date: Fri, 26 Mar 2010 11:16:57 +0100 From: Luigi Rizzo To: Adailton Milhorini Message-ID: <20100326101657.GA59512@onelab2.iet.unipi.it> References: <4BABA4A1.9040307@hardonline.com.br> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BABA4A1.9040307@hardonline.com.br> User-Agent: Mutt/1.4.2.3i Cc: freebsd-ipfw@freebsd.org Subject: Re: dummynet error in last stable version X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2010 10:07:00 -0000 On Thu, Mar 25, 2010 at 03:00:01PM -0300, Adailton Milhorini wrote: > Hi, > > i use this rules for my bandwidth control, and after update my freebsd > in last days, show any error for me.. > my rule > > # ipfw pipe 10 config mask dst-ip 0xffffffff bw 900Kbit/s queue 90Kbit/s > > errors in dmesg after rule > > #Bump sched buckets to 64 (was 0) > > and after traffic show > > #dummynet_io dropped by enqueue > Thanks for the report. the dmesg output are only diagnostics, they should be removed but do not indicate any error. your configuration command is incorrect though, "queue 90Kbit/s" as queue size can be expressed only in slots or in bytes. The parser is sloppy and ignores everything after the 'K' so it understand it as 90Kbytes, but you should not count on that cheers luigi