From owner-freebsd-mips@FreeBSD.ORG Sun Sep 12 11:20:55 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E76D106566B for ; Sun, 12 Sep 2010 11:20:55 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id B12C48FC13 for ; Sun, 12 Sep 2010 11:20:54 +0000 (UTC) Received: by wyb33 with SMTP id 33so5817781wyb.13 for ; Sun, 12 Sep 2010 04:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=X4LxceV1Mra9bLW35lBPjLqLYE8vf27AoA9nFHhuLRQ=; b=nRw+4thfTCPv1O1btO2KrZJy1pUhJVYjmWO8wmanhlBcc0dohunizA7jSWObOWy5fx zoeAb8cScNwRd5Rjr/Cb/Ecr8Y+mJqtCTyAQSoXCDb8r4byTjA6BP1Ftt5kfxGNIbdRn lB16/TpMip9pjOEg36ZSsnXx4BKVT8idtPvxE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=wQPgeZnrLgjiiVWZHTcEREsqaumddHG7hmDIEy7WAuVZIyZgced18ogQj2RkfQffdx YLsONjJ2mlLaKpEpfP4Hf/oDr/rCtG3upCXq5VlZ1gr7yUejlSvAlYkwPA1y9IRa2z+F kEMz3DQoIBySxyu4BDueAKkSSSBNPcmc3S3W8= MIME-Version: 1.0 Received: by 10.216.38.71 with SMTP id z49mr1387662wea.76.1284290453773; Sun, 12 Sep 2010 04:20:53 -0700 (PDT) Received: by 10.216.171.12 with HTTP; Sun, 12 Sep 2010 04:20:53 -0700 (PDT) Date: Sun, 12 Sep 2010 16:50:53 +0530 Message-ID: From: "Jayachandran C." To: freebsd-mips@freebsd.org Content-Type: multipart/mixed; boundary=0016364c7f13498f2704900e2c9d Subject: patch - remove psracccess.S X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2010 11:20:55 -0000 --0016364c7f13498f2704900e2c9d Content-Type: text/plain; charset=ISO-8859-1 The functions in sys/mips/mips/psraccess.S can be implemented with mips_rd_status/mips_wr_status. Here's patch that does that. If there are no objections, I will commit this some time tomorrow. JC. --0016364c7f13498f2704900e2c9d Content-Type: application/octet-stream; name="psraccess.patch" Content-Disposition: attachment; filename="psraccess.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gdztcu3h0 SW5kZXg6IHN5cy9jb25mL2ZpbGVzLm1pcHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2NvbmYvZmlsZXMu bWlwcwkocmV2aXNpb24gMjEyNDc1KQorKysgc3lzL2NvbmYvZmlsZXMubWlwcwkod29ya2luZyBj b3B5KQpAQCAtMjIsNyArMjIsNiBAQAogbWlwcy9taXBzL21hY2hkZXAuYwkJc3RhbmRhcmQKIG1p cHMvbWlwcy9tcF9tYWNoZGVwLmMJCW9wdGlvbmFsIHNtcAogbWlwcy9taXBzL21wYm9vdC5TCQlv cHRpb25hbCBzbXAKLW1pcHMvbWlwcy9wc3JhY2Nlc3MuUwkJc3RhbmRhcmQKICMgLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQogIyBQaGFzZSAzCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KSW5kZXg6IHN5cy9taXBzL2luY2x1ZGUv Y3B1ZnVuYy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9taXBzL2luY2x1ZGUvY3B1ZnVuYy5oCShyZXZp c2lvbiAyMTI0NzUpCisrKyBzeXMvbWlwcy9pbmNsdWRlL2NwdWZ1bmMuaAkod29ya2luZyBjb3B5 KQpAQCAtMjY2LDYgKzI2NiwyNCBAQAogCX0KIH0KIAorc3RhdGljIF9faW5saW5lIHVpbnQzMl90 CitzZXRfaW50cl9tYXNrKHVpbnQzMl90IG1hc2spCit7CisJdWludDMyX3Qgb3N0YXR1czsKKwor CW9zdGF0dXMgPSBtaXBzX3JkX3N0YXR1cygpOworCW1hc2sgPSAob3N0YXR1cyAmIH5NSVBTX1NS X0lOVF9NQVNLKSB8ICh+bWFzayAmIE1JUFNfU1JfSU5UX01BU0spOworCW1pcHNfd3Jfc3RhdHVz KG1hc2spOworCXJldHVybiAob3N0YXR1cyk7Cit9CisKK3N0YXRpYyBfX2lubGluZSB1aW50MzJf dAorZ2V0X2ludHJfbWFzayh2b2lkKQoreworCisJcmV0dXJuIChtaXBzX3JkX3N0YXR1cygpICYg TUlQU19TUl9JTlRfTUFTSyk7Cit9CisKIHN0YXRpYyBfX2lubGluZSB2b2lkCiBicmVha3BvaW50 KHZvaWQpCiB7CkluZGV4OiBzeXMvbWlwcy9pbmNsdWRlL21kX3Zhci5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IHN5cy9taXBzL2luY2x1ZGUvbWRfdmFyLmgJKHJldmlzaW9uIDIxMjQ3NSkKKysrIHN5cy9taXBz L2luY2x1ZGUvbWRfdmFyLmgJKHdvcmtpbmcgY29weSkKQEAgLTc1LDkgKzc1LDUgQEAKIHZvaWQJ cGxhdGZvcm1faWRlbnRpZnkodm9pZCk7CiAKIGV4dGVybiBpbnQgYnVzZG1hX3N3aV9wZW5kaW5n Owotdm9pZCBidXNkbWFfc3dpKHZvaWQpOwotCi11X2ludDMyX3Qgc2V0X2ludHJfbWFzayh1X2lu dDMyX3QpOwotdV9pbnQzMl90IGdldF9pbnRyX21hc2sodm9pZCk7Ci0KK3ZvaWQJYnVzZG1hX3N3 aSh2b2lkKTsKICNlbmRpZiAvKiAhX01BQ0hJTkVfTURfVkFSX0hfICovCkluZGV4OiBzeXMvbWlw cy9taXBzL3BzcmFjY2Vzcy5TCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9taXBzL21pcHMvcHNyYWNjZXNz LlMJKHJldmlzaW9uIDIxMjQ3NSkKKysrIHN5cy9taXBzL21pcHMvcHNyYWNjZXNzLlMJKHdvcmtp bmcgY29weSkKQEAgLTEsODEgKzAsMCBAQAotLyoJJE9wZW5CU0QkICovCi0vKgotICogQ29weXJp Z2h0IChjKSAyMDAxIE9wc3ljb24gQUIgICh3d3cub3BzeWNvbi5zZSAvIHd3dy5vcHN5Y29uLmNv bSkKLSAqCi0gKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZv cm1zLCB3aXRoIG9yIHdpdGhvdXQKLSAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92 aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwotICogYXJlIG1ldDoKLSAqIDEuIFJl ZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJp Z2h0Ci0gKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93 aW5nIGRpc2NsYWltZXIuCi0gKiAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVz dCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAotICogICAgbm90aWNlLCB0aGlzIGxpc3Qg b2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQotICogICAg ZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRp c3RyaWJ1dGlvbi4KLSAqIDMuIEFsbCBhZHZlcnRpc2luZyBtYXRlcmlhbHMgbWVudGlvbmluZyBm ZWF0dXJlcyBvciB1c2Ugb2YgdGhpcyBzb2Z0d2FyZQotICogICAgbXVzdCBkaXNwbGF5IHRoZSBm b2xsb3dpbmcgYWNrbm93bGVkZ2VtZW50OgotICoJVGhpcyBwcm9kdWN0IGluY2x1ZGVzIHNvZnR3 YXJlIGRldmVsb3BlZCBieSBPcHN5Y29uIEFCLCBTd2VkZW4uCi0gKiA0LiBUaGUgbmFtZSBvZiB0 aGUgYXV0aG9yIG1heSBub3QgYmUgdXNlZCB0byBlbmRvcnNlIG9yIHByb21vdGUgcHJvZHVjdHMK LSAqICAgIGRlcml2ZWQgZnJvbSB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Ig d3JpdHRlbiBwZXJtaXNzaW9uLgotICoKLSAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkg VEhFIEFVVEhPUiBgYEFTIElTJycgQU5EIEFOWSBFWFBSRVNTCi0gKiBPUiBJTVBMSUVEIFdBUlJB TlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAotICogV0FS UkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQ VVJQT1NFCi0gKiBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBBVVRIT1Ig QkUgTElBQkxFIEZPUiBBTlkKLSAqIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJ QUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTAotICogREFNQUdFUyAoSU5DTFVESU5HLCBC VVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMKLSAqIE9S IFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5U RVJSVVBUSU9OKQotICogSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklM SVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QKLSAqIExJQUJJTElUWSwgT1IgVE9SVCAo SU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkKLSAq IE9VVCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUg UE9TU0lCSUxJVFkgT0YKLSAqIFNVQ0ggREFNQUdFLgotICoKLSAqCUpOUFI6IHBzcmFjY2Vzcy5T LHYgMS40LjIuMSAyMDA3LzA5LzEwIDEwOjM2OjUwIGdpcmlzaAotICogJEZyZWVCU0QkCi0gKgot ICovCi0KLS8qCi0gKiAgTG93IGxldmVsIGNvZGUgdG8gbWFuYWdlIHByb2Nlc3NvciBzcGVjaWZp YyByZWdpc3RlcnMuCi0gKi8KLQotI2luY2x1ZGUgPG1hY2hpbmUvYXNtLmg+Ci0jaW5jbHVkZSA8 bWFjaGluZS9jcHVyZWdzLmg+Ci0jaW5jbHVkZSA8bWFjaGluZS9yZWdudW0uaD4KLQotI2luY2x1 ZGUgIm9wdF9jcHV0eXBlLmgiCi0KLSNpbmNsdWRlICJhc3N5bS5zIgotCi0vKgotICogRlJFRUJT RF9ERVZFTE9QRVJTX0ZJWE1FCi0gKiBTb21lIE1JUFMgQ1BVIG1heSBuZWVkIGRlbGF5cyB1c2lu ZyBub3BzIGJldHdlZW4gZXhlY3V0aW5nIENQMCBJbnN0cnVjdGlvbnMKLSAqLwotI2RlZmluZQlN SVBTX0NQVV9OT1BfREVMQVkJbm9wO25vcDtub3A7bm9wO25vcDtub3A7bm9wO25vcDtub3A7bm9w OwotCi0JLnNldAlub3Jlb3JkZXIJCSMgTm9yZW9yZGVyIGlzIGRlZmF1bHQgc3R5bGUhCi0KLUxF QUYoc2V0X2ludHJfbWFzaykKLQlsaQl0MCwgTUlQU19TUl9JTlRfTUFTSwkjIDEgbWVhbnMgbWFz a2VkIHNvIGludmVydC4KLQlub3QJYTAsIGEwCQkJIyAxIG1lYW5zIG1hc2tlZCBzbyBpbnZlcnQu Ci0JYW5kCWEwLCB0MAkJCSMgMSBtZWFucyBtYXNrZWQgc28gaW52ZXJ0LgotCW1mYzAJdjAsIE1J UFNfQ09QXzBfU1RBVFVTCi0JbGkJdjEsIH5NSVBTX1NSX0lOVF9NQVNLCi0JYW5kCXYxLCB2MAot CW9yCXYxLCBhMAotCW10YzAJdjEsIE1JUFNfQ09QXzBfU1RBVFVTCi0JTUlQU19DUFVfTk9QX0RF TEFZCi0JbW92ZQl2MCwgdjEKLQlqcglyYQotCW5vcAotCi1FTkQoc2V0X2ludHJfbWFzaykKLQot TEVBRihnZXRfaW50cl9tYXNrKQotCWxpCWEwLCAwCi0JbWZjMAl2MCwgTUlQU19DT1BfMF9TVEFU VVMKLQlsaQl2MSwgTUlQU19TUl9JTlRfTUFTSwotCWFuZAl2MCwgdjEKLQlvcgl2MCwgYTAKLQlq cglyYQotCW5vcAotCi1FTkQoZ2V0X2ludHJfbWFzaykK --0016364c7f13498f2704900e2c9d-- From owner-freebsd-mips@FreeBSD.ORG Sun Sep 12 16:28:45 2010 Return-Path: Delivered-To: freebsd-mips@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DE35F1065694 for ; Sun, 12 Sep 2010 16:28:45 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 88A678FC1F for ; Sun, 12 Sep 2010 16:28:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o8CGQdLq050055; Sun, 12 Sep 2010 10:26:39 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 12 Sep 2010 10:26:45 -0600 (MDT) Message-Id: <20100912.102645.1055929314662048689.imp@bsdimp.com> To: c.jayachandran@gmail.com From: "M. Warner Losh" In-Reply-To: References: X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-mips@FreeBSD.org Subject: Re: patch - remove psracccess.S X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2010 16:28:45 -0000 In message: "Jayachandran C." writes: : Index: sys/mips/include/md_var.h : =================================================================== : --- sys/mips/include/md_var.h (revision 212475) : +++ sys/mips/include/md_var.h (working copy) : @@ -75,9 +75,5 @@ : void platform_identify(void); : : extern int busdma_swi_pending; : -void busdma_swi(void); : - : -u_int32_t set_intr_mask(u_int32_t); : -u_int32_t get_intr_mask(void); : - : +void busdma_swi(void); : #endif /* !_MACHINE_MD_VAR_H_ */ This appears to be unrelated... Warner From owner-freebsd-mips@FreeBSD.ORG Sun Sep 12 17:15:37 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A67E9106564A for ; Sun, 12 Sep 2010 17:15:37 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3B2748FC1D for ; Sun, 12 Sep 2010 17:15:36 +0000 (UTC) Received: by wyb33 with SMTP id 33so6115824wyb.13 for ; Sun, 12 Sep 2010 10:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=wHGRQCN7rpsxVz39Q+Tlb2c7LSwoZpVHMe2OQuPfkKk=; b=vP4vmNhyq9+WaWPYoaY57Vw1JlYe9W0rzWTpa3FOMKk1gwfXyhM0IpCeqCHmJrlbj2 cMKBF8D1Zy5wSZj8FzSG3EXXYv09fQSn+4tPMseIcdm69XuBHf7PkyvrERnmWAlo+/mZ V8UedG6GhFS2/RYh5RAxcQJlrNbxfVTAezMtY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=tXn45TmoWnmmRWsoOS9T2LXjHd0IVLTI+GrJgL7Y1refhWhc3UNlSYFzBPLFIvERtS C/ZqmpVcsFxcLB5ujAZX3r4ggCq57UI4KjIy58rGXzbkC4kk9T+qxGNokoKNCKc3KLbF BcXUNyMFk3sEzpDoPHDHml3MxTxxY7LVsExos= MIME-Version: 1.0 Received: by 10.216.178.200 with SMTP id f50mr3354795wem.62.1284311736176; Sun, 12 Sep 2010 10:15:36 -0700 (PDT) Received: by 10.216.171.12 with HTTP; Sun, 12 Sep 2010 10:15:36 -0700 (PDT) In-Reply-To: <20100912.102645.1055929314662048689.imp@bsdimp.com> References: <20100912.102645.1055929314662048689.imp@bsdimp.com> Date: Sun, 12 Sep 2010 22:45:36 +0530 Message-ID: From: "Jayachandran C." To: "M. Warner Losh" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-mips@freebsd.org Subject: Re: patch - remove psracccess.S X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2010 17:15:37 -0000 On Sun, Sep 12, 2010 at 9:56 PM, M. Warner Losh wrote: > In message: > =A0 =A0 =A0 =A0 =A0 =A0"Jayachandran C." write= s: > : Index: sys/mips/include/md_var.h > : =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > : --- sys/mips/include/md_var.h (revision 212475) > : +++ sys/mips/include/md_var.h (working copy) > : @@ -75,9 +75,5 @@ > : =A0void platform_identify(void); > : > : =A0extern int busdma_swi_pending; > : -void busdma_swi(void); > : - > : -u_int32_t set_intr_mask(u_int32_t); > : -u_int32_t get_intr_mask(void); > : - > : +void busdma_swi(void); > : =A0#endif /* !_MACHINE_MD_VAR_H_ */ > > This appears to be unrelated... cpufunc.h had the other interrupt related definitions, so I thought it would be better to move it there than to add the inline functions here. JC From owner-freebsd-mips@FreeBSD.ORG Sun Sep 12 17:53:29 2010 Return-Path: Delivered-To: freebsd-mips@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F71D1065672 for ; Sun, 12 Sep 2010 17:53:29 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id E3F8D8FC16 for ; Sun, 12 Sep 2010 17:53:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o8CHoneS050744; Sun, 12 Sep 2010 11:50:49 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sun, 12 Sep 2010 11:50:55 -0600 (MDT) Message-Id: <20100912.115055.475793127414924685.imp@bsdimp.com> To: c.jayachandran@gmail.com From: "M. Warner Losh" In-Reply-To: References: <20100912.102645.1055929314662048689.imp@bsdimp.com> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-mips@FreeBSD.org Subject: Re: patch - remove psracccess.S X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2010 17:53:29 -0000 In message: "Jayachandran C." writes: : On Sun, Sep 12, 2010 at 9:56 PM, M. Warner Losh wrot= e: : > In message: : > =A0 =A0 =A0 =A0 =A0 =A0"Jayachandran C." = writes: : > : Index: sys/mips/include/md_var.h : > : =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D : > : --- sys/mips/include/md_var.h (revision 212475) : > : +++ sys/mips/include/md_var.h (working copy) : > : @@ -75,9 +75,5 @@ : > : =A0void platform_identify(void); : > : : > : =A0extern int busdma_swi_pending; : > : -void busdma_swi(void); : > : - : > : -u_int32_t set_intr_mask(u_int32_t); : > : -u_int32_t get_intr_mask(void); : > : - : > : +void busdma_swi(void); : > : =A0#endif /* !_MACHINE_MD_VAR_H_ */ : > : > This appears to be unrelated... : = : cpufunc.h had the other interrupt related definitions, so I thought i= t : would be better to move it there than to add the inline functions : here. I well, that part is true. I was talking about the +void busdma_swi(void) I saw at the end. I didn't notice that it was just an artifact of the patch somehow... Warner From owner-freebsd-mips@FreeBSD.ORG Mon Sep 13 02:31:35 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B994C106566C for ; Mon, 13 Sep 2010 02:31:35 +0000 (UTC) (envelope-from neelnatu@gmail.com) Received: from mail-ww0-f42.google.com (mail-ww0-f42.google.com [74.125.82.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4FCE78FC1A for ; Mon, 13 Sep 2010 02:31:34 +0000 (UTC) Received: by wwb13 with SMTP id 13so2471760wwb.1 for ; Sun, 12 Sep 2010 19:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=mfiAkr65POkG/JdTJaUR2vYBPmqMYcMqwPPuAE12tPg=; b=tOPSOxIfRLrk35KbTVE1cKuMaAIHpLq1BExMO0ioJsIFe9U+paN+ZhQS72XrxhtFE3 iQ2nEgo6qhNJqEuRmxwNilIdU8iUkIWYmR7zuadOn2pbICbmdXx1h8/6e/qPKcUvwvES cTY46czr+vx5HrpBnPTk0/Q5YLHrwnsuLdM+g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=P+a48VxK8FuhP5TYPNvc1JLshLHB48KJ5uDmDrpmpkv10aIgvJej40EhoIWY8JdEsT ybyssXlGd1Z3xE3eDNDbUZcih+teXOZfndHyQeOlQ2pHqEHXoZ0Vn4STv61rZiz/z22Y wbfTYriXAvzWIimxyst+TztVryyT8nubN9WJs= MIME-Version: 1.0 Received: by 10.216.159.72 with SMTP id r50mr3607935wek.92.1284345094178; Sun, 12 Sep 2010 19:31:34 -0700 (PDT) Received: by 10.216.133.5 with HTTP; Sun, 12 Sep 2010 19:31:34 -0700 (PDT) In-Reply-To: References: Date: Sun, 12 Sep 2010 19:31:34 -0700 Message-ID: From: Neel Natu To: "Jayachandran C." Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-mips@freebsd.org Subject: Re: patch - remove psracccess.S X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2010 02:31:35 -0000 Hi JC, On Sun, Sep 12, 2010 at 4:20 AM, Jayachandran C. wrote: > The functions in sys/mips/mips/psraccess.S can be implemented with > mips_rd_status/mips_wr_status. Here's patch that does that. =A0 If there > are no objections, I will commit this some time tomorrow. > Your patch looks fine. I don't see anybody making use of get_intr_mask() so you could choose to nuke it. best Neel > JC. > > _______________________________________________ > freebsd-mips@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-mips > To unsubscribe, send any mail to "freebsd-mips-unsubscribe@freebsd.org" > > From owner-freebsd-mips@FreeBSD.ORG Mon Sep 13 05:02:07 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F415106564A for ; Mon, 13 Sep 2010 05:02:07 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 237A98FC1A for ; Mon, 13 Sep 2010 05:02:06 +0000 (UTC) Received: by wwb18 with SMTP id 18so6817862wwb.31 for ; Sun, 12 Sep 2010 22:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=2mam7sdtLdxXiDtwd6MPEsuVr/Z1RWt/wbNSZvFpuEg=; b=HFuTnmRCQ1obhl+aHrFuVV4GPWsU5AX64fLOIxmokXwGHVGAY7c8GQQsvV3gTJb9XF YsNxYrQQZCwOXtD9hm6ftTU9nPqFjchURRKNLWLp11+jPK72wld8NqvSOvctTplVkdeq hS0hLJvdZaHfph5CNsvI8+A0P1A58GS/hDRu4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=J13Q/hZ9XzlWihy2N90pXI9F8XttdM4ZSK3b9H1FaudJTJw9adrQNCTDCPdUmP7cQK w9BlTxnQZzIiivadX6Q1IhB5qi541htI0eqe3OOyIC1DigwF0maiC/kKIJTLVbLBwkCf T+n401fFoaEU36vlSWpMbUTDo3RSWSI6yfuUA= MIME-Version: 1.0 Received: by 10.216.184.19 with SMTP id r19mr3900674wem.36.1284354125951; Sun, 12 Sep 2010 22:02:05 -0700 (PDT) Received: by 10.216.171.12 with HTTP; Sun, 12 Sep 2010 22:02:05 -0700 (PDT) In-Reply-To: References: Date: Mon, 13 Sep 2010 10:32:05 +0530 Message-ID: From: "Jayachandran C." To: Neel Natu Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-mips@freebsd.org Subject: Re: patch - remove psracccess.S X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2010 05:02:07 -0000 On Mon, Sep 13, 2010 at 8:01 AM, Neel Natu wrote: > Hi JC, > > On Sun, Sep 12, 2010 at 4:20 AM, Jayachandran C. > wrote: >> The functions in sys/mips/mips/psraccess.S can be implemented with >> mips_rd_status/mips_wr_status. Here's patch that does that. =A0 If there >> are no objections, I will commit this some time tomorrow. >> > > Your patch looks fine. > > I don't see anybody making use of get_intr_mask() so you could choose > to nuke it. There are a couple of places in which it can be used, that is why I thought I would leave it in. JC. From owner-freebsd-mips@FreeBSD.ORG Tue Sep 14 02:07:36 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15B10106566C for ; Tue, 14 Sep 2010 02:07:36 +0000 (UTC) (envelope-from neelnatu@gmail.com) Received: from mail-ww0-f42.google.com (mail-ww0-f42.google.com [74.125.82.42]) by mx1.freebsd.org (Postfix) with ESMTP id A3DD08FC15 for ; Tue, 14 Sep 2010 02:07:35 +0000 (UTC) Received: by wwb18 with SMTP id 18so1090951wwb.1 for ; Mon, 13 Sep 2010 19:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=wTVugwUfXF9NyfNmLtLCRqIclTx2pE76qntv2bI2nUU=; b=m9AUklXpaoB92wKNCC4QubaqLGo8rxY6dek5MCByPIF7lVNstNWqZ05a9wd/3YRMtK AZQeXzPA4CJByxVCPNdnWowdN5csSNZaml0SZ6qzszgIYYcTbWldwTytWRcCTg7avHqf Kp4sUUTcX2y77UkEEX52cW5VHMb4ifYgMZXUQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=oYa5Obhjw1jbZ9UjMf8MDIw0cgE2XSEuWMZW1ccl7tsuYffx8PemCb0IxnDOozckmf bq44+M5fuX4pAjImIwsrWp1roxZ3C8CfrUbw8dAgwJ3aTfF+Sr5dPFHDzhGGhlzwppe2 0s90xnnWQHDZ/rm36yFb5KRVmoUU1DMLTnAck= MIME-Version: 1.0 Received: by 10.216.17.207 with SMTP id j57mr3303063wej.68.1284430054593; Mon, 13 Sep 2010 19:07:34 -0700 (PDT) Received: by 10.216.133.5 with HTTP; Mon, 13 Sep 2010 19:07:34 -0700 (PDT) Date: Mon, 13 Sep 2010 19:07:34 -0700 Message-ID: From: Neel Natu To: freebsd-mips@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Subject: PATCH: make usage of set_intr_mask() sane X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2010 02:07:36 -0000 Hi, This patch changes the meaning of the 'mask' argument to 'set_intr_mask(mask)' to exactly match the meaning of the IM0..7 bits in the CP0 status register. The way we have it set up right now is exactly the opposite for no good reason IMHO. Please review and let me know if there are any objections. best Neel Index: sys/mips/sibyte/sb_machdep.c =================================================================== --- sys/mips/sibyte/sb_machdep.c (revision 212587) +++ sys/mips/sibyte/sb_machdep.c (working copy) @@ -370,7 +370,7 @@ */ clock_int_mask = hard_int_mask(5); ipi_int_mask = hard_int_mask(platform_ipi_intrnum()); - set_intr_mask(MIPS_SR_INT_MASK & ~(ipi_int_mask | clock_int_mask)); + set_intr_mask(ipi_int_mask | clock_int_mask); } int Index: sys/mips/include/cpufunc.h =================================================================== --- sys/mips/include/cpufunc.h (revision 212587) +++ sys/mips/include/cpufunc.h (working copy) @@ -272,7 +272,7 @@ uint32_t ostatus; ostatus = mips_rd_status(); - mask = (ostatus & ~MIPS_SR_INT_MASK) | (~mask & MIPS_SR_INT_MASK); + mask = (ostatus & ~MIPS_SR_INT_MASK) | (mask & MIPS_SR_INT_MASK); mips_wr_status(mask); return (ostatus); } Index: sys/mips/cavium/octeon_mp.c =================================================================== --- sys/mips/cavium/octeon_mp.c (revision 212587) +++ sys/mips/cavium/octeon_mp.c (working copy) @@ -96,7 +96,7 @@ */ clock_int_mask = hard_int_mask(5); ipi_int_mask = hard_int_mask(platform_ipi_intrnum()); - set_intr_mask(MIPS_SR_INT_MASK & ~(ipi_int_mask | clock_int_mask)); + set_intr_mask(ipi_int_mask | clock_int_mask); mips_wbflush(); } Index: sys/mips/mips/machdep.c =================================================================== --- sys/mips/mips/machdep.c (revision 212587) +++ sys/mips/mips/machdep.c (working copy) @@ -356,7 +356,7 @@ * Mask all interrupts. Each interrupt will be enabled * when handler is installed for it */ - set_intr_mask(MIPS_SR_INT_MASK); + set_intr_mask(0); /* Clear BEV in SR so we start handling our own exceptions */ mips_wr_status(mips_rd_status() & ~MIPS_SR_BEV); Index: sys/mips/mips/trap.c =================================================================== --- sys/mips/mips/trap.c (revision 212587) +++ sys/mips/mips/trap.c (working copy) @@ -304,7 +304,7 @@ * return to userland. */ if (trapframe->sr & MIPS_SR_INT_IE) { - set_intr_mask(~(trapframe->sr & MIPS_SR_INT_MASK)); + set_intr_mask(trapframe->sr & MIPS_SR_INT_MASK); intr_enable(); } else { intr_disable(); From owner-freebsd-mips@FreeBSD.ORG Tue Sep 14 05:33:54 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 16D3F106566B for ; Tue, 14 Sep 2010 05:33:54 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id A0F9B8FC14 for ; Tue, 14 Sep 2010 05:33:53 +0000 (UTC) Received: by wyb33 with SMTP id 33so8272286wyb.13 for ; Mon, 13 Sep 2010 22:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ao07KVgS/4+HE6dKKMhKSjcTotjpXLhn5I1P+R3jSSM=; b=adcq4Fc911oogPa3Y5s2vT8BXM6MUhrgOa9Hf/drw4HPP8pVKutKUyspFzDe+lRHnN SSpiF/dlsUTrIYuzzCWTa3JNc2n4P5XK9dHn0NO201P/tWZlHpfaE2KODZxDqTMuF3Jm wDmHAUpfwM3ynXB4J4MEsfVQEh1HfOmpCrKMA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=dDIzVYmBGHipv8xKljNUjNEAN8mWKZEzDr+u1jv66bfYldLNDS1o/aPyZ251b/QSsj EQIWWLObjx6998zC3Jqr7xwft2M4lQDWC3jsrTI145CdjUyOy+inCxUcC9M6yRxzGeds YlMO/dtRm1OvBTbZ5v2m6PYax70D060LNBolA= MIME-Version: 1.0 Received: by 10.216.17.9 with SMTP id i9mr3465600wei.80.1284442432642; Mon, 13 Sep 2010 22:33:52 -0700 (PDT) Received: by 10.216.171.12 with HTTP; Mon, 13 Sep 2010 22:33:52 -0700 (PDT) In-Reply-To: References: Date: Tue, 14 Sep 2010 11:03:52 +0530 Message-ID: From: "Jayachandran C." To: Neel Natu Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-mips@freebsd.org Subject: Re: PATCH: make usage of set_intr_mask() sane X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2010 05:33:54 -0000 On Tue, Sep 14, 2010 at 7:37 AM, Neel Natu wrote: > Hi, > > This patch changes the meaning of the 'mask' argument to > 'set_intr_mask(mask)' to exactly match the meaning of the IM0..7 bits > in the CP0 status register. > > The way we have it set up right now is exactly the opposite for no > good reason IMHO. > > Please review and let me know if there are any objections. This is something I thought about doing with the last patch - so I would like to see this go in. But I think the reason probably is that on MIPS setting interrupt mask bit to 1 enables the interrupt, instead of masking (disabling) it. JC. > best > Neel > > Index: sys/mips/sibyte/sb_machdep.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/mips/sibyte/sb_machdep.c =A0 =A0 =A0 =A0(revision 212587) > +++ sys/mips/sibyte/sb_machdep.c =A0 =A0 =A0 =A0(working copy) > @@ -370,7 +370,7 @@ > =A0 =A0 =A0 =A0 */ > =A0 =A0 =A0 =A0clock_int_mask =3D hard_int_mask(5); > =A0 =A0 =A0 =A0ipi_int_mask =3D hard_int_mask(platform_ipi_intrnum()); > - =A0 =A0 =A0 set_intr_mask(MIPS_SR_INT_MASK & ~(ipi_int_mask | clock_int= _mask)); > + =A0 =A0 =A0 set_intr_mask(ipi_int_mask | clock_int_mask); > =A0} > > =A0int > Index: sys/mips/include/cpufunc.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/mips/include/cpufunc.h =A0(revision 212587) > +++ sys/mips/include/cpufunc.h =A0(working copy) > @@ -272,7 +272,7 @@ > =A0 =A0 =A0 =A0uint32_t ostatus; > > =A0 =A0 =A0 =A0ostatus =3D mips_rd_status(); > - =A0 =A0 =A0 mask =3D (ostatus & ~MIPS_SR_INT_MASK) | (~mask & MIPS_SR_I= NT_MASK); > + =A0 =A0 =A0 mask =3D (ostatus & ~MIPS_SR_INT_MASK) | (mask & MIPS_SR_IN= T_MASK); > =A0 =A0 =A0 =A0mips_wr_status(mask); > =A0 =A0 =A0 =A0return (ostatus); > =A0} > Index: sys/mips/cavium/octeon_mp.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/mips/cavium/octeon_mp.c (revision 212587) > +++ sys/mips/cavium/octeon_mp.c (working copy) > @@ -96,7 +96,7 @@ > =A0 =A0 =A0 =A0 */ > =A0 =A0 =A0 =A0clock_int_mask =3D hard_int_mask(5); > =A0 =A0 =A0 =A0ipi_int_mask =3D hard_int_mask(platform_ipi_intrnum()); > - =A0 =A0 =A0 set_intr_mask(MIPS_SR_INT_MASK & ~(ipi_int_mask | clock_int= _mask)); > + =A0 =A0 =A0 set_intr_mask(ipi_int_mask | clock_int_mask); > > =A0 =A0 =A0 =A0mips_wbflush(); > =A0} > Index: sys/mips/mips/machdep.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/mips/mips/machdep.c =A0 =A0 (revision 212587) > +++ sys/mips/mips/machdep.c =A0 =A0 (working copy) > @@ -356,7 +356,7 @@ > =A0 =A0 =A0 =A0 * Mask all interrupts. Each interrupt will be enabled > =A0 =A0 =A0 =A0 * when handler is installed for it > =A0 =A0 =A0 =A0 */ > - =A0 =A0 =A0 set_intr_mask(MIPS_SR_INT_MASK); > + =A0 =A0 =A0 set_intr_mask(0); > > =A0 =A0 =A0 =A0/* Clear BEV in SR so we start handling our own exceptions= */ > =A0 =A0 =A0 =A0mips_wr_status(mips_rd_status() & ~MIPS_SR_BEV); > Index: sys/mips/mips/trap.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/mips/mips/trap.c =A0 =A0 =A0 =A0(revision 212587) > +++ sys/mips/mips/trap.c =A0 =A0 =A0 =A0(working copy) > @@ -304,7 +304,7 @@ > =A0 =A0 =A0 =A0 * return to userland. > =A0 =A0 =A0 =A0 */ > =A0 =A0 =A0 =A0if (trapframe->sr & MIPS_SR_INT_IE) { > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 set_intr_mask(~(trapframe->sr & MIPS_SR_INT= _MASK)); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 set_intr_mask(trapframe->sr & MIPS_SR_INT_M= ASK); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0intr_enable(); > =A0 =A0 =A0 =A0} else { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0intr_disable(); > _______________________________________________ > freebsd-mips@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-mips > To unsubscribe, send any mail to "freebsd-mips-unsubscribe@freebsd.org" > From owner-freebsd-mips@FreeBSD.ORG Tue Sep 14 18:02:28 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E852A106566C for ; Tue, 14 Sep 2010 18:02:28 +0000 (UTC) (envelope-from PMahan@adaranet.com) Received: from barracuda.adaranet.com (smtp.adaranet.com [72.5.229.2]) by mx1.freebsd.org (Postfix) with ESMTP id CF6D78FC1D for ; Tue, 14 Sep 2010 18:02:28 +0000 (UTC) X-ASG-Debug-ID: 1284486331-50610f660001-1gY7mK Received: from SJ-EXCH-1.adaranet.com ([10.10.1.29]) by barracuda.adaranet.com with ESMTP id GT55tCvFbbLcBke1 for ; Tue, 14 Sep 2010 10:45:31 -0700 (PDT) X-Barracuda-Envelope-From: PMahan@adaranet.com Received: from mycroft.adaranet.com (10.10.24.100) by SJ-EXCH-1.adaranet.com (10.10.1.29) with Microsoft SMTP Server (TLS) id 8.1.240.5; Tue, 14 Sep 2010 10:45:30 -0700 Message-ID: <4C8FB5CA.2060100@adaranet.com> X-Barracuda-BBL-IP: nil Date: Tue, 14 Sep 2010 10:50:02 -0700 From: Patrick Mahan User-Agent: Thunderbird 2.0.0.23 (X11/20091021) MIME-Version: 1.0 To: "freebsd-mips@freebsd.org" X-ASG-Orig-Subj: Booting a 64-bit kernel on Octeon 58XX eval board fails Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: UNKNOWN[10.10.1.29] X-Barracuda-Start-Time: 1284486331 X-Barracuda-URL: http://172.16.10.203:8000/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at adaranet.com Subject: Booting a 64-bit kernel on Octeon 58XX eval board fails X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2010 18:02:29 -0000 Warner and Julie, I built and tried to boot the 64-bit kernel for the Octeon out of the HEAD sources. This board still has the Cavium SDK 1.8.1 bootloader. Here is the output on the console - Octeon ebt5800# tftp 0 mahan/kern90.64 Interface 1 has 4 ports (RGMII) Using octeth0 device TFTP from server 10.10.29.252; our IP address is 10.10.29.100 Filename 'mahan/kern90.64'. Load address: 0x20000000 Loading: ################################################################# ################################################################# ################################################################# ####################################################### done Bytes transferred = 35701417 (220c2a9 hex), 12668 Kbytes/sec Octeon ebt5800# bootoctlinux $fileaddr coremask=0x0001 argv[2]: coremask=0x0001 ELF file is 64 bit Allocated memory for ELF segment: addr: 0x100040, size 0xa8 Error allocating memory for elf image! ## Loading Linux kernel with entry point: 0x20000000 ... Bootloader: Done loading app on coremask: 0x1 Is this due to the 1.8.1 bootloader? Thanks, Patrick From owner-freebsd-mips@FreeBSD.ORG Thu Sep 16 00:12:25 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40541106566C for ; Thu, 16 Sep 2010 00:12:25 +0000 (UTC) (envelope-from PMahan@adaranet.com) Received: from barracuda.adaranet.com (smtp.adaranet.com [72.5.229.2]) by mx1.freebsd.org (Postfix) with ESMTP id 287A38FC14 for ; Thu, 16 Sep 2010 00:12:24 +0000 (UTC) X-ASG-Debug-ID: 1284595944-50611bd00001-1gY7mK Received: from SJ-EXCH-1.adaranet.com ([10.10.1.29]) by barracuda.adaranet.com with ESMTP id HFgHEClWdHSQIlpK for ; Wed, 15 Sep 2010 17:12:24 -0700 (PDT) X-Barracuda-Envelope-From: PMahan@adaranet.com Received: from mycroft.adaranet.com (10.10.24.100) by SJ-EXCH-1.adaranet.com (10.10.1.29) with Microsoft SMTP Server (TLS) id 8.1.240.5; Wed, 15 Sep 2010 17:12:24 -0700 Message-ID: <4C9161F7.7020801@adaranet.com> X-Barracuda-BBL-IP: nil Date: Wed, 15 Sep 2010 17:16:55 -0700 From: Patrick Mahan User-Agent: Thunderbird 2.0.0.23 (X11/20091021) MIME-Version: 1.0 To: "freebsd-mips@freebsd.org" X-ASG-Orig-Subj: FreeBSD Mips 64-bit boots using Cavium SDK 1.8.1 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: UNKNOWN[10.10.1.29] X-Barracuda-Start-Time: 1284595944 X-Barracuda-URL: http://172.16.10.203:8000/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at adaranet.com Subject: FreeBSD Mips 64-bit boots using Cavium SDK 1.8.1 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2010 00:12:25 -0000 Juli and Warner, Just to let you know the 64-bit version is booting on the Cavium SDK 1.8.1, don't know why that changed except for my rebuilding of u-boot and reflashing it to the eval board. The network is working fine. Now all I need is support KLM's :-) Thanks to all the team for some hard work! Patrick From owner-freebsd-mips@FreeBSD.ORG Thu Sep 16 00:19:01 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1E3D4106564A for ; Thu, 16 Sep 2010 00:19:01 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id E69858FC08 for ; Thu, 16 Sep 2010 00:19:00 +0000 (UTC) Received: by iwn34 with SMTP id 34so658337iwn.13 for ; Wed, 15 Sep 2010 17:19:00 -0700 (PDT) Received: by 10.231.79.213 with SMTP id q21mr2395681ibk.137.1284596340187; Wed, 15 Sep 2010 17:19:00 -0700 (PDT) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.231.37.135 with HTTP; Wed, 15 Sep 2010 17:18:40 -0700 (PDT) In-Reply-To: <4C9161F7.7020801@adaranet.com> References: <4C9161F7.7020801@adaranet.com> From: Juli Mallett Date: Wed, 15 Sep 2010 17:18:40 -0700 X-Google-Sender-Auth: OIw_6qAPautiInvcU85_ldGfJ0w Message-ID: To: Patrick Mahan Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-mips@freebsd.org" Subject: Re: FreeBSD Mips 64-bit boots using Cavium SDK 1.8.1 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2010 00:19:01 -0000 On Wed, Sep 15, 2010 at 17:16, Patrick Mahan wrote: > Just to let you know the 64-bit version is booting on the Cavium SDK 1.8.1, > don't know why > that changed except for my rebuilding of u-boot and reflashing it to the > eval board. Glad to hear it! If you have any problems, don't hesitate to let me know.