From owner-freebsd-ports@FreeBSD.ORG  Sun Oct 10 01:22:23 2010
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 50204106566B
	for <ports@freebsd.org>; Sun, 10 Oct 2010 01:22:23 +0000 (UTC)
	(envelope-from gordon@tetlows.org)
Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id E144E8FC14
	for <ports@freebsd.org>; Sun, 10 Oct 2010 01:22:22 +0000 (UTC)
Received: by bwz16 with SMTP id 16so3673bwz.13
	for <ports@freebsd.org>; Sat, 09 Oct 2010 18:22:21 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.204.118.148 with SMTP id v20mr1135247bkq.95.1286672078495;
	Sat, 09 Oct 2010 17:54:38 -0700 (PDT)
Received: by 10.204.174.212 with HTTP; Sat, 9 Oct 2010 17:54:38 -0700 (PDT)
In-Reply-To: <4CAB3A64.4080709@DataIX.net>
References: <4CAB3A64.4080709@DataIX.net>
Date: Sat, 9 Oct 2010 17:54:38 -0700
Message-ID: <AANLkTimCjEzpEVTS85m+2icpm5Z1gv+KRP5MYDL5PknV@mail.gmail.com>
From: Gordon Tetlow <gordon@tetlows.org>
To: jhell <jhell@dataix.net>
Content-Type: text/plain; charset=ISO-8859-1
Cc: FreeBSD Ports <ports@freebsd.org>
Subject: Re: devel/p4d/Makefile
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Oct 2010 01:22:23 -0000

On Tue, Oct 5, 2010 at 7:47 AM, jhell <jhell@dataix.net> wrote:
> Hi Gordon,
>
> I have just upgraded my p4d install and have found the following
> inconsistency in the Makefile:
>
> ${CAT} pkg-message
>
> pkg-message at this point cannot be found and it would be better if this
> referred to the ports directory and the portname /pkg-message instead.
>
>
> I might also suggest that instead of using touch(1) chown(1) chmod(1) to
> create entries in the filesystem for the p4d.log that you use install(1)
> instead as that allows you to achieve all three steps listed above in
> one command like so.
>
> install -S -o p4admin -g p4admin -m 640 /dev/null /var/log/p4d.log
>
> And of course this might need/involve some checking to see if the users
> log file already exists as we would not want to overwrite that by the
> above command but nor do we want to blindly chmod(1) the file either
> which is also done in the Makefile already.

A lot of the existing code was taken from the previous version of the
port. I didn't mess with it particularly when I took it over. I'll
take a look at the pkg-message part. At the very least, I should be
able to change it to ${PKGMESSAGE}.

Gordon