From owner-freebsd-ppc@FreeBSD.ORG Mon May 31 11:07:02 2010 Return-Path: Delivered-To: freebsd-ppc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83D3A106567B for ; Mon, 31 May 2010 11:07:02 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 71BF38FC1A for ; Mon, 31 May 2010 11:07:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o4VB72nr046082 for ; Mon, 31 May 2010 11:07:02 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o4VB71HE046080 for freebsd-ppc@FreeBSD.org; Mon, 31 May 2010 11:07:01 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 31 May 2010 11:07:01 GMT Message-Id: <201005311107.o4VB71HE046080@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-ppc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-ppc@FreeBSD.org X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 May 2010 11:07:02 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o power/146888 ppc kernel panic when loading snd_ai2s o power/140241 ppc [kernel] [patch] Linker set problems on PowerPC EABI o power/135576 ppc gdb cannot debug threaded programs on ppc o power/133503 ppc [sound] Sound stutter after switching ttys o power/133383 ppc firefox thr_kill crash with heavy vm load o power/133382 ppc [install] Installer gets signal 11 o power/131548 ppc ofw_syscons no longer supports 32-bit framebuffer a power/121407 ppc [panic] Won't boot up; strange error message. o power/111296 ppc [kernel] [patch] [request] Support IMISS, DLMISS an DS o power/93203 ppc FreeBSD PPC Can't Write to Partitions. 10 problems total. From owner-freebsd-ppc@FreeBSD.ORG Tue Jun 1 16:50:06 2010 Return-Path: Delivered-To: ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F522106564A for ; Tue, 1 Jun 2010 16:50:06 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31]) by mx1.freebsd.org (Postfix) with ESMTP id ECE928FC17 for ; Tue, 1 Jun 2010 16:50:05 +0000 (UTC) Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1]) by mail.cs.rice.edu (Postfix) with ESMTP id A55042C2B58; Tue, 1 Jun 2010 11:21:42 -0500 (CDT) X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu Received: from mail.cs.rice.edu ([127.0.0.1]) by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dALQqynSHnxZ; Tue, 1 Jun 2010 11:21:34 -0500 (CDT) Received: from adsl-216-63-78-18.dsl.hstntx.swbell.net (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cs.rice.edu (Postfix) with ESMTP id A36F62C2C60; Tue, 1 Jun 2010 11:21:30 -0500 (CDT) Message-ID: <4C053389.1040204@cs.rice.edu> Date: Tue, 01 Jun 2010 11:21:29 -0500 From: Alan Cox User-Agent: Thunderbird 2.0.0.24 (X11/20100501) MIME-Version: 1.0 To: ppc@freebsd.org Content-Type: multipart/mixed; boundary="------------070902080904060507040709" Cc: Marcel Moolenaar , Alan Cox Subject: BookE pmap_enter() bug? X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2010 16:50:06 -0000 This is a multi-part message in MIME format. --------------070902080904060507040709 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit I've been reviewing the various pmap_enter() implementations and came across the following bit of code in the BookE pmap_enter(): if (prot & VM_PROT_EXECUTE) { flags |= PTE_SX; if (!su) flags |= PTE_UX; /* * Check existing flags for execute permissions: if we * are turning execute permissions on, icache should * be flushed. */ if ((flags & (PTE_UX | PTE_SX)) == 0) sync++; } This will never flush the instruction cache because the new flags, not the old flags, are being used. I suspect that the attached change should be made. Alan --------------070902080904060507040709 Content-Type: text/plain; name="booke.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="booke.patch" Index: powerpc/booke/pmap.c =================================================================== --- powerpc/booke/pmap.c (revision 208657) +++ powerpc/booke/pmap.c (working copy) @@ -1621,7 +1621,7 @@ mmu_booke_enter_locked(mmu_t mmu, pmap_t pmap, vm_ * are turning execute permissions on, icache should * be flushed. */ - if ((flags & (PTE_UX | PTE_SX)) == 0) + if ((pte->flags & (PTE_UX | PTE_SX)) == 0) sync++; } --------------070902080904060507040709-- From owner-freebsd-ppc@FreeBSD.ORG Tue Jun 1 17:20:44 2010 Return-Path: Delivered-To: ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E67BF106566B; Tue, 1 Jun 2010 17:20:44 +0000 (UTC) (envelope-from alc@cs.rice.edu) Received: from mail.cs.rice.edu (mail.cs.rice.edu [128.42.1.31]) by mx1.freebsd.org (Postfix) with ESMTP id BEDEC8FC17; Tue, 1 Jun 2010 17:20:44 +0000 (UTC) Received: from mail.cs.rice.edu (localhost.localdomain [127.0.0.1]) by mail.cs.rice.edu (Postfix) with ESMTP id 5631E2C2AAC; Tue, 1 Jun 2010 12:20:44 -0500 (CDT) X-Virus-Scanned: by amavis-2.4.0 at mail.cs.rice.edu Received: from mail.cs.rice.edu ([127.0.0.1]) by mail.cs.rice.edu (mail.cs.rice.edu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qQ5-HjH4Q-9g; Tue, 1 Jun 2010 12:20:36 -0500 (CDT) Received: from adsl-216-63-78-18.dsl.hstntx.swbell.net (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cs.rice.edu (Postfix) with ESMTP id DCC2A2C2A91; Tue, 1 Jun 2010 12:20:35 -0500 (CDT) Message-ID: <4C054163.1050900@cs.rice.edu> Date: Tue, 01 Jun 2010 12:20:35 -0500 From: Alan Cox User-Agent: Thunderbird 2.0.0.24 (X11/20100501) MIME-Version: 1.0 To: Marcel Moolenaar References: <4C053389.1040204@cs.rice.edu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcel Moolenaar , Alan Cox , ppc@freebsd.org Subject: Re: BookE pmap_enter() bug? X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2010 17:20:45 -0000 Marcel Moolenaar wrote: > On Jun 1, 2010, at 9:21 AM, Alan Cox wrote: > > >> I've been reviewing the various pmap_enter() implementations and came across the following bit of code in the BookE pmap_enter(): >> >> if (prot & VM_PROT_EXECUTE) { >> flags |= PTE_SX; >> if (!su) >> flags |= PTE_UX; >> >> /* >> * Check existing flags for execute permissions: if we >> * are turning execute permissions on, icache should >> * be flushed. >> */ >> if ((flags & (PTE_UX | PTE_SX)) == 0) >> sync++; >> } >> >> >> This will never flush the instruction cache because the new flags, not the old flags, are being used. I suspect that the attached change should be made. >> > > *snip* > > You're right. > > I'm not aware of icache incoherency problems on BookE, so this raises > the question as to whether we actually need to worry about syncing the > icache here. But that's ortogonal... > > I'm also skeptical of the following, which is a few lines earlier: /* * The PTE_MODIFIED flag could be set by underlying * TLB misses since we last read it (above), possibly * other CPUs could update it so we check in the PTE * directly rather than rely on that saved local flags * copy. */ if (PTE_ISMODIFIED(pte)) vm_page_dirty(m); I don't see how this completely addresses the race. Why can't another processor update the PTE immediately after this test and before the PTE is finally updated a few lines later? Alan From owner-freebsd-ppc@FreeBSD.ORG Tue Jun 1 17:35:37 2010 Return-Path: Delivered-To: ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 39B4A106567E for ; Tue, 1 Jun 2010 17:35:37 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout028.mac.com (asmtpout028.mac.com [17.148.16.103]) by mx1.freebsd.org (Postfix) with ESMTP id 2200F8FC0A for ; Tue, 1 Jun 2010 17:35:36 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=us-ascii Received: from macbook-pro.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp028.mac.com (Sun Java(tm) System Messaging Server 6.3-8.01 (built Dec 16 2008; 32bit)) with ESMTPSA id <0L3C00AZGGQI1K00@asmtp028.mac.com>; Tue, 01 Jun 2010 09:35:07 -0700 (PDT) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx engine=6.0.2-1004200000 definitions=main-1006010100 X-Proofpoint-Virus-Version: vendor=fsecure engine=1.12.8161:2.4.5,1.2.40,4.0.166 definitions=2010-06-01_02:2010-02-06, 2010-06-01, 2010-06-01 signatures=0 From: Marcel Moolenaar In-reply-to: <4C053389.1040204@cs.rice.edu> Date: Tue, 01 Jun 2010 09:35:06 -0700 Message-id: References: <4C053389.1040204@cs.rice.edu> To: Alan Cox X-Mailer: Apple Mail (2.1078) Cc: Marcel Moolenaar , ppc@freebsd.org Subject: Re: BookE pmap_enter() bug? X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2010 17:35:37 -0000 On Jun 1, 2010, at 9:21 AM, Alan Cox wrote: > I've been reviewing the various pmap_enter() implementations and came across the following bit of code in the BookE pmap_enter(): > > if (prot & VM_PROT_EXECUTE) { > flags |= PTE_SX; > if (!su) > flags |= PTE_UX; > > /* > * Check existing flags for execute permissions: if we > * are turning execute permissions on, icache should > * be flushed. > */ > if ((flags & (PTE_UX | PTE_SX)) == 0) > sync++; > } > > > This will never flush the instruction cache because the new flags, not the old flags, are being used. I suspect that the attached change should be made. *snip* You're right. I'm not aware of icache incoherency problems on BookE, so this raises the question as to whether we actually need to worry about syncing the icache here. But that's ortogonal... -- Marcel Moolenaar xcllnt@mac.com From owner-freebsd-ppc@FreeBSD.ORG Wed Jun 2 08:21:21 2010 Return-Path: Delivered-To: ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C8B3810656C8 for ; Wed, 2 Jun 2010 08:21:21 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.cran.org.uk (muon.cran.org.uk [204.109.60.94]) by mx1.freebsd.org (Postfix) with ESMTP id AE3AA8FC1C for ; Wed, 2 Jun 2010 08:21:21 +0000 (UTC) Received: from unknown (87-194-158-129.bethere.co.uk [87.194.158.129]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by muon.cran.org.uk (Postfix) with ESMTPSA id B55CB5C85 for ; Wed, 2 Jun 2010 08:02:59 +0000 (UTC) Date: Wed, 2 Jun 2010 09:02:52 +0100 From: Bruce Cran To: ppc@freebsd.org Message-ID: <20100602090252.0000024c@unknown> X-Mailer: Claws Mail 3.7.4cvs1 (GTK+ 2.16.0; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Subject: "panic: moea_is_modified" on iBook G4 on latest -CURRENT X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2010 08:21:21 -0000 I just updated my system to the latest 9-CURRENT yesterday. I get the following panic on boot: real memory = 521877856 (497 MB) avail memory = 502124544 (478 MB) kbd0 at kbdmux0 nexus0: panic: moea_is_modified: page 0xd00e3940 is not managed KDB: enter: panic [ thread pid 0 tid 100000 ] The machine is a 1GHz G4 iBook. -- Bruce Cran From owner-freebsd-ppc@FreeBSD.ORG Sat Jun 5 16:30:12 2010 Return-Path: Delivered-To: freebsd-ppc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E43F2106564A for ; Sat, 5 Jun 2010 16:30:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (unknown [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BA73D8FC0C for ; Sat, 5 Jun 2010 16:30:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o55GUCOK046395 for ; Sat, 5 Jun 2010 16:30:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o55GUCLv046387; Sat, 5 Jun 2010 16:30:12 GMT (envelope-from gnats) Date: Sat, 5 Jun 2010 16:30:12 GMT Message-Id: <201006051630.o55GUCLv046387@freefall.freebsd.org> To: freebsd-ppc@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) Cc: Subject: Re: powerpc/146888: commit references a PR X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jun 2010 16:30:13 -0000 The following reply was made to PR powerpc/146888; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: powerpc/146888: commit references a PR Date: Sat, 5 Jun 2010 16:22:13 +0000 (UTC) Author: nwhitehorn Date: Sat Jun 5 16:21:55 2010 New Revision: 208835 URL: http://svn.freebsd.org/changeset/base/208835 Log: Make sure that interrupt sense settings set after interrupts are enabled are respected. This fixes loading the Apple onboard audio driver (snd_ai2s) as a module after boot, which would previously cause a panic. PR: powerpc/146888 MFC after: 5 days Modified: head/sys/powerpc/powerpc/intr_machdep.c Modified: head/sys/powerpc/powerpc/intr_machdep.c ============================================================================== --- head/sys/powerpc/powerpc/intr_machdep.c Sat Jun 5 16:00:53 2010 (r208834) +++ head/sys/powerpc/powerpc/intr_machdep.c Sat Jun 5 16:21:55 2010 (r208835) @@ -164,6 +164,7 @@ intr_lookup(u_int irq) i->trig = INTR_TRIGGER_CONFORM; i->pol = INTR_POLARITY_CONFORM; i->irq = irq; + i->pic = NULL; i->vector = -1; mtx_lock(&intr_table_lock); @@ -325,6 +326,11 @@ powerpc_setup_intr(const char *name, u_i if (!cold) { error = powerpc_map_irq(i); + + if (!error && (i->trig != INTR_TRIGGER_CONFORM || + i->pol != INTR_POLARITY_CONFORM)) + PIC_CONFIG(i->pic, i->intline, i->trig, i->pol); + if (!error && enable) PIC_ENABLE(i->pic, i->intline, i->vector); } @@ -350,7 +356,7 @@ powerpc_config_intr(int irq, enum intr_t i->trig = trig; i->pol = pol; - if (!cold) + if (!cold && i->pic != NULL) PIC_CONFIG(i->pic, i->intline, trig, pol); return (0); _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"