From owner-freebsd-python@FreeBSD.ORG Mon Nov 29 00:30:16 2010 Return-Path: Delivered-To: freebsd-python@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D78A1065673 for ; Mon, 29 Nov 2010 00:30:16 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6193B8FC20 for ; Mon, 29 Nov 2010 00:30:16 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAT0UGVB051347 for ; Mon, 29 Nov 2010 00:30:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAT0UGqk051342; Mon, 29 Nov 2010 00:30:16 GMT (envelope-from gnats) Date: Mon, 29 Nov 2010 00:30:16 GMT Message-Id: <201011290030.oAT0UGqk051342@freefall.freebsd.org> To: freebsd-python@FreeBSD.org From: John Hein Cc: Subject: Re: ports/152224: [patch] fix installed permissions for lang/python27 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John Hein List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Nov 2010 00:30:16 -0000 The following reply was made to PR ports/152224; it has been noted by GNATS. From: John Hein To: bug-followup@FreeBSD.org Cc: freebsd-python@FreeBSD.org Subject: Re: ports/152224: [patch] fix installed permissions for lang/python27 Date: Sun, 28 Nov 2010 17:23:48 -0700 --8qxSgvgPz6 Content-Type: text/plain; charset=us-ascii Content-Description: message body text Content-Transfer-Encoding: 7bit This patch is still needed for python 2.7.1 The 2.7.1 distribution tarball doesn't have 'other' permissions set, so the post-extract is still needed. The second part that uses --no-same-owner with tar in post-install is still needed in general to avoid having the installed files owned by the build user. [As described in the original report, this is needed for at least python26 as well]. --8qxSgvgPz6 Content-Type: text/plain; name="p" Content-Description: fix permissions for lang/python27 Content-Disposition: inline; filename="p" Content-Transfer-Encoding: 7bit Index: Makefile =================================================================== RCS file: /base/FreeBSD-CVS/ports/lang/python27/Makefile,v retrieving revision 1.169 diff -u -p -r1.169 Makefile --- Makefile 6 Sep 2010 00:25:04 -0000 1.169 +++ Makefile 29 Nov 2010 00:15:42 -0000 @@ -146,6 +146,12 @@ CONFIGURE_ARGS+= --disable-ipv6 CONFIGURE_ARGS+= --with-fpectl .endif +post-extract: +# The distribution tarball for python 2.7 has permission bits for 'others' +# set to 0. Later during install, we copy Tools and Demo to the installed +# prefix, so set them right here. + ${CHMOD} og=u-w ${PYTHON_WRKSRC}/Tools ${PYTHON_WRKSRC}/Demo + pre-patch: ${CP} -r ${PATCH_WRKSRC}/Lib/plat-freebsd8 \ ${PATCH_WRKSRC}/Lib/plat-freebsd9 @@ -260,12 +266,12 @@ post-install: .if !defined(NOPORTDATA) @${MKDIR} ${DATADIR} @cd ${PYTHON_WRKSRC}; ${TAR} -cf - Tools | \ - (cd ${DATADIR}; ${TAR} -xf -) + (cd ${DATADIR}; ${TAR} --no-same-owner -xf -) .endif .if !defined(NOPORTEXAMPLES) @${MKDIR} ${EXAMPLESDIR} @cd ${PYTHON_WRKSRC}/Demo; ${TAR} -cf - * | \ - (cd ${EXAMPLESDIR}; ${TAR} -xf -) + (cd ${EXAMPLESDIR}; ${TAR} --no-same-owner -xf -) .endif @${CAT} ${PKGMESSAGE} --8qxSgvgPz6--