From owner-freebsd-stable@FreeBSD.ORG Sun Jan 31 01:06:27 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BB1A81065750; Sun, 31 Jan 2010 01:06:27 +0000 (UTC) (envelope-from peterjeremy@acm.org) Received: from mail15.syd.optusnet.com.au (mail15.syd.optusnet.com.au [211.29.132.196]) by mx1.freebsd.org (Postfix) with ESMTP id BC6048FC19; Sun, 31 Jan 2010 01:06:26 +0000 (UTC) Received: from server.vk2pj.dyndns.org (c122-106-232-148.belrs3.nsw.optusnet.com.au [122.106.232.148]) by mail15.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id o0V16Jj8013115 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 31 Jan 2010 12:06:20 +1100 X-Bogosity: Ham, spamicity=0.000000 Received: from server.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by server.vk2pj.dyndns.org (8.14.3/8.14.3) with ESMTP id o0V16IbU002112; Sun, 31 Jan 2010 12:06:18 +1100 (EST) (envelope-from peter@server.vk2pj.dyndns.org) Received: (from peter@localhost) by server.vk2pj.dyndns.org (8.14.3/8.14.3/Submit) id o0V16IaS002111; Sun, 31 Jan 2010 12:06:18 +1100 (EST) (envelope-from peter) Date: Sun, 31 Jan 2010 12:06:18 +1100 From: Peter Jeremy To: Marius Strobl Message-ID: <20100131010618.GA1864@server.vk2pj.dyndns.org> References: <20100126073336.GA1955@server.vk2pj.dyndns.org> <201001260946.44977.jhb@freebsd.org> <20100126183756.GA40779@alchemy.franken.de> <201001261510.59667.jhb@freebsd.org> <20100127063649.GA1889@server.vk2pj.dyndns.org> <20100127115229.GD40779@alchemy.franken.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <20100127115229.GD40779@alchemy.franken.de> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.20 (2009-06-14) Cc: rmacklem@freebsd.org, dfr@freebsd.org, freebsd-stable@freebsd.org, John Baldwin Subject: Re: uma_zalloc_arg complaining about non-sleepable locks X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jan 2010 01:06:27 -0000 --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Sorry for the delay, I was trying to avoid rebooting my server. I've setup a similar environment in VirtualBox to test it. On 2010-Jan-27 12:52:29 +0100, Marius Strobl wr= ote: >Ah, I forgot that using nfsm_aligned() causes nfs_realign() to >be a NOP on architectures without strict alignment requirements >for performance reasons. That's generally fine but unfortunately >that way you don't actually exercise the code which caused the >problem before (unfortunately I still don't manage to hit the >unaligned case myself). >Could you please test with #ifdef __NO_STRICT_ALIGNMENT replaced >with #if 0 in sys/nfs/nfs_common.h? The vfs.nfs.realign_count >counter should also increase then. I'm not sure what triggers the unaligned case either - I tried roughly "tar -cf - -C /mnt/usr src | tar -xf - -C /mnt/tmp" and that caused some unaligned accesses (but also completely wedged the VBox host). I also tried copying a pile of files off my NFS client (FreeBSD-8.x/i386) and that also triggered some unaligned accesses without any errors being reported. Currently, I have: vfs.nfs.realign_count: 12 vfs.nfs.realign_test: 188817 I'd say that your patch works. --=20 Peter Jeremy --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAktk14oACgkQ/opHv/APuIeisgCePxY3sndE6CGY8tE4mczcl/h6 GhwAn2JbZL6GMfbgMmksUrCuASTaFbRW =1AQN -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--