From owner-freebsd-current@FreeBSD.ORG Sat Apr 16 15:51:22 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC4EF1065672 for ; Sat, 16 Apr 2011 15:51:22 +0000 (UTC) (envelope-from uncle@devio.us) Received: from wolfman.devio.us (devious-1-pt.tunnel.tserv12.mia1.ipv6.he.net [IPv6:2001:470:4:2a5::2]) by mx1.freebsd.org (Postfix) with ESMTP id C94518FC18 for ; Sat, 16 Apr 2011 15:51:22 +0000 (UTC) Received: by wolfman.devio.us (Postfix, from userid 3773) id 2C9C71A930B; Sat, 16 Apr 2011 11:51:22 -0400 (EDT) Date: Sat, 16 Apr 2011 11:51:22 -0400 From: Nick Ulen To: freebsd-current@freebsd.org Message-ID: <20110416155122.GA29309@wolfman.devio.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-Mailman-Approved-At: Sun, 17 Apr 2011 05:04:31 +0000 Subject: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Apr 2011 15:51:23 -0000 FreeBSD was successfully upgraded. uname -v FreeBSD 9.0-CURRENT #0: Mon Apr 11 18:14:36 MSD 2011 root@test:/usr/obj/usr/src/sys/GENERIC Everything seems to be working well except `hw.acpi.thermal.tz0.temperature' disappeared from the list of available sysctl variables. sysctl hw.acpi.thermal. hw.acpi.thermal.min_runtime: 0 hw.acpi.thermal.polling_rate: 10 hw.acpi.thermal.user_override: 0 hw.acpi.thermal.tz0.active: -1 hw.acpi.thermal.tz0.passive_cooling: 0 hw.acpi.thermal.tz0.thermal_flags: 0 hw.acpi.thermal.tz0._PSV: -1 hw.acpi.thermal.tz0._HOT: -1 hw.acpi.thermal.tz0._CRT: 90.0C hw.acpi.thermal.tz0._TC1: -1 hw.acpi.thermal.tz0._TC2: -1 hw.acpi.thermal.tz0._TSP: -1 output from: sysctl -a |grep acpi is here: https://privatepaste.com/ca08d4658b CPU (From /var/run/dmesg.boot): https://privatepaste.com/d107389cc1 Why is this so and how can it be changed? How is it possible to monitor CPU temperature now? Regards, Nick. From owner-freebsd-current@FreeBSD.ORG Sun Apr 17 12:10:17 2011 Return-Path: Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CE04106564A for ; Sun, 17 Apr 2011 12:10:17 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id 51F6F8FC0A for ; Sun, 17 Apr 2011 12:10:17 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:ec1f:209f:368a:33de] (unknown [IPv6:2001:7b8:3a7:0:ec1f:209f:368a:33de]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 4900C5C59 for ; Sun, 17 Apr 2011 14:10:16 +0200 (CEST) Message-ID: <4DAAD8A7.6070702@FreeBSD.org> Date: Sun, 17 Apr 2011 14:10:15 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110415 Lanikai/3.1.11pre MIME-Version: 1.0 To: freebsd-current@FreeBSD.ORG Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: HEADS UP: Removal of libobjc from the base system X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Apr 2011 12:10:17 -0000 I will be removing libobjc and other Objective-C related components from the base system, as these are extremely outdated, and not used by anything in the base system. The previous thread about this (*) did not generate much discussion, but if there are any objections, please speak up. *) http://docs.freebsd.org/cgi/mid.cgi?2AD11EA8-18FC-46E1-AE97-184599A054AD From owner-freebsd-current@FreeBSD.ORG Sun Apr 17 16:03:39 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50A691065673 for ; Sun, 17 Apr 2011 16:03:39 +0000 (UTC) (envelope-from romain.garbage@gmail.com) Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 05EA98FC15 for ; Sun, 17 Apr 2011 16:03:38 +0000 (UTC) Received: by qyk27 with SMTP id 27so2706518qyk.13 for ; Sun, 17 Apr 2011 09:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=CRjrk5GJ2RXq1AXzhdUZV9KvScdpK6wdT3niER+0ZZo=; b=Mdd/M1/CT+lc+uFkb+bsOOsv9L7a/VnDD2kbVA0qyI/PkozJeHjlUlGvm1hXX953yL xIGAyLs1tJz9iJep8w6iX+KkcAlFOE3wzA+vFUfBwwAm+YTIndyorEAt06VGxrFSCtI8 1Gb98aBhx3DQSkdVcTtlNIR/0A1oTpUoWro1s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=ZUwAXFEH7kNkTZaWD8mFtQZH9BaNH9LFr/hXfyxcCVdiOdeaQ3NccvzJPDsSPabODo tXGZ4pG5/FOdofbKJYl74aTMvQxTa//DZNqM/YmwviVu5kfq3HzwcSWm35jEm7CYBDJU HBVisbmMKEEcLFLVJB8Z3QGlWS+mfDUSdsxOM= MIME-Version: 1.0 Received: by 10.229.201.28 with SMTP id ey28mr2879603qcb.108.1303054380403; Sun, 17 Apr 2011 08:33:00 -0700 (PDT) Received: by 10.229.110.17 with HTTP; Sun, 17 Apr 2011 08:33:00 -0700 (PDT) In-Reply-To: <20110416155122.GA29309@wolfman.devio.us> References: <20110416155122.GA29309@wolfman.devio.us> Date: Sun, 17 Apr 2011 17:33:00 +0200 Message-ID: From: Romain Garbage To: Nick Ulen Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Apr 2011 16:03:39 -0000 2011/4/16 Nick Ulen : > FreeBSD was successfully upgraded. > > uname -v > FreeBSD 9.0-CURRENT #0: Mon Apr 11 18:14:36 MSD 2011 > root@test:/usr/obj/usr/src/sys/GENERIC > > Everything seems to be working well except > `hw.acpi.thermal.tz0.temperature' disappeared from the list of available > sysctl variables. > > sysctl hw.acpi.thermal. > > hw.acpi.thermal.min_runtime: 0 > hw.acpi.thermal.polling_rate: 10 > hw.acpi.thermal.user_override: 0 > hw.acpi.thermal.tz0.active: -1 > hw.acpi.thermal.tz0.passive_cooling: 0 > hw.acpi.thermal.tz0.thermal_flags: 0 > hw.acpi.thermal.tz0._PSV: -1 > hw.acpi.thermal.tz0._HOT: -1 > hw.acpi.thermal.tz0._CRT: 90.0C > hw.acpi.thermal.tz0._TC1: -1 > hw.acpi.thermal.tz0._TC2: -1 > hw.acpi.thermal.tz0._TSP: -1 > > output from: > =C2=A0sysctl -a |grep acpi > is here: https://privatepaste.com/ca08d4658b > > CPU (From /var/run/dmesg.boot): https://privatepaste.com/d107389cc1 > > Why is this so and how can it be changed? > How is it possible to monitor CPU temperature now? If you have an Intel CPU (according to coretemp manpage), you can use coretemp module: # kldload coretemp # sysctl -a | grep temp [...] dev.cpu.0.temperature: 84.0C dev.cpu.1.temperature: 85.0C dev.coretemp.0.%desc: CPU On-Die Thermal Sensors dev.coretemp.0.%driver: coretemp dev.coretemp.0.%parent: cpu0 dev.coretemp.1.%desc: CPU On-Die Thermal Sensors dev.coretemp.1.%driver: coretemp dev.coretemp.1.%parent: cpu1 If you're using an AMD CPU, the right module seems to be amdtemp. Regards, Romain From owner-freebsd-current@FreeBSD.ORG Sun Apr 17 18:09:23 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 382961065673 for ; Sun, 17 Apr 2011 18:09:23 +0000 (UTC) (envelope-from uncle@devio.us) Received: from wolfman.devio.us (devious-1-pt.tunnel.tserv12.mia1.ipv6.he.net [IPv6:2001:470:4:2a5::2]) by mx1.freebsd.org (Postfix) with ESMTP id 123758FC1C for ; Sun, 17 Apr 2011 18:09:23 +0000 (UTC) Received: by wolfman.devio.us (Postfix, from userid 3773) id A84CE1A90C8; Sun, 17 Apr 2011 14:09:22 -0400 (EDT) Date: Sun, 17 Apr 2011 14:09:22 -0400 From: Nick Ulen To: Romain Garbage Message-ID: <20110417180922.GA31398@wolfman.devio.us> References: <20110416155122.GA29309@wolfman.devio.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Mailman-Approved-At: Sun, 17 Apr 2011 19:26:03 +0000 Cc: freebsd-current@freebsd.org Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Apr 2011 18:09:23 -0000 On Sun, Apr 17, 2011 at 05:33:00PM +0200, Romain Garbage wrote: > 2011/4/16 Nick Ulen : > > FreeBSD was successfully upgraded. > > > > uname -v > > FreeBSD 9.0-CURRENT #0: Mon Apr 11 18:14:36 MSD 2011 > > root@test:/usr/obj/usr/src/sys/GENERIC > > > > Everything seems to be working well except > > `hw.acpi.thermal.tz0.temperature' disappeared from the list of available > > sysctl variables. > > > > sysctl hw.acpi.thermal. > > > > hw.acpi.thermal.min_runtime: 0 > > hw.acpi.thermal.polling_rate: 10 > > hw.acpi.thermal.user_override: 0 > > hw.acpi.thermal.tz0.active: -1 > > hw.acpi.thermal.tz0.passive_cooling: 0 > > hw.acpi.thermal.tz0.thermal_flags: 0 > > hw.acpi.thermal.tz0._PSV: -1 > > hw.acpi.thermal.tz0._HOT: -1 > > hw.acpi.thermal.tz0._CRT: 90.0C > > hw.acpi.thermal.tz0._TC1: -1 > > hw.acpi.thermal.tz0._TC2: -1 > > hw.acpi.thermal.tz0._TSP: -1 > > > > output from: > > sysctl -a |grep acpi > > is here: https://privatepaste.com/ca08d4658b > > > > CPU (From /var/run/dmesg.boot): https://privatepaste.com/d107389cc1 > > > > Why is this so and how can it be changed? > > How is it possible to monitor CPU temperature now? > > If you have an Intel CPU (according to coretemp manpage), you can use > coretemp module: > > # kldload coretemp > # sysctl -a | grep temp > [...] > dev.cpu.0.temperature: 84.0C > dev.cpu.1.temperature: 85.0C > dev.coretemp.0.%desc: CPU On-Die Thermal Sensors > dev.coretemp.0.%driver: coretemp > dev.coretemp.0.%parent: cpu0 > dev.coretemp.1.%desc: CPU On-Die Thermal Sensors > dev.coretemp.1.%driver: coretemp > dev.coretemp.1.%parent: cpu1 > > If you're using an AMD CPU, the right module seems to be amdtemp. Romain, Thanks for your feedback. The coretemp driver provides support for the on-die digital thermal sensor present in Intel Core and newer CPUs (according to coretemp manpage). I am using old Intel Pentium M processor( http://privatepaste.com/d107389cc1), so coretemp module can't help in my case. Regards, Nick From owner-freebsd-current@FreeBSD.ORG Sun Apr 17 18:45:38 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 808D4106566C for ; Sun, 17 Apr 2011 18:45:38 +0000 (UTC) (envelope-from giffunip@tutopia.com) Received: from nm29.bullet.mail.sp2.yahoo.com (nm29.bullet.mail.sp2.yahoo.com [98.139.91.99]) by mx1.freebsd.org (Postfix) with SMTP id 5DD258FC14 for ; Sun, 17 Apr 2011 18:45:38 +0000 (UTC) Received: from [98.139.91.68] by nm29.bullet.mail.sp2.yahoo.com with NNFMP; 17 Apr 2011 18:33:12 -0000 Received: from [98.139.91.53] by tm8.bullet.mail.sp2.yahoo.com with NNFMP; 17 Apr 2011 18:33:12 -0000 Received: from [127.0.0.1] by omp1053.mail.sp2.yahoo.com with NNFMP; 17 Apr 2011 18:33:12 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 820048.56539.bm@omp1053.mail.sp2.yahoo.com Received: (qmail 97440 invoked by uid 60001); 17 Apr 2011 18:33:12 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1303065192; bh=76gMSfIbnMEfQRt1dLtplga5DNqEgVd+ZlnDI1Rq4JI=; h=Message-ID:X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:Date:From:Reply-To:Subject:To:Cc:MIME-Version:Content-Type; b=btrxNE/YnG3k2YnkShG9wcYdvm9TQW3Du6XbLZ7GZjzT0uonLrWbKPVbdhgWOHQB0TN9iNf/z+n05gdi9JAdBGw4IakiyXWY7rPaJUd67AmYkhioKB5IgkIZ7/rp9XlG9lwrWcScqobVQNdwt4yOLiakQPLdvJA8AQ+SPhXe2lQ= Message-ID: <337897.86270.qm@web113503.mail.gq1.yahoo.com> X-YMail-OSG: qflzuLQVM1k34uus0s6_o8JXbyXuJ1kyKDF.786nWweoMZy UhgJccXgvq4Hz6RQW0vrk3SbhJw6YoR9vMtrAY0SI_VY6Tgw_i2e0dx8BFmf pIiJCuxbIIaEUGaMK8vrtmAEDJ.IP46dy8z7UzYXedINDaYM6I.GNonDrt9o KsfqWKeMeQzqbXJrWEHRXu4zVvNhtZWGs1YLKFBZKFHNCzvBgmdY7R2YUQki ZySDnH5_LidyA4eOvPDcZTFDNV6Ydqx6flYFrsU9NaFooxyBV3LxL0FF5ZfN lgcLGo0A4PQKS404O31x06kgPR3QuPLG_MnycIVThQjYGpLY1lU65Z1yGooe RxIKwjhgspDVVodP2bEcza3pmLnVOj7.TnTmzCvVJv2fsfGcRHBeyt955j.Y rf__nbdirzx1kx6jXB6o- Received: from [200.118.159.55] by web113503.mail.gq1.yahoo.com via HTTP; Sun, 17 Apr 2011 11:33:12 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailClassic/12.0.2 YahooMailWebService/0.8.109.295617 Date: Sun, 17 Apr 2011 11:33:12 -0700 (PDT) From: "Pedro F. Giffuni" To: Dimitry Andric MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailman-Approved-At: Sun, 17 Apr 2011 20:39:36 +0000 Cc: freebsd-current@FreeBSD.ORG Subject: Re: HEADS UP: Removal of libobjc from the base system X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: giffunip@tutopia.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Apr 2011 18:45:38 -0000 Yeah it's too outdated to be of any use. IMHO, you can axe libf2c too... cheers, Pedro. From owner-freebsd-current@FreeBSD.ORG Sun Apr 17 18:59:50 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 472A91065672 for ; Sun, 17 Apr 2011 18:59:50 +0000 (UTC) (envelope-from armin@frozen-zone.org) Received: from mailbackup.inode.at (mailbackup.inode.at [213.229.60.24]) by mx1.freebsd.org (Postfix) with ESMTP id 06D8C8FC0A for ; Sun, 17 Apr 2011 18:59:49 +0000 (UTC) Received: from [62.99.145.17] (port=25620 helo=mx.inode.at) by mailbackup.inode.at with esmtp (Exim 4.72) (envelope-from ) id 1QBWwJ-00009m-G8 for current@freebsd.org; Sun, 17 Apr 2011 20:43:19 +0200 Received: from [84.119.4.245] (port=8212 helo=fz-sub1.local) by smartmx-15.inode.at with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1QBWwH-0005c2-FG for current@freebsd.org; Sun, 17 Apr 2011 20:43:17 +0200 Message-ID: <4DAB34C3.9080503@frozen-zone.org> Date: Sun, 17 Apr 2011 20:43:15 +0200 From: Armin Pirkovitsch User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110313 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: current@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Sun, 17 Apr 2011 20:54:51 +0000 Cc: Subject: ukbs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Apr 2011 18:59:50 -0000 Hi! Out of curiousity - is currently someone working on ukbd? Armin From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 06:19:05 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A6E52106564A; Mon, 18 Apr 2011 06:19:05 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 66D0E8FC12; Mon, 18 Apr 2011 06:19:04 +0000 (UTC) Received: from [127.0.0.1] (pooker.samsco.org [168.103.85.57]) (authenticated bits=0) by pooker.samsco.org (8.14.4/8.14.4) with ESMTP id p3I5m5eG055597; Sun, 17 Apr 2011 23:48:06 -0600 (MDT) (envelope-from scottl@samsco.org) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Scott Long In-Reply-To: <337897.86270.qm@web113503.mail.gq1.yahoo.com> Date: Sun, 17 Apr 2011 23:48:04 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <337897.86270.qm@web113503.mail.gq1.yahoo.com> To: giffunip@tutopia.com X-Mailer: Apple Mail (2.1084) X-Spam-Status: No, score=-50.0 required=3.8 tests=ALL_TRUSTED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.0 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on pooker.samsco.org Cc: freebsd-current@freebsd.org, Dimitry Andric Subject: Re: HEADS UP: Removal of libobjc from the base system X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 06:19:05 -0000 On Apr 17, 2011, at 12:33 PM, Pedro F. Giffuni wrote: > Yeah it's too outdated to be of any use. >=20 > IMHO, you can axe libf2c too... >=20 Honest question here, is there a newer version of libf2c that lives in = ports and is adopted by people who use fortran? The one that I find in = the base system seems to be a similar match to the one in = ports/devel/f2c. Is the one in the base system a pain to maintain or = otherwise holding back other work, or has it been made obsolete by = something in ports? Is removing it from the base system anything more = than just churn? With libobjc, the one in ports looks to indeed be a lot newer, and I'll = take it on faith that the gnustep ports automatically installs it, = overriding the base copy and making it essentially obsolete. Scott From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 08:14:24 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0EA83106566C for ; Mon, 18 Apr 2011 08:14:24 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe03.c2i.net [212.247.154.66]) by mx1.freebsd.org (Postfix) with ESMTP id 660E58FC12 for ; Mon, 18 Apr 2011 08:14:23 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.1 cv=0KkIQGagYCvnrzE3Z2Lmid87OPdbX6VLcZYwAuLMZ50= c=1 sm=1 a=IU0TiZmyZPMA:10 a=WQU8e4WWZSUA:10 a=8nJEP1OIZ-IA:10 a=CL8lFSKtTFcA:10 a=i9M/sDlu2rpZ9XS819oYzg==:17 a=B5ijWa4DjXl1fKutGWEA:9 a=wPNLvfGTeEIA:10 a=i9M/sDlu2rpZ9XS819oYzg==:117 Received: from [188.126.198.129] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe03.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 115936248; Mon, 18 Apr 2011 10:14:21 +0200 From: Hans Petter Selasky To: freebsd-current@freebsd.org Date: Mon, 18 Apr 2011 10:13:21 +0200 User-Agent: KMail/1.13.5 (FreeBSD/8.2-PRERELEASE; KDE/4.4.5; amd64; ; ) References: <4DAB34C3.9080503@frozen-zone.org> In-Reply-To: <4DAB34C3.9080503@frozen-zone.org> X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5 %V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC( :AuzV9:.hESm-x4h240C`9=w MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201104181013.21620.hselasky@c2i.net> Cc: Armin Pirkovitsch , current@freebsd.org Subject: Re: ukbs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 08:14:24 -0000 On Sunday 17 April 2011 20:43:15 Armin Pirkovitsch wrote: > Hi! > > Out of curiousity - is currently someone working on ukbd? > No. --HPS From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 08:24:25 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68968106564A for ; Mon, 18 Apr 2011 08:24:25 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe03.c2i.net [212.247.154.66]) by mx1.freebsd.org (Postfix) with ESMTP id F23F18FC13 for ; Mon, 18 Apr 2011 08:24:24 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.1 cv=0KkIQGagYCvnrzE3Z2Lmid87OPdbX6VLcZYwAuLMZ50= c=1 sm=1 a=IU0TiZmyZPMA:10 a=WQU8e4WWZSUA:10 a=8nJEP1OIZ-IA:10 a=CL8lFSKtTFcA:10 a=i9M/sDlu2rpZ9XS819oYzg==:17 a=B5ijWa4DjXl1fKutGWEA:9 a=wPNLvfGTeEIA:10 a=i9M/sDlu2rpZ9XS819oYzg==:117 Received: from [188.126.198.129] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe03.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 115936248; Mon, 18 Apr 2011 10:14:21 +0200 From: Hans Petter Selasky To: freebsd-current@freebsd.org Date: Mon, 18 Apr 2011 10:13:21 +0200 User-Agent: KMail/1.13.5 (FreeBSD/8.2-PRERELEASE; KDE/4.4.5; amd64; ; ) References: <4DAB34C3.9080503@frozen-zone.org> In-Reply-To: <4DAB34C3.9080503@frozen-zone.org> X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5 %V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC( :AuzV9:.hESm-x4h240C`9=w MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201104181013.21620.hselasky@c2i.net> Cc: Armin Pirkovitsch , current@freebsd.org Subject: Re: ukbs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 08:24:25 -0000 On Sunday 17 April 2011 20:43:15 Armin Pirkovitsch wrote: > Hi! > > Out of curiousity - is currently someone working on ukbd? > No. --HPS From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 12:20:43 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 92396106564A; Mon, 18 Apr 2011 12:20:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 66E678FC0A; Mon, 18 Apr 2011 12:20:43 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 0937E46B46; Mon, 18 Apr 2011 08:20:43 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 7975B8A01B; Mon, 18 Apr 2011 08:20:42 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org Date: Mon, 18 Apr 2011 08:05:40 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <20110416155122.GA29309@wolfman.devio.us> In-Reply-To: <20110416155122.GA29309@wolfman.devio.us> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201104180805.40743.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Mon, 18 Apr 2011 08:20:42 -0400 (EDT) Cc: Matthew Fleming , Nick Ulen Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 12:20:43 -0000 On Saturday, April 16, 2011 11:51:22 am Nick Ulen wrote: > FreeBSD was successfully upgraded. > > uname -v > FreeBSD 9.0-CURRENT #0: Mon Apr 11 18:14:36 MSD 2011 > root@test:/usr/obj/usr/src/sys/GENERIC > > Everything seems to be working well except > `hw.acpi.thermal.tz0.temperature' disappeared from the list of available > sysctl variables. > > sysctl hw.acpi.thermal. > > hw.acpi.thermal.min_runtime: 0 > hw.acpi.thermal.polling_rate: 10 > hw.acpi.thermal.user_override: 0 > hw.acpi.thermal.tz0.active: -1 > hw.acpi.thermal.tz0.passive_cooling: 0 > hw.acpi.thermal.tz0.thermal_flags: 0 > hw.acpi.thermal.tz0._PSV: -1 > hw.acpi.thermal.tz0._HOT: -1 > hw.acpi.thermal.tz0._CRT: 90.0C > hw.acpi.thermal.tz0._TC1: -1 > hw.acpi.thermal.tz0._TC2: -1 > hw.acpi.thermal.tz0._TSP: -1 > > output from: > sysctl -a |grep acpi > is here: https://privatepaste.com/ca08d4658b I suspect it is still there, but sysctl doesn't know how to display it anymore. This is probably due to the changes with formatting of sysctl information. mdf@ is probably responsible in that case. SYSCTL_ADD_OPAQUE(&sc->tz_sysctl_ctx, SYSCTL_CHILDREN(sc->tz_sysctl_tree), OID_AUTO, "temperature", CTLFLAG_RD, &sc->tz_temperature, sizeof(sc->tz_temperature), "IK", "current thermal zone temperature"); -- John Baldwin From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 13:24:56 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB79C1065675 for ; Mon, 18 Apr 2011 13:24:55 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from albert.catwhisker.org (m209-73.dsl.rawbw.com [198.144.209.73]) by mx1.freebsd.org (Postfix) with ESMTP id B935C8FC1B for ; Mon, 18 Apr 2011 13:24:55 +0000 (UTC) Received: from albert.catwhisker.org (localhost [127.0.0.1]) by albert.catwhisker.org (8.14.4/8.14.4) with ESMTP id p3IDOtge008752 for ; Mon, 18 Apr 2011 06:24:55 -0700 (PDT) (envelope-from david@albert.catwhisker.org) Received: (from david@localhost) by albert.catwhisker.org (8.14.4/8.14.4/Submit) id p3IDOtlD008751 for current@freebsd.org; Mon, 18 Apr 2011 06:24:55 -0700 (PDT) (envelope-from david) Date: Mon, 18 Apr 2011 06:24:55 -0700 From: David Wolfskill To: current@freebsd.org Message-ID: <20110418132455.GE1554@albert.catwhisker.org> Mail-Followup-To: David Wolfskill , current@freebsd.org References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wchHw8dVAp53YPj8" Content-Disposition: inline In-Reply-To: <201104180805.40743.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 13:24:56 -0000 --wchHw8dVAp53YPj8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 18, 2011 at 08:05:40AM -0400, John Baldwin wrote: > ... > > output from: > > sysctl -a |grep acpi > > is here: https://privatepaste.com/ca08d4658b >=20 > I suspect it is still there, but sysctl doesn't know how to display it=20 > anymore. This is probably due to the changes with formatting of sysctl= =20 > information. mdf@ is probably responsible in that case. >=20 > SYSCTL_ADD_OPAQUE(&sc->tz_sysctl_ctx, SYSCTL_CHILDREN(sc->tz_sysctl_t= ree), > OID_AUTO, "temperature", CTLFLAG_RD, &sc->tz_temperature, > sizeof(sc->tz_temperature), "IK", > "current thermal zone temperature"); That appears to agree with what I see here: g1-222(9.0-C)[1] uname -a FreeBSD g1-222.catwhisker.org. 9.0-CURRENT FreeBSD 9.0-CURRENT #202 r220770= : Mon Apr 18 05:59:09 PDT 2011 root@g1-222.catwhisker.org.:/usr/obj/usr= /src/sys/CANARY i386 g1-222(9.0-C)[2] sysctl -o dev.coretemp dev.coretemp.0.%desc: CPU On-Die Thermal Sensors dev.coretemp.0.%driver: coretemp dev.coretemp.0.%parent: cpu0 dev.coretemp.1.%desc: CPU On-Die Thermal Sensors dev.coretemp.1.%driver: coretemp dev.coretemp.1.%parent: cpu1 g1-222(9.0-C)[3] sysctl -o hw.acpi.thermal hw.acpi.thermal.min_runtime: 0 hw.acpi.thermal.polling_rate: 10 hw.acpi.thermal.user_override: 0 hw.acpi.thermal.tz0.temperature: Format:IK Length:4 Dump:0xd70c0000... hw.acpi.thermal.tz0.active: -1 hw.acpi.thermal.tz0.passive_cooling: 0 hw.acpi.thermal.tz0.thermal_flags: 0 hw.acpi.thermal.tz0._PSV: -1 hw.acpi.thermal.tz0._HOT: -1 hw.acpi.thermal.tz0._CRT: 107.0C hw.acpi.thermal.tz0._ACx: Format:IK Length:40 Dump:0xffffffffffffffffffffff= ffffffffff... =20 hw.acpi.thermal.tz0._TC1: -1 hw.acpi.thermal.tz0._TC2: -1 hw.acpi.thermal.tz0._TSP: -1 g1-222(9.0-C)[4]=20 [From dmesg...] =2E.. CPU: Intel(R) Core(TM)2 Duo CPU T9600 @ 2.80GHz (2793.06-MHz 686-class= CPU) Origin =3D "GenuineIntel" Id =3D 0x10676 Family =3D 6 Model =3D 17 St= epping =3D 6 Features=3D0xbfebfbff Features2=3D0x8e3fd AMD Features=3D0x20100000 AMD Features2=3D0x1 TSC: P-state invariant, performance statistics =2E... Peace, david --=20 David H. Wolfskill david@catwhisker.org Depriving a girl or boy of an opportunity for education is evil. See http://www.catwhisker.org/~david/publickey.gpg for my public key. --wchHw8dVAp53YPj8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iEYEARECAAYFAk2sO6YACgkQmprOCmdXAD3N1wCeLiHE9i1BCLrifaUB7IPHzAsR wJ8AnRQDxOwfazusDUplLz/OTrTVXY1m =K49E -----END PGP SIGNATURE----- --wchHw8dVAp53YPj8-- From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 13:42:56 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFF091065672; Mon, 18 Apr 2011 13:42:56 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id 5073D8FC1B; Mon, 18 Apr 2011 13:42:56 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:adc5:19f9:a31a:3bcd] (unknown [IPv6:2001:7b8:3a7:0:adc5:19f9:a31a:3bcd]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 495B85C59; Mon, 18 Apr 2011 15:42:55 +0200 (CEST) Message-ID: <4DAC3FD9.1060603@FreeBSD.org> Date: Mon, 18 Apr 2011 15:42:49 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110415 Lanikai/3.1.11pre MIME-Version: 1.0 To: "arch@freebsd.org" , "current@freebsd.org" Content-Type: multipart/mixed; boundary="------------000008000402090004000307" Cc: Subject: Removal of ICC (intel compiler) bits from mk X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 13:42:57 -0000 This is a multi-part message in MIME format. --------------000008000402090004000307 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reviving an old thread(*), I would like to propose to finally remove the Intel C Compiler support from share/mk and other places. As mentioned in that thread, the ICC bits simply do not work anymore, and no one has volunteered to fix it for many years. Please review the attached patch, which cleans up the ICC bits. *) http://lists.freebsd.org/pipermail/freebsd-current/2010-August/019179.html --------------000008000402090004000307 Content-Type: text/plain; name="remove-icc-1.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="remove-icc-1.diff" diff --git a/share/mk/bsd.cpu.mk b/share/mk/bsd.cpu.mk index 99c28aa..0670bff 100644 --- a/share/mk/bsd.cpu.mk +++ b/share/mk/bsd.cpu.mk @@ -91,31 +91,6 @@ _CPUCFLAGS = -march=prescott . else _CPUCFLAGS = -march=${CPUTYPE} . endif # GCC on 'i386' -. if ${CPUTYPE} == "crusoe" -_ICC_CPUCFLAGS = -tpp6 -xiM -. elif ${CPUTYPE} == "athlon-mp" || ${CPUTYPE} == "athlon-xp" || \ - ${CPUTYPE} == "athlon-4" -_ICC_CPUCFLAGS = -tpp6 -xiMK -. elif ${CPUTYPE} == "athlon-tbird" || ${CPUTYPE} == "athlon" -_ICC_CPUCFLAGS = -tpp6 -xiM -. elif ${CPUTYPE} == "k6-3" || ${CPUTYPE} == "k6-2" || ${CPUTYPE} == "k6" -_ICC_CPUCFLAGS = -tpp6 -xi -. elif ${CPUTYPE} == "k5" -_ICC_CPUCFLAGS = -tpp5 -. elif ${CPUTYPE} == "pentium4" || ${CPUTYPE} == "pentium4m" -_ICC_CPUCFLAGS = -tpp7 -xiMKW -. elif ${CPUTYPE} == "pentium3" || ${CPUTYPE} == "pentium3m" || \ - ${CPUTYPE} == "pentium-m" -_ICC_CPUCFLAGS = -tpp6 -xiMK -. elif ${CPUTYPE} == "pentium2" || ${CPUTYPE} == "pentiumpro" -_ICC_CPUCFLAGS = -tpp6 -xiM -. elif ${CPUTYPE} == "pentium-mmx" -_ICC_CPUCFLAGS = -tpp5 -xM -. elif ${CPUTYPE} == "pentium" -_ICC_CPUCFLAGS = -tpp5 -. else -_ICC_CPUCFLAGS = -. endif # ICC on 'i386' . elif ${MACHINE_CPUARCH} == "amd64" _CPUCFLAGS = -march=${CPUTYPE} . elif ${MACHINE_CPUARCH} == "arm" @@ -242,9 +217,5 @@ CFLAGS += -G0 # NB: COPTFLAGS is handled in /usr/src/sys/conf/kern.pre.mk .if !defined(NO_CPU_CFLAGS) -. if ${CC} == "icc" -CFLAGS += ${_ICC_CPUCFLAGS} -. else CFLAGS += ${_CPUCFLAGS} -. endif .endif diff --git a/share/mk/bsd.dep.mk b/share/mk/bsd.dep.mk index 459a9c3..c452528 100644 --- a/share/mk/bsd.dep.mk +++ b/share/mk/bsd.dep.mk @@ -125,13 +125,8 @@ depend: beforedepend ${DEPENDFILE} afterdepend # Different types of sources are compiled with slightly different flags. # Split up the sources, and filter out headers and non-applicable flags. -.if ${CC:T:Micc} == "icc" -MKDEP_CFLAGS= ${CFLAGS:M-X*} ${CFLAGS:M-[BIDU]*} -MKDEP_CXXFLAGS= ${CXXFLAGS:M-X*} ${CXXFLAGS:M-[BIDU]*} -.else MKDEP_CFLAGS= ${CFLAGS:M-nostdinc*} ${CFLAGS:M-[BIDU]*} MKDEP_CXXFLAGS= ${CXXFLAGS:M-nostdinc*} ${CXXFLAGS:M-[BIDU]*} -.endif DPSRCS+= ${SRCS} ${DEPENDFILE}: ${DPSRCS} diff --git a/share/mk/bsd.lib.mk b/share/mk/bsd.lib.mk index 9d655b6..943010c 100644 --- a/share/mk/bsd.lib.mk +++ b/share/mk/bsd.lib.mk @@ -65,11 +65,7 @@ PICFLAG=-fpic .endif .endif -.if ${CC:T:Micc} == "icc" -PO_FLAG=-p -.else PO_FLAG=-pg -.endif .c.po: ${CC} ${PO_FLAG} ${PO_CFLAGS} -c ${.IMPSRC} -o ${.TARGET} diff --git a/share/mk/bsd.sys.mk b/share/mk/bsd.sys.mk index fc5ec40..796d169 100644 --- a/share/mk/bsd.sys.mk +++ b/share/mk/bsd.sys.mk @@ -11,20 +11,18 @@ # the default is gnu99 for now CSTD ?= gnu99 -.if ${CC:T:Micc} != "icc" -. if ${CSTD} == "k&r" +.if ${CSTD} == "k&r" CFLAGS += -traditional -. elif ${CSTD} == "c89" || ${CSTD} == "c90" +.elif ${CSTD} == "c89" || ${CSTD} == "c90" CFLAGS += -std=iso9899:1990 -. elif ${CSTD} == "c94" || ${CSTD} == "c95" +.elif ${CSTD} == "c94" || ${CSTD} == "c95" CFLAGS += -std=iso9899:199409 -. elif ${CSTD} == "c99" +.elif ${CSTD} == "c99" CFLAGS += -std=iso9899:1999 -. else +.else CFLAGS += -std=${CSTD} -. endif .endif -.if !defined(NO_WARNS) && ${CC:T:Micc} != "icc" +.if !defined(NO_WARNS) # -pedantic is problematic because it also imposes namespace restrictions #CFLAGS += -pedantic . if defined(WARNS) @@ -82,9 +80,8 @@ CWARNFLAGS += -Wno-format CWARNFLAGS += -Wno-unknown-pragmas .endif -.if ${MK_SSP} != "no" && ${CC:T:Micc} != "icc" && \ - ${MACHINE_CPUARCH} != "ia64" && \ - ${MACHINE_CPUARCH} != "arm" && ${MACHINE_CPUARCH} != "mips" +.if ${MK_SSP} != "no" && ${MACHINE_CPUARCH} != "ia64" && \ + ${MACHINE_CPUARCH} != "arm" && ${MACHINE_CPUARCH} != "mips" # Don't use -Wstack-protector as it breaks world with -Werror. SSP_CFLAGS ?= -fstack-protector CFLAGS += ${SSP_CFLAGS} diff --git a/sys/conf/kern.mk b/sys/conf/kern.mk index 01b1438..1e58378 100644 --- a/sys/conf/kern.mk +++ b/sys/conf/kern.mk @@ -6,14 +6,9 @@ # Note that the newly added -Wcast-qual is responsible for generating # most of the remaining warnings. Warnings introduced with -Wall will # also pop up, but are easier to fix. -.if ${CC:T:Micc} == "icc" -#CWARNFLAGS= -w2 # use this if you are terribly bored -CWARNFLAGS= -.else CWARNFLAGS?= -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes \ -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual \ -Wundef -Wno-pointer-sign -fformat-extensions -.endif # # The following flags are next up for working on: # -W @@ -29,7 +24,7 @@ CWARNFLAGS?= -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes \ # operations inside the kernel itself. These operations are exclusively # reserved for user applications. # -.if ${MACHINE_CPUARCH} == "i386" && ${CC:T:Micc} != "icc" +.if ${MACHINE_CPUARCH} == "i386" .if ${CC:T:Mclang} != "clang" CFLAGS+= -mno-align-long-strings -mpreferred-stack-boundary=2 .endif @@ -100,22 +95,13 @@ INLINE_LIMIT?= 8000 # GCC 3.0 and above like to do certain optimizations based on the # assumption that the program is linked against libc. Stop this. # -.if ${CC:T:Micc} == "icc" -CFLAGS+= -nolib_inline -.else CFLAGS+= -ffreestanding -.endif - -.if ${CC:T:Micc} == "icc" -CFLAGS+= -restrict -.endif # # GCC SSP support. # -.if ${MK_SSP} != "no" && ${CC:T:Micc} != "icc" && \ - ${MACHINE_CPUARCH} != "ia64" && ${MACHINE_CPUARCH} != "arm" && \ - ${MACHINE_CPUARCH} != "mips" +.if ${MK_SSP} != "no" && ${MACHINE_CPUARCH} != "ia64" && \ + ${MACHINE_CPUARCH} != "arm" && ${MACHINE_CPUARCH} != "mips" CFLAGS+= -fstack-protector .endif diff --git a/sys/conf/kern.pre.mk b/sys/conf/kern.pre.mk index 4deaea8..db244c4 100644 --- a/sys/conf/kern.pre.mk +++ b/sys/conf/kern.pre.mk @@ -23,38 +23,25 @@ NM?= nm OBJCOPY?= objcopy SIZE?= size -.if ${CC:T:Micc} == "icc" -COPTFLAGS?= -O -.else -. if defined(DEBUG) +.if defined(DEBUG) _MINUS_O= -O CTFFLAGS+= -g -. else +.else _MINUS_O= -O2 -. endif -. if ${MACHINE_CPUARCH} == "amd64" +.endif +.if ${MACHINE_CPUARCH} == "amd64" COPTFLAGS?=-O2 -frename-registers -pipe -. else +.else COPTFLAGS?=${_MINUS_O} -pipe -. endif -. if !empty(COPTFLAGS:M-O[23s]) && empty(COPTFLAGS:M-fno-strict-aliasing) +.endif +.if !empty(COPTFLAGS:M-O[23s]) && empty(COPTFLAGS:M-fno-strict-aliasing) COPTFLAGS+= -fno-strict-aliasing -. endif .endif .if !defined(NO_CPU_COPTFLAGS) -. if ${CC:T:Micc} == "icc" -COPTFLAGS+= ${_ICC_CPUCFLAGS:C/(-x[^M^K^W]+)[MKW]+|-x[MKW]+/\1/} -. else COPTFLAGS+= ${_CPUCFLAGS} -. endif .endif -.if ${CC:T:Micc} == "icc" -C_DIALECT= -NOSTDINC= -X -.else C_DIALECT= -std=c99 NOSTDINC= -nostdinc -.endif INCLUDES= ${NOSTDINC} ${INCLMAGIC} -I. -I$S @@ -89,36 +76,31 @@ INCLUDES+= -I$S/dev/cxgb -I$S/dev/cxgbe CFLAGS= ${COPTFLAGS} ${C_DIALECT} ${DEBUG} ${CWARNFLAGS} CFLAGS+= ${INCLUDES} -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -.if ${CC:T:Micc} != "icc" .if ${CC:T:Mclang} != "clang" CFLAGS+= -fno-common -finline-limit=${INLINE_LIMIT} -.if ${MACHINE_CPUARCH} != "mips" +. if ${MACHINE_CPUARCH} != "mips" CFLAGS+= --param inline-unit-growth=100 CFLAGS+= --param large-function-growth=1000 -.else +. else # XXX Actually a gross hack just for Octeon because of the Simple Executive. CFLAGS+= --param inline-unit-growth=10000 CFLAGS+= --param large-function-growth=100000 CFLAGS+= --param max-inline-insns-single=10000 -.endif +. endif .endif WERROR?= -Werror -.endif # XXX LOCORE means "don't declare C stuff" not "for locore.s". ASM_CFLAGS= -x assembler-with-cpp -DLOCORE ${CFLAGS} .if defined(PROFLEVEL) && ${PROFLEVEL} >= 1 -.if ${CC:T:Micc} == "icc" -.error "Profiling doesn't work with icc" -.endif CFLAGS+= -DGPROF -falign-functions=16 -.if ${PROFLEVEL} >= 2 +. if ${PROFLEVEL} >= 2 CFLAGS+= -DGPROF4 -DGUPROF PROF= -pg -mprofiler-epilogue -.else +. else PROF= -pg -.endif +. endif .endif DEFINED_PROF= ${PROF} diff --git a/sys/conf/kmod.mk b/sys/conf/kmod.mk index 2239d66..6d22e41 100644 --- a/sys/conf/kmod.mk +++ b/sys/conf/kmod.mk @@ -88,25 +88,17 @@ __KLD_SHARED=yes __KLD_SHARED=no .endif -.if ${CC:T:Micc} == "icc" -CFLAGS:= ${CFLAGS:C/(-x[^M^K^W]+)[MKW]+|-x[MKW]+/\1/} -.else -. if !empty(CFLAGS:M-O[23s]) && empty(CFLAGS:M-fno-strict-aliasing) +.if !empty(CFLAGS:M-O[23s]) && empty(CFLAGS:M-fno-strict-aliasing) CFLAGS+= -fno-strict-aliasing -. endif +.endif WERROR?= -Werror -.endif CFLAGS+= ${WERROR} CFLAGS+= -D_KERNEL CFLAGS+= -DKLD_MODULE # Don't use any standard or source-relative include directories. -.if ${CC:T:Micc} == "icc" -NOSTDINC= -X -.else CSTD= c99 NOSTDINC= -nostdinc -.endif CFLAGS:= ${CFLAGS:N-I*} ${NOSTDINC} ${INCLMAGIC} ${CFLAGS:M-I*} .if defined(KERNBUILDDIR) CFLAGS+= -DHAVE_KERNEL_OPTION_HEADERS -include ${KERNBUILDDIR}/opt_global.h @@ -121,7 +113,7 @@ CFLAGS+= -I. -I@ # for example. CFLAGS+= -I@/contrib/altq -.if ${CC:T:Micc} != "icc" && ${CC:T:Mclang} != "clang" +.if ${CC:T:Mclang} != "clang" CFLAGS+= -finline-limit=${INLINE_LIMIT} CFLAGS+= --param inline-unit-growth=100 CFLAGS+= --param large-function-growth=1000 @@ -129,9 +121,7 @@ CFLAGS+= --param large-function-growth=1000 # Disallow common variables, and if we end up with commons from # somewhere unexpected, allocate storage for them in the module itself. -.if ${CC:T:Micc} != "icc" CFLAGS+= -fno-common -.endif LDFLAGS+= -d -warn-common CFLAGS+= ${DEBUG_FLAGS} diff --git a/sys/dev/aic7xxx/aicasm/Makefile b/sys/dev/aic7xxx/aicasm/Makefile index c077285..b8352d6 100644 --- a/sys/dev/aic7xxx/aicasm/Makefile +++ b/sys/dev/aic7xxx/aicasm/Makefile @@ -24,12 +24,7 @@ WARNS?= 5 DEPENDFILE= .depend_aicasm .endif -.if ${CC:T:Micc} == "icc" -CFLAGS+= -restrict -NOSTDINC= -X -.else NOSTDINC= -nostdinc -.endif CFLAGS+= ${NOSTDINC} -I/usr/include -I. .ifdef MAKESRCPATH CFLAGS+= -I${MAKESRCPATH} --------------000008000402090004000307-- From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 15:03:45 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F8A5106566C; Mon, 18 Apr 2011 15:03:45 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id BAB888FC1A; Mon, 18 Apr 2011 15:03:44 +0000 (UTC) Received: by qwc9 with SMTP id 9so2952248qwc.13 for ; Mon, 18 Apr 2011 08:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:in-reply-to :references:x-mailer:mime-version:content-type; bh=X4cK8GB8L67Anjw2P2pVJOvBlQxXMlQy07tdCM7oW7c=; b=InZXQ/h87661mmtfP8rXDXK0TtXv++HAy2J/TpmJ0kPqamm9vDKM5fHakUCVMOddud ZygUJRVIVZ6kqVef5lzqQ4gVl5crgqpMiEkC5snicOd2BgTyPkJFYepj62UQyqVuHVVl NU6gqa3kxKlDauTER5msajcgqYVQn1N91T5/k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=TcONZsq7g+iY0SG7QHmrfoirYhnuNUTJajb460Rjq0KtSIYuMdAroy3Yd/IO93BFtY 76Ye00zzCgn+S5/Dka6CTXQ7UMr3HSIQDi5jmg+VSMfgxkHpYiKTSfTYSwQ0e/T2Aiys vphxQcQbFfspldP9ytuAemhArvuZqHsBuewb8= Received: by 10.224.76.74 with SMTP id b10mr2612333qak.339.1303137265486; Mon, 18 Apr 2011 07:34:25 -0700 (PDT) Received: from kan.dnsalias.net (c-24-63-226-98.hsd1.ma.comcast.net [24.63.226.98]) by mx.google.com with ESMTPS id k2sm4068365qcu.43.2011.04.18.07.34.23 (version=SSLv3 cipher=OTHER); Mon, 18 Apr 2011 07:34:23 -0700 (PDT) Date: Mon, 18 Apr 2011 10:34:16 -0400 From: Alexander Kabaev To: Dimitry Andric Message-ID: <20110418103416.76b07b36@kan.dnsalias.net> In-Reply-To: <4DAC3FD9.1060603@FreeBSD.org> References: <4DAC3FD9.1060603@FreeBSD.org> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.1; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/HE9=aLB=UIM5lkFIXnBIgWp"; protocol="application/pgp-signature" Cc: "arch@freebsd.org" , "current@freebsd.org" Subject: Re: Removal of ICC (intel compiler) bits from mk X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 15:03:45 -0000 --Sig_/HE9=aLB=UIM5lkFIXnBIgWp Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 18 Apr 2011 15:42:49 +0200 Dimitry Andric wrote: > Reviving an old thread(*), I would like to propose to finally remove > the Intel C Compiler support from share/mk and other places. As > mentioned in that thread, the ICC bits simply do not work anymore, > and no one has volunteered to fix it for many years. >=20 > Please review the attached patch, which cleans up the ICC bits. >=20 >=20 > *) > http://lists.freebsd.org/pipermail/freebsd-current/2010-August/019179.html You probably also want to remove the code that uses __INTEL_COMPILER in source tree if you want to be really thorough. --=20 Alexander Kabaev --Sig_/HE9=aLB=UIM5lkFIXnBIgWp Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iD8DBQFNrEvuQ6z1jMm+XZYRAhS9AJwPqUX6MD4V26T9hBEsNDNNgQAfggCg5Ytr IocLFZW53AauDtA7RQOp/ys= =OEaV -----END PGP SIGNATURE----- --Sig_/HE9=aLB=UIM5lkFIXnBIgWp-- From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 13:37:11 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 820BA106567B for ; Mon, 18 Apr 2011 13:37:11 +0000 (UTC) (envelope-from giffunip@tutopia.com) Received: from nm27.bullet.mail.sp2.yahoo.com (nm27.bullet.mail.sp2.yahoo.com [98.139.91.97]) by mx1.freebsd.org (Postfix) with SMTP id 2164F8FC13 for ; Mon, 18 Apr 2011 13:37:10 +0000 (UTC) Received: from [98.139.91.62] by nm27.bullet.mail.sp2.yahoo.com with NNFMP; 18 Apr 2011 13:37:10 -0000 Received: from [98.139.91.21] by tm2.bullet.mail.sp2.yahoo.com with NNFMP; 18 Apr 2011 13:37:10 -0000 Received: from [127.0.0.1] by omp1021.mail.sp2.yahoo.com with NNFMP; 18 Apr 2011 13:37:10 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 745181.1844.bm@omp1021.mail.sp2.yahoo.com Received: (qmail 42622 invoked by uid 60001); 18 Apr 2011 13:37:10 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1303133830; bh=iItISDaLe7dBnSC3G4LtHYdmV3LHmwqQuZyw55Btd/o=; h=Message-ID:X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=NP4M8prLh7cJ7YeY6yAmOOILcrGC3P1hH6TWJQLopeqj6Lp2663IlGk4u4i4CfhAaRwirUBTAwY5SDtBTZ/6PDPDXQJcC9sznVF0HXx+0P09xsWt8RRZ0OGwk/9fTljqg2/nSD52U/sjnUGaNVpnyGTx/ysF99CgCP2E6qXe6Q0= Message-ID: <463183.28445.qm@web113513.mail.gq1.yahoo.com> X-YMail-OSG: ctCVxfgVM1keCmucIu5r9FJQKlUfYg3gs3B9J.D064s.L8t DQFk4gm.KzCc8moX4DJEXCS399.qERs7jAo5cfAlyt.cHMKThbMcFVHKapSk FY2pUgSqOMC06BaFn1y6O_tzEP_7HkDDywcIyI2EHcW.cTvJTGvgPB7XIe3Z cMN2Cn_0KBcaW_1wegRzpa87wZQOk1lcyl04jx5DDIOfMppUpSR8uuNvI0f3 bGO7r2hIAz2GKe2Lk26YTHSUq2BBj_8DNnvXDgdiOZ0HfEYidSz48cKIsQnT Ix_YNKoM6w.iD0YsjW80_7SRTCLI51cGzG.LkUF9YqK4iynq_J2yXRXNXIUy ecrGRa5n5zi2Rr831hVAg3s68gIC7H2Fhvo.jQnvnl8va41dyijEuZuVwqR1 HBHnQFsxrWVD238I- Received: from [200.118.159.55] by web113513.mail.gq1.yahoo.com via HTTP; Mon, 18 Apr 2011 06:37:10 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailClassic/12.0.2 YahooMailWebService/0.8.109.295617 Date: Mon, 18 Apr 2011 06:37:10 -0700 (PDT) From: "Pedro F. Giffuni" To: Scott Long In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 18 Apr 2011 15:40:11 +0000 Cc: freebsd-current@freebsd.org Subject: Re: HEADS UP: Removal of libobjc from the base system X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: giffunip@tutopia.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 13:37:11 -0000 =0A--- On Mon, 4/18/11, Scott Long wrote:=0A...=0A> > Y= eah it's too outdated to be of any use.=0A> > =0A> > IMHO, you can axe libf= 2c too...=0A> > =0A> =0A> Honest question here, is there a newer version of= libf2c=0A> that lives in ports and is adopted by people who use=0A> fortra= n?=A0 The one that I find in the base system seems=0A> to be a similar matc= h to the one in ports/devel/f2c.=A0=0A> Is the one in the base system a pai= n to maintain or=0A> otherwise holding back other work, or has it been made= =0A> obsolete by something in ports?=A0 Is removing it from=0A> the base sy= stem anything more than just churn?=0A> =0A=0AI am a moderate user of Fortr= an: when I need it I use=0Agfortran instead of f2c. lang/f2c is in the port= s tree,=0Aand the one port I made (tochnog) that actually depends=0Aon libf= 2c uses the port, not the system library.=0A=0AConsidering we are not carry= ing fortran in base anymore,=0Ait would seem logical to kill libf2c, but it= must be said=0Athe f2c port originates in netlib, I have no idea where=0At= he GPL'd libf2c comes from or if there is any significant=0Adifference.=0A= =0Acheers,=0A=0APedro.=0A From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 15:43:58 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 490AB106566B; Mon, 18 Apr 2011 15:43:58 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id A7C918FC14; Mon, 18 Apr 2011 15:43:57 +0000 (UTC) Received: by wwc33 with SMTP id 33so5725696wwc.31 for ; Mon, 18 Apr 2011 08:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=H2rr3CkGIZValX7wugIOfywNw38XEN+kS7nTx8z6hIw=; b=pcLt3y12dkT6r5xoGfWltETwJoTDCBeHT6YRUk8vhcFFl9XZdP142mdsKanoxC1QNf 7oTEzNmErQFgNvSlz5OxD70qXGr2EoBATMFK4Kc/VxzXTVgVT8PNPj8aXvUleiUBHgRs p2nw5JARsOidcL+cbkFgGSf5Q7JzOpykhAF1o= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=kW0dlt9cPlR6A3GVPeEeqfYbb+E6Ldh1+XayyvPmNr2kUhFBjZR2vcLYMXOmHXZ+Oy u3U3X4zo2p2Z8D5lQex6dl06t5CaMdh93zH+rnoydHGnpBcsSFpLGRp/k6JyTEuTx2Fo a376lz5aea+0QhJJFcTPzHofkOWv0ctpjsSxQ= MIME-Version: 1.0 Received: by 10.216.141.225 with SMTP id g75mr5107339wej.10.1303141436570; Mon, 18 Apr 2011 08:43:56 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.216.9.67 with HTTP; Mon, 18 Apr 2011 08:43:56 -0700 (PDT) In-Reply-To: <201104180805.40743.jhb@freebsd.org> References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> Date: Mon, 18 Apr 2011 08:43:56 -0700 X-Google-Sender-Auth: nCRyZMIVTDqh9H4dLVn3952VBB0 Message-ID: From: mdf@FreeBSD.org To: John Baldwin Content-Type: multipart/mixed; boundary=0016e6dab06b6b3c5b04a133426d Cc: freebsd-current@freebsd.org, Nick Ulen Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 15:43:58 -0000 --0016e6dab06b6b3c5b04a133426d Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Mon, Apr 18, 2011 at 5:05 AM, John Baldwin wrote: > On Saturday, April 16, 2011 11:51:22 am Nick Ulen wrote: >> FreeBSD was successfully upgraded. >> >> uname -v >> FreeBSD 9.0-CURRENT #0: Mon Apr 11 18:14:36 MSD 2011 >> root@test:/usr/obj/usr/src/sys/GENERIC >> >> Everything seems to be working well except >> `hw.acpi.thermal.tz0.temperature' disappeared from the list of available >> sysctl variables. >> >> sysctl hw.acpi.thermal. >> >> hw.acpi.thermal.min_runtime: 0 >> hw.acpi.thermal.polling_rate: 10 >> hw.acpi.thermal.user_override: 0 >> hw.acpi.thermal.tz0.active: -1 >> hw.acpi.thermal.tz0.passive_cooling: 0 >> hw.acpi.thermal.tz0.thermal_flags: 0 >> hw.acpi.thermal.tz0._PSV: -1 >> hw.acpi.thermal.tz0._HOT: -1 >> hw.acpi.thermal.tz0._CRT: 90.0C >> hw.acpi.thermal.tz0._TC1: -1 >> hw.acpi.thermal.tz0._TC2: -1 >> hw.acpi.thermal.tz0._TSP: -1 >> >> output from: >> =A0sysctl -a |grep acpi >> is here: https://privatepaste.com/ca08d4658b > > I suspect it is still there, but sysctl doesn't know how to display it > anymore. =A0This is probably due to the changes with formatting of sysctl > information. =A0mdf@ is probably responsible in that case. > > =A0 =A0SYSCTL_ADD_OPAQUE(&sc->tz_sysctl_ctx, SYSCTL_CHILDREN(sc->tz_sysct= l_tree), > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0OID_AUTO, "temperature", CTLFL= AG_RD, &sc->tz_temperature, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sizeof(sc->tz_temperature), "I= K", > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"current thermal zone temperat= ure"); I don't seem to have a hw.acpi.thermal sysctl node on my box. Can someone please try this patch? Thanks, matthew --0016e6dab06b6b3c5b04a133426d Content-Type: text/x-patch; charset=US-ASCII; name="bsd-temperature.diff" Content-Disposition: attachment; filename="bsd-temperature.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gmnkq3ie0 ZGlmZiAtLWdpdCBhL3N5cy9kZXYvYWNwaWNhL2FjcGlfdGhlcm1hbC5jIGIvc3lzL2Rldi9hY3Bp Y2EvYWNwaV90aGVybWFsLmMKaW5kZXggNTE1YTc0Mi4uYjY0ZDhkZiAxMDA2NDQKLS0tIGEvc3lz L2Rldi9hY3BpY2EvYWNwaV90aGVybWFsLmMKKysrIGIvc3lzL2Rldi9hY3BpY2EvYWNwaV90aGVy bWFsLmMKQEAgLTI1NywxMCArMjU3LDEwIEBAIGFjcGlfdHpfYXR0YWNoKGRldmljZV90IGRldikK ICAgICBzYy0+dHpfc3lzY3RsX3RyZWUgPSBTWVNDVExfQUREX05PREUoJnNjLT50el9zeXNjdGxf Y3R4LAogCQkJCQkgU1lTQ1RMX0NISUxEUkVOKGFjcGlfdHpfc3lzY3RsX3RyZWUpLAogCQkJCQkg T0lEX0FVVE8sIG9pZG5hbWUsIENUTEZMQUdfUkQsIDAsICIiKTsKLSAgICBTWVNDVExfQUREX09Q QVFVRSgmc2MtPnR6X3N5c2N0bF9jdHgsIFNZU0NUTF9DSElMRFJFTihzYy0+dHpfc3lzY3RsX3Ry ZWUpLAotCQkgICAgICBPSURfQVVUTywgInRlbXBlcmF0dXJlIiwgQ1RMRkxBR19SRCwgJnNjLT50 el90ZW1wZXJhdHVyZSwKLQkJICAgICAgc2l6ZW9mKHNjLT50el90ZW1wZXJhdHVyZSksICJJSyIs Ci0JCSAgICAgICJjdXJyZW50IHRoZXJtYWwgem9uZSB0ZW1wZXJhdHVyZSIpOworICAgIFNZU0NU TF9BRERfUFJPQygmc2MtPnR6X3N5c2N0bF9jdHgsIFNZU0NUTF9DSElMRFJFTihzYy0+dHpfc3lz Y3RsX3RyZWUpLAorCQkgICAgT0lEX0FVVE8sICJ0ZW1wZXJhdHVyZSIsIENUTFRZUEVfSU5UIHwg Q1RMRkxBR19SRCwKKwkJICAgICZzYy0+dHpfdGVtcGVyYXR1cmUsIDAsIHN5c2N0bF9oYW5kbGVf aW50LAorCQkgICAgIklLIiwgImN1cnJlbnQgdGhlcm1hbCB6b25lIHRlbXBlcmF0dXJlIik7CiAg ICAgU1lTQ1RMX0FERF9QUk9DKCZzYy0+dHpfc3lzY3RsX2N0eCwgU1lTQ1RMX0NISUxEUkVOKHNj LT50el9zeXNjdGxfdHJlZSksCiAJCSAgICBPSURfQVVUTywgImFjdGl2ZSIsIENUTFRZUEVfSU5U IHwgQ1RMRkxBR19SVywKIAkJICAgIHNjLCAwLCBhY3BpX3R6X2FjdGl2ZV9zeXNjdGwsICJJIiwg ImNvb2xpbmcgaXMgYWN0aXZlIik7CkBAIC0yODYsOSArMjg2LDkgQEAgYWNwaV90el9hdHRhY2go ZGV2aWNlX3QgZGV2KQogCQkgICAgc2MsIG9mZnNldG9mKHN0cnVjdCBhY3BpX3R6X3NvZnRjLCB0 el96b25lLmNydCksCiAJCSAgICBhY3BpX3R6X3RlbXBfc3lzY3RsLCAiSUsiLAogCQkgICAgImNy aXRpY2FsIHRlbXAgc2V0cG9pbnQgKHNodXRkb3duIG5vdykiKTsKLSAgICBTWVNDVExfQUREX09Q QVFVRSgmc2MtPnR6X3N5c2N0bF9jdHgsIFNZU0NUTF9DSElMRFJFTihzYy0+dHpfc3lzY3RsX3Ry ZWUpLAotCQkgICAgICBPSURfQVVUTywgIl9BQ3giLCBDVExGTEFHX1JELCAmc2MtPnR6X3pvbmUu YWMsCi0JCSAgICAgIHNpemVvZihzYy0+dHpfem9uZS5hYyksICJJSyIsICIiKTsKKyAgICBTWVND VExfQUREX1BST0MoJnNjLT50el9zeXNjdGxfY3R4LCBTWVNDVExfQ0hJTERSRU4oc2MtPnR6X3N5 c2N0bF90cmVlKSwKKwkJICAgIE9JRF9BVVRPLCAiX0FDeCIsIENUTFRZUEVfSU5UIHwgQ1RMRkxB R19SRCwKKwkJICAgICZzYy0+dHpfem9uZS5hYywgMCwgc3lzY3RsX2hhbmRsZV9pbnQsICJJSyIs ICIiKTsKICAgICBTWVNDVExfQUREX1BST0MoJnNjLT50el9zeXNjdGxfY3R4LCBTWVNDVExfQ0hJ TERSRU4oc2MtPnR6X3N5c2N0bF90cmVlKSwKIAkJICAgIE9JRF9BVVRPLCAiX1RDMSIsIENUTFRZ UEVfSU5UIHwgQ1RMRkxBR19SVywKIAkJICAgIHNjLCBvZmZzZXRvZihzdHJ1Y3QgYWNwaV90el9z b2Z0YywgdHpfem9uZS50YzEpLAo= --0016e6dab06b6b3c5b04a133426d-- From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 15:47:35 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E896106566B for ; Mon, 18 Apr 2011 15:47:35 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id ED98B8FC0A for ; Mon, 18 Apr 2011 15:47:34 +0000 (UTC) Received: by vxc34 with SMTP id 34so4652121vxc.13 for ; Mon, 18 Apr 2011 08:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:in-reply-to :references:x-mailer:mime-version:content-type; bh=r7JRlXEPNeVClV360V0RhAxI/OpykSTp4wVJ/htot+Y=; b=yC8lzGNX94IZypnW2fp0HfqfV2mEo7/fNAfEnJcG/XFdTjjjzjz99oX0rCjldeZzTB DwaYqKoQzf2THhs2UgItd7FW1pwVwpeHf3QG7V0obTJ464QG7Hx+Oj01LYzmtSfzGt9H htDQwO14PE9nGRiD5Uumzyf2usRYhzwBL7xCE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=vwQ696UUYEulddA7Y13Ewi/Bs/Eb7opA7Bmp86Ex1a0u+bH+kBdZu3ydi+cQmxjhn2 kjHEYCiU1hbcht1+gwuzum5GkOBj6X9PtxXpWQ+oVgZysYRbzD6vO0kboFml9FiB92u1 MoxS7iw5s98Rlaie/X98kCi6Z8UtNUeSE6cIg= Received: by 10.52.0.228 with SMTP id 4mr7603989vdh.107.1303141654028; Mon, 18 Apr 2011 08:47:34 -0700 (PDT) Received: from kan.dnsalias.net (c-24-63-226-98.hsd1.ma.comcast.net [24.63.226.98]) by mx.google.com with ESMTPS id ck17sm219527vdb.16.2011.04.18.08.47.32 (version=SSLv3 cipher=OTHER); Mon, 18 Apr 2011 08:47:32 -0700 (PDT) Date: Mon, 18 Apr 2011 11:47:26 -0400 From: Alexander Kabaev To: giffunip@tutopia.com Message-ID: <20110418114726.26ceeef2@kan.dnsalias.net> In-Reply-To: <463183.28445.qm@web113513.mail.gq1.yahoo.com> References: <463183.28445.qm@web113513.mail.gq1.yahoo.com> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.22.1; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/LbaLb=T_89wLX/a7=JtI/=0"; protocol="application/pgp-signature" Cc: freebsd-current@freebsd.org Subject: Re: HEADS UP: Removal of libobjc from the base system X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 15:47:35 -0000 --Sig_/LbaLb=T_89wLX/a7=JtI/=0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On Mon, 18 Apr 2011 06:37:10 -0700 (PDT) "Pedro F. Giffuni" wrote: >=20 > --- On Mon, 4/18/11, Scott Long wrote: > ... > > > Yeah it's too outdated to be of any use. > > >=20 > > > IMHO, you can axe libf2c too... > > >=20 > >=20 > > Honest question here, is there a newer version of libf2c > > that lives in ports and is adopted by people who use > > fortran?=9A The one that I find in the base system seems > > to be a similar match to the one in ports/devel/f2c.=9A > > Is the one in the base system a pain to maintain or > > otherwise holding back other work, or has it been made > > obsolete by something in ports?=9A Is removing it from > > the base system anything more than just churn? > >=20 >=20 > I am a moderate user of Fortran: when I need it I use > gfortran instead of f2c. lang/f2c is in the ports tree, > and the one port I made (tochnog) that actually depends > on libf2c uses the port, not the system library. >=20 > Considering we are not carrying fortran in base anymore, > it would seem logical to kill libf2c, but it must be said > the f2c port originates in netlib, I have no idea where > the GPL'd libf2c comes from or if there is any significant > difference. >=20 > cheers, >=20 > Pedro. > =20 We do not have f2c in tree and it was disconnected from the build even longer than that. --=20 Alexander Kabaev --Sig_/LbaLb=T_89wLX/a7=JtI/=0 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iD8DBQFNrF0TQ6z1jMm+XZYRAiG0AKCZVvptxdc9lhUQoDwioPWDaH+pwQCfcm+q e+iVubKYtfw3CUJH54WJ+ds= =T6L3 -----END PGP SIGNATURE----- --Sig_/LbaLb=T_89wLX/a7=JtI/=0-- From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 15:49:09 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD2CF106568B for ; Mon, 18 Apr 2011 15:49:09 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 6FA098FC26 for ; Mon, 18 Apr 2011 15:49:08 +0000 (UTC) Received: by wwc33 with SMTP id 33so5732190wwc.31 for ; Mon, 18 Apr 2011 08:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=oObQ9TqDtsdh/vWpnschMRERwdYgHsHBhU7a+R3uKhI=; b=pv7DzkWu0sGTGNsFWvyhd8+2I1dW1N3VknP6EmrHF6hxvueq4QYZezViV0m2MlZ0nd RFvv7BwmFSWUdDVBoTRAgjumOcYpkza+gJGni0puDqxh4/WVl1lT7N9cFOnT1F48PyTe 0xDf8keQqt4ONpmGhGkrdnriZ0ed2z4VzZ/f4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=xL8d5XEUHHWO1d013dtMMxak0FW696Z7LCYotJS1kr39yOA+PRgF7zA/4SQmYIF89T sKzHKCyhm1kGtDzq6rFRLIVjMinHn9lUhYixJEtQymiRxfwgB4F1dcrIaDUx+2ziCxu0 lfGWu0AX1B1cHQu3JfPgyL12Ghm+XLpCr5ZLg= MIME-Version: 1.0 Received: by 10.216.134.207 with SMTP id s57mr5069083wei.25.1303139864907; Mon, 18 Apr 2011 08:17:44 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.216.9.67 with HTTP; Mon, 18 Apr 2011 08:17:44 -0700 (PDT) In-Reply-To: <201104180805.40743.jhb@freebsd.org> References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> Date: Mon, 18 Apr 2011 08:17:44 -0700 X-Google-Sender-Auth: -nksYBbvEg6dX9Mj1PlrwWGqgvk Message-ID: From: mdf@FreeBSD.org To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, Nick Ulen Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 15:49:10 -0000 On Mon, Apr 18, 2011 at 5:05 AM, John Baldwin wrote: > On Saturday, April 16, 2011 11:51:22 am Nick Ulen wrote: >> FreeBSD was successfully upgraded. >> >> uname -v >> FreeBSD 9.0-CURRENT #0: Mon Apr 11 18:14:36 MSD 2011 >> root@test:/usr/obj/usr/src/sys/GENERIC >> >> Everything seems to be working well except >> `hw.acpi.thermal.tz0.temperature' disappeared from the list of available >> sysctl variables. >> >> sysctl hw.acpi.thermal. >> >> hw.acpi.thermal.min_runtime: 0 >> hw.acpi.thermal.polling_rate: 10 >> hw.acpi.thermal.user_override: 0 >> hw.acpi.thermal.tz0.active: -1 >> hw.acpi.thermal.tz0.passive_cooling: 0 >> hw.acpi.thermal.tz0.thermal_flags: 0 >> hw.acpi.thermal.tz0._PSV: -1 >> hw.acpi.thermal.tz0._HOT: -1 >> hw.acpi.thermal.tz0._CRT: 90.0C >> hw.acpi.thermal.tz0._TC1: -1 >> hw.acpi.thermal.tz0._TC2: -1 >> hw.acpi.thermal.tz0._TSP: -1 >> >> output from: >> =A0sysctl -a |grep acpi >> is here: https://privatepaste.com/ca08d4658b > > I suspect it is still there, but sysctl doesn't know how to display it > anymore. =A0This is probably due to the changes with formatting of sysctl > information. =A0mdf@ is probably responsible in that case. > > =A0 =A0SYSCTL_ADD_OPAQUE(&sc->tz_sysctl_ctx, SYSCTL_CHILDREN(sc->tz_sysct= l_tree), > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0OID_AUTO, "temperature", CTLFL= AG_RD, &sc->tz_temperature, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0sizeof(sc->tz_temperature), "I= K", > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"current thermal zone temperat= ure"); Oops, yes. The change in r217586 required the type to be set to CTLTYPE_INT to print as format IK. My grep of the source tree shows that acpi_thermal.c is the only affected source file that was using OPAQUE. I'm testing out the fix now. Thanks, matthew From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 16:12:16 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68BC81065670 for ; Mon, 18 Apr 2011 16:12:16 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 27DD68FC1D for ; Mon, 18 Apr 2011 16:12:15 +0000 (UTC) Received: from [127.0.0.1] (pooker.samsco.org [168.103.85.57]) (authenticated bits=0) by pooker.samsco.org (8.14.4/8.14.4) with ESMTP id p3IGCCbI059300; Mon, 18 Apr 2011 10:12:13 -0600 (MDT) (envelope-from scottl@samsco.org) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Scott Long In-Reply-To: <20110418114726.26ceeef2@kan.dnsalias.net> Date: Mon, 18 Apr 2011 10:12:12 -0600 Content-Transfer-Encoding: 7bit Message-Id: <8529F46F-CB05-4F34-B894-5F60097A1760@samsco.org> References: <463183.28445.qm@web113513.mail.gq1.yahoo.com> <20110418114726.26ceeef2@kan.dnsalias.net> To: Alexander Kabaev X-Mailer: Apple Mail (2.1084) X-Spam-Status: No, score=-50.0 required=3.8 tests=ALL_TRUSTED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.0 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on pooker.samsco.org Cc: giffunip@tutopia.com, freebsd-current@freebsd.org Subject: Re: HEADS UP: Removal of libobjc from the base system X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 16:12:16 -0000 On Apr 18, 2011, at 9:47 AM, Alexander Kabaev wrote: > On Mon, 18 Apr 2011 06:37:10 -0700 (PDT) > "Pedro F. Giffuni" wrote: > >> >> --- On Mon, 4/18/11, Scott Long wrote: >> ... >>>> Yeah it's too outdated to be of any use. >>>> >>>> IMHO, you can axe libf2c too... >>>> >>> >>> Honest question here, is there a newer version of libf2c >>> that lives in ports and is adopted by people who use >>> fortran? The one that I find in the base system seems >>> to be a similar match to the one in ports/devel/f2c. >>> Is the one in the base system a pain to maintain or >>> otherwise holding back other work, or has it been made >>> obsolete by something in ports? Is removing it from >>> the base system anything more than just churn? >>> >> >> I am a moderate user of Fortran: when I need it I use >> gfortran instead of f2c. lang/f2c is in the ports tree, >> and the one port I made (tochnog) that actually depends >> on libf2c uses the port, not the system library. >> >> Considering we are not carrying fortran in base anymore, >> it would seem logical to kill libf2c, but it must be said >> the f2c port originates in netlib, I have no idea where >> the GPL'd libf2c comes from or if there is any significant >> difference. >> >> cheers, >> >> Pedro. >> > > We do not have f2c in tree and it was disconnected from the build even > longer than that. > Guess I was looking on an old system, sorry for the noise. Scott From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 17:12:42 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 313DA1065673; Mon, 18 Apr 2011 17:12:42 +0000 (UTC) (envelope-from david@catwhisker.org) Received: from albert.catwhisker.org (m209-73.dsl.rawbw.com [198.144.209.73]) by mx1.freebsd.org (Postfix) with ESMTP id 06E648FC12; Mon, 18 Apr 2011 17:12:41 +0000 (UTC) Received: from albert.catwhisker.org (localhost [127.0.0.1]) by albert.catwhisker.org (8.14.4/8.14.4) with ESMTP id p3IGxAxK002495; Mon, 18 Apr 2011 09:59:10 -0700 (PDT) (envelope-from david@albert.catwhisker.org) Received: (from david@localhost) by albert.catwhisker.org (8.14.4/8.14.4/Submit) id p3IGxAD6002494; Mon, 18 Apr 2011 09:59:10 -0700 (PDT) (envelope-from david) Date: Mon, 18 Apr 2011 09:59:10 -0700 From: David Wolfskill To: mdf@freebsd.org Message-ID: <20110418165910.GB1553@albert.catwhisker.org> References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="i9LlY+UWpKt15+FH" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: freebsd-current@freebsd.org Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 17:12:42 -0000 --i9LlY+UWpKt15+FH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 18, 2011 at 08:43:56AM -0700, mdf@freebsd.org wrote: > .... > I don't seem to have a hw.acpi.thermal sysctl node on my box. Can > someone please try this patch? Well, no magic smoke leaked out when I tried it, and: FreeBSD 9.0-CURRENT #203 r220770M: Mon Apr 18 09:51:15 PDT 2011 d130(9.0-C)[2] sysctl hw.acpi.thermal hw.acpi.thermal.min_runtime: 0 hw.acpi.thermal.polling_rate: 10 hw.acpi.thermal.user_override: 0 hw.acpi.thermal.tz0.temperature: 57.5C hw.acpi.thermal.tz0.active: -1 hw.acpi.thermal.tz0.passive_cooling: 0 hw.acpi.thermal.tz0.thermal_flags: 0 hw.acpi.thermal.tz0._PSV: -1 hw.acpi.thermal.tz0._HOT: -1 hw.acpi.thermal.tz0._CRT: 107.0C hw.acpi.thermal.tz0._ACx: -1 hw.acpi.thermal.tz0._TC1: -1 hw.acpi.thermal.tz0._TC2: -1 hw.acpi.thermal.tz0._TSP: -1 d130(9.0-C)[3]=20 So that seems fairly encouraging. :-) Peace, david --=20 David H. Wolfskill david@catwhisker.org Depriving a girl or boy of an opportunity for education is evil. See http://www.catwhisker.org/~david/publickey.gpg for my public key. --i9LlY+UWpKt15+FH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iEYEARECAAYFAk2sbd4ACgkQmprOCmdXAD2kdwCdEEnkxcCXnld018oBt8/MlFO+ 00MAn0iXgHPHKd78TgPA2nKDRaFFpui2 =/+jq -----END PGP SIGNATURE----- --i9LlY+UWpKt15+FH-- From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 19:47:04 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A19CF1065670; Mon, 18 Apr 2011 19:47:04 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id D4BA58FC14; Mon, 18 Apr 2011 19:47:03 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:adc5:19f9:a31a:3bcd] (unknown [IPv6:2001:7b8:3a7:0:adc5:19f9:a31a:3bcd]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id DD7FA5C59; Mon, 18 Apr 2011 21:47:02 +0200 (CEST) Message-ID: <4DAC9534.60009@FreeBSD.org> Date: Mon, 18 Apr 2011 21:47:00 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110415 Lanikai/3.1.11pre MIME-Version: 1.0 To: Alexander Kabaev References: <4DAC3FD9.1060603@FreeBSD.org> <20110418103416.76b07b36@kan.dnsalias.net> In-Reply-To: <20110418103416.76b07b36@kan.dnsalias.net> Content-Type: multipart/mixed; boundary="------------080709080509050705050302" Cc: "arch@freebsd.org" , "current@freebsd.org" Subject: Re: Removal of ICC (intel compiler) bits from mk X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 19:47:04 -0000 This is a multi-part message in MIME format. --------------080709080509050705050302 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 2011-04-18 16:34, Alexander Kabaev wrote: ... >> Please review the attached patch, which cleans up the ICC bits. > You probably also want to remove the code that uses __INTEL_COMPILER > in source tree if you want to be really thorough. Ok, new patch attached. Some of the contributed sources also contain instances of __INTEL_COMPILER, but these are all from upstream, so I left them in. --------------080709080509050705050302 Content-Type: text/plain; name="remove-icc-2.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="remove-icc-2.diff" diff --git a/include/stdbool.h b/include/stdbool.h index c0d6459..c0ce8bb 100644 --- a/include/stdbool.h +++ b/include/stdbool.h @@ -37,7 +37,7 @@ #define true 1 #define bool _Bool -#if __STDC_VERSION__ < 199901L && __GNUC__ < 3 && !defined(__INTEL_COMPILER) +#if __STDC_VERSION__ < 199901L && __GNUC__ < 3 typedef int _Bool; #endif diff --git a/include/stdlib.h b/include/stdlib.h index 3c48f17..c212cde 100644 --- a/include/stdlib.h +++ b/include/stdlib.h @@ -228,7 +228,7 @@ extern void (*_malloc_message)(const char *, const char *, const char *, * programs which use it will fail to link when compiled with non-GNU * compilers. */ -#if __GNUC__ >= 2 || defined(__INTEL_COMPILER) +#if __GNUC__ >= 2 #undef alloca /* some GNU bits try to get cute and define this on their own */ #define alloca(sz) __builtin_alloca(sz) #elif defined(lint) diff --git a/lib/msun/src/math.h b/lib/msun/src/math.h index 8ad13ed..8c229e5 100644 --- a/lib/msun/src/math.h +++ b/lib/msun/src/math.h @@ -34,11 +34,11 @@ extern const union __nan_un { float __uf; } __nan; -#if __GNUC_PREREQ__(3, 3) || (defined(__INTEL_COMPILER) && __INTEL_COMPILER >= 800) +#if __GNUC_PREREQ__(3, 3) #define __MATH_BUILTIN_CONSTANTS #endif -#if __GNUC_PREREQ__(3, 0) && !defined(__INTEL_COMPILER) +#if __GNUC_PREREQ__(3, 0) #define __MATH_BUILTIN_RELOPS #endif diff --git a/share/mk/bsd.cpu.mk b/share/mk/bsd.cpu.mk index 99c28aa..0670bff 100644 --- a/share/mk/bsd.cpu.mk +++ b/share/mk/bsd.cpu.mk @@ -91,31 +91,6 @@ _CPUCFLAGS = -march=prescott . else _CPUCFLAGS = -march=${CPUTYPE} . endif # GCC on 'i386' -. if ${CPUTYPE} == "crusoe" -_ICC_CPUCFLAGS = -tpp6 -xiM -. elif ${CPUTYPE} == "athlon-mp" || ${CPUTYPE} == "athlon-xp" || \ - ${CPUTYPE} == "athlon-4" -_ICC_CPUCFLAGS = -tpp6 -xiMK -. elif ${CPUTYPE} == "athlon-tbird" || ${CPUTYPE} == "athlon" -_ICC_CPUCFLAGS = -tpp6 -xiM -. elif ${CPUTYPE} == "k6-3" || ${CPUTYPE} == "k6-2" || ${CPUTYPE} == "k6" -_ICC_CPUCFLAGS = -tpp6 -xi -. elif ${CPUTYPE} == "k5" -_ICC_CPUCFLAGS = -tpp5 -. elif ${CPUTYPE} == "pentium4" || ${CPUTYPE} == "pentium4m" -_ICC_CPUCFLAGS = -tpp7 -xiMKW -. elif ${CPUTYPE} == "pentium3" || ${CPUTYPE} == "pentium3m" || \ - ${CPUTYPE} == "pentium-m" -_ICC_CPUCFLAGS = -tpp6 -xiMK -. elif ${CPUTYPE} == "pentium2" || ${CPUTYPE} == "pentiumpro" -_ICC_CPUCFLAGS = -tpp6 -xiM -. elif ${CPUTYPE} == "pentium-mmx" -_ICC_CPUCFLAGS = -tpp5 -xM -. elif ${CPUTYPE} == "pentium" -_ICC_CPUCFLAGS = -tpp5 -. else -_ICC_CPUCFLAGS = -. endif # ICC on 'i386' . elif ${MACHINE_CPUARCH} == "amd64" _CPUCFLAGS = -march=${CPUTYPE} . elif ${MACHINE_CPUARCH} == "arm" @@ -242,9 +217,5 @@ CFLAGS += -G0 # NB: COPTFLAGS is handled in /usr/src/sys/conf/kern.pre.mk .if !defined(NO_CPU_CFLAGS) -. if ${CC} == "icc" -CFLAGS += ${_ICC_CPUCFLAGS} -. else CFLAGS += ${_CPUCFLAGS} -. endif .endif diff --git a/share/mk/bsd.dep.mk b/share/mk/bsd.dep.mk index 459a9c3..c452528 100644 --- a/share/mk/bsd.dep.mk +++ b/share/mk/bsd.dep.mk @@ -125,13 +125,8 @@ depend: beforedepend ${DEPENDFILE} afterdepend # Different types of sources are compiled with slightly different flags. # Split up the sources, and filter out headers and non-applicable flags. -.if ${CC:T:Micc} == "icc" -MKDEP_CFLAGS= ${CFLAGS:M-X*} ${CFLAGS:M-[BIDU]*} -MKDEP_CXXFLAGS= ${CXXFLAGS:M-X*} ${CXXFLAGS:M-[BIDU]*} -.else MKDEP_CFLAGS= ${CFLAGS:M-nostdinc*} ${CFLAGS:M-[BIDU]*} MKDEP_CXXFLAGS= ${CXXFLAGS:M-nostdinc*} ${CXXFLAGS:M-[BIDU]*} -.endif DPSRCS+= ${SRCS} ${DEPENDFILE}: ${DPSRCS} diff --git a/share/mk/bsd.lib.mk b/share/mk/bsd.lib.mk index 9d655b6..943010c 100644 --- a/share/mk/bsd.lib.mk +++ b/share/mk/bsd.lib.mk @@ -65,11 +65,7 @@ PICFLAG=-fpic .endif .endif -.if ${CC:T:Micc} == "icc" -PO_FLAG=-p -.else PO_FLAG=-pg -.endif .c.po: ${CC} ${PO_FLAG} ${PO_CFLAGS} -c ${.IMPSRC} -o ${.TARGET} diff --git a/share/mk/bsd.sys.mk b/share/mk/bsd.sys.mk index fc5ec40..796d169 100644 --- a/share/mk/bsd.sys.mk +++ b/share/mk/bsd.sys.mk @@ -11,20 +11,18 @@ # the default is gnu99 for now CSTD ?= gnu99 -.if ${CC:T:Micc} != "icc" -. if ${CSTD} == "k&r" +.if ${CSTD} == "k&r" CFLAGS += -traditional -. elif ${CSTD} == "c89" || ${CSTD} == "c90" +.elif ${CSTD} == "c89" || ${CSTD} == "c90" CFLAGS += -std=iso9899:1990 -. elif ${CSTD} == "c94" || ${CSTD} == "c95" +.elif ${CSTD} == "c94" || ${CSTD} == "c95" CFLAGS += -std=iso9899:199409 -. elif ${CSTD} == "c99" +.elif ${CSTD} == "c99" CFLAGS += -std=iso9899:1999 -. else +.else CFLAGS += -std=${CSTD} -. endif .endif -.if !defined(NO_WARNS) && ${CC:T:Micc} != "icc" +.if !defined(NO_WARNS) # -pedantic is problematic because it also imposes namespace restrictions #CFLAGS += -pedantic . if defined(WARNS) @@ -82,9 +80,8 @@ CWARNFLAGS += -Wno-format CWARNFLAGS += -Wno-unknown-pragmas .endif -.if ${MK_SSP} != "no" && ${CC:T:Micc} != "icc" && \ - ${MACHINE_CPUARCH} != "ia64" && \ - ${MACHINE_CPUARCH} != "arm" && ${MACHINE_CPUARCH} != "mips" +.if ${MK_SSP} != "no" && ${MACHINE_CPUARCH} != "ia64" && \ + ${MACHINE_CPUARCH} != "arm" && ${MACHINE_CPUARCH} != "mips" # Don't use -Wstack-protector as it breaks world with -Werror. SSP_CFLAGS ?= -fstack-protector CFLAGS += ${SSP_CFLAGS} diff --git a/sys/conf/kern.mk b/sys/conf/kern.mk index 01b1438..1e58378 100644 --- a/sys/conf/kern.mk +++ b/sys/conf/kern.mk @@ -6,14 +6,9 @@ # Note that the newly added -Wcast-qual is responsible for generating # most of the remaining warnings. Warnings introduced with -Wall will # also pop up, but are easier to fix. -.if ${CC:T:Micc} == "icc" -#CWARNFLAGS= -w2 # use this if you are terribly bored -CWARNFLAGS= -.else CWARNFLAGS?= -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes \ -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual \ -Wundef -Wno-pointer-sign -fformat-extensions -.endif # # The following flags are next up for working on: # -W @@ -29,7 +24,7 @@ CWARNFLAGS?= -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes \ # operations inside the kernel itself. These operations are exclusively # reserved for user applications. # -.if ${MACHINE_CPUARCH} == "i386" && ${CC:T:Micc} != "icc" +.if ${MACHINE_CPUARCH} == "i386" .if ${CC:T:Mclang} != "clang" CFLAGS+= -mno-align-long-strings -mpreferred-stack-boundary=2 .endif @@ -100,22 +95,13 @@ INLINE_LIMIT?= 8000 # GCC 3.0 and above like to do certain optimizations based on the # assumption that the program is linked against libc. Stop this. # -.if ${CC:T:Micc} == "icc" -CFLAGS+= -nolib_inline -.else CFLAGS+= -ffreestanding -.endif - -.if ${CC:T:Micc} == "icc" -CFLAGS+= -restrict -.endif # # GCC SSP support. # -.if ${MK_SSP} != "no" && ${CC:T:Micc} != "icc" && \ - ${MACHINE_CPUARCH} != "ia64" && ${MACHINE_CPUARCH} != "arm" && \ - ${MACHINE_CPUARCH} != "mips" +.if ${MK_SSP} != "no" && ${MACHINE_CPUARCH} != "ia64" && \ + ${MACHINE_CPUARCH} != "arm" && ${MACHINE_CPUARCH} != "mips" CFLAGS+= -fstack-protector .endif diff --git a/sys/conf/kern.pre.mk b/sys/conf/kern.pre.mk index 4deaea8..db244c4 100644 --- a/sys/conf/kern.pre.mk +++ b/sys/conf/kern.pre.mk @@ -23,38 +23,25 @@ NM?= nm OBJCOPY?= objcopy SIZE?= size -.if ${CC:T:Micc} == "icc" -COPTFLAGS?= -O -.else -. if defined(DEBUG) +.if defined(DEBUG) _MINUS_O= -O CTFFLAGS+= -g -. else +.else _MINUS_O= -O2 -. endif -. if ${MACHINE_CPUARCH} == "amd64" +.endif +.if ${MACHINE_CPUARCH} == "amd64" COPTFLAGS?=-O2 -frename-registers -pipe -. else +.else COPTFLAGS?=${_MINUS_O} -pipe -. endif -. if !empty(COPTFLAGS:M-O[23s]) && empty(COPTFLAGS:M-fno-strict-aliasing) +.endif +.if !empty(COPTFLAGS:M-O[23s]) && empty(COPTFLAGS:M-fno-strict-aliasing) COPTFLAGS+= -fno-strict-aliasing -. endif .endif .if !defined(NO_CPU_COPTFLAGS) -. if ${CC:T:Micc} == "icc" -COPTFLAGS+= ${_ICC_CPUCFLAGS:C/(-x[^M^K^W]+)[MKW]+|-x[MKW]+/\1/} -. else COPTFLAGS+= ${_CPUCFLAGS} -. endif .endif -.if ${CC:T:Micc} == "icc" -C_DIALECT= -NOSTDINC= -X -.else C_DIALECT= -std=c99 NOSTDINC= -nostdinc -.endif INCLUDES= ${NOSTDINC} ${INCLMAGIC} -I. -I$S @@ -89,36 +76,31 @@ INCLUDES+= -I$S/dev/cxgb -I$S/dev/cxgbe CFLAGS= ${COPTFLAGS} ${C_DIALECT} ${DEBUG} ${CWARNFLAGS} CFLAGS+= ${INCLUDES} -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -.if ${CC:T:Micc} != "icc" .if ${CC:T:Mclang} != "clang" CFLAGS+= -fno-common -finline-limit=${INLINE_LIMIT} -.if ${MACHINE_CPUARCH} != "mips" +. if ${MACHINE_CPUARCH} != "mips" CFLAGS+= --param inline-unit-growth=100 CFLAGS+= --param large-function-growth=1000 -.else +. else # XXX Actually a gross hack just for Octeon because of the Simple Executive. CFLAGS+= --param inline-unit-growth=10000 CFLAGS+= --param large-function-growth=100000 CFLAGS+= --param max-inline-insns-single=10000 -.endif +. endif .endif WERROR?= -Werror -.endif # XXX LOCORE means "don't declare C stuff" not "for locore.s". ASM_CFLAGS= -x assembler-with-cpp -DLOCORE ${CFLAGS} .if defined(PROFLEVEL) && ${PROFLEVEL} >= 1 -.if ${CC:T:Micc} == "icc" -.error "Profiling doesn't work with icc" -.endif CFLAGS+= -DGPROF -falign-functions=16 -.if ${PROFLEVEL} >= 2 +. if ${PROFLEVEL} >= 2 CFLAGS+= -DGPROF4 -DGUPROF PROF= -pg -mprofiler-epilogue -.else +. else PROF= -pg -.endif +. endif .endif DEFINED_PROF= ${PROF} diff --git a/sys/conf/kmod.mk b/sys/conf/kmod.mk index 2239d66..6d22e41 100644 --- a/sys/conf/kmod.mk +++ b/sys/conf/kmod.mk @@ -88,25 +88,17 @@ __KLD_SHARED=yes __KLD_SHARED=no .endif -.if ${CC:T:Micc} == "icc" -CFLAGS:= ${CFLAGS:C/(-x[^M^K^W]+)[MKW]+|-x[MKW]+/\1/} -.else -. if !empty(CFLAGS:M-O[23s]) && empty(CFLAGS:M-fno-strict-aliasing) +.if !empty(CFLAGS:M-O[23s]) && empty(CFLAGS:M-fno-strict-aliasing) CFLAGS+= -fno-strict-aliasing -. endif +.endif WERROR?= -Werror -.endif CFLAGS+= ${WERROR} CFLAGS+= -D_KERNEL CFLAGS+= -DKLD_MODULE # Don't use any standard or source-relative include directories. -.if ${CC:T:Micc} == "icc" -NOSTDINC= -X -.else CSTD= c99 NOSTDINC= -nostdinc -.endif CFLAGS:= ${CFLAGS:N-I*} ${NOSTDINC} ${INCLMAGIC} ${CFLAGS:M-I*} .if defined(KERNBUILDDIR) CFLAGS+= -DHAVE_KERNEL_OPTION_HEADERS -include ${KERNBUILDDIR}/opt_global.h @@ -121,7 +113,7 @@ CFLAGS+= -I. -I@ # for example. CFLAGS+= -I@/contrib/altq -.if ${CC:T:Micc} != "icc" && ${CC:T:Mclang} != "clang" +.if ${CC:T:Mclang} != "clang" CFLAGS+= -finline-limit=${INLINE_LIMIT} CFLAGS+= --param inline-unit-growth=100 CFLAGS+= --param large-function-growth=1000 @@ -129,9 +121,7 @@ CFLAGS+= --param large-function-growth=1000 # Disallow common variables, and if we end up with commons from # somewhere unexpected, allocate storage for them in the module itself. -.if ${CC:T:Micc} != "icc" CFLAGS+= -fno-common -.endif LDFLAGS+= -d -warn-common CFLAGS+= ${DEBUG_FLAGS} diff --git a/sys/dev/aic7xxx/aicasm/Makefile b/sys/dev/aic7xxx/aicasm/Makefile index c077285..b8352d6 100644 --- a/sys/dev/aic7xxx/aicasm/Makefile +++ b/sys/dev/aic7xxx/aicasm/Makefile @@ -24,12 +24,7 @@ WARNS?= 5 DEPENDFILE= .depend_aicasm .endif -.if ${CC:T:Micc} == "icc" -CFLAGS+= -restrict -NOSTDINC= -X -.else NOSTDINC= -nostdinc -.endif CFLAGS+= ${NOSTDINC} -I/usr/include -I. .ifdef MAKESRCPATH CFLAGS+= -I${MAKESRCPATH} diff --git a/sys/i386/i386/in_cksum.c b/sys/i386/i386/in_cksum.c index c0e92d6..3984049 100644 --- a/sys/i386/i386/in_cksum.c +++ b/sys/i386/i386/in_cksum.c @@ -54,11 +54,7 @@ __FBSDID("$FreeBSD$"); #undef ADDCARRY #define ADDCARRY(x) if ((x) > 0xffff) (x) -= 0xffff -/* - * icc needs to be special cased here, as the asm code below results - * in broken code if compiled with icc. - */ -#if !defined(__GNUCLIKE_ASM) || defined(__INTEL_COMPILER) +#if !defined(__GNUCLIKE_ASM) /* non gcc parts stolen from sys/alpha/alpha/in_cksum.c */ #define REDUCE32 \ { \ @@ -75,7 +71,7 @@ __FBSDID("$FreeBSD$"); #endif #define REDUCE {sum = (sum & 0xffff) + (sum >> 16); ADDCARRY(sum);} -#if !defined(__GNUCLIKE_ASM) || defined(__INTEL_COMPILER) +#if !defined(__GNUCLIKE_ASM) static const u_int32_t in_masks[] = { /*0 bytes*/ /*1 byte*/ /*2 bytes*/ /*3 bytes*/ 0x00000000, 0x000000FF, 0x0000FFFF, 0x00FFFFFF, /* offset 0 */ diff --git a/sys/i386/include/in_cksum.h b/sys/i386/include/in_cksum.h index c692f69..35c6577 100644 --- a/sys/i386/include/in_cksum.h +++ b/sys/i386/include/in_cksum.h @@ -53,7 +53,7 @@ * in the normal case (where there are no options and the header length is * therefore always exactly five 32-bit words. */ -#if defined(__GNUCLIKE_ASM) && !defined(__INTEL_COMPILER) +#if defined(__GNUCLIKE_ASM) static __inline u_int in_cksum_hdr(const struct ip *ip) { @@ -131,7 +131,7 @@ in_pseudo(u_int sum, u_int b, u_int c) #endif #ifdef _KERNEL -#if !defined(__GNUCLIKE_ASM) || defined(__INTEL_COMPILER) +#if !defined(__GNUCLIKE_ASM) u_int in_cksum_hdr(const struct ip *ip); u_short in_addword(u_short sum, u_short b); u_short in_pseudo(u_int sum, u_int b, u_int c); diff --git a/sys/sys/cdefs.h b/sys/sys/cdefs.h index dbab329..15bcfe4 100644 --- a/sys/sys/cdefs.h +++ b/sys/sys/cdefs.h @@ -50,9 +50,9 @@ * having a compiler-agnostic source tree. */ -#if defined(__GNUC__) || defined(__INTEL_COMPILER) +#if defined(__GNUC__) -#if __GNUC__ >= 3 || defined(__INTEL_COMPILER) +#if __GNUC__ >= 3 #define __GNUCLIKE_ASM 3 #define __GNUCLIKE_MATH_BUILTIN_CONSTANTS #else @@ -62,17 +62,11 @@ #define __GNUCLIKE___OFFSETOF 1 #define __GNUCLIKE___SECTION 1 -#ifndef __INTEL_COMPILER -# define __GNUCLIKE_CTOR_SECTION_HANDLING 1 -#endif +#define __GNUCLIKE_CTOR_SECTION_HANDLING 1 #define __GNUCLIKE_BUILTIN_CONSTANT_P 1 -# if defined(__INTEL_COMPILER) && defined(__cplusplus) \ - && __INTEL_COMPILER < 800 -# undef __GNUCLIKE_BUILTIN_CONSTANT_P -# endif -#if (__GNUC_MINOR__ > 95 || __GNUC__ >= 3) && !defined(__INTEL_COMPILER) +#if __GNUC_MINOR__ > 95 || __GNUC__ >= 3 # define __GNUCLIKE_BUILTIN_VARARGS 1 # define __GNUCLIKE_BUILTIN_STDARG 1 # define __GNUCLIKE_BUILTIN_VAALIST 1 @@ -82,10 +76,8 @@ # define __GNUC_VA_LIST_COMPATIBILITY 1 #endif -#ifndef __INTEL_COMPILER -# define __GNUCLIKE_BUILTIN_NEXT_ARG 1 -# define __GNUCLIKE_MATH_BUILTIN_RELOPS -#endif +#define __GNUCLIKE_BUILTIN_NEXT_ARG 1 +#define __GNUCLIKE_MATH_BUILTIN_RELOPS #define __GNUCLIKE_BUILTIN_MEMCPY 1 @@ -101,12 +93,12 @@ #define __CC_SUPPORTS_DYNAMIC_ARRAY_INIT 1 -#endif /* __GNUC__ || __INTEL_COMPILER */ +#endif /* __GNUC__ */ /* * Macro to test if we're using a specific version of gcc or later. */ -#if defined(__GNUC__) && !defined(__INTEL_COMPILER) +#if defined(__GNUC__) #define __GNUC_PREREQ__(ma, mi) \ (__GNUC__ > (ma) || __GNUC__ == (ma) && __GNUC_MINOR__ >= (mi)) #else @@ -187,12 +179,12 @@ #define __aligned(x) #define __section(x) #else -#if !__GNUC_PREREQ__(2, 5) && !defined(__INTEL_COMPILER) +#if !__GNUC_PREREQ__(2, 5) #define __dead2 #define __pure2 #define __unused #endif -#if __GNUC__ == 2 && __GNUC_MINOR__ >= 5 && __GNUC_MINOR__ < 7 && !defined(__INTEL_COMPILER) +#if __GNUC__ == 2 && __GNUC_MINOR__ >= 5 && __GNUC_MINOR__ < 7 #define __dead2 __attribute__((__noreturn__)) #define __pure2 __attribute__((__const__)) #define __unused @@ -207,15 +199,6 @@ #define __aligned(x) __attribute__((__aligned__(x))) #define __section(x) __attribute__((__section__(x))) #endif -#if defined(__INTEL_COMPILER) -#define __dead2 __attribute__((__noreturn__)) -#define __pure2 __attribute__((__const__)) -#define __unused __attribute__((__unused__)) -#define __used __attribute__((__used__)) -#define __packed __attribute__((__packed__)) -#define __aligned(x) __attribute__((__aligned__(x))) -#define __section(x) __attribute__((__section__(x))) -#endif #endif #if __GNUC_PREREQ__(2, 96) @@ -226,7 +209,7 @@ #define __pure #endif -#if __GNUC_PREREQ__(3, 1) || (defined(__INTEL_COMPILER) && __INTEL_COMPILER >= 800) +#if __GNUC_PREREQ__(3, 1) #define __always_inline __attribute__((__always_inline__)) #else #define __always_inline @@ -245,11 +228,11 @@ #endif /* XXX: should use `#if __STDC_VERSION__ < 199901'. */ -#if !__GNUC_PREREQ__(2, 7) && !defined(__INTEL_COMPILER) +#if !__GNUC_PREREQ__(2, 7) #define __func__ NULL #endif -#if (defined(__INTEL_COMPILER) || (defined(__GNUC__) && __GNUC__ >= 2)) && !defined(__STRICT_ANSI__) || __STDC_VERSION__ >= 199901 +#if (defined(__GNUC__) && __GNUC__ >= 2) && !defined(__STRICT_ANSI__) || __STDC_VERSION__ >= 199901 #define __LONG_LONG_SUPPORTED #endif @@ -336,7 +319,7 @@ * that are known to support the features properly (old versions of gcc-2 * didn't permit keeping the keywords out of the application namespace). */ -#if !__GNUC_PREREQ__(2, 7) && !defined(__INTEL_COMPILER) +#if !__GNUC_PREREQ__(2, 7) #define __printflike(fmtarg, firstvararg) #define __scanflike(fmtarg, firstvararg) #define __format_arg(fmtarg) @@ -349,18 +332,16 @@ #endif /* Compiler-dependent macros that rely on FreeBSD-specific extensions. */ -#if __FreeBSD_cc_version >= 300001 && defined(__GNUC__) && !defined(__INTEL_COMPILER) +#if __FreeBSD_cc_version >= 300001 && defined(__GNUC__) #define __printf0like(fmtarg, firstvararg) \ __attribute__((__format__ (__printf0__, fmtarg, firstvararg))) #else #define __printf0like(fmtarg, firstvararg) #endif -#if defined(__GNUC__) || defined(__INTEL_COMPILER) -#ifndef __INTEL_COMPILER +#if defined(__GNUC__) #define __strong_reference(sym,aliassym) \ extern __typeof (sym) aliassym __attribute__ ((__alias__ (#sym))) -#endif #ifdef __STDC__ #define __weak_reference(sym,alias) \ __asm__(".weak " #alias); \ @@ -386,12 +367,12 @@ #define __sym_default(impl,sym,verid) \ __asm__(".symver impl, sym@@verid") #endif /* __STDC__ */ -#endif /* __GNUC__ || __INTEL_COMPILER */ +#endif /* __GNUC__ */ #define __GLOBL1(sym) __asm__(".globl " #sym) #define __GLOBL(sym) __GLOBL1(sym) -#if defined(__GNUC__) || defined(__INTEL_COMPILER) +#if defined(__GNUC__) #define __IDSTRING(name,string) __asm__(".ident\t\"" string "\"") #else /* diff --git a/usr.bin/csup/misc.h b/usr.bin/csup/misc.h index a7ca3a6..9303f4a 100644 --- a/usr.bin/csup/misc.h +++ b/usr.bin/csup/misc.h @@ -60,11 +60,8 @@ #undef __packed #define __packed __attribute__((__packed__)) -/* We explicitely don't define this with icc because it defines __GNUC__ - but doesn't support it. */ #undef __printflike -#if defined(__GNUC__) && !defined(__INTEL_COMPILER) && \ - (__GNUC__ > 2 || __GNUC__ == 2 && __GNUC__MINOR__ >= 7) +#if defined(__GNUC__) && (__GNUC__ > 2 || __GNUC__ == 2 && __GNUC__MINOR__ >= 7) #define __printflike(fmtarg, firstvararg) \ __attribute__((__format__ (__printf__, fmtarg, firstvararg))) #else --------------080709080509050705050302-- From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 20:01:40 2011 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09841106566B for ; Mon, 18 Apr 2011 20:01:40 +0000 (UTC) (envelope-from uqs@FreeBSD.org) Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by mx1.freebsd.org (Postfix) with ESMTP id 7F6BB8FC08 for ; Mon, 18 Apr 2011 20:01:39 +0000 (UTC) Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id p3IK1bwB088363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 18 Apr 2011 22:01:38 +0200 (CEST) (envelope-from uqs@FreeBSD.org) Date: Mon, 18 Apr 2011 22:01:37 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: current@FreeBSD.org Message-ID: <20110418200137.GK85668@acme.spoerlein.net> Mail-Followup-To: current@freebsd.org, Gordon Tetlow MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="gw4vLALk08fVJy3V" Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Gordon Tetlow Subject: RFC: let man(1) depend on users PATH? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 20:01:40 -0000 --gw4vLALk08fVJy3V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Greetings, the following patch is required to let man(1) continue to work if the user build WITHOUT_GROFF and has textproc/groff installed. I personally think relying on a sane $PATH while calling groff and co is ok to do. If there are good reasons against this, please speak your mind. The idea is to be able to switch back and forth between base/ports groff-suite without having to alter any configuration files. Cheers, Uli --gw4vLALk08fVJy3V Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="man_groff.diff" Content-Transfer-Encoding: 8bit commit 4f1cfe61ede418f795095c2d3c021db64c860e20 Author: Ulrich Spörlein Date: Sat Mar 12 12:40:21 2011 +0100 Let users' PATH decide which groff suite to pick up. Let groff pass the -c flag to grotty, which will turn off ANSI sequences. While these are not a problem for our more/less, they get mangled by col(1) and this will result in garbage output. This makes man(1) work together with textproc/groff, in case the user decided to delete the old groff from base (-DWITHOUT_GROFF). diff --git a/usr.bin/man/man.sh b/usr.bin/man/man.sh index 147ce58..58373a4 100755 --- a/usr.bin/man/man.sh +++ b/usr.bin/man/man.sh @@ -889,16 +889,18 @@ do_whatis() { search_whatis whatis "$@" } -EQN=/usr/bin/eqn +# User's PATH setting decides on the groff-suite to pick up. +EQN=eqn +NROFF='groff -P-c -Wall -mtty-char -man' +PIC=pic +REFER=refer +TBL=tbl +TROFF='groff -P-c -man' +VGRIND=vgrind + COL=/usr/bin/col LOCALE=/usr/bin/locale -NROFF='/usr/bin/groff -S -Wall -mtty-char -man' -PIC=/usr/bin/pic SYSCTL=/sbin/sysctl -TBL=/usr/bin/tbl -TROFF='/usr/bin/groff -S -man' -REFER=/usr/bin/refer -VGRIND=/usr/bin/vgrind debug=0 man_default_sections='1:1aout:8:2:3:n:4:5:6:7:9:l' --gw4vLALk08fVJy3V-- From owner-freebsd-current@FreeBSD.ORG Mon Apr 18 22:30:08 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 664DD1065670 for ; Mon, 18 Apr 2011 22:30:08 +0000 (UTC) (envelope-from giffunip@tutopia.com) Received: from nm15-vm0.bullet.mail.ne1.yahoo.com (nm15-vm0.bullet.mail.ne1.yahoo.com [98.138.91.70]) by mx1.freebsd.org (Postfix) with SMTP id EECAF8FC1E for ; Mon, 18 Apr 2011 22:30:07 +0000 (UTC) Received: from [98.138.90.55] by nm15.bullet.mail.ne1.yahoo.com with NNFMP; 18 Apr 2011 22:17:22 -0000 Received: from [98.138.89.170] by tm8.bullet.mail.ne1.yahoo.com with NNFMP; 18 Apr 2011 22:17:21 -0000 Received: from [127.0.0.1] by omp1026.mail.ne1.yahoo.com with NNFMP; 18 Apr 2011 22:17:21 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 976806.97151.bm@omp1026.mail.ne1.yahoo.com Received: (qmail 8614 invoked by uid 60001); 18 Apr 2011 22:17:21 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1303165041; bh=53LgDrO7idfk7uSmrNCI0UFhTq1v2PBo/650TiXXayw=; h=Message-ID:X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=lKE20pagIpjEO76qlBdRPapb7GSI6KY+PF/TcUHNZhGhWtJutMX/kecBHAgSHcfw24PxttDq0SzgpPTKRjU/6bmJwW2t1IKSOxi+hWPJ6LRdlLonISsUTDRESov9MLKL7AnMey3+WS8W6hxsouWwuSyXdepJi4cL5QIwOLMje1g= Message-ID: <500520.88810.qm@web113504.mail.gq1.yahoo.com> X-YMail-OSG: otRayrwVM1mITD1ovxjmGKzlWf2Jc_Yc5N8hu5zkmIAZo1N 7YxUoSlepKKaQvlY8HnFuP47Rk0g6wCOYu4Gcmm1lHEWnJhrvcGfdsh4RMzM E5GFXuEHeB6iI3p9h0OiPWpk0sbpw9QaMS1ddN5RaLIHonmK1kCivpeDtf0y zv6PhG62fggow9plBfsz_IvCA6oovQzTJ.FaX7GsaiyNFvLJ4VtyXnWcqziK avqrvOrljrLSnE50nrFpz3tyw3sbCgiCTi9Er6IoZY43oPBVp22rF2ohlejv _oJ_KhHkGjxujhdn9qOMVNr1EUJOcbRej_Uq5UOqC6wzl8X4aGw.qoT9nf8L YlkpHTLI5dU.TX4DtyD4.aKydQ_lcBXmW6jfLpu5mWeXnFlC.Go39RBNQyG3 XdoAHJe7w68K9cLQ- Received: from [190.157.141.135] by web113504.mail.gq1.yahoo.com via HTTP; Mon, 18 Apr 2011 15:17:21 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailClassic/12.0.2 YahooMailWebService/0.8.109.295617 Date: Mon, 18 Apr 2011 15:17:21 -0700 (PDT) From: "Pedro F. Giffuni" To: Alexander Kabaev , Scott Long In-Reply-To: <8529F46F-CB05-4F34-B894-5F60097A1760@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailman-Approved-At: Mon, 18 Apr 2011 22:41:47 +0000 Cc: freebsd-current@freebsd.org Subject: Re: HEADS UP: Removal of libobjc from the base system X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: giffunip@tutopia.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2011 22:30:08 -0000 --- On Mon, 4/18/11, Scott Long wrote: ... > > > > We do not have f2c in tree and it was disconnected > from the build even > > longer than that. > > > > Guess I was looking on an old system, sorry for the noise. > > Scott > Ugh.. pointyhat is all mine please... It's still linked in the wiki, so I got confused: http://wiki.freebsd.org/ContribSoftware Pedro From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 08:29:07 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E66B2106564A; Tue, 19 Apr 2011 08:29:07 +0000 (UTC) (envelope-from uncle@devio.us) Received: from wolfman.devio.us (devious-1-pt.tunnel.tserv12.mia1.ipv6.he.net [IPv6:2001:470:4:2a5::2]) by mx1.freebsd.org (Postfix) with ESMTP id C03A28FC1B; Tue, 19 Apr 2011 08:29:06 +0000 (UTC) Received: by wolfman.devio.us (Postfix, from userid 3773) id 52B6E1A90C9; Tue, 19 Apr 2011 04:29:06 -0400 (EDT) Date: Tue, 19 Apr 2011 04:29:06 -0400 From: Nick Ulen To: mdf@FreeBSD.org Message-ID: <20110419082906.GA8125@wolfman.devio.us> References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Mailman-Approved-At: Tue, 19 Apr 2011 11:11:15 +0000 Cc: freebsd-current@freebsd.org Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 08:29:08 -0000 On Mon, Apr 18, 2011 at 08:43:56AM -0700, mdf@FreeBSD.org wrote: > On Mon, Apr 18, 2011 at 5:05 AM, John Baldwin wrote: > > > > I suspect it is still there, but sysctl doesn't know how to display it > > anymore. This is probably due to the changes with formatting of sysctl > > information. ?mdf@ is probably responsible in that case. > > I don't seem to have a hw.acpi.thermal sysctl node on my box. Can > someone please try this patch? This patch works. FreeBSD 9.0-CURRENT #1: Tue Apr 19 10:52:58 MSD 2011 # sysctl hw.acpi.thermal hw.acpi.thermal.min_runtime: 0 hw.acpi.thermal.polling_rate: 10 hw.acpi.thermal.user_override: 0 hw.acpi.thermal.tz0.temperature: 67.5C hw.acpi.thermal.tz0.active: -1 hw.acpi.thermal.tz0.passive_cooling: 0 hw.acpi.thermal.tz0.thermal_flags: 0 hw.acpi.thermal.tz0._PSV: -1 hw.acpi.thermal.tz0._HOT: -1 hw.acpi.thermal.tz0._CRT: 90.0C hw.acpi.thermal.tz0._ACx: -1 hw.acpi.thermal.tz0._TC1: -1 hw.acpi.thermal.tz0._TC2: -1 hw.acpi.thermal.tz0._TSP: -1 Thank you all of you! Regargs, Nick. From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 11:15:01 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29B9C1065672 for ; Tue, 19 Apr 2011 11:15:01 +0000 (UTC) (envelope-from brucec@muon.cran.org.uk) Received: from muon.cran.org.uk (muon.cran.org.uk [IPv6:2a01:348:0:15:5d59:5c40:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id E81FE8FC13 for ; Tue, 19 Apr 2011 11:15:00 +0000 (UTC) Received: by muon.cran.org.uk (Postfix, from userid 1001) id 494D9E61CB; Tue, 19 Apr 2011 12:15:00 +0100 (BST) Date: Tue, 19 Apr 2011 12:15:00 +0100 From: Bruce Cran To: freebsd-current@freebsd.org Message-ID: <20110419111500.GA16509@muon.cran.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Finding typos using codespell X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 11:15:01 -0000 There's a new tool that can be used to find spelling mistakes in code: codespell from http://www.politreco.com has already been used to find mistakes in both Linux and LLVM. I ran it on sys/ and it found lots of potential typos - the full diff (which I know does contain some incorrect changes) can be found at http://www.cran.org.uk/~brucec/freebsd/codespell_sys.diff . -- Bruce Cran From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 11:21:33 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D156C106566B; Tue, 19 Apr 2011 11:21:33 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 844E68FC15; Tue, 19 Apr 2011 11:21:33 +0000 (UTC) Received: from outgoing.leidinger.net (p5B1557F8.dip.t-dialin.net [91.21.87.248]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 648F6844015; Tue, 19 Apr 2011 13:21:18 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [IPv6:fd73:10c7:2053:1::2:102]) by outgoing.leidinger.net (Postfix) with ESMTP id 19ECA1CDF; Tue, 19 Apr 2011 13:21:15 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.13.8/Submit) id p3JBLEEB085729; Tue, 19 Apr 2011 13:21:14 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Tue, 19 Apr 2011 13:21:14 +0200 Message-ID: <20110419132114.43009vpwaeidet68@webmail.leidinger.net> Date: Tue, 19 Apr 2011 13:21:14 +0200 From: Alexander Leidinger To: Dimitry Andric References: <4DAC3FD9.1060603@FreeBSD.org> <20110418103416.76b07b36@kan.dnsalias.net> <4DAC9534.60009@FreeBSD.org> In-Reply-To: <4DAC9534.60009@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.6) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 648F6844015.AE694 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=0, required 6, autolearn=disabled) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1303816878.61879@3G7XlhemNpacWYtsV3GnLA X-EBL-Spam-Status: No Cc: "arch@freebsd.org" , "current@freebsd.org" Subject: Re: Removal of ICC (intel compiler) bits from mk X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 11:21:33 -0000 Quoting Dimitry Andric (from Mon, 18 Apr 2011 21:47:00 +0200): > On 2011-04-18 16:34, Alexander Kabaev wrote: > ... >>> Please review the attached patch, which cleans up the ICC bits. >> You probably also want to remove the code that uses __INTEL_COMPILER >> in source tree if you want to be really thorough. > > Ok, new patch attached. Some of the contributed sources also contain > instances of __INTEL_COMPILER, but these are all from upstream, so I > left them in. Is it really necessary to remove them from cdefs.h? If someone takes parts of our source and wants to compile them on linux or windows with icc, the icc parts in cdefs.h are a valuable part to have. Info: AFAIR I didn't add icc stuff to csup, and AFAIR csup was added when our icc in the ports collection was outdated, so I assume someone tested csup with icc on linux and addid this stuff there. Removing it from csup seems to be a step backwards to me in this case. Regarding the build infrastructure part I just skimmed over it, and the math/std* headers and 1s-complement-checksum part looks ok to me. Bye, Alexander. -- Intel CPUs are not defective, they just act that way. -- Henry Spencer http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 12:22:12 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BCE1C106566C for ; Tue, 19 Apr 2011 12:22:12 +0000 (UTC) (envelope-from uqs@spoerlein.net) Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by mx1.freebsd.org (Postfix) with ESMTP id 5502D8FC18 for ; Tue, 19 Apr 2011 12:22:12 +0000 (UTC) Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id p3JCMAVb038009 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Apr 2011 14:22:10 +0200 (CEST) (envelope-from uqs@spoerlein.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net; s=dkim200908; t=1303215730; bh=mtprsyMes8xRZB1QM2i1TiAu0oR7Lg0+tN4+E4Y8IZ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=M5YWYAhTTkfWQThw+6uy98ZO918kz6hvEfiYxmAJGaZR2HavpqF0jTwwZC6Ul5pyG m7SgXUxnFZqyOenahX6sH+s9cdP88XwCnplmF27bMN9kZC8qOM5Hrzil9pOX6LJGez saGgn8CcIPKCX8VBt7B2yBSQCSO8XuWvZ6wus4c8= Date: Tue, 19 Apr 2011 14:22:10 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: Bruce Cran Message-ID: <20110419122210.GL85668@acme.spoerlein.net> Mail-Followup-To: Bruce Cran , freebsd-current@freebsd.org References: <20110419111500.GA16509@muon.cran.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110419111500.GA16509@muon.cran.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-current@freebsd.org Subject: Re: Finding typos using codespell X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 12:22:12 -0000 On Tue, 19.04.2011 at 12:15:00 +0100, Bruce Cran wrote: > There's a new tool that can be used to find spelling mistakes in code: codespell > from http://www.politreco.com has already been used to find mistakes in both > Linux and LLVM. I ran it on sys/ and it found lots of potential typos - the > full diff (which I know does contain some incorrect changes) can be found at > http://www.cran.org.uk/~brucec/freebsd/codespell_sys.diff . Needs manual review, but I think this is very useful for the spelling nazi challenged among us :-) False positive, e.g.: { - struct ccb_immed_notify *inot; + struct ccb_immed_notify *into; mpt_tgt_state_t *tgt; Cheers, Uli From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 12:40:01 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5DB48106564A for ; Tue, 19 Apr 2011 12:40:01 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id 22F288FC15 for ; Tue, 19 Apr 2011 12:40:01 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 859667300A; Tue, 19 Apr 2011 14:39:17 +0200 (CEST) Date: Tue, 19 Apr 2011 14:39:17 +0200 From: Luigi Rizzo To: Bruce Cran Message-ID: <20110419123917.GB35646@onelab2.iet.unipi.it> References: <20110419111500.GA16509@muon.cran.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110419111500.GA16509@muon.cran.org.uk> User-Agent: Mutt/1.4.2.3i Cc: freebsd-current@freebsd.org Subject: Re: Finding typos using codespell X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 12:40:01 -0000 On Tue, Apr 19, 2011 at 12:15:00PM +0100, Bruce Cran wrote: > There's a new tool that can be used to find spelling mistakes in code: codespell > from http://www.politreco.com has already been used to find mistakes in both > Linux and LLVM. I ran it on sys/ and it found lots of potential typos - the > full diff (which I know does contain some incorrect changes) can be found at > http://www.cran.org.uk/~brucec/freebsd/codespell_sys.diff . interesting :) it finds typos in comments, i guess, not code bugs ? cheers luigi From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 14:10:40 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF2AD106566B for ; Tue, 19 Apr 2011 14:10:40 +0000 (UTC) (envelope-from gpeskens85@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7A2648FC0A for ; Tue, 19 Apr 2011 14:10:40 +0000 (UTC) Received: by iwn33 with SMTP id 33so6423446iwn.13 for ; Tue, 19 Apr 2011 07:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type; bh=1a0cY9BmTRT0Hl12PTCb7KKy2uYVoKdonk7al+eTsqk=; b=q/RX61qQT1mBK2WQJ0/Gj18DsLzKxGHv+dISNmFfi9BxB4+OdMP2V72otFG/iD+zkU cLoyHNedcrFI0/V8u/VhS0toPZKTJBThyJQSCPMzrXH3tuW8i2M8r3k9VRojE/ryrJGt B/8FIPyzXvDMf/+Z4FXPvlBhd99klNmQBqC7s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=cK9+zKb9GFfvh1VvUNJUUDzY+W0CvgNfuY+TRwBRu7tx80tszVDRhGZQywRisnvybV 1dq/TvG/Hzod4ZSyK5nL02vBmHT87NczERIflhQl/jNCITufGXfpy4wjVbaTgMJ04D61 HojifV4wuRdVs+1/wCQkX/I46KfHqkkZlw8Xc= MIME-Version: 1.0 Received: by 10.231.187.165 with SMTP id cw37mr4757019ibb.88.1303220365955; Tue, 19 Apr 2011 06:39:25 -0700 (PDT) Received: by 10.231.207.5 with HTTP; Tue, 19 Apr 2011 06:39:25 -0700 (PDT) Date: Tue, 19 Apr 2011 15:39:25 +0200 Message-ID: From: Gijs Peskens To: freebsd-current@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: FreeBSD 9 Vimage and PF ? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 14:10:40 -0000 of course I know that Vimage is still very much experimental and still very much unfinished as well, but I would like to use it to try and set up a box where everything is seggregated into jails as much as possible, compiling the kernel with vimage support works like a charm and the system even boots up. But as soon as the PF module (for the jail host a absolute requirement) is loaded the system deadlocks. Are there any work arounds or patches in order to get it working and at least support PF in the jail host ? I looked around a lot and googled around a lot and found some patches (wich don't work for me unfortunately :/ ) But nothing really recent ? Gijs From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 14:48:20 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1DE64106564A; Tue, 19 Apr 2011 14:48:20 +0000 (UTC) (envelope-from taku@tackymt.homeip.net) Received: from basalt.tackymt.homeip.net (unknown [IPv6:2001:3e0:577:0:20d:61ff:fecc:2253]) by mx1.freebsd.org (Postfix) with ESMTP id 8DC408FC16; Tue, 19 Apr 2011 14:48:19 +0000 (UTC) Received: from basalt.tackymt.homeip.net (localhost [127.0.0.1]) by basalt.tackymt.homeip.net (Postfix) with ESMTP id 031631335D; Tue, 19 Apr 2011 23:48:18 +0900 (JST) X-Virus-Scanned: amavisd-new at tackymt.homeip.net Received: from localhost ([127.0.0.1]) by basalt.tackymt.homeip.net (basalt.tackymt.homeip.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dSzb6spSBCfN; Tue, 19 Apr 2011 23:48:15 +0900 (JST) Received: from basalt.tackymt.homeip.net (basalt.tackymt.homeip.net [IPv6:2001:3e0:577:0:20d:61ff:fecc:2253]) by basalt.tackymt.homeip.net (Postfix) with ESMTP; Tue, 19 Apr 2011 23:48:15 +0900 (JST) Date: Tue, 19 Apr 2011 23:48:15 +0900 From: Taku YAMAMOTO To: Nick Ulen Message-Id: <20110419234815.e2944dd5.taku@tackymt.homeip.net> In-Reply-To: <20110419082906.GA8125@wolfman.devio.us> References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> <20110419082906.GA8125@wolfman.devio.us> X-Mailer: Sylpheed 3.0.3 (GTK+ 2.22.1; i386-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: mdf@FreeBSD.org, freebsd-current@freebsd.org Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 14:48:20 -0000 > This patch works. > > FreeBSD 9.0-CURRENT #1: Tue Apr 19 10:52:58 MSD 2011 > > # sysctl hw.acpi.thermal > hw.acpi.thermal.min_runtime: 0 > hw.acpi.thermal.polling_rate: 10 > hw.acpi.thermal.user_override: 0 > hw.acpi.thermal.tz0.temperature: 67.5C > hw.acpi.thermal.tz0.active: -1 > hw.acpi.thermal.tz0.passive_cooling: 0 > hw.acpi.thermal.tz0.thermal_flags: 0 > hw.acpi.thermal.tz0._PSV: -1 > hw.acpi.thermal.tz0._HOT: -1 > hw.acpi.thermal.tz0._CRT: 90.0C > hw.acpi.thermal.tz0._ACx: -1 > hw.acpi.thermal.tz0._TC1: -1 > hw.acpi.thermal.tz0._TC2: -1 > hw.acpi.thermal.tz0._TSP: -1 We should have 10 _ACx values like this: hw.acpi.thermal.tz0._ACx: -1 -1 -1 -1 -1 -1 -1 -1 -1 -1 I haven't seen meaningful values these days, though. IMHO the BIOS writers don't rely on OSes being stable enough not to toast the core ;) -- -|-__ YAMAMOTO, Taku | __ < - A chicken is an egg's way of producing more eggs. - From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 14:58:51 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1F58106566C for ; Tue, 19 Apr 2011 14:58:51 +0000 (UTC) (envelope-from schmiedgen@gmx.net) Received: from mailout-de.gmx.net (mailout-de.gmx.net [213.165.64.23]) by mx1.freebsd.org (Postfix) with SMTP id 07C2D8FC14 for ; Tue, 19 Apr 2011 14:58:50 +0000 (UTC) Received: (qmail invoked by alias); 19 Apr 2011 14:32:08 -0000 Received: from business-213-023-190-146.static.arcor-ip.net (EHLO [192.168.10.5]) [213.23.190.146] by mail.gmx.net (mp025) with SMTP; 19 Apr 2011 16:32:08 +0200 X-Authenticated: #3631242 X-Provags-ID: V01U2FsdGVkX19GF61C53dGrw6aQomvb77vF0BhJLPc89+x2W+msu 7iZ/5CCxdi04U5 Message-ID: <4DAD9CE8.50000@gmx.net> Date: Tue, 19 Apr 2011 16:32:08 +0200 From: Michael Schmiedgen User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: freebsd-current@freebsd.org References: <20110419111500.GA16509@muon.cran.org.uk> In-Reply-To: <20110419111500.GA16509@muon.cran.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Subject: Re: Finding typos using codespell X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 14:58:51 -0000 On 19.04.2011 13:15, Bruce Cran wrote: > There's a new tool that can be used to find spelling mistakes in code: codespell > from http://www.politreco.com has already been used to find mistakes in both > Linux and LLVM. I ran it on sys/ and it found lots of potential typos - the > full diff (which I know does contain some incorrect changes) can be found at > http://www.cran.org.uk/~brucec/freebsd/codespell_sys.diff . Nice! But there are also some false positives in .uu files. Cheers, Michael From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 15:08:24 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 303741065674 for ; Tue, 19 Apr 2011 15:08:24 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe01.c2i.net [212.247.154.2]) by mx1.freebsd.org (Postfix) with ESMTP id B5A868FC15 for ; Tue, 19 Apr 2011 15:08:23 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.1 cv=Vlw5OJcoxCC473z5moizI40ESYe+BpcMN2hU0iQoJwI= c=1 sm=1 a=IU0TiZmyZPMA:10 a=WQU8e4WWZSUA:10 a=8nJEP1OIZ-IA:10 a=CL8lFSKtTFcA:10 a=i9M/sDlu2rpZ9XS819oYzg==:17 a=hLgvo10uAAAA:8 a=h7F_ZzWiAAAA:8 a=HMxKnLlVoz25TPqAb48A:9 a=wPNLvfGTeEIA:10 a=i9M/sDlu2rpZ9XS819oYzg==:117 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mailfe01.swip.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.1 X-TFF-CGPSA-Version: 1.7 X-T2-CGPSA-Filter: Scanned Received: from [188.126.198.129] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe01.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 116736321; Tue, 19 Apr 2011 17:08:19 +0200 From: Hans Petter Selasky To: freebsd-current@freebsd.org Date: Tue, 19 Apr 2011 17:07:19 +0200 User-Agent: KMail/1.13.5 (FreeBSD/8.2-PRERELEASE; KDE/4.4.5; amd64; ; ) References: <20110419111500.GA16509@muon.cran.org.uk> In-Reply-To: <20110419111500.GA16509@muon.cran.org.uk> X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5 %V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC( :AuzV9:.hESm-x4h240C`9=w MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201104191707.19855.hselasky@c2i.net> Cc: Bruce Cran Subject: Re: Finding typos using codespell X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 15:08:24 -0000 On Tuesday 19 April 2011 13:15:00 Bruce Cran wrote: > There's a new tool that can be used to find spelling mistakes in code: > codespell from http://www.politreco.com has already been used to find > mistakes in both Linux and LLVM. I ran it on sys/ and it found lots of > potential typos - the full diff (which I know does contain some incorrect > changes) can be found at > http://www.cran.org.uk/~brucec/freebsd/codespell_sys.diff . Changes in sys/dev/usb are OK, including the one in usbdevs --HPS From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 16:44:51 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A3FE3106564A for ; Tue, 19 Apr 2011 16:44:51 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 3201F8FC15 for ; Tue, 19 Apr 2011 16:44:50 +0000 (UTC) Received: by wwc33 with SMTP id 33so7059191wwc.31 for ; Tue, 19 Apr 2011 09:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=taw9G3CXTymXET+vtSMjn6l/oK8a2OIC5R9Il7f+Lys=; b=kXGruYgpVU3Ajredv00wUUvSoV1FEhS+CSiCBvE33Jr7H5v70IW+qrZDhgcHD0nL10 ZZdXbALw6lz5RRuDjZfaT7zpYIahAP3m/mC5CE+HCdrKo1BHllAw1W2i3EOAteW63nTs WCp3StInIu7p6HFRkGlrL7Y/5OYbWMB3i2Lb0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=IGlueGc3Q7TVSBdbO26hhVsmZ0IRmbu2pb0Xfg0Zd2z3cLxg4IlUqJk28+Kr+SAHAi VGuD6iCp1BVfSHc/Rmj1eVlhTldePK7/xU4UHq9MhGjL1JARgmoOyn/y4rpfJ1pc2wdf 3FnrDxo4MSrKmDdDNzlnA+mqk85InPcA9gECo= MIME-Version: 1.0 Received: by 10.216.120.144 with SMTP id p16mr1506560weh.10.1303231490116; Tue, 19 Apr 2011 09:44:50 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.216.9.67 with HTTP; Tue, 19 Apr 2011 09:44:50 -0700 (PDT) In-Reply-To: <20110419234815.e2944dd5.taku@tackymt.homeip.net> References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> <20110419082906.GA8125@wolfman.devio.us> <20110419234815.e2944dd5.taku@tackymt.homeip.net> Date: Tue, 19 Apr 2011 09:44:50 -0700 X-Google-Sender-Auth: ft9XhLbQB3-YUEXZ22RnNfNZFHM Message-ID: From: mdf@FreeBSD.org To: Taku YAMAMOTO Content-Type: multipart/mixed; boundary=00261883bac2074e6c04a1483ace Cc: freebsd-current@freebsd.org, Nick Ulen Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 16:44:51 -0000 --00261883bac2074e6c04a1483ace Content-Type: text/plain; charset=ISO-8859-1 On Tue, Apr 19, 2011 at 7:48 AM, Taku YAMAMOTO wrote: >> This patch works. >> >> FreeBSD 9.0-CURRENT #1: Tue Apr 19 10:52:58 MSD 2011 >> >> # sysctl hw.acpi.thermal >> hw.acpi.thermal.min_runtime: 0 >> hw.acpi.thermal.polling_rate: 10 >> hw.acpi.thermal.user_override: 0 >> hw.acpi.thermal.tz0.temperature: 67.5C >> hw.acpi.thermal.tz0.active: -1 >> hw.acpi.thermal.tz0.passive_cooling: 0 >> hw.acpi.thermal.tz0.thermal_flags: 0 >> hw.acpi.thermal.tz0._PSV: -1 >> hw.acpi.thermal.tz0._HOT: -1 >> hw.acpi.thermal.tz0._CRT: 90.0C >> hw.acpi.thermal.tz0._ACx: -1 >> hw.acpi.thermal.tz0._TC1: -1 >> hw.acpi.thermal.tz0._TC2: -1 >> hw.acpi.thermal.tz0._TSP: -1 > > We should have 10 _ACx values like this: > hw.acpi.thermal.tz0._ACx: -1 -1 -1 -1 -1 -1 -1 -1 -1 -1 D'oh, I didn't read the original source carefully enough. Can someone test this patch? As an aside, what kind of h/w do I need for hw.acpi.thermal to show up? I don't see it on my Dell desktop... Thanks, matthew --00261883bac2074e6c04a1483ace Content-Type: text/x-patch; charset=US-ASCII; name="bsd-temperature.diff" Content-Disposition: attachment; filename="bsd-temperature.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gmp2bu090 ZGlmZiAtLWdpdCBhL3N5cy9kZXYvYWNwaWNhL2FjcGlfdGhlcm1hbC5jIGIvc3lzL2Rldi9hY3Bp Y2EvYWNwaV90aGVybWFsLmMKaW5kZXggYjY0ZDhkZi4uNzIyNmI2YyAxMDA2NDQKLS0tIGEvc3lz L2Rldi9hY3BpY2EvYWNwaV90aGVybWFsLmMKKysrIGIvc3lzL2Rldi9hY3BpY2EvYWNwaV90aGVy bWFsLmMKQEAgLTI4OCw3ICsyODgsOCBAQCBhY3BpX3R6X2F0dGFjaChkZXZpY2VfdCBkZXYpCiAJ CSAgICAiY3JpdGljYWwgdGVtcCBzZXRwb2ludCAoc2h1dGRvd24gbm93KSIpOwogICAgIFNZU0NU TF9BRERfUFJPQygmc2MtPnR6X3N5c2N0bF9jdHgsIFNZU0NUTF9DSElMRFJFTihzYy0+dHpfc3lz Y3RsX3RyZWUpLAogCQkgICAgT0lEX0FVVE8sICJfQUN4IiwgQ1RMVFlQRV9JTlQgfCBDVExGTEFH X1JELAotCQkgICAgJnNjLT50el96b25lLmFjLCAwLCBzeXNjdGxfaGFuZGxlX2ludCwgIklLIiwg IiIpOworCQkgICAgJnNjLT50el96b25lLmFjLCBzaXplb2Yoc2MtPnR6X3pvbmUuYWMpLAorCQkg ICAgc3lzY3RsX2hhbmRsZV9vcGFxdWUsICJJSyIsICIiKTsKICAgICBTWVNDVExfQUREX1BST0Mo JnNjLT50el9zeXNjdGxfY3R4LCBTWVNDVExfQ0hJTERSRU4oc2MtPnR6X3N5c2N0bF90cmVlKSwK IAkJICAgIE9JRF9BVVRPLCAiX1RDMSIsIENUTFRZUEVfSU5UIHwgQ1RMRkxBR19SVywKIAkJICAg IHNjLCBvZmZzZXRvZihzdHJ1Y3QgYWNwaV90el9zb2Z0YywgdHpfem9uZS50YzEpLAo= --00261883bac2074e6c04a1483ace-- From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 16:53:56 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 35546106566C; Tue, 19 Apr 2011 16:53:56 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6F7748FC14; Tue, 19 Apr 2011 16:53:55 +0000 (UTC) Received: by ewy1 with SMTP id 1so2210701ewy.13 for ; Tue, 19 Apr 2011 09:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to:cc :content-type; bh=blpFMu7XZaAXA0fDHA7MTDmPrPuMXoBJWkPMjkh5DtA=; b=Wnvd00QLj9YaS1rHnxCL+VAttndMFIuEpLcALSNDO1ShbTlc2QD+goG2xv70jnOw4E Xyikdm2s/LGPe0gdMkyxb3cIDTj5I4eu/M8QwNVJ/ubHiFjoCGow6879Apr8ZKYpFr+f MWKjsB102uuncq+/TYVWLiZTwQOl27SQtlceA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; b=Tdl405cNWflHX+lyf7atqz0MIOM2ZOxgyFvyDx44vk+D3VOmFDrH5Qaw2d/f9l7c6F ad0VpdZ4pxR8wDMCApVSg47YYo0IfIvWkgF6A/CObV0FT3kv9PRWRW3x+cq0habXN97o Wbtttyu7/YtZpnkhniM4rx1F0jisbjRzonKsE= MIME-Version: 1.0 Received: by 10.213.113.205 with SMTP id b13mr4517030ebq.62.1303232034253; Tue, 19 Apr 2011 09:53:54 -0700 (PDT) Received: by 10.213.32.4 with HTTP; Tue, 19 Apr 2011 09:53:54 -0700 (PDT) Date: Tue, 19 Apr 2011 12:53:54 -0400 Message-ID: From: Ryan Stone To: FreeBSD Current Content-Type: text/plain; charset=ISO-8859-1 Cc: Ed Maste , davidxu@freebsd.org Subject: [PATCH] Call _thr_check_init() from _pthread_once X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 16:53:56 -0000 In r179417 the implementation of pthread_once in libthr was changed from using a global pthread_mutex_t for synchronization to rolling its own synchronization mechanism. Unfortunately, this introduced a bug. Calling _pthread_mutex_lock implicitly ensured that _thr_check_init() had been called. In the current version, there is no such guarantee. This means that if your first call into libthr is pthread_once, your executable will segfault when it tries to access curthread. This patch resolves the issue for me: Index: lib/libthr/thread/thr_once.c =================================================================== --- lib/libthr/thread/thr_once.c (revision 220603) +++ lib/libthr/thread/thr_once.c (working copy) @@ -64,6 +64,8 @@ struct pthread *curthread; int state; + _thr_check_init(); + for (;;) { state = once_control->state; if (state == ONCE_DONE) If there are no objections I'll commit this soon. From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 17:51:51 2011 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 739EE106566B; Tue, 19 Apr 2011 17:51:51 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id 323978FC0C; Tue, 19 Apr 2011 17:51:51 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:7533:44c6:1935:7a72] (unknown [IPv6:2001:7b8:3a7:0:7533:44c6:1935:7a72]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 4CF035C59; Tue, 19 Apr 2011 19:51:49 +0200 (CEST) Message-ID: <4DADCBB4.8060301@FreeBSD.org> Date: Tue, 19 Apr 2011 19:51:48 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110415 Lanikai/3.1.11pre MIME-Version: 1.0 To: Alexander Leidinger References: <4DAC3FD9.1060603@FreeBSD.org> <20110418103416.76b07b36@kan.dnsalias.net> <4DAC9534.60009@FreeBSD.org> <20110419132114.43009vpwaeidet68@webmail.leidinger.net> In-Reply-To: <20110419132114.43009vpwaeidet68@webmail.leidinger.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "arch@freebsd.org" , "current@freebsd.org" Subject: Re: Removal of ICC (intel compiler) bits from mk X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 17:51:51 -0000 On 2011-04-19 13:21, Alexander Leidinger wrote: ... >>> You probably also want to remove the code that uses __INTEL_COMPILER >>> in source tree if you want to be really thorough. >> >> Ok, new patch attached. Some of the contributed sources also contain >> instances of __INTEL_COMPILER, but these are all from upstream, so I >> left them in. > > Is it really necessary to remove them from cdefs.h? If someone takes > parts of our source and wants to compile them on linux or windows with > icc, the icc parts in cdefs.h are a valuable part to have. Isn't that the case for the other headers too? Except the in_cksum.[ch] files, where the 'fix' for ICC is apparently not needed at all anymore. > Info: AFAIR I didn't add icc stuff to csup, and AFAIR csup was added > when our icc in the ports collection was outdated, so I assume someone > tested csup with icc on linux and addid this stuff there. Removing it > from csup seems to be a step backwards to me in this case. It used to be in contrib, but was moved to the base system recently. If csup is also ported to e.g. Linux, then it won't make much sense to remove the ICC ifdefs. > Regarding the build infrastructure part I just skimmed over it, and > the math/std* headers and 1s-complement-checksum part looks ok to me. For now, I will just commit the Makefile/*.mk part, and leave most headers as they are. From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 18:02:16 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 68CE7106566B; Tue, 19 Apr 2011 18:02:16 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id E2C811791A0; Tue, 19 Apr 2011 18:02:12 +0000 (UTC) Message-ID: <4DADCE20.6070306@FreeBSD.org> Date: Tue, 19 Apr 2011 11:02:08 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: mdf@FreeBSD.org References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> <20110419082906.GA8125@wolfman.devio.us> <20110419234815.e2944dd5.taku@tackymt.homeip.net> In-Reply-To: X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Taku YAMAMOTO , freebsd-current@freebsd.org, Nick Ulen Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 18:02:16 -0000 On 4/19/2011 9:44 AM, mdf@FreeBSD.org wrote: > As an aside, what kind of h/w do I need > for hw.acpi.thermal to show up? I don't see it on my Dell desktop... The hardware is likely to be there for any reasonably modern Dell desktop. Do you have coretemp loaded? Doug -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 18:18:26 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9163B1065692 for ; Tue, 19 Apr 2011 18:18:26 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id EBA5F8FC1E for ; Tue, 19 Apr 2011 18:18:25 +0000 (UTC) Received: by wyf23 with SMTP id 23so6176066wyf.13 for ; Tue, 19 Apr 2011 11:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=d5jcLGpd110Va7oPsNQZJ9GJ/gtHWdC2z8BZz0Wsykc=; b=JOymn3YHXiGhqckC5WKmEdbnjq79CHkruJLdFPNO9mJo2Imxu4TIPHAbexZTOGtxT3 abuMigXhl6GBnqr3Xgua/AvnVMqUhRB6Oca6kXhfAu3B238Tpbrf8IBNEHIFTHCQRrMF Yp/DoRx5QC5a2gBpxsb/fIpUWdbcTzVe55Ti0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=Novh8kF1whjWwZCoBJ+l74S5NUWwX+/GrlceZQxB7mMbV9A0aGL3IkjgnBxlaxTLwC ilkcPb4hq872oYHs4tLQroORf9vtBQatsYb5my48YF6ldtPwLJ3Zk611ooMXKrS+zhAs /onaVzO1OP4vZnusmITxrOeA7nTlMPw7l9PcA= MIME-Version: 1.0 Received: by 10.216.245.6 with SMTP id n6mr29522wer.40.1303237103868; Tue, 19 Apr 2011 11:18:23 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.216.9.67 with HTTP; Tue, 19 Apr 2011 11:18:23 -0700 (PDT) In-Reply-To: <4DADCE20.6070306@FreeBSD.org> References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> <20110419082906.GA8125@wolfman.devio.us> <20110419234815.e2944dd5.taku@tackymt.homeip.net> <4DADCE20.6070306@FreeBSD.org> Date: Tue, 19 Apr 2011 11:18:23 -0700 X-Google-Sender-Auth: Xosh5BDBIizL_7y7RMYpfEZuZJU Message-ID: From: mdf@FreeBSD.org To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Taku YAMAMOTO , freebsd-current@freebsd.org, Nick Ulen Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 18:18:26 -0000 On Tue, Apr 19, 2011 at 11:02 AM, Doug Barton wrote: > On 4/19/2011 9:44 AM, mdf@FreeBSD.org wrote: >> >> As an aside, what kind of h/w do I need >> for hw.acpi.thermal to show up? =A0I don't see it on my Dell desktop... > > The hardware is likely to be there for any reasonably modern Dell desktop= . > Do you have coretemp loaded? I didn't (I had assumed since the relevant sysctls are defined in acpi_thermal.c that having acpi was sufficient), so I just tried that, but still no hw.acpi.thermal node. Thanks, matthew From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 18:34:03 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 14F051065670 for ; Tue, 19 Apr 2011 18:34:03 +0000 (UTC) (envelope-from romain.garbage@gmail.com) Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 86F8A8FC0A for ; Tue, 19 Apr 2011 18:34:02 +0000 (UTC) Received: by qyk27 with SMTP id 27so3962951qyk.13 for ; Tue, 19 Apr 2011 11:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=0LEllmfQuDf7v2y6hyeA3DggPask+lvxO0qPpIkETJ8=; b=r8jwMRYQ4aSatXa0JvmZH0FhpwEvgQKFTf/utbvG2DjfzeDSNIOvLe0L3lpeQbEq8i 1rXlPxeKtVGjIDGFECB9naDm9eHnfzCW3jGT8kqBkIwg/ErfUFLFgIToMtL0JeBS9O5L REVNUgEQiZ3mUxRkIs0LSYvCEEY8oiMO7XmMg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Pqt6a3zvmnGBHliHqOZuH6J24xNznRJuSfc4EVsAX3ux43ddef1Uh6t81TXOQwjuL5 hzh31oJcBsKAjhTEZC1dwlasxMfI4vJEZjzZGVQowi9Ut5oLwQPXnCiDT+UK72wODTVU hufjNoe94G9UScA7OSBTUMImqg7+JLT59J704= MIME-Version: 1.0 Received: by 10.229.130.144 with SMTP id t16mr4753474qcs.146.1303238040768; Tue, 19 Apr 2011 11:34:00 -0700 (PDT) Received: by 10.229.110.17 with HTTP; Tue, 19 Apr 2011 11:34:00 -0700 (PDT) In-Reply-To: References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> <20110419082906.GA8125@wolfman.devio.us> <20110419234815.e2944dd5.taku@tackymt.homeip.net> <4DADCE20.6070306@FreeBSD.org> Date: Tue, 19 Apr 2011 20:34:00 +0200 Message-ID: From: Romain Garbage To: mdf@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Taku YAMAMOTO , Doug Barton , Nick Ulen , freebsd-current@freebsd.org Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 18:34:03 -0000 2011/4/19 : > On Tue, Apr 19, 2011 at 11:02 AM, Doug Barton wrote: >> On 4/19/2011 9:44 AM, mdf@FreeBSD.org wrote: >>> >>> As an aside, what kind of h/w do I need >>> for hw.acpi.thermal to show up? =C2=A0I don't see it on my Dell desktop= ... >> >> The hardware is likely to be there for any reasonably modern Dell deskto= p. >> Do you have coretemp loaded? > > I didn't (I had assumed since the relevant sysctls are defined in > acpi_thermal.c that having acpi was sufficient), so I just tried that, > but still no hw.acpi.thermal node. On 8.2-R I did have hw.acpi.thermal sysctl nodes by default, without loading coretemp. Actually, even in 9-CURRENT you don't need any special module for that (I don't think any loaded module is acpi related): $> uname -a FreeBSD freebsd-laptop 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r220730: Sun Apr 17 20:14:29 CEST 2011 root@freebsd-laptop:/usr/obj/usr/src/sys/GENERIC amd64 $> kldstat Id Refs Address Size Name 1 49 0xffffffff80200000 11dc048 kernel 2 1 0xffffffff813dd000 4248 fdescfs.ko 3 1 0xffffffff813e2000 b398 linprocfs.ko 4 4 0xffffffff813ee000 426a8 linux.ko 5 1 0xffffffff81431000 2c20 linsysfs.ko 6 1 0xffffffff81434000 209108 zfs.ko 7 2 0xffffffff8163e000 4b98 opensolaris.ko 8 1 0xffffffff81643000 29c58 snd_hda.ko 9 2 0xffffffff8166d000 84f70 sound.ko 11 1 0xffffffff816f5000 da6678 nvidia.ko 12 1 0xffffffff8249c000 6678 sem.ko 13 1 0xffffffff824a3000 4b620 vboxdrv.ko 14 1 0xffffffff824ef000 10f00 ahci.ko 15 1 0xffffffff82500000 15ce8 tmpfs.ko 16 1 0xffffffff82612000 a912 fuse.ko $> sysctl -a | grep thermal "Giant","ACPI thermal zone" hw.acpi.thermal.min_runtime: 0 hw.acpi.thermal.polling_rate: 10 hw.acpi.thermal.user_override: 0 hw.acpi.thermal.tz0.active: -1 hw.acpi.thermal.tz0.passive_cooling: 1 hw.acpi.thermal.tz0.thermal_flags: 0 hw.acpi.thermal.tz0._PSV: 105.0C hw.acpi.thermal.tz0._HOT: -1 hw.acpi.thermal.tz0._CRT: 110.0C hw.acpi.thermal.tz0._TC1: 2 hw.acpi.thermal.tz0._TC2: 10 hw.acpi.thermal.tz0._TSP: 100 What coretemp gives you is: $> sudo kldunload coretemp $> sysctl -N -a > without-coretemp $> sudo kldload coretemp $> sysctl -N -a > with-coretemp $> diff -u without-coretemp with-coretemp --- without-coretemp 2011-04-19 20:32:05.236218708 +0200 +++ with-coretemp 2011-04-19 20:32:15.543219179 +0200 @@ -1744,6 +1744,7 @@ dev.cpu.0.cx_supported dev.cpu.0.cx_lowest dev.cpu.0.cx_usage +dev.cpu.0.temperature dev.cpu.1.%desc dev.cpu.1.%driver dev.cpu.1.%location @@ -1752,6 +1753,7 @@ dev.cpu.1.cx_supported dev.cpu.1.cx_lowest dev.cpu.1.cx_usage +dev.cpu.1.temperature dev.pci_link.%parent dev.pci_link.0.%desc dev.pci_link.0.%driver @@ -2421,6 +2423,16 @@ dev.acpi_perf.1.%pnpinfo dev.acpi_perf.1.%parent dev.coretemp.%parent +dev.coretemp.0.%desc +dev.coretemp.0.%driver +dev.coretemp.0.%location +dev.coretemp.0.%pnpinfo +dev.coretemp.0.%parent +dev.coretemp.1.%desc +dev.coretemp.1.%driver +dev.coretemp.1.%location +dev.coretemp.1.%pnpinfo +dev.coretemp.1.%parent dev.est.%parent dev.est.0.%desc dev.est.0.%driver Regards, Romain From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 18:26:39 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 764C3106566B; Tue, 19 Apr 2011 18:26:39 +0000 (UTC) (envelope-from uncle@devio.us) Received: from wolfman.devio.us (devious-1-pt.tunnel.tserv12.mia1.ipv6.he.net [IPv6:2001:470:4:2a5::2]) by mx1.freebsd.org (Postfix) with ESMTP id 4D18E8FC1C; Tue, 19 Apr 2011 18:26:39 +0000 (UTC) Received: by wolfman.devio.us (Postfix, from userid 3773) id C6B8B1A90C6; Tue, 19 Apr 2011 14:26:38 -0400 (EDT) Date: Tue, 19 Apr 2011 14:26:38 -0400 From: Nick Ulen To: mdf@FreeBSD.org Message-ID: <20110419182638.GA20307@wolfman.devio.us> References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> <20110419082906.GA8125@wolfman.devio.us> <20110419234815.e2944dd5.taku@tackymt.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Mailman-Approved-At: Tue, 19 Apr 2011 18:58:59 +0000 Cc: freebsd-current@freebsd.org Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 18:26:39 -0000 On Tue, Apr 19, 2011 at 09:44:50AM -0700, mdf@FreeBSD.org wrote: > On Tue, Apr 19, 2011 at 7:48 AM, Taku YAMAMOTO > wrote: > >... > > We should have 10 _ACx values like this: > > hw.acpi.thermal.tz0._ACx: -1 -1 -1 -1 -1 -1 -1 -1 -1 -1 > > D'oh, I didn't read the original source carefully enough. > > Can someone test this patch? As an aside, what kind of h/w do I need > for hw.acpi.thermal to show up? I don't see it on my Dell desktop... Done: #sysctl hw.acpi.thermal hw.acpi.thermal.min_runtime: 0 hw.acpi.thermal.polling_rate: 10 hw.acpi.thermal.user_override: 0 hw.acpi.thermal.tz0.temperature: 78.5C hw.acpi.thermal.tz0.active: -1 hw.acpi.thermal.tz0.passive_cooling: 0 hw.acpi.thermal.tz0.thermal_flags: 0 hw.acpi.thermal.tz0._PSV: -1 hw.acpi.thermal.tz0._HOT: -1 hw.acpi.thermal.tz0._CRT: 90.0C hw.acpi.thermal.tz0._ACx: -1 -1 -1 -1 -1 -1 -1 -1 -1 -1 hw.acpi.thermal.tz0._TC1: -1 hw.acpi.thermal.tz0._TC2: -1 hw.acpi.thermal.tz0._TSP: -1 Regards, Nick From owner-freebsd-current@FreeBSD.ORG Tue Apr 19 21:25:05 2011 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B9191065672; Tue, 19 Apr 2011 21:25:05 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 5578C8FC0A; Tue, 19 Apr 2011 21:25:04 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id AAA09203; Wed, 20 Apr 2011 00:25:02 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1QCIPu-0009Tn-8K; Wed, 20 Apr 2011 00:25:02 +0300 Message-ID: <4DADFDAD.6000909@FreeBSD.org> Date: Wed, 20 Apr 2011 00:25:01 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110308 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: mdf@FreeBSD.org References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> <20110419082906.GA8125@wolfman.devio.us> <20110419234815.e2944dd5.taku@tackymt.homeip.net> <4DADCE20.6070306@FreeBSD.org> In-Reply-To: <4DADCE20.6070306@FreeBSD.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org, Doug Barton Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 21:25:05 -0000 on 19/04/2011 21:02 Doug Barton said the following: > On 4/19/2011 9:44 AM, mdf@FreeBSD.org wrote: >> As an aside, what kind of h/w do I need >> for hw.acpi.thermal to show up? I don't see it on my Dell desktop... The hardware can be anything with ACPI compatibility, but your DSDT has to [correctly] define TZ object. > The hardware is likely to be there for any reasonably modern Dell desktop. Do > you have coretemp loaded? I think that coretemp works directly with CPU and is not related to the problem at hand. -- Andriy Gapon From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 00:17:44 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4F97106566C for ; Wed, 20 Apr 2011 00:17:44 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 76AA08FC0A for ; Wed, 20 Apr 2011 00:17:44 +0000 (UTC) Received: by iwn33 with SMTP id 33so245002iwn.13 for ; Tue, 19 Apr 2011 17:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:x-openpgp-key-id:x-openpgp-key-fingerprint :x-openpgp-key-url; bh=EIpaFhbg1PrEij63+al4nAwoM4eD64xzmHHEF7QgBS0=; b=E32q0NPFlxlf0daxw+spXSmLuLLEPgZZdPsaKx6eC6RXd9BcVhkcjLQrPX3bN8iBRm 7n2JBOSjSOqQb3VXK4Kc6ojMthnuoRRTn8A2Czn5teWIJDy1MO3FC/4v8PJ3pbzJ18Rz Z86s6M712Lq/TCORTy+4UVqheJXx8KX8WSEFE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-openpgp-key-id :x-openpgp-key-fingerprint:x-openpgp-key-url; b=Vzy+ygscSPr5swOuJY9TW7ywKBdvsjHhYng4iFts5LGakrrv6QkMj/TohlFE0uCmbO peUTdWG2bCh95TMvBedd2AgAi6gWH0YkipLbpgZwz0rCPbynkEwhveri/u3e+LTUgKmI Vpult8DeOXkBY+LjDY6OOs3ZN4uo/58CVxfEw= Received: by 10.231.25.157 with SMTP id z29mr1497413ibb.129.1303258663775; Tue, 19 Apr 2011 17:17:43 -0700 (PDT) Received: from DataIX.net (adsl-99-190-84-116.dsl.klmzmi.sbcglobal.net [99.190.84.116]) by mx.google.com with ESMTPS id d9sm141282ibb.19.2011.04.19.17.17.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Apr 2011 17:17:42 -0700 (PDT) Sender: "J. Hellenthal" Received: from DataIX.net (localhost [127.0.0.1]) by DataIX.net (8.14.4/8.14.4) with ESMTP id p3K0Hcbv084874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Apr 2011 20:17:39 -0400 (EDT) (envelope-from jhell@DataIX.net) Received: (from jhell@localhost) by DataIX.net (8.14.4/8.14.4/Submit) id p3K0Hcfq084873; Tue, 19 Apr 2011 20:17:38 -0400 (EDT) (envelope-from jhell@DataIX.net) Date: Tue, 19 Apr 2011 20:17:37 -0400 From: "J. Hellenthal" To: Bruce Cran , freebsd-current@freebsd.org Message-ID: <20110420001737.GE2483@DataIX.net> References: <20110419111500.GA16509@muon.cran.org.uk> <20110419122210.GL85668@acme.spoerlein.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XStn23h1fwudRqtG" Content-Disposition: inline In-Reply-To: <20110419122210.GL85668@acme.spoerlein.net> X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E X-OpenPGP-Key-URL: http://bit.ly/0x89D8547E Cc: Subject: Re: Finding typos using codespell X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 00:17:44 -0000 --XStn23h1fwudRqtG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 19, 2011 at 02:22:10PM +0200, Ulrich Sp=F6rlein wrote: >On Tue, 19.04.2011 at 12:15:00 +0100, Bruce Cran wrote: >> There's a new tool that can be used to find spelling mistakes in code: c= odespell=20 >> from http://www.politreco.com has already been used to find mistakes in = both=20 >> Linux and LLVM. I ran it on sys/ and it found lots of potential typos - = the=20 >> full diff (which I know does contain some incorrect changes) can be foun= d at=20 >> http://www.cran.org.uk/~brucec/freebsd/codespell_sys.diff . > >Needs manual review, but I think this is very useful for the spelling >nazi challenged among us :-) > >False positive, e.g.: > { >- struct ccb_immed_notify *inot; >+ struct ccb_immed_notify *into; > mpt_tgt_state_t *tgt; > >Cheers, >Uli As mentioned here already changes that I have noticed are: (Upper || lower case): inot -> into lsat -> last inbetween -> between ALOT -> A LOT boundry -> boundary "This one seems to have corrected itself." virtualY -> virtually ID -> DID lastr -> last *Any uuencoded file* This was just a review of the functional changes. The no-op changes I just filtered out of the patch to quickly catch the "Bad Thing" changes above. It might just be better to build a list of files with spelling errors and anyone with the next commit to any of those files just runs it through aspell/ispell or whatever they like rather than causing this much of a slush. All in all good find Bruce!. --=20 Regards, J. Hellenthal WWJD --XStn23h1fwudRqtG Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) Comment: http://bit.ly/0x89D8547E iQEcBAEBAgAGBQJNriYhAAoJEJBXh4mJ2FR+WaQH/jYS1pF1kiL73zi1QlpfvjI2 7Vjtmpv2s91ih1URDvf5B+I+IpSiYvMreFhKeAJsBVUXyfILUtO1sSYUh06E2oHf sE6t9cD2q2BndVaXUXvgycYlvDO2r52vpIWqL7hiAufubTLnqNYNVIwYyL0lOuWR zPUxNLCb816iWkynS9vxKIW2hhYjX3Obw3d06rOQ3WRnjOTv8UVPYrw5GgcWdDvo WQetM0GCuhGBYTv64EioCuVnzpN+lbf+H2aoRjJlMeLVpTLigr7aZWlM+Ps1FgTh XRe2Ya5/ys3ZztXh778+RSGbMQWKxoADgcGbLmm5+16qMRkk5B9G7wFzvmN2pgU= =A3Z6 -----END PGP SIGNATURE----- --XStn23h1fwudRqtG-- From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 00:53:56 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACC9F106566C for ; Wed, 20 Apr 2011 00:53:56 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 5DF6A8FC08 for ; Wed, 20 Apr 2011 00:53:56 +0000 (UTC) Received: by iyj12 with SMTP id 12so276240iyj.13 for ; Tue, 19 Apr 2011 17:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:x-openpgp-key-id:x-openpgp-key-fingerprint :x-openpgp-key-url; bh=nvBb7fPqoaxLevpkzGimHCCuBYercccOdVhgQFoNYSY=; b=c9j6EafBQtAeD4Gie9PZuo6L8bz+SsT6wFY/3v6hYBXNfBa3OaXm5+uO+R8HWsjH2p n3GSOoQ85DaZRAZGcefUgVuQYmwHBH8CVdZcPR/vxzpqIlPp+NrRhe67KQVc+Pol2VLM 6s73Oc15hEk+OtfbwuZSBfzg+zMe/kzGv2Uik= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-openpgp-key-id :x-openpgp-key-fingerprint:x-openpgp-key-url; b=m1vfwwn1IvKjY0n0F2rsxOifISMlvMq0vYRhDSwrSzD/7TSQQferWTjSu3eGplidaI +dNoz3GKu2Hz2ZEcy2jQAYgYD8CsF9ZQ1bvc/r+8IN4r4qYPlDrfPCUfSvmPCOfvZKue d83w3HFZAKmlS1U2hwjgxkCwd4cJyfBj6soSY= Received: by 10.231.25.94 with SMTP id y30mr5408849ibb.61.1303260835547; Tue, 19 Apr 2011 17:53:55 -0700 (PDT) Received: from DataIX.net ([99.190.84.116]) by mx.google.com with ESMTPS id o3sm151123ibd.27.2011.04.19.17.53.53 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Apr 2011 17:53:54 -0700 (PDT) Sender: "J. Hellenthal" Received: from DataIX.net (localhost [127.0.0.1]) by DataIX.net (8.14.4/8.14.4) with ESMTP id p3K0roD9090404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Apr 2011 20:53:51 -0400 (EDT) (envelope-from jhell@DataIX.net) Received: (from jhell@localhost) by DataIX.net (8.14.4/8.14.4/Submit) id p3K0rnNA090403; Tue, 19 Apr 2011 20:53:49 -0400 (EDT) (envelope-from jhell@DataIX.net) Date: Tue, 19 Apr 2011 20:53:49 -0400 From: "J. Hellenthal" To: Bruce Cran , freebsd-current@freebsd.org Message-ID: <20110420005349.GF2483@DataIX.net> References: <20110419111500.GA16509@muon.cran.org.uk> <20110419122210.GL85668@acme.spoerlein.net> <20110420001737.GE2483@DataIX.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZYOWEO2dMm2Af3e3" Content-Disposition: inline In-Reply-To: <20110420001737.GE2483@DataIX.net> X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E X-OpenPGP-Key-URL: http://bit.ly/0x89D8547E Cc: Subject: Re: Finding typos using codespell X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 00:53:56 -0000 --ZYOWEO2dMm2Af3e3 Content-Type: multipart/mixed; boundary="3607uds81ZQvwCD0" Content-Disposition: inline --3607uds81ZQvwCD0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 19, 2011 at 08:17:37PM -0400, J. Hellenthal wrote: >On Tue, Apr 19, 2011 at 02:22:10PM +0200, Ulrich Sp=F6rlein wrote: >>On Tue, 19.04.2011 at 12:15:00 +0100, Bruce Cran wrote: >>> There's a new tool that can be used to find spelling mistakes in code: = codespell=20 >>> from http://www.politreco.com has already been used to find mistakes in= both=20 >>> Linux and LLVM. I ran it on sys/ and it found lots of potential typos -= the=20 >>> full diff (which I know does contain some incorrect changes) can be fou= nd at=20 >>> http://www.cran.org.uk/~brucec/freebsd/codespell_sys.diff . >> >>Needs manual review, but I think this is very useful for the spelling >>nazi challenged among us :-) >> >>False positive, e.g.: >> { >>- struct ccb_immed_notify *inot; >>+ struct ccb_immed_notify *into; >> mpt_tgt_state_t *tgt; >> >>Cheers, >>Uli > >As mentioned here already changes that I have noticed are: > >(Upper || lower case): >inot -> into >lsat -> last >inbetween -> between >ALOT -> A LOT >boundry -> boundary "This one seems to have corrected itself." >virtualY -> virtually >ID -> DID >lastr -> last >*Any uuencoded file* > >This was just a review of the functional changes. The no-op changes I >just filtered out of the patch to quickly catch the "Bad Thing" changes >above. > >It might just be better to build a list of files with spelling errors >and anyone with the next commit to any of those files just runs it >through aspell/ispell or whatever they like rather than causing this >much of a slush. > >All in all good find Bruce!. > Meant to attach the final list I came up with for further use if needed but forgot on send... Here it is. --=20 Regards, J. Hellenthal WWJD --3607uds81ZQvwCD0 Content-Type: application/octet-stream Content-Disposition: attachment; filename="codespell_sys.txt.gz" Content-Transfer-Encoding: base64 H4sICOMtrk0CA2NvZGVzcGVsbF9zeXMudHh0AO1aWW/bSBJ+1vyKhgEbpClmnexgHzaJAcaS HSGypJHorL2ZoEGRLYswRXLIlo/Z/PitPngfomxjAywmQBKp+6uT1VXVJeo9+IOQcrAgPkWG OZr+bTSZmkg5DNXf/YM+2sYkwra9VNX3v2h1YHNaD9Z7vZhGW5siWMDuZkMc7AfUXT2hYxc+ cHYtCBpwHgyKPiKlAXmsbizPC2wldv8kwUrhrNU+usSLs8Xo0+c+k8KY7ceDBgUeTI8VUoQu H9HkajxW0X84a77M2GfLgH4MKY4J3YbMG8oRI9RPmdx1H4UkcsO1fhpaFL6dGZd4Nh9N5yPz Bk+m80tjrKaGS5o3q61vYztwCFhxPTPx6PJyOAC0OTq/qYDt5cr2Q0BSK7pdrp3AJ+8TnSyb uoGvKFsf/mOOQMcq95h8XhbdxkCZZycW+dOqWEWDvaySj6KbVSVwrVVam1XwDGWMpVZl7BKr wOreKiKEP9vskctglzs0KOwAzWI8WoDCk8VwbuLPQ2OgHMXBitr6aT6wcOy5MXAtPH/GeG/y zNEgXYZxHNh3luNE2KLIiy0AHsO/TPE6gBWnANB/+SeJAkWx+TZVjwS9jP8quTzPDPUG/mKP +ODPZngRzVbfxGAUf9KGaQwGc2xMbibTwbAeSWgRODSLuJW1cb0nhjnHxmw2HprG+IsIYYuR cnv4I6wYyv3QaihQMVRHQ/PodkPrkHWG5nENhmqZoYBkhkOIQHyvPPd2zdZP+igiMfEd8dn1 l4Q+EG4MfLXsOyJ3rGVwz5Q9YUzbmXRgwU5TKkvTxCHKfdV5vlRSGafoREU/frAUmnBnSyK3 NkDLQJ2VJJTqnTM2UV+qKJUWz6xIsotA7y0t33lwWWpziGc9Ack2iimPDMZPbDsN+8wtJIqC CLzk3+IlZSFEKI5WdrDZ4BAONhOrwIc+MsZTU6af7jRIEIGgPfjvw3Yfvvsw3tki7OwQXs5h V48B1QSW1u87tBIpVJwElvU3JI6tW4KhbMXfTr4DMbmH9kk/5f9h+hSSRvjbChyWhY9FTejE vAHewDztJlzfpa5Fgwi7TobMr+bA8GxjItPlSdpusCpd22ykxb2LkBRcEqI1C+G1/6/Y+Cs2 mmODVQDl4Fu4sfuHznf04JLIQWezKwTCDh24zGA8Hk2GGPeRHW5FY1CmIe4umpKcZ4jpJmWL 7bUVIbQMtr4TPTEuhSWLrbHGT+yzpga6TZ88UhyyKkeRjt6+Ty46CeoDR0XEBhCEBjTNEVV5 QBb55BBBKDhpEmM1C9NywqxGaVqvwqlGHOjEDppr42BLl0ps9xHcJWYn+NNkftNP3CKiayfQ 4kidPYYIrjuRrxxs/bvgwT9gDErLvlwXPdi9G9Gt5V33k083SWNV2fH4E1GO710nfvimWE6o 6qf3FnZ9hzx+h4i27gmY6RFKiarw/T5SYAFWiKq20nqB5bTRas+RyxfaaRvlSlq9J1qvg9mW ovP5cIj4tMHb+hDZfIQAH2UXUcaZ0yruNVL87gyPFqYxGv+Gz0fzhakc0YiGLA8FNFaTnrY6 GthdDVrZag2jBe6VC5L33mGYd4y4yOZv8OzGDJ1Y4tkyB/BrmQO78OZvywUOem9DNjGhyVhD ZF7HolafXQfEZUl4JL+pqomzayqC5FgtczUs89siX2b6ZJWgRp/ipiBtKB6pPuXKWMOyrI/e XN0vFxfY+DSFS79pXOSK107kDp5n46ExB+TiC17IK2Qb4zJ8B3fTmF8MTTwfduFdBHfS2zgz OqrMkT/Bv5PpdLaTnQDpPXorTh47/PnOA4mMpPeq0zWAsonZ5XCxMC6G4Lyzrz/YwmD4Ff92 Pv/3hAlv4csSmdarzrc68NV3NWPtbZQbh3gNl18PSoZn0VUQbdLplR27CuzzyRamkHDjkKUV DG1c9MQXmIxftBfyAEVYLbwPXAd8AbwkLXQaioRLU1oxsi2s1AvoNUmhqCCRjmvn1yUwrwAC nHTxdSWhQAVlgU8Hk6oQ0ihfFZqvGd25cF1kPpVz7LTayJFKrzdazPDMMD/j2dwUPmIr4+mF ORh+uro4KdYYMfY9OIz/iUzrjuSqkw0dFUXQJSXlBWM++IXuNdMKc1TyE0MX0VmoN4iGsraf 6I5WC0po+kgEUqGJRFAKuKXigWwjEv8uOsUXMQT9ywz1ymMrPDVW2Nn0BR4KXNg8NsuK7vmU TvZCbQDeC7WcxHe/Pj7WnsSVLc4iA3Q71HuwEmfbD9eOl/4sAUC+wByc7YgLY7IDngqDiLpO nkqs4LWLPnxAb/+BflS2PJ5H86SSbR1pccsTw6gHl9rrpFOBXZGHxdPKNiVptsnrD5xl8BiI ZRHCiujX2WhwneUwTnMfus5jektupZBSEgqW2+rVw/F2yX6HkUHVoGcelc8gNRDWss4gxkdq Ibe0I3V5WhaT2RzC/1xZbldZrwVf4CpxMBwv0Mnj4eNBziUl9cTB249TvaGFE8cBK8+6jdER HM93v15f4/OxcYFnV/PhNR5Nzz6VDmVHinSALWVEj66Tsy6Ar0KTLiVOspLCE1byq2Sl9bpV Qm4HIFZwu8Ohs8TLJwjzAMIpS2TtYdpH/Dz20ZEXqmncAEuHePjhQZbx7tw8uCCx88ZoU97J YmLbs9QunJWK2tqeape47VZbF/zDiBZqxGhyPoVQPWOH/NBBhzFU/e1Sl80di14VQWZFE51x QiLfJlHdxaFQehoPktRUOvV/ol3Jb1K72sOZadf1ZHSK+VfjtLONrJtNVNrHtvnEPv3efiOK ffrRhhcgasfE7Ooh74f/Go0HZ8Z80DzurQU3cWaHScRXM8M8JhtE/CE2hbW8L6LW7b3lZRj4 3oBBp6fo7+/yY4RmbglmNzeZC+TMZWNFd9hawgEiDiZW5Mm8Q3NHV/DMjx6AtnTJXXxJz3FH zpm2+aF8PedWwaWZRDOkhkvdhKB2t5G2VYPGSUgGYYnuzBjjq8moOgNph9Vwa5ilNAH0n3QN 6zik6DA++Dl3uY7DkE7zDXZcxGGtXlpyJK7NftnemfbF1eg1eYo70rPj5BsryN9RylkmJl65 2RZaRcFGfMpVdsQiln0oPgs5oM6npay/yLJxsiYSZr/mfbNkDcS8LIxe1zwt119n5pWLTbKW mVeOxWRNmKf3oH9IX3Rjj1mU/GRgyHfTwpF3brqblp68Y9PdUiWsPhDm4ooOvDlIWpWyDpkH 0t2cDpn16W5Fh7LXXrdr6to2wTqH7w4wQJbiS8YWz69pPMXs5SQXOuI4/TmmfBSSuEjiSm19 faBOYe2FCkNCbVa4Gtw1CmcezolJYrejR2syktQwIvaT7RUOK2iUnchmrxZ8Waua9swBY2fV mvyndnkNd/crrXrveQ+/8JNrH+KM/MHeKBD3tHJ5TWcoL5BiTndK+X+zBfE/q/hNyH8RR6cf 2Rc+LtBP2buaETo6qkV+qAA19PUSnxtXY9YNGgNVZaRaFyFNwLKMehGgXVmVjzkmGlpZW48K 83W0JGtY53FbYt6B6L9X4GLvfjAAAA== --3607uds81ZQvwCD0-- --ZYOWEO2dMm2Af3e3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) Comment: http://bit.ly/0x89D8547E iQEcBAEBAgAGBQJNri6cAAoJEJBXh4mJ2FR+YAsIAJOECKsj68YAbj+/jLWOtzOx nN9fj1YyaCjlflw3m7vNrTyoqtpm5LCVCPzGZ5x1/4+dTZT0DL75i9Nd5+emKYCw x5eW+cD8BzyakA5luoc2IQndef6zzufRPSKdou3ls++BKQCzeEqbbEBnVMnQNJZa JEI5ydTqkqVqyGms9xoC4fpNVtJdr4IkrzspartvIJ2r6Xmnx/1K9tjXcvP0ZAiK ndmyAKrYRBSbyMg3Jk7xyQxewB2cAkaUCM5YuBplfumolZjmRhYgIleN5DdPr4Nf MuMMTN72mZToF6YrzdFsM7nWGDencbOQnu6t/TgHlUFvHins486vXXbXjt0A8rY= =oI/X -----END PGP SIGNATURE----- --ZYOWEO2dMm2Af3e3-- From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 02:13:57 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8587E1065674; Wed, 20 Apr 2011 02:13:57 +0000 (UTC) (envelope-from davidxu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 735F58FC08; Wed, 20 Apr 2011 02:13:57 +0000 (UTC) Received: from xyf.my.dom (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p3K2DnHb060787; Wed, 20 Apr 2011 02:13:56 GMT (envelope-from davidxu@freebsd.org) Message-ID: <4DAE4164.9080006@freebsd.org> Date: Wed, 20 Apr 2011 10:13:56 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.13) Gecko/20110127 Thunderbird/3.1.7 MIME-Version: 1.0 To: Ryan Stone References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD Current , Ed Maste Subject: Re: [PATCH] Call _thr_check_init() from _pthread_once X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 02:13:57 -0000 On 2011/04/20 00:53, Ryan Stone wrote: > In r179417 the implementation of pthread_once in libthr was changed > from using a global pthread_mutex_t for synchronization to rolling its > own synchronization mechanism. Unfortunately, this introduced a bug. > Calling _pthread_mutex_lock implicitly ensured that _thr_check_init() > had been called. In the current version, there is no such guarantee. > This means that if your first call into libthr is pthread_once, your > executable will segfault when it tries to access curthread. This > patch resolves the issue for me: > > Index: lib/libthr/thread/thr_once.c > =================================================================== > --- lib/libthr/thread/thr_once.c (revision 220603) > +++ lib/libthr/thread/thr_once.c (working copy) > @@ -64,6 +64,8 @@ > struct pthread *curthread; > int state; > > + _thr_check_init(); > + > for (;;) { > state = once_control->state; > if (state == ONCE_DONE) > > If there are no objections I'll commit this soon. Have you tested that current code causes segfault ? anyway, I can not reproduce it on my machne. Regards, David Xu From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 02:49:01 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B31C106564A; Wed, 20 Apr 2011 02:49:01 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id D67878FC15; Wed, 20 Apr 2011 02:49:00 +0000 (UTC) Received: by eyg7 with SMTP id 7so102364eyg.13 for ; Tue, 19 Apr 2011 19:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=eVpcdaRKOWKnSQOZ6YJH2pEfdy969hhoNo/aodrRTRc=; b=Xd2YYrDFXZuJsqFUnjSGcqnXFIBs2WExwgARNKy2JDcc8nacl3dBS1WC+4SXiwquXB AWkZAq2+w6ZY9GGbdOx9cOsDFPl87gtiObx78MfnKKfQ4lWzc6GsUVwYGnykFAckGgjV 0h6NWee5I7Q0sr00jIt0FjpBOhYyx3pGm6DWY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=YawG2hdBEsspsR6wtaDubk7P+EokAFiwxgl0clsBAWJ9LOk21px2cURQCUgMVeVXFk wrOK0AC2s44S1bZLEFwvngapkvOjR9/KcK/EwB6ow3DQp4Wdxw7fWlscWm/+yMr6SYdt OKiLtQufza3pbIwuMNMwuM7BKhQlu1obFSvmk= MIME-Version: 1.0 Received: by 10.213.96.228 with SMTP id i36mr72169ebn.100.1303267739627; Tue, 19 Apr 2011 19:48:59 -0700 (PDT) Received: by 10.213.32.4 with HTTP; Tue, 19 Apr 2011 19:48:59 -0700 (PDT) In-Reply-To: <4DAE4164.9080006@freebsd.org> References: <4DAE4164.9080006@freebsd.org> Date: Tue, 19 Apr 2011 22:48:59 -0400 Message-ID: From: Ryan Stone To: David Xu Content-Type: text/plain; charset=ISO-8859-1 Cc: FreeBSD Current , Ed Maste Subject: Re: [PATCH] Call _thr_check_init() from _pthread_once X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 02:49:01 -0000 On Tue, Apr 19, 2011 at 10:13 PM, David Xu wrote: > Have you tested that current code causes segfault ? > anyway, I can not reproduce it on my machne. > > Regards, > David Xu Yes, I had an application where libstdc++ was calling pthread_once while constructing a static object. As near as I can tell it's pure luck as to whether you'll hit this crash or not. If the linker happens to place a static initializer that calls pthread_once first in the list of static initializers, you crash. If instead something far more likely like pthread_mutex_lock is called first, you're fine. The backtrace for my executable was something like: #0 0x684dadd4 in _pthread_once (once_control=0x6887fdcc, init_routine=0x6883d740 <__gthread_trigger()>) at /usr/src/lib/libthr/thread/thr_once.c:84 #1 0x6883d992 in __gthread_active_p () at /tmp/buildutils.x86/x86-i686-pc-freebsd8/i686-pc-freebsd8/libstdc++-v3/include/i686-pc-freebsd8/bits/gthr-default.h:221 #2 __eh_globals_init () at gcc/libstdc++-v3/libsupc++/eh_globals.cc:98 #3 __static_initialization_and_destruction_0 () at gcc/libstdc++-v3/libsupc++/eh_globals.cc:110 #4 global constructors keyed to eh_globals.cc(void) () at gcc/libstdc++-v3/libsupc++/eh_globals.cc:146 #5 0x68848d06 in __do_global_ctors_aux () from /usr/local/mumble/lib/libstdc++.so.6 From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 02:57:09 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DDCA5106564A for ; Wed, 20 Apr 2011 02:57:08 +0000 (UTC) (envelope-from no-reply@dropboxmail.com) Received: from mailman-2.dropboxmail.com (mailman-2.dropboxmail.com [75.126.110.122]) by mx1.freebsd.org (Postfix) with ESMTP id A85118FC13 for ; Wed, 20 Apr 2011 02:57:08 +0000 (UTC) Received: from mailman-2.dropboxmail.com (localhost [127.0.0.1]) by mailman-2.dropboxmail.com (Postfix) with ESMTP id DE64C483461 for ; Wed, 20 Apr 2011 02:45:04 +0000 (UTC) X-DomainKeys: Sendmail DomainKeys Filter v0.6.0 mailman-2.dropboxmail.com DE64C483461 DomainKey-Signature: a=rsa-sha1; s=m1; d=dropboxmail.com; c=simple; q=dns; b=H4LIWQv5j3BotGpwblFi8d5SjTwuwjC9fqGTTIfTsm8JXR1YJLKHer11aiIuw6X3M 5A9gn4KZItEdD6y7nsng3AHw1CsqcKBAH692OFRPtPsunOZxADn1/C3G+0LpVAxTCcf FUf/j5ymNwcZxLdd3FH0GEi8hQ0BBISq9EuiIa8= MIME-Version: 1.0 From: Dropbox To: freebsd-current@freebsd.org Date: Wed, 20 Apr 2011 02:45:04 +0000 Message-Id: <20110420024504.DE64C483461@mailman-2.dropboxmail.com> Content-Type: text/plain; charset="utf8" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: Masoom Shaikh invited you to Dropbox X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: masoom.shaikh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 02:57:09 -0000 Masoom Shaikh wants you to try Dropbox! Dropbox lets you bring all your photos, docs and videos with you anywhere and share them easily. Get started here: http://www.dropbox.com/link/20.19I4vT5g3K/Njg3MzIzMDI4Nw?src=referrals_bulk9 - The Dropbox Team ____________________________________________________ To stop receiving invites from Dropbox, please go to http://www.dropbox.com/bl/f4177619c52f/freebsd-current%40freebsd.org From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 02:58:06 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF9E81065673; Wed, 20 Apr 2011 02:58:06 +0000 (UTC) (envelope-from davidxu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id ABF638FC15; Wed, 20 Apr 2011 02:58:06 +0000 (UTC) Received: from xyf.my.dom (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p3K2w219096612; Wed, 20 Apr 2011 02:58:05 GMT (envelope-from davidxu@freebsd.org) Message-ID: <4DAE4BC1.7030007@freebsd.org> Date: Wed, 20 Apr 2011 10:58:09 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.13) Gecko/20110127 Thunderbird/3.1.7 MIME-Version: 1.0 To: Ryan Stone References: <4DAE4164.9080006@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD Current , Ed Maste Subject: Re: [PATCH] Call _thr_check_init() from _pthread_once X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 02:58:06 -0000 On 2011/04/20 10:48, Ryan Stone wrote: > On Tue, Apr 19, 2011 at 10:13 PM, David Xu wrote: >> Have you tested that current code causes segfault ? >> anyway, I can not reproduce it on my machne. >> >> Regards, >> David Xu > > Yes, I had an application where libstdc++ was calling pthread_once > while constructing a static object. As near as I can tell it's pure > luck as to whether you'll hit this crash or not. If the linker > happens to place a static initializer that calls pthread_once first in > the list of static initializers, you crash. If instead something far > more likely like pthread_mutex_lock is called first, you're fine. > > The backtrace for my executable was something like: > #0 0x684dadd4 in _pthread_once (once_control=0x6887fdcc, > init_routine=0x6883d740 <__gthread_trigger()>) > at /usr/src/lib/libthr/thread/thr_once.c:84 > #1 0x6883d992 in __gthread_active_p () > at /tmp/buildutils.x86/x86-i686-pc-freebsd8/i686-pc-freebsd8/libstdc++-v3/include/i686-pc-freebsd8/bits/gthr-default.h:221 > #2 __eh_globals_init () > at gcc/libstdc++-v3/libsupc++/eh_globals.cc:98 > #3 __static_initialization_and_destruction_0 () > at gcc/libstdc++-v3/libsupc++/eh_globals.cc:110 > #4 global constructors keyed to eh_globals.cc(void) () > at gcc/libstdc++-v3/libsupc++/eh_globals.cc:146 > #5 0x68848d06 in __do_global_ctors_aux () > from /usr/local/mumble/lib/libstdc++.so.6 > But I don't touch curthread unless it is blocked by another thread. From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 03:02:45 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2968A106566B; Wed, 20 Apr 2011 03:02:45 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 623968FC1B; Wed, 20 Apr 2011 03:02:44 +0000 (UTC) Received: by ewy1 with SMTP id 1so105440ewy.13 for ; Tue, 19 Apr 2011 20:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ejlubP0Y8G60cue0oFcSR1+C2WB6R5b2yi6lTArLEMQ=; b=O1MunmcT8G+TR48gcvQLRq7UCYTf73dOUNyyvFace7392P98SP9gqUEn8wFvWyjjdy cQ0k95QbpwLk3y0OiHe803p8eo3w0I0ru9hVyjdcC4BnDnP2NA7XOmFSZIp1fXpvvxap qf8EftH20E+L6nFDevTaEosWTvDf9UewReTHw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=UCEloc7q19GRLqyRnYbViwNvOK9oEj9KRWIyzCQAvoFnvRjjxYSCNpVnF8/Z0h4bas u3oY/Dg/sogpzIUeTOITuDFce+oCCJfJox+jhVrHXwZOXYtjEdiphST8iJcpuWNuGDNN gWAetz+01enXVk0vIJal4JYBDhoJ0UY4MEMTI= MIME-Version: 1.0 Received: by 10.213.113.205 with SMTP id b13mr78879ebq.62.1303268563253; Tue, 19 Apr 2011 20:02:43 -0700 (PDT) Received: by 10.213.32.4 with HTTP; Tue, 19 Apr 2011 20:02:43 -0700 (PDT) In-Reply-To: <4DAE4BC1.7030007@freebsd.org> References: <4DAE4164.9080006@freebsd.org> <4DAE4BC1.7030007@freebsd.org> Date: Tue, 19 Apr 2011 23:02:43 -0400 Message-ID: From: Ryan Stone To: David Xu Content-Type: text/plain; charset=ISO-8859-1 Cc: FreeBSD Current , Ed Maste Subject: Re: [PATCH] Call _thr_check_init() from _pthread_once X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 03:02:45 -0000 On Tue, Apr 19, 2011 at 10:58 PM, David Xu wrote: > > But I don't touch curthread unless it is blocked by another thread. > You do a THR_CLEANUP_PUSH(curthread, once_cancel_handler, once_control); before calling *init_routine. THR_CLEANUP_PUSH touches curthread->cleanup; From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 03:04:48 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AFD2F106566C; Wed, 20 Apr 2011 03:04:48 +0000 (UTC) (envelope-from davidxu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9B72B8FC08; Wed, 20 Apr 2011 03:04:48 +0000 (UTC) Received: from xyf.my.dom (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p3K34iEi005364; Wed, 20 Apr 2011 03:04:46 GMT (envelope-from davidxu@freebsd.org) Message-ID: <4DAE4D53.7080602@freebsd.org> Date: Wed, 20 Apr 2011 11:04:51 +0800 From: David Xu User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.13) Gecko/20110127 Thunderbird/3.1.7 MIME-Version: 1.0 To: Ryan Stone References: <4DAE4164.9080006@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD Current , Ed Maste Subject: Re: [PATCH] Call _thr_check_init() from _pthread_once X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 03:04:48 -0000 On 2011/04/20 10:48, Ryan Stone wrote: > On Tue, Apr 19, 2011 at 10:13 PM, David Xu wrote: >> Have you tested that current code causes segfault ? >> anyway, I can not reproduce it on my machne. >> >> Regards, >> David Xu > > Yes, I had an application where libstdc++ was calling pthread_once > while constructing a static object. As near as I can tell it's pure > luck as to whether you'll hit this crash or not. If the linker > happens to place a static initializer that calls pthread_once first in > the list of static initializers, you crash. If instead something far > more likely like pthread_mutex_lock is called first, you're fine. > > The backtrace for my executable was something like: > #0 0x684dadd4 in _pthread_once (once_control=0x6887fdcc, > init_routine=0x6883d740 <__gthread_trigger()>) > at /usr/src/lib/libthr/thread/thr_once.c:84 > #1 0x6883d992 in __gthread_active_p () > at /tmp/buildutils.x86/x86-i686-pc-freebsd8/i686-pc-freebsd8/libstdc++-v3/include/i686-pc-freebsd8/bits/gthr-default.h:221 > #2 __eh_globals_init () > at gcc/libstdc++-v3/libsupc++/eh_globals.cc:98 > #3 __static_initialization_and_destruction_0 () > at gcc/libstdc++-v3/libsupc++/eh_globals.cc:110 > #4 global constructors keyed to eh_globals.cc(void) () > at gcc/libstdc++-v3/libsupc++/eh_globals.cc:146 > #5 0x68848d06 in __do_global_ctors_aux () > from /usr/local/mumble/lib/libstdc++.so.6 > OK, I understand, that current INPROGRESS will push cleanup routine, so the curthread is used, your patch is right. From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 06:22:40 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A32FF1065676; Wed, 20 Apr 2011 06:22:40 +0000 (UTC) (envelope-from romain.garbage@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 2CA8E8FC19; Wed, 20 Apr 2011 06:22:39 +0000 (UTC) Received: by qwc9 with SMTP id 9so250121qwc.13 for ; Tue, 19 Apr 2011 23:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=onc8IeubrpGXC4ZdTXLdoH9lJiJeFyRlxH+cOKuwEKE=; b=U6L4TUS0CrEvFNvVmtqDbR/1hbz+jusPjKwy7OGQF3oyAnkz3RyYF0uTciwcKjO16y nOce7tZIYx9WyphE3P0vksVWM4naKwmLdAYrnyGrOtm6aqJDATlh5BlZ1Thm+39aLS8T jP+wQNPLOTFRXPIrha4spafY7PPQMxTDa1tBg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=bVwz1bu96QrckKHzzIuCmcsvOxS8aaTxGkhVu20ZsJO4xjyTpMez/BWf0pH/MYVyDI YzFqoSKyN9IK0AkFkZM0pNL2gHE5xWIsBLhUjX0N/zI3WYuNadr2LxQU2PEnCAGH6d0H dXZJuKb9IJqD9HWqmbk2IAy/NmoRgxQ8dBQ1A= MIME-Version: 1.0 Received: by 10.229.130.144 with SMTP id t16mr5147613qcs.146.1303280559294; Tue, 19 Apr 2011 23:22:39 -0700 (PDT) Received: by 10.229.110.17 with HTTP; Tue, 19 Apr 2011 23:22:39 -0700 (PDT) In-Reply-To: References: <20110416155122.GA29309@wolfman.devio.us> <201104180805.40743.jhb@freebsd.org> Date: Wed, 20 Apr 2011 08:22:39 +0200 Message-ID: From: Romain Garbage To: mdf@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, Nick Ulen Subject: Re: `hw.acpi.thermal.tz0.temperature' disappeared X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 06:22:40 -0000 2011/4/18 : > I don't seem to have a hw.acpi.thermal sysctl node on my box. =C2=A0Can > someone please try this patch? Works for me too. $> sysctl -a | grep temp [...] hw.acpi.thermal.tz0.temperature: 62.0C dev.cpu.0.temperature: 55.0C dev.cpu.1.temperature: 56.0C [...] By the way, why the temperature from coretemp is different of the one from acpi? Are they two different hardware? Regards, Romain From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 09:15:32 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA5BB106564A; Wed, 20 Apr 2011 09:15:32 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 6C5408FC0A; Wed, 20 Apr 2011 09:15:32 +0000 (UTC) Received: from outgoing.leidinger.net (p5B155769.dip.t-dialin.net [91.21.87.105]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 65637844015; Wed, 20 Apr 2011 11:15:15 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [IPv6:fd73:10c7:2053:1::2:102]) by outgoing.leidinger.net (Postfix) with ESMTP id 8B8CB1E07; Wed, 20 Apr 2011 11:15:11 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.13.8/Submit) id p3K9FB6D026294; Wed, 20 Apr 2011 11:15:11 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 20 Apr 2011 11:15:10 +0200 Message-ID: <20110420111510.31806jq0ffewdrgo@webmail.leidinger.net> Date: Wed, 20 Apr 2011 11:15:10 +0200 From: Alexander Leidinger To: Dimitry Andric References: <4DAC3FD9.1060603@FreeBSD.org> <20110418103416.76b07b36@kan.dnsalias.net> <4DAC9534.60009@FreeBSD.org> <20110419132114.43009vpwaeidet68@webmail.leidinger.net> <4DADCBB4.8060301@FreeBSD.org> In-Reply-To: <4DADCBB4.8060301@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.6) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 65637844015.ADCC7 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=0.077, required 6, autolearn=disabled, TW_TD 0.08) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1303895718.86926@UBtFnLfq1mwvwQFcEk5elA X-EBL-Spam-Status: No Cc: "arch@freebsd.org" , "current@freebsd.org" Subject: Re: Removal of ICC (intel compiler) bits from mk X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 09:15:32 -0000 Quoting Dimitry Andric (from Tue, 19 Apr 2011 19:51:48 +0200): > On 2011-04-19 13:21, Alexander Leidinger wrote: > ... >>>> You probably also want to remove the code that uses __INTEL_COMPILER >>>> in source tree if you want to be really thorough. >>> >>> Ok, new patch attached. Some of the contributed sources also contain >>> instances of __INTEL_COMPILER, but these are all from upstream, so I >>> left them in. >> >> Is it really necessary to remove them from cdefs.h? If someone takes >> parts of our source and wants to compile them on linux or windows with >> icc, the icc parts in cdefs.h are a valuable part to have. > > Isn't that the case for the other headers too? Except the in_cksum.[ch] > files, where the 'fix' for ICC is apparently not needed at all anymore. The stdbool header is somewhat tied to our system I would say. The math one is AFAIK about building the math lib itself. Just from reading the diff I would assume this could manifest itself by compile errors (duplicate definition). I do not know how valuable it is to build this somewhere else. IMO they can stay in or they can be removed. Both should be easy to debug/redo in case of problems. The cdefs header is differntly in this regard, only for some parts you will get easy to debug error cases, other cases are silent (you don't know where it happens) corruption or bad performance. Bye, Alexander. -- Coming together is a beginning; keeping together is progress; working together is success. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 09:58:08 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3DF44106564A for ; Wed, 20 Apr 2011 09:58:08 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id C5B2D8FC0A for ; Wed, 20 Apr 2011 09:58:07 +0000 (UTC) Received: by fxm11 with SMTP id 11so459541fxm.13 for ; Wed, 20 Apr 2011 02:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:subject:x-enigmail-version:content-type :content-transfer-encoding; bh=YDJi6cjezYgPUF7XONVqH6lHKxsyqjon1ua+W3JwZ04=; b=Ih8W7dotR0S8smLHahUoGuxUWbwfNwnhotJQZrWeEfOAK3OE0mFVHesE4xlklSnJAD 8FGXMHRICJdtQ9SX4k3gZaaYAo9+4+niE7rO89pAeft2ru/NNSQ1Bi9OZbLIXz2K/g2s 1f+UN0+kO1JAHa2K2QZAFtthmSgi0/8yAyxRA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:subject :x-enigmail-version:content-type:content-transfer-encoding; b=NoYMFJRk+36Mktg119Q2+MkKB68rVIKQlcYRsvcgcAsWkejNkMepJGRNM+NlJQdc0+ bY3GNCGWTggEPH/umgjXNV6yHiepD/DpQV4L0v4GhZONJ6oOBnDq/ykm36BI1xD4NnWU ALXw3s8b/3tCmydR+KZYKtHsyqvKHrfy3AzUs= Received: by 10.223.159.14 with SMTP id h14mr1852331fax.20.1303293486718; Wed, 20 Apr 2011 02:58:06 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id l2sm233860fam.5.2011.04.20.02.58.05 (version=SSLv3 cipher=OTHER); Wed, 20 Apr 2011 02:58:05 -0700 (PDT) Sender: Alexander Motin Message-ID: <4DAEAE1B.70207@FreeBSD.org> Date: Wed, 20 Apr 2011 12:57:47 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: FreeBSD-Current X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 09:58:08 -0000 Hi. With 9.0 release approaching quickly, I believe it the best time now to manage migration from legacy ata(4) ATA to the new CAM-based one. New ATA code present in the tree for more then a year now, used by many people and proved it's superior functionality and reliability. The only major issue with it now is the migration process. Sooner or later we have to pass it, but due to major UI and API changes we can't do it after 9.0 release. So I propose to do it the next Sunday (April 24) to have as much time for troubleshooting as possible. I have prepared the following patch to do it: http://people.freebsd.org/~mav/ata_switch.patch I haven't added geom_raid to the kernel configurations because we have no other GEOM classes there. But tell me if you thing I should. If somebody has any problems with new ATA stack, please repeat your tests with latest HEAD code and contact me if problem is still there. Next three weeks before BSDCan I am going to dedicate to fixing possibly remaining issues. -- Alexander Motin From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 12:20:04 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E1AD106564A; Wed, 20 Apr 2011 12:20:04 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.cran.org.uk (muon.cran.org.uk [IPv6:2a01:348:0:15:5d59:5c40:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id B20998FC13; Wed, 20 Apr 2011 12:20:03 +0000 (UTC) Received: from muon.cran.org.uk (localhost [127.0.0.1]) by muon.cran.org.uk (Postfix) with ESMTP id B2F7BE61D0; Wed, 20 Apr 2011 13:20:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=cran.org.uk; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=mail; bh=ffXVHaRwKSv/ 2/caLwKFcFOyzTo=; b=oVdeAEU7N6K5HWJ+moxIYHmU6HlvbI6BT9BHCwE/fXRD qFnh9zqgaMlqQIHynPKN5a1RvnjQeXlOlYqJ33efHFUhXDdvQtRtSpdyjHJVIp7q u1ykD1F3fEXCeFkVb1Ngn5mFHQrz62MgAq4/JMa7KuM6mV0jVRayuSt2ZdNJnwo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=cran.org.uk; h=date:from:to :cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; q=dns; s=mail; b=Nj8uMU 6ATEIGKAamUNDA7oT++PvHHkDgBF5eOMxC8hcfoSukFondrYv1p8qDDB/TFHS/ho HA3u1KyxmpdrYgyPIF8BVfnnIMeiwTd/g3Fq86i/+jMl6JlbdzAofSoBqZ0A/1kB yxOZdVZ8q6Q7iqRZG/8eGBKDFyrR8PqR0Fd2E= Received: from unknown (188-222-18-231.zone13.bethere.co.uk [188.222.18.231]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by muon.cran.org.uk (Postfix) with ESMTPSA id 58074E61CE; Wed, 20 Apr 2011 13:20:02 +0100 (BST) Date: Wed, 20 Apr 2011 13:20:01 +0100 From: Bruce Cran To: Alexander Motin Message-ID: <20110420132001.000058e1@unknown> In-Reply-To: <4DAEAE1B.70207@FreeBSD.org> References: <4DAEAE1B.70207@FreeBSD.org> X-Mailer: Claws Mail 3.7.8cvs47 (GTK+ 2.16.6; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 12:20:04 -0000 On Wed, 20 Apr 2011 12:57:47 +0300 Alexander Motin wrote: > If somebody has any problems with new ATA stack, please repeat your > tests with latest HEAD code and contact me if problem is still there. > Next three weeks before BSDCan I am going to dedicate to fixing > possibly remaining issues. I've not checked recently with -current, but at least on the latest 8-stable there's a problem with using ATA_CAM on Xen: during boot there's a pause for a minute after which "run_interrupt_driven_hooks: still waiting after 60 seconds for xpt_config" is displayed. -- Bruce Cran From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 12:22:09 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 19D7A106564A for ; Wed, 20 Apr 2011 12:22:09 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9C10C8FC1D for ; Wed, 20 Apr 2011 12:22:08 +0000 (UTC) Received: by fxm11 with SMTP id 11so539506fxm.13 for ; Wed, 20 Apr 2011 05:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=2PrIXAUHvBht1uCbxnh6omc1H8E+TSu0wiHceVQPK3s=; b=pu5Dukp+yZ+OZRL9gwvyJW+Vdca14RURXHBmpapf0JfJzsJWz0RzsZHmJNML8BnEVW +nIbO+L3kZUgI9RNF/QC6S+9ah+wk4ohq65SAoTR8YYo6gtzIqh3ZXA1ezWeJS7iKjHQ I4Vjlfc+ntq7wQYgdyORC7QYe0Y6rSEZvDvpI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=ifhpp6KvVJXJXvwwkUkGzBhaimoM1dJxN2bb/g7Ch/ZctMrsjcsFU/CPZ9FqRyu7gq zt8uuK/VmB3ipTjy9OP8t6/GTG0QyM8290VMS5RHaDVKImEk9S+sjhs46upzdIc8fSsk Qf3ONXLZmP0alh2TKVsfSeg1wiu5Byh/uTzJs= Received: by 10.223.78.142 with SMTP id l14mr2038133fak.88.1303302127492; Wed, 20 Apr 2011 05:22:07 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id n26sm271444fam.37.2011.04.20.05.22.05 (version=SSLv3 cipher=OTHER); Wed, 20 Apr 2011 05:22:06 -0700 (PDT) Sender: Alexander Motin Message-ID: <4DAECFDC.2050508@FreeBSD.org> Date: Wed, 20 Apr 2011 15:21:48 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Bruce Cran References: <4DAEAE1B.70207@FreeBSD.org> <20110420132001.000058e1@unknown> In-Reply-To: <20110420132001.000058e1@unknown> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 12:22:09 -0000 Bruce Cran wrote: > On Wed, 20 Apr 2011 12:57:47 +0300 > Alexander Motin wrote: > >> If somebody has any problems with new ATA stack, please repeat your >> tests with latest HEAD code and contact me if problem is still there. >> Next three weeks before BSDCan I am going to dedicate to fixing >> possibly remaining issues. > > I've not checked recently with -current, but at least on the > latest 8-stable there's a problem with using ATA_CAM on Xen: during boot > there's a pause for a minute after which "run_interrupt_driven_hooks: > still waiting after 60 seconds for xpt_config" is displayed. Verbose dmesg from the fresh system would be appreciated. -- Alexander Motin From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 14:35:19 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0634106566B for ; Wed, 20 Apr 2011 14:35:19 +0000 (UTC) (envelope-from mj@feral.com) Received: from ns1.feral.com (ns1.feral.com [192.67.166.1]) by mx1.freebsd.org (Postfix) with ESMTP id 836958FC0A for ; Wed, 20 Apr 2011 14:35:19 +0000 (UTC) Received: from [192.168.135.100] (c-71-202-26-20.hsd1.ca.comcast.net [71.202.26.20]) (authenticated bits=0) by ns1.feral.com (8.14.4/8.14.4) with ESMTP id p3KEAUo5078063 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Wed, 20 Apr 2011 07:10:31 -0700 (PDT) (envelope-from mj@feral.com) Message-ID: <4DAEE957.8040201@feral.com> Date: Wed, 20 Apr 2011 07:10:31 -0700 From: Matthew Jacob Organization: Feral Software User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 MIME-Version: 1.0 To: freebsd-current@freebsd.org References: <4DAEAE1B.70207@FreeBSD.org> In-Reply-To: <4DAEAE1B.70207@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (ns1.feral.com [192.67.166.1]); Wed, 20 Apr 2011 07:10:31 -0700 (PDT) Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: mj@feral.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 14:35:19 -0000 Yes, I believe that now is the time to do this. From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 15:36:29 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 708F3106566B for ; Wed, 20 Apr 2011 15:36:29 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.16.84]) by mx1.freebsd.org (Postfix) with ESMTP id 1FF1D8FC13 for ; Wed, 20 Apr 2011 15:36:28 +0000 (UTC) Received: from pampa.cs.huji.ac.il ([132.65.80.32]) by kabab.cs.huji.ac.il with esmtp id 1QCYmy-000PAA-F8; Wed, 20 Apr 2011 17:53:56 +0300 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2 To: Alexander Motin In-reply-to: <4DAECFDC.2050508@FreeBSD.org> References: <4DAEAE1B.70207@FreeBSD.org> <20110420132001.000058e1@unknown> <4DAECFDC.2050508@FreeBSD.org> Comments: In-reply-to Alexander Motin message dated "Wed, 20 Apr 2011 15:21:48 +0300." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 20 Apr 2011 17:53:56 +0300 From: Daniel Braniss Message-ID: Cc: Bruce Cran , FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 15:36:29 -0000 > Bruce Cran wrote: > > On Wed, 20 Apr 2011 12:57:47 +0300 > > Alexander Motin wrote: > > > >> If somebody has any problems with new ATA stack, please repeat your > >> tests with latest HEAD code and contact me if problem is still there. > >> Next three weeks before BSDCan I am going to dedicate to fixing > >> possibly remaining issues. > > > > I've not checked recently with -current, but at least on the > > latest 8-stable there's a problem with using ATA_CAM on Xen: during boot > > there's a pause for a minute after which "run_interrupt_driven_hooks: > > still waiting after 60 seconds for xpt_config" is displayed. > > Verbose dmesg from the fresh system would be appreciated. > I have a similar problem, but it's under 8.2-stable: ... FreeBSD is a registered trademark of The FreeBSD Foundation. FreeBSD 8.2-STABLE #43 r4876: Fri Mar 25 12:00:48 IST 2011 danny@rnd:/home/obj/rnd/r+d/stable/8/sys/HUJI amd64 Preloaded elf kernel "/boot/kernel/kernel" at 0xffffffff80f08000. Preloaded elf obj module "/boot/kernel/geom_stripe.ko" at 0xffffffff80f081a8. Preloaded elf obj module "/boot/kernel/ahci.ko" at 0xffffffff80f087d8. Timecounter "i8254" frequency 1193182 Hz quality 0 Calibrating TSC clock ... TSC clock: 2261016004 Hz CPU: Intel(R) Xeon(R) CPU E5507 @ 2.27GHz (2261.02-MHz K8-class CPU) Origin = "GenuineIntel" Id = 0x106a5 Family = 6 Model = 1a Stepping = 5 Features=0xbfebfbff AMD Features=0x28100800 AMD Features2=0x1 TSC: P-state invariant real memory = 25769803776 (24576 MB) ... ums0: on usbus3 ums0: 3 buttons and [Z] coordinates ID=0 ata2: p0: SATA connect time=0ms status=00000113 ata2: p1: SATA connect timeout status=00000000 ata2: reset tp1 mask=03 ostat0=00 ostat1=00 ata2: stat0=0x00 err=0x01 lsb=0x14 msb=0xeb ata2: stat1=0x00 err=0x01 lsb=0x14 msb=0xeb ata2: reset tp2 stat0=00 stat1=00 devices=0x30000 (aprobe0:ata2:0:1:0): ATAPI_IDENTIFY. ACB: a1 00 00 00 00 40 00 00 00 00 00 00 (aprobe0:ata2:0:1:0): CAM status: Command timeout (aprobe0:ata2:0:1:0): SIGNATURE: eb14 run_interrupt_driven_hooks: still waiting after 60 seconds for xpt_config ata2: p0: SATA connect time=0ms status=00000113 ata2: p1: SATA connect timeout status=00000000 ata2: reset tp1 mask=03 ostat0=00 ostat1=00 ata2: stat0=0x00 err=0x01 lsb=0x14 msb=0xeb ata2: stat1=0x00 err=0x01 lsb=0x14 msb=0xeb ata2: reset tp2 stat0=00 stat1=00 devices=0x30000 (aprobe0:ata2:0:1:0): ATAPI_IDENTIFY. ACB: a1 00 00 00 00 40 00 00 00 00 00 00 (aprobe0:ata2:0:1:0): CAM status: Command timeout pass0 at ata2 bus 0 scbus0 target 0 lun 0 pass0: Removable CD-ROM SCSI-0 device pass0: Serial Number e1F3456789KLMN4P pass0: 150.000MB/s transfers (SATA 1.x, UDMA5, ATAPI 12bytes, PIO 8192bytes) ATA PseudoRAID loaded lapic22: CMCI unmasked lapic0: CMCI unmasked SMP: AP CPU #3 Launched! lapic4: CMCI unmasked lapic18: CMCI unmasked ... cheers, danny From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 18:19:24 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6182A1065674; Wed, 20 Apr 2011 18:19:24 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.cran.org.uk (muon.cran.org.uk [IPv6:2a01:348:0:15:5d59:5c40:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id E93F78FC12; Wed, 20 Apr 2011 18:19:23 +0000 (UTC) Received: from muon.cran.org.uk (localhost [127.0.0.1]) by muon.cran.org.uk (Postfix) with ESMTP id 0B62BE61DD; Wed, 20 Apr 2011 19:19:23 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=cran.org.uk; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=mail; bh=OUeLMiVQ4UNw XZECQYnV2uAalLU=; b=qrqGqtNMBH4mllGIdu5t3JhJmd+JZcQryetz+at2Rl5p oTNxKn7W2uZXzfkCua5j/C4VmFd2D2G8QlqTcaB0ZC+RobGixLvqx4C8W+le4i8+ dj/7w3BUB90ynhYEopHq1xtS0dWTGEqev5NmI3tAbfLiZS+J+1zH+4nuYSGtPKU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=cran.org.uk; h=date:from:to :cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; q=dns; s=mail; b=iycMf+ GMlWxDSCPIL+z1axt4NYgu5b9IyRCLjsCTnjcBrWuR2hmzkS2z90Ts6dLFdjfvvf BSc2VUGuEmfW+Lo2dvGnBjBzGo21YSwRBhOsE0BEGFE9G52vTX1lMPhao4jABywV GbFp9LjVBDYX3mFguROn9RB2x6Qffrb1mXNxM= Received: from unknown (188-222-18-231.zone13.bethere.co.uk [188.222.18.231]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by muon.cran.org.uk (Postfix) with ESMTPSA id AD6C8E61DC; Wed, 20 Apr 2011 19:19:22 +0100 (BST) Date: Wed, 20 Apr 2011 19:19:22 +0100 From: Bruce Cran To: Alexander Motin Message-ID: <20110420191922.00002482@unknown> In-Reply-To: <4DAECFDC.2050508@FreeBSD.org> References: <4DAEAE1B.70207@FreeBSD.org> <20110420132001.000058e1@unknown> <4DAECFDC.2050508@FreeBSD.org> X-Mailer: Claws Mail 3.7.8cvs47 (GTK+ 2.16.6; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 18:19:24 -0000 On Wed, 20 Apr 2011 15:21:48 +0300 Alexander Motin wrote: > Verbose dmesg from the fresh system would be appreciated. I've put a verbose dmesg at http://www.cran.org.uk/~brucec/freebsd/dmesg.verbose_20110420.txt -- Bruce Cran From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 18:55:14 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCCA4106567B for ; Wed, 20 Apr 2011 18:55:13 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 681C38FC15 for ; Wed, 20 Apr 2011 18:55:13 +0000 (UTC) Received: by fxm11 with SMTP id 11so872844fxm.13 for ; Wed, 20 Apr 2011 11:55:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=mOKsVdMTAWSDCPR969m1sK7SP/PB8sAhHu1kPXsXopk=; b=RCEUcV0EFzVAvPH1dvRwmrxEWR1nCnli6q5/bddLuIjW8QjqFXFw2ha5qe22v/S9OI NZCe7HWy5fz/tAv3wIu6jNnv8aJBwuPMTbJToyK0G/stEWyYsEeDE+/V98XSPWaHFhYW iU0Vs2bJLaJnnOiFa68Zr1IzqtSk99kLQOOBo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=AfASObUG+QrxAKZPTMRI8w/hjwA+2EMM1LZCAWjj8wGF706210cZuiqyBdvIT9IbvA hEYaBBYL1xYXZY6AFiukhSH4TPRitnTQeJTDIyTnB64R4w8nO9bpVUYy5IgdoCKJoAsI h9HngL125LsYYbcVOgSPyBD7JHqiLDz0efmNY= Received: by 10.223.117.134 with SMTP id r6mr36702faq.147.1303325712376; Wed, 20 Apr 2011 11:55:12 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id l3sm369365fap.36.2011.04.20.11.55.10 (version=SSLv3 cipher=OTHER); Wed, 20 Apr 2011 11:55:11 -0700 (PDT) Sender: Alexander Motin Message-ID: <4DAF2BFC.3030504@FreeBSD.org> Date: Wed, 20 Apr 2011 21:54:52 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Bruce Cran References: <4DAEAE1B.70207@FreeBSD.org> <20110420132001.000058e1@unknown> <4DAECFDC.2050508@FreeBSD.org> <20110420191922.00002482@unknown> In-Reply-To: <20110420191922.00002482@unknown> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 18:55:15 -0000 Bruce Cran wrote: > On Wed, 20 Apr 2011 15:21:48 +0300 > Alexander Motin wrote: > >> Verbose dmesg from the fresh system would be appreciated. > > I've put a verbose dmesg at > http://www.cran.org.uk/~brucec/freebsd/dmesg.verbose_20110420.txt Thank you. I've compared your and Daniel dmesgs, and while they are showing different emulated controllers, the problems seems to be common: ata_generic_reset() reports two devices on the channel with CD, while there is only one. As result, attempts to send requests to the missing device predictably cause timeouts. I have doubts that problem is specific to CAM-based ATA. It looks more probable to me that difference is just in command timeouts: 1 second with legacy ATA, and 30 seconds with CAM. Could you show me verbose dmesg with legacy ATA to make sure? Same time I'll try to think what can we do about it. -- Alexander Motin From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 20:37:56 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 81262106564A; Wed, 20 Apr 2011 20:37:56 +0000 (UTC) (envelope-from uqs@spoerlein.net) Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by mx1.freebsd.org (Postfix) with ESMTP id 193F68FC0C; Wed, 20 Apr 2011 20:37:55 +0000 (UTC) Received: from localhost (acme.spoerlein.net [IPv6:2a01:4f8:131:23c2::1]) by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id p3KKbsaP007475 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 20 Apr 2011 22:37:54 +0200 (CEST) (envelope-from uqs@spoerlein.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net; s=dkim200908; t=1303331875; bh=3+duNg3P2Gp6orIFVRiVXe++fHJ3c+qy+mi9dluYQJM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=P/y4CaSIpJvNTkrFFRqX/NGDBfQPtbbCYLYuhaZuD7pR+nP39bci0taFu3OJCCTbQ ooq9FKyJH/xDx3JWAiHpzw0sGvVYFlov1hPWOwIoNoN7cIsUGOfAg8v+CCWDcJeqWN D9ZXkOc6Vi7Kwi2QD1wofTNNLR1hsnnbw+4JOMP0= Date: Wed, 20 Apr 2011 22:37:54 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: Alexander Motin Message-ID: <20110420203754.GM85668@acme.spoerlein.net> Mail-Followup-To: Alexander Motin , FreeBSD-Current References: <4DAEAE1B.70207@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DAEAE1B.70207@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 20:37:56 -0000 On Wed, 20.04.2011 at 12:57:47 +0300, Alexander Motin wrote: > Hi. > > With 9.0 release approaching quickly, I believe it the best time now to > manage migration from legacy ata(4) ATA to the new CAM-based one. New > ATA code present in the tree for more then a year now, used by many > people and proved it's superior functionality and reliability. The only > major issue with it now is the migration process. Sooner or later we > have to pass it, but due to major UI and API changes we can't do it > after 9.0 release. So I propose to do it the next Sunday (April 24) to > have as much time for troubleshooting as possible. > > I have prepared the following patch to do it: > http://people.freebsd.org/~mav/ata_switch.patch > > I haven't added geom_raid to the kernel configurations because we have > no other GEOM classes there. But tell me if you thing I should. > > If somebody has any problems with new ATA stack, please repeat your > tests with latest HEAD code and contact me if problem is still there. > Next three weeks before BSDCan I am going to dedicate to fixing possibly > remaining issues. Can we then please get the "ad" device prefix back? I seem to remember that when they were introduced they were thought to be a temporary thing ... Unless both stacks can run in parallel, I don't see a problem with having them both show up as /dev/ad0, etc. People with problems must send in a complete dmesg anyway, so it should be clear what stack they are running. The POLA violation for people upgrading from 8.x to 9.0 however is pretty big ... and unnecessary. Cheers, Uli From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 20:50:21 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4DA01065676 for ; Wed, 20 Apr 2011 20:50:21 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 331648FC21 for ; Wed, 20 Apr 2011 20:50:20 +0000 (UTC) Received: by fxm11 with SMTP id 11so965926fxm.13 for ; Wed, 20 Apr 2011 13:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=LNterwDkZNdSZNVHoi/oGbuUvGO+B5vQzf8nuikL3XQ=; b=U0fcEDPJvPQRnXX2uGZ1NMcwiMD12zDTGkFN+CRU14yN7GiTXgG2MNzhTrt/xodQAs FkbVJDXrgqPwwhLuUSBpV7twenDi19vPs+cfmSgj5hNP9jr4ttPVswSrl3m1WRzCEr98 I1zbeFf2Y6vFNrpgwgjOLTdOUOAGkaf0ZClno= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=lUm4DK+DJ2D0WKFsphGfNEf6y/naDuqlP/x2AaasAVNUe++ylWlESmrG2dH4XGHc75 CUWRGlImfb2n4jLwmF4gnJBS61eWRD/fQFYh3iovfkVnKcAHNH42UyeETcheAfILvmCP ZK3BpYz3Hn+naW2JybRmCx1ncsAHpYVTGxSQY= Received: by 10.223.30.82 with SMTP id t18mr2558733fac.106.1303332620253; Wed, 20 Apr 2011 13:50:20 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id f15sm396823fax.10.2011.04.20.13.50.18 (version=SSLv3 cipher=OTHER); Wed, 20 Apr 2011 13:50:19 -0700 (PDT) Sender: Alexander Motin Message-ID: <4DAF46F8.9040004@FreeBSD.org> Date: Wed, 20 Apr 2011 23:50:00 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Ulrich_Sp=F6rlein?= References: <4DAEAE1B.70207@FreeBSD.org> <20110420203754.GM85668@acme.spoerlein.net> In-Reply-To: <20110420203754.GM85668@acme.spoerlein.net> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 20:50:21 -0000 Ulrich Spörlein wrote: > Can we then please get the "ad" device prefix back? I seem to remember > that when they were introduced they were thought to be a temporary thing > ... > > Unless both stacks can run in parallel, I don't see a problem with > having them both show up as /dev/ad0, etc. People with problems must > send in a complete dmesg anyway, so it should be clear what stack they > are running. The POLA violation for people upgrading from 8.x to 9.0 > however is pretty big ... and unnecessary. Stacks do can run in parallel, and it really happens when people loading ahci(4) driver for SATA disks without using `options ATA_CAM` of ata(4) for PATA. As result, SATA will use new stack and PATA - old one. What's about POLA violation, it is inevitable, because present kernel uses ata(4) with ATA_STATIC_ID option, that is not applicable in modern SATA world order. So at least device numbers will change. Also you should take into account, that many people and some software already adapted to adaX names and change back will break POLA for them. -- Alexander Motin From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 21:02:21 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F629106566C for ; Wed, 20 Apr 2011 21:02:21 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id D1CD08FC08 for ; Wed, 20 Apr 2011 21:02:20 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id p3KKpFBg086433; Wed, 20 Apr 2011 22:51:15 +0200 (CEST) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.4/8.14.4/Submit) id p3KKpFIE086432; Wed, 20 Apr 2011 22:51:15 +0200 (CEST) (envelope-from marius) Date: Wed, 20 Apr 2011 22:51:15 +0200 From: Marius Strobl To: Alexander Motin Message-ID: <20110420205115.GA86399@alchemy.franken.de> References: <4DAEAE1B.70207@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DAEAE1B.70207@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 21:02:21 -0000 On Wed, Apr 20, 2011 at 12:57:47PM +0300, Alexander Motin wrote: > Hi. > > With 9.0 release approaching quickly, I believe it the best time now to > manage migration from legacy ata(4) ATA to the new CAM-based one. New > ATA code present in the tree for more then a year now, used by many > people and proved it's superior functionality and reliability. The only > major issue with it now is the migration process. Sooner or later we > have to pass it, but due to major UI and API changes we can't do it > after 9.0 release. So I propose to do it the next Sunday (April 24) to > have as much time for troubleshooting as possible. > > I have prepared the following patch to do it: > http://people.freebsd.org/~mav/ata_switch.patch > Could you please add descriptions of the controllers supported by ahci(4), mvs(4) and siis(4) to the kernel configuration files and preserve alphabetical ordering, i.e. list ata(4) after ahci(4)? Marius From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 21:18:08 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EC2B8106566C for ; Wed, 20 Apr 2011 21:18:07 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 731078FC0C for ; Wed, 20 Apr 2011 21:18:07 +0000 (UTC) Received: by fxm11 with SMTP id 11so983831fxm.13 for ; Wed, 20 Apr 2011 14:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type; bh=H+NmXM79EmsUY+hL5Tb4mEt0himJr+NhpSJ7ctWUoW0=; b=x8L/JU+7ZhK4HX1a/M2S39OywQANd1tpFJZru2iMZFk6XEuycrQ6/ilaPeX+s5VBBN YX2RP1wNkiAblXfODQnGuZjab8Cu+tFd3++0D6qntTiWGTCccUndVEkmUyCY1C1FtkQp QOzGPxxjnWZOntBlKcTm5wVIWCBgpAAUcAhe8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type; b=uQQy3TibB38zMVdkAhWB7eBU5Q0Gze2Pp0Z+cAYxHrPUwE9P8R+2+I6foFACiqjSXy Qg1pzJt7LsPQkGXhBu5eWfhPt0htged8CDEFet+RwOqMMMDeZ4MPHQHDuZ16v2bgBL1n +tedjKqNzfRgoOReAGfDWaizcoowJAe4vpt4k= Received: by 10.223.79.79 with SMTP id o15mr791099fak.16.1303334285202; Wed, 20 Apr 2011 14:18:05 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id o17sm401072fal.25.2011.04.20.14.18.03 (version=SSLv3 cipher=OTHER); Wed, 20 Apr 2011 14:18:04 -0700 (PDT) Sender: Alexander Motin Message-ID: <4DAF4D78.4010205@FreeBSD.org> Date: Thu, 21 Apr 2011 00:17:44 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Bruce Cran References: <4DAEAE1B.70207@FreeBSD.org> <20110420132001.000058e1@unknown> <4DAECFDC.2050508@FreeBSD.org> <20110420191922.00002482@unknown> <4DAF2BFC.3030504@FreeBSD.org> In-Reply-To: <4DAF2BFC.3030504@FreeBSD.org> X-Enigmail-Version: 0.96.0 Content-Type: multipart/mixed; boundary="------------040701020904010009010701" Cc: FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 21:18:08 -0000 This is a multi-part message in MIME format. --------------040701020904010009010701 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Alexander Motin wrote: > Bruce Cran wrote: >> On Wed, 20 Apr 2011 15:21:48 +0300 >> Alexander Motin wrote: >> >>> Verbose dmesg from the fresh system would be appreciated. >> I've put a verbose dmesg at >> http://www.cran.org.uk/~brucec/freebsd/dmesg.verbose_20110420.txt > > Thank you. I've compared your and Daniel dmesgs, and while they are > showing different emulated controllers, the problems seems to be common: > ata_generic_reset() reports two devices on the channel with CD, while > there is only one. As result, attempts to send requests to the missing > device predictably cause timeouts. I have doubts that problem is > specific to CAM-based ATA. It looks more probable to me that difference > is just in command timeouts: 1 second with legacy ATA, and 30 seconds > with CAM. Could you show me verbose dmesg with legacy ATA to make sure? > Same time I'll try to think what can we do about it. 2 Bruce: Looking on XEN sources, it seems that the only place how it differs missing and present disk is the device signature. ata(4) at this moment doesn't checks signature if it is not ATAPI and READY bit is set. Attached patch should solve the problem by using more strict check, and I only hope it won't break anything else. Try it please. 2 Daniel: Your situation is different, as both devices reported equally during soft-reset. The only place where I see difference is on SATA layer. But the funny thing is that I can't find SATA support in XEN sources. What are you using? Can you send me full verbose dmesg and `pciconf -lvcb`? -- Alexander Motin --------------040701020904010009010701 Content-Type: text/plain; name="ata_strict.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ata_strict.patch" Index: ata-lowlevel.c =================================================================== --- ata-lowlevel.c (revision 220837) +++ ata-lowlevel.c (working copy) @@ -535,7 +535,7 @@ if (lsb == ATAPI_MAGIC_LSB && msb == ATAPI_MAGIC_MSB) { ch->devices |= ATA_ATAPI_MASTER; } - else if (stat0 & ATA_S_READY) { + else if (lsb == 0 && msb == 0 && (stat0 & ATA_S_READY)) { ch->devices |= ATA_ATA_MASTER; } } @@ -568,7 +568,7 @@ if (lsb == ATAPI_MAGIC_LSB && msb == ATAPI_MAGIC_MSB) { ch->devices |= ATA_ATAPI_SLAVE; } - else if (stat1 & ATA_S_READY) { + else if (lsb == 0 && msb == 0 && (stat1 & ATA_S_READY)) { ch->devices |= ATA_ATA_SLAVE; } } --------------040701020904010009010701-- From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 21:26:43 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD1B01065688; Wed, 20 Apr 2011 21:26:43 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.cran.org.uk (muon.cran.org.uk [IPv6:2a01:348:0:15:5d59:5c40:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id 50D138FC18; Wed, 20 Apr 2011 21:26:43 +0000 (UTC) Received: from muon.cran.org.uk (localhost [127.0.0.1]) by muon.cran.org.uk (Postfix) with ESMTP id 68F32E61E5; Wed, 20 Apr 2011 22:26:42 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=cran.org.uk; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=mail; bh=lQn/sVq5gjWi S6Oglv94IBm/AeI=; b=KFAr8THk6nRShcWzGV4N+vCLZJWl68KxcAfN7cNiFU82 tvNqTO1/JeKxainrmf/r9NezeM7MalzPHjd7L86LOxcr0FaOLHRt8zmdu8qnUIiQ lvh9WEYlMWAGNrU08xS7pw6mLpaLp6k1+ByoouHp9Thws0kzm2IsnhA2lws+Zhw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=cran.org.uk; h=date:from:to :cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; q=dns; s=mail; b=kWYV3K Cqc8ksGnjd/oNSreffdwQmQqA+u1OalgVQJmVTZBJM6amW6N016gTivn0kPlwlIk yM5e9QuGqIdoT5z8BoskgWWMdcp1Q3aY7ZEVQkbwqw9DlEeWDjvoKcnMqFJ8Hlkw e3VobVMsqhZkSGNEYye49xij2gGC9bfGRO7vw= Received: from unknown (188-222-18-231.zone13.bethere.co.uk [188.222.18.231]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by muon.cran.org.uk (Postfix) with ESMTPSA id 23DB5E61DC; Wed, 20 Apr 2011 22:26:42 +0100 (BST) Date: Wed, 20 Apr 2011 22:26:36 +0100 From: Bruce Cran To: Alexander Motin Message-ID: <20110420222636.00006fcd@unknown> In-Reply-To: <4DAF2BFC.3030504@FreeBSD.org> References: <4DAEAE1B.70207@FreeBSD.org> <20110420132001.000058e1@unknown> <4DAECFDC.2050508@FreeBSD.org> <20110420191922.00002482@unknown> <4DAF2BFC.3030504@FreeBSD.org> X-Mailer: Claws Mail 3.7.8cvs9 (GTK+ 2.16.6; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 21:26:43 -0000 On Wed, 20 Apr 2011 21:54:52 +0300 Alexander Motin wrote: > Could you show me verbose dmesg with > legacy ATA to make sure? Same time I'll try to think what can we do > about it. You're right - with the verbose dmesg with ata(4) there are lines: unknown: FAILURE - ATA_IDENTIFY timed out LBA=0 The full dmesg is at http://www.cran.org.uk/~brucec/freebsd/dmesg.verbose_ata_20110420.txt . -- Bruce Cran From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 21:55:45 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E37C106566C; Wed, 20 Apr 2011 21:55:45 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.cran.org.uk (muon.cran.org.uk [IPv6:2a01:348:0:15:5d59:5c40:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id 959B38FC08; Wed, 20 Apr 2011 21:55:44 +0000 (UTC) Received: from muon.cran.org.uk (localhost [127.0.0.1]) by muon.cran.org.uk (Postfix) with ESMTP id A302EE61D9; Wed, 20 Apr 2011 22:55:43 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=cran.org.uk; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=mail; bh=y1v+ssDqAu65 +MKGmAfpl+WuGN0=; b=tIpz3vUGagsFA2dGIrU/4c2j5QXCraLC3J6KTxa7lF3G GiH6RS1ZI7uTvP5Vi7UYid/GQnnYEdK2jOrx4nqke14Vkb/GJOct1cN5pYf8tmSI UD/GsqgWTN+1tx8kV375Bs3nQQyU2MjFXioVOE7/jW7sZEdBIuy6hWLKGm64vSs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=cran.org.uk; h=date:from:to :cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; q=dns; s=mail; b=MmJQtR MDuv6WO2ZE12stYvrLAwg1PBRT+ps7UsZRNg5gHS9T/rJrK1txYWsd9768rweL+Y H/iCqrSdUgYNXR5Nc8GVgdRNapoy4RsZX2n44OQ1H5d8y3yDBDyE9xGJbVY+CIXz r/7ktKBIpdkErXkvawE5Kie6eYnU/v1pvaQsE= Received: from unknown (188-222-18-231.zone13.bethere.co.uk [188.222.18.231]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by muon.cran.org.uk (Postfix) with ESMTPSA id 52F7BE61D8; Wed, 20 Apr 2011 22:55:43 +0100 (BST) Date: Wed, 20 Apr 2011 22:55:37 +0100 From: Bruce Cran To: Alexander Motin Message-ID: <20110420225537.00002200@unknown> In-Reply-To: <4DAF4D78.4010205@FreeBSD.org> References: <4DAEAE1B.70207@FreeBSD.org> <20110420132001.000058e1@unknown> <4DAECFDC.2050508@FreeBSD.org> <20110420191922.00002482@unknown> <4DAF2BFC.3030504@FreeBSD.org> <4DAF4D78.4010205@FreeBSD.org> X-Mailer: Claws Mail 3.7.8cvs9 (GTK+ 2.16.6; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 21:55:45 -0000 On Thu, 21 Apr 2011 00:17:44 +0300 Alexander Motin wrote: > 2 Bruce: Looking on XEN sources, it seems that the only place how it > differs missing and present disk is the device signature. ata(4) at > this moment doesn't checks signature if it is not ATAPI and READY bit > is set. Attached patch should solve the problem by using more strict > check, and I only hope it won't break anything else. Try it please. That seems to have fixed it. Thanks! -- Bruce Cran From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 22:02:44 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A8262106566C; Wed, 20 Apr 2011 22:02:44 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id DF2608FC0A; Wed, 20 Apr 2011 22:02:43 +0000 (UTC) Received: by ewy1 with SMTP id 1so460378ewy.13 for ; Wed, 20 Apr 2011 15:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=Wy0R0Y+iXYmlXmTQ+imBBkMYukHvTh1tI84PXEa1nyc=; b=GPGB1iWRJyFPn6ANSlkUVtnZhtRp2KE54BwUCSgOdVegK5D5h7z4cdxK2Ep9shTncP ZOmj8Q50jOkVpfLsrMq6tuvcYBV71GCOxhYy4Bue7/7GYVFztIwuVXe/d9o6pkj1Mnpn xlUOZnLUMZlyG/u0AwzBxpXgwqSE1wxQUJkww= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=ZnGUe+lFLB6yV9+swukd/hG3dOnXQqnlyLVpHnEvpudDf0sAozh0wKOIxJqYx1iJDp rz9WkVKKuScJaHNkBQQaQk9P1nN8kiR2lKNWZ4EVOYawzqIZJ5tZRuPtEc5kBPtWdA6B GxDiB6dGfXG6vXJW3gRN2mbTQwz78vs5XD71w= MIME-Version: 1.0 Received: by 10.213.19.17 with SMTP id y17mr3322145eba.38.1303336962854; Wed, 20 Apr 2011 15:02:42 -0700 (PDT) Received: by 10.213.4.209 with HTTP; Wed, 20 Apr 2011 15:02:42 -0700 (PDT) In-Reply-To: <201104061429.50185.jhb@freebsd.org> References: <201104060836.56542.jhb@freebsd.org> <201104061429.50185.jhb@freebsd.org> Date: Wed, 20 Apr 2011 18:02:42 -0400 Message-ID: From: Ryan Stone To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, Ed Maste Subject: Re: sched_4bsd startup crash trying to run a bound thread on an AP that hasn't started X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 22:02:44 -0000 On Wed, Apr 6, 2011 at 2:29 PM, John Baldwin wrote: > I guess one other option would be something like this: > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (smp_started && (td->td_pinned !=3D 0 |= | td->td_flags & TDF_BOUND || > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ts->ts_flags & TSF_AFFINITY)) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (td->td_pinned !=3D 0) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0cpu =3D td= ->td_lastcpu; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0else if (td->td_flags & TD= F_BOUND) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* Find CP= U from bound runq. */ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0KASSERT(..= .); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0cpu =3D ts= ->ts_runq - &runq_pcpu[0]; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} else > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* Find a = valid CPU for our cpuset. */ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0cpu =3D sc= hed_pickcpu(td); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0ts->ts_runq =3D &runq_pcpu= [cpu]; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0single_cpu =3D 1; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0CTR3(KTR_RUNQ, ...); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} else { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0/* Global runq case. */ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} > > This also avoids duplicating some common code to all the single_cpu cases= . > > -- > John Baldwin > I went with this option. Does this look right? Index: sys/kern/sched_4bsd.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/kern/sched_4bsd.c (revision 220603) +++ sys/kern/sched_4bsd.c (working copy) @@ -1246,30 +1246,28 @@ } TD_SET_RUNQ(td); - if (td->td_pinned !=3D 0) { - cpu =3D td->td_lastcpu; + /* + * If SMP is not started, don't obey any requested CPU pinning as t= hat + * CPU has either not yet started or it is curcpu. Trying to run a + * thread on a CPU that has not yet started will panic the system. + */ + if (smp_started && (td->td_pinned !=3D 0 || td->td_flags & TDF_BOUN= D || + ts->ts_flags & TSF_AFFINITY)) { + if (td->td_pinned !=3D 0) + cpu =3D td->td_lastcpu; + else if (td->td_flags & TDF_BOUND) { + /* Find CPU from bound runq. */ + KASSERT(SKE_RUNQ_PCPU(ts), + ("sched_add: bound td_sched not on cpu runq")); + cpu =3D ts->ts_runq - &runq_pcpu[0]; + } else + /* Find a valid CPU for our cpuset */ + cpu =3D sched_pickcpu(td); ts->ts_runq =3D &runq_pcpu[cpu]; single_cpu =3D 1; CTR3(KTR_RUNQ, "sched_add: Put td_sched:%p(td:%p) on cpu%d runq", ts, = td, cpu); - } else if (td->td_flags & TDF_BOUND) { - /* Find CPU from bound runq. */ - KASSERT(SKE_RUNQ_PCPU(ts), - ("sched_add: bound td_sched not on cpu runq")); - cpu =3D ts->ts_runq - &runq_pcpu[0]; - single_cpu =3D 1; - CTR3(KTR_RUNQ, - "sched_add: Put td_sched:%p(td:%p) on cpu%d runq", ts, = td, - cpu); - } else if (ts->ts_flags & TSF_AFFINITY) { - /* Find a valid CPU for our cpuset */ - cpu =3D sched_pickcpu(td); - ts->ts_runq =3D &runq_pcpu[cpu]; - single_cpu =3D 1; - CTR3(KTR_RUNQ, - "sched_add: Put td_sched:%p(td:%p) on cpu%d runq", ts, = td, - cpu); } else { CTR2(KTR_RUNQ, "sched_add: adding td_sched:%p (td:%p) to gbl runq", ts= , From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 22:19:03 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C051B1065670; Wed, 20 Apr 2011 22:19:03 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 1AC928FC13; Wed, 20 Apr 2011 22:19:02 +0000 (UTC) Received: from [127.0.0.1] (pooker.samsco.org [168.103.85.57]) (authenticated bits=0) by pooker.samsco.org (8.14.4/8.14.4) with ESMTP id p3KMIxXg083011; Wed, 20 Apr 2011 16:18:59 -0600 (MDT) (envelope-from scottl@samsco.org) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=iso-8859-1 From: Scott Long In-Reply-To: <4DAF46F8.9040004@FreeBSD.org> Date: Wed, 20 Apr 2011 16:18:59 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <4DAEAE1B.70207@FreeBSD.org> <20110420203754.GM85668@acme.spoerlein.net> <4DAF46F8.9040004@FreeBSD.org> To: =?iso-8859-1?Q?Ulrich_Sp=F6rlein?= X-Mailer: Apple Mail (2.1084) X-Spam-Status: No, score=-50.0 required=3.8 tests=ALL_TRUSTED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.0 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on pooker.samsco.org Cc: Alexander Motin , FreeBSD-Current Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 22:19:03 -0000 On Apr 20, 2011, at 2:50 PM, Alexander Motin wrote: > Ulrich Sp=F6rlein wrote: >> Can we then please get the "ad" device prefix back? I seem to = remember >> that when they were introduced they were thought to be a temporary = thing >> ... >>=20 >> Unless both stacks can run in parallel, I don't see a problem with >> having them both show up as /dev/ad0, etc. People with problems must >> send in a complete dmesg anyway, so it should be clear what stack = they >> are running. The POLA violation for people upgrading from 8.x to 9.0 >> however is pretty big ... and unnecessary. >=20 > Stacks do can run in parallel, and it really happens when people = loading > ahci(4) driver for SATA disks without using `options ATA_CAM` of = ata(4) > for PATA. As result, SATA will use new stack and PATA - old one. >=20 > What's about POLA violation, it is inevitable, because present kernel > uses ata(4) with ATA_STATIC_ID option, that is not applicable in = modern > SATA world order. So at least device numbers will change. >=20 > Also you should take into account, that many people and some software > already adapted to adaX names and change back will break POLA for = them. I agree with what Alexander is saying, but I'd like to take it a step = further. We should all be using either mount-by-label, or be working to = introduce generic device names to GEOM. Right now, device names are an = implementation detail that have no functional use other than to = complicate the fstab. Disks exposed through the block layer are simply = direct-access block-array devices, nothing more. There's no functional = difference to the kernel or userland between ad, ar, da, aacd, mfid, = amrd, etc when it comes to reading and writing sectors off of them. But = yet we give them unique names and pretend that those names mean = something. We could give them all the name of "disk" and the system = would still function exactly that same. The name attributes are = interesting when it comes to doing out-of-band management, but it's also = trivial to create a human-readable map and a programatic API between the = generic name and the attribute name. Same goes for volumes labels, and = I'd almost argue that they're more powerful than generic device names. In other words, "ada" isn't the problem here, it's that we all still = think in terms of the 1980's when systems didn't autoconfigure and = device names were important hints to system functionality. That time = has thankfully passed, and it's time for us to catch up. Scott From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 22:35:39 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 25D43106564A; Wed, 20 Apr 2011 22:35:39 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 65-241-43-5.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id E48E214E298; Wed, 20 Apr 2011 22:35:38 +0000 (UTC) Message-ID: <4DAF5FBA.8080304@FreeBSD.org> Date: Wed, 20 Apr 2011 15:35:38 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.15) Gecko/20110319 Thunderbird/3.1.9 MIME-Version: 1.0 To: Scott Long References: <4DAEAE1B.70207@FreeBSD.org> <20110420203754.GM85668@acme.spoerlein.net> <4DAF46F8.9040004@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: FreeBSD-Current , Alexander Motin Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 22:35:39 -0000 On 04/20/2011 15:18, Scott Long wrote: > I agree with what Alexander is saying, but I'd like to take it a step further. We should all be using [...] mount-by-label +1 When I first saw this on linux my gut reaction was "ewwww, different." But now that I've worked with it a bit, I really like it. Doing this by default in 9.0 would be a really useful step forward, and would allow greater innovation down the road. Is there a handy tutorial somewhere for making this change in FreeBSD? Or is it even possible to do in a rational way? Doug -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/ From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 22:38:09 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D595106566C; Wed, 20 Apr 2011 22:38:09 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 0490B8FC0A; Wed, 20 Apr 2011 22:38:08 +0000 (UTC) Received: by pwj8 with SMTP id 8so785861pwj.13 for ; Wed, 20 Apr 2011 15:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=jQ1THlto0SCpFZgzqRSvIkZckRwZyzsrcbuvZpIOyto=; b=g3CkiflSG5XIyHTwcQhpzxJxStO75oepNlXbNk+Zd37Sl8ChL3jPtRWoUTzMd06GQA zpKwj2wGxlMb+wCeYg9dp2eDZIOMhTbZUVzphler8r0sxoTmgl6EDHEHqxHIh88YEukW dlDsUrbNqfcIO6qQSki8lE4A0mFJimiRKgBxM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Xsi2KB8U12vKi+M+Dl6s7H1eLhpO5AdvvDFILjgNXRGh4e9gHjN7a7RQSygoHAiCUk HDGmlNV8sl/LRysADfYWfZtDcfB1g1PjHf13cqHh2QS/QS4tui5g+sJdn6hsfpJ89BB7 bQ0XG225Qw9muLqgKZ1BqmwT7AcsJwIEJ8yu0= MIME-Version: 1.0 Received: by 10.68.62.132 with SMTP id y4mr3163444pbr.212.1303339088524; Wed, 20 Apr 2011 15:38:08 -0700 (PDT) Received: by 10.68.42.3 with HTTP; Wed, 20 Apr 2011 15:38:08 -0700 (PDT) In-Reply-To: <4DAF5FBA.8080304@FreeBSD.org> References: <4DAEAE1B.70207@FreeBSD.org> <20110420203754.GM85668@acme.spoerlein.net> <4DAF46F8.9040004@FreeBSD.org> <4DAF5FBA.8080304@FreeBSD.org> Date: Wed, 20 Apr 2011 15:38:08 -0700 Message-ID: From: Garrett Cooper To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD-Current , Alexander Motin Subject: Re: Switch from legacy ata(4) to CAM-based ATA X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 22:38:09 -0000 On Wed, Apr 20, 2011 at 3:35 PM, Doug Barton wrote: > On 04/20/2011 15:18, Scott Long wrote: >> >> I agree with what Alexander is saying, but I'd like to take it a step >> further. =A0We should all be using [...] mount-by-label > > +1 > > When I first saw this on linux my gut reaction was "ewwww, different." Bu= t > now that I've worked with it a bit, I really like it. Doing this by defau= lt > in 9.0 would be a really useful step forward, and would allow greater > innovation down the road. > > Is there a handy tutorial somewhere for making this change in FreeBSD? Or= is > it even possible to do in a rational way? glabel create