From owner-freebsd-emulation@FreeBSD.ORG Sun Jan 30 06:58:18 2011 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id 0D4521065672; Sun, 30 Jan 2011 06:58:18 +0000 (UTC) Date: Sun, 30 Jan 2011 06:58:18 +0000 From: Alexander Best To: Chagin Dmitry Message-ID: <20110130065818.GA7031@freebsd.org> References: <20110129122617.GA77148@freebsd.org> <20110129154538.GA50877@dchagin.static.corbina.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110129154538.GA50877@dchagin.static.corbina.ru> Cc: freebsd-emulation@freebsd.org Subject: Re: [patch] draft to add support for futex operators FUTEX_WAIT_BITSET and FUTEX_WAKE_BITSET to the linuxulator X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jan 2011 06:58:18 -0000 On Sat Jan 29 11, Chagin Dmitry wrote: > On Sat, Jan 29, 2011 at 12:26:17PM +0000, Alexander Best wrote: > > hi there, > > > > i've spent a couple of hours hacking support for futex operators > > FUTEX_WAIT_BITSET and FUTEX_WAKE_BITSET into the linuxulator. the following > > patch is far from perfect and in certain places it is probably doing the wrong > > thing, however it doesn't seem to break anything. > > > > i'd appreciate if somebody could have a look at the patch and point out any > > issues. please note that the patch also contains a few unrelated comment > > changes and such (however only very few). > > > > thanks in advance. > > > > the patch can be found in here: > > > > http://people.freebsd.org/~arundel/drafts/futex.diff > > hi, how i can test this? thnx :) the patch should apply cleanly to a recent HEAD. so far i've only tested it on arch amd64. try installing emulators/linux_dist-gentoo-stage3 and then do 'chroot /usr/local/gentoo-stage3 bash'. you'll notice that without the patch most applications (ls, grep, etc.) trigger a warning about FUTEX_WAIT_BITSET/ FUTEX_WAKE_BITSET being unimplemented. the patch should fix that. also you might want to try running the futex tests from the linux test project and darren hart's test suite (both described on http://wiki.freebsd.org/linux-kernel i believe). also it's important that any applications that use FUTEX_WAIT shouldn't be affected by this patch. you might want to try running flash, which makes heavy use of futexes. if the patch has a bad impact on flash then there's something wrong with my patch. cheers. alex > > -- > Have fun! > chd -- a13x