Date: Sat, 22 Jan 2011 17:06:05 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Pawel Jakub Dawidek <pjd@freebsd.org> Cc: freebsd-fs@freebsd.org Subject: Concerns over shim-layers for ZFS and kernel/userland namespace pollution Message-ID: <AANLkTikTcLMwDP9ec9UQgzLqEJWDb7u=6v_r=2mxoo7e@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
Hi Pawel, I've been trying to get rid of the time.h pollution in sys/time.h for POSIX conformance and I've run into a bit of a roadblock (referring to sys/cddl/compat/opensolaris/sys/time.h): 1. The clock_gettime call in gethrtime() can fail and the failure itself isn't captured. 2. The calls in many case assume userland behavior, being "return value", not "return errno, assign value to address passed in" 3. AFAICT the calls shouldn't be calling the clock_gettime syscall interface from userland; they should be calling the clock_gettime interface. I could be partly wrong here, but if so then some additional hacking will need to be made to pull in time.h as that's where clock_gettime must be defined according to our manpages and POSIX. There might be another preexisting KPI that can be used in its place. I haven't looked outside of that header for now. Comments on my above statements are more than welcome. Thanks, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikTcLMwDP9ec9UQgzLqEJWDb7u=6v_r=2mxoo7e>