From owner-freebsd-fs@FreeBSD.ORG Sun Oct 2 00:19:34 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A6DC8106564A; Sun, 2 Oct 2011 00:19:34 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 08C5D8FC0C; Sun, 2 Oct 2011 00:19:33 +0000 (UTC) Received: by wwe3 with SMTP id 3so3961374wwe.31 for ; Sat, 01 Oct 2011 17:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=LaO0Gm6CoMEAd8kcfQ6jZ0aIQGdWNnmKyb84kc55i30=; b=jbq/+Df79BP050WdYSF7YVg7Iy0wcR6ms//EpiQA6dbQUj+Y9pL20CYmU3MRnCkdj2 TEbALK0bUD1RrocGdlNa6voCf42mArdkxuMaPTAjzlGwQ6bc4iUjH+SGuUUN7SgKRj2E LlrCVJAalnhLBo5sseCZrKQnvq1abdZfp/6Bo= MIME-Version: 1.0 Received: by 10.216.229.86 with SMTP id g64mr1608669weq.42.1317514772717; Sat, 01 Oct 2011 17:19:32 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.216.182.3 with HTTP; Sat, 1 Oct 2011 17:19:32 -0700 (PDT) In-Reply-To: <201110012137.p91Lb6FI093841@chez.mckusick.com> References: <201110012137.p91Lb6FI093841@chez.mckusick.com> Date: Sun, 2 Oct 2011 02:19:32 +0200 X-Google-Sender-Auth: 0AZU2PJUCZ-d8xDlzYWASIq8nTQ Message-ID: From: Attilio Rao To: Kirk McKusick Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Garrett Cooper , Xin LI , freebsd-fs@freebsd.org Subject: Re: Need to force sync(2) before umounting UFS1 filesystems? X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Oct 2011 00:19:34 -0000 2011/10/1 Kirk McKusick : >> Date: Sat, 1 Oct 2011 12:44:04 -0700 >> Subject: Re: Need to force sync(2) before umounting UFS1 filesystems? >> From: Garrett Cooper >> To: Attilio Rao >> Cc: Kostik Belousov , >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 Kirk McKusick , freeb= sd-fs@freebsd.org, >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 Xin LI >> >> Ok. Now that I know this is the direction you guys want to go, I'll >> start testing the change. >> Thanks! >> -Garrett > > Thanks for throwing some testing at this. Please test my latest > proposed change (included below so you do not have to dig through > earlier email) as I believe that it has the least likelyhood of > problems and is what I am currently proposing to put in. I'm sorry if it wasn't clear in kib/my latest message, but we don't need the coveredvnode unlocking logic because of the tegge's commit. I just think we should commit the change in policy Kirk initially submitted + a comment on top of vfs_busy() explaining why the deadlock with coveredvnode cannot happen. Attilio --=20 Peace can only be achieved by understanding - A. Einstein