From owner-freebsd-hackers@FreeBSD.ORG Sun May 1 01:10:43 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0990E106566B for ; Sun, 1 May 2011 01:10:43 +0000 (UTC) (envelope-from dieterbsd@engineer.com) Received: from mailout-us.gmx.com (mailout-us.gmx.com [74.208.5.67]) by mx1.freebsd.org (Postfix) with SMTP id A4A138FC16 for ; Sun, 1 May 2011 01:10:42 +0000 (UTC) Received: (qmail 2646 invoked by uid 0); 1 May 2011 01:10:41 -0000 Received: from 67.206.162.173 by rms-us001.v300.gmx.net with HTTP Content-Type: text/plain; charset="utf-8" Date: Sun, 01 May 2011 01:10:37 +0000 From: "Dieter BSD" Message-ID: <20110501011039.287260@gmx.com> MIME-Version: 1.0 To: freebsd-hackers@freebsd.org X-Authenticated: #74169980 X-Flags: 0001 X-Mailer: GMX.com Web Mailer x-registered: 0 Content-Transfer-Encoding: 8bit X-GMX-UID: PYqEeAoDyH6nIQ7MAzNLcx5PUzc4ctHe Subject: Re: [RELEASE] New Boot-Loader Menu X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2011 01:10:43 -0000 > Already on the to-do list is to support ``loader_logo=...'' in > /boot/loader.conf Including an option for no logo? (For consoles that are slow and/or small, and for people that just don't like the logos.) >> Putting brackets around letters (and numbers) sounds good. >> If there is room, perhaps add a message explaining that >> the user should enter one of the choices in brackets. > > I think I'm going to have to play with this and see what we come up with. I > don't want to make it too "busy" if you know what I mean. That's with > respect to the brackets. As for adding a messages... things are a bit tight > and again, I'm afraid of making it too cluttered. I'll post some screenshots > of some mock-ups tomorrow, incorporating the various requests. > >> A help option would be useful, giving a reminder of what >> things like ACPI and APIC stand for, what "safe" mode does, etc. > > This is not altogether infeasible. Since this menu (unlike the current one) > has the ability to be wiped from screen and then recalled completely in the > original state is was left in ... implementing an F1 feature that reads text > from a file would be very do-able. If there is a help option that the user can figure out how to execute, the explaination about brackets (if you go that route), entering numbers, letters, and such could be included in the help screen(s) instead of the main menu page. >> Would be nice: a fix for having to lean on a key autorepeating >> for a couple seconds. > > Could you explain? I don't follow. On my Tyan Tomcat k8e 2865, just entering the number rarely if ever works. I have to either repeatedly bang away at the key or hold it down, letting the RS-232 terminal do the autorepeat thing, while hoping that it notices before the timer runs out. From owner-freebsd-hackers@FreeBSD.ORG Sun May 1 03:11:13 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5814E1065670 for ; Sun, 1 May 2011 03:11:13 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0D2E18FC0A for ; Sun, 1 May 2011 03:11:12 +0000 (UTC) Received: by iyj12 with SMTP id 12so5552153iyj.13 for ; Sat, 30 Apr 2011 20:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:x-openpgp-key-id:x-openpgp-key-fingerprint :x-openpgp-key-url; bh=WYNxJeLqPbzD7yVMlKyAmgAoK+6+4xxbpTrWaQ1vDtQ=; b=HcN1ypTAGDh7bKLmjJ3zhLaNnZ4wnAXRRdEh/zQZ5WxEI8tMIh7RJT6Q7KnPSd56tH A0EN0lwlM5xh5Xu8IpG4Ul0z/TRtBZy335oxzV7mpt/rkF4xA28FXDqyJ2eOjv1Qcq48 MuC3w7tXYE472B0I0JWyD7vGlqgZuoqfjX+28= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-openpgp-key-id :x-openpgp-key-fingerprint:x-openpgp-key-url; b=gh0RBmHsQVpC3s2rrcntYyGRaqYaquT8PHpPM0UNAGZo1F2JjyBVeMXf1FLBGdA7zn dnXlrOcgrdAxY8rOVzGNyq1E7mECxUWwJ1TkeLsLjB062ZHCgQcUvrq6yainlWrh8tjl DhgNHTG9r1/a/4mCyPRCiIElcpX6/6BA2h9k4= Received: by 10.231.25.137 with SMTP id z9mr5324239ibb.53.1304219472437; Sat, 30 Apr 2011 20:11:12 -0700 (PDT) Received: from DataIX.net (adsl-99-190-84-116.dsl.klmzmi.sbcglobal.net [99.190.84.116]) by mx.google.com with ESMTPS id f7sm1778640ibn.7.2011.04.30.20.11.10 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 30 Apr 2011 20:11:11 -0700 (PDT) Sender: "J. Hellenthal" Received: from DataIX.net (localhost [127.0.0.1]) by DataIX.net (8.14.4/8.14.4) with ESMTP id p413B7U2025313 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 30 Apr 2011 23:11:07 -0400 (EDT) (envelope-from jhell@DataIX.net) Received: (from jhell@localhost) by DataIX.net (8.14.4/8.14.4/Submit) id p413B501025304; Sat, 30 Apr 2011 23:11:05 -0400 (EDT) (envelope-from jhell@DataIX.net) Date: Sat, 30 Apr 2011 23:11:05 -0400 From: Jason Hellenthal To: Devin Teske Message-ID: <20110501031105.GA16357@DataIX.net> References: <20110430192737.287270@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm" Content-Disposition: inline In-Reply-To: X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E X-OpenPGP-Key-URL: http://bit.ly/0x89D8547E Cc: freebsd-hackers@freebsd.org, 'Dieter BSD' Subject: Re: [RELEASE] New Boot-Loader Menu X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2011 03:11:13 -0000 --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Devin, On Sat, Apr 30, 2011 at 04:00:47PM -0700, Devin Teske wrote: > >> Would be nice: "uname -v" of the kernel it will boot. > >That's a bit more technically challenging. I'll have another look at the >FICL words available, but I don't recall if there was a way to crawl the >object space of the items loaded with ``load'' (looking for the uname). I'm >open to suggestions if you had an idea of how to do this in Forth -- else >I'd think this would need to be a loader(8) modification. How about forgetting a mention of unmae & ... instead look into if we can support some sort of bootcode versioning to be displayed on the screen. This would serve to be very helpful in the future when for say a new version of bootcode for ZFS has to be installed then it would be easy for announce@ to simply say "A new version of ZFS has been MFCd and requires boot version >=3D X. To find out your version please see the bottom right hand corner of your boot screen." I would place a pretty good bet that loader(8) could be modified to export some sort of versioning of the bootcode to make this a easier stance for the user to gather information before a upgrade. --=20 Regards, (jhell) Jason Hellenthal --EVF5PPMfhYS0aIcm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) Comment: http://bit.ly/0x89D8547E iQEcBAEBAgAGBQJNvM9IAAoJEJBXh4mJ2FR+bXMH/iHBCo8H8RHSMEdY0fz2N20w qo1stCEzILUe8IHtFWDulezbL+jvEUlLZ/6+2XJv4SOOS0U4wMg6IVp2NjkOSNWF My5xAQATAFewpSbMC9gx9//nOqcfkay2vSYGDkBh87rj/943JpZMltvcrcqRbeO0 R/PE68BcD/twTiIfvtJgNkay02WQkIT7jtFhWpPkqnt2A1GSy1MzZVnDb1tuX8nQ h7rl6X9nMtLdw6iSgdMLBa70gjhpzAZd6FcNGtdFYEY4kwEMVTfBClCfkMkLmBsD EwUsQmVJJGMnfr+nGrdP6pOOBzGutooHczuG66I+8nfwmqeaJE1fcNMyXMo6Aqg= =V+9F -----END PGP SIGNATURE----- --EVF5PPMfhYS0aIcm-- From owner-freebsd-hackers@FreeBSD.ORG Sun May 1 03:38:44 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E650C106566B for ; Sun, 1 May 2011 03:38:44 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id ACBB48FC0C for ; Sun, 1 May 2011 03:38:44 +0000 (UTC) Received: from SBHFISLREXT03 ([10.132.254.62]) by SCSFISLTC01 (8.14.3/8.14.3) with ESMTP id p413chft017267; Sat, 30 Apr 2011 22:38:43 -0500 Received: from sbhfisltcgw01.FNFIS.COM (Not Verified[10.132.248.121]) by SBHFISLREXT03 with MailMarshal (v6, 5, 4, 7535) id ; Sat, 30 Apr 2011 22:39:21 -0500 Received: from SBHFISLTCGW07.FNFIS.COM ([10.132.248.135]) by sbhfisltcgw01.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Sat, 30 Apr 2011 22:38:42 -0500 Received: from [10.0.0.102] ([10.132.254.136]) by SBHFISLTCGW07.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 30 Apr 2011 22:38:42 -0500 Mime-Version: 1.0 (Apple Message framework v1084) From: Devin Teske In-Reply-To: <20110501011039.287260@gmx.com> Date: Sat, 30 Apr 2011 20:38:40 -0700 Message-Id: References: <20110501011039.287260@gmx.com> To: "Dieter BSD" X-Mailer: Apple Mail (2.1084) X-OriginalArrivalTime: 01 May 2011 03:38:42.0611 (UTC) FILETIME=[44764830:01CC07B1] Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-hackers@freebsd.org Subject: Re: [RELEASE] New Boot-Loader Menu X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2011 03:38:45 -0000 On Apr 30, 2011, at 6:10 PM, Dieter BSD wrote: >> Already on the to-do list is to support ``loader_logo=3D...'' in >> /boot/loader.conf >=20 > Including an option for no logo? (For consoles that are slow and/or > small, and for people that just don't like the logos.) The current behavior -- with what's in CVS today -- is to draw a logo for a= ll values of "loader_logo" except for "none". My menu differs slightly, improving functionality by defaulting to not draw= any logo for values we don't understand. Therefore "none" would have the d= esired effect (but so will "NO", "blank", "johnnycat", "billjoy", or even "= " -- all produce a menu with no logo). NOTE: If NULL, we don't display the = logo, however if unset, we'll default to displaying the chosen/sensible def= ault (going for `orbbw' to comply with the aforementioned compatibility dec= rees -- of which I fully agree with). This is to facilitate the loader.conf= (5) override ability. Currently, you'd make the change by altering the ``set logo=3D"orb"'' line = in /etc/menu.rc (line 10). In the next release, I plan to change the enviro= nment variable from "logo" to "loader_logo" for backward compatibility (all= owing loader.conf(5) override as previously mentioned). >=20 >>> Putting brackets around letters (and numbers) sounds good. >>> If there is room, perhaps add a message explaining that >>> the user should enter one of the choices in brackets. >>=20 >> I think I'm going to have to play with this and see what we come up with= . I >> don't want to make it too "busy" if you know what I mean. That's with >> respect to the brackets. As for adding a messages... things are a bit ti= ght >> and again, I'm afraid of making it too cluttered. I'll post some screens= hots >> of some mock-ups tomorrow, incorporating the various requests. >>=20 >>> A help option would be useful, giving a reminder of what >>> things like ACPI and APIC stand for, what "safe" mode does, etc. >>=20 >> This is not altogether infeasible. Since this menu (unlike the current o= ne) >> has the ability to be wiped from screen and then recalled completely in = the >> original state is was left in ... implementing an F1 feature that reads = text >> from a file would be very do-able. >=20 > If there is a help option that the user can figure out how to execute, > the explaination about brackets (if you go that route), entering numbers, > letters, and such could be included in the help screen(s) instead of the > main menu page. One of the decrees was that we shouldn't assume that there are function key= s. I think that's a fair decree, so that puts me in a quandry with the "Pre= ss F1 for Help" model of presentation. Although convenient programmatically= , it could potentially leave users without function-keys without an ability= to read the carefully prepared messages awaiting their keypress. There's really only room for one or two more menu items. Perhaps we could i= ntroduce a new menuitem after the reboot item. A menuitem whose number is p= erhaps not a number, but instead the question-mark. The text for which coul= d be "[H]elp" (keeping to the recent bracketed concept -- which could conce= ptually switch to underline if loader_color is set). >=20 >>> Would be nice: a fix for having to lean on a key autorepeating >>> for a couple seconds. >>=20 >> Could you explain? I don't follow. >=20 > On my Tyan Tomcat k8e 2865, just entering the number rarely if > ever works. I have to either repeatedly bang away at the key or > hold it down, letting the RS-232 terminal do the autorepeat thing, > while hoping that it notices before the timer runs out. Is that with the current code that's in CVS? I'd love for you to try my cod= e on that hardware. One of the things that I worked on in the very beginnin= g was the responsiveness. --=20 Cheers, Devin Teske -> LEGAL DISCLAIMER <- This message contains confidential and proprietary information of the sender, and is intended only for the person(s) to whom it is addressed. Any use, distribution, copying or disclosure by any other person is strictly prohibited. If you have received this message in error, please notify the e-mail sender immediately, and delete the original message without making a copy. -> FUN STUFF <- -----BEGIN GEEK CODE BLOCK----- Version 3.12 GAT/CS/B/CC/E/IT/MC/M/MU/P/S/TW d+(++) s: a- C+++@$ UB++++$ P++++@$ L++++$ = E- W+++ N? o? K? w@ O M++$ V- PS+>++ PE@ Y+ PGP-> t(+) 5? X(+) R(-) tv+ b+>++ = DI+ D+(++) G++ e>++++ h r+++ z+++ ------END GEEK CODE BLOCK------ http://www.geekcode.com/ -> END TRANSMISSION <- _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Sun May 1 03:45:22 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 352C81065674 for ; Sun, 1 May 2011 03:45:22 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id EFFFF8FC13 for ; Sun, 1 May 2011 03:45:21 +0000 (UTC) Received: from SBHFISLREXT03 ([10.132.254.62]) by SCSFISLTC02 (8.14.3/8.14.3) with ESMTP id p413jHZU026569; Sat, 30 Apr 2011 22:45:17 -0500 Received: from SBHFISLTCGW07.FNFIS.COM (Not Verified[10.132.248.135]) by SBHFISLREXT03 with MailMarshal (v6, 5, 4, 7535) id ; Sat, 30 Apr 2011 22:45:55 -0500 Received: from sbhfisltcgw01.FNFIS.COM ([10.132.248.121]) by SBHFISLTCGW07.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Sat, 30 Apr 2011 22:45:17 -0500 Received: from [10.0.0.102] ([10.132.254.136]) by sbhfisltcgw01.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 30 Apr 2011 22:45:15 -0500 Mime-Version: 1.0 (Apple Message framework v1084) From: Devin Teske In-Reply-To: <20110501031105.GA16357@DataIX.net> Date: Sat, 30 Apr 2011 20:45:14 -0700 Message-Id: References: <20110430192737.287270@gmx.com> <20110501031105.GA16357@DataIX.net> To: Jason Hellenthal X-Mailer: Apple Mail (2.1084) X-OriginalArrivalTime: 01 May 2011 03:45:15.0967 (UTC) FILETIME=[2EEBA4F0:01CC07B2] Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-hackers@freebsd.org, 'Dieter BSD' Subject: Re: [RELEASE] New Boot-Loader Menu X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2011 03:45:22 -0000 On Apr 30, 2011, at 8:11 PM, Jason Hellenthal wrote: >=20 > Devin, >=20 >=20 > On Sat, Apr 30, 2011 at 04:00:47PM -0700, Devin Teske wrote: >>=20 >>> Would be nice: "uname -v" of the kernel it will boot. >>=20 >> That's a bit more technically challenging. I'll have another look at the >> FICL words available, but I don't recall if there was a way to crawl the >> object space of the items loaded with ``load'' (looking for the uname). = I'm >> open to suggestions if you had an idea of how to do this in Forth -- else >> I'd think this would need to be a loader(8) modification. >=20 > How about forgetting a mention of unmae & ... instead look into if we > can support some sort of bootcode versioning to be displayed on the > screen. This would serve to be very helpful in the future when for say a > new version of bootcode for ZFS has to be installed then it would be > easy for announce@ to simply say "A new version of ZFS has been MFCd and > requires boot version >=3D X. To find out your version please see the > bottom right hand corner of your boot screen." >=20 > I would place a pretty good bet that loader(8) could be modified to > export some sort of versioning of the bootcode to make this a easier > stance for the user to gather information before a upgrade. Piece of cake! If you give me a loader(8) that exports a "version" environm= ent variable, I'll give the Forth functionality in mere seconds. It's alrea= dy been developed (but was not packaged). I have a module named "version.4th" which prints the value of the "version"= environment variable at the bottom-right of the screen underneath the beas= tie logo. Since you mention this, I'll add the code to the next package and if/when l= oader(8) ever exports a "version" environment variable, it will just magica= lly appear. How's that sound? >=20 > --=20 >=20 > Regards, (jhell) > Jason Hellenthal >=20 --=20 Cheers, Devin Teske -> LEGAL DISCLAIMER <- This message contains confidential and proprietary information of the sender, and is intended only for the person(s) to whom it is addressed. Any use, distribution, copying or disclosure by any other person is strictly prohibited. If you have received this message in error, please notify the e-mail sender immediately, and delete the original message without making a copy. -> FUN STUFF <- -----BEGIN GEEK CODE BLOCK----- Version 3.12 GAT/CS/B/CC/E/IT/MC/M/MU/P/S/TW d+(++) s: a- C+++@$ UB++++$ P++++@$ L++++$ = E- W+++ N? o? K? w@ O M++$ V- PS+>++ PE@ Y+ PGP-> t(+) 5? X(+) R(-) tv+ b+>++ = DI+ D+(++) G++ e>++++ h r+++ z+++ ------END GEEK CODE BLOCK------ http://www.geekcode.com/ -> END TRANSMISSION <- _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Sun May 1 11:19:54 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A2116106566B for ; Sun, 1 May 2011 11:19:54 +0000 (UTC) (envelope-from rank1seeker@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 2DCEF8FC1B for ; Sun, 1 May 2011 11:19:53 +0000 (UTC) Received: by bwz12 with SMTP id 12so5783810bwz.13 for ; Sun, 01 May 2011 04:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:from:to:subject:date:in-reply-to :references:x-mailer; bh=uTjlufLefTNah5K/nn3GHOmQVv/sQK9LqAVjHXEy9uw=; b=k87zNu7wi38BIbgSjj85cxUGpo3wIshAqON4XQ5I2SuTp97DT0QJVN08a6YtVmwlLi szUfHMAAEMK6W594yrdxnY9jWl7mFe8r5gZX6IiCapJ+yozVDKgIcR5JTdVopUPjqt8r tqnFlMKIvvuKZqz95ebn2Bf3BKo+nfV/VtE7U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:subject:date:in-reply-to:references:x-mailer; b=IedbgV7Ca6PbhK3wZnXh9XTaByYjas+YgtDstaOuTPVQm1hwwfz0ufJCIG8fOalVxv 1WwKIlMc8HQpGy+AP+E197Sr08pGVN2XL49tT1OEK/+xeJBOHDB2ZBq1mkjeQ4ocClnz RiGeLRsFMBKj2NXT6j3ObtZZk6RErEp5RF77c= Received: by 10.204.19.20 with SMTP id y20mr1559225bka.170.1304248793114; Sun, 01 May 2011 04:19:53 -0700 (PDT) Received: from DEV (93-139-36-29.adsl.net.t-com.hr [93.139.36.29]) by mx.google.com with ESMTPS id u15sm2640502bkf.4.2011.05.01.04.19.50 (version=SSLv3 cipher=OTHER); Sun, 01 May 2011 04:19:51 -0700 (PDT) Message-ID: <20110501.111952.296.2@DEV> From: rank1seeker@gmail.com To: freebsd-hackers@freebsd.org Date: Sun, 01 May 2011 13:19:52 +0200 In-Reply-To: <4DBC5D0A.3080008@FreeBSD.org> References: <4DBC3D63.6020508@FreeBSD.org> <4DBC5D0A.3080008@FreeBSD.org> X-Mailer: POP Peeper (3.7.0.0) Subject: Re: Look of boot2, on HDD X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2011 11:19:54 -0000 > On 30.04.2011 20:39, rank1seeker@gmail.com wrote: > >> Garrett Cooper wrote: > >>> 2011/4/29: > >>>> /boot/boot2 STAGE 2 bootstrap file > >>>> Understands the FreeBSD file system enough, to find files on it, and can provide a simple interface to choose the kernel or loader to run. > >>>> > >>>> Once sys is fully booted, HDD is 'ada0'. > >>>> However, STAGE 2, sees it, as a 'ad4', at boot process, which is same seen, by booted sys, when I turn off AHCI. > >>>> > >>>> So, here is the riddle ... > >>>> On fully booted sys, how do I query STAGE 2, to tell me, how it'll see, my 'ada0' HDD? > >>> > >>> This is a very interesting catch: > >>> > >>> /usr/src/sys/boot/pc98/boot2/boot2.c:static const char *const > >>> dev_nm[NDEV] = {"ad", "da", "fd"}; > >>> /usr/src/sys/boot/i386/boot2/boot2.c:static const char *const > >>> dev_nm[NDEV] = {"ad", "da", "fd"}; > >>> > >>> It probably will be a no-op soon because of some of the > >>> compatibility changes Alex made, but still a potential point of > >>> confusion nonetheless. > >> > >> Pardon my ignorance, but could somebody shed some light for me on this > >> list of names? Why much more sophisticated loader(8) operates disks as > >> diak0/1/..., while boot2 tries to mimic something he has no any idea > >> about, using very limited information from random sources? Does this > >> names important for anything? > >> > >> Even with old ATA names didn't match on my laptop: boot2 reports ad0, > >> while system - ad4. Also we have a lot of drivers who's disk names don't > >> fit into this set of ad, da and fd. > > > > Well ..., ATM, I say lets NOT touch/edit boot2 nor loader. > > Let them continue to see devices, the way they "like" ... > > League for the robots rights? :) LOL! > > NOW, all I would like, is to find a way of ASKING them, how will they see "$target" device, at theirs boot step/time. > > "Asking" is done, on a fully booted sys and I am interested in asking STAGE 2 (boot2). > > I think it may be impossible. It is up to each controller's BIOS to > report device or not. And some controllers may just have no/disabled > BIOS to report anything. Artificial separation between ad and da in > boot2 also doesn't makes thinks easier. > Ah, I see ..., so, the only solution, is to reboot and see for yourself, as it is hardware dependant outcome. Run, in some virtual env, as qemu or virtualbox, wouldn't help here, right? From owner-freebsd-hackers@FreeBSD.ORG Sun May 1 14:45:22 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3BD72106564A for ; Sun, 1 May 2011 14:45:22 +0000 (UTC) (envelope-from moeller.akt@googlemail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id B561A8FC08 for ; Sun, 1 May 2011 14:45:21 +0000 (UTC) Received: by bwz12 with SMTP id 12so5867058bwz.13 for ; Sun, 01 May 2011 07:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=2Ekuba4gVifDCJBi07BiMc4b3qmRdCZwdcIdn4TVKcw=; b=vKUyL0KCM5ZjVJpvNNJOpvi8KLoEXl60vz8ihZX15+q6ZuIzBELlVIBbO5PecjqAma 2RB5Q14fFBGixWHyosMPeYL6TC5MmVT9RM40KM6eg95Zeys78r34hzH/oaclBGGgU6XM lze7/ZAdsM5CtPnQ8GYR4BXGI0k9qemMXrQLQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=YdfPs8zqF2F591o1R6FsBrpZN4PvK0lJVZWo+qFVDojezvvnLyA8zeMDgijfebvInn M8XFQr8lcH8uhdaYuiIrr6Cen37F4dY0CiN/SpFdEMEZO4kKg8K6wnSUMFC+XOkzb9y2 3y1dJdjmnZcokwqA3Eisert/6ZeGi3hJ2/1hw= Received: by 10.204.139.199 with SMTP id f7mr5833158bku.23.1304261120349; Sun, 01 May 2011 07:45:20 -0700 (PDT) Received: from [192.168.0.108] (p5B24E7F5.dip.t-dialin.net [91.36.231.245]) by mx.google.com with ESMTPS id d11sm2724739bka.7.2011.05.01.07.45.18 (version=SSLv3 cipher=OTHER); Sun, 01 May 2011 07:45:19 -0700 (PDT) User-Agent: Microsoft-Entourage/12.0.0.071130 Date: Sun, 01 May 2011 16:45:14 +0200 From: Martin =?ISO-8859-1?B?TfZsbGVy?= To: Daniel O'Connor Message-ID: Thread-Topic: [LIBC] Modfied Version of sscanf Thread-Index: AcwIDmEvE7dfJmzaSRq3U7kWysP1SQ== In-Reply-To: <6ACFC545-73B5-49FA-A97F-BC500F9AFE40@gsoft.com.au> Mime-version: 1.0 Content-type: text/plain; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable Cc: freebsd-hackers@freebsd.org Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2011 14:45:22 -0000 Am 01.05.11 00:53 schrieb "Daniel O'Connor" unter : Thanks for your reply. Ok, another example. I try to parse a request, coming from a client in the form: GET HTTP/1.1. It is expected that can contain space characters (even if its not the case in reality). How would you do that with sscanf ? With regards, Martin >=20 > On 01/05/2011, at 2:14, Martin M=F6ller wrote: >> outputs total garbage on my FreeBSD-7.0-RELEASE #0 amd64. >> Is there already a way to do this or should we release a new version of >> sscanf, e.g. called sscanfWS. >>=20 >> This modified version would output: Test 2->Test 3. >=20 > I think it does what it should.. %s is supposed to stop at whitespace. >=20 > You probably really want.. >=20 > #include > #include > #include >=20 > int > main(int argc, char **argv) { > char name [20], value [20]; > int i; >=20 > i =3D sscanf("Test 2->Test 3", "%[^-]->%[^-]", name, value); > printf("%d %s->%s\n", i, name, value); >=20 > exit(0); > } >=20 > -- > Daniel O'Connor software and network engineer > for Genesis Software - http://www.gsoft.com.au > "The nice thing about standards is that there > are so many of them to choose from." > -- Andrew Tanenbaum > GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C >=20 >=20 >=20 >=20 >=20 >=20 From owner-freebsd-hackers@FreeBSD.ORG Sun May 1 16:29:27 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCBE41065673 for ; Sun, 1 May 2011 16:29:27 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104]) by mx1.freebsd.org (Postfix) with ESMTP id 77C918FC17 for ; Sun, 1 May 2011 16:29:27 +0000 (UTC) Received: from turtle.stack.nl (turtle.stack.nl [IPv6:2001:610:1108:5010::132]) by mx1.stack.nl (Postfix) with ESMTP id 0E4A4359397; Sun, 1 May 2011 18:29:26 +0200 (CEST) Received: by turtle.stack.nl (Postfix, from userid 1677) id EC4EB17376; Sun, 1 May 2011 18:29:25 +0200 (CEST) Date: Sun, 1 May 2011 18:29:25 +0200 From: Jilles Tjoelker To: Martin =?iso-8859-1?Q?M=F6ller?= Message-ID: <20110501162925.GB47497@stack.nl> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-hackers@freebsd.org Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2011 16:29:27 -0000 On Sat, Apr 30, 2011 at 06:44:43PM +0200, Martin Möller wrote: > This is my first email to this list, so hello to all members. > The current version of sscanf, stops when a whitespace characters occurs in > a string > when the "%s" (string) type is used. > The following code: > char name [20], value [20]; > sscanf ("Test 2->Test 3", "%s->%s", name, value); > printf ("%s->%s\n", name, value); > outputs total garbage on my FreeBSD-7.0-RELEASE #0 amd64. > Is there already a way to do this or should we release a new version of > sscanf, e.g. called sscanfWS. > This modified version would output: Test 2->Test 3. I think you should use functions like memchr(), strchr() and strtok_r() rather than sscanf(). For one, your code has undefined behaviour if the name or the value exceed 19 bytes. If the input is untrusted, as your follow-up seems to indicate, this undefined behaviour likely manifests in allowing an attacker to execute code of his own choosing. Even if you avoid the buffer overflow using a format string like "%19s->%19s" it is still not very good as you may not get an error if the string is too long. Silent truncation might invalidate security checks done elsewhere and can lead to hard-to-diagnose bugs. -- Jilles Tjoelker From owner-freebsd-hackers@FreeBSD.ORG Sun May 1 16:42:26 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 058D4106564A for ; Sun, 1 May 2011 16:42:26 +0000 (UTC) (envelope-from db@db.net) Received: from diana.db.net (diana.db.net [66.113.102.10]) by mx1.freebsd.org (Postfix) with ESMTP id E203F8FC0A for ; Sun, 1 May 2011 16:42:25 +0000 (UTC) Received: from night.db.net (localhost [127.0.0.1]) by diana.db.net (Postfix) with ESMTP id 7C7772283B; Sun, 1 May 2011 10:20:08 -0600 (MDT) Received: by night.db.net (Postfix, from userid 1000) id 651085E23; Sun, 1 May 2011 12:25:04 -0400 (EDT) Date: Sun, 1 May 2011 12:25:04 -0400 From: Diane Bruce To: Martin M?ller Message-ID: <20110501162504.GA81754@night.db.net> References: <6ACFC545-73B5-49FA-A97F-BC500F9AFE40@gsoft.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: freebsd-hackers@freebsd.org Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2011 16:42:26 -0000 On Sun, May 01, 2011 at 04:45:14PM +0200, Martin M?ller wrote: > Am 01.05.11 00:53 schrieb "Daniel O'Connor" unter : > > Thanks for your reply. > Ok, another example. I try to parse a request, coming from a client in the > form: > GET HTTP/1.1. > > It is expected that can contain space characters (even if > its not the case in reality). > > How would you do that with sscanf ? You don't. You write a tokeniser and parser. You are trying to misuse sscanf. - Diane -- - db@FreeBSD.org db@db.net http://www.db.net/~db Why leave money to our children if we don't leave them the Earth? From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 12:13:17 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6CFCF1065670 for ; Mon, 2 May 2011 12:13:17 +0000 (UTC) (envelope-from moeller.akt@googlemail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id E80288FC1E for ; Mon, 2 May 2011 12:13:16 +0000 (UTC) Received: by bwz12 with SMTP id 12so6557672bwz.13 for ; Mon, 02 May 2011 05:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=0Auw7M90IpWMifz5cqU+LWjUzGYiimptkCd385osAO4=; b=LxGB1RxnExVJaw//2PMZN3dZtHXG8vNGJ2vNeqPUDBtn6yIzwb2pGcMhKUSNCNJFra RiazbkJVkz12vDcTKCtgg1qCUYCsmBuiSosHZRCywwxSvfo1cv5YMF9oWBEiv4YP1Jdl Hcsc8GcBbkFIqwEqbGwWexgK012PWIW24WUiM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=uVYT72339j2h3F2IIRzVhZ1SjaH4kir1ATdWfA8Y0oyk0cjl+qNLB0E1zD8T10va9+ 4i1CMCYnZjEMdmQBF98a/poFSA+Mr0CjgHzNFPpyAVVotQMpwtzKDaeBax93ZUlBYjOd TlmqRhfRCoCrgldu3xcS2k/wJ+oja3dnBJI/U= Received: by 10.204.229.193 with SMTP id jj1mr2462340bkb.21.1304338395585; Mon, 02 May 2011 05:13:15 -0700 (PDT) Received: from [192.168.0.108] (p5B24CEC4.dip.t-dialin.net [91.36.206.196]) by mx.google.com with ESMTPS id c11sm3259217bkc.14.2011.05.02.05.13.13 (version=SSLv3 cipher=OTHER); Mon, 02 May 2011 05:13:14 -0700 (PDT) User-Agent: Microsoft-Entourage/12.0.0.071130 Date: Mon, 02 May 2011 14:13:11 +0200 From: Martin =?ISO-8859-1?B?TfZsbGVy?= To: Message-ID: Thread-Topic: [LIBC] Modfied Version of sscanf Thread-Index: AcwIwk3eMnnzSYUUSLGl9Lolund+ag== In-Reply-To: <20110501162925.GB47497@stack.nl> Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 12:13:17 -0000 Hello, Thanks for all the replies. We have so far discovered the following suggetions for the parsing Problem: Using: o a tokenizer/parser is too much overhead for such a simple task o strchr, memchr is too low-level and not elegant enough o strtok would not even parse (tokenize) this simple example o a regexp library: How would you solve the problem with a regexp lib ? Criteria: o Receive the value of o Check the Environment: Is really sourrounded by 'GET ' and 'HTTP/1.1' ?! I need a function which accepts BNF-style rules. E.g.: char resource [512]; ret = bnfparse (request, "GET %s HTTP/1.1", resource); Ret would be $(NUMBER OF FORMAT SPECIFIERS, successfully handled) +env. Env would be 1 if the Environment passes, and 0 is not. Any comments ? Best regards, Martin From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 13:07:03 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C171106564A for ; Mon, 2 May 2011 13:07:03 +0000 (UTC) (envelope-from joerg@britannica.bec.de) Received: from mo-p00-ob.rzone.de (mo-p00-ob.rzone.de [81.169.146.161]) by mx1.freebsd.org (Postfix) with ESMTP id 342678FC16 for ; Mon, 2 May 2011 13:07:02 +0000 (UTC) X-RZG-AUTH: :JiIXek6mfvEEUpFQdo7Fj1/zg48CFjWjQv0cW+St/nW/YPAwti93ltYhxHqcfQ== X-RZG-CLASS-ID: mo00 Received: from britannica.bec.de (dslb-088-072-198-082.pools.arcor-ip.net [88.72.198.82]) by post.strato.de (fruni mo24) (RZmta 25.17) with (DHE-RSA-AES128-SHA encrypted) ESMTPA id v053e3n42CC2RT for ; Mon, 2 May 2011 14:55:23 +0200 (MEST) Received: by britannica.bec.de (sSMTP sendmail emulation); Mon, 02 May 2011 14:55:22 +0200 Date: Mon, 2 May 2011 14:55:22 +0200 From: Joerg Sonnenberger To: freebsd-hackers@freebsd.org Message-ID: <20110502125522.GA17312@britannica.bec.de> Mail-Followup-To: freebsd-hackers@freebsd.org References: <20110501162925.GB47497@stack.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 13:07:03 -0000 On Mon, May 02, 2011 at 02:13:11PM +0200, Martin Möller wrote: > o strchr, memchr is too low-level and not elegant enough Actually, you are looking for strstr. Joerg From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 13:26:48 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15F9F106566B for ; Mon, 2 May 2011 13:26:48 +0000 (UTC) (envelope-from rs@bytecamp.net) Received: from mail.bytecamp.net (mail.bytecamp.net [212.204.60.9]) by mx1.freebsd.org (Postfix) with ESMTP id 4E87E8FC08 for ; Mon, 2 May 2011 13:26:46 +0000 (UTC) Received: (qmail 46461 invoked by uid 89); 2 May 2011 15:00:06 +0200 Received: from stella.bytecamp.net (HELO ?212.204.60.37?) (rs%bytecamp.net@212.204.60.37) by mail.bytecamp.net with CAMELLIA256-SHA encrypted SMTP; 2 May 2011 15:00:06 +0200 Message-ID: <4DBEAAD5.7040906@bytecamp.net> Date: Mon, 02 May 2011 15:00:05 +0200 From: Robert Schulze Organization: bytecamp GmbH User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 13:26:48 -0000 Hi, Am 02.05.2011 14:13, schrieb Martin Möller: > > Criteria: > o Receive the value of > o Check the Environment: Is really sourrounded by 'GET ' and > 'HTTP/1.1' ?! these quite simple criteria might be matched by code like this one: char *ptr=NULL; char *res=NULL; if(strstr(str,"GET ")==str) /* "GET " at beginning? */ { ptr=(str+4); if(ptr && (ptr=strstr(ptr," HTTP/1.1"))) /* find end of res */ { *ptr=0; /* temp delimiter */ res=strdup(ptr); *ptr=' '; /* restore original value of str */ } } res is the value of , or NULL. with kind regards, Robert Schulze From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 14:06:34 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 306B41065670 for ; Mon, 2 May 2011 14:06:34 +0000 (UTC) (envelope-from artemb@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.216.175]) by mx1.freebsd.org (Postfix) with ESMTP id 9DA458FC1A for ; Mon, 2 May 2011 14:06:33 +0000 (UTC) Received: by qyk35 with SMTP id 35so1447162qyk.13 for ; Mon, 02 May 2011 07:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=TbLeZO5H9/Rqqd+Mdx4JfzIyyLrKYLqSP7ybgbyeYHc=; b=CAq04VBugrpEEUON8YjjWm7aVMi9wPVEvzPNfudf5XPwHEUYsfXkm7UCE8a3CK0Fqj YuhEOa3nMOYamh9rdU04zmgcHov590fb+6R/oK07sQ4mEPMba/LPvp5Tp9JyV5K51FGY 631k4DzPbilUoLmBhjDLHt+WUZUYuPFFXSOBs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=S4dRpuZA3FaxROG7r9de0yHegKuREukTPXZlYzGXcyezmTRmI5IaDBlPOMBdkLXB7m QEv2AA/f94gLwDHJlUOQJN6aswnnD7AtfHI3wQ7yuoaLh3gm4V65Dj6/D+Ka3qf7CLVr ILOa7nOEAUKyhaI6vJ2SfeIHIYpRbrUVzctS8= MIME-Version: 1.0 Received: by 10.229.27.193 with SMTP id j1mr6252791qcc.82.1304345192569; Mon, 02 May 2011 07:06:32 -0700 (PDT) Sender: artemb@gmail.com Received: by 10.229.95.140 with HTTP; Mon, 2 May 2011 07:06:32 -0700 (PDT) In-Reply-To: <4DBEAAD5.7040906@bytecamp.net> References: <4DBEAAD5.7040906@bytecamp.net> Date: Mon, 2 May 2011 07:06:32 -0700 X-Google-Sender-Auth: ul5SLXmGR7X5kwAt9N8q7BhEALA Message-ID: From: Artem Belevich To: Robert Schulze Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 14:06:34 -0000 On Mon, May 2, 2011 at 6:00 AM, Robert Schulze wrote: > Hi, > > Am 02.05.2011 14:13, schrieb Martin M=F6ller: >> >> Criteria: >> =A0 =A0 o Receive the value of >> =A0 =A0 o Check the Environment: Is =A0really sourrounded by '= GET ' >> and >> =A0 =A0 =A0 'HTTP/1.1' ?! > > these quite simple criteria might be matched by code like this one: > > char *ptr=3DNULL; > char *res=3DNULL; > if(strstr(str,"GET ")=3D=3Dstr) /* "GET " at beginning? */ > =A0 =A0 =A0 =A0{ > =A0 =A0 =A0 =A0ptr=3D(str+4); > =A0 =A0 =A0 =A0if(ptr && (ptr=3Dstrstr(ptr," HTTP/1.1"))) /* find end of = res */ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0{ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*ptr=3D0; /* temp delimiter */ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0res=3Dstrdup(ptr); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*ptr=3D' '; /* restore original value of s= tr */ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} > =A0 =A0 =A0 =A0} Bzzt! Try it on "GET blah_HTTP/1.1.1.1.1.1_whatever HTTP/1.1" > > res is the value of , or NULL. > Second problem -- res on success will always be "" as you've just did *ptr= =3D0. --Artem > with kind regards, > Robert Schulze > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org= " > From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 14:15:24 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C0B101065675 for ; Mon, 2 May 2011 14:15:24 +0000 (UTC) (envelope-from rs@bytecamp.net) Received: from mail.bytecamp.net (mail.bytecamp.net [212.204.60.9]) by mx1.freebsd.org (Postfix) with ESMTP id F08D18FC13 for ; Mon, 2 May 2011 14:15:23 +0000 (UTC) Received: (qmail 15788 invoked by uid 89); 2 May 2011 16:15:22 +0200 Received: from stella.bytecamp.net (HELO ?212.204.60.37?) (rs%bytecamp.net@212.204.60.37) by mail.bytecamp.net with CAMELLIA256-SHA encrypted SMTP; 2 May 2011 16:15:22 +0200 Message-ID: <4DBEBC7A.60607@bytecamp.net> Date: Mon, 02 May 2011 16:15:22 +0200 From: Robert Schulze Organization: bytecamp GmbH User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org References: <4DBEAAD5.7040906@bytecamp.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 14:15:24 -0000 Hi, Am 02.05.2011 16:06, schrieb Artem Belevich: > > Second problem -- res on success will always be "" as you've just did *ptr=0. thats right, the copy should look like: res=strdup(str+4); > Bzzt! > > Try it on "GET blah_HTTP/1.1.1.1.1.1_whatever HTTP/1.1" will return "blah_HTTP/1.1.1.1.1.1_whatever" as resource. It should be the next step to check whether is valid. with kind regards, Robert Schulze From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 14:36:33 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6CDB9106566B; Mon, 2 May 2011 14:36:33 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 436668FC1A; Mon, 2 May 2011 14:36:33 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id EED9F46B23; Mon, 2 May 2011 10:36:32 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 6D0608A027; Mon, 2 May 2011 10:36:32 -0400 (EDT) From: John Baldwin To: freebsd-hackers@freebsd.org Date: Mon, 2 May 2011 09:26:52 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <20110429.160309.656.1@DEV> <4DBC3D63.6020508@FreeBSD.org> In-Reply-To: <4DBC3D63.6020508@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105020926.53164.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Mon, 02 May 2011 10:36:32 -0400 (EDT) Cc: Alexander Motin Subject: Re: Look of boot2, on HDD X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 14:36:33 -0000 On Saturday, April 30, 2011 12:48:35 pm Alexander Motin wrote: > Garrett Cooper wrote: > > 2011/4/29 : > >> /boot/boot2 STAGE 2 bootstrap file > >> Understands the FreeBSD file system enough, to find files on it, and can provide a simple interface to choose the kernel or loader to run. > >> > >> Once sys is fully booted, HDD is 'ada0'. > >> However, STAGE 2, sees it, as a 'ad4', at boot process, which is same seen, by booted sys, when I turn off AHCI. > >> > >> So, here is the riddle ... > >> On fully booted sys, how do I query STAGE 2, to tell me, how it'll see, my 'ada0' HDD? > > > > This is a very interesting catch: > > > > /usr/src/sys/boot/pc98/boot2/boot2.c:static const char *const > > dev_nm[NDEV] = {"ad", "da", "fd"}; > > /usr/src/sys/boot/i386/boot2/boot2.c:static const char *const > > dev_nm[NDEV] = {"ad", "da", "fd"}; > > > > It probably will be a no-op soon because of some of the > > compatibility changes Alex made, but still a potential point of > > confusion nonetheless. > > Pardon my ignorance, but could somebody shed some light for me on this > list of names? Why much more sophisticated loader(8) operates disks as > diak0/1/..., while boot2 tries to mimic something he has no any idea > about, using very limited information from random sources? Does this > names important for anything? They are no longer important. Before /boot/loader existed, boot2 passed the root device to the kernel via 'bootdev'. It basically handled floppies (fdX for BIOS devices < 0x80) and hard drives (devices starting at 0x80, either ATA (wdX) or SCSI (sdX)). I think the user could hint what the root device was via /boot.config similar to 'vfs.mountroot' in loader.conf. Due to CAM (in 3.x) and sos's new ATA (in 4.x), wd and sd were renamed to 'ad' and 'da'. At this point however, it is mostly archaic. boot2 still passes info in bootdev that the loader uses, but all the loader cares about is the BIOS device number partition/slice information on that device. I would be happy for boot2 to be changed to use the same naming scheme that /boot/loader uses (diskX), but it's fairly low priority. -- John Baldwin From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 14:41:58 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1879E106567A for ; Mon, 2 May 2011 14:41:58 +0000 (UTC) (envelope-from artemb@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.216.175]) by mx1.freebsd.org (Postfix) with ESMTP id C16578FC33 for ; Mon, 2 May 2011 14:41:57 +0000 (UTC) Received: by qyk35 with SMTP id 35so1471414qyk.13 for ; Mon, 02 May 2011 07:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=b4AXGjMdi6va9OECcJ1CrHXKLn70Q1nQo0t+mNRtN9w=; b=FnsFp/bCgaOw8awa9K/kc6vlgTTDb/SQFc8+ohFemQjq8sEhjn1ylWzXeXPhKjXi3S TejC/A3HcKOBt9aTh97K5gkZCt3QKhM0N6v1K6yWsutR+bJv8/hicpt0Vrkur0kDEKA2 9uh6e8yV6ZPNgKGuu39Ko4sXfcmzHfLqKlGgg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=LJiroySSDeo68UG2QWdbwRoVzNaMdeoVhz1MifDSS9DV+t/dEAKamIONexlvsqVRZO CPQowE7l7XaKx9jyyeY53OVvJrBsuU/53gnTalqZrFzBKf8AyVP3zjtq/9w/1rkdUgK/ Ml1UnvWJBzhJLvZ3PDeeq2cVhGODbzugMKl8Y= MIME-Version: 1.0 Received: by 10.229.130.3 with SMTP id q3mr6325861qcs.44.1304347316904; Mon, 02 May 2011 07:41:56 -0700 (PDT) Sender: artemb@gmail.com Received: by 10.229.95.140 with HTTP; Mon, 2 May 2011 07:41:56 -0700 (PDT) In-Reply-To: <4DBEBC7A.60607@bytecamp.net> References: <4DBEAAD5.7040906@bytecamp.net> <4DBEBC7A.60607@bytecamp.net> Date: Mon, 2 May 2011 07:41:56 -0700 X-Google-Sender-Auth: JpEcnP09fARapV_S1lkBTqmBUfk Message-ID: From: Artem Belevich To: Robert Schulze Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-hackers@freebsd.org Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 14:41:58 -0000 On Mon, May 2, 2011 at 7:15 AM, Robert Schulze wrote: > Hi, > > Am 02.05.2011 16:06, schrieb Artem Belevich: >> >> Second problem -- res on success will always be "" as you've just did >> *ptr=0. > > thats right, the copy should look like: > > res=strdup(str+4); > >> Bzzt! >> >> Try it on "GET blah_HTTP/1.1.1.1.1.1_whatever HTTP/1.1" > > will return "blah_HTTP/1.1.1.1.1.1_whatever" as resource. > It should be the next step to check whether is valid. Oops. Should've been space after blah, not underscore. > if(ptr && (ptr=strstr(ptr," HTTP/1.1"))) /* find end of res */ Contrary to the comment in the code you're not checking for "HTTP/1.1" at the end but you're checking for it *anywhere* in the string. While it will occur at the end of valid input string, nobody said it can't occur in the middle, too. Original requirement was saying "surrounded by GET and HTTP/1.1". --Artem > > with kind regards, > Robert Schulze > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" > From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 14:43:36 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3045106566B for ; Mon, 2 May 2011 14:43:36 +0000 (UTC) (envelope-from robpilling@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id AB5D98FC21 for ; Mon, 2 May 2011 14:43:36 +0000 (UTC) Received: by iyj12 with SMTP id 12so6622572iyj.13 for ; Mon, 02 May 2011 07:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=mAOczzvaVhaGEKBCN3Rn9sEZWq1V+BfuDPMrRdi1fGs=; b=YobdgBKaBrWE179FeX1ujtBRin3r2fdV9FjEI34Oc520ji864hDxZUJqHHJ65FNXa0 nrxEFlsIiZFb7bDXaU4DlRXcHHhYcJowQfX4xCifAnUjuKZ1XAFxpfu3KOH3umT6IqW/ BVzec7E2TnPwjygcoiFR/Qs+UnvSqMbmVdDXY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=Hv73iH5KJzueAr3YnKJ0xnmry5IYjtjFcJBgWRRsVOWjxp8PpWuuAB4wTYDVKyge7H WyPp0C/souHFFkIJsPPapXsMw1W/Yhkyof3l2kmDieBNsqOvHJ6fmYgHNlBqHm/thHQr iYKZGucRGc+Ow1/UJ29lkM3KzTxCoABCWGQMg= MIME-Version: 1.0 Received: by 10.42.161.74 with SMTP id s10mr4698706icx.28.1304346054602; Mon, 02 May 2011 07:20:54 -0700 (PDT) Received: by 10.42.219.134 with HTTP; Mon, 2 May 2011 07:20:54 -0700 (PDT) In-Reply-To: References: <4DBEAAD5.7040906@bytecamp.net> Date: Mon, 2 May 2011 15:20:54 +0100 Message-ID: From: Rob To: freebsd-hackers@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 14:43:37 -0000 For goodness sake, it's not even NP-complete. char *start = strchr(line, ' ') + 1; char *end = strrchr(line, ' '); char *ret; *end = '\0'; ret = strdup(start); *end = ' '; return ret; Obviously there's no error checking, but there you go. I don't see what's inelegant about that. This is C, use pointers, if you want high level string parsers, use Perl. Cheers, Rob. From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 14:58:44 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4DCBA106566B for ; Mon, 2 May 2011 14:58:44 +0000 (UTC) (envelope-from rs@bytecamp.net) Received: from mail.bytecamp.net (mail.bytecamp.net [212.204.60.9]) by mx1.freebsd.org (Postfix) with ESMTP id 7C0EE8FC14 for ; Mon, 2 May 2011 14:58:42 +0000 (UTC) Received: (qmail 55026 invoked by uid 89); 2 May 2011 16:58:42 +0200 Received: from stella.bytecamp.net (HELO ?212.204.60.37?) (rs%bytecamp.net@212.204.60.37) by mail.bytecamp.net with CAMELLIA256-SHA encrypted SMTP; 2 May 2011 16:58:42 +0200 Message-ID: <4DBEC6A1.40302@bytecamp.net> Date: Mon, 02 May 2011 16:58:41 +0200 From: Robert Schulze Organization: bytecamp GmbH User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org References: <4DBEAAD5.7040906@bytecamp.net> <4DBEBC7A.60607@bytecamp.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 14:58:44 -0000 Hi, Am 02.05.2011 16:41, schrieb Artem Belevich: > >> if(ptr&& (ptr=strstr(ptr," HTTP/1.1"))) /* find end of res */ > > Contrary to the comment in the code you're not checking for "HTTP/1.1" > at the end but you're checking for it *anywhere* in the string. While > it will occur at the end of valid input string, nobody said it can't > occur in the middle, too. Original requirement was saying "surrounded > by GET and HTTP/1.1". good catch :-) The additional test for end-of-string should be an exercise for the OP. Reading the code of should clarify things, too. With kind regards, Robert Schulze From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 15:54:32 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 97546106566C for ; Mon, 2 May 2011 15:54:32 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id EDB648FC14 for ; Mon, 2 May 2011 15:54:31 +0000 (UTC) Received: by vxc34 with SMTP id 34so5782453vxc.13 for ; Mon, 02 May 2011 08:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=vNSl1WipaBpWUfxOLWA1kB5iOSA7kUs6TTsxC9KwTes=; b=aXhD52gyG5C7IUwr2sdfysn/8xMYYM68zcNRTxJFdaCmfHKuThyzZKyDXvPFKyUoe1 Z2E0D/zbU1eg/EbQkFbetZenadDAI358ucwBbfKt96suECRW2LHRWd8cVi+NJqpYoJEx 5iqDiS9iAE6wYfxBitRKo/oYvPTPHXMXhsWjw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=t8WEMSSwAZKSj4DU/xhq+m1pm9fwdWq/SRG91DwsTnso3VtrZwDToE0YI+nCJWc7lz zThGFBSKgDXVHlTNm/cduIuDgtgdDQIs/6uR3PUOfwIXtzOHEO4yChbqx2KuiPUfi5AO DjFL8O29p6opRACck7IFLolCASO520MfB9JpA= MIME-Version: 1.0 Received: by 10.220.112.138 with SMTP id w10mr1710906vcp.46.1304351670757; Mon, 02 May 2011 08:54:30 -0700 (PDT) Received: by 10.220.199.130 with HTTP; Mon, 2 May 2011 08:54:30 -0700 (PDT) In-Reply-To: <201105020748.p427mBRP004105@freebsd-current.sentex.ca> References: <201105020748.p427mBRP004105@freebsd-current.sentex.ca> Date: Mon, 2 May 2011 08:54:30 -0700 Message-ID: From: Garrett Cooper To: FreeBSD Tinderbox Content-Type: multipart/mixed; boundary=0016e6471744ff6a8804a24d09fa Cc: freebsd-hackers@freebsd.org, current@freebsd.org, i386@freebsd.org Subject: Re: [head tinderbox] failure on i386/i386 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 15:54:32 -0000 --0016e6471744ff6a8804a24d09fa Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Mon, May 2, 2011 at 12:48 AM, FreeBSD Tinderbox wrote: [...] > cc -c -O -pipe =A0-std=3Dc99 -g -Wall -Wredundant-decls -Wnested-externs = -Wstrict-prototypes =A0-Wmissing-prototypes -Wpointer-arith -Winline -Wcast= -qual =A0-Wundef -Wno-pointer-sign -fformat-extensions -nostdinc =A0-I. -I/= src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -inc= lude opt_global.h -fno-common -finline-limit=3D8000 --param inline-unit-gro= wth=3D100 --param large-function-growth=3D1000 =A0-mno-align-long-strings -= mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-s= se3 -msoft-float -ffreestanding -fstack-protector -Werror =A0/src/sys/dev/l= ge/if_lge.c > cc -c -O -pipe =A0-std=3Dc99 -g -Wall -Wredundant-decls -Wnested-externs = -Wstrict-prototypes =A0-Wmissing-prototypes -Wpointer-arith -Winline -Wcast= -qual =A0-Wundef -Wno-pointer-sign -fformat-extensions -nostdinc =A0-I. -I/= src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -inc= lude opt_global.h -fno-common -finline-limit=3D8000 --param inline-unit-gro= wth=3D100 --param large-function-growth=3D1000 =A0-mno-align-long-strings -= mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-s= se3 -msoft-float -ffreestanding -fstack-protector -Werror =A0/src/sys/dev/m= alo/if_malo.c > cc -c -O -pipe =A0-std=3Dc99 -g -Wall -Wredundant-decls -Wnested-externs = -Wstrict-prototypes =A0-Wmissing-prototypes -Wpointer-arith -Winline -Wcast= -qual =A0-Wundef -Wno-pointer-sign -fformat-extensions -nostdinc =A0-I. -I/= src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -inc= lude opt_global.h -fno-common -finline-limit=3D8000 --param inline-unit-gro= wth=3D100 --param large-function-growth=3D1000 =A0-mno-align-long-strings -= mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-s= se3 -msoft-float -ffreestanding -fstack-protector -Werror =A0/src/sys/dev/m= alo/if_malohal.c > cc -c -O -pipe =A0-std=3Dc99 -g -Wall -Wredundant-decls -Wnested-externs = -Wstrict-prototypes =A0-Wmissing-prototypes -Wpointer-arith -Winline -Wcast= -qual =A0-Wundef -Wno-pointer-sign -fformat-extensions -nostdinc =A0-I. -I/= src/sys -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -inc= lude opt_global.h -fno-common -finline-limit=3D8000 --param inline-unit-gro= wth=3D100 --param large-function-growth=3D1000 =A0-mno-align-long-strings -= mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-s= se3 -msoft-float -ffreestanding -fstack-protector -Werror =A0/src/sys/dev/m= alo/if_malo_pci.c > cc1: warnings being treated as errors > /src/sys/dev/malo/if_malo_pci.c: In function 'malo_pci_attach': > /src/sys/dev/malo/if_malo_pci.c:232: warning: large integer implicitly tr= uncated to unsigned type > /src/sys/dev/malo/if_malo_pci.c:232: warning: large integer implicitly tr= uncated to unsigned type > *** Error code 1 > > Stop in /obj/i386.i386/src/sys/PAE. > *** Error code 1 > > Stop in /src. > *** Error code 1 > > Stop in /src. Tinderbox has been whining about malo for the last day or so on i386 because of this issue. Could someone please commit the following patch to fix it? It's correct according to the printf(3) manpage combined with the fields in the malo_hal structure. FWIW I'm a bit confused too because it's listed in the WITHOUT_MODULES group for several i386 kernel compiles based on my looking at the make universe output, but it's still barfing on the module with tinderbox (and not with my local make universe), but it the results might be tainted by my environment somehow. Thanks! -Garrett --0016e6471744ff6a8804a24d09fa Content-Type: text/x-patch; charset=US-ASCII; name="fix-sys-dev-if-malo-format-string.patch" Content-Disposition: attachment; filename="fix-sys-dev-if-malo-format-string.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gn7bwhqy1 SW5kZXg6IHN5cy9kZXYvbWFsby9pZl9tYWxvLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL2Rldi9tYWxv L2lmX21hbG8uYwkocmV2aXNpb24gMjIxMjE5KQorKysgc3lzL2Rldi9tYWxvL2lmX21hbG8uYwko d29ya2luZyBjb3B5KQpAQCAtMjI0LDkgKzIyNCw5IEBACiAJfQogCiAJRFBSSU5URihzYywgTUFM T19ERUJVR19GVywKLQkgICAgIm1hbG9faGFsX2dldGh3c3BlY3M6IGh3dmVyc2lvbiAweCV4IGhv c3RpZiAweCV4IgotCSAgICAibWF4bnVtX3djYiAweCV4IG1heG51bV9tY2FkZHIgMHgleCBtYXhu dW1fdHhfd2NiIDB4JXgiCi0JICAgICJyZWdpb25jb2RlIDB4JXggbnVtX2FudGVubmEgMHgleCBm d19yZWxlYXNlbnVtIDB4JXgiCisJICAgICJtYWxvX2hhbF9nZXRod3NwZWNzOiBod3ZlcnNpb24g MHglaGh4IGhvc3RpZiAweCVoaHgiCisJICAgICJtYXhudW1fd2NiIDB4JWh4IG1heG51bV9tY2Fk ZHIgMHglaHggbWF4bnVtX3R4X3djYiAweCVoeCIKKwkgICAgInJlZ2lvbmNvZGUgMHglaHggbnVt X2FudGVubmEgMHglaHggZndfcmVsZWFzZW51bSAweCV4IgogCSAgICAid2NiYmFzZTAgMHgleCBy eGRlc2NfcmVhZCAweCV4IHJ4ZGVzY193cml0ZSAweCV4IgogCSAgICAidWxfZndfYXdha2Vjb29r aWUgMHgleCB3WzRdID0gJXggJXggJXggJXgiLAogCSAgICBzYy0+bWFsb19od3NwZWNzLmh3dmVy c2lvbiwKQEAgLTE5MzEsNyArMTkzMSw4IEBACiB7CiAJc3RydWN0IGlmbmV0ICppZnAgPSBzYy0+ bWFsb19pZnA7CiAKLQlpZl9wcmludGYoaWZwLCAidmVyc2lvbnMgW2h3ICVkIGZ3ICVkLiVkLiVk LiVkXSAocmVnaW9uY29kZSAlZClcbiIsCisJaWZfcHJpbnRmKGlmcCwKKwkJInZlcnNpb25zIFto dyAweCVoaHggZncgJWQuJWQuJWQuJWRdIChyZWdpb25jb2RlIDB4JWh4KVxuIiwKIAkJc2MtPm1h bG9faHdzcGVjcy5od3ZlcnNpb24sCiAJCShzYy0+bWFsb19od3NwZWNzLmZ3X3JlbGVhc2VudW0g Pj4gMjQpICYgMHhmZiwKIAkJKHNjLT5tYWxvX2h3c3BlY3MuZndfcmVsZWFzZW51bSA+PiAxNikg JiAweGZmLAo= --0016e6471744ff6a8804a24d09fa-- From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 15:57:23 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91627106566B for ; Mon, 2 May 2011 15:57:23 +0000 (UTC) (envelope-from lacombar@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 585658FC0A for ; Mon, 2 May 2011 15:57:23 +0000 (UTC) Received: by iwn33 with SMTP id 33so6655048iwn.13 for ; Mon, 02 May 2011 08:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=zLfERyDm1KRY1ci1mrWRZCHVNe/PvBz6qEUXHvHyYQ0=; b=XBKNRhX3iXsn21/HvKFY4iLjwEHMPZzuVX7VuP9eBv5C6AsQGBILXA/8rCKI63bPcS +oBnk+vhiglO1I2c7WLlOdNaDoZj0YXYVbVzTTsu9U0IwfiJvHWsk8dDk4lrde+Ye5QI 4g7rV3HAwGAGQAkHDH8f8fSs3a2Eo0oC3fMi0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=gFRzNTwy4sifCuBY4cN9CSHGf9+3y5edEJk+pRObRY1Q5r8zQV4Go5oF9u7TCTL+PO unt5gTaEOPvvMOAtVpZMIyg1J7+xpUYbYJZWbwCd0/WBLWKNbLNchpVJaRSZz88utTAo tW2SlFi29zMHy9S29BDyGOsGWnshjlhHPUmQQ= MIME-Version: 1.0 Received: by 10.43.44.6 with SMTP id ue6mr10479316icb.69.1304351842684; Mon, 02 May 2011 08:57:22 -0700 (PDT) Received: by 10.42.165.132 with HTTP; Mon, 2 May 2011 08:57:22 -0700 (PDT) In-Reply-To: References: <20110501162925.GB47497@stack.nl> Date: Mon, 2 May 2011 11:57:22 -0400 Message-ID: From: Arnaud Lacombe To: =?ISO-8859-1?Q?Martin_M=F6ller?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 15:57:23 -0000 Hi, On Mon, May 2, 2011 at 8:13 AM, Martin M=F6ller wrote: > Hello, > > Thanks for all the replies. > We have so far discovered the following suggetions for the parsing Proble= m: > Using: > =A0 =A0o a tokenizer/parser is too much overhead for such a simple task > =A0 =A0o strchr, memchr is too low-level and not elegant enough > =A0 =A0o strtok would not even parse (tokenize) this simple example > =A0 =A0o a regexp library: How would you solve the problem with a regexp = lib ? > > Criteria: > =A0 =A0o Receive the value of > =A0 =A0o Check the Environment: Is really sourrounded by 'GET = ' and > =A0 =A0 =A0'HTTP/1.1' ?! > There is plenty of library out there dealing with parsing the code you pointed out. Do you really need to re-invent the wheel ? - Arnaud > I need a function which accepts BNF-style rules. > E.g.: > =A0 =A0char resource [512]; > > =A0 =A0ret =3D bnfparse (request, "GET %s HTTP/1.1", resource); > > Ret would be $(NUMBER OF FORMAT SPECIFIERS, successfully handled) +env. > Env would be 1 if the Environment passes, and 0 is not. > > Any comments ? > Best regards, > Martin > > > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org= " > From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 16:10:59 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 650FC1065676 for ; Mon, 2 May 2011 16:10:59 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 1B3508FC13 for ; Mon, 2 May 2011 16:10:58 +0000 (UTC) Received: by vws18 with SMTP id 18so5750682vws.13 for ; Mon, 02 May 2011 09:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type; bh=ndO+zR56/bD8muYyHK2P41HBhPGjuB9Sz/ecrZA6WOA=; b=LyIivpfr67+ipIDeoswfqI+jrZp0GlVNde4RGs9JlqS1Q3Ij+mw2GXlh4dwz1YrzWG Jo8UgJpnU/evuooA7SxERcAnpvX0y3a+ffmjzS6XvzwnHwvgbUr96iX9hX/3Gy/pIX4c 3CfUBfyRDJcbrDFNMvVr7ihZOSRCInoroZWCE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=V1aZextnzjDkzl8iFCaok3iQL7S0jqz4gF125lSeP9PkN5zgLB7gFh8NPnmaeP13wI Ec8QGfaIl3rML0US1ow9FS3w/VM+YXG4JDwHLQrOGQ/4icg9sbVOMjWYzp9mAywyWx0j 0LYAm+z5BRvMdNV4v5UesoCBiIRNwacyBx6hU= MIME-Version: 1.0 Received: by 10.220.112.138 with SMTP id w10mr1716215vcp.46.1304352658092; Mon, 02 May 2011 09:10:58 -0700 (PDT) Received: by 10.220.199.130 with HTTP; Mon, 2 May 2011 09:10:58 -0700 (PDT) Date: Mon, 2 May 2011 09:10:58 -0700 Message-ID: From: Garrett Cooper To: freebsd-hackers@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Subject: [PATCH] draft patch to make usr.bin/kdump WARNS?= 6 clean X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 16:10:59 -0000 I wanted to do something different this weekend, and I picked usr.bin/kdump as a likely 'victim' for converting from WARNS?= 0 to WARNS?= 6. I'm curious as to whether or not this is on the right track, but here's the reasoning I used: 1. Conditionally include diskmbr.h or diskpc98.h based on whether or not an architecture was non-pc98 or pc98 to avoid duplicate definitions, because the beforementioned headers are mutually exclusive. 2. Move the sockfamilyname declaration to kdump_subr.h as it's used in the generated ioctl.c file. 3. Fix a signed vs unsigned comparison with a simple cast because the size_t value will be sufficiently small that it can be converted to a signed comparison. 4. Fix a cast assignment type source//dest value alignment issue on ia64 assigning a struct sockaddr value to either struct sockaddr_in or struct sockaddr_in6 by using calloc and memcpy. 5. Fix structure alignment issues on arm by marking some structures as __packed. 6. Fix a shadowed declaration for flags by renaming a locally scoped variable to _flags; add appropriate type to field. 7. Remove unused argument to ktruser_malloc. 8. Add missing declarations for ktruser_malloc and ktruser_rtld. I've run some basic tests and things seem sane (in particular ktrace'ing ktrace :)... ktrace'ing 'ssh ::1' and ktrace'ing 'ssh localhost', but I was wondering if there was anything I was missing or if someone else who ran arm or ia64 could test this patch out for me. I've run make universe on amd64, i386, ia64, mips, and pc98, and things seem sane, but I can't play around with those machines to determine whether or not they're functional at runtime with the above changes. Thanks! -Garrett PS Oh yeah... no commit bit means that I can't commit this either, but I was curious if my approach was correct before getting to that step :). From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 16:23:45 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B00C1065670 for ; Mon, 2 May 2011 16:23:45 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id EFED78FC14 for ; Mon, 2 May 2011 16:23:44 +0000 (UTC) Received: by vws18 with SMTP id 18so5763466vws.13 for ; Mon, 02 May 2011 09:23:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=S7odBqxBKF9Tno3rG/EsIdt512Pw3EX0D3ExABK/6+g=; b=boshEJbxdbqG0MHWHnKjYtPe7fL2bQi2ywpok+4THGhkl0n5F3teXUiZItDwXS07YY EzBTrnopVPvuDV8K5VbcRJLlBAtUJmcu1+80H7qPncoqRmlsbJLuKqHy05EMdaUVnWZa HKujGENMjiNiF9ohipD7OgzmTMuqSzco6gy3w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=hlXD9EDdzlqFxjCKpTnhQ3Vf/zwsJDAwVGWa8y2V1cb2VeW9/vBrPircKzDrWVKDRW DAo9wDi+jIn1mV4UQQ9gbW2+l7p/jGO5l/jjY11QuNhWEoDGOccfFYFN3S0JL800OJAf Nh2Q4ltrzp2i0d55YpdfqKxdk0tqARSAHASVE= MIME-Version: 1.0 Received: by 10.220.112.138 with SMTP id w10mr1720388vcp.46.1304353424016; Mon, 02 May 2011 09:23:44 -0700 (PDT) Received: by 10.220.199.130 with HTTP; Mon, 2 May 2011 09:23:43 -0700 (PDT) In-Reply-To: References: <20110501162925.GB47497@stack.nl> Date: Mon, 2 May 2011 09:23:43 -0700 Message-ID: From: Garrett Cooper To: Arnaud Lacombe Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org, =?ISO-8859-1?Q?Martin_M=F6ller?= Subject: Re: [LIBC] Modfied Version of sscanf X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 16:23:45 -0000 On Mon, May 2, 2011 at 8:57 AM, Arnaud Lacombe wrote: > Hi, > > On Mon, May 2, 2011 at 8:13 AM, Martin M=F6ller > wrote: >> Hello, >> >> Thanks for all the replies. >> We have so far discovered the following suggetions for the parsing Probl= em: >> Using: >> =A0 =A0o a tokenizer/parser is too much overhead for such a simple task Explain :). >> =A0 =A0o strchr, memchr is too low-level and not elegant enough You forgot strstr ;D! >> =A0 =A0o strtok would not even parse (tokenize) this simple example Yes, it could. It just wouldn't be smart to set the delim up as " " more than once ;D (wrong tool for the job)... >> =A0 =A0o a regexp library: How would you solve the problem with a regexp= lib ? '^[A-Z]{3,4} (.+) HTTP/[\d\.]+$' Example: $ python >>> import re >>> r =3D re.compile('^[A-Z]{3,4} (.+) HTTP/[\d\.]+$') >>> m =3D r.match('GET blah_HTTP/1.1.1.1.1.1_whatever HTTP/1.1') >>> m.group(1) 'blah_HTTP/1.1.1.1.1.1_whatever I don't think it's what you wanted earlier -- but you can inspect the request string further if you wish (and should!). Oh yeah, and although I used python as a quick and dirty means for illustrating my example, there's no reason why you can't use C, C++, Java, perl, ruby, etc to articulate what you need. Point is, there are a ton of different solutions available, and the fact that one is homing in on sscanf as the tool to solve the problem is probably ill put, just like using strtok/strsep wouldn't be the best choice either for this problem by itself. Cheers, -Garrett From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 16:24:59 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9AC35106566C for ; Mon, 2 May 2011 16:24:59 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4E3578FC18 for ; Mon, 2 May 2011 16:24:59 +0000 (UTC) Received: by vws18 with SMTP id 18so5764743vws.13 for ; Mon, 02 May 2011 09:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=3jEQR6SsN/uwczRto1nOcDUdYCkhsnh+2EC1mESJy3Q=; b=JHXjIr0q/gUKNQ2VD2eO4JAhLHT1YzKPN6KSWfixN5kFGWfUoxbpKzOJR33GkbEW0f YwkoAu+ltq6vhLXAda57XGDzXA3vAQF698PA6eLbI5DNXTO93zqugrGDfv7EHS7+ZN/2 ksfGCCc0BQugut10tdX6HBS/NFcYeuBvgHuCI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=bI3av7kD8sR1nRdebU22XWJalHbqfxWuMYgkTp0ARl2zKb/lloXqDt5x4NPh6XHy0m bsywWPbaK5Sycddfd5PbU+I7a+uRX6VDUgBhSIpaQBfXqs26jbVKmt+XcPiIS95Mo+Gn 3KCHdWG4gTjElz+0SF7PHH8Zue663MBZLmfWk= MIME-Version: 1.0 Received: by 10.220.203.13 with SMTP id fg13mr2419749vcb.11.1304353498593; Mon, 02 May 2011 09:24:58 -0700 (PDT) Received: by 10.220.199.130 with HTTP; Mon, 2 May 2011 09:24:58 -0700 (PDT) In-Reply-To: References: Date: Mon, 2 May 2011 09:24:58 -0700 Message-ID: From: Garrett Cooper To: freebsd-hackers@freebsd.org Content-Type: multipart/mixed; boundary=90e6ba53a7b4f1faaa04a24d763b Subject: Fwd: [PATCH] draft patch to make usr.bin/kdump WARNS?= 6 clean X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 16:24:59 -0000 --90e6ba53a7b4f1faaa04a24d763b Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable ---------- Forwarded message ---------- From: Garrett Cooper Date: Mon, May 2, 2011 at 9:24 AM Subject: Re: [PATCH] draft patch to make usr.bin/kdump WARNS?=3D 6 clean To: Arnaud Lacombe On Mon, May 2, 2011 at 9:21 AM, Arnaud Lacombe wrote: > Hi, > > On Mon, May 2, 2011 at 12:10 PM, Garrett Cooper wrot= e: >> =A0 =A0I wanted to do something different this weekend, and I picked >> usr.bin/kdump as a likely 'victim' for converting from WARNS?=3D 0 to >> WARNS?=3D 6. I'm curious as to whether or not this is on the right >> track, but here's the reasoning I used: >> >> 1. Conditionally include diskmbr.h or diskpc98.h based on whether or >> not an architecture was non-pc98 or pc98 to avoid duplicate >> definitions, because the beforementioned headers are mutually >> exclusive. >> 2. Move the sockfamilyname declaration to kdump_subr.h as it's used in >> the generated ioctl.c file. >> 3. Fix a signed vs unsigned comparison with a simple cast because the >> size_t value will be sufficiently small that it can be converted to a >> signed comparison. >> 4. Fix a cast assignment type source//dest value alignment issue on >> ia64 assigning a struct sockaddr value to either struct sockaddr_in or >> struct sockaddr_in6 by using calloc and memcpy. >> 5. Fix structure alignment issues on arm by marking some structures as _= _packed. >> 6. Fix a shadowed declaration for flags by renaming a locally scoped >> variable to _flags; add appropriate type to field. >> 7. Remove unused argument to ktruser_malloc. >> 8. Add missing declarations for ktruser_malloc and ktruser_rtld. >> >> =A0 =A0I've run some basic tests and things seem sane (in particular >> ktrace'ing ktrace :)... ktrace'ing 'ssh ::1' and ktrace'ing 'ssh >> localhost', but I was wondering if there was anything I was missing or >> if someone else who ran arm or ia64 could test this patch out for me. >> =A0 =A0I've run make universe on amd64, i386, ia64, mips, and pc98, and >> things seem sane, but I can't play around with those machines to >> determine whether or not they're functional at runtime with the above >> changes. >> Thanks! >> -Garrett >> > I do not see any patch, either inline or attached. > > =A0- Arnaud > >> PS Oh yeah... no commit bit means that I can't commit this either, but >> I was curious if my approach was correct before getting to that step >> :). Yeah... I'm stupid for not attaching it. Need to get more sleep. -Garrett --90e6ba53a7b4f1faaa04a24d763b Content-Type: text/x-patch; charset=US-ASCII; name="usr-bin-kdump-WARNS-6-clean.patch" Content-Disposition: attachment; filename="usr-bin-kdump-WARNS-6-clean.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gn7md5980 SW5kZXg6IHVzci5iaW4va2R1bXAva2R1bXAuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB1c3IuYmluL2tkdW1w L2tkdW1wLmMJKHJldmlzaW9uIDIyMTIxOSkKKysrIHVzci5iaW4va2R1bXAva2R1bXAuYwkod29y a2luZyBjb3B5KQpAQCAtOTksOCArOTksOSBAQAogdm9pZCBrdHJzb2NrYWRkcihzdHJ1Y3Qgc29j a2FkZHIgKik7CiB2b2lkIGt0cnN0YXQoc3RydWN0IHN0YXQgKik7CiB2b2lkIGt0cnN0cnVjdChj aGFyICosIHNpemVfdCk7Cit2b2lkIGt0cnVzZXJfbWFsbG9jKHVuc2lnbmVkIGNoYXIgKnApOwor dm9pZCBrdHJ1c2VyX3J0bGQoaW50IGxlbiwgdW5zaWduZWQgY2hhciAqcCk7CiB2b2lkIHVzYWdl KHZvaWQpOwotdm9pZCBzb2NrZmFtaWx5bmFtZShpbnQpOwogY29uc3QgY2hhciAqaW9jdGxuYW1l KHVfbG9uZyk7CiAKIGludCB0aW1lc3RhbXAsIGRlY2ltYWwsIGZhbmN5ID0gMSwgc3VwcHJlc3Nk YXRhLCB0YWlsLCB0aHJlYWRzLCBtYXhkYXRhLApAQCAtNTI4LDEzICs1MjksMTMgQEAKIAkJCQlp cCsrOwogCQkJCW5hcmctLTsKIAkJCX0gZWxzZSBpZiAoa3RyLT5rdHJfY29kZSA9PSBTWVNfb3Bl bikgewotCQkJCWludAlmbGFnczsKKwkJCQl1X2ludAlfZmxhZ3M7CiAJCQkJaW50CW1vZGU7CiAJ CQkJcHJpbnRfbnVtYmVyKGlwLG5hcmcsYyk7Ci0JCQkJZmxhZ3MgPSAqaXA7CisJCQkJX2ZsYWdz ID0gKmlwOwogCQkJCW1vZGUgPSAqKytpcDsKIAkJCQkodm9pZClwdXRjaGFyKCcsJyk7Ci0JCQkJ ZmxhZ3NhbmRtb2RlbmFtZSAoZmxhZ3MsIG1vZGUsIGRlY2ltYWwpOworCQkJCWZsYWdzYW5kbW9k ZW5hbWUgKF9mbGFncywgbW9kZSwgZGVjaW1hbCk7CiAJCQkJaXArKzsKIAkJCQluYXJnLT0yOwog CQkJfSBlbHNlIGlmIChrdHItPmt0cl9jb2RlID09IFNZU193YWl0NCkgewpAQCAtMTI1Niw3ICsx MjU3LDcgQEAKIH07CiAKIHZvaWQKLWt0cnVzZXJfbWFsbG9jKGludCBsZW4sIHVuc2lnbmVkIGNo YXIgKnApCitrdHJ1c2VyX21hbGxvYyh1bnNpZ25lZCBjaGFyICpwKQogewogCXN0cnVjdCB1dHJh Y2VfbWFsbG9jICp1dCA9IChzdHJ1Y3QgdXRyYWNlX21hbGxvYyAqKXA7CiAKQEAgLTEyODAsNyAr MTI4MSw3IEBACiAJfQogCiAJaWYgKGxlbiA9PSBzaXplb2Yoc3RydWN0IHV0cmFjZV9tYWxsb2Mp KSB7Ci0JCWt0cnVzZXJfbWFsbG9jKGxlbiwgcCk7CisJCWt0cnVzZXJfbWFsbG9jKHApOwogCQly ZXR1cm47CiAJfQogCkBAIC0xNDgwLDggKzE0ODEsOCBAQAogCWlmIChkYXRhbGVuID09IDApCiAJ CWdvdG8gaW52YWxpZDsKIAkvKiBzYW5pdHkgY2hlY2sgKi8KLQlmb3IgKGkgPSAwOyBpIDwgbmFt ZWxlbjsgKytpKQotCQlpZiAoIWlzYWxwaGEoKHVuc2lnbmVkIGNoYXIpbmFtZVtpXSkpCisJZm9y IChpID0gMDsgaSA8IChpbnQpbmFtZWxlbjsgKytpKQorCQlpZiAoIWlzYWxwaGEobmFtZVtpXSkp CiAJCQlnb3RvIGludmFsaWQ7CiAJaWYgKHN0cmNtcChuYW1lLCAic3RhdCIpID09IDApIHsKIAkJ aWYgKGRhdGFsZW4gIT0gc2l6ZW9mKHN0cnVjdCBzdGF0KSkKSW5kZXg6IHVzci5iaW4va2R1bXAv a2R1bXBfc3Vici5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHVzci5iaW4va2R1bXAva2R1bXBfc3Vici5oCShy ZXZpc2lvbiAyMjEyMTkpCisrKyB1c3IuYmluL2tkdW1wL2tkdW1wX3N1YnIuaAkod29ya2luZyBj b3B5KQpAQCAtNDUsMyArNDUsNCBAQAogdm9pZCBtaW5oZXJpdG5hbWUgKGludCk7CiB2b2lkIHF1 b3RhY3RsbmFtZSAoaW50KTsKIHZvaWQgcHRyYWNlb3BuYW1lIChpbnQpOwordm9pZCBzb2NrZmFt aWx5bmFtZShpbnQpOwpJbmRleDogdXNyLmJpbi9rZHVtcC9ta2lvY3Rscwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSB1c3IuYmluL2tkdW1wL21raW9jdGxzCShyZXZpc2lvbiAyMjEyMTkpCisrKyB1c3IuYmluL2tk dW1wL21raW9jdGxzCSh3b3JraW5nIGNvcHkpCkBAIC0yMiwxMiArMjIsMjEgQEAKICMgWFhYIHNo b3VsZCB3ZSB1c2UgYW4gQU5TSSBjcHA/CiBpb2N0bF9pbmNsdWRlcz1gCiAJY2QgJDEKLQlmaW5k IC1IIC1zICogLW5hbWUgJyouaCcgfAorCWZpbmQgLUggLXMgKiAtbmFtZSAnKi5oJyAtYW5kIFwo IC1uYW1lICEgJ2Rpc2ttYnIuaCcgLW9yIC1uYW1lICEgJ2Rpc2twYzk4LmgnIFwpIHwKIAkJeGFy Z3MgZWdyZXAgLWwgXAogJ14jWyAJXSpkZWZpbmVbIAldK1tBLVphLXpfXVtBLVphLXowLTlfXSpb IAldK19JT1teYS16MC05X10nIHwKIAkJYXdrICd7cHJpbnRmKCIjaW5jbHVkZSA8JXM+XFxcXG4i LCAkMSl9JwogYAogCitjYXNlICJgdW5hbWUgLW1gIiBpbgorKnBjOTgqKQorCWlvY3RsX2luY2x1 ZGVzPSIkaW9jdGxfaW5jbHVkZXMjaW5jbHVkZSA8c3lzL2Rpc2twYzk4Lmg+XFxuIgorCTs7Cisq KQorCWlvY3RsX2luY2x1ZGVzPSIkaW9jdGxfaW5jbHVkZXMjaW5jbHVkZSA8c3lzL2Rpc2ttYnIu aD5cXG4iCisJOzsKK2VzYWMKKwogYXdrIC12IHg9IiRpb2N0bF9pbmNsdWRlcyIgJ0JFR0lOIHtw cmludCB4fScgfAogCWdjYyAtRSAtSSQxIC1kTSAtRENPTVBBVF80M1RUWSAtIHwKIAlhd2sgLXYg aW9jdGxfaW5jbHVkZXM9IiRpb2N0bF9pbmNsdWRlcyIgLXYgdXNlX3N3aXRjaD0iJHVzZV9zd2l0 Y2giICcKSW5kZXg6IHVzci5iaW4va2R1bXAvTWFrZWZpbGUKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gdXNyLmJp bi9rZHVtcC9NYWtlZmlsZQkocmV2aXNpb24gMjIxMjE5KQorKysgdXNyLmJpbi9rZHVtcC9NYWtl ZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMTUsNyArMTUsNyBAQAogU1JDUys9CQlsaW51eF9zeXNj YWxscy5jCiAuZW5kaWYKIAotV0FSTlM/PQkJMAorV0FSTlM/PQkJNgogCiBDTEVBTkZJTEVTPQlp b2N0bC5jIGtkdW1wX3N1YnIuYyBsaW51eF9zeXNjYWxscy5jCiAK --90e6ba53a7b4f1faaa04a24d763b-- From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 16:40:20 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3DFE71065672 for ; Mon, 2 May 2011 16:40:20 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id E19258FC08 for ; Mon, 2 May 2011 16:40:19 +0000 (UTC) Received: by vws18 with SMTP id 18so5780671vws.13 for ; Mon, 02 May 2011 09:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type:content-transfer-encoding; bh=E282lvhnOj25LYWHYovZ7DfytsxdiTbP4SWq1SPvX9U=; b=oq4x/bG6XwjpdyPIFoEhJ2EwwPdtkk4+7CvilKNPOHOiN350zEkJ8++wd6CAFln7zo p1FSsOTIBaZm1pL05/PmKvbPBIhOhV8QRVIO7bQqd/eYK/zadjTbX/iO8F3PA3IhwPnO CmHZTw3Xc2SVIzaxKfatAVmYFSkEzQwp1NcTY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=Jnet6XIA96UtAvj7lfoUXY1O6EriCDy4d+ivw9WfzWiFVV4pxEIwZZqzXWVJfQKrJG kAQcxFbNKEo17OQwJACEla6FWDgVN6ic1FOe4ShbsSq4CWfyVVjW29NPHbAlC17N51IF RBwVFWi8qnOJ0aM4W5Fp7gQv5jR0MU7wmzOOo= MIME-Version: 1.0 Received: by 10.52.176.194 with SMTP id ck2mr4910180vdc.248.1304354418927; Mon, 02 May 2011 09:40:18 -0700 (PDT) Received: by 10.220.199.130 with HTTP; Mon, 2 May 2011 09:40:18 -0700 (PDT) In-Reply-To: References: Date: Mon, 2 May 2011 09:40:18 -0700 Message-ID: From: Garrett Cooper To: freebsd-hackers@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] draft patch to make usr.bin/kdump WARNS?= 6 clean X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 16:40:20 -0000 On Mon, May 2, 2011 at 9:24 AM, Garrett Cooper wrote: > ---------- Forwarded message ---------- > From: Garrett Cooper > Date: Mon, May 2, 2011 at 9:24 AM > Subject: Re: [PATCH] draft patch to make usr.bin/kdump WARNS?=3D 6 clean > To: Arnaud Lacombe > > > On Mon, May 2, 2011 at 9:21 AM, Arnaud Lacombe wrote= : >> Hi, >> >> On Mon, May 2, 2011 at 12:10 PM, Garrett Cooper wro= te: >>> =A0 =A0I wanted to do something different this weekend, and I picked >>> usr.bin/kdump as a likely 'victim' for converting from WARNS?=3D 0 to >>> WARNS?=3D 6. I'm curious as to whether or not this is on the right >>> track, but here's the reasoning I used: >>> >>> 1. Conditionally include diskmbr.h or diskpc98.h based on whether or >>> not an architecture was non-pc98 or pc98 to avoid duplicate >>> definitions, because the beforementioned headers are mutually >>> exclusive. >>> 2. Move the sockfamilyname declaration to kdump_subr.h as it's used in >>> the generated ioctl.c file. >>> 3. Fix a signed vs unsigned comparison with a simple cast because the >>> size_t value will be sufficiently small that it can be converted to a >>> signed comparison. >>> 4. Fix a cast assignment type source//dest value alignment issue on >>> ia64 assigning a struct sockaddr value to either struct sockaddr_in or >>> struct sockaddr_in6 by using calloc and memcpy. >>> 5. Fix structure alignment issues on arm by marking some structures as = __packed. >>> 6. Fix a shadowed declaration for flags by renaming a locally scoped >>> variable to _flags; add appropriate type to field. >>> 7. Remove unused argument to ktruser_malloc. >>> 8. Add missing declarations for ktruser_malloc and ktruser_rtld. >>> >>> =A0 =A0I've run some basic tests and things seem sane (in particular >>> ktrace'ing ktrace :)... ktrace'ing 'ssh ::1' and ktrace'ing 'ssh >>> localhost', but I was wondering if there was anything I was missing or >>> if someone else who ran arm or ia64 could test this patch out for me. >>> =A0 =A0I've run make universe on amd64, i386, ia64, mips, and pc98, and >>> things seem sane, but I can't play around with those machines to >>> determine whether or not they're functional at runtime with the above >>> changes. >>> Thanks! >>> -Garrett >>> >> I do not see any patch, either inline or attached. >> >> =A0- Arnaud >> >>> PS Oh yeah... no commit bit means that I can't commit this either, but >>> I was curious if my approach was correct before getting to that step >>> :). > > Yeah... I'm stupid for not attaching it. Need to get more sleep. Note to self: should be freeing socket structures after use, and I should apply similar logic to the rest of the socket inspection code. I'll attach another version after I do some more testing. Thanks! -Garrett From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 16:46:44 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DE4681065678 for ; Mon, 2 May 2011 16:46:43 +0000 (UTC) (envelope-from jamesbrandongooch@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 713518FC14 for ; Mon, 2 May 2011 16:46:43 +0000 (UTC) Received: by wyf23 with SMTP id 23so5690659wyf.13 for ; Mon, 02 May 2011 09:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=jJfBTw0wThYvauwTWFBK80zLqnyUCmay6n55jb25DZo=; b=lVMxMbQeTW9dtXZ9q0d+CcfTHgfuxwAQX/mU/bItZA19Hr1kL1A+PXTFyHYaeUByA0 xduWskB8fZZ7DVV3kecqO3k1rTZ7YtJkLLqS8uohh6IBJrd25bmmzjFZUhPZfYzi1+pR 5jlXdplz4FX4DrnEePbR0+iRDEKzANrdoQrlo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=rIoeA39UQZdijce6DncbzrFaNgoBJnzpiRV8np0JiTdKOvcj7cLgqC4y42Sm0ixjrW LSCFOhvKD68iam6VYMfEHn2MggLl0mzpkD1lv7WujlNvhSrlhHVbI7IL4saxbP+dPwZg zVBBUvlqiA2rR3AATpdhQQrpT3LcSUkA5jn/M= MIME-Version: 1.0 Received: by 10.216.188.20 with SMTP id z20mr3374801wem.66.1304353086637; Mon, 02 May 2011 09:18:06 -0700 (PDT) Received: by 10.216.17.213 with HTTP; Mon, 2 May 2011 09:18:06 -0700 (PDT) In-Reply-To: References: Date: Mon, 2 May 2011 11:18:06 -0500 Message-ID: From: Brandon Gooch To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] draft patch to make usr.bin/kdump WARNS?= 6 clean X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 16:46:44 -0000 On Mon, May 2, 2011 at 11:10 AM, Garrett Cooper wrote: > =A0 =A0I wanted to do something different this weekend, and I picked > usr.bin/kdump as a likely 'victim' for converting from WARNS?=3D 0 to > WARNS?=3D 6. I'm curious as to whether or not this is on the right > track, but here's the reasoning I used: > > 1. Conditionally include diskmbr.h or diskpc98.h based on whether or > not an architecture was non-pc98 or pc98 to avoid duplicate > definitions, because the beforementioned headers are mutually > exclusive. > 2. Move the sockfamilyname declaration to kdump_subr.h as it's used in > the generated ioctl.c file. > 3. Fix a signed vs unsigned comparison with a simple cast because the > size_t value will be sufficiently small that it can be converted to a > signed comparison. > 4. Fix a cast assignment type source//dest value alignment issue on > ia64 assigning a struct sockaddr value to either struct sockaddr_in or > struct sockaddr_in6 by using calloc and memcpy. > 5. Fix structure alignment issues on arm by marking some structures as __= packed. > 6. Fix a shadowed declaration for flags by renaming a locally scoped > variable to _flags; add appropriate type to field. > 7. Remove unused argument to ktruser_malloc. > 8. Add missing declarations for ktruser_malloc and ktruser_rtld. > > =A0 =A0I've run some basic tests and things seem sane (in particular > ktrace'ing ktrace :)... ktrace'ing 'ssh ::1' and ktrace'ing 'ssh > localhost', but I was wondering if there was anything I was missing or > if someone else who ran arm or ia64 could test this patch out for me. > =A0 =A0I've run make universe on amd64, i386, ia64, mips, and pc98, and > things seem sane, but I can't play around with those machines to > determine whether or not they're functional at runtime with the above > changes. > Thanks! > -Garrett > > PS Oh yeah... no commit bit means that I can't commit this either, but > I was curious if my approach was correct before getting to that step > :). Cool, but where's the patch for review? -Brandon From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 20:23:01 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D6DD71065674 for ; Mon, 2 May 2011 20:23:01 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id 8D3238FC17 for ; Mon, 2 May 2011 20:23:01 +0000 (UTC) Received: from sbhfislrext01.fnfis.com ([192.168.249.167]) by SCSFISLTC02 (8.14.3/8.14.3) with ESMTP id p42KN0cq021781 for ; Mon, 2 May 2011 15:23:00 -0500 Resent-Message-Id: <201105022023.p42KN0cq021781@SCSFISLTC02> Received: from sbhfisltcgw01.FNFIS.COM (Not Verified[10.132.248.121]) by sbhfislrext01.fnfis.com with MailMarshal (v6, 5, 4, 7535) id ; Mon, 02 May 2011 15:23:01 -0500 Received: from SBHFISLTCGW04.FNFIS.COM ([10.132.248.123]) by sbhfisltcgw01.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Mon, 2 May 2011 15:23:00 -0500 Received: from [192.168.1.123] ([10.132.254.136]) by SBHFISLTCGW04.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 2 May 2011 15:22:59 -0500 Mime-Version: 1.0 (Apple Message framework v1084) From: Devin Teske Resent-From: Devin Teske Date: Mon, 2 May 2011 11:03:10 -0700 Resent-Date: Mon, 2 May 2011 13:22:57 -0700 Message-Id: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> Resent-To: FreeBSD Hackers To: FreeBSD Hackers X-Mailer: Apple Mail (2.1084) X-OriginalArrivalTime: 02 May 2011 20:23:00.0198 (UTC) FILETIME=[BB322060:01CC0906] Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: mwm@mired.org, Mike Meyer , Warner Losh , Freddie Cash , Alexander Leidinger , Olivier SMEDTS , Warren Block , Doug Barton , Artem Belevich , Artem Belevich , Dieter BSD , Jason Hellenthal , Jason Hellenthal , Devin Teske , Damien Fleuriot , Zhihao Yuan , Paul Schenkeveld , Mehmet Erol Sanliturk , Dave Robison Subject: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 20:23:01 -0000 NOTE: Apologies if this comes through multiple times. I'm having problems g= etting this e-mail to appear on the list. Hi again, fellow hackers, First, I'd like to thank all of you for the input and suggestions that you = provided. Things are moving fast and nimble here. With over 1,000 lines of code chang= ed (in one single 24-hour period), I'd like to announce an update to my adv= anced boot-loader menu. This version (1.1) attempts to address all communit= y requests. You can grab the updated code here: http://druidbsd.sourceforge.net/ or http://druidbsd.sourceforge.net/download/loader_menu-1.1.tgz =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D Below is an itemized list of things addressed in this latest release (compl= ete with attribution to the person(s) whom made the request): Mike Meyer: Individual menuitem hotkeys have been implemented. (ENTER =3D b= oot, a =3D ACPI, v =3D verbose, s =3D single-user, m =3D safe-mode, esc =3D= escape to loader prompt). Paul Schenkeveld, Damien Fleuriot, Zhihao Yuan, and Warner Losh: Both numbe= rs and hotkeys are supported. Freddie Cash: Customize beastie logo with loader.conf(5) variables (see bel= ow -- also documented in package description). Alexander Leidinger: When loader_color is enabled (see loader.conf(5) varia= bles below -- also documented in package description), the hotkeys/mnemonic= s are bolded (sorry, underline is currently not implemented correctly in lo= ader(8)). When loader_color is disabled (the default), the hotkeys/mnemonic= s appear in [square-brackets] (e.g. [ENTER], [A], [V], [M], [S], and [Esc])= . Also, when loader_color is enabled, the numerical prefixes are also made = bold (when loader_color is disabled, the numerical prefixes are displayed n= ormally -- without square-brackets). Olivier SMEDTS: All loader.conf(5) variables that are supported by the curr= ent loader are now supported, including `loader_logo' and many many more (s= ee loader.conf(5) variables below -- also documented in package description= ). Warren Block and Doug Barton: With respect to ANSI underline being a more s= tandard UI choice for hotkey/mnemonics... sorry, ANSI underline is currentl= y not implemented correctly in loader(8) as of RELENG_8 that I've tried. Go= ing with ANSI bold when loader_color is enabled and square-brackets by defa= ult. Artem Belevich: The default layout should meet all VT100 requirements (that= is to explain, that "out of the box" with no additional customizations in = loader.conf(5), the menu should meet VT100 standards). Dieter BSD: In the "out of box" configuration (assuming the user doesn't ha= ve any existing customizations in loader.conf(5)), all of your previously-m= entioned decrees have been met (no graphics, no color, no assumptions, etc.= etc.). The only requirements are that you have an 80x24 screen and a basic= keyboard with either letters 1-7 or A-Z+ENTER (or both). Jason Hellenthal (aka jhell): The ability to display the loader version at = the bottom-right edge of the screen (right-justified) is enabled. However, = currently the loader does not export the "loader_version" environment varia= ble, and thus nothing will be displayed until then. Though, to test this fe= ature, you can simply add a line to loader.conf(5) (see the loader.conf(5) = variables below -- also documented in the package description). All: The initial delay introduced before loading the menu can be disabled/c= ustomized (see loader.conf(5) variables below -- also documented in package= description). Mehmet Erol Sanliturk: You can customize the default 10-second menu timeout= by adding `loader_menu_timeout' to loader.conf(5) (see the loader.conf(5) = variables below -- also documented in the package description). You had sta= ted a desire to increase the timeout to 255. Minor note: due to limited scr= een real-estate, the countdown timer will continue to display "9 seconds" u= ntil the internal timer gets to a number that is below 9 (however, this sho= uld still meet your needs of dramatically increasing the timeout delay). =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D Here's the package description (+DESC: attainable via either `tar zxfO load= er_menu-X.Y.tgz +DESC | less' or `pkg_info -dx loader_menu | less'): loader_menu is a modern boot loader for the FreeBSD Operating System. The following options can be added to loader.conf(5) to customize the behav= ior and/or appearance of the boot menu/process: loader_color=3D"YES" Enables the use of color in the boot menu. Not all devices support the display of ANSI color codes, and so the default is to not use them. loader_logo=3D"..." Selects which FreeBSD logo to display. Valid values are "beastie", "beastiebw", "fbsdbw", "orb", or "orbbw". An invalid value (such as "none") will disable the display of any logo. The logo is displayed to the right of the dynamic menu. loader_logo_x=3D"N" loader_logo_y=3D"N" Column (x) and row (y) placement of FreeBSD" mascot placed to the right of the dynamic menu. Defaults are 46 (x) and 4 (y). loader_brand=3D"..." Selects the BSD brand to display. Valid values are "fbsd" (displays "FreeBSD") and "dbsd" (displays "DruidBSD"). An invalid value (such as "none") will disable the display of any brand. The brand is displayed above the dynamic menu. The default is "fbsd". loader_brand_x=3D"N" loader_brand_y=3D"N" Column (x) and row (y) placement of the brand text ("FreeBSD") placed above the dynamic menu. Defaults are 2 (x) and 1 (y). loader_menu_timeout=3D"N" Timeout in seconds (N) until the menu aborts, causing the system to autoboot with the displayed options. Default is 10 seconds. Pressing any key during the duration will cancel the timeout. You can use values as high as you like, however due to limited screen real-estate (at a mere 24 rows x 80 columns for compatibility reasons) the counter will simply display "9 seconds" while counting down internally. Once the final countdown is upon you, the numbers will finally start to move. A future version could overcome this limitation. loader_menu_timeout_x=3D"N" loader_menu_timeout_y=3D"N" Column (x) and row (y) placement of the menu timeout count-down text. Defaults are 4 (x) and 23 (y). loader_password=3D"..." Sets a password (up to 16 characters long) that is required to be entered before the system is allowed to boot. Default is to not ask for a password if unset or NULL. loader_version=3D"..." Overrides the display of the loader's built-in version. Displays the text at the bottom-right edge of the screen (underneath beastie). The version text is right-justified when displayed. The current default is to not display any text. However, as-of RELENG_9, there may be plans to modify loader(8) to export this variable for display during the boot process, displaying the version of boot-loader for trouble-shooting purposes. loader_version_x=3D"N" loader_version_y=3D"N" Column (x) and row (y) placement of the loader's built-in version at the bottom-right edge of the screen. Defaults are 80 (x) and 24 (y). The version text is right-justified with the text ending at (x,y). dc_seconds=3D"N" By default, loader_menu introduces a 2-second delay before launching the menu for improved debugging abilities. This option customizes the duration (setting it to zero disables the delay). However, it is worth noting that pressing ENTER anytime during the delay will preempt the duration, launching the menu immediately upon keypress. WWW: http://druidbsd.sourceforge.net/ =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D Once again, you can grab the updated code here: http://druidbsd.sourceforge.net/ or http://druidbsd.sourceforge.net/download/loader_menu-1.1.tgz --=20 Cheers, Devin Teske -> LEGAL DISCLAIMER <- This message contains confidential and proprietary information of the sender, and is intended only for the person(s) to whom it is addressed. Any use, distribution, copying or disclosure by any other person is strictly prohibited. If you have received this message in error, please notify the e-mail sender immediately, and delete the original message without making a copy. -> FUN STUFF <- -----BEGIN GEEK CODE BLOCK----- Version 3.12 GAT/CS/B/CC/E/IT/MC/M/MU/P/S/TW d+(++) s: a- C+++@$ UB++++$ P++++@$ L++++$ = E- W+++ N? o? K? w@ O M++$ V- PS+>++ PE@ Y+ PGP-> t(+) 5? X(+) R(-) tv+ b+>++ = DI+ D+(++) G++ e>++++ h r+++ z+++ ------END GEEK CODE BLOCK------ http://www.geekcode.com/ -> END TRANSMISSION <- _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Mon May 2 21:26:43 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8C93106564A for ; Mon, 2 May 2011 21:26:43 +0000 (UTC) (envelope-from olivier@gid0.org) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 587418FC15 for ; Mon, 2 May 2011 21:25:21 +0000 (UTC) Received: by pzk27 with SMTP id 27so4225097pzk.13 for ; Mon, 02 May 2011 14:25:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.41.194 with SMTP id h2mr9705473pbl.273.1304371521515; Mon, 02 May 2011 14:25:21 -0700 (PDT) Received: by 10.68.40.4 with HTTP; Mon, 2 May 2011 14:25:21 -0700 (PDT) In-Reply-To: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> Date: Mon, 2 May 2011 23:25:21 +0200 Message-ID: From: Olivier Smedts To: Devin Teske Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 02 May 2011 22:01:36 +0000 Cc: Zhihao@freebsd.org, Freddie@freebsd.org, Losh@freebsd.org, Dieter@freebsd.org, Warner@freebsd.org, Yuan@freebsd.org, mwm@mired.org, Devin@freebsd.org, Teske@freebsd.org, Fleuriot@freebsd.org, Block@freebsd.org, Artem@freebsd.org, Meyer@freebsd.org, Mike@freebsd.org, Jason@freebsd.org, SMEDTS@freebsd.org, Erol@freebsd.org, Alexander@freebsd.org, Damien@freebsd.org, Sanliturk@freebsd.org, Schenkeveld@freebsd.org, Mehmet@freebsd.org, Doug@freebsd.org, Hellenthal@freebsd.org, BSD@freebsd.org, Paul@freebsd.org, FreeBSD Hackers , Warren@freebsd.org, Leidinger@freebsd.org, Robison@freebsd.org, Belevich@freebsd.org, Cash@freebsd.org, Barton@freebsd.org, Dave@freebsd.org, Olivier@freebsd.org Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2011 21:26:44 -0000 2011/5/2 Devin Teske : > NOTE: Apologies if this comes through multiple times. I'm having problems= getting this e-mail to appear on the list. > > Hi again, fellow hackers, > > First, I'd like to thank all of you for the input and suggestions that yo= u provided. > > Things are moving fast and nimble here. With over 1,000 lines of code cha= nged (in one single 24-hour period), I'd like to announce an update to my a= dvanced boot-loader menu. This version (1.1) attempts to address all commun= ity requests. > > You can grab the updated code here: > http://druidbsd.sourceforge.net/ > =A0 =A0 =A0 =A0or > http://druidbsd.sourceforge.net/download/loader_menu-1.1.tgz Using it right now. Great :) What would you think of using the "bw" variant of a logo when loader_color=3D"NO" ? Oh forget that, I tried without a loader_logo setting, and it seems to be the case with the default orb. It was only strange with my previous setting of loader_logo=3D"beastie", without the new "loader_color" setting. The previous loader behavior when an unknown key was pressed was to reset the delay to the autoboot_delay value. And it also worked with, for examble, the arrow keys. I appreciated it, like I appreciate your "Space to pause" ! Do you know why this loader displays "ACPI Support: Disabled" on my 9-CURRENT amd64 computer when it really seems to be enabled ? Note acpi.ko is not loaded, it's in the GENERIC kernel. > loader_menu_timeout=3D"N" > > =A0 =A0 =A0 =A0Timeout in seconds (N) until the menu aborts, causing the = system to > =A0 =A0 =A0 =A0autoboot with the displayed options. Default is 10 seconds= . Pressing > =A0 =A0 =A0 =A0any key during the duration will cancel the timeout. Could you add a compatibility shim for the actual autoboot_delay variable ? > dc_seconds=3D"N" > > =A0 =A0 =A0 =A0By default, loader_menu introduces a 2-second delay before= launching > =A0 =A0 =A0 =A0the menu for improved debugging abilities. This option cus= tomizes the > =A0 =A0 =A0 =A0duration (setting it to zero disables the delay). However,= it is worth > =A0 =A0 =A0 =A0noting that pressing ENTER anytime during the delay will p= reempt the > =A0 =A0 =A0 =A0duration, launching the menu immediately upon keypress. For consistency with all the logo_* variables, what would you think of using something like loader_delay instead of dc_seconds ? (and yes, I know, autoboot_delay doesn't begin with "loader_", but it was there before ;) Many thanks ! --=20 Olivier Smedts=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=A0 _ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 ASCII ribbon campaign ( ) e-mail: olivier@gid0.org=A0 =A0 =A0 =A0 - against HTML email & vCards=A0 X www: http://www.gid0.org=A0 =A0 - against proprietary attachments / \ =A0 "Il y a seulement 10 sortes de gens dans le monde : =A0 ceux qui comprennent le binaire, =A0 et ceux qui ne le comprennent pas." From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 00:48:27 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C1D3106566C for ; Tue, 3 May 2011 00:48:27 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id E5A998FC18 for ; Tue, 3 May 2011 00:48:26 +0000 (UTC) Received: from SBHFISLREXT03 ([10.132.254.62]) by SCSFISLTC01 (8.14.3/8.14.3) with ESMTP id p430mPum016352; Mon, 2 May 2011 19:48:25 -0500 Received: from SBHFISLTCGW04.FNFIS.COM (Not Verified[10.132.248.123]) by SBHFISLREXT03 with MailMarshal (v6, 5, 4, 7535) id ; Mon, 02 May 2011 19:48:28 -0500 Received: from sbhfisltcgw01.FNFIS.COM ([10.132.248.121]) by SBHFISLTCGW04.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Mon, 2 May 2011 19:48:25 -0500 Received: from dtwin ([10.132.254.136]) by sbhfisltcgw01.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 2 May 2011 19:48:24 -0500 From: "Devin Teske" To: References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> In-Reply-To: Date: Mon, 2 May 2011 17:48:31 -0700 Organization: Vicor, Inc. Message-ID: <013201cc092b$d3c7c470$7b574d50$@vicor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQDgmRfeLsy4wLEIiFlDotMJ0wufHwLYWr3Uljo0+kA= Content-Language: en-us X-OriginalArrivalTime: 03 May 2011 00:48:24.0786 (UTC) FILETIME=[CEFD6B20:01CC092B] Cc: Olivier SMEDTS Subject: RE: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 00:48:27 -0000 UPDATE: New version 1.2 released right now. Get your update at: http://druidbsd.sourceforge.net/ or http://druidbsd.sourceforge.net/download/loader_menu-1.2.tgz Keep reading for details/discussion below. > -----Original Message----- > From: Olivier Smedts [mailto:olivier@gid0.org] > Sent: Monday, May 02, 2011 2:25 PM > To: Devin Teske > Cc: FreeBSD Hackers; mwm@mired.org; Mike@freebsd.org; > Meyer@freebsd.org; Warner@freebsd.org; Losh@freebsd.org; > Freddie@freebsd.org; Cash@freebsd.org; Alexander@freebsd.org; > Leidinger@freebsd.org; Olivier@freebsd.org; SMEDTS@freebsd.org; > Warren@freebsd.org; Block@freebsd.org; Doug@freebsd.org; > Barton@freebsd.org; Artem@freebsd.org; Belevich@freebsd.org; > Dieter@freebsd.org; BSD@freebsd.org; Jason@freebsd.org; > Hellenthal@freebsd.org; Devin@freebsd.org; Teske@freebsd.org; > Damien@freebsd.org; Fleuriot@freebsd.org; Zhihao@freebsd.org; > Yuan@freebsd.org; Paul@freebsd.org; Schenkeveld@freebsd.org; > Mehmet@freebsd.org; Erol@freebsd.org; Sanliturk@freebsd.org; > Dave@freebsd.org; Robison@freebsd.org > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 >=20 > 2011/5/2 Devin Teske : > > NOTE: Apologies if this comes through multiple times. I'm having proble= ms > getting this e-mail to appear on the list. > > > > Hi again, fellow hackers, > > > > First, I'd like to thank all of you for the input and suggestions that = you provided. > > > > Things are moving fast and nimble here. With over 1,000 lines of code changed > (in one single 24-hour period), I'd like to announce an update to my adva= nced > boot-loader menu. This version (1.1) attempts to address all community > requests. > > > > You can grab the updated code here: > > http://druidbsd.sourceforge.net/ > > =A0 =A0 =A0 =A0or > > http://druidbsd.sourceforge.net/download/loader_menu-1.1.tgz >=20 > Using it right now. Great :) ^_^ > What would you think of using the "bw" variant of a logo when > loader_color=3D"NO" ? > Oh forget that, I tried without a loader_logo setting, and it seems to be= the case > with the default orb. It was only strange with my previous setting of > loader_logo=3D"beastie", without the new "loader_color" > setting. Right. I wanted it to function so that if you explicitly set loader_logo, t= hat it would override the use of loader_color. If you don't set loader_logo, th= en playing with loader_color will automatically switch from orbbw to orb, wher= eas if you set it to something like "beastie", you'll get that logo regardless = of what loader_color is set to. > The previous loader behavior when an unknown key was pressed was to reset > the delay to the autoboot_delay value. I wasn't aware of that functionality (I'd always pressed SPACE to pause the timer). Maybe a dumb question, but why would anybody want to reset the timer? I can= 't think of a single scenario where I'd prefer a timer to be reset on keypress opposed to just stopping. I'm of the school of thought that there are only = three reasonable scenarios where you'd want to abate auto-boot (listed below), al= l of which involve more time than just "another 10 seconds" gained by resetting = the timer: 1. Slow readers (of which I am guilty of) 2. People that just want to bask in the glory of the boot-loader (also guil= ty) 3. Hackers that want to rewrite rogue(6) in FICL for the boot-loader (work = in progress?) Is this a serious concern (removing the "reset timer on unknown key" functionality)? > And it also worked with, for examble, the > arrow keys. I appreciated it, like I appreciate your "Space to pause" ! >=20 Arrow keys are funny. They produce a zero value by the "key" function, so detecting them is ... impossible. However, I was able to correct this behavior. Version 1.2 (just released ri= ght now) will cancel the timeout on ANY keypress, including keys that produce N= ULL keycodes (such as arrows, navigational keys, command sequences, and special= key combinations). > Do you know why this loader displays "ACPI Support: Disabled" on my 9-CUR= RENT > amd64 computer when it really seems to be enabled ? Note acpi.ko is not loaded, > it's in the GENERIC kernel. >=20 The previous version (1.0) had a hard-coded "set acpi_load=3DYES" in /boot/menu-commands.4th. This has been removed in favor of dynamically dete= cting "acpi_load" at boot time. This version (1.1) works nearly identically to the standard menu that ships= with FreeBSD in that it detects whether ACPI is enabled (truth be told, I actual= ly re-used the "acpienabled?" function verbatim from /boot/beastie.4th by Scott Long and Aleksander Fafula). The ACPI detection of my boot loader (version = 1.1 or higher) should be identical to the detection of the current boot-loader. I would be willing to bet that your workstation -- while running the default boot loader -- displays "Boot FreeBSD with ACPI enabled" for option #2 (indicating that ACPI appears to be disabled from your system's perspective= ). As far as I know, the loader does not know that ACPI is compiled into your kernel. Rather the ACPI menuitem (both in the default boot-loader menu and = in my version 1.1) hinges on whether "acpi_load" is defined (and is enabled). On a side-note, the same exact code is displaying ACPI as enabled for me (running under Parallels 4 on Mac OS X 10.6.7) at boot time. Yet, I do not = have acpi_load in loader.conf(5), though I do have a kernel with ACPI built-in. = My guess is that loader(8) is setting load_acpi=3D"YES", which I verify immedi= ately after executing loader(8) and the loader.4th start-word (which reads loader.conf(5) among other things). > > loader_menu_timeout=3D"N" > > > > =A0 =A0 =A0 =A0Timeout in seconds (N) until the menu aborts, causing the > > system to > > =A0 =A0 =A0 =A0autoboot with the displayed options. Default is 10 secon= ds. > > Pressing > > =A0 =A0 =A0 =A0any key during the duration will cancel the timeout. >=20 > Could you add a compatibility shim for the actual autoboot_delay variable= ? I've decided to simply do-away with loader_menu_timeout and have it simply = use autoboot_delay. This is effective as of version 1.2 (released today). > > dc_seconds=3D"N" > > > > =A0 =A0 =A0 =A0By default, loader_menu introduces a 2-second delay befo= re > > launching > > =A0 =A0 =A0 =A0the menu for improved debugging abilities. This option > > customizes the > > =A0 =A0 =A0 =A0duration (setting it to zero disables the delay). Howeve= r, it > > is worth > > =A0 =A0 =A0 =A0noting that pressing ENTER anytime during the delay will > > preempt the > > =A0 =A0 =A0 =A0duration, launching the menu immediately upon keypress. >=20 > For consistency with all the logo_* variables, what would you think of us= ing > something like loader_delay instead of dc_seconds ? (and yes, I know, > autoboot_delay doesn't begin with "loader_", but it was there before ;) I agree, however this will require a rewrite of that module. I'll try to ge= t to that later this week. -- Devin > Many thanks ! >=20 > -- > Olivier Smedts=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=A0 _ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 ASCII ribbon campaign ( ) > e-mail: olivier@gid0.org=A0 =A0 =A0 =A0 - against HTML email & vCards=A0 X > www: http://www.gid0.org=A0 =A0 - against proprietary attachments / \ >=20 > =A0 "Il y a seulement 10 sortes de gens dans le monde : > =A0 ceux qui comprennent le binaire, > =A0 et ceux qui ne le comprennent pas." _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 03:57:08 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE865106566C for ; Tue, 3 May 2011 03:57:08 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id 829A98FC0C for ; Tue, 3 May 2011 03:57:08 +0000 (UTC) Received: from sbhfislrext01.fnfis.com ([192.168.249.167]) by SCSFISLTC02 (8.14.3/8.14.3) with ESMTP id p433v7mX009276; Mon, 2 May 2011 22:57:07 -0500 Received: from SBHFISLTCGW04.FNFIS.COM (Not Verified[10.132.248.123]) by sbhfislrext01.fnfis.com with MailMarshal (v6, 5, 4, 7535) id ; Mon, 02 May 2011 22:57:07 -0500 Received: from SBHFISLTCGW04.FNFIS.COM ([10.132.248.123]) by SBHFISLTCGW04.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Mon, 2 May 2011 22:57:07 -0500 Received: from [10.0.0.102] ([10.132.254.136]) by SBHFISLTCGW04.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 2 May 2011 22:57:06 -0500 From: Devin Teske Date: Mon, 2 May 2011 20:57:05 -0700 Message-Id: <6955841F-C3C1-4C7D-8BA4-F8EBBF60F69B@vicor.com> To: FreeBSD Hackers Mime-Version: 1.0 (Apple Message framework v1084) X-Mailer: Apple Mail (2.1084) X-OriginalArrivalTime: 03 May 2011 03:57:06.0984 (UTC) FILETIME=[2B8BBA80:01CC0946] Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Olivier SMEDTS Subject: [UPDATE] New Boot-Loader Menu -- version 1.3 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 03:57:08 -0000 Hey all, Proud to bring you version 1.3 which completes the followup suggestions mad= e by Olivier Smedts (use autoboot_delay instead of loader_menu_timeout and = change dc_seconds to loader_delay) and a couple other minor enhancements/fi= xes. I think that brings everything up to speed with the phenomenal feedback pro= vided so far. Really, thank you all very much. Get your update at http://druidbsd.sf.net/ or http://druidbsd.sourceforge.n= et/download/loader_menu-1.3.tgz Here's a dump of the latest pkg-descr (the pertinent parts that have change= d are highlighted above and one additional paragraph added to the end about= loader_delay): loader_menu is a modern boot loader for the FreeBSD Operating System. The following options can be added to loader.conf(5) to customize the behav= ior and/or appearance of the boot menu/process: autoboot_delay=3D"N" Timeout in seconds (N) until the menu aborts, causing the system to autoboot with the displayed options. Default is 10 seconds. Pressing any key during the duration will cancel the timeout. You can use values as high as you like, however due to limited screen real-estate (at a mere 24 rows x 80 columns for compatibility reasons) the counter will simply display "9 seconds" while counting down internally. Once the final countdown is upon you, the numbers will finally start to move. A future version could overcome this limitation. loader_menu_timeout_x=3D"N" loader_menu_timeout_y=3D"N" Column (x) and row (y) placement of the menu timeout count-down text. Defaults are 4 (x) and 23 (y). loader_color=3D"YES" Enables the use of color in the boot menu. Not all devices support the display of ANSI color codes, and so the default is to not use them. loader_logo=3D"..." Selects which FreeBSD logo to display. Valid values are "beastie", "beastiebw", "fbsdbw", "orb", or "orbbw". An invalid value (such as "none") will disable the display of any logo. The logo is displayed to the right of the dynamic menu. loader_logo_x=3D"N" loader_logo_y=3D"N" Column (x) and row (y) placement of FreeBSD" mascot placed to the right of the dynamic menu. Defaults are 46 (x) and 4 (y). loader_brand=3D"..." Selects the BSD brand to display. Valid values are "fbsd" (displays "FreeBSD") and "dbsd" (displays "DruidBSD"). An invalid value (such as "none") will disable the display of any brand. The brand is displayed above the dynamic menu. The default is "fbsd". loader_brand_x=3D"N" loader_brand_y=3D"N" Column (x) and row (y) placement of the brand text ("FreeBSD") placed above the dynamic menu. Defaults are 2 (x) and 1 (y). loader_password=3D"..." Sets a password (up to 16 characters long) that is required to be entered before the system is allowed to boot. Default is to not ask for a password if unset or NULL. loader_version=3D"..." Overrides the display of the loader's built-in version. Displays the text at the bottom-right edge of the screen (underneath beastie). The version text is right-justified when displayed. The current default is to not display any text. However, as-of RELENG_9, there may be plans to modify loader(8) to export this variable for display during the boot process, displaying the version of boot-loader for trouble-shooting purposes. loader_version_x=3D"N" loader_version_y=3D"N" Column (x) and row (y) placement of the loader's built-in version at the bottom-right edge of the screen. Defaults are 80 (x) and 24 (y). The version text is right-justified with the text ending at (x,y). loader_delay=3D"N" By default, loader_menu introduces a 2-second delay before launching the menu for improved debugging abilities. This option customizes the duration (setting it to zero disables the delay). However, it is worth noting that pressing ENTER anytime during the delay will preempt the duration, launching the menu immediately upon keypress. During this delay, a string of dots is displayed. The user can press Ctrl-C or Esc on the keyboard to prevent the loading of the dynamic menu system. After pressing either of these keys, the loader will drop to the usual autoboot sequence (counting down autoboot_delay seconds until booting the loaded kernel). During the autoboot sequence, any key pressed except for ENTER will allow escaping to the loader prompt. WWW: http://druidbsd.sourceforge.net/ --=20 Cheers, Devin Teske -> LEGAL DISCLAIMER <- This message contains confidential and proprietary information of the sender, and is intended only for the person(s) to whom it is addressed. Any use, distribution, copying or disclosure by any other person is strictly prohibited. If you have received this message in error, please notify the e-mail sender immediately, and delete the original message without making a copy. -> FUN STUFF <- -----BEGIN GEEK CODE BLOCK----- Version 3.12 GAT/CS/B/CC/E/IT/MC/M/MU/P/S/TW d+(++) s: a- C+++@$ UB++++$ P++++@$ L++++$ = E- W+++ N? o? K? w@ O M++$ V- PS+>++ PE@ Y+ PGP-> t(+) 5? X(+) R(-) tv+ b+>++ = DI+ D+(++) G++ e>++++ h r+++ z+++ ------END GEEK CODE BLOCK------ http://www.geekcode.com/ -> END TRANSMISSION <- _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 08:15:22 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E924B1065670 for ; Tue, 3 May 2011 08:15:22 +0000 (UTC) (envelope-from olivier@gid0.org) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id C80618FC23 for ; Tue, 3 May 2011 08:15:22 +0000 (UTC) Received: by pzk27 with SMTP id 27so4457993pzk.13 for ; Tue, 03 May 2011 01:15:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.14.37 with SMTP id m5mr1719800pbc.474.1304410522235; Tue, 03 May 2011 01:15:22 -0700 (PDT) Received: by 10.68.40.4 with HTTP; Tue, 3 May 2011 01:15:22 -0700 (PDT) In-Reply-To: <013201cc092b$d3c7c470$7b574d50$@vicor.com> References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <013201cc092b$d3c7c470$7b574d50$@vicor.com> Date: Tue, 3 May 2011 10:15:22 +0200 Message-ID: From: Olivier Smedts To: Devin Teske Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 08:15:23 -0000 2011/5/3 Devin Teske : >> The previous loader behavior when an unknown key was pressed was to rese= t >> the delay to the autoboot_delay value. > > I wasn't aware of that functionality (I'd always pressed SPACE to pause t= he > timer). > > Maybe a dumb question, but why would anybody want to reset the timer? I c= an't > think of a single scenario where I'd prefer a timer to be reset on keypre= ss > opposed to just stopping. I'm of the school of thought that there are onl= y three > reasonable scenarios where you'd want to abate auto-boot (listed below), = all of > which involve more time than just "another 10 seconds" gained by resettin= g the > timer: > > 1. Slow readers (of which I am guilty of) > 2. People that just want to bask in the glory of the boot-loader (also gu= ilty) > 3. Hackers that want to rewrite rogue(6) in FICL for the boot-loader (wor= k in > progress?) It surprised me and this loader booted the system while I didn't want, beca= use : - I was accustomed of the previous behavior - I only had a 3 seconds delay to boot (I press a key when I want a longer delay, to read or find a key) - I wanted to see the new loader (you can count this as "slow readers") - I don't have a qwerty keyboard, so finding the right keys for the loader can take some time > Is this a serious concern (removing the "reset timer on unknown key" > functionality)? > >> And it also worked with, for examble, the >> arrow keys. I appreciated it, like I appreciate your "Space to pause" ! > > Arrow keys are funny. They produce a zero value by the "key" function, so > detecting them is ... impossible. > > However, I was able to correct this behavior. Version 1.2 (just released = right > now) will cancel the timeout on ANY keypress, including keys that produce= NULL > keycodes (such as arrows, navigational keys, command sequences, and speci= al key > combinations). OK, I'll test it, now the behavior is more like the previous loader, or grub. It's ok (for me) not to reset the timer if at least it stops on all keys ! >> Do you know why this loader displays "ACPI Support: Disabled" on my 9-CU= RRENT >> amd64 computer when it really seems to be enabled ? Note acpi.ko is not > loaded, >> it's in the GENERIC kernel. > > The previous version (1.0) had a hard-coded "set acpi_load=3DYES" in > /boot/menu-commands.4th. This has been removed in favor of dynamically de= tecting > "acpi_load" at boot time. > > This version (1.1) works nearly identically to the standard menu that shi= ps with > FreeBSD in that it detects whether ACPI is enabled (truth be told, I actu= ally > re-used the "acpienabled?" function verbatim from /boot/beastie.4th by Sc= ott > Long and Aleksander Fafula). The ACPI detection of my boot loader (versio= n 1.1 > or higher) should be identical to the detection of the current boot-loade= r. > > I would be willing to bet that your workstation -- while running the defa= ult > boot loader -- displays "Boot FreeBSD with ACPI enabled" for option #2 > (indicating that ACPI appears to be disabled from your system's perspecti= ve). No, it displays "Boot FreeBSD with ACPI disabled". I didn't know this text was dynamic, are you sure it's not hard-coded ? I can provide screenshots of both loaders. > As far as I know, the loader does not know that ACPI is compiled into you= r > kernel. Rather the ACPI menuitem (both in the default boot-loader menu an= d in my > version 1.1) hinges on whether "acpi_load" is defined (and is enabled). > > On a side-note, the same exact code is displaying ACPI as enabled for me > (running under Parallels 4 on Mac OS X 10.6.7) at boot time. Yet, I do no= t have > acpi_load in loader.conf(5), though I do have a kernel with ACPI built-in= . My > guess is that loader(8) is setting load_acpi=3D"YES", which I verify imme= diately > after executing loader(8) and the loader.4th start-word (which reads > loader.conf(5) among other things). > >> > loader_menu_timeout=3D"N" >> > >> > =A0 =A0 =A0 =A0Timeout in seconds (N) until the menu aborts, causing t= he >> > system to >> > =A0 =A0 =A0 =A0autoboot with the displayed options. Default is 10 seco= nds. >> > Pressing >> > =A0 =A0 =A0 =A0any key during the duration will cancel the timeout. >> >> Could you add a compatibility shim for the actual autoboot_delay variabl= e ? > > I've decided to simply do-away with loader_menu_timeout and have it simpl= y use > autoboot_delay. This is effective as of version 1.2 (released today). > >> > dc_seconds=3D"N" >> > >> > =A0 =A0 =A0 =A0By default, loader_menu introduces a 2-second delay bef= ore >> > launching >> > =A0 =A0 =A0 =A0the menu for improved debugging abilities. This option >> > customizes the >> > =A0 =A0 =A0 =A0duration (setting it to zero disables the delay). Howev= er, it >> > is worth >> > =A0 =A0 =A0 =A0noting that pressing ENTER anytime during the delay wil= l >> > preempt the >> > =A0 =A0 =A0 =A0duration, launching the menu immediately upon keypress. >> >> For consistency with all the logo_* variables, what would you think of u= sing >> something like loader_delay instead of dc_seconds ? (and yes, I know, >> autoboot_delay doesn't begin with "loader_", but it was there before ;) > > I agree, however this will require a rewrite of that module. I'll try to = get to > that later this week. Thanks again, I'll test 1.2 version in a few hours :) --=20 Olivier Smedts=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=A0 _ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 ASCII ribbon campaign ( ) e-mail: olivier@gid0.org=A0 =A0 =A0 =A0 - against HTML email & vCards=A0 X www: http://www.gid0.org=A0 =A0 - against proprietary attachments / \ =A0 "Il y a seulement 10 sortes de gens dans le monde : =A0 ceux qui comprennent le binaire, =A0 et ceux qui ne le comprennent pas." From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 09:23:37 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F1F7106566B for ; Tue, 3 May 2011 09:23:37 +0000 (UTC) (envelope-from olivier@gid0.org) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 3CECA8FC0C for ; Tue, 3 May 2011 09:23:36 +0000 (UTC) Received: by pwj8 with SMTP id 8so3977829pwj.13 for ; Tue, 03 May 2011 02:23:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.35.228 with SMTP id l4mr10601318pbj.5.1304414616152; Tue, 03 May 2011 02:23:36 -0700 (PDT) Received: by 10.68.40.4 with HTTP; Tue, 3 May 2011 02:23:36 -0700 (PDT) In-Reply-To: <6955841F-C3C1-4C7D-8BA4-F8EBBF60F69B@vicor.com> References: <6955841F-C3C1-4C7D-8BA4-F8EBBF60F69B@vicor.com> Date: Tue, 3 May 2011 11:23:36 +0200 Message-ID: From: Olivier Smedts To: Devin Teske Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Hackers Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.3 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 09:23:37 -0000 2011/5/3 Devin Teske : > Hey all, > Proud to bring you version 1.3 which completes the followup suggestions m= ade > by Olivier Smedts (use autoboot_delay instead of loader_menu_timeout and > change dc_seconds to loader_delay) and a couple other minor > enhancements/fixes. > I think that brings everything up to speed with the phenomenal feedback > provided so far. Really, thank you all very much. That was fast ! > Get your update > at=A0http://druidbsd.sf.net/=A0or=A0http://druidbsd.sourceforge.net/downl= oad/loader_menu-1.3.tgz Installed here, on another computer. Added to /boot/loader.conf : loader_delay=3D"0" loader_color=3D"YES" Removed : loader_logo=3D"beastie" Kept : autoboot_delay=3D"3" I'm happy with it. The "stop delay on all keys" feature is great, I have an habit of using arrow keys to stop or reset delays in boot loaders because those keys usually don't have a special meaning like letters or space bar can have (except selecting another entry, in grub for example). But still, on this computer I've got "2. ACPI Support: Disabled", while the old loader offers me to boot with ACPI disabled. ACPI seems enabled after boot in both cases. I've got this behavior on 2 computers with different hardware, they both use 9-CURRENT (latest and few days old) amd64, compiled with clang. I'll try to investigate a little more. Cheers --=20 Olivier Smedts=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=A0 _ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 ASCII ribbon campaign ( ) e-mail: olivier@gid0.org=A0 =A0 =A0 =A0 - against HTML email & vCards=A0 X www: http://www.gid0.org=A0 =A0 - against proprietary attachments / \ =A0 "Il y a seulement 10 sortes de gens dans le monde : =A0 ceux qui comprennent le binaire, =A0 et ceux qui ne le comprennent pas." From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 11:45:57 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2DB25106564A for ; Tue, 3 May 2011 11:45:57 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id F2DB28FC18 for ; Tue, 3 May 2011 11:45:56 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id F2EB146B0D; Tue, 3 May 2011 07:45:55 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8C82C8A027; Tue, 3 May 2011 07:45:55 -0400 (EDT) From: John Baldwin To: freebsd-hackers@freebsd.org Date: Tue, 3 May 2011 07:45:04 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <013201cc092b$d3c7c470$7b574d50$@vicor.com> In-Reply-To: <013201cc092b$d3c7c470$7b574d50$@vicor.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105030745.04486.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 03 May 2011 07:45:55 -0400 (EDT) Cc: Olivier SMEDTS , Devin Teske Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 11:45:57 -0000 On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: > This version (1.1) works nearly identically to the standard menu that ships with > FreeBSD in that it detects whether ACPI is enabled (truth be told, I actually > re-used the "acpienabled?" function verbatim from /boot/beastie.4th by Scott > Long and Aleksander Fafula). The ACPI detection of my boot loader (version 1.1 > or higher) should be identical to the detection of the current boot-loader. > > I would be willing to bet that your workstation -- while running the default > boot loader -- displays "Boot FreeBSD with ACPI enabled" for option #2 > (indicating that ACPI appears to be disabled from your system's perspective). > > As far as I know, the loader does not know that ACPI is compiled into your > kernel. Rather the ACPI menuitem (both in the default boot-loader menu and in my > version 1.1) hinges on whether "acpi_load" is defined (and is enabled). > > On a side-note, the same exact code is displaying ACPI as enabled for me > (running under Parallels 4 on Mac OS X 10.6.7) at boot time. Yet, I do not have > acpi_load in loader.conf(5), though I do have a kernel with ACPI built-in. My > guess is that loader(8) is setting load_acpi="YES", which I verify immediately > after executing loader(8) and the loader.4th start-word (which reads > loader.conf(5) among other things). Err, note that the acpienabled stuff is all different in HEAD than in 7/8 since acpi.ko no longer exists. You should use the scheme from HEAD for handling ACPI present vs ACPI enabled/disabled. -- John Baldwin From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 13:28:41 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 260A2106564A for ; Tue, 3 May 2011 13:28:41 +0000 (UTC) (envelope-from philip-freebsd1@soeberg.net) Received: from pasmtpB.tele.dk (pasmtpb.tele.dk [80.160.77.98]) by mx1.freebsd.org (Postfix) with ESMTP id D78F98FC16 for ; Tue, 3 May 2011 13:28:40 +0000 (UTC) Received: from mail.soeberg.net (0x573f534a.cpe.ge-1-1-0-1109.bynqu1.customer.tele.dk [87.63.83.74]) by pasmtpB.tele.dk (Postfix) with ESMTP id DE9BAE30317 for ; Tue, 3 May 2011 15:10:23 +0200 (CEST) Received: from [10.240.10.87] ([188.120.77.114]) (authenticated user philip@soeberg.net) by mail.soeberg.net (using TLSv1/SSLv3 with cipher AES256-SHA (256 bits)) for freebsd-hackers@freebsd.org; Tue, 3 May 2011 15:10:27 +0200 Message-ID: <4DBFFEC2.4010506@soeberg.net> Date: Tue, 03 May 2011 15:10:26 +0200 From: Philip Soeberg User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Runtime check for PAE option on BSD 6+ i386 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: philip-freebsd1@soeberg.net List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 13:28:41 -0000 Hi fellow FreeBSD hackers, I've been using the following poor-man's approach in my driver init for ages in an attempt at detecting PAE option on BSD 6 (or greater) i386 kernels, as I depend on dmabus(9) but provide a loadable kernel module only. >>> if (sizeof(void*) == 4) { if (((uint64_t)(cnt.v_page_count * cnt.v_page_size) / 1073741824) >= 4) { printf("FreeBSD i386 detected with PAE option enabled. FreeBSD PAE type\n"); printf("kernels does not support loadable modules which use DMA. Please\n"); printf("reconfigure your kernel for non-PAE or switch to amd64 kernel.\n"); return EFAULT; } } <<< afaik there's a sysctl method of checking this per BSD7 (or is it 8?), but what about BSD6? Any hints on how I can runtime detect the above? Thanx, Phil From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 16:31:19 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3AD3D1065674 for ; Tue, 3 May 2011 16:31:19 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id E49618FC21 for ; Tue, 3 May 2011 16:31:18 +0000 (UTC) Received: from sbhfislrext02.fnfis.com ([192.168.249.140]) by SCSFISLTC02 (8.14.3/8.14.3) with ESMTP id p43GVIFm023351; Tue, 3 May 2011 11:31:18 -0500 Received: from sbhfisltcgw02.FNFIS.COM (Not Verified[10.132.248.122]) by sbhfislrext02.fnfis.com with MailMarshal (v6, 5, 4, 7535) id ; Tue, 03 May 2011 11:31:19 -0500 Received: from sbhfisltcgw01.FNFIS.COM ([10.132.248.121]) by sbhfisltcgw02.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Tue, 3 May 2011 11:31:17 -0500 Received: from [192.168.1.123] ([10.132.254.136]) by sbhfisltcgw01.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 3 May 2011 11:31:16 -0500 Mime-Version: 1.0 (Apple Message framework v1084) From: Devin Teske In-Reply-To: <201105030745.04486.jhb@freebsd.org> Date: Tue, 3 May 2011 09:31:14 -0700 Message-Id: References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <013201cc092b$d3c7c470$7b574d50$@vicor.com> <201105030745.04486.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1084) X-OriginalArrivalTime: 03 May 2011 16:31:16.0579 (UTC) FILETIME=[8667FB30:01CC09AF] Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Olivier SMEDTS , freebsd-hackers@freebsd.org Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 16:31:19 -0000 On May 3, 2011, at 4:45 AM, John Baldwin wrote: > On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: >> This version (1.1) works nearly identically to the standard menu that sh= ips with >> FreeBSD in that it detects whether ACPI is enabled (truth be told, I act= ually >> re-used the "acpienabled?" function verbatim from /boot/beastie.4th by S= cott >> Long and Aleksander Fafula). The ACPI detection of my boot loader (versi= on 1.1 >> or higher) should be identical to the detection of the current boot-load= er. Ugh. By "current", I meant 8.1-RELEASE (wasn't expecting this stuff to be d= ifferent in HEAD, which it is). > Err, note that the acpienabled stuff is all different in HEAD than in 7/8 > since acpi.ko no longer exists. You should use the scheme from HEAD for > handling ACPI present vs ACPI enabled/disabled. >=20 > --=20 > John Baldwin Ok, I see the new "acpipresent?" word (which replaces the "arch-i386" envir= onment-test). Does this imply that we're going to support ACPI on non-i386 = platforms (or already do)? I also see the rewritten "acpienabled?" word. Nice. I'll slurp it in to mak= e my ACPI detection the same as HEAD. I also performed some backward compatibility tests. Looks like this will be= backward compatible with 8.1-RELEASE (loader_version =3D=3D 11). However, = the code in HEAD appears to not work in 8.0-RELEASE (loader_version =3D=3D = 8). I'm thinking about adding the following test-case to the "acpienabled?" wor= d to add backward compatibility: : acpienabled? ( -- flag ) \ BEGIN: Additional code for backward compatibility s" loader_version" environment? if 11 < if \ older version of loader(8) s" acpi_load" getenv dup -1 =3D if drop false exit then s" YES" compare-insensitive 0<> if false exit then then then \ END: Additional code for backward compatibility \ BEGIN: Existing code in HEAD s" hiint.acpi.0.disabled" getenv dup -1 <> if s" 0" compare 0<> if false exit then else drop then true \ END: Existing code in HEAD ; In-addition, I'm also thinking about adding the following test-case to the = new "acpipresent?" word to add backward compatibility: : acpipresent? ( -- flag ) \ BEGIN: Additional code for backward compatibility s" loader_version" environment? if 11 < if \ older version of loader(8) s" arch-i386" environment? if drop true exit else false exit then then then \ END: Additional code for backward compatibility \ BEGIN: Existing code in HEAD s" hint.acpi.0.rsdp" getenv dup -1 =3D if drop false exit then 2drop true \ END: Existing code in HEAD ; What do you think? I'm actually thinking this would be a good change to inc= orporate HEAD. --=20 Cheers, Devin Teske -> CONTACT INFORMATION <- Business Solutions Consultant II FIS - fisglobal.com 510-735-5650 Mobile 510-621-2038 Office 510-621-2020 Office Fax 909-477-4578 Home/Fax devin.teske@fisglobal.com -> LEGAL DISCLAIMER <- This message contains confidential and proprietary information of the sender, and is intended only for the person(s) to whom it is addressed. Any use, distribution, copying or disclosure by any other person is strictly prohibited. If you have received this message in error, please notify the e-mail sender immediately, and delete the original message without making a copy. -> END TRANSMISSION <- _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 17:35:43 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA5501065679 for ; Tue, 3 May 2011 17:35:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id A1DA38FC0A for ; Tue, 3 May 2011 17:35:43 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 5593E46B09; Tue, 3 May 2011 13:35:43 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id D921F8A027; Tue, 3 May 2011 13:35:42 -0400 (EDT) From: John Baldwin To: freebsd-hackers@freebsd.org, philip-freebsd1@soeberg.net Date: Tue, 3 May 2011 11:44:32 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <4DBFFEC2.4010506@soeberg.net> In-Reply-To: <4DBFFEC2.4010506@soeberg.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105031144.32862.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 03 May 2011 13:35:43 -0400 (EDT) Cc: Subject: Re: Runtime check for PAE option on BSD 6+ i386 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 17:35:43 -0000 On Tuesday, May 03, 2011 9:10:26 am Philip Soeberg wrote: > Hi fellow FreeBSD hackers, > > I've been using the following poor-man's approach in my driver init for > ages in an attempt at detecting PAE option on BSD 6 (or greater) i386 > kernels, as I depend on dmabus(9) but provide a loadable kernel module only. > > >>> > if (sizeof(void*) == 4) { > if (((uint64_t)(cnt.v_page_count * cnt.v_page_size) / 1073741824) > >= 4) { > printf("FreeBSD i386 detected with PAE option enabled. FreeBSD > PAE type\n"); > printf("kernels does not support loadable modules which use DMA. > Please\n"); > printf("reconfigure your kernel for non-PAE or switch to amd64 > kernel.\n"); > return EFAULT; > } > } > <<< Hmmm, even this isn't really accurate as some folks may choose to enable PAE even with < 4GB to get PG_NX functionality. > afaik there's a sysctl method of checking this per BSD7 (or is it 8?), > but what about BSD6? Any hints on how I can runtime detect the above? Definitely a kern.features.pae sysctl in 7. I don't see anything similar in 6. -- John Baldwin From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 17:35:45 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0FCDF1065673 for ; Tue, 3 May 2011 17:35:45 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D8EFA8FC18 for ; Tue, 3 May 2011 17:35:44 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 8EDB446B32; Tue, 3 May 2011 13:35:44 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 31B888A02B; Tue, 3 May 2011 13:35:44 -0400 (EDT) From: John Baldwin To: Devin Teske Date: Tue, 3 May 2011 13:32:41 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <201105030745.04486.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201105031332.41827.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 03 May 2011 13:35:44 -0400 (EDT) Cc: Olivier SMEDTS , freebsd-hackers@freebsd.org Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 17:35:45 -0000 On Tuesday, May 03, 2011 12:31:14 pm Devin Teske wrote: > > On May 3, 2011, at 4:45 AM, John Baldwin wrote: > > > On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: > >> This version (1.1) works nearly identically to the standard menu that ships with > >> FreeBSD in that it detects whether ACPI is enabled (truth be told, I actually > >> re-used the "acpienabled?" function verbatim from /boot/beastie.4th by Scott > >> Long and Aleksander Fafula). The ACPI detection of my boot loader (version 1.1 > >> or higher) should be identical to the detection of the current boot-loader. > > Ugh. By "current", I meant 8.1-RELEASE (wasn't expecting this stuff to be different in HEAD, which it is). > > > > Err, note that the acpienabled stuff is all different in HEAD than in 7/8 > > since acpi.ko no longer exists. You should use the scheme from HEAD for > > handling ACPI present vs ACPI enabled/disabled. > > > > -- > > John Baldwin > > > Ok, I see the new "acpipresent?" word (which replaces the "arch-i386" > environment-test). Does this imply that we're going to support ACPI on > non-i386 platforms (or already do)? amd64 and ia64 have always supported ACPI. ia64 effectively requires it. However, "hint.acpi.0.rsdp" is set by biosacpi.c in the i386 loader bits, so other platforms will not set it, so the arch-i386 test is no longer needed. > I also see the rewritten "acpienabled?" word. Nice. I'll slurp it in to > make my ACPI detection the same as HEAD. > > I also performed some backward compatibility tests. Looks like this will be > backward compatible with 8.1-RELEASE (loader_version == 11). However, the > code in HEAD appears to not work in 8.0-RELEASE (loader_version == 8). Hmm, which part does not work in 8.0? arch-i386 has existed since at least 4.x I thought, and the ACPI bits have been setting hint.acpi.0.rsdp since 7.0 (sys/boot/i386/libi386/biosacpi.c CVS rev 1.12 added it). -- John Baldwin From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 17:43:44 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5089D10656B7; Tue, 3 May 2011 17:43:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 28BB68FC17; Tue, 3 May 2011 17:43:42 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p43HhdYD086134 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 May 2011 20:43:39 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p43Hhdpq082417; Tue, 3 May 2011 20:43:39 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p43Hhd4S082416; Tue, 3 May 2011 20:43:39 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 3 May 2011 20:43:39 +0300 From: Kostik Belousov To: John Baldwin Message-ID: <20110503174339.GI48734@deviant.kiev.zoral.com.ua> References: <4DBFFEC2.4010506@soeberg.net> <201105031144.32862.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eVUvLhJy3aWqIBaz" Content-Disposition: inline In-Reply-To: <201105031144.32862.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-hackers@freebsd.org, philip-freebsd1@soeberg.net Subject: Re: Runtime check for PAE option on BSD 6+ i386 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 17:43:44 -0000 --eVUvLhJy3aWqIBaz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 03, 2011 at 11:44:32AM -0400, John Baldwin wrote: > On Tuesday, May 03, 2011 9:10:26 am Philip Soeberg wrote: > > Hi fellow FreeBSD hackers, > >=20 > > I've been using the following poor-man's approach in my driver init for= =20 > > ages in an attempt at detecting PAE option on BSD 6 (or greater) i386= =20 > > kernels, as I depend on dmabus(9) but provide a loadable kernel module = only. > >=20 > > >>> > > if (sizeof(void*) =3D=3D 4) { > > if (((uint64_t)(cnt.v_page_count * cnt.v_page_size) / 1073741824)= =20 > > >=3D 4) { > > printf("FreeBSD i386 detected with PAE option enabled. FreeBSD= =20 > > PAE type\n"); > > printf("kernels does not support loadable modules which use DMA.= =20 > > Please\n"); > > printf("reconfigure your kernel for non-PAE or switch to amd64= =20 > > kernel.\n"); > > return EFAULT; > > } > > } > > <<< >=20 > Hmmm, even this isn't really accurate as some folks may choose to enable = PAE > even with < 4GB to get PG_NX functionality. > =20 > > afaik there's a sysctl method of checking this per BSD7 (or is it 8?),= =20 > > but what about BSD6? Any hints on how I can runtime detect the above? >=20 > Definitely a kern.features.pae sysctl in 7. I don't see anything similar= in=20 > 6. =20 Read %cr4 and test the bit there. --eVUvLhJy3aWqIBaz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk3APsoACgkQC3+MBN1Mb4hFawCg0x+eKns4F9qgvH1Rja+R+Gi2 KZgAn0ndc1NnvKZdnycp8UElct80n9bE =ZARE -----END PGP SIGNATURE----- --eVUvLhJy3aWqIBaz-- From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 18:39:14 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E4E90106566C for ; Tue, 3 May 2011 18:39:14 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id BAB788FC1E for ; Tue, 3 May 2011 18:39:14 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 4E90E46B39; Tue, 3 May 2011 14:39:14 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id C6C448A02B; Tue, 3 May 2011 14:39:13 -0400 (EDT) From: John Baldwin To: Kostik Belousov Date: Tue, 3 May 2011 14:25:12 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <4DBFFEC2.4010506@soeberg.net> <201105031144.32862.jhb@freebsd.org> <20110503174339.GI48734@deviant.kiev.zoral.com.ua> In-Reply-To: <20110503174339.GI48734@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201105031425.12710.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 03 May 2011 14:39:13 -0400 (EDT) Cc: freebsd-hackers@freebsd.org, philip-freebsd1@soeberg.net Subject: Re: Runtime check for PAE option on BSD 6+ i386 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 18:39:15 -0000 On Tuesday, May 03, 2011 1:43:39 pm Kostik Belousov wrote: > On Tue, May 03, 2011 at 11:44:32AM -0400, John Baldwin wrote: > > On Tuesday, May 03, 2011 9:10:26 am Philip Soeberg wrote: > > > Hi fellow FreeBSD hackers, > > > > > > I've been using the following poor-man's approach in my driver init for > > > ages in an attempt at detecting PAE option on BSD 6 (or greater) i386 > > > kernels, as I depend on dmabus(9) but provide a loadable kernel module only. > > > > > > >>> > > > if (sizeof(void*) == 4) { > > > if (((uint64_t)(cnt.v_page_count * cnt.v_page_size) / 1073741824) > > > >= 4) { > > > printf("FreeBSD i386 detected with PAE option enabled. FreeBSD > > > PAE type\n"); > > > printf("kernels does not support loadable modules which use DMA. > > > Please\n"); > > > printf("reconfigure your kernel for non-PAE or switch to amd64 > > > kernel.\n"); > > > return EFAULT; > > > } > > > } > > > <<< > > > > Hmmm, even this isn't really accurate as some folks may choose to enable PAE > > even with < 4GB to get PG_NX functionality. > > > > > afaik there's a sysctl method of checking this per BSD7 (or is it 8?), > > > but what about BSD6? Any hints on how I can runtime detect the above? > > > > Definitely a kern.features.pae sysctl in 7. I don't see anything similar in > > 6. > > Read %cr4 and test the bit there. Oh, cute. :) -- John Baldwin From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 18:57:27 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7042106564A; Tue, 3 May 2011 18:57:27 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id 6D44B8FC1A; Tue, 3 May 2011 18:57:27 +0000 (UTC) Received: from SBHFISLREXT03 ([10.132.254.62]) by SCSFISLTC01 (8.14.3/8.14.3) with ESMTP id p43IvQuI007565; Tue, 3 May 2011 13:57:26 -0500 Received: from SBHFISLTCGW04.FNFIS.COM (Not Verified[10.132.248.123]) by SBHFISLREXT03 with MailMarshal (v6, 5, 4, 7535) id ; Tue, 03 May 2011 13:57:29 -0500 Received: from sbhfisltcgw01.FNFIS.COM ([10.132.248.121]) by SBHFISLTCGW04.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Tue, 3 May 2011 13:57:26 -0500 Received: from dtwin ([10.132.254.136]) by sbhfisltcgw01.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 3 May 2011 13:57:25 -0500 From: "Devin Teske" To: References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <201105030745.04486.jhb@freebsd.org> <201105031332.41827.jhb@freebsd.org> In-Reply-To: Date: Tue, 3 May 2011 11:57:34 -0700 Organization: Vicor, Inc. Message-ID: <004501cc09c3$f740e600$e5c2b200$@vicor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQDgmRfeLsy4wLEIiFlDotMJ0wufHwKhERazAJnGNIUBqVT2gAIX6gO6lhpztfA= Content-Language: en-us X-OriginalArrivalTime: 03 May 2011 18:57:25.0980 (UTC) FILETIME=[F16061C0:01CC09C3] Cc: Subject: RE: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 18:57:27 -0000 > From: John Baldwin [mailto:jhb@freebsd.org] > Sent: Tuesday, May 03, 2011 10:33 AM > To: Devin Teske > Cc: freebsd-hackers@freebsd.org; Olivier SMEDTS > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > On Tuesday, May 03, 2011 12:31:14 pm Devin Teske wrote: > > > > On May 3, 2011, at 4:45 AM, John Baldwin wrote: > > > > > On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: > > > > This version (1.1) works nearly identically to the standard menu > > > > that ships with FreeBSD in that it detects whether ACPI is > > > > enabled (truth be told, I actually re-used the "acpienabled?" > > > > function verbatim from /boot/beastie.4th by Scott Long and > > > > Aleksander Fafula). The ACPI detection of my boot loader (version > > > > 1.1 or higher) should be identical to the detection of the current > > > > boot-loader. > > > > Ugh. By "current", I meant 8.1-RELEASE (wasn't expecting this stuff > > to be different in HEAD, which it is). > > > > > > > Err, note that the acpienabled stuff is all different in HEAD than > > > in 7/8 since acpi.ko no longer exists. You should use the scheme > > > from HEAD for handling ACPI present vs ACPI enabled/disabled. > > > > > > -- > > > John Baldwin > > > > > > Ok, I see the new "acpipresent?" word (which replaces the "arch-i386" > > environment-test). Does this imply that we're going to support ACPI on > > non-i386 platforms (or already do)? > > amd64 and ia64 have always supported ACPI. ia64 effectively requires it. > However, "hint.acpi.0.rsdp" is set by biosacpi.c in the i386 loader > bits, so other platforms will not set it, so the arch-i386 test is no longer needed. If "hint.acpi.0.rsdp" is only set in the i386 pieces, wouldn't that imply that the "acpipresent?" would return FALSE on IA64? > > I also see the rewritten "acpienabled?" word. Nice. I'll slurp it in > > to make my ACPI detection the same as HEAD. > > > > I also performed some backward compatibility tests. Looks like this > > will be backward compatible with 8.1-RELEASE (loader_version == 11). > > However, the code in HEAD appears to not work in 8.0-RELEASE > > (loader_version == 8). > > Hmm, which part does not work in 8.0? arch-i386 has existed since at > least 4.x I thought, and the ACPI bits have been setting > hint.acpi.0.rsdp since 7.0 (sys/boot/i386/libi386/biosacpi.c CVS rev 1.12 added it). > > -- > John Baldwin I've got this 8.0-STABLE box. I don't know exactly when it was installed, but /boot/loader has a timestamp from June 2010 and when I execute: s" loader_version" environment? drop . I get "8", whereas when I boot the same exact hardware with 8.1-RELEASE, I get "11". When I boot 8.0-STABLE (loader_version 8), I do not have "hint.acpi.0.rsdp" whereas if I boot 8.1-RELEASE (loader_version 11), I do get "hint.acpi.0.rsdp". (NOTE: this is on the exact same hardware, without changing any BIOS settings between boots). Is it possible that my 8.0-STABLE has a loader that is older than 7.0-RELEASE? I'm trying to figure out why this 8.0-STABLE box is not setting hint.acpi.0.rsdp. -- Cheers, Devin Teske -> FUN STUFF <- -----BEGIN GEEK CODE BLOCK----- Version 3.12 GAT/CS/B/CC/E/IT/MC/M/MU/P/S/TW d+(++) s: a- C+++@$ UB++++$ P++++@$ L++++$ E- W+++ N? o? K? w@ O M++$ V- PS+>++ PE@ Y+ PGP-> t(+) 5? X(+) R(-) tv+ W+++ b+>++ DI+ D+(++) G++ e>++++ h r+++ z+++ ------END GEEK CODE BLOCK------ Learn about the "Geek Code": http://www.geekcode.com/ -> LEGAL DISCLAIMER <- This message contains confidential and proprietary information of the sender, and is intended only for the person(s) to whom it is addressed. Any use, distribution, copying or disclosure by any other person is strictly prohibited. If you have received this message in error, please notify the e-mail sender immediately, and delete the original message without making a copy. -> END TRANSMISSION <- _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 19:19:41 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C68B9106564A for ; Tue, 3 May 2011 19:19:41 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 846BE8FC16 for ; Tue, 3 May 2011 19:19:41 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 1B50246B09; Tue, 3 May 2011 15:19:41 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id ACC808A01B; Tue, 3 May 2011 15:19:40 -0400 (EDT) From: John Baldwin To: "Devin Teske" Date: Tue, 3 May 2011 15:19:40 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <201105031332.41827.jhb@freebsd.org> <004501cc09c3$f740e600$e5c2b200$@vicor.com> In-Reply-To: <004501cc09c3$f740e600$e5c2b200$@vicor.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105031519.40087.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 03 May 2011 15:19:40 -0400 (EDT) Cc: freebsd-hackers@freebsd.org Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 19:19:41 -0000 On Tuesday, May 03, 2011 2:57:34 pm Devin Teske wrote: > > From: John Baldwin [mailto:jhb@freebsd.org] > > Sent: Tuesday, May 03, 2011 10:33 AM > > To: Devin Teske > > Cc: freebsd-hackers@freebsd.org; Olivier SMEDTS > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > On Tuesday, May 03, 2011 12:31:14 pm Devin Teske wrote: > > > > > > On May 3, 2011, at 4:45 AM, John Baldwin wrote: > > > > > > > On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: > > > > > This version (1.1) works nearly identically to the standard menu > > > > > that ships with FreeBSD in that it detects whether ACPI is > > > > > enabled (truth be told, I actually re-used the "acpienabled?" > > > > > function verbatim from /boot/beastie.4th by Scott Long and > > > > > Aleksander Fafula). The ACPI detection of my boot loader (version > > > > > 1.1 or higher) should be identical to the detection of the current > > > > > boot-loader. > > > > > > Ugh. By "current", I meant 8.1-RELEASE (wasn't expecting this stuff > > > to be different in HEAD, which it is). > > > > > > > > > > Err, note that the acpienabled stuff is all different in HEAD than > > > > in 7/8 since acpi.ko no longer exists. You should use the scheme > > > > from HEAD for handling ACPI present vs ACPI enabled/disabled. > > > > > > > > -- > > > > John Baldwin > > > > > > > > > Ok, I see the new "acpipresent?" word (which replaces the "arch-i386" > > > environment-test). Does this imply that we're going to support ACPI on > > > non-i386 platforms (or already do)? > > > > amd64 and ia64 have always supported ACPI. ia64 effectively requires it. > > However, "hint.acpi.0.rsdp" is set by biosacpi.c in the i386 loader > > bits, so other platforms will not set it, so the arch-i386 test is no longer > needed. > > If "hint.acpi.0.rsdp" is only set in the i386 pieces, wouldn't that imply that > the > "acpipresent?" would return FALSE on IA64? Yes. Right now the ACPI menu item is not displayed on ia64 and it never has been. You can't actually boot IA64 with ACPI disabled, so there's no reason for it to be in the menu. > > > I also see the rewritten "acpienabled?" word. Nice. I'll slurp it in > > > to make my ACPI detection the same as HEAD. > > > > > > I also performed some backward compatibility tests. Looks like this > > > will be backward compatible with 8.1-RELEASE (loader_version == 11). > > > However, the code in HEAD appears to not work in 8.0-RELEASE > > > (loader_version == 8). > > > > Hmm, which part does not work in 8.0? arch-i386 has existed since at > > least 4.x I thought, and the ACPI bits have been setting > > hint.acpi.0.rsdp since 7.0 (sys/boot/i386/libi386/biosacpi.c CVS rev 1.12 > added it). > > > > -- > > John Baldwin > > I've got this 8.0-STABLE box. I don't know exactly when it was installed, but > /boot/loader has a timestamp from June 2010 and when I execute: > > s" loader_version" environment? drop . > > I get "8", whereas when I boot the same exact hardware with 8.1-RELEASE, I get > "11". > > When I boot 8.0-STABLE (loader_version 8), I do not have "hint.acpi.0.rsdp" > whereas if I boot 8.1-RELEASE (loader_version 11), I do get "hint.acpi.0.rsdp". > (NOTE: this is on the exact same hardware, without changing any BIOS settings > between boots). > > Is it possible that my 8.0-STABLE has a loader that is older than 7.0-RELEASE? > I'm > trying to figure out why this 8.0-STABLE box is not setting hint.acpi.0.rsdp. What is the output of 'kenv | grep acpi' from your old loader? Hmm, sys/boot/i386/loader/version was bumped to 1.1 in 5.0 release. It was bumped to 1.0 in 5.0-CURRENT. It was last 0.8 (so "8") in 4.x. -- John Baldwin From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 20:18:16 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E0DF21065670; Tue, 3 May 2011 20:18:16 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id A7E9F8FC14; Tue, 3 May 2011 20:18:16 +0000 (UTC) Received: from SBHFISLREXT03 ([10.132.254.62]) by SCSFISLTC02 (8.14.3/8.14.3) with ESMTP id p43KIF2A011783; Tue, 3 May 2011 15:18:15 -0500 Received: from SBHFISLTCGW04.FNFIS.COM (Not Verified[10.132.248.123]) by SBHFISLREXT03 with MailMarshal (v6, 5, 4, 7535) id ; Tue, 03 May 2011 15:18:19 -0500 Received: from SBHFISLTCGW04.FNFIS.COM ([10.132.248.123]) by SBHFISLTCGW04.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Tue, 3 May 2011 15:18:15 -0500 Received: from dtwin ([10.132.254.136]) by SBHFISLTCGW04.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 3 May 2011 15:18:14 -0500 From: "Devin Teske" To: References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <201105031332.41827.jhb@freebsd.org> <004501cc09c3$f740e600$e5c2b200$@vicor.com> <201105031519.40087.jhb@freebsd.org> In-Reply-To: <201105031519.40087.jhb@freebsd.org> Date: Tue, 3 May 2011 13:17:23 -0700 Organization: Vicor, Inc. Message-ID: <004901cc09cf$1da33fe0$58e9bfa0$@vicor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQDgmRfeLsy4wLEIiFlDotMJ0wufHwGpVPaAAfZY3/oBSN6oTJYrHiWg Content-Language: en-us X-OriginalArrivalTime: 03 May 2011 20:18:15.0106 (UTC) FILETIME=[3BAE4A20:01CC09CF] Cc: Subject: RE: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 20:18:17 -0000 > -----Original Message----- > From: John Baldwin [mailto:jhb@freebsd.org] > Sent: Tuesday, May 03, 2011 12:20 PM > To: Devin Teske > Cc: freebsd-hackers@freebsd.org > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > On Tuesday, May 03, 2011 2:57:34 pm Devin Teske wrote: > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > Sent: Tuesday, May 03, 2011 10:33 AM > > > To: Devin Teske > > > Cc: freebsd-hackers@freebsd.org; Olivier SMEDTS > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > On Tuesday, May 03, 2011 12:31:14 pm Devin Teske wrote: > > > > > > > > On May 3, 2011, at 4:45 AM, John Baldwin wrote: > > > > > > > > > On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: > > > > > > This version (1.1) works nearly identically to the standard > > > > > > menu that ships with FreeBSD in that it detects whether ACPI > > > > > > is enabled (truth be told, I actually re-used the "acpienabled?" > > > > > > function verbatim from /boot/beastie.4th by Scott Long and > > > > > > Aleksander Fafula). The ACPI detection of my boot loader > > > > > > (version > > > > > > 1.1 or higher) should be identical to the detection of the > > > > > > current boot-loader. > > > > > > > > Ugh. By "current", I meant 8.1-RELEASE (wasn't expecting this > > > > stuff to be different in HEAD, which it is). > > > > > > > > > > > > > Err, note that the acpienabled stuff is all different in HEAD > > > > > than in 7/8 since acpi.ko no longer exists. You should use the > > > > > scheme from HEAD for handling ACPI present vs ACPI enabled/disabled. > > > > > > > > > > -- > > > > > John Baldwin > > > > > > > > > > > > Ok, I see the new "acpipresent?" word (which replaces the "arch-i386" > > > > environment-test). Does this imply that we're going to support > > > > ACPI on > > > > non-i386 platforms (or already do)? > > > > > > amd64 and ia64 have always supported ACPI. ia64 effectively requires it. > > > However, "hint.acpi.0.rsdp" is set by biosacpi.c in the i386 loader > > > bits, so other platforms will not set it, so the arch-i386 test is > > > no longer > > needed. > > > > If "hint.acpi.0.rsdp" is only set in the i386 pieces, wouldn't that > > imply that the "acpipresent?" would return FALSE on IA64? > > Yes. Right now the ACPI menu item is not displayed on ia64 and it never has > been. You can't actually boot IA64 with ACPI disabled, so there's no reason for it > to be in the menu. This raises a concern for my menu. Unlike the current menu, which blanks-out menuitem #2 for IA64, I've chosen instead to insert an inoperative menuitem with the text "ACPI Support: N/A". What do you think would be an appropriate stand-in? Perhaps "ACPI Support: Enabled" (simply assume that it's enabled and do nothing if the user attempts to disable it) or "ACPI Support:" with no text (or maybe what I've got right now -- "ACPI Support: N/A" -- is already acceptable)? > > > > > I also see the rewritten "acpienabled?" word. Nice. I'll slurp it > > > > in to make my ACPI detection the same as HEAD. > > > > > > > > I also performed some backward compatibility tests. Looks like > > > > this will be backward compatible with 8.1-RELEASE (loader_version == 11). > > > > However, the code in HEAD appears to not work in 8.0-RELEASE > > > > (loader_version == 8). > > > > > > Hmm, which part does not work in 8.0? arch-i386 has existed since > > > at least 4.x I thought, and the ACPI bits have been setting > > > hint.acpi.0.rsdp since 7.0 (sys/boot/i386/libi386/biosacpi.c CVS rev > > > 1.12 > > added it). > > > > > > -- > > > John Baldwin > > > > I've got this 8.0-STABLE box. I don't know exactly when it was > > installed, but /boot/loader has a timestamp from June 2010 and when I > execute: > > > > s" loader_version" environment? drop . > > > > I get "8", whereas when I boot the same exact hardware with > > 8.1-RELEASE, I get "11". > > > > When I boot 8.0-STABLE (loader_version 8), I do not have "hint.acpi.0.rsdp" > > whereas if I boot 8.1-RELEASE (loader_version 11), I do get "hint.acpi.0.rsdp". > > (NOTE: this is on the exact same hardware, without changing any BIOS > > settings between boots). > > > > Is it possible that my 8.0-STABLE has a loader that is older than 7.0-RELEASE? > > I'm > > trying to figure out why this 8.0-STABLE box is not setting hint.acpi.0.rsdp. > > What is the output of 'kenv | grep acpi' from your old loader? > > Hmm, sys/boot/i386/loader/version was bumped to 1.1 in 5.0 release. It was > bumped to 1.0 in 5.0-CURRENT. It was last 0.8 (so "8") in 4.x. D'OH! Someone had slapped a 4.9.1 hard disk into this 8.0-STABLE box without me knowing. Turns out I was booting from the 4.9.1 disk and hence why the old loader. Thanks for helping me figure that one out. Back to the topic of backward compatibility. As it stands, it would seem that the new "acpipresent?" will not produce expected results on releases older than 7.0 (since hint.acpi.0.rsdp is not set in 6.x or older). The result would be that if used on FreeBSD 6.x or older, that the boot menu would always blank-out the ACPI option. This is not an issue for the FreeBSD release engineers, but for my package -- which might potentially be added to a FreeBSD-6 box -- in which case ACPI will not detect properly. So, I'm in a quandary over the new "acpipresent?". If I take it as-is, I'll have to warn downloaders that ACPI won't be detected properly on 6.x or older. However, if I modify it, then my code cannot be committed to CVS without modification (that is to say, that if/when this makes it to the base, that backward compatibility might need to be removed). So what do you think I should do? a. Rewrite both "acpipresent?" and "acpienabled?" to be backward compatible with 6.x/older or b. embrace the future and simply warn about backward compatibility (or lack thereof) with respect to ACPI support. NOTE: Route (a) may not be possible unless the loader_version was bumped at the same time that hint.acpi.0.rsdp was added. Thoughts? -- Devin _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 20:35:53 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1EAB1106564A for ; Tue, 3 May 2011 20:35:53 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D2AFE8FC15 for ; Tue, 3 May 2011 20:35:52 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 58F8E46B58; Tue, 3 May 2011 16:35:52 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id EAF538A01B; Tue, 3 May 2011 16:35:51 -0400 (EDT) From: John Baldwin To: "Devin Teske" Date: Tue, 3 May 2011 16:35:51 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <201105031519.40087.jhb@freebsd.org> <004901cc09cf$1da33fe0$58e9bfa0$@vicor.com> In-Reply-To: <004901cc09cf$1da33fe0$58e9bfa0$@vicor.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105031635.51247.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 03 May 2011 16:35:52 -0400 (EDT) Cc: freebsd-hackers@freebsd.org Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 20:35:53 -0000 On Tuesday, May 03, 2011 4:17:23 pm Devin Teske wrote: > > -----Original Message----- > > From: John Baldwin [mailto:jhb@freebsd.org] > > Sent: Tuesday, May 03, 2011 12:20 PM > > To: Devin Teske > > Cc: freebsd-hackers@freebsd.org > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > On Tuesday, May 03, 2011 2:57:34 pm Devin Teske wrote: > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > Sent: Tuesday, May 03, 2011 10:33 AM > > > > To: Devin Teske > > > > Cc: freebsd-hackers@freebsd.org; Olivier SMEDTS > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > On Tuesday, May 03, 2011 12:31:14 pm Devin Teske wrote: > > > > > > > > > > On May 3, 2011, at 4:45 AM, John Baldwin wrote: > > > > > > > > > > > On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: > > > > > > > This version (1.1) works nearly identically to the standard > > > > > > > menu that ships with FreeBSD in that it detects whether ACPI > > > > > > > is enabled (truth be told, I actually re-used the "acpienabled?" > > > > > > > function verbatim from /boot/beastie.4th by Scott Long and > > > > > > > Aleksander Fafula). The ACPI detection of my boot loader > > > > > > > (version > > > > > > > 1.1 or higher) should be identical to the detection of the > > > > > > > current boot-loader. > > > > > > > > > > Ugh. By "current", I meant 8.1-RELEASE (wasn't expecting this > > > > > stuff to be different in HEAD, which it is). > > > > > > > > > > > > > > > > Err, note that the acpienabled stuff is all different in HEAD > > > > > > than in 7/8 since acpi.ko no longer exists. You should use the > > > > > > scheme from HEAD for handling ACPI present vs ACPI enabled/disabled. > > > > > > > > > > > > -- > > > > > > John Baldwin > > > > > > > > > > > > > > > Ok, I see the new "acpipresent?" word (which replaces the "arch-i386" > > > > > environment-test). Does this imply that we're going to support > > > > > ACPI on > > > > > non-i386 platforms (or already do)? > > > > > > > > amd64 and ia64 have always supported ACPI. ia64 effectively requires it. > > > > However, "hint.acpi.0.rsdp" is set by biosacpi.c in the i386 loader > > > > bits, so other platforms will not set it, so the arch-i386 test is > > > > no longer > > > needed. > > > > > > If "hint.acpi.0.rsdp" is only set in the i386 pieces, wouldn't that > > > imply that the "acpipresent?" would return FALSE on IA64? > > > > Yes. Right now the ACPI menu item is not displayed on ia64 and it never has > > been. You can't actually boot IA64 with ACPI disabled, so there's no reason > for it > > to be in the menu. > > This raises a concern for my menu. Unlike the current menu, which blanks-out > menuitem #2 for IA64, I've chosen instead to insert an inoperative menuitem with > the text "ACPI Support: N/A". Hmm, I think you should just leave the menu item blank or not listed. It doesn't make sense to see a knob about ACPI support on a ppc box for example, and other platforms may grow platform-specific knobs in the future as well. The current menu item is only blank as a hack to avoid renumbering the items. If you are already changing that around, then I'd just leave it out altogether unless ACPI is detected by the loader. > So what do you think I should do? > > a. Rewrite both "acpipresent?" and "acpienabled?" to be backward compatible with > 6.x/older or > b. embrace the future and simply warn about backward compatibility (or lack > thereof) with respect to ACPI support. > > NOTE: Route (a) may not be possible unless the loader_version was bumped at the > same time that hint.acpi.0.rsdp was added. (a) is not possible for the reason you mention. I wouldn't worry about supporting 6.x at this point, esp. if it is going to be a pain. -- John Baldwin From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 20:48:21 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 772FB106566B; Tue, 3 May 2011 20:48:21 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id 3E8ED8FC15; Tue, 3 May 2011 20:48:20 +0000 (UTC) Received: from sbhfislrext01.fnfis.com ([192.168.249.167]) by SCSFISLTC01 (8.14.3/8.14.3) with ESMTP id p43KmI9V021138; Tue, 3 May 2011 15:48:20 -0500 Received: from SBHFISLTCGW04.FNFIS.COM (Not Verified[10.132.248.123]) by sbhfislrext01.fnfis.com with MailMarshal (v6, 5, 4, 7535) id ; Tue, 03 May 2011 15:48:19 -0500 Received: from SBHFISLTCGW07.FNFIS.COM ([10.132.248.135]) by SBHFISLTCGW04.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Tue, 3 May 2011 15:48:18 -0500 Received: from dtwin ([10.132.254.136]) by SBHFISLTCGW07.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 3 May 2011 15:48:17 -0500 From: "Devin Teske" To: "'John Baldwin'" References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <201105031519.40087.jhb@freebsd.org> <004901cc09cf$1da33fe0$58e9bfa0$@vicor.com> <201105031635.51247.jhb@freebsd.org> In-Reply-To: <201105031635.51247.jhb@freebsd.org> Date: Tue, 3 May 2011 13:47:26 -0700 Organization: Vicor, Inc. Message-ID: <006201cc09d3$5037b7c0$f0a72740$@vicor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQDgmRfeLsy4wLEIiFlDotMJ0wufHwFI3qhMArno/PABoVXe+ZYlURCg Content-Language: en-us X-OriginalArrivalTime: 03 May 2011 20:48:17.0789 (UTC) FILETIME=[6E29E2D0:01CC09D3] Cc: freebsd-hackers@freebsd.org Subject: RE: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 20:48:21 -0000 > -----Original Message----- > From: John Baldwin [mailto:jhb@freebsd.org] > Sent: Tuesday, May 03, 2011 1:36 PM > To: Devin Teske > Cc: freebsd-hackers@freebsd.org > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > On Tuesday, May 03, 2011 4:17:23 pm Devin Teske wrote: > > > -----Original Message----- > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > Sent: Tuesday, May 03, 2011 12:20 PM > > > To: Devin Teske > > > Cc: freebsd-hackers@freebsd.org > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > On Tuesday, May 03, 2011 2:57:34 pm Devin Teske wrote: > > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > > Sent: Tuesday, May 03, 2011 10:33 AM > > > > > To: Devin Teske > > > > > Cc: freebsd-hackers@freebsd.org; Olivier SMEDTS > > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > > > On Tuesday, May 03, 2011 12:31:14 pm Devin Teske wrote: > > > > > > > > > > > > On May 3, 2011, at 4:45 AM, John Baldwin wrote: > > > > > > > > > > > > > On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: > > > > > > > > This version (1.1) works nearly identically to the > > > > > > > > standard menu that ships with FreeBSD in that it detects > > > > > > > > whether ACPI is enabled (truth be told, I actually re-used the > "acpienabled?" > > > > > > > > function verbatim from /boot/beastie.4th by Scott Long and > > > > > > > > Aleksander Fafula). The ACPI detection of my boot loader > > > > > > > > (version > > > > > > > > 1.1 or higher) should be identical to the detection of the > > > > > > > > current boot-loader. > > > > > > > > > > > > Ugh. By "current", I meant 8.1-RELEASE (wasn't expecting this > > > > > > stuff to be different in HEAD, which it is). > > > > > > > > > > > > > > > > > > > Err, note that the acpienabled stuff is all different in > > > > > > > HEAD than in 7/8 since acpi.ko no longer exists. You should > > > > > > > use the scheme from HEAD for handling ACPI present vs ACPI > enabled/disabled. > > > > > > > > > > > > > > -- > > > > > > > John Baldwin > > > > > > > > > > > > > > > > > > Ok, I see the new "acpipresent?" word (which replaces the "arch-i386" > > > > > > environment-test). Does this imply that we're going to support > > > > > > ACPI on > > > > > > non-i386 platforms (or already do)? > > > > > > > > > > amd64 and ia64 have always supported ACPI. ia64 effectively requires it. > > > > > However, "hint.acpi.0.rsdp" is set by biosacpi.c in the i386 > > > > > loader bits, so other platforms will not set it, so the > > > > > arch-i386 test is no longer > > > > needed. > > > > > > > > If "hint.acpi.0.rsdp" is only set in the i386 pieces, wouldn't > > > > that imply that the "acpipresent?" would return FALSE on IA64? > > > > > > Yes. Right now the ACPI menu item is not displayed on ia64 and it > > > never has been. You can't actually boot IA64 with ACPI disabled, so > > > there's no reason > > for it > > > to be in the menu. > > > > This raises a concern for my menu. Unlike the current menu, which > > blanks-out menuitem #2 for IA64, I've chosen instead to insert an > > inoperative menuitem with the text "ACPI Support: N/A". > > Hmm, I think you should just leave the menu item blank or not listed. It doesn't > make sense to see a knob about ACPI support on a ppc box for example, and > other platforms may grow platform-specific knobs in the future as well. > > The current menu item is only blank as a hack to avoid renumbering the items. > If you are already changing that around, then I'd just leave it out altogether > unless ACPI is detected by the loader. > I too avoid renumbering of the items. Having never actually booted a PPC or IA64 FreeBSD installation... is it the case that the numbers displayed jump from 1 to 3 (no blank line in-between 1 and 3, correct)? I think that sounds like the sensible thing to do. -- Devin _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 21:01:28 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8FE71106564A for ; Tue, 3 May 2011 21:01:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 501508FC14 for ; Tue, 3 May 2011 21:01:28 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id D850B46B59; Tue, 3 May 2011 17:01:27 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 5FF858A02A; Tue, 3 May 2011 17:01:27 -0400 (EDT) From: John Baldwin To: "Devin Teske" Date: Tue, 3 May 2011 17:01:25 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <201105031635.51247.jhb@freebsd.org> <006201cc09d3$5037b7c0$f0a72740$@vicor.com> In-Reply-To: <006201cc09d3$5037b7c0$f0a72740$@vicor.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105031701.25774.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 03 May 2011 17:01:27 -0400 (EDT) Cc: freebsd-hackers@freebsd.org Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 21:01:28 -0000 On Tuesday, May 03, 2011 4:47:26 pm Devin Teske wrote: > > -----Original Message----- > > From: John Baldwin [mailto:jhb@freebsd.org] > > Sent: Tuesday, May 03, 2011 1:36 PM > > To: Devin Teske > > Cc: freebsd-hackers@freebsd.org > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > On Tuesday, May 03, 2011 4:17:23 pm Devin Teske wrote: > > > > -----Original Message----- > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > Sent: Tuesday, May 03, 2011 12:20 PM > > > > To: Devin Teske > > > > Cc: freebsd-hackers@freebsd.org > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > On Tuesday, May 03, 2011 2:57:34 pm Devin Teske wrote: > > > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > > > Sent: Tuesday, May 03, 2011 10:33 AM > > > > > > To: Devin Teske > > > > > > Cc: freebsd-hackers@freebsd.org; Olivier SMEDTS > > > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > > > > > On Tuesday, May 03, 2011 12:31:14 pm Devin Teske wrote: > > > > > > > > > > > > > > On May 3, 2011, at 4:45 AM, John Baldwin wrote: > > > > > > > > > > > > > > > On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: > > > > > > > > > This version (1.1) works nearly identically to the > > > > > > > > > standard menu that ships with FreeBSD in that it detects > > > > > > > > > whether ACPI is enabled (truth be told, I actually re-used the > > "acpienabled?" > > > > > > > > > function verbatim from /boot/beastie.4th by Scott Long and > > > > > > > > > Aleksander Fafula). The ACPI detection of my boot loader > > > > > > > > > (version > > > > > > > > > 1.1 or higher) should be identical to the detection of the > > > > > > > > > current boot-loader. > > > > > > > > > > > > > > Ugh. By "current", I meant 8.1-RELEASE (wasn't expecting this > > > > > > > stuff to be different in HEAD, which it is). > > > > > > > > > > > > > > > > > > > > > > Err, note that the acpienabled stuff is all different in > > > > > > > > HEAD than in 7/8 since acpi.ko no longer exists. You should > > > > > > > > use the scheme from HEAD for handling ACPI present vs ACPI > > enabled/disabled. > > > > > > > > > > > > > > > > -- > > > > > > > > John Baldwin > > > > > > > > > > > > > > > > > > > > > Ok, I see the new "acpipresent?" word (which replaces the > "arch-i386" > > > > > > > environment-test). Does this imply that we're going to support > > > > > > > ACPI on > > > > > > > non-i386 platforms (or already do)? > > > > > > > > > > > > amd64 and ia64 have always supported ACPI. ia64 effectively requires > it. > > > > > > However, "hint.acpi.0.rsdp" is set by biosacpi.c in the i386 > > > > > > loader bits, so other platforms will not set it, so the > > > > > > arch-i386 test is no longer > > > > > needed. > > > > > > > > > > If "hint.acpi.0.rsdp" is only set in the i386 pieces, wouldn't > > > > > that imply that the "acpipresent?" would return FALSE on IA64? > > > > > > > > Yes. Right now the ACPI menu item is not displayed on ia64 and it > > > > never has been. You can't actually boot IA64 with ACPI disabled, so > > > > there's no reason > > > for it > > > > to be in the menu. > > > > > > This raises a concern for my menu. Unlike the current menu, which > > > blanks-out menuitem #2 for IA64, I've chosen instead to insert an > > > inoperative menuitem with the text "ACPI Support: N/A". > > > > Hmm, I think you should just leave the menu item blank or not listed. It > doesn't > > make sense to see a knob about ACPI support on a ppc box for example, and > > other platforms may grow platform-specific knobs in the future as well. > > > > The current menu item is only blank as a hack to avoid renumbering the items. > > If you are already changing that around, then I'd just leave it out altogether > > unless ACPI is detected by the loader. > > > > I too avoid renumbering of the items. > > Having never actually booted a PPC or IA64 FreeBSD installation... is it the > case that the numbers displayed jump from 1 to 3 (no blank line in-between 1 and > 3, correct)? Actually, I think PPC/IA64, etc. do not display the ACPI menu item at all and they are numbered differently from i386 and amd64. The ACPI menu item is only blank if ACPI is not present on i386 and amd64. -- John Baldwin From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 21:23:13 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE983106566C; Tue, 3 May 2011 21:23:13 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id B64008FC14; Tue, 3 May 2011 21:23:13 +0000 (UTC) Received: from sbhfislrext02.fnfis.com ([192.168.249.140]) by SCSFISLTC02 (8.14.3/8.14.3) with ESMTP id p43LNCWS014754; Tue, 3 May 2011 16:23:12 -0500 Received: from SBHFISLTCGW07.FNFIS.COM (Not Verified[10.132.248.135]) by sbhfislrext02.fnfis.com with MailMarshal (v6, 5, 4, 7535) id ; Tue, 03 May 2011 16:23:14 -0500 Received: from SBHFISLTCGW04.FNFIS.COM ([10.132.248.123]) by SBHFISLTCGW07.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Tue, 3 May 2011 16:23:12 -0500 Received: from dtwin ([10.132.254.136]) by SBHFISLTCGW04.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 3 May 2011 16:23:11 -0500 From: "Devin Teske" To: "'John Baldwin'" References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <201105031635.51247.jhb@freebsd.org> <006201cc09d3$5037b7c0$f0a72740$@vicor.com> <201105031701.25774.jhb@freebsd.org> In-Reply-To: <201105031701.25774.jhb@freebsd.org> Date: Tue, 3 May 2011 14:22:20 -0700 Organization: Vicor, Inc. Message-ID: <006401cc09d8$30974e30$91c5ea90$@vicor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQDgmRfeLsy4wLEIiFlDotMJ0wufHwGhVd75AeML+jYA4YiHsJYvTB+g Content-Language: en-us X-OriginalArrivalTime: 03 May 2011 21:23:12.0199 (UTC) FILETIME=[4E877D70:01CC09D8] Cc: freebsd-hackers@freebsd.org Subject: RE: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 21:23:14 -0000 > -----Original Message----- > From: John Baldwin [mailto:jhb@freebsd.org] > Sent: Tuesday, May 03, 2011 2:01 PM > To: Devin Teske > Cc: freebsd-hackers@freebsd.org > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > On Tuesday, May 03, 2011 4:47:26 pm Devin Teske wrote: > > > -----Original Message----- > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > Sent: Tuesday, May 03, 2011 1:36 PM > > > To: Devin Teske > > > Cc: freebsd-hackers@freebsd.org > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > On Tuesday, May 03, 2011 4:17:23 pm Devin Teske wrote: > > > > > -----Original Message----- > > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > > Sent: Tuesday, May 03, 2011 12:20 PM > > > > > To: Devin Teske > > > > > Cc: freebsd-hackers@freebsd.org > > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > > > On Tuesday, May 03, 2011 2:57:34 pm Devin Teske wrote: > > > > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > > > > Sent: Tuesday, May 03, 2011 10:33 AM > > > > > > > To: Devin Teske > > > > > > > Cc: freebsd-hackers@freebsd.org; Olivier SMEDTS > > > > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > > > > > > > On Tuesday, May 03, 2011 12:31:14 pm Devin Teske wrote: > > > > > > > > > > > > > > > > On May 3, 2011, at 4:45 AM, John Baldwin wrote: > > > > > > > > > > > > > > > > > On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: > > > > > > > > > > This version (1.1) works nearly identically to the > > > > > > > > > > standard menu that ships with FreeBSD in that it > > > > > > > > > > detects whether ACPI is enabled (truth be told, I > > > > > > > > > > actually re-used the > > > "acpienabled?" > > > > > > > > > > function verbatim from /boot/beastie.4th by Scott Long > > > > > > > > > > and Aleksander Fafula). The ACPI detection of my boot > > > > > > > > > > loader (version > > > > > > > > > > 1.1 or higher) should be identical to the detection of > > > > > > > > > > the current boot-loader. > > > > > > > > > > > > > > > > Ugh. By "current", I meant 8.1-RELEASE (wasn't expecting > > > > > > > > this stuff to be different in HEAD, which it is). > > > > > > > > > > > > > > > > > > > > > > > > > Err, note that the acpienabled stuff is all different in > > > > > > > > > HEAD than in 7/8 since acpi.ko no longer exists. You > > > > > > > > > should use the scheme from HEAD for handling ACPI > > > > > > > > > present vs ACPI > > > enabled/disabled. > > > > > > > > > > > > > > > > > > -- > > > > > > > > > John Baldwin > > > > > > > > > > > > > > > > > > > > > > > > Ok, I see the new "acpipresent?" word (which replaces the > > "arch-i386" > > > > > > > > environment-test). Does this imply that we're going to > > > > > > > > support ACPI on > > > > > > > > non-i386 platforms (or already do)? > > > > > > > > > > > > > > amd64 and ia64 have always supported ACPI. ia64 effectively > > > > > > > requires > > it. > > > > > > > However, "hint.acpi.0.rsdp" is set by biosacpi.c in the i386 > > > > > > > loader bits, so other platforms will not set it, so the > > > > > > > arch-i386 test is no longer > > > > > > needed. > > > > > > > > > > > > If "hint.acpi.0.rsdp" is only set in the i386 pieces, wouldn't > > > > > > that imply that the "acpipresent?" would return FALSE on IA64? > > > > > > > > > > Yes. Right now the ACPI menu item is not displayed on ia64 and > > > > > it never has been. You can't actually boot IA64 with ACPI > > > > > disabled, so there's no reason > > > > for it > > > > > to be in the menu. > > > > > > > > This raises a concern for my menu. Unlike the current menu, which > > > > blanks-out menuitem #2 for IA64, I've chosen instead to insert an > > > > inoperative menuitem with the text "ACPI Support: N/A". > > > > > > Hmm, I think you should just leave the menu item blank or not > > > listed. It > > doesn't > > > make sense to see a knob about ACPI support on a ppc box for > > > example, and other platforms may grow platform-specific knobs in the future > as well. > > > > > > The current menu item is only blank as a hack to avoid renumbering the > items. > > > If you are already changing that around, then I'd just leave it out > > > altogether unless ACPI is detected by the loader. > > > > > > > I too avoid renumbering of the items. > > > > Having never actually booted a PPC or IA64 FreeBSD installation... is > > it the case that the numbers displayed jump from 1 to 3 (no blank line > > in-between 1 and 3, correct)? > > Actually, I think PPC/IA64, etc. do not display the ACPI menu item at all and they > are numbered differently from i386 and amd64. The ACPI menu item is only > blank if ACPI is not present on i386 and amd64. > You're absolutely right. I looked closer at the Forth in HEAD, and indeed you're right. "arch-i386" will always allocate a #2 to ACPI, but will only display it when "hint.acpi.0.rsdp" is set whereas non-i386 architectures will assign #2 to the next menuitem (Safe Mode). I'll make a new version that mimics this behavior. The overall goal is to: a. Satisfy everbody on -hackers. b. Announce final version on -questions and -announce for broader audience. c. Try to satisfy critical concerns. d. Approach -core about using it in base Think I have a shot at (d)? -- Devin _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Tue May 3 21:36:46 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91F2D1065677 for ; Tue, 3 May 2011 21:36:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 68D2C8FC08 for ; Tue, 3 May 2011 21:36:46 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id DB15746B43; Tue, 3 May 2011 17:36:45 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 767C18A01B; Tue, 3 May 2011 17:36:45 -0400 (EDT) From: John Baldwin To: "Devin Teske" Date: Tue, 3 May 2011 17:31:48 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <9B387DE4-6866-4208-A8FC-6516D651F6A5@vicor.com> <201105031701.25774.jhb@freebsd.org> <006401cc09d8$30974e30$91c5ea90$@vicor.com> In-Reply-To: <006401cc09d8$30974e30$91c5ea90$@vicor.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105031731.49236.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 03 May 2011 17:36:45 -0400 (EDT) Cc: freebsd-hackers@freebsd.org Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2011 21:36:46 -0000 On Tuesday, May 03, 2011 5:22:20 pm Devin Teske wrote: > > -----Original Message----- > > From: John Baldwin [mailto:jhb@freebsd.org] > > Sent: Tuesday, May 03, 2011 2:01 PM > > To: Devin Teske > > Cc: freebsd-hackers@freebsd.org > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > On Tuesday, May 03, 2011 4:47:26 pm Devin Teske wrote: > > > > -----Original Message----- > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > Sent: Tuesday, May 03, 2011 1:36 PM > > > > To: Devin Teske > > > > Cc: freebsd-hackers@freebsd.org > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > On Tuesday, May 03, 2011 4:17:23 pm Devin Teske wrote: > > > > > > -----Original Message----- > > > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > > > Sent: Tuesday, May 03, 2011 12:20 PM > > > > > > To: Devin Teske > > > > > > Cc: freebsd-hackers@freebsd.org > > > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > > > > > On Tuesday, May 03, 2011 2:57:34 pm Devin Teske wrote: > > > > > > > > From: John Baldwin [mailto:jhb@freebsd.org] > > > > > > > > Sent: Tuesday, May 03, 2011 10:33 AM > > > > > > > > To: Devin Teske > > > > > > > > Cc: freebsd-hackers@freebsd.org; Olivier SMEDTS > > > > > > > > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.1 > > > > > > > > > > > > > > > > On Tuesday, May 03, 2011 12:31:14 pm Devin Teske wrote: > > > > > > > > > > > > > > > > > > On May 3, 2011, at 4:45 AM, John Baldwin wrote: > > > > > > > > > > > > > > > > > > > On Monday, May 02, 2011 8:48:31 pm Devin Teske wrote: > > > > > > > > > > > This version (1.1) works nearly identically to the > > > > > > > > > > > standard menu that ships with FreeBSD in that it > > > > > > > > > > > detects whether ACPI is enabled (truth be told, I > > > > > > > > > > > actually re-used the > > > > "acpienabled?" > > > > > > > > > > > function verbatim from /boot/beastie.4th by Scott Long > > > > > > > > > > > and Aleksander Fafula). The ACPI detection of my boot > > > > > > > > > > > loader (version > > > > > > > > > > > 1.1 or higher) should be identical to the detection of > > > > > > > > > > > the current boot-loader. > > > > > > > > > > > > > > > > > > Ugh. By "current", I meant 8.1-RELEASE (wasn't expecting > > > > > > > > > this stuff to be different in HEAD, which it is). > > > > > > > > > > > > > > > > > > > > > > > > > > > > Err, note that the acpienabled stuff is all different in > > > > > > > > > > HEAD than in 7/8 since acpi.ko no longer exists. You > > > > > > > > > > should use the scheme from HEAD for handling ACPI > > > > > > > > > > present vs ACPI > > > > enabled/disabled. > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > John Baldwin > > > > > > > > > > > > > > > > > > > > > > > > > > > Ok, I see the new "acpipresent?" word (which replaces the > > > "arch-i386" > > > > > > > > > environment-test). Does this imply that we're going to > > > > > > > > > support ACPI on > > > > > > > > > non-i386 platforms (or already do)? > > > > > > > > > > > > > > > > amd64 and ia64 have always supported ACPI. ia64 effectively > > > > > > > > requires > > > it. > > > > > > > > However, "hint.acpi.0.rsdp" is set by biosacpi.c in the i386 > > > > > > > > loader bits, so other platforms will not set it, so the > > > > > > > > arch-i386 test is no longer > > > > > > > needed. > > > > > > > > > > > > > > If "hint.acpi.0.rsdp" is only set in the i386 pieces, wouldn't > > > > > > > that imply that the "acpipresent?" would return FALSE on IA64? > > > > > > > > > > > > Yes. Right now the ACPI menu item is not displayed on ia64 and > > > > > > it never has been. You can't actually boot IA64 with ACPI > > > > > > disabled, so there's no reason > > > > > for it > > > > > > to be in the menu. > > > > > > > > > > This raises a concern for my menu. Unlike the current menu, which > > > > > blanks-out menuitem #2 for IA64, I've chosen instead to insert an > > > > > inoperative menuitem with the text "ACPI Support: N/A". > > > > > > > > Hmm, I think you should just leave the menu item blank or not > > > > listed. It > > > doesn't > > > > make sense to see a knob about ACPI support on a ppc box for > > > > example, and other platforms may grow platform-specific knobs in the > future > > as well. > > > > > > > > The current menu item is only blank as a hack to avoid renumbering the > > items. > > > > If you are already changing that around, then I'd just leave it out > > > > altogether unless ACPI is detected by the loader. > > > > > > > > > > I too avoid renumbering of the items. > > > > > > Having never actually booted a PPC or IA64 FreeBSD installation... is > > > it the case that the numbers displayed jump from 1 to 3 (no blank line > > > in-between 1 and 3, correct)? > > > > Actually, I think PPC/IA64, etc. do not display the ACPI menu item at all and > they > > are numbered differently from i386 and amd64. The ACPI menu item is only > > blank if ACPI is not present on i386 and amd64. > > > > You're absolutely right. I looked closer at the Forth in HEAD, and indeed you're > right. > > "arch-i386" will always allocate a #2 to ACPI, but will only display it when > "hint.acpi.0.rsdp" is set whereas non-i386 architectures will assign #2 to the > next menuitem (Safe Mode). > > I'll make a new version that mimics this behavior. > > The overall goal is to: > a. Satisfy everbody on -hackers. > b. Announce final version on -questions and -announce for broader audience. > c. Try to satisfy critical concerns. > d. Approach -core about using it in base > > Think I have a shot at (d)? Well, for (d) you just need to find a committer who is excited about it and wants to get it into the base system. core@ doesn't really do that as core@, per se. -- John Baldwin From owner-freebsd-hackers@FreeBSD.ORG Wed May 4 03:45:56 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8FBA7106566B for ; Wed, 4 May 2011 03:45:56 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 44BFF8FC0A for ; Wed, 4 May 2011 03:45:55 +0000 (UTC) Received: by iyj12 with SMTP id 12so879772iyj.13 for ; Tue, 03 May 2011 20:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:x-openpgp-key-id:x-openpgp-key-fingerprint :x-openpgp-key-url; bh=vT+ejBfkArI3qMgs+h6Ca3NwTVdhzKojQLev1lbs25s=; b=hL+pt1Wi/Pgx2pE5kkWC4dq1W219Kmjp3+yl2UWWshyG2BkJcyK2bHezfi2GnV1iVa SIfMRpzsdKHdB3yEkn59zSo55bc0tkEub48k/sFb/7yWwTrtgmPipj+SGlImt/mKAbA/ 1lAMVYrqHL9/CrpoYoGHFDFVc/5ozGIMI6pFw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-openpgp-key-id :x-openpgp-key-fingerprint:x-openpgp-key-url; b=U+gMNS3Qa7sZqOHTvHicdg7IX9/6QLgphMR9YN0EH9o/hfggeD8MYd8p8wrTCMyeeg 9vgKeR4a53YJnpKUG9VjA9eBM8nGU/z/XxwS/a8hUGCB91LxfC1VMjSi6k4JR7VXrH4/ ITko5qm8uIgulNwiPazlcTraxI54yT1Af9lEQ= Received: by 10.42.146.5 with SMTP id h5mr1095853icv.101.1304480755697; Tue, 03 May 2011 20:45:55 -0700 (PDT) Received: from DataIX.net (adsl-99-190-84-116.dsl.klmzmi.sbcglobal.net [99.190.84.116]) by mx.google.com with ESMTPS id hc41sm286179ibb.64.2011.05.03.20.45.53 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 May 2011 20:45:54 -0700 (PDT) Sender: "J. Hellenthal" Received: from DataIX.net (localhost [127.0.0.1]) by DataIX.net (8.14.4/8.14.4) with ESMTP id p443jo4B017271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 May 2011 23:45:51 -0400 (EDT) (envelope-from jhell@DataIX.net) Received: (from jhell@localhost) by DataIX.net (8.14.4/8.14.4/Submit) id p443joJR017270; Tue, 3 May 2011 23:45:50 -0400 (EDT) (envelope-from jhell@DataIX.net) Date: Tue, 3 May 2011 23:45:49 -0400 From: Jason Hellenthal To: Devin Teske Message-ID: <20110504034549.GB78390@DataIX.net> References: <6955841F-C3C1-4C7D-8BA4-F8EBBF60F69B@vicor.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s/l3CgOIzMHHjg/5" Content-Disposition: inline In-Reply-To: <6955841F-C3C1-4C7D-8BA4-F8EBBF60F69B@vicor.com> X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E X-OpenPGP-Key-URL: http://bit.ly/0x89D8547E Cc: Olivier SMEDTS , FreeBSD Hackers Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.3 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2011 03:45:56 -0000 --s/l3CgOIzMHHjg/5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Devin, On Mon, May 02, 2011 at 08:57:05PM -0700, Devin Teske wrote: [...] > >loader_brand=3D"..." > > Selects the BSD brand to display. Valid values are "fbsd" (displays > "FreeBSD") and "dbsd" (displays "DruidBSD"). An invalid value (such as > "none") will disable the display of any brand. The brand is displayed > above the dynamic menu. The default is "fbsd". > [...] Speaking directly toward one of the many other version announcements where= =20 you mentioned approaching -core@ in delta D). I can't see DruidBSD making= =20 it into the tree. You might want to do some work to separate that for your= =20 own personal use. Replacing it with "PC-BSD" on the other hand or allowing= =20 user supplied text to just be there without all the checking is another=20 option. --=20 Regards, (jhell) Jason Hellenthal --s/l3CgOIzMHHjg/5 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) Comment: http://bit.ly/0x89D8547E iQEcBAEBAgAGBQJNwMvtAAoJEJBXh4mJ2FR+VKwH/1jLXZLoZra5Ud7tNKMSoL16 Wl/reckL7IR6sM4+vQWgPZW4OFeZ5vcM5Y1W4WRV7oVKS9xV7+5AfkFOD3kx5Rde W3ohLY6VYEtxHOue55xyabsSzUkOJPJQ77KTwMHLENG4Nu3A731Dp3JJLDWRijK+ zQWY7rPNjvuCeZaFN2IQoAt8hWIl58N7qbPu81PYMB4z1abC98vff7nUXMtAWRFa vmSkRDco0WIQoPF2jVl+1kMTAv4os324rfEUsYkJRpgrf4Jj4Z8sPhJT/aVp/Ov7 bJftsUsr4VMLC7OuxUDpZ4/28xRBoNDS131tHXa+0w+AJzMhv5eSZtBZBYo++ag= =oVRh -----END PGP SIGNATURE----- --s/l3CgOIzMHHjg/5-- From owner-freebsd-hackers@FreeBSD.ORG Wed May 4 04:06:31 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3C78106564A for ; Wed, 4 May 2011 04:06:31 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 5DAD48FC08 for ; Wed, 4 May 2011 04:06:31 +0000 (UTC) Received: by gwb15 with SMTP id 15so348913gwb.13 for ; Tue, 03 May 2011 21:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:x-openpgp-key-id:x-openpgp-key-fingerprint :x-openpgp-key-url; bh=q19IV73aBNYnhRvpAzoG8pTop6Je1aNJVDSQibtf6b4=; b=QjX9xahAT9lKu1fKQbH/aStSI7Ale7xsHeYpt2453Q1exoUzrzlVcoI3WMDDH5oNyN 8CeWa1lepI1KaZ/9/ukFr/KpqAsWE9lCLTbTXExah4SfHxp6gM5YVG8+5Ulck7qMmJW9 7o+PpCBUnepV19OJhhTctLbObTd0l5caZTQlI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-openpgp-key-id :x-openpgp-key-fingerprint:x-openpgp-key-url; b=MB78ZK0Hp7x9LCJpp4LdnXivXlIDpj6kUYV/xbs3IBVbMOvSy7ntis4yLOBQxG6vOy Oncn6drTyfxV58/0M1UBzuXEU3MKhbzYwNa5yKW+R6+2/ywP5k/aepyAGdN/xz2aXpjA LKXfpmKpk75AGZirOzaeab6OFcABW/8PizGuw= Received: by 10.150.73.9 with SMTP id v9mr719234yba.138.1304481990540; Tue, 03 May 2011 21:06:30 -0700 (PDT) Received: from DataIX.net ([99.190.84.116]) by mx.google.com with ESMTPS id c3sm311555ybn.18.2011.05.03.21.06.27 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 May 2011 21:06:28 -0700 (PDT) Sender: "J. Hellenthal" Received: from DataIX.net (localhost [127.0.0.1]) by DataIX.net (8.14.4/8.14.4) with ESMTP id p4446MKm018364 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 4 May 2011 00:06:24 -0400 (EDT) (envelope-from jhell@DataIX.net) Received: (from jhell@localhost) by DataIX.net (8.14.4/8.14.4/Submit) id p4446MJd018363; Wed, 4 May 2011 00:06:22 -0400 (EDT) (envelope-from jhell@DataIX.net) Date: Wed, 4 May 2011 00:06:22 -0400 From: Jason Hellenthal To: Devin Teske Message-ID: <20110504040621.GC78390@DataIX.net> References: <20110430192737.287270@gmx.com> <20110501031105.GA16357@DataIX.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E/DnYTRukya0zdZ1" Content-Disposition: inline In-Reply-To: X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E X-OpenPGP-Key-URL: http://bit.ly/0x89D8547E Cc: freebsd-hackers@freebsd.org, 'Dieter BSD' Subject: Re: [RELEASE] New Boot-Loader Menu X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2011 04:06:31 -0000 --E/DnYTRukya0zdZ1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Devin, On Sat, Apr 30, 2011 at 08:45:14PM -0700, Devin Teske wrote: > >On Apr 30, 2011, at 8:11 PM, Jason Hellenthal wrote: > >>=20 >> Devin, >>=20 >>=20 >> On Sat, Apr 30, 2011 at 04:00:47PM -0700, Devin Teske wrote: >>>=20 >>>> Would be nice: "uname -v" of the kernel it will boot. >>>=20 >>> That's a bit more technically challenging. I'll have another look at the >>> FICL words available, but I don't recall if there was a way to crawl the >>> object space of the items loaded with ``load'' (looking for the uname).= I'm >>> open to suggestions if you had an idea of how to do this in Forth -- el= se >>> I'd think this would need to be a loader(8) modification. >>=20 >> How about forgetting a mention of unmae & ... instead look into if we >> can support some sort of bootcode versioning to be displayed on the >> screen. This would serve to be very helpful in the future when for say a >> new version of bootcode for ZFS has to be installed then it would be >> easy for announce@ to simply say "A new version of ZFS has been MFCd and >> requires boot version >=3D X. To find out your version please see the >> bottom right hand corner of your boot screen." >>=20 >> I would place a pretty good bet that loader(8) could be modified to >> export some sort of versioning of the bootcode to make this a easier >> stance for the user to gather information before a upgrade. > >Piece of cake! If you give me a loader(8) that exports a "version" environ= ment variable, I'll give the Forth functionality in mere seconds. It's alre= ady been developed (but was not packaged). > >I have a module named "version.4th" which prints the value of the "version= " environment variable at the bottom-right of the screen underneath the bea= stie logo. > >Since you mention this, I'll add the code to the next package and if/when = loader(8) ever exports a "version" environment variable, it will just magic= ally appear. How's that sound? > Sounds perfect! --=20 Regards, (jhell) Jason Hellenthal --E/DnYTRukya0zdZ1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) Comment: http://bit.ly/0x89D8547E iQEcBAEBAgAGBQJNwNC9AAoJEJBXh4mJ2FR+1RgH/1iRs0zi3VvARVSU8kt6PFxO voiBSwMSPsEoqVnaJqhYK5jJBoJCH/nHMQknmYkkCzP7Z38KeVp/0nE5i1+ebUk8 m6q7SYpcMLOAqn/aPZlcW8g5mvwA9jTzY4KG+02oi2hybjUhsU/30ku5i/sT0IB/ /42fkm+ww79cNhZtFVMAxWOf7coZUfCxfytQqInVAVfUQx7aOy2DMlebH2zngGGB tvgdq3q+qt3Nb9PTh4mNtvHL4yMQXobgJd40v9z0CtmaUB22TDse/hh9WmyK46fm N0xEgkLLvOzddU90+IX1cQ3d6OiqhKaNF10s1ChYR6RlIFtOBkeRTgoY/7UrCBg= =axjc -----END PGP SIGNATURE----- --E/DnYTRukya0zdZ1-- From owner-freebsd-hackers@FreeBSD.ORG Wed May 4 08:37:52 2011 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 58206106564A for ; Wed, 4 May 2011 08:37:52 +0000 (UTC) (envelope-from ehaupt@FreeBSD.org) Received: from mx.critical.ch (cl-8.zrh-02.ch.sixxs.net [IPv6:2001:1620:f00:7::2]) by mx1.freebsd.org (Postfix) with ESMTP id E35C98FC19 for ; Wed, 4 May 2011 08:37:51 +0000 (UTC) Received: from beaver.home.critical.ch (beaver.critical.ch [IPv6:2001:1620:f06:0:21e:8cff:fe7d:e7ea] (may be forged)) (authenticated bits=0) by mx.critical.ch (8.14.4/8.14.4/critical-1.0) with ESMTP id p448bmCw029439; Wed, 4 May 2011 10:37:49 +0200 (CEST) (envelope-from ehaupt@FreeBSD.org) Date: Wed, 4 May 2011 10:37:43 +0200 From: Emanuel Haupt To: Devin Teske Message-Id: <20110504103743.8d9f19d5.ehaupt@FreeBSD.org> In-Reply-To: <6955841F-C3C1-4C7D-8BA4-F8EBBF60F69B@vicor.com> References: <6955841F-C3C1-4C7D-8BA4-F8EBBF60F69B@vicor.com> X-Mailer: Sylpheed 3.1.0 (GTK+ 2.22.1; amd64-portbld-freebsd8.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Olivier SMEDTS , FreeBSD Hackers Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.3 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2011 08:37:52 -0000 Devin Teske wrote: > Hey all, > > Proud to bring you version 1.3 which completes the followup > suggestions made by Olivier Smedts (use autoboot_delay instead of > loader_menu_timeout and change dc_seconds to loader_delay) and a > couple other minor enhancements/fixes. > > I think that brings everything up to speed with the phenomenal > feedback provided so far. Really, thank you all very much. > > Get your update at http://druidbsd.sf.net/ or > http://druidbsd.sourceforge.net/download/loader_menu-1.3.tgz Devin, have you thought about writing a port [1]? I'd be happy to review it: [1] http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/own-port.html Emanuel From owner-freebsd-hackers@FreeBSD.ORG Wed May 4 11:29:25 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 686C9106566B for ; Wed, 4 May 2011 11:29:25 +0000 (UTC) (envelope-from philip-freebsd1@soeberg.net) Received: from pasmtpA.tele.dk (pasmtpa.tele.dk [80.160.77.114]) by mx1.freebsd.org (Postfix) with ESMTP id 265158FC1A for ; Wed, 4 May 2011 11:29:24 +0000 (UTC) Received: from mail.soeberg.net (0x573f534a.cpe.ge-1-1-0-1109.bynqu1.customer.tele.dk [87.63.83.74]) by pasmtpA.tele.dk (Postfix) with ESMTP id B201C80042E for ; Wed, 4 May 2011 13:29:23 +0200 (CEST) Received: from [10.240.10.87] ([188.120.77.114]) (authenticated user philip@soeberg.net) by mail.soeberg.net (using TLSv1/SSLv3 with cipher AES256-SHA (256 bits)) for freebsd-hackers@freebsd.org; Wed, 4 May 2011 13:29:31 +0200 Message-ID: <4DC13892.1020004@soeberg.net> Date: Wed, 04 May 2011 13:29:22 +0200 From: Philip Soeberg User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: freebsd-hackers@freebsd.org References: <4DBFFEC2.4010506@soeberg.net> <201105031144.32862.jhb@freebsd.org> <20110503174339.GI48734@deviant.kiev.zoral.com.ua> In-Reply-To: <20110503174339.GI48734@deviant.kiev.zoral.com.ua> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: Runtime check for PAE option on BSD 6+ i386 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: philip-freebsd1@soeberg.net List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2011 11:29:25 -0000 On 03-05-2011 19:43, Kostik Belousov wrote: > On Tue, May 03, 2011 at 11:44:32AM -0400, John Baldwin wrote: >> On Tuesday, May 03, 2011 9:10:26 am Philip Soeberg wrote: >>> Hi fellow FreeBSD hackers, >>> >>> I've been using the following poor-man's approach in my driver init for >>> ages in an attempt at detecting PAE option on BSD 6 (or greater) i386 >>> kernels, as I depend on dmabus(9) but provide a loadable kernel module only. >>> >>> >>> >>> if (sizeof(void*) == 4) { >>> if (((uint64_t)(cnt.v_page_count * cnt.v_page_size) / 1073741824) >>> >= 4) { >>> printf("FreeBSD i386 detected with PAE option enabled. FreeBSD >>> PAE type\n"); >>> printf("kernels does not support loadable modules which use DMA. >>> Please\n"); >>> printf("reconfigure your kernel for non-PAE or switch to amd64 >>> kernel.\n"); >>> return EFAULT; >>> } >>> } >>> <<< >> Hmmm, even this isn't really accurate as some folks may choose to enable PAE >> even with< 4GB to get PG_NX functionality. >> >>> afaik there's a sysctl method of checking this per BSD7 (or is it 8?), >>> but what about BSD6? Any hints on how I can runtime detect the above? >> Definitely a kern.features.pae sysctl in 7. I don't see anything similar in >> 6. > Read %cr4 and test the bit there. Ha, as always there exist a simple elegant solution.. thanks, that method had escaped me. From owner-freebsd-hackers@FreeBSD.ORG Wed May 4 15:38:12 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3FAFF106566C for ; Wed, 4 May 2011 15:38:12 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id 0AA0A8FC0A for ; Wed, 4 May 2011 15:38:11 +0000 (UTC) Received: from SBHFISLREXT03 ([10.132.254.62]) by SCSFISLTC01 (8.14.3/8.14.3) with ESMTP id p44FcAMd025920; Wed, 4 May 2011 10:38:10 -0500 Received: from sbhfisltcgw02.FNFIS.COM (Not Verified[10.132.248.122]) by SBHFISLREXT03 with MailMarshal (v6, 5, 4, 7535) id ; Wed, 04 May 2011 10:38:14 -0500 Received: from SBHFISLTCGW07.FNFIS.COM ([10.132.248.135]) by sbhfisltcgw02.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Wed, 4 May 2011 10:38:10 -0500 Received: from [192.168.1.123] ([10.132.254.136]) by SBHFISLTCGW07.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 4 May 2011 10:38:08 -0500 Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Devin Teske In-Reply-To: <20110504034549.GB78390@DataIX.net> Date: Wed, 4 May 2011 08:38:07 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <6955841F-C3C1-4C7D-8BA4-F8EBBF60F69B@vicor.com> <20110504034549.GB78390@DataIX.net> To: Jason Hellenthal X-Mailer: Apple Mail (2.1084) X-OriginalArrivalTime: 04 May 2011 15:38:09.0069 (UTC) FILETIME=[44EA4DD0:01CC0A71] Cc: Olivier SMEDTS , FreeBSD Hackers Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.3 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2011 15:38:12 -0000 On May 3, 2011, at 8:45 PM, Jason Hellenthal wrote: >=20 > Devin, >=20 >=20 > On Mon, May 02, 2011 at 08:57:05PM -0700, Devin Teske wrote: > [...] >>=20 >> loader_brand=3D"..." >>=20 >> Selects the BSD brand to display. Valid values are "fbsd" (displays >> "FreeBSD") and "dbsd" (displays "DruidBSD"). An invalid value (such as >> "none") will disable the display of any brand. The brand is displayed >> above the dynamic menu. The default is "fbsd". >>=20 > [...] >=20 > Speaking directly toward one of the many other version announcements wher= e=20 > you mentioned approaching -core@ in delta D). I can't see DruidBSD making= =20 > it into the tree. You might want to do some work to separate that for you= r=20 > own personal use. Replacing it with "PC-BSD" on the other hand or allowin= g=20 > user supplied text to just be there without all the checking is another= =20 > option. Fair enough. I'll replace "DruidBSD" with "PC-BSD". I'm sure the PC-BSD com= munity would appreciate it. Out of curiousity, are FreeBSD and PC-BSD officially affiliated in some way? --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Wed May 4 15:57:36 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D6B44106564A for ; Wed, 4 May 2011 15:57:36 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id 9E9068FC18 for ; Wed, 4 May 2011 15:57:36 +0000 (UTC) Received: from SBHFISLREXT03 ([10.132.254.62]) by SCSFISLTC02 (8.14.3/8.14.3) with ESMTP id p44FvYNg030358; Wed, 4 May 2011 10:57:34 -0500 Received: from SBHFISLTCGW04.FNFIS.COM (Not Verified[10.132.248.123]) by SBHFISLREXT03 with MailMarshal (v6, 5, 4, 7535) id ; Wed, 04 May 2011 10:57:39 -0500 Received: from SBHFISLTCGW07.FNFIS.COM ([10.132.248.135]) by SBHFISLTCGW04.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Wed, 4 May 2011 10:57:34 -0500 Received: from [192.168.1.123] ([10.132.254.136]) by SBHFISLTCGW07.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 4 May 2011 10:57:33 -0500 Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Devin Teske In-Reply-To: <20110504040621.GC78390@DataIX.net> Date: Wed, 4 May 2011 08:57:32 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <5536F45D-82C1-44EE-8BF2-E1C081FAC095@vicor.com> References: <20110430192737.287270@gmx.com> <20110501031105.GA16357@DataIX.net> <20110504040621.GC78390@DataIX.net> To: Jason Hellenthal X-Mailer: Apple Mail (2.1084) X-OriginalArrivalTime: 04 May 2011 15:57:33.0881 (UTC) FILETIME=[FB328290:01CC0A73] Cc: freebsd-hackers@freebsd.org, 'Dieter BSD' Subject: Re: [RELEASE] New Boot-Loader Menu X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2011 15:57:37 -0000 On May 3, 2011, at 9:06 PM, Jason Hellenthal wrote: >=20 > Devin, >=20 >=20 > On Sat, Apr 30, 2011 at 08:45:14PM -0700, Devin Teske wrote: >>=20 >> On Apr 30, 2011, at 8:11 PM, Jason Hellenthal wrote: >>=20 >>>=20 >>> Devin, >>>=20 >>>=20 >>> On Sat, Apr 30, 2011 at 04:00:47PM -0700, Devin Teske wrote: >>>>=20 >>>>> Would be nice: "uname -v" of the kernel it will boot. >>>>=20 >>>> That's a bit more technically challenging. I'll have another look at t= he >>>> FICL words available, but I don't recall if there was a way to crawl t= he >>>> object space of the items loaded with ``load'' (looking for the uname)= . I'm >>>> open to suggestions if you had an idea of how to do this in Forth -- e= lse >>>> I'd think this would need to be a loader(8) modification. >>>=20 >>> How about forgetting a mention of unmae & ... instead look into if we >>> can support some sort of bootcode versioning to be displayed on the >>> screen. This would serve to be very helpful in the future when for say a >>> new version of bootcode for ZFS has to be installed then it would be >>> easy for announce@ to simply say "A new version of ZFS has been MFCd and >>> requires boot version >=3D X. To find out your version please see the >>> bottom right hand corner of your boot screen." >>>=20 >>> I would place a pretty good bet that loader(8) could be modified to >>> export some sort of versioning of the bootcode to make this a easier >>> stance for the user to gather information before a upgrade. >>=20 >> Piece of cake! If you give me a loader(8) that exports a "version" envir= onment variable, I'll give the Forth functionality in mere seconds. It's al= ready been developed (but was not packaged). >>=20 >> I have a module named "version.4th" which prints the value of the "versi= on" environment variable at the bottom-right of the screen underneath the b= eastie logo. >>=20 >> Since you mention this, I'll add the code to the next package and if/whe= n loader(8) ever exports a "version" environment variable, it will just mag= ically appear. How's that sound? >>=20 >=20 > Sounds perfect! One minor adjustment... can we make that environment variable "loader_versi= on" instead of "version"? The code is already in for "loader_version". Whatever string you export int= o that environment variable will be displayed on-screen at bottom-right, ri= ght-justified. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Wed May 4 22:20:31 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E71BD1065670 for ; Wed, 4 May 2011 22:20:30 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 8D13F8FC08 for ; Wed, 4 May 2011 22:20:30 +0000 (UTC) Received: by gxk28 with SMTP id 28so730779gxk.13 for ; Wed, 04 May 2011 15:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:cc:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:x-openpgp-key-id:x-openpgp-key-fingerprint :x-openpgp-key-url; bh=OncbhDgiXllfgq2zq0k8GT8iBL99e4bg6cAGbQzdvWA=; b=EWIb4AxOw7WwfIHh+AGcYMCgFs2qiVl4Mke17Zk8+NC5KAgRzICFU3Lk7ffsTx6lo1 nPrHAYTIh7QoliAPy8NC3nEAA+ktdngMVlIF0yWd6kHbL/bjN4XK8PG7CaqpPVpKoSw/ eBbU4DML40VYqElvCeIoiVDzH25x9q2pxj+ts= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-openpgp-key-id :x-openpgp-key-fingerprint:x-openpgp-key-url; b=tzuPdi4JdPVcgJoTSCh5UNtcLqn1088AUMnXp+VT+9bdwAQd7tQN3YPnNXApbn8Cis NqH73O1CRTOguQyrr8A1zP8vlsbCKoxYhoquIjZSSSJEvX/k9oUMatGzK2OdQ9msVF0r 5FhEkOdYCd3kkuxxp/kgoZGCKLyiR6ucuJUI0= Received: by 10.151.87.2 with SMTP id p2mr1596783ybl.99.1304547629430; Wed, 04 May 2011 15:20:29 -0700 (PDT) Received: from DataIX.net (adsl-99-190-84-116.dsl.klmzmi.sbcglobal.net [99.190.84.116]) by mx.google.com with ESMTPS id w1sm729714ybl.24.2011.05.04.15.20.26 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 04 May 2011 15:20:27 -0700 (PDT) Sender: "J. Hellenthal" Received: from DataIX.net (localhost [127.0.0.1]) by DataIX.net (8.14.4/8.14.4) with ESMTP id p44MKOuY007742 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 4 May 2011 18:20:24 -0400 (EDT) (envelope-from jhell@DataIX.net) Received: (from jhell@localhost) by DataIX.net (8.14.4/8.14.4/Submit) id p44MKMW4007741; Wed, 4 May 2011 18:20:22 -0400 (EDT) (envelope-from jhell@DataIX.net) Date: Wed, 4 May 2011 18:20:22 -0400 From: Jason Hellenthal To: Devin Teske Message-ID: <20110504222022.GA6943@DataIX.net> References: <6955841F-C3C1-4C7D-8BA4-F8EBBF60F69B@vicor.com> <20110504034549.GB78390@DataIX.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Qxx1br4bt0+wmkIi" Content-Disposition: inline In-Reply-To: X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E X-OpenPGP-Key-URL: http://bit.ly/0x89D8547E Cc: Olivier SMEDTS , FreeBSD Hackers Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.3 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2011 22:20:31 -0000 --Qxx1br4bt0+wmkIi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Devin, On Wed, May 04, 2011 at 08:38:07AM -0700, Devin Teske wrote: > >On May 3, 2011, at 8:45 PM, Jason Hellenthal wrote: > >>=20 >> Devin, >>=20 >>=20 >> On Mon, May 02, 2011 at 08:57:05PM -0700, Devin Teske wrote: >> [...] >>>=20 >>> loader_brand=3D"..." >>>=20 >>> Selects the BSD brand to display. Valid values are "fbsd" (displays >>> "FreeBSD") and "dbsd" (displays "DruidBSD"). An invalid value (such as >>> "none") will disable the display of any brand. The brand is displayed >>> above the dynamic menu. The default is "fbsd". >>>=20 >> [...] >>=20 >> Speaking directly toward one of the many other version announcements whe= re=20 >> you mentioned approaching -core@ in delta D). I can't see DruidBSD makin= g=20 >> it into the tree. You might want to do some work to separate that for yo= ur=20 >> own personal use. Replacing it with "PC-BSD" on the other hand or allowi= ng=20 >> user supplied text to just be there without all the checking is another= =20 >> option. > >Fair enough. I'll replace "DruidBSD" with "PC-BSD". I'm sure the PC-BSD co= mmunity would appreciate it. > >Out of curiousity, are FreeBSD and PC-BSD officially affiliated in some wa= y? Just FreeBSD re-badged with a new installer frontend to make it easier on= =20 those looking to install FreeBSD as a desktop. --=20 Regards, (jhell) Jason Hellenthal --Qxx1br4bt0+wmkIi Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) Comment: http://bit.ly/0x89D8547E iQEcBAEBAgAGBQJNwdElAAoJEJBXh4mJ2FR+lQ0H/1F7zXC2ruMQZzOzDlzumb40 vzzRWuLOfw+mputt9xMQ3hhIiGYKAP3YCru98n2df1Q1ks0eg4Q2mjlN9akoXIUL NIeaqCRA1LMm+anzGPa4Qru3qhgHZ0/5GtmaikFWABu9Am6tl8uyx68KRbITig63 CTGPmJh7TLYvwUHzo41+lFy3IYZrb8DlHj+YgwLOa4Inw73lXo5FAOlRGa4SYeE2 M5qW9mF1jU2mqbbMAtC/1PSKAavhW2pzpuwICvrohCaXJG1WIocVf3nSDzWGxVNA WZxHkLlntXYNtd7HrxS5x01PvHBuZlNRDoeCq2zVT2dbSOi+vGEazI6fsASokbk= =n0Hg -----END PGP SIGNATURE----- --Qxx1br4bt0+wmkIi-- From owner-freebsd-hackers@FreeBSD.ORG Thu May 5 08:20:47 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B0AF106567A for ; Thu, 5 May 2011 08:20:47 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id 23BE88FC26 for ; Thu, 5 May 2011 08:20:46 +0000 (UTC) Received: from SBHFISLREXT03 ([10.132.254.62]) by SCSFISLTC02 (8.14.3/8.14.3) with ESMTP id p458KksK012041 for ; Thu, 5 May 2011 03:20:46 -0500 Received: from SBHFISLTCGW07.FNFIS.COM (Not Verified[10.132.248.135]) by SBHFISLREXT03 with MailMarshal (v6, 5, 4, 7535) id ; Thu, 05 May 2011 03:20:51 -0500 Received: from SBHFISLTCGW07.FNFIS.COM ([10.132.248.135]) by SBHFISLTCGW07.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Thu, 5 May 2011 03:20:45 -0500 Received: from [10.0.0.102] ([10.132.254.136]) by SBHFISLTCGW07.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 5 May 2011 03:20:45 -0500 From: Devin Teske Date: Thu, 5 May 2011 01:20:43 -0700 Message-Id: <65D3163B-427B-41F6-80B9-7BA4AF794939@vicor.com> To: FreeBSD Hackers Mime-Version: 1.0 (Apple Message framework v1084) X-Mailer: Apple Mail (2.1084) X-OriginalArrivalTime: 05 May 2011 08:20:45.0595 (UTC) FILETIME=[54FFB6B0:01CC0AFD] Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: [UPDATE] New Boot-Loader Menu -- version 1.4 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 08:20:47 -0000 Hello fellow -hackers, I'm so very proud to offer the latest update to my new boot loader menu -- = version 1.4 -- addressing ACPI detection, bringing it in-line with HEAD. It took some work and a few days, but I got it! Have a look below for six d= ifferent displays (three different scenarios -- i386 w/ ACPI, i386 w/o ACPI= , and non-i386 -- each in both B&W and Color). Running on i386-compatible hardware supporting ACPI: B&W (standard): http://twitpic.com/4tlsin Color (loader_color=3DYES): http://twitpic.com/4tlt6l Running on i386-compatible hardware lacking ACPI support: B&W (standard): http://twitpic.com/4tltp0 Color (loader_color=3DYES): http://twitpic.com/4tlu5w Running on non-i386 hardware: B&W (standard): http://twitpic.com/4tluio Color (loader_color=3DYES): http://twitpic.com/4tluuy This version is feature complete with HEAD and backward compatible to 7.0-R= ELEASE. I do hope you like this latest version. You can get your update at: http://druidbsd.sourceforge.net/ or http://druidbsd.sourceforge.net/download/loader_menu-1.4.tgz --=20 Cheers, Devin Teske -> FUN STUFF <- -----BEGIN GEEK CODE BLOCK----- Version 3.12 GAT/CS/B/CC/E/IT/MC/M/MU/P/S/TW d+(++) s: a- C+++@$ UB++++$ P++++@$ L++++$ = E- W+++ N? o? K? w@ O M++$ V- PS+>++ PE@ Y+ PGP-> t(+) 5? X(+) R(-) tv+ b+>++ = DI+ D+(++) G++ e>++++ h r+++ z+++ ------END GEEK CODE BLOCK------ http://www.geekcode.com/ -> LEGAL DISCLAIMER <- This message contains confidential and proprietary information of the sender, and is intended only for the person(s) to whom it is addressed. Any use, distribution, copying or disclosure by any other person is strictly prohibited. If you have received this message in error, please notify the e-mail sender immediately, and delete the original message without making a copy. -> END TRANSMISSION <- _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Thu May 5 09:05:42 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7FAA1065670 for ; Thu, 5 May 2011 09:05:42 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from nm21-vm2.bullet.mail.ne1.yahoo.com (nm21-vm2.bullet.mail.ne1.yahoo.com [98.138.91.209]) by mx1.freebsd.org (Postfix) with SMTP id 7C2C28FC20 for ; Thu, 5 May 2011 09:05:42 +0000 (UTC) Received: from [98.138.90.57] by nm21.bullet.mail.ne1.yahoo.com with NNFMP; 05 May 2011 08:52:07 -0000 Received: from [98.138.84.38] by tm10.bullet.mail.ne1.yahoo.com with NNFMP; 05 May 2011 08:52:07 -0000 Received: from [127.0.0.1] by smtp106.mail.ne1.yahoo.com with NNFMP; 05 May 2011 08:52:07 -0000 X-Yahoo-Newman-Id: 778545.78704.bm@smtp106.mail.ne1.yahoo.com Received: from [192.168.119.12] (se@81.173.144.96 with plain) by smtp106.mail.ne1.yahoo.com with SMTP; 05 May 2011 01:52:07 -0700 PDT X-Yahoo-SMTP: iDf2N9.swBDAhYEh7VHfpgq0lnq. X-YMail-OSG: 9JxUB_EVM1ksaGsHUnwbBHoya3AduAJfEE3bCPfMlEhHocs 3rpHIn6UiZbHt7sTHn5x27sr2dFUWHZNIGBRHvdPNIYWC3kFPlDLfw7T_DG2 eVWozaCuamGBHI9ug6gZ77PA4sgkNCXDs69AemZRIxHRn5n3ssFmly0ibgnw EHcCKf6UDXRYfwGP0FqfhfmFfNMoDBYcg8BsIZ1ng8Z1G4LrNMwK3H8Waziw 1_y5T8SgjkHEEEa6G5esjsGuwQDZJpIaFPT5QjByXxBX8VpGNl6TlzTJnK5L BF3UTLO0a7nPFysldYL67gnlUU1QLudWkOkPAFY4u4mbGQy6tpE_JXWOFT86 xf7vpx4kPUNqSsdIMVpo.HZ_vstGP7NmxFC_EJj_WT10yUS82Z1vH0.cZjRJ EPsyNRfvhAa5wsE2uLOt9PBo_BeTDPG1IppkNtn8Heb8qYTfj0YaBEfyTtZF aTRXlQv.PKWFYahCfIh75aKyAby3P2DAo1wW0Ho1dKr7gmw-- X-Yahoo-Newman-Property: ymail-3 Message-ID: <4DC26533.5010904@FreeBSD.org> Date: Thu, 05 May 2011 10:52:03 +0200 From: Stefan Esser User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.18) Gecko/20081105 Thunderbird/2.0.0.18 ThunderBrowse/3.2.2.1 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: FreeBSD Hackers X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: ZFS panic during file move on nearly full pool X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 09:05:42 -0000 I just lost my 2TB ZFS pool while moving some large files (ISO images) under a current stable. The system paniced with a message very similar to the one reported in http://unix.derkeiler.com/Mailing-Lists/FreeBSD/current/2009-05/msg00181.html . Seems, that the on-disk structure is damaged, since the identical panic happens even when I try to import into a fresh -CURRENT with its newer ZFS code. Is there any chance to recover my data? I have copies of some critical information, but no easily restorable complete backups and thus I´m very interested in getting (most of) this pool working again ... Any ideas or help? Thanks in advance! STefan From owner-freebsd-hackers@FreeBSD.ORG Thu May 5 11:05:03 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CCE91106564A for ; Thu, 5 May 2011 11:05:03 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from nm30-vm4.bullet.mail.ne1.yahoo.com (nm30-vm4.bullet.mail.ne1.yahoo.com [98.138.91.190]) by mx1.freebsd.org (Postfix) with SMTP id 76D718FC17 for ; Thu, 5 May 2011 11:05:03 +0000 (UTC) Received: from [98.138.90.49] by nm30.bullet.mail.ne1.yahoo.com with NNFMP; 05 May 2011 11:05:02 -0000 Received: from [98.138.84.43] by tm2.bullet.mail.ne1.yahoo.com with NNFMP; 05 May 2011 11:05:02 -0000 Received: from [127.0.0.1] by smtp111.mail.ne1.yahoo.com with NNFMP; 05 May 2011 11:05:02 -0000 X-Yahoo-Newman-Id: 920406.25000.bm@smtp111.mail.ne1.yahoo.com Received: from [192.168.119.12] (se@81.173.144.96 with plain) by smtp111.mail.ne1.yahoo.com with SMTP; 05 May 2011 04:05:02 -0700 PDT X-Yahoo-SMTP: iDf2N9.swBDAhYEh7VHfpgq0lnq. X-YMail-OSG: 4NrwiX0VM1ncV4o4x9Sa4_srkER1h0FNvlnxpGjbEQM4ZmK lhrT4ertKMSiGn3EmKpTvEPN.9K7L1c2xDwe0KX_MdGC8ZVtz4pQGfAxa_aF tedwNnYSW0.rIMtZs4Zxpmfax7uXpRSXH62TqHeOv8.Ccw8d2w7_uFntasyW yRYpatySTQpHyF59qsJret93zANqkFEMtclVlHn3LOvoUCaaDtjROyVRPlJr UIwIj3ubzTtzytK4NmlAjhGhPu34Dc4enOHWITJAR6PGLrsA06d82fVec1PP xl6t0RkENUX3foMI2XIWhiXTowP05krddkoBFPwQHmt4dIsyXQrBTFf.NF5q YuA5lwqdC_Adrt74B0Rei70ZqFbCDdiW0_ufZNn6OwheUaf.9rB7rtYgM3xq wxo4nvYI4i425nIXKN._zQtLeQvhCQb80gNs5iX9AdhL_xhBqYo7ohoZF1hA niUZj58Dqfw-- X-Yahoo-Newman-Property: ymail-3 Message-ID: <4DC2845B.5040401@FreeBSD.org> Date: Thu, 05 May 2011 13:04:59 +0200 From: Stefan Esser User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.18) Gecko/20081105 Thunderbird/2.0.0.18 ThunderBrowse/3.2.2.1 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: FreeBSD Hackers References: <4DC26533.5010904@FreeBSD.org> In-Reply-To: <4DC26533.5010904@FreeBSD.org> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: ZFS pool lost X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 11:05:03 -0000 Sorry for the follow-up to my own posting, but I noticed, that I left out significant information. The system is an Athlon64 (X2, but was running with SMP disabled at the time) in 32 bit mode (i386) with 4GB RAM running 8-STABLE in a ZFS only configuration (one UFS partition was mounted but not accessed; it contains an emergency system which allows me to boot the exact kernel and access /rescue in exactly the version that was installed on ZFS). The panic occurs under 8-STABLE/i386 and with identical message when booting a -CURRENT live file-system from CD. The ZPOOL consists of 3 1TB drives in a raidz1 configuration, of which only some 40GB were free. The panic message reads (under -CURRENT, but it is the same when booting 8-STABLE): panic: solaris assert: ss == NULL, file: /sys/cddl/contrib/opensolaris/uts/common/fs/zfs/space_map.c, line: 109 No dumps are currently available (I installed a -CURRENT into the normally used SWAP space), but I could try to add a new drive. I'm willing to analyze and debug this, if there is any chance of recovery. As I understand the situation, the inconsistency in the ZPOOL has been caused by some locking or processing error during the file move and there is no chance, to identify the cause of the file-system corruption in this state. Any ideas? Best regards, STefan Am 05.05.2011 10:52, schrieb Stefan Esser: > I just lost my 2TB ZFS pool while moving some large files (ISO images) > under a current stable. The system paniced with a message very similar > to the one reported in > > http://unix.derkeiler.com/Mailing-Lists/FreeBSD/current/2009-05/msg00181.html . > > Seems, that the on-disk structure is damaged, since the identical panic > happens even when I try to import into a fresh -CURRENT with its newer > ZFS code. > > Is there any chance to recover my data? I have copies of some critical > information, but no easily restorable complete backups and thus I´m very > interested in getting (most of) this pool working again ... > > Any ideas or help? > > Thanks in advance! > > STefan From owner-freebsd-hackers@FreeBSD.ORG Thu May 5 13:40:45 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6FBD3106566B for ; Thu, 5 May 2011 13:40:45 +0000 (UTC) (envelope-from wblock@wonkity.com) Received: from wonkity.com (wonkity.com [67.158.26.137]) by mx1.freebsd.org (Postfix) with ESMTP id 2F4438FC18 for ; Thu, 5 May 2011 13:40:44 +0000 (UTC) Received: from wonkity.com (localhost [127.0.0.1]) by wonkity.com (8.14.4/8.14.4) with ESMTP id p45Deibs026569; Thu, 5 May 2011 07:40:44 -0600 (MDT) (envelope-from wblock@wonkity.com) Received: from localhost (wblock@localhost) by wonkity.com (8.14.4/8.14.4/Submit) with ESMTP id p45Deihe026566; Thu, 5 May 2011 07:40:44 -0600 (MDT) (envelope-from wblock@wonkity.com) Date: Thu, 5 May 2011 07:40:44 -0600 (MDT) From: Warren Block To: Devin Teske In-Reply-To: <65D3163B-427B-41F6-80B9-7BA4AF794939@vicor.com> Message-ID: References: <65D3163B-427B-41F6-80B9-7BA4AF794939@vicor.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (wonkity.com [127.0.0.1]); Thu, 05 May 2011 07:40:44 -0600 (MDT) Cc: FreeBSD Hackers Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.4 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 13:40:45 -0000 On Thu, 5 May 2011, Devin Teske wrote: > Running on i386-compatible hardware supporting ACPI: > B&W (standard): http://twitpic.com/4tlsin > Color (loader_color=YES): http://twitpic.com/4tlt6l Looks nice. Options 3, 4, and 5 could be changed to 3. Safe Mode 4. Single User Mode 5. Verbose On/Off or Enabled/Disabled might be bikeshedably better than Yes and No. From owner-freebsd-hackers@FreeBSD.ORG Thu May 5 14:59:50 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71B77106566B for ; Thu, 5 May 2011 14:59:50 +0000 (UTC) (envelope-from freebsd-hackers@m.gmane.org) Received: from lo.gmane.org (lo.gmane.org [80.91.229.12]) by mx1.freebsd.org (Postfix) with ESMTP id E46D88FC0C for ; Thu, 5 May 2011 14:59:49 +0000 (UTC) Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QI01s-0001Ul-HN for freebsd-hackers@freebsd.org; Thu, 05 May 2011 16:59:48 +0200 Received: from lara.cc.fer.hr ([161.53.72.113]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 05 May 2011 16:59:48 +0200 Received: from ivoras by lara.cc.fer.hr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 05 May 2011 16:59:48 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: freebsd-hackers@freebsd.org From: Ivan Voras Date: Thu, 05 May 2011 16:59:36 +0200 Lines: 26 Message-ID: References: <65D3163B-427B-41F6-80B9-7BA4AF794939@vicor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: lara.cc.fer.hr User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.12) Gecko/20101102 Thunderbird/3.1.6 In-Reply-To: X-Enigmail-Version: 1.1.2 Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.4 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 14:59:50 -0000 On 05/05/2011 15:40, Warren Block wrote: > On Thu, 5 May 2011, Devin Teske wrote: > >> Running on i386-compatible hardware supporting ACPI: >> B&W (standard): http://twitpic.com/4tlsin >> Color (loader_color=YES): http://twitpic.com/4tlt6l > > Looks nice. Options 3, 4, and 5 could be changed to > > 3. Safe Mode > 4. Single User Mode > 5. Verbose > > On/Off or Enabled/Disabled might be bikeshedably better than Yes and No. If we're going to nitpick, then the style of *Enable* Safe Mode : *YES | NO* may be even better :) While at it, I'd also suggest aligning the YES | NO fields vertically for better readability. But these are minor suggestions, it is ok the way it is :) From owner-freebsd-hackers@FreeBSD.ORG Fri May 6 01:21:33 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A4162106566B for ; Fri, 6 May 2011 01:21:33 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id 6DDB08FC13 for ; Fri, 6 May 2011 01:21:33 +0000 (UTC) Received: from SBHFISLREXT03 ([10.132.254.62]) by SCSFISLTC01 (8.14.3/8.14.3) with ESMTP id p461LVOk006553; Thu, 5 May 2011 20:21:31 -0500 Received: from SBHFISLTCGW07.FNFIS.COM (Not Verified[10.132.248.135]) by SBHFISLREXT03 with MailMarshal (v6, 5, 4, 7535) id ; Thu, 05 May 2011 20:21:37 -0500 Received: from sbhfisltcgw01.FNFIS.COM ([10.132.248.121]) by SBHFISLTCGW07.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Thu, 5 May 2011 20:21:30 -0500 Received: from lummox ([10.132.254.136]) by sbhfisltcgw01.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 5 May 2011 20:21:30 -0500 From: "Devin Teske" To: "'Ivan Voras'" , References: <65D3163B-427B-41F6-80B9-7BA4AF794939@vicor.com> Date: Thu, 5 May 2011 18:21:27 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 Thread-Index: AcwLNSDluMthtnnYSlewT/3nx6MOmAAVTd9Q X-OriginalArrivalTime: 06 May 2011 01:21:30.0557 (UTC) FILETIME=[EDD746D0:01CC0B8B] Cc: Subject: RE: [UPDATE] New Boot-Loader Menu -- version 1.4 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2011 01:21:33 -0000 > -----Original Message----- > From: owner-freebsd-hackers@freebsd.org [mailto:owner-freebsd- > hackers@freebsd.org] On Behalf Of Ivan Voras > Sent: Thursday, May 05, 2011 8:00 AM > To: freebsd-hackers@freebsd.org > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.4 > > On 05/05/2011 15:40, Warren Block wrote: > > On Thu, 5 May 2011, Devin Teske wrote: > > > >> Running on i386-compatible hardware supporting ACPI: > >> B&W (standard): http://twitpic.com/4tlsin > >> Color (loader_color=YES): http://twitpic.com/4tlt6l > > > > Looks nice. Options 3, 4, and 5 could be changed to > > > > 3. Safe Mode > > 4. Single User Mode > > 5. Verbose > > > > On/Off or Enabled/Disabled might be bikeshedably better than Yes and No. > > If we're going to nitpick, then the style of > > *Enable* Safe Mode : *YES | NO* > > may be even better :) While at it, I'd also suggest aligning the YES | > NO fields vertically for better readability. > > But these are minor suggestions, it is ok the way it is :) > Suggestions are good. I'm always open to them. Both are good suggestions. It's with great undulating frivolity (think: Steve Ballmer or Billy Mays) that I invite anyone to simply edit the decidedly Forth-free /boot/menu.rc where the captions are configured simply as a series of carefully-named environment variables. If you find something you like, report back the values that you used and I'll test them out. If it's a definite improvement, I'll definitely make the change. The current boot loader menu, you have to go mucking through Forth to change the captions (which can be tricky with any stack-based language let alone a reverse polish one such as FICL). -- Devin _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Fri May 6 09:12:00 2011 Return-Path: Delivered-To: hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDE19106564A for ; Fri, 6 May 2011 09:12:00 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id E00F18FC08 for ; Fri, 6 May 2011 09:11:59 +0000 (UTC) Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA21450 for ; Fri, 06 May 2011 12:11:58 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost.topspin.kiev.ua ([127.0.0.1]) by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1QIH4o-000D20-EF for hackers@freebsd.org; Fri, 06 May 2011 12:11:58 +0300 Message-ID: <4DC3BB5D.5080300@FreeBSD.org> Date: Fri, 06 May 2011 12:11:57 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110503 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: hackers@FreeBSD.org X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=X-VIET-VPS Content-Transfer-Encoding: 7bit Cc: Subject: thread_lock vs panic/trap X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2011 09:12:00 -0000 Can a current thread panic or receive a trap while some other thread holds its thread_lock (the same lock as pointed to by the td_lock)? And a related question, can there be a reason for a thread in panic or kdb context to try to get the thread_lock? Thank you! -- Andriy Gapon From owner-freebsd-hackers@FreeBSD.ORG Fri May 6 08:35:53 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDED21065672; Fri, 6 May 2011 08:35:53 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 768D48FC14; Fri, 6 May 2011 08:35:53 +0000 (UTC) Received: from outgoing.leidinger.net (p5B1556E7.dip.t-dialin.net [91.21.86.231]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 6E24B844018; Fri, 6 May 2011 10:35:35 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [IPv6:fd73:10c7:2053:1::2:102]) by outgoing.leidinger.net (Postfix) with ESMTP id 6CB76120C; Fri, 6 May 2011 10:35:31 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.13.8/Submit) id p468ZUp0032911; Fri, 6 May 2011 10:35:30 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Fri, 06 May 2011 10:35:30 +0200 Message-ID: <20110506103530.185262w55kumd3sw@webmail.leidinger.net> Date: Fri, 06 May 2011 10:35:30 +0200 From: Alexander Leidinger To: Stefan Esser References: <4DC26533.5010904@FreeBSD.org> <4DC2845B.5040401@FreeBSD.org> In-Reply-To: <4DC2845B.5040401@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.6) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 6E24B844018.AFFD1 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=0.077, required 6, autolearn=disabled, TW_ZF 0.08) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1305275739.65665@XlVUybo5Wo3CfS7WsO+8gA X-EBL-Spam-Status: No X-Mailman-Approved-At: Fri, 06 May 2011 11:03:35 +0000 Cc: FreeBSD Hackers Subject: Re: ZFS pool lost X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2011 08:35:53 -0000 Quoting Stefan Esser (from Thu, 05 May 2011 13:04:59 +0200): > Sorry for the follow-up to my own posting, but I noticed, that I left > out significant > information. > > The system is an Athlon64 (X2, but was running with SMP disabled at the > time) in > 32 bit mode (i386) with 4GB RAM running 8-STABLE in a ZFS only configuration > (one UFS partition was mounted but not accessed; it contains an > emergency system > which allows me to boot the exact kernel and access /rescue in exactly > the version that > was installed on ZFS). The panic occurs under 8-STABLE/i386 and with > identical > message when booting a -CURRENT live file-system from CD. The current is from which date? If it is one without zfs v28, please try one with zfs v28 (if you want to have a 8.2-release with v28 patched in: http://mfsbsd.vx.sk/). Maybe the problem is fixed in v28. If the import/export into v28 (it does not updeate the pool automatically, and updating the pool manually is not necessary) and a reimport into v15 does not solve the issue, you could try a "import -F" on v28 and then export + reimport in v15. Bye, Alexander. -- BOFH excuse #176: vapors from evaporating sticky-note adhesives http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From owner-freebsd-hackers@FreeBSD.ORG Fri May 6 15:38:02 2011 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0780A1065677; Fri, 6 May 2011 15:38:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (unknown [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 990D88FC13; Fri, 6 May 2011 15:38:01 +0000 (UTC) Received: from warner-losh.int.fusionio.com ([216.51.42.66]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id p46FUhrs075871 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Fri, 6 May 2011 09:30:46 -0600 (MDT) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: Date: Fri, 6 May 2011 09:30:37 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <65D3163B-427B-41F6-80B9-7BA4AF794939@vicor.com> To: Devin Teske X-Mailer: Apple Mail (2.1084) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Fri, 06 May 2011 09:30:47 -0600 (MDT) Cc: freebsd-hackers@FreeBSD.org, 'Ivan Voras' Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.4 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2011 15:38:02 -0000 On May 5, 2011, at 7:21 PM, Devin Teske wrote: >> -----Original Message----- >> From: owner-freebsd-hackers@freebsd.org [mailto:owner-freebsd- >> hackers@freebsd.org] On Behalf Of Ivan Voras >> Sent: Thursday, May 05, 2011 8:00 AM >> To: freebsd-hackers@freebsd.org >> Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.4 >>=20 >> On 05/05/2011 15:40, Warren Block wrote: >>> On Thu, 5 May 2011, Devin Teske wrote: >>>=20 >>>> Running on i386-compatible hardware supporting ACPI: >>>> B&W (standard): http://twitpic.com/4tlsin >>>> Color (loader_color=3DYES): http://twitpic.com/4tlt6l >>>=20 >>> Looks nice. Options 3, 4, and 5 could be changed to >>>=20 >>> 3. Safe Mode >>> 4. Single User Mode >>> 5. Verbose >>>=20 >>> On/Off or Enabled/Disabled might be bikeshedably better than Yes and = No. >>=20 >> If we're going to nitpick, then the style of >>=20 >> *Enable* Safe Mode : *YES | NO* >>=20 >> may be even better :) While at it, I'd also suggest aligning the YES = | >> NO fields vertically for better readability. >>=20 >> But these are minor suggestions, it is ok the way it is :) >>=20 >=20 > Suggestions are good. I'm always open to them. Both are good = suggestions. >=20 > It's with great undulating frivolity (think: Steve Ballmer or Billy = Mays) > that I invite anyone to simply edit the decidedly Forth-free = /boot/menu.rc > where the captions are configured simply as a series of = carefully-named > environment variables. If you find something you like, report back the > values that you used and I'll test them out. If it's a definite = improvement, > I'll definitely make the change. >=20 > The current boot loader menu, you have to go mucking through Forth to = change > the captions (which can be tricky with any stack-based language let = alone a > reverse polish one such as FICL). In general, I really like things becoming more modular. For FreeNAS's = boot loader, I hacked a copy and put it as a patch to the FreeNAS = build.... Warner From owner-freebsd-hackers@FreeBSD.ORG Fri May 6 16:28:46 2011 Return-Path: Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 24204106564A; Fri, 6 May 2011 16:28:46 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id DE99D8FC0A; Fri, 6 May 2011 16:28:45 +0000 (UTC) Received: from sbhfislrext02.fnfis.com ([192.168.249.140]) by SCSFISLTC01 (8.14.3/8.14.3) with ESMTP id p46GScxO021384; Fri, 6 May 2011 11:28:38 -0500 Received: from SBHFISLTCGW04.FNFIS.COM (Not Verified[10.132.248.123]) by sbhfislrext02.fnfis.com with MailMarshal (v6, 5, 4, 7535) id ; Fri, 06 May 2011 11:28:43 -0500 Received: from SBHFISLTCGW04.FNFIS.COM ([10.132.248.123]) by SBHFISLTCGW04.FNFIS.COM with Microsoft SMTPSVC(6.0.3790.4675); Fri, 6 May 2011 11:28:37 -0500 Received: from lummox ([10.132.254.136]) by SBHFISLTCGW04.FNFIS.COM over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 6 May 2011 11:28:37 -0500 From: "Devin Teske" To: "'Warner Losh'" References: <65D3163B-427B-41F6-80B9-7BA4AF794939@vicor.com> Date: Fri, 6 May 2011 09:28:34 -0700 Message-ID: <8E70609FFACF4E48B83FB09C8E39FCA4@shxd.ath.cx> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 Thread-Index: AcwMA7K7VNdCU3XFQvKAswbaTW0UJAABiYNw X-OriginalArrivalTime: 06 May 2011 16:28:37.0589 (UTC) FILETIME=[A6E14850:01CC0C0A] Cc: freebsd-hackers@FreeBSD.org, 'Ivan Voras' Subject: RE: [UPDATE] New Boot-Loader Menu -- version 1.4 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2011 16:28:46 -0000 > -----Original Message----- > From: Warner Losh [mailto:imp@bsdimp.com] > Sent: Friday, May 06, 2011 8:31 AM > To: Devin Teske > Cc: 'Ivan Voras'; freebsd-hackers@FreeBSD.org > Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.4 > > > On May 5, 2011, at 7:21 PM, Devin Teske wrote: > > >> -----Original Message----- > >> From: owner-freebsd-hackers@freebsd.org [mailto:owner-freebsd- > >> hackers@freebsd.org] On Behalf Of Ivan Voras > >> Sent: Thursday, May 05, 2011 8:00 AM > >> To: freebsd-hackers@freebsd.org > >> Subject: Re: [UPDATE] New Boot-Loader Menu -- version 1.4 > >> > >> On 05/05/2011 15:40, Warren Block wrote: > >>> On Thu, 5 May 2011, Devin Teske wrote: > >>> > >>>> Running on i386-compatible hardware supporting ACPI: > >>>> B&W (standard): http://twitpic.com/4tlsin > >>>> Color (loader_color=YES): http://twitpic.com/4tlt6l > >>> > >>> Looks nice. Options 3, 4, and 5 could be changed to > >>> > >>> 3. Safe Mode > >>> 4. Single User Mode > >>> 5. Verbose > >>> > >>> On/Off or Enabled/Disabled might be bikeshedably better than Yes and > No. > >> > >> If we're going to nitpick, then the style of > >> > >> *Enable* Safe Mode : *YES | NO* > >> > >> may be even better :) While at it, I'd also suggest aligning the YES | > >> NO fields vertically for better readability. > >> > >> But these are minor suggestions, it is ok the way it is :) > >> > > > > Suggestions are good. I'm always open to them. Both are good > suggestions. > > > > It's with great undulating frivolity (think: Steve Ballmer or Billy > Mays) > > that I invite anyone to simply edit the decidedly Forth-free > /boot/menu.rc > > where the captions are configured simply as a series of carefully-named > > environment variables. If you find something you like, report back the > > values that you used and I'll test them out. If it's a definite > improvement, > > I'll definitely make the change. > > > > The current boot loader menu, you have to go mucking through Forth to > change > > the captions (which can be tricky with any stack-based language let > alone a > > reverse polish one such as FICL). > > In general, I really like things becoming more modular. For FreeNAS's > boot loader, I hacked a copy and put it as a patch to the FreeNAS > build.... > > Warner Awesome! Absolutely Fantastic! That's what the BSD license is all about! (although... maybe I should have released it under the Beerware license -- with a Guinuess clause, lol). -- Devin _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. _____________ From owner-freebsd-hackers@FreeBSD.ORG Fri May 6 20:19:43 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 228F2106566B; Fri, 6 May 2011 20:19:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id ED4FC8FC16; Fri, 6 May 2011 20:19:42 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id A457546B09; Fri, 6 May 2011 16:19:42 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id CCA268A02A; Fri, 6 May 2011 16:19:41 -0400 (EDT) From: John Baldwin To: freebsd-hackers@freebsd.org Date: Fri, 6 May 2011 16:19:38 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <4DC3BB5D.5080300@FreeBSD.org> In-Reply-To: <4DC3BB5D.5080300@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105061619.38596.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 06 May 2011 16:19:42 -0400 (EDT) Cc: Andriy Gapon Subject: Re: thread_lock vs panic/trap X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2011 20:19:43 -0000 On Friday, May 06, 2011 5:11:57 am Andriy Gapon wrote: > > Can a current thread panic or receive a trap while some other thread holds its > thread_lock (the same lock as pointed to by the td_lock)? I'm sure it's theoretically possible. If the thread is running just about anywhere and another thread is changing its cpuset for example, then you could run into this. > And a related question, can there be a reason for a thread in panic or kdb > context to try to get the thread_lock? I think it isn't safe to try to grab one's own thread lock in panic or kdb for this reason. -- John Baldwin From owner-freebsd-hackers@FreeBSD.ORG Fri May 6 23:34:20 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id C7D871065672; Fri, 6 May 2011 23:34:20 +0000 (UTC) Date: Fri, 6 May 2011 23:34:20 +0000 From: Alexander Best To: freebsd-hackers@freebsd.org Message-ID: <20110506233420.GA70885@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="45Z9DzgjV8m4Oswq" Content-Disposition: inline Subject: function typo in xfs sources X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2011 23:34:20 -0000 --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline hi there, while experimenting with 'gcc -Wmissing-declarations', i stumbled upon the following typo. it would be nice, if anybody could correct this. thanks in advance. alex -- a13x --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="xfs.patch" diff --git a/sys/gnu/fs/xfs/FreeBSD/support/kdb.c b/sys/gnu/fs/xfs/FreeBSD/support/kdb.c index 274f23d..b133dfe 100644 --- a/sys/gnu/fs/xfs/FreeBSD/support/kdb.c +++ b/sys/gnu/fs/xfs/FreeBSD/support/kdb.c @@ -56,7 +56,7 @@ kdb_getarea_size(void *res, unsigned long addr, size_t size) } int -db_putarea_size(unsigned long addr, void *res, size_t size) +kdb_putarea_size(unsigned long addr, void *res, size_t size) { return 0; } --45Z9DzgjV8m4Oswq-- From owner-freebsd-hackers@FreeBSD.ORG Sat May 7 17:44:55 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 27081106564A for ; Sat, 7 May 2011 17:44:55 +0000 (UTC) (envelope-from damjan.marion@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id B08258FC0C for ; Sat, 7 May 2011 17:44:54 +0000 (UTC) Received: by wyf23 with SMTP id 23so4011448wyf.13 for ; Sat, 07 May 2011 10:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:content-type:content-transfer-encoding :subject:date:message-id:to:mime-version:x-mailer; bh=IYZzue+FIKlVwJqZEgGGDFf7mc/poh2tdJZcidlvlBI=; b=D1xZGgBEO7IY1VyUGb0ednUUW6T9rtsp51+G+lPpL8ke212erTCS3b6QzkwgA16s0G IEOAUkVfiX/8KBm+LwbBijyW1EYoBlrdZPeFwpvKLbLMvQ2Ry0I5Jw5c5zdDHCEGXzHL cBTRcHK9cCnWi6AuMxl+nt2tVe3JyqNPPctkc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:content-type:content-transfer-encoding:subject:date:message-id :to:mime-version:x-mailer; b=KajUtHYASoVUrtzNUL/RgU5Og04vAbcayRBH2tew9biOIurIBtq9jZVrcYboza9OsU RnAe/MgxWJm1I6LjBmmAUFqnLX19rM8z/zPrOtyoPkenMGHruBNYRMGrailuFa4Y9x2Z CHBkgUzB/IXwWBxAN+IYTnLrpu9GJ0EvLij4g= Received: by 10.227.11.17 with SMTP id r17mr5219689wbr.6.1304788947720; Sat, 07 May 2011 10:22:27 -0700 (PDT) Received: from [192.168.123.4] (cpe-109-60-66-194.zg3.cable.xnet.hr [109.60.66.194]) by mx.google.com with ESMTPS id t16sm1690315wbg.23.2011.05.07.10.22.25 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 07 May 2011 10:22:25 -0700 (PDT) From: Damjan Marion Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Date: Sat, 7 May 2011 19:22:23 +0200 Message-Id: <34CF3ED0-52BC-4D0E-922A-FE26F624E77F@gmail.com> To: freebsd-hackers@freebsd.org Mime-Version: 1.0 (Apple Message framework v1084) X-Mailer: Apple Mail (2.1084) Subject: Embedded switch instead of stadard PHY X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 May 2011 17:44:55 -0000 Hi, I would like to implement support for embedded switch on WRT350Nv2 = router which is based on 88F5181L SoC (ARM). FreeBSD already have = support for embedded gigabit card (if_mge) but in case if this router = MAC is connected directly to 8-port ethernet chip (88E6131). If I use = MII_PHY_ANY scan founds following PHYs on miibus: mge0: mem 0xf1072000-0xf1073fff = irq 18,19,20,21,22 on simplebus0 miibus0: on mge0 e1000phy0: PHY 12 on miibus0 e1000phy0: id1=3D0x0141, id2=3D0x0c00=20 e1000phy1: PHY 13 on miibus0 e1000phy1: id1=3D0x0141, id2=3D0x0c00=20 e1000phy2: PHY 14 on miibus0 e1000phy2: id1=3D0x0141, id2=3D0x0c00=20 e1000phy3: PHY 15 on miibus0 e1000phy3: id1=3D0x0141, id2=3D0x0c00=20 ukphy0: PHY 20 on miibus0 ukphy0: =20 ukphy1: PHY 21 on miibus0 ukphy1: =20 ukphy2: PHY 22 on miibus0 ukphy2: =20 ukphy3: PHY 23 on miibus0 if_mge MAC is connected to port 3 of E6131 and port 3 acts in = reverse-GMII mode to simulate PHY side. Reason for output above is that E6131 uses non-standard registers on = multiple device addresses and on some of them mii_attach fails, and on = another it false detects PHY (20-23 above). I would like to hear form more experienced people how to implement this = properly, as it is obvious that it cannot be addressed with existing = routines. On linux this is implemented as dsa driver (Distributed Switch = Architecture) which supports several similar devices (net/dsa/*). Thanks in advance, Damjan=