From owner-freebsd-hackers@FreeBSD.ORG  Sun Aug 21 10:13:28 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A485D106566B;
	Sun, 21 Aug 2011 10:13:28 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id C26CB8FC15;
	Sun, 21 Aug 2011 10:13:27 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id NAA19412;
	Sun, 21 Aug 2011 13:13:26 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1Qv51x-0000qJ-K4; Sun, 21 Aug 2011 13:13:25 +0300
Message-ID: <4E50DA45.3010809@FreeBSD.org>
Date: Sun, 21 Aug 2011 13:13:25 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:6.0) Gecko/20110819 Thunderbird/6.0
MIME-Version: 1.0
To: Jung-uk Kim <jkim@FreeBSD.org>
References: <201107312128.29322.lobo@bsd.com.br>
	<201108011548.03059.jkim@FreeBSD.org>
	<4E370823.4000707@FreeBSD.org>
	<201108011706.14163.jkim@FreeBSD.org>
In-Reply-To: <201108011706.14163.jkim@FreeBSD.org>
X-Enigmail-Version: undefined
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@FreeBSD.org
Subject: Re: Phenom II 975 BE shows 0 celsius
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Aug 2011 10:13:28 -0000

on 02/08/2011 00:06 Jung-uk Kim said the following:
> On Monday 01 August 2011 04:10 pm, Andriy Gapon wrote:
>> on 01/08/2011 22:48 Jung-uk Kim said the following:
>>> I have mixed feeling about this because I own a system with such
>>> CPU/motherboard combo, too.  I also believe it works well but
>>> errata is errata.  If vendor says we shouldn't use it, then we
>>> shouldn't. In fact, I am just following Linux as an example here
>>> but I have no problem with turning this into a warning message,
>>> either.
>>
>> Let's cut a deal :-)
>> If we start using amdtemp for fan control, emergency system
>> shutdown or similar, then we follow the strict path.  Until then,
>> while we use amdtemp to amuse users with numbers, let's just print
>> a warning :-)
> 
> Okay, here is the new patch (not tested on the affected system yet):
> 
> http://people.freebsd.org/~jkim/amdtemp2.diff

Tested the patch - looks good!
One comment though: it seems that sensor_offset defaults to zero now.
Would it be a good idea to default it to what it previously used to be?
On my system the hardware reports the offset correctly (as verified by using
independent hardware monitoring logic in Super I/O), so defaulting it to zero is
kind of a regression.

-- 
Andriy Gapon