From owner-freebsd-mips@FreeBSD.ORG Mon Jun 20 17:24:01 2011 Return-Path: Delivered-To: mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00EE4106564A for ; Mon, 20 Jun 2011 17:24:01 +0000 (UTC) (envelope-from aduane@juniper.net) Received: from exprod7og107.obsmtp.com (exprod7og107.obsmtp.com [64.18.2.167]) by mx1.freebsd.org (Postfix) with ESMTP id 9A9A98FC16 for ; Mon, 20 Jun 2011 17:24:00 +0000 (UTC) Received: from P-EMHUB01-HQ.jnpr.net ([66.129.224.36]) (using TLSv1) by exprod7ob107.postini.com ([64.18.6.12]) with SMTP ID DSNKTf+CLw3Mr1Bx79MbusMShzogQsbtfI5G@postini.com; Mon, 20 Jun 2011 10:24:00 PDT Received: from p-emfe01-wf.jnpr.net (172.28.145.24) by P-EMHUB01-HQ.jnpr.net (172.24.192.35) with Microsoft SMTP Server (TLS) id 8.2.254.0; Mon, 20 Jun 2011 10:22:36 -0700 Received: from EMBX01-WF.jnpr.net ([fe80::1914:3299:33d9:e43b]) by p-emfe01-wf.jnpr.net ([fe80::d0d1:653d:5b91:a123%11]) with mapi; Mon, 20 Jun 2011 13:22:35 -0400 From: Andrew Duane To: "mips@freebsd.org" Date: Mon, 20 Jun 2011 13:22:31 -0400 Thread-Topic: Changes to cpu_mask in octeon_mp.c Thread-Index: AcwvbqNChYn5wReiQZGBNC2eeavQfw== Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-cr-puzzleid: {CDB5310F-05AD-41E5-B16F-00A2A828C317} x-cr-hashedpuzzle: AECG BAgc Bhag Bk9W BwBr ElhL E8Ct FswJ GDcK GXdp GrTD HRyV IBHY IQkk IqXZ JTqT; 1; bQBpAHAAcwBAAGYAcgBlAGUAYgBzAGQALgBvAHIAZwA=; Sosha1_v1; 7; {CDB5310F-05AD-41E5-B16F-00A2A828C317}; YQBkAHUAYQBuAGUAQABqAHUAbgBpAHAAZQByAC4AbgBlAHQA; Mon, 20 Jun 2011 17:22:32 GMT; QwBoAGEAbgBnAGUAcwAgAHQAbwAgAGMAcAB1AF8AbQBhAHMAawAgAGkAbgAgAG8AYwB0AGUAbwBuAF8AbQBwAC4AYwA= acceptlanguage: en-US MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Changes to cpu_mask in octeon_mp.c X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2011 17:24:01 -0000 I'm merging in some changes that were recently made to octeon_mp.c, and wan= t to clean it up. I had changed the platform_cpu_mask to return the Cavium = hardware register, rather than octeon_bootinfo->core_mask. This was part of= my cleanup to remove octeon_bootinfo from anywhere besides the boot code (= for bootstrap agnosticity). I was a little uncomfortable with returning ALL= cores that existed, in case core_mask was set to some sparse mask. I see i= n the log comments that this very topic was discussed. I can put in a check to see if octeon_bootinfo supplied a core_mask at boot= time, and mask the hardware register with that. IIRC, Cavium didn't really= say whether having non-contiguous cores was a possibility (e.g. a 12 core = CPU where 1 or 2 cores failed DVT and were masked out and sold as a 10-core= ). If this is a concern, I will figure something out for my octeon_mp.c; octeo= n_bootinfo will no longer exist outside the octeon_machdep.c file. BTW, Oleksandr had said he had committed my version, but the merge seems to= be broken here which indicates he didn't? ................................... Andrew Duane Juniper Networks o +1 978 589 0551 m +1 603-770-7088 aduane@juniper.net