From owner-freebsd-net@FreeBSD.ORG Sun Sep 4 02:15:47 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E4AD1065672; Sun, 4 Sep 2011 02:15:47 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from lauren.room52.net (lauren.room52.net [210.50.193.198]) by mx1.freebsd.org (Postfix) with ESMTP id 0EE818FC0A; Sun, 4 Sep 2011 02:15:46 +0000 (UTC) Received: from lstewart1.loshell.room52.net (ppp59-167-184-191.static.internode.on.net [59.167.184.191]) by lauren.room52.net (Postfix) with ESMTPSA id 0551D7E824; Sun, 4 Sep 2011 12:15:29 +1000 (EST) Message-ID: <4E62DF40.4020001@freebsd.org> Date: Sun, 04 Sep 2011 12:15:28 +1000 From: Lawrence Stewart User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:6.0.1) Gecko/20110903 Thunderbird/6.0.1 MIME-Version: 1.0 To: Andre Oppermann References: <1F95A4C2D54E4F369830143CBDB5FF86@multiplay.co.uk><4E37C0F2.4080004@freebsd.org><2B063B6D95AA4C27B004C50D96393F91@multiplay.co.uk><4E3AA66A.6060605@freebsd.org><20229216858044E4881642284F245750@multiplay.co.uk> <4E432CB2.3030700@freebsd.org> <177917182AAD46A3962139F22B835B37@multiplay.co.uk> <4E5AD893.7010708@freebsd.org> <4E5B785D.6000009@freebsd.org> In-Reply-To: <4E5B785D.6000009@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on lauren.room52.net Cc: freebsd-net@freebsd.org Subject: Re: tcp failing to recover from a packet loss under 8.2-RELEASE? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Sep 2011 02:15:47 -0000 Sorry for the delay in responding. On 08/29/11 21:30, Andre Oppermann wrote: > On 29.08.2011 02:08, Lawrence Stewart wrote: >> On 08/14/11 23:53, Steven Hartland wrote: >>> ----- Original Message ----- From: "Lawrence Stewart" >>> >>>> >>>> Here's my tweaked version of Andre's patch: >>>> http://people.freebsd.org/~lstewart/patches/misctcp/tcp_reass.c-logdebug%2bmissingsegment-20110811-lstewart.diff >>>> >>>> >>>> >>> >>> Still testing this and just noticed that the patch fails to >>> compile when INVARIANTS is enabled. The KASSERT calls need >>> ()'s around the split strings. >> >> oops, sorry. Compile tested on 8-STABLE without INVARIANTS enabled :/ >> >> Any further feedback with respect to the patch? Plan to submit it to >> re@ later this week for >> inclusion in 9.0. > > I'm not sure these excessive KASSERT's are really necessary. Probably one > covering those cases at the start of the function is sufficient. I don't see how the logic currently captured in the KASSERTs I've added could be easily captured in a single KASSERT at the top of the function. I also think KASSERTs are most usefully placed next to the code which is making the assumption you wish to sanity check. Could you please give me a few pointers as to what you had in mind? > I was about to send the original patch to re@ for approval as well now > that I'm back from vacation and fully available again. Don't mind if > you do it if you've got the time. I didn't realise you'd gone on holidays and planned to deal with this on your return so I already started a dialogue with re@ and might as well follow it through now. Cheers, Lawrence