From owner-freebsd-net@FreeBSD.ORG Sun Nov 20 00:47:20 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 315A1106566B; Sun, 20 Nov 2011 00:47:20 +0000 (UTC) (envelope-from bhutchings@solarflare.com) Received: from exchange.solarflare.com (mail.solarflare.com [216.237.3.220]) by mx1.freebsd.org (Postfix) with ESMTP id 0DA058FC08; Sun, 20 Nov 2011 00:47:19 +0000 (UTC) Received: from OCEX02.SolarFlarecom.com ([10.20.40.31]) by exchange.solarflare.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 19 Nov 2011 16:47:19 -0800 Received: from [192.168.4.185] (88.96.1.126) by webmail.SolarFlare.com (10.20.40.31) with Microsoft SMTP Server (TLS) id 14.1.339.1; Sat, 19 Nov 2011 16:47:18 -0800 Message-ID: <1321750026.2885.236.camel@deadeye> From: Ben Hutchings To: Philip Paeps Date: Sun, 20 Nov 2011 00:47:06 +0000 In-Reply-To: References: <1321652051.2883.76.camel@bwh-desktop> Organization: Solarflare Communications Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.3-2 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [88.96.1.126] X-TM-AS-Product-Ver: SMEX-8.0.0.1181-6.500.1024-18526.005 X-TM-AS-Result: No--23.460000-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-OriginalArrivalTime: 20 Nov 2011 00:47:19.0303 (UTC) FILETIME=[F4FD4170:01CCA71D] Cc: freebsd-net@freebsd.org, marius@freebsd.org Subject: Re: sfxge: Remove interrupt self-test code X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Nov 2011 00:47:20 -0000 On Sat, 2011-11-19 at 11:20 +0200, Philip Paeps wrote: > On 18 Nov 2011, at 23:34, Ben Hutchings wrote: > > sfxge: Remove interrupt self-test code > > > > It's not currently used; it didn't build on 32-bit and the previous > > build fix is incorrect. If we really implement self-tests we can do > > this again properly. > > Committed. Thanks! > > Have you had a chance to see if the driver still works on i386? If so, > I'll enable it again in the i386 build, now that it compiles again. I really need to find or set up a new test image with i386. But I can say that a quick test by running: make MACHINE=i386 MACHINE_CPUARCH=i386 CC='cc -m32' in sys/modules/sfxge now successfully compiles all object files (but the linker gives up due to mismatched architectures). Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.