From owner-freebsd-ports@FreeBSD.ORG  Sun Feb  6 00:33:43 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F0F931065679
	for <freebsd-ports@freebsd.org>; Sun,  6 Feb 2011 00:33:43 +0000 (UTC)
	(envelope-from freebsd-ports@m.gmane.org)
Received: from lo.gmane.org (lo.gmane.org [80.91.229.12])
	by mx1.freebsd.org (Postfix) with ESMTP id AAA738FC21
	for <freebsd-ports@freebsd.org>; Sun,  6 Feb 2011 00:33:43 +0000 (UTC)
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <freebsd-ports@m.gmane.org>) id 1PlsZQ-0007uc-PJ
	for freebsd-ports@freebsd.org; Sun, 06 Feb 2011 01:33:40 +0100
Received: from 189.61.208.111 ([189.61.208.111])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <freebsd-ports@freebsd.org>; Sun, 06 Feb 2011 01:33:40 +0100
Received: from kubito by 189.61.208.111 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <freebsd-ports@freebsd.org>; Sun, 06 Feb 2011 01:33:40 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: freebsd-ports@freebsd.org
From: Raphael Kubo da Costa <kubito@gmail.com>
Date: Sat, 05 Feb 2011 22:33:25 -0200
Lines: 41
Message-ID: <8762syroh6.fsf@gmail.com>
References: <AANLkTimtuCRzdk4MjWH2KaQTHHPsYqenq94f3Eiu+UdW@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
X-Complaints-To: usenet@dough.gmane.org
X-Gmane-NNTP-Posting-Host: 189.61.208.111
User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (berkeley-unix)
Cancel-Lock: sha1:cl6VmqnObwz6mHT19GiQui4Qroo=
Subject: Re: Call for testers: projectM comes to FreeBSD! [re ports/152823]
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Feb 2011 00:33:44 -0000

Chris Rees <utisoft@gmail.com> writes:

> Anyone interested can grab them and test them out! I've tried them on
> i386, they work great; feedback is most welcome.

In both ports I see that you manually add ${LOCALBASE}/include and
${LOCALBASE}/lib to CFLAGS. In theory, that shouldn't be necessary.

Unfortunately, projectM does not seem to be a very good CMake citizen:
it should have a FindGLEW.cmake file responsible for finding GLEW's
libraries and includes, so that it later can just do something along
these lines:

  include_directories(${GLEW_INCLUDE_DIR})
  target_link_libraries(foo ${GLEW_LIBRARIES})

Also, it shouldn't even have a copy of FindFreetype2.cmake lying around
(which should also render one of the sed's you use in post-path
unnecessary), as CMake itself has had FindFreetype.cmake for quite a
long time.

Do you know if upstream is aware of these issues?

Another question related to libprojectM: does it really need to install
Vera.ttf instead of using the system-wide one from
x11-fonts/bitstream-vera? Or is it a different font which happens to
have the same name?

As for projectm-libvisual:

Do you also need to set CFLAGS here too?

+post-patch:
+	@${FIND} ${WRKSRC} -name "*.[hc]*" | ${XARGS} ${REINPLACE_CMD} \
+		-e 's#<libvisual#<libvisual-${LIBVISUAL_VER}/libvisual#g'

Is this really needed? It seems to be fairly intrusive.

+ @${REINPLACE_CMD} -e '/return NULL/d' ${WRKSRC}/actor_projectM.cpp

Is this one from upstream? If so, isn't it better to put it in files/?