From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Aug 28 00:00:33 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F09DB1065676 for ; Sun, 28 Aug 2011 00:00:32 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5798C8FC1E for ; Sun, 28 Aug 2011 00:00:30 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p7S00UlP005250 for ; Sun, 28 Aug 2011 00:00:30 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p7S00U1e005249; Sun, 28 Aug 2011 00:00:30 GMT (envelope-from gnats) Resent-Date: Sun, 28 Aug 2011 00:00:30 GMT Resent-Message-Id: <201108280000.p7S00U1e005249@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Mikhail T." Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2411106564A for ; Sat, 27 Aug 2011 23:56:21 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 99E578FC15 for ; Sat, 27 Aug 2011 23:56:21 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p7RNuLVF044089 for ; Sat, 27 Aug 2011 23:56:21 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p7RNuLuo044088; Sat, 27 Aug 2011 23:56:21 GMT (envelope-from nobody) Message-Id: <201108272356.p7RNuLuo044088@red.freebsd.org> Date: Sat, 27 Aug 2011 23:56:21 GMT From: "Mikhail T." To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/160245: [PATCH] net/libvncserver optionsify gnutls and gcrypt support X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Aug 2011 00:00:33 -0000 >Number: 160245 >Category: ports >Synopsis: [PATCH] net/libvncserver optionsify gnutls and gcrypt support >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Aug 28 00:00:29 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Mikhail T. >Release: 8.2 >Organization: >Environment: FreeBSD red8.2-RELEASE-p2 FreeBSD 8.2-RELEASE-p2 #0 r223806: Fri Aug 26 03:29:57 MSD 2011 root@red:/usr/obj/usr/src/sys/XGATE amd64 >Description: - OPTIONSify gnutls and gcrypt support to prevent configure detect them itself - Make portlint happy >How-To-Repeat: Install gnutls/gcrypt first, then libvncserver (it will be linked against gnutls/gcrypt without any actual dependency). So deinstalling gnutls/gcrypt will result in unusable libvncserver (tested by VBoxHeadless -n). >Fix: Patch attached with submission follows: Index: Makefile =================================================================== RCS file: /home/ncvs/ports/net/libvncserver/Makefile,v retrieving revision 1.14 diff -u -r1.14 Makefile --- Makefile 11 Aug 2011 19:19:47 -0000 1.14 +++ Makefile 27 Aug 2011 23:39:32 -0000 @@ -22,10 +22,29 @@ USE_GNOME= gnomehack USE_LDCONFIG= yes GNU_CONFIGURE= yes -CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \ - LDFLAGS="-L${LOCALBASE}/lib" +CPPFLAGS= "-I${LOCALBASE}/include" +LDFLAGS= "-L${LOCALBASE}/lib" CONFIGURE_ARGS= --without-x +OPTIONS= GNUTLS "Adds GnuTLS support" Off \ + GCRYPT "Adds Libgcrypt support" Off + +.include + +.if defined(WITH_GNUTLS) +LIB_DEPENDS+= gnutls.0:${PORTSDIR}/security/gnutls +CONFIGURE_ARGS+= --with-gnutls +.else +CONFIGURE_ARGS+= --without-gnutls +.endif + +.if defined(WITH_GCRYPT) +LIB_DEPENDS+= gcrypt.0:${PORTSDIR}/security/libgcrypt +CONFIGURE_ARGS+= --with-gcrypt +.else +CONFIGURE_ARGS+= --without-gcrypt +.endif + post-patch: @${REINPLACE_CMD} -e \ 's|-lpthread|${PTHREAD_LIBS}|g' ${WRKSRC}/configure >Release-Note: >Audit-Trail: >Unformatted: