From owner-freebsd-rc@FreeBSD.ORG Mon Mar 14 11:07:08 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 07DAD106564A for ; Mon, 14 Mar 2011 11:07:08 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E93B78FC12 for ; Mon, 14 Mar 2011 11:07:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p2EB77EF002662 for ; Mon, 14 Mar 2011 11:07:07 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p2EB77uY002660 for freebsd-rc@FreeBSD.org; Mon, 14 Mar 2011 11:07:07 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 14 Mar 2011 11:07:07 GMT Message-Id: <201103141107.p2EB77uY002660@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2011 11:07:08 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/154554 rc [rc.d] [patch] statd and lockd fail to start o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/152784 rc services provide himself instead providing class of se o conf/151063 rc [rc.subr] Verify network link and packet flow before s o conf/150752 rc [rc.subr] [patch] be not needed to eval $_pidcmd on re o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145445 rc [rc.d] error in /etc/rc.d/jail (bad logic) o conf/145440 rc [rc.d] [patch] add multiple fib support (setfib) in /e o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145344 rc [patch] Fix kitchen sink approach for rc.d scripts ins o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/144213 rc [rc.d] [patch] Disappearing zvols on reboot o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances o conf/143084 rc [jail] [patch]: fix rc.d/jail creating stray softlinks o conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141907 rc [rc.d] Bug if mtu (maybe others?) is set as first argu o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/141275 rc [request] dhclient(8) rc script should print something o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip o conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137629 rc [rc.d] background_dhclient rc.conf option causing doub o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/135338 rc [rc.d] pf startup order seems broken [regression] o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped p bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 92 problems total. From owner-freebsd-rc@FreeBSD.ORG Fri Mar 18 01:24:43 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C8011065677 for ; Fri, 18 Mar 2011 01:24:43 +0000 (UTC) (envelope-from Harlan.Stenn@pfcs.com) Received: from gwc.pfcs.com (gwc.pfcs.com [70.88.151.226]) by mx1.freebsd.org (Postfix) with ESMTP id 465C38FC0C for ; Fri, 18 Mar 2011 01:24:43 +0000 (UTC) Received: from spike.pfcs.com (localhost.pfcs.com [127.0.0.1]) by gwc.pfcs.com (Postfix) with ESMTP id 1DE4E28438; Thu, 17 Mar 2011 21:05:33 -0400 (EDT) To: freebsd-rc@freebsd.org From: Harlan Stenn X-Face: "csXK}xnnsH\h_ce`T#|pM]tG, 6Xu.{3Rb\]&XJgVyTS'w{E+|-(}n:c(Cc* $cbtusxDP6T)Hr'k&zrwq0.3&~bAI~YJco[r.mE+K|(q]F=ZNXug:s6tyOk{VTqARy0#axm6BWti9C d X-Mailer: MH-E 7.4.2; nmh 1.2; XEmacs 21.4 (patch 22) Mime-Version: 1.0 (generated by tm-edit 1.8) Content-Type: text/plain; charset=US-ASCII Date: Thu, 17 Mar 2011 21:05:33 -0400 Sender: Harlan.Stenn@pfcs.com Message-Id: <20110318010533.1DE4E28438@gwc.pfcs.com> Cc: Harlan.Stenn@pfcs.com Subject: RC system and monit X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2011 01:24:43 -0000 I'm starting to use 'monit' at more sites, to monitor essential services and restart them if there is a problem. The thing is, monit uses the existing RC framework to start and stop these services, so when a machine is first started the RC system we have both the RC and monit starting these services, and I have seen things get Ugly (processes abort while there are multiple simultaneous attempts to start them, with the result that monit stops trying and the processes do not get started). I figure there are several ways to crack this problem, and I'd bet that other folks have thought about it already and might even have solutions. Harlan From owner-freebsd-rc@FreeBSD.ORG Fri Mar 18 01:59:06 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCE10106566C for ; Fri, 18 Mar 2011 01:59:06 +0000 (UTC) (envelope-from Harlan.Stenn@pfcs.com) Received: from gwc.pfcs.com (gwc.pfcs.com [70.88.151.226]) by mx1.freebsd.org (Postfix) with ESMTP id B69D18FC17 for ; Fri, 18 Mar 2011 01:59:06 +0000 (UTC) Received: from spike.pfcs.com (localhost.pfcs.com [127.0.0.1]) by gwc.pfcs.com (Postfix) with ESMTP id 1E3882844C; Thu, 17 Mar 2011 21:59:06 -0400 (EDT) To: Brandon Gooch In-reply-to: References: <20110318010533.1DE4E28438@gwc.pfcs.com> Comments: In-reply-to Brandon Gooch message dated "Thu, 17 Mar 2011 20:52:12 -0500." X-Mailer: MH-E 7.4.2; nmh 1.2; XEmacs 21.4 (patch 22) Mime-Version: 1.0 (generated by tm-edit 1.8) Content-Type: text/plain; charset=US-ASCII Date: Thu, 17 Mar 2011 21:59:06 -0400 From: Harlan Stenn Message-Id: <20110318015906.1E3882844C@gwc.pfcs.com> Cc: freebsd-rc@freebsd.org, Harlan Stenn Subject: Re: RC system and monit X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2011 01:59:07 -0000 Thanks Brandon, I'll check that out. H From owner-freebsd-rc@FreeBSD.ORG Fri Mar 18 02:18:19 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E309106564A for ; Fri, 18 Mar 2011 02:18:19 +0000 (UTC) (envelope-from jamesbrandongooch@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id BCCFC8FC1E for ; Fri, 18 Mar 2011 02:18:18 +0000 (UTC) Received: by wyf23 with SMTP id 23so3667389wyf.13 for ; Thu, 17 Mar 2011 19:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ZnrvEO8JCk+KghB5+xHcHvHN/L14zl2B5phOLdk0sto=; b=f1WyDW/xN+Cf/SkrnibS8gp9Uz4oyiKpgwHGnT16VdA+tRUKoqJwZfz+YaFfY56BPn TazDc9mpA0i5M7PrdXdbFAyi01vWAY3B5tIPUplehPr11+QokvS7QCadc/mP5TqIKae9 rVOrMnLTAELVyvmU0dBp2XXefwieWBAupS05E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=hknBDvP3V6qMKpPJAWV92WK/ItYq87YbOJpL0lTCflwD03hlUH1A8vRvEHSIq3M6Ta j1Jn35de4c2xb8zggP7DAKBlQM8dlbu4jFjW00cpbvG3yaKilMVYfgEJQZtFLD/o2nFx ipp214QZa7ZZTqymMb0/j3P+NGVN9HlQHsq/Y= MIME-Version: 1.0 Received: by 10.216.221.14 with SMTP id q14mr1646153wep.49.1300413132576; Thu, 17 Mar 2011 18:52:12 -0700 (PDT) Received: by 10.216.72.207 with HTTP; Thu, 17 Mar 2011 18:52:12 -0700 (PDT) In-Reply-To: <20110318010533.1DE4E28438@gwc.pfcs.com> References: <20110318010533.1DE4E28438@gwc.pfcs.com> Date: Thu, 17 Mar 2011 20:52:12 -0500 Message-ID: From: Brandon Gooch To: Harlan Stenn Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-rc@freebsd.org Subject: Re: RC system and monit X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2011 02:18:19 -0000 On Thu, Mar 17, 2011 at 8:05 PM, Harlan Stenn wrote: > I'm starting to use 'monit' at more sites, to monitor essential services > and restart them if there is a problem. > > The thing is, monit uses the existing RC framework to start and stop > these services, so when a machine is first started the RC system we have > both the RC and monit starting these services, and I have seen things > get Ugly (processes abort while there are multiple simultaneous attempts > to start them, with the result that monit stops trying and the processes > do not get started). > > I figure there are several ways to crack this problem, and I'd bet that > other folks have thought about it already and might even have solutions. > > Harlan While not as feature-rich as monit, have you heard about the fsc utility? http://www.freebsd.org/news/status/report-2010-10-2010-12.html#FreeBSD-Services-Control-%28fsc%29 There is a port in progress as well: http://people.freebsd.org/~trhodes/fsc/fsc-port.tar It integrates well with the base system (as it is hoped to one day become a part of). It may be a viable alternative to monit in your situation... -Brandon From owner-freebsd-rc@FreeBSD.ORG Fri Mar 18 15:47:13 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32A1C106564A for ; Fri, 18 Mar 2011 15:47:13 +0000 (UTC) (envelope-from trhodes@FreeBSD.org) Received: from hapkido.dreamhost.com (hapkido.dreamhost.com [66.33.216.122]) by mx1.freebsd.org (Postfix) with ESMTP id 1A0668FC0A for ; Fri, 18 Mar 2011 15:47:12 +0000 (UTC) Received: from homiemail-a28.g.dreamhost.com (caiajhbdcahe.dreamhost.com [208.97.132.74]) by hapkido.dreamhost.com (Postfix) with ESMTP id 84FFE17CF5A for ; Fri, 18 Mar 2011 08:27:43 -0700 (PDT) Received: from homiemail-a28.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a28.g.dreamhost.com (Postfix) with ESMTP id 871A71B4058; Fri, 18 Mar 2011 08:27:42 -0700 (PDT) Received: from fbsdlab.fbsdsecure.org (ip72-219-240-45.dc.dc.cox.net [72.219.240.45]) (Authenticated sender: trhodes@fbsdsecure.org) by homiemail-a28.g.dreamhost.com (Postfix) with ESMTPA id 01FC71B4009; Fri, 18 Mar 2011 08:27:41 -0700 (PDT) Date: Fri, 18 Mar 2011 11:27:42 -0400 From: Tom Rhodes To: Harlan Stenn Message-Id: <20110318112742.715b3464.trhodes@FreeBSD.org> In-Reply-To: <20110318015906.1E3882844C@gwc.pfcs.com> References: <20110318010533.1DE4E28438@gwc.pfcs.com> <20110318015906.1E3882844C@gwc.pfcs.com> X-Mailer: Sylpheed version 1.0.6 (GTK+ 1.2.10; i386-portbld-freebsd8.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: RC system and monit X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2011 15:47:13 -0000 On Thu, 17 Mar 2011 21:59:06 -0400 Harlan Stenn wrote: > Thanks Brandon, I'll check that out. > > H Meant to follow up but Brandon beat me to it. The current way fscd handles processes that die is try, give up. It won't go into a vicious loop attempting to restart something that is just failing. It will also log the event (stop reason, attempt to start, success||fail) so you can check messages. I've thought about coming up with a method to plug this into Nagios but I just moved into a new place and have a TON of work to do. But I love to hear feedback, even if I don't get back with you right away. Cheers, -- Tom Rhodes From owner-freebsd-rc@FreeBSD.ORG Sat Mar 19 01:41:04 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EA520106566C for ; Sat, 19 Mar 2011 01:41:04 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.49.45]) by mx1.freebsd.org (Postfix) with ESMTP id 998DA8FC08 for ; Sat, 19 Mar 2011 01:41:04 +0000 (UTC) Received: by syn.atarininja.org (Postfix, from userid 1001) id D1D495C3F; Fri, 18 Mar 2011 21:31:55 -0400 (EDT) Date: Fri, 18 Mar 2011 21:31:55 -0400 From: Wesley Shields To: freebsd-rc@FreeBSD.org Message-ID: <20110319013155.GB39929@atarininja.org> References: <20110319012959.GA39929@atarininja.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline In-Reply-To: <20110319012959.GA39929@atarininja.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Re: status cleanup X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Mar 2011 01:41:05 -0000 --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 18, 2011 at 09:29:59PM -0400, Wesley Shields wrote: > A co-worker noticed that the pf rc script has 'status' listed twice when > run without any arguments. The attached patch fixes that and two other > cases where this also happens. I've only tested the pf changes. I'd > appreciate a review of this and maybe a commit? I can file a PR if it > would make people feel better. > > I'm not subscribed to this list so I would appreciate being CC'ed on any > replies. > > -- WXS This time with the patch attached, or you can get it at: http://people.freebsd.org/~wxs/rc-status-cleanup.diff -- WXS --ZGiS0Q5IWpPtfppv-- From owner-freebsd-rc@FreeBSD.ORG Sat Mar 19 01:46:04 2011 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A9080106566B for ; Sat, 19 Mar 2011 01:46:04 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.49.45]) by mx1.freebsd.org (Postfix) with ESMTP id 8B6018FC0A for ; Sat, 19 Mar 2011 01:46:04 +0000 (UTC) Received: by syn.atarininja.org (Postfix, from userid 1001) id 82E1E5C3D; Fri, 18 Mar 2011 21:29:59 -0400 (EDT) Date: Fri, 18 Mar 2011 21:29:59 -0400 From: Wesley Shields To: freebsd-rc@FreeBSD.org Message-ID: <20110319012959.GA39929@atarininja.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Subject: status cleanup X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Mar 2011 01:46:04 -0000 A co-worker noticed that the pf rc script has 'status' listed twice when run without any arguments. The attached patch fixes that and two other cases where this also happens. I've only tested the pf changes. I'd appreciate a review of this and maybe a commit? I can file a PR if it would make people feel better. I'm not subscribed to this list so I would appreciate being CC'ed on any replies. -- WXS