From owner-freebsd-rc@FreeBSD.ORG Sun Mar 20 04:11:03 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 97AD4106566B; Sun, 20 Mar 2011 04:11:03 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 45D498FC08; Sun, 20 Mar 2011 04:11:02 +0000 (UTC) Received: by iyj12 with SMTP id 12so6357254iyj.13 for ; Sat, 19 Mar 2011 21:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:cc:subject:in-reply-to :message-id:references:user-agent:x-openpgp-key-id :x-openpgp-key-fingerprint:mime-version:content-type; bh=+DY9BpaMhrieRCcwg3wcFLrTDEYsf5E7/zBmVNoE330=; b=Rg7g8c40BK9I8gvjgSwTTSHiZQPI1+gyCAMdA3uqvrxk4iniy+5lnSHaPzHVZfl5kg TJp1rKmMvfHrfaBq+vGfWCnbzx3jNZWWwqKSz4ZqltUoLAnjJYZtqTE1a7uM5SOFk0st C6Vo2YMt3nEnxpQiMd85N3yshWpulMw1Z3M5w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:x-openpgp-key-id:x-openpgp-key-fingerprint:mime-version :content-type; b=KApOZvdmxCEKeCIUfhie7cUBxSn4h2eYEd9bT6yMSzTSQMKQprfZjD8LZ9jiX7CWXo JknSjq7ndlZICpc3OoT1ZlnBrJRea8rWa+4ZQ39nWkBiAUo6u0jc16Kxzyoo9hjxf+76 yXJWz7JcTr8S1EpDAYvHdwVwox4tkUKGQ8mU4= Received: by 10.231.143.129 with SMTP id v1mr2729320ibu.78.1300592800644; Sat, 19 Mar 2011 20:46:40 -0700 (PDT) Received: from disbatch.dataix.local (adsl-99-181-154-144.dsl.klmzmi.sbcglobal.net [99.181.154.144]) by mx.google.com with ESMTPS id 14sm2681240ibo.63.2011.03.19.20.46.38 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 19 Mar 2011 20:46:39 -0700 (PDT) Sender: "J. Hellenthal" Date: Sat, 19 Mar 2011 23:46:23 -0400 From: "J. Hellenthal" To: Wesley Shields In-Reply-To: <20110319013155.GB39929@atarininja.org> Message-ID: References: <20110319012959.GA39929@atarininja.org> <20110319013155.GB39929@atarininja.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="80310268-1944442781-1300592799=:3999" Cc: freebsd-rc@freebsd.org Subject: Re: status cleanup X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Mar 2011 04:11:03 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --80310268-1944442781-1300592799=:3999 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Fri, 18 Mar 2011 21:31, wxs@ wrote: > On Fri, Mar 18, 2011 at 09:29:59PM -0400, Wesley Shields wrote: >> A co-worker noticed that the pf rc script has 'status' listed twice when >> run without any arguments. The attached patch fixes that and two other >> cases where this also happens. I've only tested the pf changes. I'd >> appreciate a review of this and maybe a commit? I can file a PR if it >> would make people feel better. >> >> I'm not subscribed to this list so I would appreciate being CC'ed on any >> replies. >> > > This time with the patch attached, or you can get it at: > > http://people.freebsd.org/~wxs/rc-status-cleanup.diff > While on this subject since it has to do with status messages I might as well take a moment and share the following patch [1] that changes the stupid "Enabling pfpf enabled" & "Disabling pfpf disabled" messages. 1. http://patches.jhell.googlecode.com/hg/pf-rc-startstop.patch - -- Regards, J. Hellenthal (0x89D8547E) JJH48-ARIN -----BEGIN PGP SIGNATURE----- Comment: THIS SOFTWARE AND/OR CONTENTS IS PROVIDED BY THE AUTHOR ``AS IS'' AND Comment: ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE Comment: IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR Comment: PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY Comment: DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL Comment: DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS Comment: OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) Comment: HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, Comment: STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING Comment: IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE Comment: POSSIBILITY OF SUCH DAMAGE. iQEcBAEBAgAGBQJNhXiYAAoJEJBXh4mJ2FR+CKAH/296rcCVoYDH3pUqwentnUHR 2T4ocIbJ+76/z/HgCl257sV3iWGhrQxPy/LbcEGPZ1JrxyhTtyfAPMO4uG8I95sO R3mlA6fBtt5PVOexPuPRIIjmjK4zUBQimRreUCRDng+AyKxoi+/pIwAiaSBnUitD PdCeHHNvotB4zffjc9Kq1KJol9hyhwpzMnHBPywQ8NKgt1mETNYUrdUbLBBjCdgP KkDIlMy2/pzi6garrPdW02G8fV4co9jLha0zWZmVo2oOy7/iUrdnbT8URY5l7EfU /fkQFPmTwTq9OGi5WBuvX581S0F2n6xlVjoP3hcEGeSSPNw1t+qMebLeUvveJXk= =MiOn -----END PGP SIGNATURE----- --80310268-1944442781-1300592799=:3999 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=pf-rc-startstop.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Start Stop Status relief. Content-Disposition: attachment; filename=pf-rc-startstop.patch IyBIRyBjaGFuZ2VzZXQgcGF0Y2gNCiMgUGFyZW50IDc1MjgzNzZiYmM3YmRl YWU2NDJlMzFjYmEyYmRiM2U1MjkzMGM2NGINCkZpeHVwIHBmIHN0YXJ0L3N0 b3AgbWVzc2FnZXMgb24gdGhlIGNvbnNvbGUsIEVuYWJsaW5nIHBmcGYgZW5h YmxlZA0KDQpkaWZmIC1yIDc1MjgzNzZiYmM3YiBldGMvcmMuZC9wZg0KLS0t IGEvZXRjL3JjLmQvcGYNCisrKyBiL2V0Yy9yYy5kL3BmDQpAQCAtMjUsNyAr MjUsNyBAQA0KIA0KIHBmX3N0YXJ0KCkNCiB7DQotCWNoZWNrX3N0YXJ0bXNn cyAmJiBlY2hvIC1uICdFbmFibGluZyBwZicNCisJY2hlY2tfc3RhcnRtc2dz ICYmIGVjaG8gLW4gJ0VuYWJsaW5nIHBmOiAnDQogCSRwZl9wcm9ncmFtIC1G IGFsbCA+IC9kZXYvbnVsbCAyPiYxDQogCSRwZl9wcm9ncmFtIC1mICIkcGZf cnVsZXMiICRwZl9mbGFncw0KIAlpZiAhICRwZl9wcm9ncmFtIC1zIGluZm8g fCBncmVwIC1xICJFbmFibGVkIiA7IHRoZW4NCkBAIC0zNyw3ICszNyw3IEBA DQogcGZfc3RvcCgpDQogew0KIAlpZiAkcGZfcHJvZ3JhbSAtcyBpbmZvIHwg Z3JlcCAtcSAiRW5hYmxlZCIgOyB0aGVuDQotCQllY2hvIC1uICdEaXNhYmxp bmcgcGYnDQorCQllY2hvIC1uICdEaXNhYmxpbmcgcGY6ICcNCiAJCSRwZl9w cm9ncmFtIC1kDQogCQllY2hvICcuJw0KIAlmaQ0K --80310268-1944442781-1300592799=:3999--