From owner-freebsd-sparc64@FreeBSD.ORG Mon Nov 28 11:07:29 2011 Return-Path: Delivered-To: freebsd-sparc64@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F19D71065672 for ; Mon, 28 Nov 2011 11:07:29 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CF7178FC13 for ; Mon, 28 Nov 2011 11:07:29 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pASB7TjQ042953 for ; Mon, 28 Nov 2011 11:07:29 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pASB7TIk042937 for freebsd-sparc64@FreeBSD.org; Mon, 28 Nov 2011 11:07:29 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 28 Nov 2011 11:07:29 GMT Message-Id: <201111281107.pASB7TIk042937@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-sparc64@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-sparc64@FreeBSD.org X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2011 11:07:30 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o sparc/162513 sparc64 mpt(4), mptutil(8) reports variable, erroneous drive i f sparc/145211 sparc64 [panic] Memory modified after free o sparc/142102 sparc64 [nfs] [panic] FreeBSD 8.0 kernel panics on sparc64 whe o sparc/141918 sparc64 [ehci] ehci_interrupt: unrecoverable error, controller s sparc/139134 sparc64 kernel output corruption f sparc/108732 sparc64 ping(8) reports 14 digit time on sparc64 s sparc/107087 sparc64 [hang] system is hung during boot from CD o sparc/105048 sparc64 [trm] trm(4) panics on sparc64 o sparc/104428 sparc64 [nullfs] nullfs panics on E4500 (but not E420) o sparc/80890 sparc64 [panic] kmem_malloc(73728): kmem_map too small running o sparc/71729 sparc64 printf in kernel thread causes panic on SPARC 11 problems total. From owner-freebsd-sparc64@FreeBSD.ORG Fri Dec 2 14:05:45 2011 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00974106568B; Fri, 2 Dec 2011 14:05:45 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 3EA0F8FC18; Fri, 2 Dec 2011 14:05:44 +0000 (UTC) Received: by faak28 with SMTP id k28so2909566faa.13 for ; Fri, 02 Dec 2011 06:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=PysOqB/e4zHYSRyNSMThYRjPBTyB9Jw+KWHgy/YX1JY=; b=jvgk4MUzF8KyKasorBQTN/9SOXwehxBd6BEc7LQYcx7peQIZAKBhsv/+wguv2fKQuP Zz5tIHbBI62w5DjAzUC+P540vSFYso+O9Wwr8iv/Osd2EVssCuk2Mu0VNEzBRJXkAhKj UH2bJx2VBlaJbQXJqGOb1UiwvjoQS55ll/EBE= MIME-Version: 1.0 Received: by 10.180.96.166 with SMTP id dt6mr9759843wib.47.1322832945131; Fri, 02 Dec 2011 05:35:45 -0800 (PST) Sender: c.jayachandran@gmail.com Received: by 10.216.20.67 with HTTP; Fri, 2 Dec 2011 05:35:45 -0800 (PST) Date: Fri, 2 Dec 2011 19:05:45 +0530 X-Google-Sender-Auth: bqsKpIfnvIAbWHvgD_8mbil46Vg Message-ID: From: "Jayachandran C." To: freebsd-sparc64@freebsd.org Content-Type: multipart/mixed; boundary=f46d04427272caaff004b31c0b65 Cc: marius@freebsd.org Subject: [PATCH] fix OF_finddevice return value checks on sparc64 X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2011 14:05:45 -0000 --f46d04427272caaff004b31c0b65 Content-Type: text/plain; charset=ISO-8859-1 While going thru the OF_finddevice usage in kernel (to fix up the FDT interface) I noticed that a few calls made to OF_finddevice in sparc64 does not check the return value correctly. The error return is -1 not 0, and since the value is unsigned, checking it for '< 0' does not work either. The attached patch fixes this. Regards, JC. --f46d04427272caaff004b31c0b65 Content-Type: text/x-patch; charset=US-ASCII; name="sparc64-of-finddev-fixes.patch" Content-Disposition: attachment; filename="sparc64-of-finddev-fixes.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gvp8ltsr0 SW5kZXg6IHN5cy9zcGFyYzY0L3NwYXJjNjQvdm1fbWFjaGRlcC5jCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5 cy9zcGFyYzY0L3NwYXJjNjQvdm1fbWFjaGRlcC5jCShyZXZpc2lvbiAyMjgxOTcpCisrKyBzeXMv c3BhcmM2NC9zcGFyYzY0L3ZtX21hY2hkZXAuYwkod29ya2luZyBjb3B5KQpAQCAtMzY4LDcgKzM2 OCw3IEBACiAJCShjZWxsX3QpYnNwZWMKIAl9OwogCi0JaWYgKChjaG9zZW4gPSBPRl9maW5kZGV2 aWNlKCIvY2hvc2VuIikpICE9IDApIHsKKwlpZiAoKGNob3NlbiA9IE9GX2ZpbmRkZXZpY2UoIi9j aG9zZW4iKSkgIT0gLTEpIHsKIAkJaWYgKE9GX2dldHByb3AoY2hvc2VuLCAiYm9vdHBhdGgiLCBi c3BlYywgc2l6ZW9mKGJzcGVjKSkgPT0gLTEpCiAJCQlic3BlY1swXSA9ICdcMCc7CiAJCWJzcGVj W3NpemVvZihic3BlYykgLSAxXSA9ICdcMCc7CkluZGV4OiBzeXMvc3BhcmM2NC9zcGFyYzY0L29m d19tYWNoZGVwLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lzL3NwYXJjNjQvc3BhcmM2NC9vZndfbWFjaGRl cC5jCShyZXZpc2lvbiAyMjgxOTcpCisrKyBzeXMvc3BhcmM2NC9zcGFyYzY0L29md19tYWNoZGVw LmMJKHdvcmtpbmcgY29weSkKQEAgLTUyLDcgKzUyLDcgQEAKIAlwaGFuZGxlX3Qgbm9kZTsKIAlz dHJ1Y3QgaWRwcm9tIGlkcDsKIAotCWlmICgobm9kZSA9IE9GX2ZpbmRkZXZpY2UoIi9vcHRpb25z IikpID4gMCAmJgorCWlmICgobm9kZSA9IE9GX2ZpbmRkZXZpY2UoIi9vcHRpb25zIikpICE9IC0x ICYmCiAJICAgIE9GX2dldHByb3Aobm9kZSwgImxvY2FsLW1hYy1hZGRyZXNzPyIsIGJ1Ziwgc2l6 ZW9mKGJ1ZikpID4gMCkgewogCQlidWZbc2l6ZW9mKGJ1ZikgLSAxXSA9ICdcMCc7CiAJCWlmIChz dHJjbXAoYnVmLCAidHJ1ZSIpID09IDAgJiYK --f46d04427272caaff004b31c0b65-- From owner-freebsd-sparc64@FreeBSD.ORG Fri Dec 2 15:36:43 2011 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CE2E81065677; Fri, 2 Dec 2011 15:36:43 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 40F948FC17; Fri, 2 Dec 2011 15:36:42 +0000 (UTC) Received: by wgbdr11 with SMTP id dr11so1377281wgb.31 for ; Fri, 02 Dec 2011 07:36:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=S+yqAU1ZwS3FAfgu5VQNN2RySflGJNC++YZlBzo1Ke8=; b=Yk2lNKWcfrKoJ3L7onmC48cpPhSFIK2tg0qnOCVxvpbX0Q6mgRvvIxCbXCWDcCqsvp qROIXhynwfowqqs1F+8e1yM7uxcOuhkO8wxcjJcvGWYPFtTudALtwXXdw9B2GcIJcJMO OgOhKJe5JOgHO5AXjHYSEwo/bzAHNYsDBIv3g= MIME-Version: 1.0 Received: by 10.216.134.96 with SMTP id r74mr619254wei.43.1322840202166; Fri, 02 Dec 2011 07:36:42 -0800 (PST) Sender: c.jayachandran@gmail.com Received: by 10.216.20.67 with HTTP; Fri, 2 Dec 2011 07:36:42 -0800 (PST) In-Reply-To: References: Date: Fri, 2 Dec 2011 21:06:42 +0530 X-Google-Sender-Auth: namLLvuuFaxk5KJ1_rn3dgtuVO4 Message-ID: From: "Jayachandran C." To: freebsd-sparc64@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: marius@freebsd.org Subject: Re: [PATCH] fix OF_finddevice return value checks on sparc64 X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2011 15:36:43 -0000 On Fri, Dec 2, 2011 at 7:05 PM, Jayachandran C. wrot= e: > While going thru the OF_finddevice usage in kernel (to fix up the FDT > interface) I noticed that =A0a few calls made to OF_finddevice in > sparc64 does not check the return value correctly. > > The error return is -1 not 0, and since the value is unsigned, > checking it for '< 0' does not work either. =A0The attached patch fixes > this. I had not planned to commit this yet, but it has gone in with the related changes in r228201. Let me know if there are any objections - I can revert or check in further changes if needed. Thanks, JC. From owner-freebsd-sparc64@FreeBSD.ORG Fri Dec 2 15:58:10 2011 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CF681106564A for ; Fri, 2 Dec 2011 15:58:10 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id 68CF68FC0C for ; Fri, 2 Dec 2011 15:58:10 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id pB2Fw6d5072412; Fri, 2 Dec 2011 16:58:09 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.4/8.14.4/Submit) id pB2Fw6bY072411; Fri, 2 Dec 2011 16:58:06 +0100 (CET) (envelope-from marius) Date: Fri, 2 Dec 2011 16:58:06 +0100 From: Marius Strobl To: "Jayachandran C." Message-ID: <20111202155805.GB60194@alchemy.franken.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: freebsd-sparc64@freebsd.org Subject: Re: [PATCH] fix OF_finddevice return value checks on sparc64 X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2011 15:58:10 -0000 On Fri, Dec 02, 2011 at 09:06:42PM +0530, Jayachandran C. wrote: > On Fri, Dec 2, 2011 at 7:05 PM, Jayachandran C. wrote: > > While going thru the OF_finddevice usage in kernel (to fix up the FDT > > interface) I noticed that ?a few calls made to OF_finddevice in > > sparc64 does not check the return value correctly. > > > > The error return is -1 not 0, and since the value is unsigned, > > checking it for '< 0' does not work either. ?The attached patch fixes > > this. > > I had not planned to commit this yet, but it has gone in with the > related changes in r228201. Let me know if there are any objections - > I can revert or check in further changes if needed. > It's okay. It would be nice if you could MFC these changes down to stable/8 once stable/9 is open again. Marius