From owner-freebsd-usb@FreeBSD.ORG  Sun Oct 30 20:18:44 2011
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7CAD81065674;
	Sun, 30 Oct 2011 20:18:44 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe06.c2i.net [212.247.154.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 6650F8FC0C;
	Sun, 30 Oct 2011 20:18:43 +0000 (UTC)
X-T2-Spam-Status: No, hits=-0.2 required=5.0 tests=ALL_TRUSTED,
	BAYES_50
Received: from [188.126.198.129] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe06.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 196809555; Sun, 30 Oct 2011 21:18:41 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: Pawel Jakub Dawidek <pjd@freebsd.org>
Date: Sun, 30 Oct 2011 21:15:40 +0100
User-Agent: KMail/1.13.5 (FreeBSD/8.2-STABLE; KDE/4.4.5; amd64; ; )
References: <4EA9127E.80504@entel.upc.edu>
	<201110290851.15130.hselasky@c2i.net>
	<20111029183807.GF1713@garage.freebsd.pl>
In-Reply-To: <20111029183807.GF1713@garage.freebsd.pl>
X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq,NwSZ4V"
	=?iso-8859-1?q?=7CLR=2E+tj=7Dg5=0A=09=25V?=,x^qOs~mnU3]Gn;
	cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC(
	=?iso-8859-1?q?=0A=09=3AAuzV9=3A=2EhESm-x4h240C=609=3Dw?=
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201110302115.40450.hselasky@c2i.net>
Cc: freebsd-usb@freebsd.org
Subject: Re: Quirk for a USB mass storage device
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Oct 2011 20:18:44 -0000

On Saturday 29 October 2011 20:38:07 Pawel Jakub Dawidek wrote:
> > +     err = usbd_do_request(udev, NULL, &req, &buf);
> > +     if (err)
> > +             buf = 0;
> > +
> > +     return (buf);
> > +}
> 
> You could drop 'err' variable and just check function return directly.
> There is only one extra empty line at the begining of the function.

No, because there is &buf.

I'll add your device to the device quirk list.

--HPS