From owner-freebsd-arch@FreeBSD.ORG Sun Dec 9 15:13:04 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5D7B74B9; Sun, 9 Dec 2012 15:13:04 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) by mx1.freebsd.org (Postfix) with ESMTP id 161B38FC08; Sun, 9 Dec 2012 15:13:03 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.17]) by ltcfislmsgpa03.fnfis.com (8.14.5/8.14.5) with ESMTP id qB9FD2ve028417 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sun, 9 Dec 2012 09:13:02 -0600 Received: from [10.0.0.102] (10.14.152.61) by smtp.fisglobal.com (10.132.206.17) with Microsoft SMTP Server (TLS) id 14.2.309.2; Sun, 9 Dec 2012 09:13:01 -0600 Subject: Re: PR conf/121064 -- [patch] sys/boot/forth -- Use ASCII characters for box/line characters in frames.4th MIME-Version: 1.0 (Apple Message framework v1283) From: Devin Teske In-Reply-To: Date: Sun, 9 Dec 2012 07:12:59 -0800 Message-ID: <2599CA42-6700-4451-A67A-9610863D829F@fisglobal.com> References: To: X-Mailer: Apple Mail (2.1283) X-Originating-IP: [10.14.152.61] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.9.8185, 1.0.431, 0.0.0000 definitions=2012-12-09_05:2012-12-07,2012-12-09,1970-01-01 signatures=0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Adrian Chadd , Devin Teske , Garrett Cooper X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Devin Teske List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Dec 2012 15:13:04 -0000 Appears to be no objections. As I move forward with reviewed/tested commit, would like to document what = I tested (for posterity): 1. boot_serial=3D" " 2. boot_serial=3D"abc" 3. boot_serial=3D"YES" All produce the new serial-compatible frames. 4. console=3D"comconsole" 5. console=3D"vidconsole comconsole" 6. console=3D" vidconsole comconsole2 comconsole " Also produce the new serial-compatible frames. 7. console=3D"vidconsole comconsole2" 8. console=3D"spinconsole" 9. console=3D"vidconsole" 10. boot_serial=3D"" 11. boot_multicons=3D"" Produce the old serial UN-friendly frames (as expected) 12. boot_multicons=3D"1" 13. boot_multicons=3D"YES" Both of which produce serial friendly frames. In-addition, I also unit-tested the "contains?" function for several hours,= making sure it works as-expected. --=20 Devin On Dec 7, 2012, at 4:43 PM, Devin Teske wrote: > Hi -arch, >=20 > Eitan brought PR conf/121064 to my attention. >=20 > This particular PR appears to be ~5 years old and addresses an ~10 year o= ld issue introduced by SVN r115410 >=20 > Below is the commit message and patch that I'm proposing to commit for th= is PR (also, I amended said patch to the PR audit trail; see conf/121064). >=20 > I asked gcooper to review the working/tested patch. >=20 > Here's a before/after shot (courtesy of jh) -- against 9.0-R: >=20 > http://twitpic.com/bjxfcz >=20 > Please let me know if you have any objections, feature-requests, nagging = feelings, etc. > --=20 > Cheers, > Devin >=20 > =3D=3D=3D >=20 > Use ASCII characters for box/line characters in frames.4th >=20 > Committed with changes to support the following from loader.conf(5): > + console=3D"vidconsole comconsole" (not just console=3D"comconsole") > + boot_serial=3D"anything" (not just boot_serial=3D"YES") > + boot_multicons=3D"anything" (unsupported in originally-submitted patch) >=20 > PR: conf/121064 > Submitted by: koitsu > Reviewed by: gcooper, adrian (co-mentor) [pending your review] > Approved by: adrian (co-mentor) [pending your approval] > Obtained from: > MFC after: > Security: > --This line, and those below, will be ignored-- >> Description of fields to fill in above: 76 columns -= -| >> PR: If a GNATS PR is affected by the change. >> Submitted by: If someone else sent in the change. >> Reviewed by: If someone else reviewed your modification. >> Approved by: If you needed approval for this commit. >> Obtained from: If the change is from a third party. >> MFC after: N [day[s]|week[s]|month[s]]. Request a reminder email. >> Security: Vulnerability reference (one per line) or description. >> Empty fields above will be automatically removed. >=20 > M forth/support.4th > M forth/frames.4th >=20 > _____________ > The information contained in this message is proprietary and/or confident= ial. If you are not the intended recipient, please: (i) delete the message = and all copies; (ii) do not disclose, distribute or use the message in any = manner; and (iii) notify the sender immediately. In addition, please be awa= re that any message addressed to our domain is subject to archiving and rev= iew by persons other than the intended recipient. Thank you. > _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.