From owner-freebsd-arm@FreeBSD.ORG Sun Aug 12 00:18:32 2012 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 39F5F106564A for ; Sun, 12 Aug 2012 00:18:32 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from smtp5.clear.net.nz (smtp5.clear.net.nz [203.97.33.68]) by mx1.freebsd.org (Postfix) with ESMTP id F2D658FC08 for ; Sun, 12 Aug 2012 00:18:31 +0000 (UTC) Received: from mxin2-orange.clear.net.nz (lb2-srcnat.clear.net.nz [203.97.32.237]) by smtp5.clear.net.nz (CLEAR Net Mail) with ESMTP id <0M8M0039O8UO7E40@smtp5.clear.net.nz> for freebsd-arm@freebsd.org; Sun, 12 Aug 2012 12:18:24 +1200 (NZST) Received: from 202-0-48-19.paradise.net.nz (HELO localhost) ([202.0.48.19]) by smtpin2.paradise.net.nz with ESMTP; Sun, 12 Aug 2012 12:18:24 +1200 Date: Sun, 12 Aug 2012 12:18:10 +1200 From: Andrew Turner In-reply-to: <1344717708.1186.20.camel@revolution.hippie.lan> To: Ian Lepore Message-id: <20120812121810.0f8e301a@fubar.geek.nz> MIME-version: 1.0 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; i386-portbld-freebsd8.1) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Pirate: Arrrr References: <50256231.3030008@bluezbox.com> <1344717708.1186.20.camel@revolution.hippie.lan> Cc: "freebsd-arm@FreeBSD.org" Subject: Re: projects/armv6 merge X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Aug 2012 00:18:32 -0000 On Sat, 11 Aug 2012 14:41:48 -0600 Ian Lepore wrote: > files: sys/arm/lpc/lpc_machdep.c sys/arm/mv/mv_machdep.c > description: > Add missing brace. Comment out definition of proc0_tf, because it's > already defined in arm/machdep.c. > > Maybe it's the definition in arm/machdep.c that has to go, but if so > then a whole lot of other _machdep.c files need to have the > definition added. They were moved from _machdep.c to arm/marchdep.c as part of cleaning up duplicate code in initarm. You can remove them from _machdep.c. initarm() should then call init_proc0(). The mv version appears correct, however neither the lpc and tegra versions call init_proc0() and should be fixed. Andrew