From owner-freebsd-bugs@FreeBSD.ORG Sun Aug 19 07:30:09 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7259B1065673 for ; Sun, 19 Aug 2012 07:30:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 327068FC0A for ; Sun, 19 Aug 2012 07:30:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q7J7U9r0087598 for ; Sun, 19 Aug 2012 07:30:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q7J7U9fv087597; Sun, 19 Aug 2012 07:30:09 GMT (envelope-from gnats) Resent-Date: Sun, 19 Aug 2012 07:30:09 GMT Resent-Message-Id: <201208190730.q7J7U9fv087597@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Marcelo Araujo Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D8762106566B for ; Sun, 19 Aug 2012 07:27:27 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id C3E618FC0A for ; Sun, 19 Aug 2012 07:27:27 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7J7RR8f030874 for ; Sun, 19 Aug 2012 07:27:27 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q7J7RRSk030873; Sun, 19 Aug 2012 07:27:27 GMT (envelope-from nobody) Message-Id: <201208190727.q7J7RRSk030873@red.freebsd.org> Date: Sun, 19 Aug 2012 07:27:27 GMT From: Marcelo Araujo To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/170763: [zfs] 3085 zfs diff panics, then panics in a loop on booting X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2012 07:30:09 -0000 >Number: 170763 >Category: kern >Synopsis: [zfs] 3085 zfs diff panics, then panics in a loop on booting >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Aug 19 07:30:08 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Marcelo Araujo >Release: 10.0-CURRENT >Organization: FreeBSD >Environment: FreeBSD hostb 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r233530: Tue Apr 3 02:11:40 UTC 2012 araujo@hostb:/usr/obj/usr/src/sys/HOSTB i386 >Description: - Just import a small change from Illumos vendor. Illumos-gate changeset: 2579580ac955 >How-To-Repeat: >Fix: Patch attached with submission follows: Index: dsl_dataset.c =================================================================== --- dsl_dataset.c (revision 233530) +++ dsl_dataset.c (working copy) @@ -3896,6 +3896,10 @@ VERIFY(error == 0 || error == ENOENT); zapobj = ds->ds_phys->ds_userrefs_obj; VERIFY(0 == zap_remove(mos, zapobj, ra->htag, tx)); + + spa_history_log_internal_ds(ds, "release", tx, + "tag = %s refs now = %lld", ra->htag, (longlong_t)refs); + if (ds->ds_userrefs == 0 && ds->ds_phys->ds_num_children == 1 && DS_IS_DEFER_DESTROY(ds)) { struct dsl_ds_destroyarg dsda = {0}; Index: spa_history.c =================================================================== --- spa_history.c (revision 233530) +++ spa_history.c (working copy) @@ -436,8 +436,10 @@ * If this is part of creating a pool, not everything is * initialized yet, so don't bother logging the internal events. */ - if (tx->tx_txg == TXG_INITIAL) + if (tx->tx_txg == TXG_INITIAL) { + fnvlist_free(nvl); return; + } va_copy(adx2, adx); >Release-Note: >Audit-Trail: >Unformatted: