From owner-freebsd-hackers@FreeBSD.ORG Sun Oct 28 03:08:30 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 61EC5181; Sun, 28 Oct 2012 03:08:30 +0000 (UTC) (envelope-from hiren.panchasara@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 470578FC08; Sun, 28 Oct 2012 03:08:28 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id jf20so1670926bkc.13 for ; Sat, 27 Oct 2012 20:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=PN6YYrBuXwEz5044mLOLnhRINxQRioHHQxKNTOrIQ4Q=; b=bb/Bxrv2VQAeGoNXd7iMcin4gg3ffcwImk1gYgM6idnViehklNS3Xvn0rOVlSO5cLi cjqWYyT3PDVgfe5V6IOOlw1rH+umafFx71mIxUCE5sd4iA+7AiLkTax+QAOqhaiQ5ZiK qTspgUhVbQv8BJQNxB97SFegCrHxu4QaTr1ukixNl56OcVNp2SVzvR3dTNYPhoY5rPqI u3bZtwEfLtyyPgDEtVaQC7t6QMp+Z59KoaZjcQ9NHiRdCjHIvMU3hkF8jwkZWWuvlJ+9 FJd2ncOLjOvhryMG2w8ANnWo26q4rXjN+DaXZu539KvSAg4yLrerp1otX7DXp0gZVB5s LpDA== MIME-Version: 1.0 Received: by 10.204.131.75 with SMTP id w11mr8448420bks.111.1351393708073; Sat, 27 Oct 2012 20:08:28 -0700 (PDT) Received: by 10.205.83.197 with HTTP; Sat, 27 Oct 2012 20:08:28 -0700 (PDT) In-Reply-To: <508C61C1.8090109@FreeBSD.org> References: <508C61C1.8090109@FreeBSD.org> Date: Sat, 27 Oct 2012 20:08:28 -0700 Message-ID: Subject: Re: Porting patch(1) from NetBSD to FreeBSD (was Re: FreeBSD in Google Code-In 2012? You can help too!) From: hiren panchasara To: Pedro Giffuni Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Chris Rees , freebsd-hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2012 03:08:30 -0000 On Sat, Oct 27, 2012 at 3:35 PM, Pedro Giffuni wrote: > Hello Hiren; > > > > On 10/27/2012 16:48, hiren panchasara wrote: > > + Sean, who has been helping me. > > On Sat, Oct 27, 2012 at 2:31 PM, Chris Rees wrote: > >> On 27 October 2012 22:17, hiren panchasara >> wrote: >> > [removing the CC list] >> > >> > On Wed, Oct 24, 2012 at 3:36 PM, Pedro Giffuni wrote= : >> > >> >> (cc'ing -ports and cutting most of the rest) >> >> >> >> > From: Eitan Adler >> >> .> >> >> >On 24 October 2012 13:24, Fernando Apestegu=C3=ADa wrote: >> >> >> Also related to that, what about writing a section about redports[= 1] >> >> >> in the porter's handbook[2]? >> >> > >> >> >This is a good documentation task... but we need more *coding* tasks >> as >> >> well. >> >> > >> >> >> >> We do need to port and test patch (1) from NetBSD or DragonFly to >> replace >> >> GNU patch, and this shouldn't be difficult. >> >> >> > >> > Hi Pedro / List, >> > >> > I am not part of google summer of code but I've tried to port patch(1) >> from >> > NetBSD into FreeBSD head. I hope that is okay. >> > >> > Patching was trivial and It _seems_ to be working fine. >> > >> > I would appreciate any ideas around how to test the changes and how to >> > proceed further. >> >> Have you a patch :)? You're right, there shouldn't have been many >> changes needed. >> > > Will prepare a patch and post here as soon as I get a chance :-) > > > This is great news Hiren, Thanks! > > > The stress test for this utility is the ports tree but before that we hav= e > to > know what will change. > Thanks Pedro! I will have a lot of questions as I am a newbie here. :-) > > What needs to be done is: > > 1- Compare the options between our old patch and the new BSD patch. > Will do. > 2- Document this in FreeBSD's wiki. > I think this needs to be done when we are done deciding on diffs and how the changes look, right? Also, I do not think I have write access to the wiki. > 3- Prepare a port for testing. > Does this need to be a port? I thought this would live in /src/usr.bin/patch. Also, I believe this will co-exist with current gnu patch(1). Is that a right assumption? Thank you, Hiren > > Unfortunately I will be very busy for more than a month and I can't > help much but I am sure some other committer will love to follow > on this. > > Thanks for taking the initiative, that's what FreeBSD needs! > > Pedro. > >