From owner-freebsd-jail@FreeBSD.ORG  Sun Nov 11 12:30:32 2012
Return-Path: <owner-freebsd-jail@FreeBSD.ORG>
Delivered-To: jail@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 422C543A;
 Sun, 11 Nov 2012 12:30:32 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
 [209.85.214.54])
 by mx1.freebsd.org (Postfix) with ESMTP id 56FF18FC0A;
 Sun, 11 Nov 2012 12:30:31 +0000 (UTC)
Received: by mail-bk0-f54.google.com with SMTP id jm19so1081532bkc.13
 for <multiple recipients>; Sun, 11 Nov 2012 04:30:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=hT6roMBV3d2CmUVito96hiFaTqUhYHDq4sQNgk2YHPw=;
 b=GjVC6y1lrLs+bwEh3k692tGuOsQSZYcelHpKwlvU7DsaYWvP1MGhfeG0zGQjIGbIA8
 LAfAJc6SDnAfYkD9c8DqwZvXyPxGJy6GzJZNNdpphl5uPDaxRtZRR6P/mn4Lm40JrcE+
 4VicyMvkUnUaWmEdeR4oVnmq/zGGO7buXQrWESRqj4b5i0MAHen3EHRmbOxoXzd0KLvV
 ydpvsQJrcCspJk+bR7a4d1JlPKC4pgKupw7PIyDfRUax2tKUN+FfIn7Bvpl2/vh8qkib
 hPmWU5sEeE68cwxdNmJBqISbWT+8Gz8/9ZPYx4NjB9moik2EeIWiNJEYyrGEZfpE26JZ
 TRnw==
MIME-Version: 1.0
Received: by 10.204.147.212 with SMTP id m20mr989243bkv.103.1352637030211;
 Sun, 11 Nov 2012 04:30:30 -0800 (PST)
Received: by 10.204.50.197 with HTTP; Sun, 11 Nov 2012 04:30:30 -0800 (PST)
In-Reply-To: <CADLo83-L-GuuK_aqyzNEriRMJsDczroujt5kHHazKDh_4qWeyw@mail.gmail.com>
References: <CADLo83-L-GuuK_aqyzNEriRMJsDczroujt5kHHazKDh_4qWeyw@mail.gmail.com>
Date: Sun, 11 Nov 2012 12:30:30 +0000
Message-ID: <CADLo839pJxZuw2k0kMCAtVh7PTEcF4gbjM2p1Fd9hf71OZmKhg@mail.gmail.com>
Subject: Re: jail: unknown parameter: ip6.addr
From: Chris Rees <utisoft@gmail.com>
To: jail@freebsd.org, "freebsd-rc@freebsd.org" <freebsd-rc@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Eitan Adler <eadler@freebsd.org>
X-BeenThere: freebsd-jail@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion about FreeBSD jail\(8\)" <freebsd-jail.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-jail>,
 <mailto:freebsd-jail-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-jail>
List-Post: <mailto:freebsd-jail@freebsd.org>
List-Help: <mailto:freebsd-jail-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-jail>,
 <mailto:freebsd-jail-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Nov 2012 12:30:32 -0000

On 10/11/2012, Chris Rees <utisoft@gmail.com> wrote:
> [adding rc@, please keep me CCd as I'm not in jail@]
>
> On Thu, 2012-11-08 at 02:27 +0100, Mateusz Guzik wrote:
>> On Wed, Nov 07, 2012 at 03:39:26PM -0500, Mike Jakubik wrote:
>> > Hello,
>> >
>> > I just updated a server to latest stable and my jails no longer start,
>> > troubleshooting the startup script shows us that the parameter ip6.addr
>> > is unknown, this system is compiled without INET6.
>> [..]
>> > + tail +2 /tmp/jail.PJ5ji3QH/jail.8101
>> > jail: unknown parameter: ip6.addr
>>
>> Try this (lightly tested):
>> http://people.freebsd.org/~mjg/patches/rc-jail-ip-arg.diff
>>
>> Basically the idea is to pass ip4.addr and ip6.addr only when respective
>> addresses are specified in configuration.
>
>
> Since we've had confirmation that the patch works, a much faster way
> is to use sh's variable substitution magic, which also means a much
> smaller change:
>
> -            ip4.addr=\"${_addrl}\" ip6.addr=\"${_addr6l}\"
> ${_parameters} command=${_exec_start} > ${_tmp_jail} 2>&1 \
> +            ${_addrl:+ip4.addr=\"${_addrl}\"}
> ${_addr6l:+ip6.addr=\"${_addr6l}\"} ${_parameters}
> command=${_exec_start} > ${_tmp_jail} 2>&1 \
>
> I'll get a patch together later
>

Patch as promised-- please would you test and confirm?

http://www.bayofrum.net/~crees/patches/rc-jail-ip-arg-shvars.diff

Chris