From owner-freebsd-multimedia@FreeBSD.ORG  Sun Oct 28 12:28:05 2012
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C7C1A3F1
 for <freebsd-multimedia@freebsd.org>; Sun, 28 Oct 2012 12:28:05 +0000 (UTC)
 (envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe06.c2i.net [212.247.154.162])
 by mx1.freebsd.org (Postfix) with ESMTP id 48A878FC0A
 for <freebsd-multimedia@freebsd.org>; Sun, 28 Oct 2012 12:28:04 +0000 (UTC)
X-T2-Spam-Status: No, hits=-0.2 required=5.0 tests=ALL_TRUSTED,
	BAYES_50
Received: from [176.74.213.204] (account mc467741@c2i.net HELO
 laptop015.hselasky.homeunix.org)
 by mailfe06.swip.net (CommuniGate Pro SMTP 5.4.4)
 with ESMTPA id 336486750; Sun, 28 Oct 2012 13:22:57 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: sox-devel@lists.sourceforge.net
Subject: Bug in sox-14.3.2/src/oss.c
Date: Sun, 28 Oct 2012 13:24:36 +0100
User-Agent: KMail/1.13.7 (FreeBSD/9.1-PRERELEASE; KDE/4.8.4; amd64; ; )
X-Face: 'mmZ:T{)),Oru^0c+/}w'`gU1$ubmG?lp!=R4Wy\ELYo2)@'UZ24N@
 =?utf-8?q?d2+AyewRX=7DmAm=3BYp=0A=09=7CU=5B?=@,
 _z/([?1bCfM{_"B<.J>mICJCHAzzGHI{y7{%JVz%R~yJHIji`y>
 =?utf-8?q?Y=7Dk1C4TfysrsUI=0A=09-=25GU9V5=5DiUZF=26nRn9mJ=27=3F=26?=>O
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201210281324.36923.hselasky@c2i.net>
Cc: freebsd-multimedia@freebsd.org
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Oct 2012 12:28:05 -0000

Hi,

Line buffering should be off, but this statement leads to SOX reading 1 and 
one byte from the recording DSP device under FreeBSD:

    /* Change to non-buffered I/O */
    setvbuf(ft->fp, NULL, _IONBF, sizeof(char) * file->size);
    return(SOX_SUCCESS);

I think this flag should be used instead:

           _IOFBF  fully buffered

I've tested this change and it works like expected.

Any comments?

--HPS