From owner-freebsd-rc@FreeBSD.ORG Sun Oct 14 13:19:23 2012 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 69973836; Sun, 14 Oct 2012 13:19:23 +0000 (UTC) (envelope-from crees@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [8.8.178.135]) by mx1.freebsd.org (Postfix) with ESMTP id 3B8858FC14; Sun, 14 Oct 2012 13:19:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q9EDJNeQ085447; Sun, 14 Oct 2012 13:19:23 GMT (envelope-from crees@freefall.freebsd.org) Received: (from crees@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q9EDJN6H085443; Sun, 14 Oct 2012 13:19:23 GMT (envelope-from crees) Date: Sun, 14 Oct 2012 13:19:23 GMT Message-Id: <201210141319.q9EDJN6H085443@freefall.freebsd.org> To: crees@FreeBSD.org, freebsd-doc@FreeBSD.org, freebsd-rc@FreeBSD.org From: crees@FreeBSD.org Subject: Re: docs/172692: [PATCH] Bring parts of the rc scripting guides up to date X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Oct 2012 13:19:23 -0000 Synopsis: [PATCH] Bring parts of the rc scripting guides up to date Responsible-Changed-From-To: freebsd-doc->freebsd-rc Responsible-Changed-By: crees Responsible-Changed-When: Sun Oct 14 13:19:15 UTC 2012 Responsible-Changed-Why: What do you guys think? http://www.freebsd.org/cgi/query-pr.cgi?pr=172692 From owner-freebsd-rc@FreeBSD.ORG Mon Oct 15 11:06:14 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0B18E516 for ; Mon, 15 Oct 2012 11:06:14 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [8.8.178.135]) by mx1.freebsd.org (Postfix) with ESMTP id CD4CA8FC25 for ; Mon, 15 Oct 2012 11:06:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q9FB6Dg5011590 for ; Mon, 15 Oct 2012 11:06:13 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q9FB6D1L011589 for freebsd-rc@FreeBSD.org; Mon, 15 Oct 2012 11:06:13 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 15 Oct 2012 11:06:13 GMT Message-Id: <201210151106.q9FB6D1L011589@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2012 11:06:14 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). From owner-freebsd-rc@FreeBSD.ORG Mon Oct 15 16:29:17 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F0FE0C33; Mon, 15 Oct 2012 16:29:16 +0000 (UTC) (envelope-from mmakonnen@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 896278FC17; Mon, 15 Oct 2012 16:29:15 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id jf20so2455542bkc.13 for ; Mon, 15 Oct 2012 09:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=K+PmAWI21Q9X4IpqP2F0aE7XCj7uHVMo+GgHW0yi4VQ=; b=VuRncBNznEc0xidZZd0Nf6qb7X1j+4Vr8KdssJvnNdSOYvPDpLKa1POZrn75a8Jadd 71beq6CqBZvlgURygSfPYm1UTrjNiP0WapZWGXSuJIkbCDfW2gXZmu/vF0HURfmpdizY tUeBzisFL+oRc0Rm5enO2AJvXXV1lV3b1wvTQaS+K1+yvQcy8F6myp1+WoOF55AtLgMp isAxcsgN1C1XR0GRALXGMYGWufw5gi7uqtflqS57OPMxP6fXlCiqgUs++2ZqgEfQWgCQ IIMUJ0mEHB6RfJP4eznsCWKtP/IaSNUm6155NfRaxKg0KF0o9QkVcPIY+Ou+EJ8oq/mY qR2g== Received: by 10.204.156.74 with SMTP id v10mr3360483bkw.39.1350318554320; Mon, 15 Oct 2012 09:29:14 -0700 (PDT) Received: from [192.168.8.158] ([213.55.110.254]) by mx.google.com with ESMTPS id k21sm9008882bkv.1.2012.10.15.09.29.07 (version=SSLv3 cipher=OTHER); Mon, 15 Oct 2012 09:29:09 -0700 (PDT) Message-ID: <507C39D0.9030909@gmail.com> Date: Mon, 15 Oct 2012 19:29:04 +0300 From: Michael Telahun Makonnen User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: crees@FreeBSD.org Subject: Re: docs/172692: [PATCH] Bring parts of the rc scripting guides up to date References: <201210141319.q9EDJN6H085443@freefall.freebsd.org> In-Reply-To: <201210141319.q9EDJN6H085443@freefall.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-doc@FreeBSD.org, freebsd-rc@FreeBSD.org, freebsd-bugs@freebsd.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2012 16:29:17 -0000 Some minor nits: @@ -479,7 +479,7 @@ The names of all &man.rc.conf.5; variables used exclusively by our script must - have the same prefix: ${name}. For + have the same prefix: ${name}_. For example: dummy_mode, dummy_state_file, and so on. You should add the same correction to the very next sentence, which reads: Note: While it is possible to use a shorter name internally, e.g., just msg, adding the unique prefix ${name} to all global names introduced by our script will save us from possible collisions with the rc.subr(8) namespace. @@ -491,15 +491,6 @@ our script will save us from possible collisions with the &man.rc.subr.8; namespace. - As long as an &man.rc.conf.5; variable and its - internal equivalent are the same, we can use a more - compact expression to set the default value: - - : ${dummy_msg:="Nothing started."} - - The current style is to use the more verbose form - though. - Not sure why you felt this paragraph needed to be removed. @@ -512,7 +503,11 @@ Here we use dummy_msg to actually - control our script, i.e., to emit a variable message. + control our script, i.e., to emit a variable message. + Use of a shell function is overkill here, since it only + runs a single command; an equally valid alternative is: + + start_cmd="echo \"$dummy_msg\"" While you are technically correct, I think you misunderstood the writer's intent, which was to show how an rc.conf(8) variable can be used in a subroutine to control the behavior of the command. I agree that the example isn't a very good one (in that it doesn't depict a valid use case), but I think the "spirit" is correct. Maybe you can suggest a better example? Cheers, Mike. From owner-freebsd-rc@FreeBSD.ORG Mon Oct 15 18:26:24 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 801B64AF; Mon, 15 Oct 2012 18:26:24 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 84FA58FC08; Mon, 15 Oct 2012 18:26:23 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id jf20so2509831bkc.13 for ; Mon, 15 Oct 2012 11:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=reF4HHTd1bsQtr661ZFZetPFyPe4dwr8teIHf5f86w0=; b=Y8yENwnPkUvVdXm4WqwrmEtMbgaMwLH8z2zOBqDxq+Cb1MdVtjoY6Rpx49IyHw9zG+ 8lmk2l7XlcCO4alkwDxX31MZvQDJFxm8OuZe3W6K4waTPv8sK1IV+WdOi0PUIzhVz7Ki bv9WZ71d4yfcsXoSYovGjBhKYC3WBTMfS192srg6sMG5xFqDzgm5Ejmf+PlFJE46ZNj0 bkmtujZg2F7VDjgQ9fUt19JYbz1rbakk7Vbc2fqD9lKjUSplehfXpxLyM5pRTzWXPX1t 5A1jZJOYYsCZ3/MdzsUfWyMjRDUWr+8vWOTwn1oHeZ0sd8fVpUjiHuWZE26BFm7ojdIb i/Ug== MIME-Version: 1.0 Received: by 10.204.7.213 with SMTP id e21mr3345963bke.32.1350325582578; Mon, 15 Oct 2012 11:26:22 -0700 (PDT) Sender: utisoft@gmail.com Received: by 10.204.50.197 with HTTP; Mon, 15 Oct 2012 11:26:22 -0700 (PDT) In-Reply-To: <507C39D0.9030909@gmail.com> References: <201210141319.q9EDJN6H085443@freefall.freebsd.org> <507C39D0.9030909@gmail.com> Date: Mon, 15 Oct 2012 19:26:22 +0100 X-Google-Sender-Auth: FEIK7E_ngwIE_l8Jb5vcpP7FuEs Message-ID: Subject: Re: docs/172692: [PATCH] Bring parts of the rc scripting guides up to date From: Chris Rees To: Michael Telahun Makonnen Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-doc@freebsd.org, freebsd-rc@freebsd.org, freebsd-bugs@freebsd.org, "bug-followup@freebsd.org" X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2012 18:26:24 -0000 On 15/10/2012, Michael Telahun Makonnen wrote: > Some minor nits: > > - have the same prefix: ${name}. For > + have the same prefix: ${name}_. For > > You should add the same correction to the very next sentence, which reads: > > Note: While it is possible to use a shorter name internally, e.g., just Done, thanks! > > > @@ -491,15 +491,6 @@ > our script will save us from possible > collisions with the &man.rc.subr.8; namespace. > > - As long as an &man.rc.conf.5; variable and its > - internal equivalent are the same, we can use a more > - compact expression to set the default value: > - > - : ${dummy_msg:="Nothing > started."} > - > - The current style is to use the more verbose form > - though. > - > > Not sure why you felt this paragraph needed to be removed. Because the style is clearer and makes it much more obvious when a variable is having its own default value set. In ports at least, the current style is to use the less verbose form. > @@ -512,7 +503,11 @@ > > > Here we use dummy_msg to actually > - control our script, i.e., to emit a variable message. > + control our script, i.e., to emit a variable message. > + Use of a shell function is overkill here, since it only > + runs a single command; an equally valid alternative is: > + > + start_cmd="echo \"$dummy_msg\"" > > While you are technically correct, I think you misunderstood the > writer's intent, which was to show how an rc.conf(8) variable can be > used in a subroutine to control the behavior of the command. I agree > that the example isn't a very good one (in that it doesn't depict a > valid use case), but I think the "spirit" is correct. Maybe you can > suggest a better example? > I think that this script is very simple by design, and making a better example would complicate it. It is definitely worth pointing out the alternative though; it makes useful food for thought; both examples with a disclaimer. Thank you very much for commenting, and I feel bad that I'm fobbing you off. You've raised genuine points, but I had already considered them. Please keep on at me if you think I still need to do something about it. Chris [1] http://www.bayofrum.net/~crees/patches/rc-scripting-modernise2.diff -- Chris Rees | FreeBSD Developer crees@FreeBSD.org | http://people.freebsd.org/~crees From owner-freebsd-rc@FreeBSD.ORG Mon Oct 15 18:30:02 2012 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 123AF5F6 for ; Mon, 15 Oct 2012 18:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [8.8.178.135]) by mx1.freebsd.org (Postfix) with ESMTP id E49FA8FC08 for ; Mon, 15 Oct 2012 18:30:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q9FIU13V045112 for ; Mon, 15 Oct 2012 18:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q9FIU11n045109; Mon, 15 Oct 2012 18:30:01 GMT (envelope-from gnats) Date: Mon, 15 Oct 2012 18:30:01 GMT Message-Id: <201210151830.q9FIU11n045109@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org Cc: From: Chris Rees Subject: Re: docs/172692: [PATCH] Bring parts of the rc scripting guides up to date X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Chris Rees List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2012 18:30:02 -0000 The following reply was made to PR docs/172692; it has been noted by GNATS. From: Chris Rees To: Michael Telahun Makonnen Cc: freebsd-doc@freebsd.org, freebsd-rc@freebsd.org, freebsd-bugs@freebsd.org, "bug-followup@freebsd.org" Subject: Re: docs/172692: [PATCH] Bring parts of the rc scripting guides up to date Date: Mon, 15 Oct 2012 19:26:22 +0100 On 15/10/2012, Michael Telahun Makonnen wrote: > Some minor nits: > > - have the same prefix: ${name}. For > + have the same prefix: ${name}_. For > > You should add the same correction to the very next sentence, which reads: > > Note: While it is possible to use a shorter name internally, e.g., just Done, thanks! > > > @@ -491,15 +491,6 @@ > our script will save us from possible > collisions with the &man.rc.subr.8; namespace. > > - As long as an &man.rc.conf.5; variable and its > - internal equivalent are the same, we can use a more > - compact expression to set the default value: > - > - : ${dummy_msg:="Nothing > started."} > - > - The current style is to use the more verbose form > - though. > - > > Not sure why you felt this paragraph needed to be removed. Because the style is clearer and makes it much more obvious when a variable is having its own default value set. In ports at least, the current style is to use the less verbose form. > @@ -512,7 +503,11 @@ > > > Here we use dummy_msg to actually > - control our script, i.e., to emit a variable message. > + control our script, i.e., to emit a variable message. > + Use of a shell function is overkill here, since it only > + runs a single command; an equally valid alternative is: > + > + start_cmd="echo \"$dummy_msg\"" > > While you are technically correct, I think you misunderstood the > writer's intent, which was to show how an rc.conf(8) variable can be > used in a subroutine to control the behavior of the command. I agree > that the example isn't a very good one (in that it doesn't depict a > valid use case), but I think the "spirit" is correct. Maybe you can > suggest a better example? > I think that this script is very simple by design, and making a better example would complicate it. It is definitely worth pointing out the alternative though; it makes useful food for thought; both examples with a disclaimer. Thank you very much for commenting, and I feel bad that I'm fobbing you off. You've raised genuine points, but I had already considered them. Please keep on at me if you think I still need to do something about it. Chris [1] http://www.bayofrum.net/~crees/patches/rc-scripting-modernise2.diff -- Chris Rees | FreeBSD Developer crees@FreeBSD.org | http://people.freebsd.org/~crees From owner-freebsd-rc@FreeBSD.ORG Thu Oct 18 06:58:09 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1F778D18; Thu, 18 Oct 2012 06:58:09 +0000 (UTC) (envelope-from mmakonnen@gmail.com) Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id C19B78FC14; Thu, 18 Oct 2012 06:58:07 +0000 (UTC) Received: by mail-ee0-f54.google.com with SMTP id c50so4848598eek.13 for ; Wed, 17 Oct 2012 23:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=m2CJuNqq5KR5KydyKSrQMmaV8n6/I3P/ccMu+ypF4qU=; b=sv86brTHWX8hCN90Ttd4GFkVNL42xHH4A/67FICkRbXMKRf1Ug43WRsxI2+RG5fIJ4 T4BQ2sgI37Vqqk+Smbxj/miR1J1UUSbS/3YOYXGoGz0zZo4EpATTpS9Hlgi7rML33ruU sQnYfElgf/sCLj4fd4T+Ly4YAVfa2/akuTyEoXSJvZ8rFQ3qbsk7lX/p59SKdEJ4TnYC 2S7k9nbG+59NQzTIwKdsOanYkMylD35m1rEMvFgFCI+fzJ/K5aM5JQO6/tMJ3gpywrW8 PhXh/Na8qgZSyrnXIOh5n5OeiRnuWYPqTLpT65HQsvtP8k+Koc/Wsl8kQhOYKkYk0HvT KPFw== Received: by 10.14.194.136 with SMTP id m8mr29908734een.10.1350543486837; Wed, 17 Oct 2012 23:58:06 -0700 (PDT) Received: from [172.16.16.143] ([213.55.76.19]) by mx.google.com with ESMTPS id 7sm38300695eeg.5.2012.10.17.23.57.53 (version=SSLv3 cipher=OTHER); Wed, 17 Oct 2012 23:57:59 -0700 (PDT) Message-ID: <507FA86D.5040905@gmail.com> Date: Thu, 18 Oct 2012 09:57:49 +0300 From: Michael Telahun Makonnen User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Chris Rees Subject: Re: docs/172692: [PATCH] Bring parts of the rc scripting guides up to date References: <201210141319.q9EDJN6H085443@freefall.freebsd.org> <507C39D0.9030909@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-doc@freebsd.org, freebsd-rc@freebsd.org, "bug-followup@freebsd.org" X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2012 06:58:09 -0000 On 10/15/2012 09:26 PM, Chris Rees wrote: >> Not sure why you felt this paragraph needed to be removed. > > Because the style is clearer and makes it much more obvious when a > variable is having its own default value set. In ports at least, the > current style is to use the less verbose form. > ok > >> While you are technically correct, I think you misunderstood the >> writer's intent, which was to show how an rc.conf(8) variable can be >> used in a subroutine to control the behavior of the command. I agree >> that the example isn't a very good one (in that it doesn't depict a >> valid use case), but I think the "spirit" is correct. Maybe you can >> suggest a better example? >> > > I think that this script is very simple by design, and making a better > example would complicate it. It is definitely worth pointing out the > alternative though; it makes useful food for thought; both examples > with a disclaimer. ok > > [1] http://www.bayofrum.net/~crees/patches/rc-scripting-modernise2.diff > Looks fine to me. Thanks for taking the time to update the documentation. Cheers, Mike. From owner-freebsd-rc@FreeBSD.ORG Thu Oct 18 07:00:01 2012 Return-Path: Delivered-To: freebsd-rc@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C098BDB4 for ; Thu, 18 Oct 2012 07:00:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [8.8.178.135]) by mx1.freebsd.org (Postfix) with ESMTP id A83E98FC08 for ; Thu, 18 Oct 2012 07:00:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q9I701Sf027406 for ; Thu, 18 Oct 2012 07:00:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q9I7012E027405; Thu, 18 Oct 2012 07:00:01 GMT (envelope-from gnats) Date: Thu, 18 Oct 2012 07:00:01 GMT Message-Id: <201210180700.q9I7012E027405@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org Cc: From: Michael Telahun Makonnen Subject: Re: docs/172692: [PATCH] Bring parts of the rc scripting guides up to date X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Michael Telahun Makonnen List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2012 07:00:01 -0000 The following reply was made to PR docs/172692; it has been noted by GNATS. From: Michael Telahun Makonnen To: Chris Rees Cc: freebsd-doc@freebsd.org, freebsd-rc@freebsd.org, "bug-followup@freebsd.org" Subject: Re: docs/172692: [PATCH] Bring parts of the rc scripting guides up to date Date: Thu, 18 Oct 2012 09:57:49 +0300 On 10/15/2012 09:26 PM, Chris Rees wrote: >> Not sure why you felt this paragraph needed to be removed. > > Because the style is clearer and makes it much more obvious when a > variable is having its own default value set. In ports at least, the > current style is to use the less verbose form. > ok > >> While you are technically correct, I think you misunderstood the >> writer's intent, which was to show how an rc.conf(8) variable can be >> used in a subroutine to control the behavior of the command. I agree >> that the example isn't a very good one (in that it doesn't depict a >> valid use case), but I think the "spirit" is correct. Maybe you can >> suggest a better example? >> > > I think that this script is very simple by design, and making a better > example would complicate it. It is definitely worth pointing out the > alternative though; it makes useful food for thought; both examples > with a disclaimer. ok > > [1] http://www.bayofrum.net/~crees/patches/rc-scripting-modernise2.diff > Looks fine to me. Thanks for taking the time to update the documentation. Cheers, Mike.