From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 00:22:58 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 84CC5D3B; Sun, 18 Nov 2012 00:22:58 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id A8C008FC14; Sun, 18 Nov 2012 00:22:57 +0000 (UTC) Received: by mail-we0-f182.google.com with SMTP id u54so341249wey.13 for ; Sat, 17 Nov 2012 16:22:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=jo+mzHToO6OfcXFRM92rhmiiFygylG6H2tavYg3Oyfw=; b=BznFNQlESvGagZY+B7TLioF079c1emHkaXjVU9XXHrZLnKrF9G/wLYUKfzE0Xc7QCK JUi+C5id3PR1LlYAg45GdFgKyoyJKGl9aPTXGyhf4QpFojgZPG9AJp10hONcdc7v40dn hE3lnOWHx9zct3sJ0CLD7txsRtxdw+2LduE5hkWnCmMiJbM179BT/KoJvjkRxldWnZ9E QAcQOPUYppMPLDBXqJ2da1eUfRY/zPFKVOjaO126H9WNRplVL10N53gdWOy2wbcJjzYj +burq3TweVVh9jdsEK4YHio0DhYRlPNgdStRkEp0g0MxFOVJh8qqPvej5+OUSUdVUjC1 xXNw== Received: by 10.180.97.72 with SMTP id dy8mr3577615wib.6.1353198176179; Sat, 17 Nov 2012 16:22:56 -0800 (PST) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPS id gk9sm7159283wib.4.2012.11.17.16.22.54 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 17 Nov 2012 16:22:55 -0800 (PST) Date: Sun, 18 Nov 2012 01:22:45 +0100 From: Mateusz Guzik To: Hiroki Sato Subject: Re: mountlate being too mount-happy Message-ID: <20121118002245.GB15055@dft-labs.eu> References: <20121118.074325.564844639489846824.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20121118.074325.564844639489846824.hrs@allbsd.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: freebsd-rc@FreeBSD.org, mjg@FreeBSD.org, utisoft@gmail.com X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 00:22:58 -0000 On Sun, Nov 18, 2012 at 07:43:25AM +0900, Hiroki Sato wrote: > Chris Rees wrote > in : > > ut> On 2 November 2012 14:21, Eitan Adler wrote: > ut> > On 2 November 2012 09:56, Chris Rees wrote: > ut> >> I'll take a look. > ut> > > ut> > untested: > ut> > ut> Based on Eitan's patch, I've tested this one, and documented it in mount(8) too: > ut> > ut> http://www.bayofrum.net/~crees/patches/mountonlylate.diff > ut> > ut> Does anyone have any suggestions/objections/urge to approve it? > > Is the original problem due to backgrounding of NFS mount only? If > so, implementing prevention of duplicate invocation into mount(8) > would be more reasonable, I think. > We have 2 distinct scripts that try to mount same set of filesystems. I think this is the real bug here and proposed patches makes it go away in an IMHO acceptable way. -- Mateusz Guzik From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 06:10:09 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0E94EAEC; Sun, 18 Nov 2012 06:10:09 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id E77F68FC08; Sun, 18 Nov 2012 06:10:07 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id qAI69nGm040329 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 18 Nov 2012 15:09:59 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id qAI69lUQ095887; Sun, 18 Nov 2012 15:09:49 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 18 Nov 2012 15:09:35 +0900 (JST) Message-Id: <20121118.150935.240651183336258002.hrs@allbsd.org> To: mjguzik@gmail.com Subject: Re: mountlate being too mount-happy From: Hiroki Sato In-Reply-To: <20121118002245.GB15055@dft-labs.eu> References: <20121118.074325.564844639489846824.hrs@allbsd.org> <20121118002245.GB15055@dft-labs.eu> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sun_Nov_18_15_09_35_2012_216)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Sun, 18 Nov 2012 15:10:00 +0900 (JST) X-Spam-Status: No, score=-98.1 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: freebsd-rc@FreeBSD.org, mjg@FreeBSD.org, utisoft@gmail.com X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 06:10:09 -0000 ----Security_Multipart(Sun_Nov_18_15_09_35_2012_216)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mateusz Guzik wrote in <20121118002245.GB15055@dft-labs.eu>: mj> On Sun, Nov 18, 2012 at 07:43:25AM +0900, Hiroki Sato wrote: mj> > Chris Rees wrote mj> > in : mj> > mj> > ut> On 2 November 2012 14:21, Eitan Adler wrote: mj> > ut> > On 2 November 2012 09:56, Chris Rees wrote: mj> > ut> >> I'll take a look. mj> > ut> > mj> > ut> > untested: mj> > ut> mj> > ut> Based on Eitan's patch, I've tested this one, and documented it in mount(8) too: mj> > ut> mj> > ut> http://www.bayofrum.net/~crees/patches/mountonlylate.diff mj> > ut> mj> > ut> Does anyone have any suggestions/objections/urge to approve it? mj> > mj> > Is the original problem due to backgrounding of NFS mount only? If mj> > so, implementing prevention of duplicate invocation into mount(8) mj> > would be more reasonable, I think. mj> > mj> mj> We have 2 distinct scripts that try to mount same set of filesystems. mj> I think this is the real bug here and proposed patches makes it go away in mj> an IMHO acceptable way. I just wanted to make sure if the case is limited to background NFS mount or not. rc.d/mountlate just tries to mount the filesystems that are not mounted yet at that time in addition to the "late" ones, not always to mount the same set twice. If it is a bug, it is better to simply fix -l to exclude not-yet-mounted ones without "late" keyword than adding another option. -- Hiroki ----Security_Multipart(Sun_Nov_18_15_09_35_2012_216)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlCoe58ACgkQTyzT2CeTzy1eBgCdFEy9GeVr9gDeVgY4Uwyrjr+I 3WEAn2TuZrf7BuwFo8+s9yPb/pbQvJJA =XzXq -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Nov_18_15_09_35_2012_216)---- From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 14:21:46 2012 Return-Path: Delivered-To: freebsd-rc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 14CC9FDD; Sun, 18 Nov 2012 14:21:46 +0000 (UTC) (envelope-from crees@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id ECD048FC08; Sun, 18 Nov 2012 14:21:45 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAIELjjJ036376; Sun, 18 Nov 2012 14:21:45 GMT (envelope-from crees@freefall.freebsd.org) Received: (from crees@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAIELjHc036372; Sun, 18 Nov 2012 14:21:45 GMT (envelope-from crees) Date: Sun, 18 Nov 2012 14:21:45 GMT Message-Id: <201211181421.qAIELjHc036372@freefall.freebsd.org> To: f_zavatzki@blue-network.org, crees@FreeBSD.org, freebsd-rc@FreeBSD.org, crees@FreeBSD.org From: crees@FreeBSD.org Subject: Re: conf/99721: [patch] /etc/rc.initdiskless problem copy dotfile in subdirectories to the MFS filesystem X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 14:21:46 -0000 Synopsis: [patch] /etc/rc.initdiskless problem copy dotfile in subdirectories to the MFS filesystem State-Changed-From-To: feedback->patched State-Changed-By: crees State-Changed-When: Sun Nov 18 14:21:26 UTC 2012 State-Changed-Why: Committed to head, thanks! Responsible-Changed-From-To: freebsd-rc->crees Responsible-Changed-By: crees Responsible-Changed-When: Sun Nov 18 14:21:26 UTC 2012 Responsible-Changed-Why: Committed by me http://www.freebsd.org/cgi/query-pr.cgi?pr=99721 From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 14:29:01 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 12EFC1D4; Sun, 18 Nov 2012 14:29:01 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id D34D48FC0C; Sun, 18 Nov 2012 14:28:59 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id je9so857005bkc.13 for ; Sun, 18 Nov 2012 06:28:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=TKGImLFllUSlb4RtPj9YKCv25/2Z11XyjYvNot6Qsiw=; b=I6CXzIkb7htN6dl2JiHpHtm2FxgB48/nfRm1iQbVesA9i6CQYN9yU//flJ735J/knz dcQR6CzN0+L1wNNjq/rTt6wcu7zEOA0PN5v88W1ryQcCpAa9qQ4SYzDZvIOdexDGdLXp O+y7ml8lwxmRpYkWGgUkAaoYOWNsNvJWQyWSTSRL9CXel07EV33LXuHC8486As5pVsLy 5AzDcmBkQb4Flm6bo/oXGCo7mUahN/t8gIw/HmynWD2A/PhkW2IJuQhfoOHTzadmLvDb eUZ2J4Hns5AOw3pI1sszTAYCHxeeh4me3TrSdTZyF1PlrLrGlk7aq31/gvbL2KVKjS9l FvOw== Received: by 10.204.147.22 with SMTP id j22mr3874902bkv.66.1353248938785; Sun, 18 Nov 2012 06:28:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.50.197 with HTTP; Sun, 18 Nov 2012 06:28:28 -0800 (PST) In-Reply-To: <20121118.150935.240651183336258002.hrs@allbsd.org> References: <20121118.074325.564844639489846824.hrs@allbsd.org> <20121118002245.GB15055@dft-labs.eu> <20121118.150935.240651183336258002.hrs@allbsd.org> From: Chris Rees Date: Sun, 18 Nov 2012 14:28:28 +0000 Message-ID: Subject: Re: mountlate being too mount-happy To: Hiroki Sato Content-Type: text/plain; charset=ISO-8859-1 Cc: Mateusz Guzik , "freebsd-rc@freebsd.org" , Mateusz Guzik X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 14:29:01 -0000 On 18 November 2012 06:09, Hiroki Sato wrote: > Mateusz Guzik wrote > in <20121118002245.GB15055@dft-labs.eu>: > > mj> On Sun, Nov 18, 2012 at 07:43:25AM +0900, Hiroki Sato wrote: > mj> > Chris Rees wrote > mj> > in : > mj> > > mj> > ut> On 2 November 2012 14:21, Eitan Adler wrote: > mj> > ut> > On 2 November 2012 09:56, Chris Rees wrote: > mj> > ut> >> I'll take a look. > mj> > ut> > > mj> > ut> > untested: > mj> > ut> > mj> > ut> Based on Eitan's patch, I've tested this one, and documented it in mount(8) too: > mj> > ut> > mj> > ut> http://www.bayofrum.net/~crees/patches/mountonlylate.diff > mj> > ut> > mj> > ut> Does anyone have any suggestions/objections/urge to approve it? > mj> > > mj> > Is the original problem due to backgrounding of NFS mount only? If > mj> > so, implementing prevention of duplicate invocation into mount(8) > mj> > would be more reasonable, I think. > mj> > > mj> > mj> We have 2 distinct scripts that try to mount same set of filesystems. > mj> I think this is the real bug here and proposed patches makes it go away in > mj> an IMHO acceptable way. > > I just wanted to make sure if the case is limited to background NFS > mount or not. > > rc.d/mountlate just tries to mount the filesystems that are not > mounted yet at that time in addition to the "late" ones, not always > to mount the same set twice. If it is a bug, it is better to simply > fix -l to exclude not-yet-mounted ones without "late" keyword than > adding another option. I don't think it's a bug as such-- -l option is clearly labelled in the manpage (emphasis mine): When used in conjunction with the -a option, *also* mount those file systems which are marked as ``late''. I think that for POLA and to avoid changing behaviour of an option that's been there a long time we need the -L option. I disagree with Mateusz here-- split operations in rc makes two scripts necessary; mount and mountlate are two separate operations, done at different times. Chris From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 14:40:32 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E4E9051F; Sun, 18 Nov 2012 14:40:32 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id E80D48FC0C; Sun, 18 Nov 2012 14:40:31 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id je9so858930bkc.13 for ; Sun, 18 Nov 2012 06:40:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=qm7S22s4AfnVRtWNCRPJ5irHc82U5kr4pY07GgHIA/w=; b=vfApqiAOyw6jNx2dJLYNhDxGpcJyR7Fyf0FXBXpMyyULtAgAd0+9fCfQDF3/LmhEtE TVUATovwtUvbbmdd+zYeosHs1LaLiVwVKHlMXS6GVLI2nYAS1vnhKS8bJgnqf8fbRTns n110IKlEJZS6pkqAApj3IJzfBj490d5QT5e/gY0sSgd7d86h7jKkYZrNXquwZVdJeEoA bgeSZZOlIL1v0vE4zSO7LELwylOJPp9z+vF0GAw/+CFA2iQ1dI8ZlOSDuDKOgdTYDaWy SSCQ2bcvGTCIhms3meNke3ytZlMhGf8f8dGQgzlKiHoab8x4/UnwKcCjZTTGOpJ4KSo2 O8rg== Received: by 10.204.130.140 with SMTP id t12mr2436645bks.39.1353249630694; Sun, 18 Nov 2012 06:40:30 -0800 (PST) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.204.50.197 with HTTP; Sun, 18 Nov 2012 06:40:00 -0800 (PST) In-Reply-To: <20121118.075956.2090347175828215059.hrs@allbsd.org> References: <201211021111.qA2BBHEi008211@freefall.freebsd.org> <20121118.075956.2090347175828215059.hrs@allbsd.org> From: Chris Rees Date: Sun, 18 Nov 2012 14:40:00 +0000 X-Google-Sender-Auth: I-PR9vJEntaSoOCfG2wlq4uh1h8 Message-ID: Subject: Re: bin/165477: [rc] dhclient is run twice To: Hiroki Sato Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-rc@freebsd.org" , wblock@freebsd.org, "bug-followup@freebsd.org" X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 14:40:33 -0000 On 17 November 2012 22:59, Hiroki Sato wrote: > > I think it is safe to remove the warning message when rc_quiet=YES. > What do you think about the attached patch? I had originally considered that, but it then makes dhclient behave differently from other scripts; nothing else respects rc_quiet in this fashion; from rc.subr: start) if [ -z "$rc_fast" -a -n "$rc_pid" ]; then echo 1>&2 "${name} already running? (pid=$rc_pid)." return 1 fi and [crees@pegasus]~/workspace/ports/musicpd% sudo service musicpd quietstart musicpd already running? (pid=83847). Chris From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 14:50:01 2012 Return-Path: Delivered-To: freebsd-rc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3A38F823 for ; Sun, 18 Nov 2012 14:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 1D6418FC12 for ; Sun, 18 Nov 2012 14:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAIEo0Rd037419 for ; Sun, 18 Nov 2012 14:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAIEo0L7037418; Sun, 18 Nov 2012 14:50:00 GMT (envelope-from gnats) Date: Sun, 18 Nov 2012 14:50:00 GMT Message-Id: <201211181450.qAIEo0L7037418@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org Cc: From: Chris Rees Subject: Re: bin/165477: [rc] dhclient is run twice X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Chris Rees List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 14:50:01 -0000 The following reply was made to PR bin/165477; it has been noted by GNATS. From: Chris Rees To: Hiroki Sato Cc: wblock@freebsd.org, "freebsd-rc@freebsd.org" , "bug-followup@freebsd.org" Subject: Re: bin/165477: [rc] dhclient is run twice Date: Sun, 18 Nov 2012 14:40:00 +0000 On 17 November 2012 22:59, Hiroki Sato wrote: > > I think it is safe to remove the warning message when rc_quiet=YES. > What do you think about the attached patch? I had originally considered that, but it then makes dhclient behave differently from other scripts; nothing else respects rc_quiet in this fashion; from rc.subr: start) if [ -z "$rc_fast" -a -n "$rc_pid" ]; then echo 1>&2 "${name} already running? (pid=$rc_pid)." return 1 fi and [crees@pegasus]~/workspace/ports/musicpd% sudo service musicpd quietstart musicpd already running? (pid=83847). Chris From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 14:58:45 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A1AF59C9; Sun, 18 Nov 2012 14:58:45 +0000 (UTC) (envelope-from freebsd@damnhippie.dyndns.org) Received: from duck.symmetricom.us (duck.symmetricom.us [206.168.13.214]) by mx1.freebsd.org (Postfix) with ESMTP id 0FD9A8FC14; Sun, 18 Nov 2012 14:58:45 +0000 (UTC) Received: from damnhippie.dyndns.org (daffy.symmetricom.us [206.168.13.218]) by duck.symmetricom.us (8.14.5/8.14.5) with ESMTP id qAIEwcnZ057743; Sun, 18 Nov 2012 07:58:38 -0700 (MST) (envelope-from freebsd@damnhippie.dyndns.org) Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id qAIEwEFc028478; Sun, 18 Nov 2012 07:58:14 -0700 (MST) (envelope-from freebsd@damnhippie.dyndns.org) Subject: Re: bin/165477: [rc] dhclient is run twice From: Ian Lepore To: Chris Rees In-Reply-To: References: <201211021111.qA2BBHEi008211@freefall.freebsd.org> <20121118.075956.2090347175828215059.hrs@allbsd.org> Content-Type: text/plain; charset="us-ascii" Date: Sun, 18 Nov 2012 07:58:14 -0700 Message-ID: <1353250694.1217.321.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: "freebsd-rc@freebsd.org" , wblock@freebsd.org, "bug-followup@freebsd.org" X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 14:58:45 -0000 On Sun, 2012-11-18 at 14:40 +0000, Chris Rees wrote: > On 17 November 2012 22:59, Hiroki Sato wrote: > > > > I think it is safe to remove the warning message when rc_quiet=YES. > > What do you think about the attached patch? > > I had originally considered that, but it then makes dhclient behave > differently from other scripts; nothing else respects rc_quiet in this > fashion; > > from rc.subr: > start) > if [ -z "$rc_fast" -a -n "$rc_pid" ]; then > echo 1>&2 "${name} already running? > (pid=$rc_pid)." > return 1 > fi > and > > [crees@pegasus]~/workspace/ports/musicpd% sudo service musicpd quietstart > musicpd already running? (pid=83847). > > Chris If not via the rc_quiet mechanism, then please silence it via some other mechanism *to restore historical behavior*. In the past, rc.d/dhclient had its own silent pidfile check and in general the design was to be silently idempotent (presumably because of the way it gets invoked multiple times for the same inteface during rc processing). Somewhere along the line it was changed to use new common rc.subr code to handle the pidfile check, but because the new code is not silent it wasn't really equivelent to the old code. As far as I'm concerned the switch to the new noisy pidfile check for dhclient amounts to the introduction of a bug. If it doesn't get changed I can see years of explaining to customers (who seem to have nothing better to do than spelunk system logs) "don't worry about that, it's normal." -- Ian From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 15:00:01 2012 Return-Path: Delivered-To: freebsd-rc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 76670B0B for ; Sun, 18 Nov 2012 15:00:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 431248FC0C for ; Sun, 18 Nov 2012 15:00:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAIF00ch037613 for ; Sun, 18 Nov 2012 15:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAIF00hD037609; Sun, 18 Nov 2012 15:00:00 GMT (envelope-from gnats) Date: Sun, 18 Nov 2012 15:00:00 GMT Message-Id: <201211181500.qAIF00hD037609@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org Cc: From: Ian Lepore Subject: Re: bin/165477: [rc] dhclient is run twice X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Ian Lepore List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 15:00:01 -0000 The following reply was made to PR bin/165477; it has been noted by GNATS. From: Ian Lepore To: Chris Rees Cc: Hiroki Sato , "freebsd-rc@freebsd.org" , wblock@freebsd.org, "bug-followup@freebsd.org" Subject: Re: bin/165477: [rc] dhclient is run twice Date: Sun, 18 Nov 2012 07:58:14 -0700 On Sun, 2012-11-18 at 14:40 +0000, Chris Rees wrote: > On 17 November 2012 22:59, Hiroki Sato wrote: > > > > I think it is safe to remove the warning message when rc_quiet=YES. > > What do you think about the attached patch? > > I had originally considered that, but it then makes dhclient behave > differently from other scripts; nothing else respects rc_quiet in this > fashion; > > from rc.subr: > start) > if [ -z "$rc_fast" -a -n "$rc_pid" ]; then > echo 1>&2 "${name} already running? > (pid=$rc_pid)." > return 1 > fi > and > > [crees@pegasus]~/workspace/ports/musicpd% sudo service musicpd quietstart > musicpd already running? (pid=83847). > > Chris If not via the rc_quiet mechanism, then please silence it via some other mechanism *to restore historical behavior*. In the past, rc.d/dhclient had its own silent pidfile check and in general the design was to be silently idempotent (presumably because of the way it gets invoked multiple times for the same inteface during rc processing). Somewhere along the line it was changed to use new common rc.subr code to handle the pidfile check, but because the new code is not silent it wasn't really equivelent to the old code. As far as I'm concerned the switch to the new noisy pidfile check for dhclient amounts to the introduction of a bug. If it doesn't get changed I can see years of explaining to customers (who seem to have nothing better to do than spelunk system logs) "don't worry about that, it's normal." -- Ian From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 15:17:51 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 975BB166; Sun, 18 Nov 2012 15:17:51 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 5AB558FC0C; Sun, 18 Nov 2012 15:17:50 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id qAIFHWjf047169 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 19 Nov 2012 00:17:42 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id qAIFHVsp016821; Mon, 19 Nov 2012 00:17:32 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Mon, 19 Nov 2012 00:17:26 +0900 (JST) Message-Id: <20121119.001726.1901703543569641080.hrs@allbsd.org> To: crees@FreeBSD.org Subject: Re: bin/165477: [rc] dhclient is run twice From: Hiroki Sato In-Reply-To: <201211181450.qAIEo0L7037418@freefall.freebsd.org> References: <201211181450.qAIEo0L7037418@freefall.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Mon_Nov_19_00_17_26_2012_329)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Mon, 19 Nov 2012 00:17:43 +0900 (JST) X-Spam-Status: No, score=-97.8 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,QENCPTR1,SAMEHELOBY2HOP,USER_IN_WHITELIST,X_CHINESE_RELAY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 15:17:51 -0000 ----Security_Multipart(Mon_Nov_19_00_17_26_2012_329)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Chris Rees wrote in <201211181450.qAIEo0L7037418@freefall.freebsd.org>: cr> The following reply was made to PR bin/165477; it has been noted by GNATS. cr> cr> From: Chris Rees cr> To: Hiroki Sato cr> Cc: wblock@freebsd.org, "freebsd-rc@freebsd.org" , cr> "bug-followup@freebsd.org" cr> Subject: Re: bin/165477: [rc] dhclient is run twice cr> Date: Sun, 18 Nov 2012 14:40:00 +0000 cr> cr> On 17 November 2012 22:59, Hiroki Sato wrote: cr> > cr> > I think it is safe to remove the warning message when rc_quiet=YES. cr> > What do you think about the attached patch? cr> cr> I had originally considered that, but it then makes dhclient behave cr> differently from other scripts; nothing else respects rc_quiet in this cr> fashion; cr> cr> from rc.subr: cr> start) cr> if [ -z "$rc_fast" -a -n "$rc_pid" ]; then cr> echo 1>&2 "${name} already running? cr> (pid=$rc_pid)." cr> return 1 cr> fi cr> and cr> cr> [crees@pegasus]~/workspace/ports/musicpd% sudo service musicpd quietstart cr> musicpd already running? (pid=83847). I cannot understand why the dhclient script behaves differently from the others after patching rc.subr. Did you read the attached patch in my previous email? -- Hiroki ----Security_Multipart(Mon_Nov_19_00_17_26_2012_329)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlCo/AYACgkQTyzT2CeTzy3TlgCg1zXTxAa4h1tVDH+Pe40U6AkM jdgAoLoeFv4i0d5Lg5FxgPDt3PLTSgRT =0LFr -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Nov_19_00_17_26_2012_329)---- From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 16:41:59 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C9036E1; Sun, 18 Nov 2012 16:41:59 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 791D68FC15; Sun, 18 Nov 2012 16:41:57 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id je9so878538bkc.13 for ; Sun, 18 Nov 2012 08:41:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HtGnYOQtcz9/phnZ2zNRRh+oV34shJib4m6ydZdkxUE=; b=UZtlsDpqjSKUxMOcQPQotYKfDGMPkkL8hBDdsUgbjNZIREvNuF8TnHdMbydHZi+nnU THPbbmFBvZ9c7tN5Z5M0E1qY3z5LvlQHJi7L+G0hZxFUOGx8jpryqBapOg5VdENmVaTA LiWtnHn2C3jPSSxZaxzYouKwoBxZII0l6JOQONZP1lko/sDYCR+iY60UsfSVDlMyjvSr Mcspm39BuYgeE2o2u3z41XuONF06LyfJYmPAOJbze0UR4pXT0YXpNjOm5wfeyR4nL+MC MZaJG2hCL3CEt+ehCXyBDhcecnubLZEAil8uGFf8AylY2MDQBs5OruSLAxwFn4qAUMyT 3Mjw== MIME-Version: 1.0 Received: by 10.205.120.3 with SMTP id fw3mr671732bkc.40.1353256916968; Sun, 18 Nov 2012 08:41:56 -0800 (PST) Received: by 10.204.50.197 with HTTP; Sun, 18 Nov 2012 08:41:56 -0800 (PST) Received: by 10.204.50.197 with HTTP; Sun, 18 Nov 2012 08:41:56 -0800 (PST) In-Reply-To: <20121119.001726.1901703543569641080.hrs@allbsd.org> References: <201211181450.qAIEo0L7037418@freefall.freebsd.org> <20121119.001726.1901703543569641080.hrs@allbsd.org> Date: Sun, 18 Nov 2012 16:41:56 +0000 Message-ID: Subject: Re: bin/165477: [rc] dhclient is run twice From: Chris Rees To: Hiroki Sato Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-rc@freebsd.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 16:41:59 -0000 On 18 Nov 2012 15:17, "Hiroki Sato" wrote: > > Chris Rees wrote > in <201211181450.qAIEo0L7037418@freefall.freebsd.org>: > > cr> The following reply was made to PR bin/165477; it has been noted by GNATS. > cr> > cr> From: Chris Rees > cr> To: Hiroki Sato > cr> Cc: wblock@freebsd.org, "freebsd-rc@freebsd.org" < freebsd-rc@freebsd.org>, > cr> "bug-followup@freebsd.org" > cr> Subject: Re: bin/165477: [rc] dhclient is run twice > cr> Date: Sun, 18 Nov 2012 14:40:00 +0000 > cr> > cr> On 17 November 2012 22:59, Hiroki Sato wrote: > cr> > > cr> > I think it is safe to remove the warning message when rc_quiet=YES. > cr> > What do you think about the attached patch? > cr> > cr> I had originally considered that, but it then makes dhclient behave > cr> differently from other scripts; nothing else respects rc_quiet in this > cr> fashion; > cr> > cr> from rc.subr: > cr> start) > cr> if [ -z "$rc_fast" -a -n "$rc_pid" ]; then > cr> echo 1>&2 "${name} already running? > cr> (pid=$rc_pid)." > cr> return 1 > cr> fi > cr> and > cr> > cr> [crees@pegasus]~/workspace/ports/musicpd% sudo service musicpd quietstart > cr> musicpd already running? (pid=83847). > > I cannot understand why the dhclient script behaves differently from > the others after patching rc.subr. Did you read the attached patch > in my previous email? I read the patch, but not the filename-- I'm sorry that Sunday afternoons are clearly not a good time for me to review code :( If you want to respect rc_quiet in rc.subr for the already running case, then I think that's fine. Chris From owner-freebsd-rc@FreeBSD.ORG Mon Nov 19 11:06:51 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 67F76215 for ; Mon, 19 Nov 2012 11:06:51 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 4308D8FC1B for ; Mon, 19 Nov 2012 11:06:51 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAJB6p8S013430 for ; Mon, 19 Nov 2012 11:06:51 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAJB6oeR013428 for freebsd-rc@FreeBSD.org; Mon, 19 Nov 2012 11:06:50 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 19 Nov 2012 11:06:50 GMT Message-Id: <201211191106.qAJB6oeR013428@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-rc@FreeBSD.org Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2012 11:06:51 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o bin/173153 rc [rc.d] [patch] $netwait_ip should be more parallel o conf/172532 rc [rc] [patch] service routing restart always fails o conf/169373 rc mountd starts too early when exporting fs marked as la o conf/169047 rc [rc.subr] [patch] /etc/rc.subr not checking some scrip o bin/168544 rc [patch] [rc]: addswap-mounted swapfiles cause panic on o conf/167566 rc [rc.d] [patch] ipdivert module loading vs. ipfw rc.d o o conf/166484 rc [rc] [patch] rc.initdiskless patch for different major o conf/165769 rc [rc][jai][ipv6] IPv6 Initialization on external iface f bin/165477 rc [rc] dhclient is run twice o conf/164393 rc [rc.d] restarting netif with static addresses doesn't o conf/163508 rc [rc.subr] [patch] Add "enable" and "disable" commands o conf/163488 rc Confusing explanation in defaults/rc.conf o conf/163321 rc [rc.conf] [patch] allow _fib syntax in rc.conf o conf/162642 rc .sh scripts in /usr/local/etc/rc.d get executed, not s p kern/161899 rc [route] ntpd(8): Repeating RTM_MISS packets causing hi o conf/161107 rc [rc] stop_boot in mountcritlocal usage is incorrect. o conf/160403 rc [rc] [patch] concurrently running rc-scripts during bo o conf/160240 rc rc.d/mdconfig and mdconfig2 should autoset $_type to v o conf/159846 rc [rc.conf] routing_stop_inet6() logic doesn't handle ip o conf/158557 rc [patch] /etc/rc.d/pf broken messages o conf/158127 rc [patch] remount_optional option in rc.initdiskless doe o conf/153666 rc [rc.d][patch] mount filesystems from fstab over zfs da o conf/153200 rc post-boot /etc/rc.d/network_ipv6 start can miss neighb o conf/153123 rc [rc] [patch] add gsched rc file to automatically inser o conf/150474 rc [patch] rc.d/accounting: Add ability to set location o o conf/149867 rc [PATCH] rc.d script to manage multiple FIBS (kern opti o conf/149831 rc [PATCH] add support to /etc/rc.d/jail for delegating Z o conf/148656 rc rc.firewall(8): {oip} and {iip} variables in rc.firewa o conf/147685 rc [rc.d] [patch] new feature for /etc/rc.d/fsck o conf/147444 rc [rc.d] [patch] /etc/rc.d/zfs stop not called on reboot o conf/146053 rc [patch] [request] shutdown of jails breaks inter-jail o conf/145399 rc [patch] rc.d scripts are unable to start/stop programs o conf/145009 rc [patch] rc.subr(8): rc.conf should allow mac label con o conf/143637 rc [patch] ntpdate(8) support for ntp-servers supplied by o conf/143085 rc [patch] ftp-proxy(8) rc(8) with multiple instances a conf/142973 rc [jail] [patch] Strange counter init value in jail rc o conf/142434 rc [patch] Add cpuset(1) support to rc.subr(8) o conf/142304 rc rc.conf(5): mdconfig and mdconfig2 rc.d scripts lack e o conf/141909 rc rc.subr(8): [patch] add rc.conf.d support to /usr/loca o conf/141678 rc [patch] A minor enhancement to how /etc/rc.d/jail dete o conf/140440 rc [patch] allow local command files in rc.{suspend,resum o conf/140261 rc [patch] Improve flexibility of mdconfig2 startup scrip p conf/138208 rc [rc.d] [patch] Making rc.firewall (workstation) IPv6 a o conf/137271 rc [rc.d] Cannot update /etc/host.conf when root filesyst o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). p conf/123119 rc [patch] rc script for ipfw does not handle IPv6 o conf/122968 rc [rc.d] /etc/rc.d/addswap: md swapfile multiplication a o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug a conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses f conf/118255 rc savecore never finding kernel core dumps (rcorder prob f conf/117935 rc [patch] ppp fails to start at boot because of missing f conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p f conf/105689 rc [ppp] [request] syslogd starts too late at boot f conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp f conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d f conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle a conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi a conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} f conf/56934 rc [patch] rc.firewall rules for natd expect an interface 82 problems total. From owner-freebsd-rc@FreeBSD.ORG Tue Nov 20 04:45:38 2012 Return-Path: Delivered-To: freebsd-rc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 187EEE08; Tue, 20 Nov 2012 04:45:38 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id D75248FC16; Tue, 20 Nov 2012 04:45:37 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAK4jbCt088650; Tue, 20 Nov 2012 04:45:37 GMT (envelope-from hrs@freefall.freebsd.org) Received: (from hrs@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAK4jbaD088646; Tue, 20 Nov 2012 04:45:37 GMT (envelope-from hrs) Date: Tue, 20 Nov 2012 04:45:37 GMT Message-Id: <201211200445.qAK4jbaD088646@freefall.freebsd.org> To: wblock@FreeBSD.org, hrs@FreeBSD.org, freebsd-rc@FreeBSD.org, hrs@FreeBSD.org From: hrs@FreeBSD.org Subject: Re: bin/165477: [rc] dhclient is run twice X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2012 04:45:38 -0000 Synopsis: [rc] dhclient is run twice State-Changed-From-To: feedback->patched State-Changed-By: hrs State-Changed-When: Tue Nov 20 04:45:05 UTC 2012 State-Changed-Why: Committed a patch. Responsible-Changed-From-To: freebsd-rc->hrs Responsible-Changed-By: hrs Responsible-Changed-When: Tue Nov 20 04:45:05 UTC 2012 Responsible-Changed-Why: Committed a patch. http://www.freebsd.org/cgi/query-pr.cgi?pr=165477 From owner-freebsd-rc@FreeBSD.ORG Fri Nov 23 14:39:38 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 33A93703; Fri, 23 Nov 2012 14:39:38 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 4C42A8FC16; Fri, 23 Nov 2012 14:39:37 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id qANEdIUv025619 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 Nov 2012 23:39:28 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id qANEdIbS002005; Fri, 23 Nov 2012 23:39:18 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Fri, 23 Nov 2012 23:37:54 +0900 (JST) Message-Id: <20121123.233754.1596631883684484110.hrs@allbsd.org> To: mwlucas@michaelwlucas.com Subject: Re: after upgrade, can't restart apache via cron From: Hiroki Sato In-Reply-To: <20121123031753.GA59632@bewilderbeast.blackhelicopters.org> References: <20121123031753.GA59632@bewilderbeast.blackhelicopters.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart0(Fri_Nov_23_23_37_54_2012_910)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Fri, 23 Nov 2012 23:39:29 +0900 (JST) X-Spam-Status: No, score=-97.6 required=13.0 tests=CONTENT_TYPE_PRESENT, FAKEDWORD_BACKQUOTE,ONLY1HOPDIRECT,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: freebsd-rc@FreeBSD.org, current@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: freebsd-rc@FreeBSD.org List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2012 14:39:38 -0000 ----Security_Multipart0(Fri_Nov_23_23_37_54_2012_910)-- Content-Type: Multipart/Mixed; boundary="--Next_Part(Fri_Nov_23_23_37_54_2012_649)--" Content-Transfer-Encoding: 7bit ----Next_Part(Fri_Nov_23_23_37_54_2012_649)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit "Michael W. Lucas" wrote in <20121123031753.GA59632@bewilderbeast.blackhelicopters.org>: mw> eval: setfib: not found mw> /usr/local/etc/rc.d/apache22: WARNING: failed to start apache22 mw> mw> If I run /usr/local/etc/rc.d/apache22 restart from the command line, I mw> can restart httpd without trouble. mw> mw> Any thoughts? This was due to $PATH in the cron job as already pointed out, but this should not happen. I attached a patch to use full-path for external commands in rc.subr. If there is no objection to this change I will commit it. -- Hiroki ----Next_Part(Fri_Nov_23_23_37_54_2012_649)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="rc.subr.cmdpath.20121123-1.diff" Index: etc/rc.subr =================================================================== --- etc/rc.subr (revision 243327) +++ etc/rc.subr (working copy) @@ -49,6 +49,18 @@ IDCMD="if [ -x $ID ]; then $ID -un; fi" PS="/bin/ps -ww" JID=`$PS -p $$ -o jid=` +CHROOT_CMD="/usr/sbin/chroot" +DEVFS_CMD="/sbin/devfs" +EGREP_CMD="/usr/bin/egrep" +GREP_CMD="/usr/bin/grep" +KLDSTAT_CMD="/sbin/kldstat" +KLDLOAD_CMD="/sbin/kldload" +LOGGER_CMD="/usr/bin/logger" +MDMFS_CMD="/sbin/mdmfs" +MOUNT_CMD="/sbin/mount" +NICE_CMD="/usr/bin/nice" +SETFIB_CMD="/usr/sbin/setfib" +SU_CMD="/usr/bin/su" # # functions @@ -181,7 +193,7 @@ if $_ismounted; then : else - mount $_fs >/dev/null 2>&1 + ${MOUNT_CMD} $_fs >/dev/null 2>&1 fi ) done @@ -726,17 +738,17 @@ check_startmsgs && echo "Starting ${name}." if [ -n "$_chroot" ]; then _doit="\ -${_nice:+nice -n $_nice }\ -${_fib:+setfib -F $_fib }\ -chroot ${_user:+-u $_user }${_group:+-g $_group }${_groups:+-G $_groups }\ +${_nice:+${NICE_CMD} -n $_nice }\ +${_fib:+${SETFIB_CMD} -F $_fib }\ +${CHROOT_CMD} ${_user:+-u $_user }${_group:+-g $_group }${_groups:+-G $_groups }\ $_chroot $command $rc_flags $command_args" else _doit="\ ${_chdir:+cd $_chdir && }\ -${_fib:+setfib -F $_fib }\ +${_fib:+${SETFIB_CMD} -F $_fib }\ $command $rc_flags $command_args" if [ -n "$_user" ]; then - _doit="su -m $_user -c 'sh -c \"$_doit\"'" + _doit="${SU_CMD} -m $_user -c 'sh -c \"$_doit\"'" fi if [ -n "$_nice" ]; then if [ -z "$_user" ]; then @@ -953,7 +965,7 @@ _cmd="kill -$1 $rc_pid" if [ -n "$_user" ]; then - _cmd="su -m ${_user} -c 'sh -c \"${_cmd}\"'" + _cmd="${SU_CMD} -m ${_user} -c 'sh -c \"${_cmd}\"'" fi echo "$_cmd" } @@ -1110,8 +1122,8 @@ exitval=$1 shift - if [ -x /usr/bin/logger ]; then - logger "$0: ERROR: $*" + if [ -x ${LOGGER_CMD} ]; then + ${LOGGER_CMD} "$0: ERROR: $*" fi echo 1>&2 "$0: ERROR: $*" exit $exitval @@ -1123,8 +1135,8 @@ # warn() { - if [ -x /usr/bin/logger ]; then - logger "$0: WARNING: $*" + if [ -x ${LOGGER_CMD} ]; then + ${LOGGER_CMD} "$0: WARNING: $*" fi echo 1>&2 "$0: WARNING: $*" } @@ -1137,8 +1149,8 @@ { case ${rc_info} in [Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|[Oo][Nn]|1) - if [ -x /usr/bin/logger ]; then - logger "$0: INFO: $*" + if [ -x ${LOGGER_CMD} ]; then + ${LOGGER_CMD} "$0: INFO: $*" fi echo "$0: INFO: $*" ;; @@ -1155,8 +1167,8 @@ { case ${rc_debug} in [Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|[Oo][Nn]|1) - if [ -x /usr/bin/logger ]; then - logger "$0: DEBUG: $*" + if [ -x ${LOGGER_CMD} ]; then + ${LOGGER_CMD} "$0: DEBUG: $*" fi echo 1>&2 "$0: DEBUG: $*" ;; @@ -1320,7 +1332,7 @@ fi eval $rulename=\$rulenum debug "found ruleset: $rulename=$rulenum" - if ! /sbin/devfs rule -s $rulenum delset; then + if ! ${DEVFS_CMD} rule -s $rulenum delset; then _err=1 break fi @@ -1331,7 +1343,7 @@ # other rules if [ -n "$rulecmd" ]; then debug "adding rule ($rulecmd)" - if ! eval /sbin/devfs rule -s $rulenum $rulecmd + if ! eval ${DEVFS_CMD} rule -s $rulenum $rulecmd then _err=1 break @@ -1389,7 +1401,7 @@ return 1 fi debug "$_me: setting ruleset ($rs) on mount-point (${devdir#-m })" - if ! /sbin/devfs $devdir ruleset $rs; then + if ! ${DEVFS_CMD} $devdir ruleset $rs; then warn "$_me: unable to set ruleset $rs to ${devdir#-m }" return 1 fi @@ -1414,7 +1426,7 @@ return 1 fi debug "$_me: applying ruleset ($rs) to mount-point (${devdir#-m })" - if ! /sbin/devfs $devdir rule -s $rs applyset; then + if ! ${DEVFS_CMD} $devdir rule -s $rs applyset; then warn "$_me: unable to apply ruleset $rs to ${devdir#-m }" return 1 fi @@ -1438,14 +1450,14 @@ return 1 fi debug "$_me: mount-point is ($devdir), ruleset is ($rs)" - if ! mount -t devfs dev "$devdir"; then + if ! ${MOUNT_CMD} -t devfs dev "$devdir"; then warn "$_me: Unable to mount devfs on $devdir" return 1 fi if [ -n "$rs" ]; then devfs_init_rulesets devfs_set_ruleset $rs $devdir - devfs -m $devdir rule applyset + ${DEVFS_CMD} -m $devdir rule applyset fi return 0 } @@ -1483,7 +1495,7 @@ if [ -n "$3" ]; then flags="$3" fi - /sbin/mdmfs $flags -s $1 md $2 + ${MDMFS_CMD} $flags -s $1 md $2 } # Code common to scripts that need to load a kernel module @@ -1512,16 +1524,16 @@ _mod=${_mod:-$1} _loaded=false if [ -n "$_re" ]; then - if kldstat -v | egrep -q -e "$_re"; then + if ${KLDSTAT_CMD} -v | ${EGREP_CMD} -q -e "$_re"; then _loaded=true fi else - if kldstat -q -m "$_mod"; then + if ${KLDSTAT_CMD} -q -m "$_mod"; then _loaded=true fi fi if ! $_loaded; then - if ! kldload "$1"; then + if ! ${KLDLOAD_CMD} "$1"; then warn "Unable to load kernel module $1" return 1 else @@ -1607,12 +1619,12 @@ for dir in ${local_startup}; do if [ -d "${dir}" ]; then for file in ${dir}/[0-9]*.sh; do - grep '^# PROVIDE:' $file >/dev/null 2>&1 && + ${GREP_CMD} '^# PROVIDE:' $file >/dev/null 2>&1 && continue zlist="$zlist $file" done for file in ${dir}/[!0-9]*.sh; do - grep '^# PROVIDE:' $file >/dev/null 2>&1 && + ${GREP_CMD} '^# PROVIDE:' $file >/dev/null 2>&1 && continue slist="$slist $file" done @@ -1624,7 +1636,7 @@ local_rc='' for dir in ${local_startup}; do if [ -d "${dir}" ]; then - for file in `grep -l '^# PROVIDE:' ${dir}/* 2>/dev/null`; do + for file in `${GREP_CMD} -l '^# PROVIDE:' ${dir}/* 2>/dev/null`; do case "$file" in *.sample) ;; *) if [ -x "$file" ]; then ----Next_Part(Fri_Nov_23_23_37_54_2012_649)---- ----Security_Multipart0(Fri_Nov_23_23_37_54_2012_910)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlCvikIACgkQTyzT2CeTzy2yzACdEQHZqMfc6auIsEPrUgqZ2Jfi rLYAoI8ZS8Pp7aEB2a2+riVyvQBJYqvy =v0c/ -----END PGP SIGNATURE----- ----Security_Multipart0(Fri_Nov_23_23_37_54_2012_910)----