From owner-freebsd-stable@FreeBSD.ORG Sun Jun 17 00:38:54 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4098C106566B for ; Sun, 17 Jun 2012 00:38:54 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com [209.85.215.182]) by mx1.freebsd.org (Postfix) with ESMTP id C1B0E8FC0A for ; Sun, 17 Jun 2012 00:38:53 +0000 (UTC) Received: by eabm6 with SMTP id m6so1389961eab.13 for ; Sat, 16 Jun 2012 17:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=N7prtZVJaDyLd6RUslxTQ0yqARNG1za+3sSoLmt+3oc=; b=mqbC/k2rzdVCPhCfMCHim4gwmENYkdkI9Of1cQZpK0laWbvU2MObvERXpMYEAxcK+5 aYuE7LHs56X1J3HjSvixeEMr9QjT1erlnSXLPG4K/l5DVvJ835n74BRAOTglXxTbLlDP PLQQLJp3m2lxg8/2pzvWl8tKJPaGWmuNHcyA4giIx5pb9UgkUpW48SncmxRfAcmHmVxM L0GxWCbcrokfEe5Q0X0OQiJqK6WzooQQpajAamEwASqgZKVSybSAgNj4q3bBF6wGhEJi MsimenFdywantXzMSqDdqSUeGNr86p3sntzWQiwJumcbRO82BqN9o/B32aZ7BmPnBNvv PKbA== Received: by 10.14.28.66 with SMTP id f42mr2592735eea.63.1339893532751; Sat, 16 Jun 2012 17:38:52 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPS id y12sm45553805eem.7.2012.06.16.17.38.51 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 16 Jun 2012 17:38:51 -0700 (PDT) Date: Sun, 17 Jun 2012 02:38:49 +0200 From: Mateusz Guzik To: David ROFFIAEN Message-ID: <20120617003849.GA11317@dft-labs.eu> References: <4FDCF74A.4010305@roffiaen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4FDCF74A.4010305@roffiaen.com> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: freebsd-stable Subject: Re: ggate problem X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2012 00:38:54 -0000 On Sat, Jun 16, 2012 at 11:14:50PM +0200, David ROFFIAEN wrote: > Hi list, > > I encoutered a panic with ggatec : > I misconfigured gg.exports on the server with bad IP address for > allowed client. Resulting a panic when creating ggatec on the > client. > Investigating the panic a I discovered at line 362 in g_gatec.c, the > ggio->gctl_sectorsize variable is not checked to be > 0 resulting a > "Fatal trap 18: integer divide fault while in kernel mode", thus > because there is no ggated allowed for my client IP (in my > misconfigured gg.exports) in my case. > > It would be better to check before the 'if' at line 362, that the > partition we are trying to import with ggatec is available and > otherwise give an explicit warning instead of letting the kernel > panicing. > I'm unable to reproduce this. It would be best if you provide: - version of your system - your gg.exports config - exact ggatec command you ran - backtrace from the panic -- Mateusz Guzik