From owner-freebsd-toolchain@FreeBSD.ORG Sun Apr 15 14:43:30 2012 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B91FB106564A; Sun, 15 Apr 2012 14:43:30 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 4F7428FC14; Sun, 15 Apr 2012 14:43:30 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q3FEhNYn021654; Sun, 15 Apr 2012 17:43:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q3FEhNGS003928; Sun, 15 Apr 2012 17:43:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q3FEhMZO003927; Sun, 15 Apr 2012 17:43:22 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 15 Apr 2012 17:43:22 +0300 From: Konstantin Belousov To: John Marino Message-ID: <20120415144322.GU2358@deviant.kiev.zoral.com.ua> References: <4F3C5A3A.6050107@FreeBSD.org> <20120216154730.GL3283@deviant.kiev.zoral.com.ua> <4F5C7764.2@marino.st> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+MW5NjnblUaFJVG7" Content-Disposition: inline In-Reply-To: <4F5C7764.2@marino.st> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: kan@freebsd.org, Pedro Giffuni , freebsd-toolchain@freebsd.org Subject: Re: DragonFly added DT_GNU_HASH support to rtld X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Apr 2012 14:43:30 -0000 --+MW5NjnblUaFJVG7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 11, 2012 at 10:59:00AM +0100, John Marino wrote: > Hi Konstantin, >=20 > It seems that no BSD supported DT_GNU_HASH despite this option being=20 > available on the base binutils (FreeBSD's 2.17.50 binutils supports it).= =20 > This gnu extension is a big performance improvement over the specified= =20 > SysV hash. >=20 > The guy porting libreoffice to pkgsrc was finding -Wl,--hash-style=3Dgnu= =20 > to be the default build for that package. Indeed, using the standard=20 > hash results in very long startup times for something like Writer (> 8=20 > seconds launched from a SSD) >=20 > The result is that we brought in DT_GNU_HASH support to our real-time=20 > linker this weekend. We're still waiting to see how that improves=20 > libreoffice startup times. >=20 > full commit: > >http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/7629c6317998f850= ebca23c296822ba08af09e5b >=20 >=20 > Modification to base compiler so all system libs and binaries can take=20 > advantage of it: > >http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/4687ecd9561d76f3= d02ccb4f7adeecd5e3afdd8f >=20 >=20 > For a while, binaries with dynamic symbol tables will have both types of= =20 > hashes embedded. At some point in the future, we may switch over to=20 > only generating the GNU hash. This will break forward compatibility,=20 > but that happens rather frequently for other reasons anyway. >=20 > I was a bit surprised FreeBSD didn't already have this functionality=20 > given the performance benefits, so hopefully these DragonFly commits=20 > will be interesting for you. >=20 I finally ported the Dragonfly commit to FreeBSD. There were several changes reverted in dragonfly version of the extracted matched_symbol() function which were restored. I also blindly converted all non-x86 arches. The matched_symbol() extraction is the good opportunity to apply the style(9) formatting to the large chunk of rtld code. Any testers, esp. on non-x86 architectures, are welcome. You would need to modify gcc spec file for you architecture, see corresponding x86 changes in contrib/gcc/config/i386. For me, patch successfully worked on the machine were I disabled sysv hashes at all. http://people.freebsd.org/~kib/misc/rtld-gnu_hash.1.patch --+MW5NjnblUaFJVG7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+K3ooACgkQC3+MBN1Mb4haUACg4ghZ+fyg8IWHKK3sU6Llffod fisAnjE/ACZRQ0QSrgc2qTXmS1ols5GA =lFUl -----END PGP SIGNATURE----- --+MW5NjnblUaFJVG7--