From owner-svn-ports-all@FreeBSD.ORG Sun Oct 7 00:19:11 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6C639106566C for ; Sun, 7 Oct 2012 00:19:11 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id E15B28FC14 for ; Sun, 7 Oct 2012 00:19:10 +0000 (UTC) Received: by mail-wg0-f50.google.com with SMTP id 16so2376846wgi.31 for ; Sat, 06 Oct 2012 17:19:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=l3H+ibppmWMOKPBe/w7lzUZf4TVJq0da86gu/4Eak4o=; b=i+AxNI8r8qAaFvl892SYs6dh+wmgjBeYyxa+25mnJkbh8E4pgZ2aj0vIuApLOVhiSH qYz2saGnMSTVzru5gT5o7hdjuLaIAqNR1QaM6sCBfSD19tc+Abajj3lZtohZgiQeeryg a+gkGDmU9Bc4G+KKP8QWL2CEgoGt7mdduOvoN/cMNTNY1OCNEb5bhwVEvRNlGT4QcpAW oqopPmwD0OJ5GJYvABBipwvegc8XK1Y08RGjuIxSWPGZdPUZ8Nni+nFgY7dqrkgA28ZU XXUuH6OZNdrh1E86QggwWkKN2crKuX+BW2Xd/++eGb4Q9NXo1LAEwwUp2yXP38hrqxtz 03Ig== MIME-Version: 1.0 Received: by 10.180.91.169 with SMTP id cf9mr11793518wib.1.1349569149317; Sat, 06 Oct 2012 17:19:09 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.194.81.136 with HTTP; Sat, 6 Oct 2012 17:19:09 -0700 (PDT) In-Reply-To: <5070B355.1000802@FreeBSD.org> References: <201210060537.q965bUpk005984@svn.freebsd.org> <5070A09B.1090404@FreeBSD.org> <5070B0F0.6080404@FreeBSD.org> <5070B355.1000802@FreeBSD.org> Date: Sat, 6 Oct 2012 17:19:09 -0700 X-Google-Sender-Auth: HPajjUUvSMW_MAFVzod-C6xfdgQ Message-ID: From: Jason Helfman To: Doug Barton X-Gm-Message-State: ALoCoQlOI2u46v6m2cD9jb/Qw8k7ypeXlUGOhFoyuZzXZX/2T8Yet7rvFhRZfUOB1aZq0AjE2V0E Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, nemysis@gmx.ch, ports-committers@freebsd.org Subject: Re: svn commit: r305338 - in head/games/pycadia: . files X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 00:19:11 -0000 On Sat, Oct 6, 2012 at 3:40 PM, Doug Barton wrote: > On 10/06/2012 15:34, Jason Helfman wrote: > > On Sat, Oct 6, 2012 at 3:30 PM, Doug Barton > > wrote: > > > > On 10/06/2012 15:25, Jason Helfman wrote: > > > On Sat, Oct 6, 2012 at 2:20 PM, Doug Barton > > > > >> wrote: > > > > > > On 10/05/2012 22:37, Jason Helfman wrote: > > > > Added: head/games/pycadia/files/pycadia.sh.in > > > > > > > > > > > > ============================================================================== > > > > --- /dev/null 00:00:00 1970 (empty, because file is newly > > added) > > > > +++ head/games/pycadia/files/pycadia.sh.in > > > > > Sat Oct 6 05:37:29 2012 (r305338) > > > > @@ -0,0 +1,6 @@ > > > > +#!/bin/sh > > > > +# > > > > +# $FreeBSD$ > > > > + > > > > +cd "%%DATADIR%%" > > > > +./pycadia.py > > > > > > Unless there is some reason to cd into that directory, you'd > > be better > > > off with just: %%DATADIR%%/pycadia.py > > > > > > And in any case, shouldn't you be using exec here? > > > > > > > > > I can check with the maintainer, but it does need to be run from > the > > > DATADIR specifically. > > > > Ok, that's not a problem. A comment to that effect would probably be > > useful for future reference. > > > > > > > What would exec provide that isn't currently fulfilled? > > > > Eliminating the shell. > > > > Fair enough. I can discuss with maintainer, as he has many ports that do > > this. I would suggest using %%PYTHON_CMD%% in favor of exec. Do you see > > an issue with that? > > Yes, unless %%PYTHON_CMD%% has some magic to eliminate the shell that > I'm not aware of. :) > > Try the existing command with and without exec and then look at your ps > output to see my point. > > Doug > Currently I'm not aware of a method to eliminate the shell within a shell script. Had I realized this was such an issue I would've sent mail requesting a review. %%PYTHON_CMD%% become /usr/local/bin/pythonXX -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve