From owner-svn-src-projects@FreeBSD.ORG Fri Oct 19 09:14:19 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EA96E15A for ; Fri, 19 Oct 2012 09:14:19 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 43F6C8FC0C for ; Fri, 19 Oct 2012 09:14:18 +0000 (UTC) Received: (qmail 29852 invoked from network); 19 Oct 2012 10:52:58 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Oct 2012 10:52:58 -0000 Message-ID: <508119DE.6020106@freebsd.org> Date: Fri, 19 Oct 2012 11:14:06 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: John Baldwin Subject: Re: svn commit: r238907 - projects/calloutng/sys/kern References: <201207301350.q6UDobCI099069@svn.freebsd.org> <5056D078.3020904@freebsd.org> <201209171113.06861.jhb@freebsd.org> In-Reply-To: <201209171113.06861.jhb@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Davide Italiano , mlaier@freebsd.org, svn-src-projects@freebsd.org, attilio@freebsd.org, Konstantin Belousov , src-committers@freebsd.org, Stephan Uphoff X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Oct 2012 09:14:20 -0000 On 17.09.2012 17:13, John Baldwin wrote: > On Monday, September 17, 2012 3:25:44 am Andre Oppermann wrote: >> Hello Attilio, >> >> could you integrate and test this patch from Isilon as well: >> >> Add INVARIANT and WITNESS support to rm_lock locks and optimize the >> synchronization path by replacing a LIST of active readers with a >> TAILQ. >> >> Obtained from: Isilon >> Submitted by: mlaier >> >> http://svn.freebsd.org/changeset/base/234648 >> >> You're far deeper into locking than I am. > > Some of this is already in the tree, and their WITNESS changes don't quite > work correctly. I have several fixes (including some of these already) that I > am just waiting to develop a good test for. Having an _rm_assert() to pull > from will be good though. Any news/progress on this? -- Andre