From owner-freebsd-amd64@FreeBSD.ORG Sun Aug 11 11:20:00 2013 Return-Path: Delivered-To: freebsd-amd64@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D43C78EA for ; Sun, 11 Aug 2013 11:20:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9A5832063 for ; Sun, 11 Aug 2013 11:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r7BBK0jP083420 for ; Sun, 11 Aug 2013 11:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r7BBK0uA083419; Sun, 11 Aug 2013 11:20:00 GMT (envelope-from gnats) Resent-Date: Sun, 11 Aug 2013 11:20:00 GMT Resent-Message-Id: <201308111120.r7BBK0uA083419@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-amd64@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, shahar klein Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id D724D8B9 for ; Sun, 11 Aug 2013 11:15:00 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C57F92043 for ; Sun, 11 Aug 2013 11:15:00 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r7BBF0rm007206 for ; Sun, 11 Aug 2013 11:15:00 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r7BBF0A4007205; Sun, 11 Aug 2013 11:15:00 GMT (envelope-from nobody) Message-Id: <201308111115.r7BBF0A4007205@oldred.freebsd.org> Date: Sun, 11 Aug 2013 11:15:00 GMT From: shahar klein To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: amd64/181225: unloading ipoib crashes the kernel X-Mailman-Approved-At: Sun, 11 Aug 2013 11:26:11 +0000 X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2013 11:20:00 -0000 >Number: 181225 >Category: amd64 >Synopsis: unloading ipoib crashes the kernel >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-amd64 >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 11 11:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: shahar klein >Release: 9.1 >Organization: Mellanox >Environment: FreeBSD 9.1-RELEASE #0 r+95f2241: Mon Jul 15 16:48:47 IDT 2013 .../sys/GENERIC amd64 >Description: When an ipoib interface is up - unloading the ipoib module crashes the kernel >How-To-Repeat: bring up a ipoib interface with an IP and unload the ipoib module >Fix: a/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c b/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c index abed7fa..f4e6706 100644 --- a/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c @@ -1073,6 +1073,8 @@ ipoib_remove_one(struct ib_device *device) if (rdma_port_get_link_layer(device, priv->port) != IB_LINK_LAYER_INFINIBAND) continue; + ipoib_stop(priv); + ib_unregister_event_handler(&priv->event_handler); /* dev_change_flags(priv->dev, priv->dev->flags & ~IFF_UP); */ >Release-Note: >Audit-Trail: >Unformatted: