From owner-freebsd-arch@FreeBSD.ORG  Sun Feb 24 06:06:00 2013
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id B9A33693
 for <freebsd-arch@freebsd.org>; Sun, 24 Feb 2013 06:06:00 +0000 (UTC)
 (envelope-from christoph.mallon@gmx.de)
Received: from mout.gmx.net (mout.gmx.net [212.227.15.19])
 by mx1.freebsd.org (Postfix) with ESMTP id 59E661665
 for <freebsd-arch@freebsd.org>; Sun, 24 Feb 2013 06:06:00 +0000 (UTC)
Received: from mailout-de.gmx.net ([10.1.76.1]) by mrigmx.server.lan
 (mrigmx001) with ESMTP (Nemesis) id 0MBYz2-1U2JBx1Rqg-00AUD2 for
 <freebsd-arch@FreeBSD.org>; Sun, 24 Feb 2013 07:05:59 +0100
Received: (qmail invoked by alias); 24 Feb 2013 06:05:59 -0000
Received: from p5B132BDD.dip.t-dialin.net (EHLO rotluchs.lokal) [91.19.43.221]
 by mail.gmx.net (mp001) with SMTP; 24 Feb 2013 07:05:59 +0100
X-Authenticated: #1673122
X-Provags-ID: V01U2FsdGVkX19Fs7kJkilF/2zVKTg79YSo4pOtjpp1x8Ymf5WEQz
 kR8JlyNNR3ZiId
Message-ID: <5129ADC5.5040306@gmx.de>
Date: Sun, 24 Feb 2013 07:05:57 +0100
From: Christoph Mallon <christoph.mallon@gmx.de>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130222 Thunderbird/17.0.3
MIME-Version: 1.0
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Subject: Re: Large Capsicum patch for review.
References: <20130213025547.GA2025@garage.freebsd.pl>
 <20130213230221.GB1375@garage.freebsd.pl>
 <20130223221116.GR1377@garage.freebsd.pl>
In-Reply-To: <20130223221116.GR1377@garage.freebsd.pl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
Cc: freebsd-arch@FreeBSD.org
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Feb 2013 06:06:00 -0000

Hi.

On 23.02.2013 23:11, Pawel Jakub Dawidek wrote:
> On Thu, Feb 14, 2013 at 12:02:22AM +0100, Pawel Jakub Dawidek wrote:
>> I'd like to commit this patch:
>>
>> 	http://people.freebsd.org/~pjd/patches/capkern.diff
> 
> The patch was updated after the following changes and is available at
> the link above:

I was not able to apply this patch cleanly and had to fudge with the diff:
- Two diff headers (contrib/openbsm/etc/audit_event and lib/libc/gen/Makefile.inc) have an extra space after --- and +++, which is recognized as part of the filename.
  Was this patch manually altered?
- Two diffs (lib/libc/sys/cap_new.2 and sys/kern/uipc_mqueue.c) contain unexpanded $FreeBSD$ tags.
I also had to guess, that the patch is to be applied onto r247201.
I placed a cleaned up patch at http://tron.homeunix.org/zeug/FreeBSD/capsicum/0001-Capsicum-update.patch.

This is a really big patch bomb changing lots of unrelated things.
Do you have smaller, more managable diffs for easier review?

I started reading the patch and found some minor glitches, e.g. mode in cap_sandboxed() should be u_int, not int.
I will report more later.

	Christoph