From owner-freebsd-arch@FreeBSD.ORG Sun Mar 3 13:02:55 2013 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 583D6980 for ; Sun, 3 Mar 2013 13:02:55 +0000 (UTC) (envelope-from christoph.mallon@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by mx1.freebsd.org (Postfix) with ESMTP id E83116A5 for ; Sun, 3 Mar 2013 13:02:54 +0000 (UTC) Received: from mailout-de.gmx.net ([10.1.76.31]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0LjP2f-1UnwYR0gn9-00dTHf for ; Sun, 03 Mar 2013 14:02:48 +0100 Received: (qmail invoked by alias); 03 Mar 2013 13:02:48 -0000 Received: from p5B131D04.dip.t-dialin.net (EHLO rotluchs.lokal) [91.19.29.4] by mail.gmx.net (mp031) with SMTP; 03 Mar 2013 14:02:48 +0100 X-Authenticated: #1673122 X-Provags-ID: V01U2FsdGVkX1+xUA0TN5Sx2Juq/hdValqeutidDUHtDmcOKVkig+ d8Yw6vnSMh/gcx Message-ID: <513349F6.4010309@gmx.de> Date: Sun, 03 Mar 2013 14:02:46 +0100 From: Christoph Mallon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130222 Thunderbird/17.0.3 MIME-Version: 1.0 To: freebsd-arch@freebsd.org Subject: Re: Proposal: Unify printing the function name in panic messages() References: <51141E33.4080103@gmx.de> In-Reply-To: <51141E33.4080103@gmx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Cc: Kirk McKusick X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Mar 2013 13:02:55 -0000 Hi, here's an updated patch series, which replaces all panic() calls, except for the places, which have their own stuff, like sys/boot/: http://tron.homeunix.org/zeug/FreeBSD/panic/ For now, PANIC() prints the function name. This is the most common location information used by panic() users. It can easily be changed in sys/systm.h, where the macro PANIC() is defined. I added the option PANIC_LOCATION. I would like to enable it by default, so it has to be deactivated explicitly. How can this be achieved? Please test this stuff. Christoph