From owner-freebsd-arm@FreeBSD.ORG Sun Jun 2 05:50:04 2013 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 565E9BDE for ; Sun, 2 Jun 2013 05:50:04 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ie0-x22b.google.com (mail-ie0-x22b.google.com [IPv6:2607:f8b0:4001:c03::22b]) by mx1.freebsd.org (Postfix) with ESMTP id 2A41118AF for ; Sun, 2 Jun 2013 05:50:04 +0000 (UTC) Received: by mail-ie0-f171.google.com with SMTP id s9so7675606iec.16 for ; Sat, 01 Jun 2013 22:50:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer :x-gm-message-state; bh=t6nGvmveCKfstMcmNvyZtVtolM2J8vzpibvGUoWHKg8=; b=YA1HMJASDqLLlTRmh4DWLY0xwVLiTsnFQUyKk2a+TM39Qa1q1FzygrJoyWdzqxFA9p QNC0DXheXcBURoZy1T+F3xoD+r7GjWqZ1C+aFXpG/0UCK2DzzBSxeJjwFSKhRew5tuia X9KHmgdTEhAhBlTWqmVlM9KREjYkcS17ghT/Z6CrVqmldMJk6qYNVinr8X0Zn3ccXykw +YOYzwNMU3FcPsmGp7sZJ24nl2Cu/Zc59nECVixnMzXBnXs6XDQKS+XGbZ2ItFH8NCu8 6aI2dbUyRrnss1vqW8QcDpY1+2f88ADudRvBn9ra3T6ooA5xDa+NWsqgUwprkUiDY3fB T4XQ== X-Received: by 10.50.120.4 with SMTP id ky4mr4888015igb.86.1370152203700; Sat, 01 Jun 2013 22:50:03 -0700 (PDT) Received: from 53.imp.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id r20sm12262715ign.8.2013.06.01.22.50.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 01 Jun 2013 22:50:02 -0700 (PDT) Sender: Warner Losh Subject: Re: Updating setjmp/longjmp Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <20130601201253.47daf4a1@bender.Home> Date: Sat, 1 Jun 2013 23:50:00 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <104894B0-F9B5-490C-A0D8-6D2732BAFCE0@bsdimp.com> References: <20130601201253.47daf4a1@bender.Home> To: Andrew Turner X-Mailer: Apple Mail (2.1085) X-Gm-Message-State: ALoCoQmCxgRqL1aXdFPVJEl3QoxWdFg28ju5MHQUJuDymYbvr9V8XU+NvrlYXZZeX7CJ9s5KleSP Cc: freebsd-arm@freebsd.org X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jun 2013 05:50:04 -0000 On Jun 1, 2013, at 1:12 PM, Andrew Turner wrote: > Hello, >=20 > I'm updating the setjmp/longjmp functions on ARM to reduce the diff to > NetBSD and to store the VFP registers when they are available. >=20 > As part of this I will be removeing support for storing the FPA > (floating point accelerator) registers. Does anyone have any = objections > to this? >=20 > The first patch is at [1]. It updates > out code to remove the FPA support but doesn't yet add the VFP as that > will require other libc changes. >=20 > (If you don't know what the FPA is this patch probably doesn't affect > you, it was an old floating-point device in only a few chips. Modern > CPUs use a different piece of hardware for floating point operations.) Did we ever support this? Or were they used only for the floating point = emulator that NetBSD had in their tree for a while, but that I don't = think ever made it into ours since softfloat is faster.... > Andrew >=20 > [1] http://people.freebsd.org/~andrew/arm_setjmp.diff This looks OK to the limit of my arm assembler knowledge, but why the = switch from r3 to ip in longjmp? Also, what's the difference between setjmp and_setgjmp? It's just saving = the signal mask... Is there any benefit to merging? The meat of the = functions are tiny, but there's all that boilerplate... Warner Warner